@jesdi/skills 0.0.19 → 0.0.20
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -18,7 +18,7 @@ Read `git diff <range>` in full, then only the surrounding code a check needs
|
|
|
18
18
|
| N+1 | One query per loop iteration where a join or `IN (…)` would do. |
|
|
19
19
|
| Migrations | Not reversible, or unsafe on a live table (a NOT NULL column without a default, a rewrite under lock). |
|
|
20
20
|
| Failure paths | A payment-provider, checkout or stock-decrement call whose failure (timeout, decline, provider error) is unhandled or silently swallowed. |
|
|
21
|
-
| Test quality | Tautological tests (asserting a mock's return value, or a value the test just set with no code in between) and tests on internals instead of the public seam. Say what they should assert. |
|
|
21
|
+
| Test quality | Tautological tests (asserting a mock's return value, or a value the test just set with no code in between) and tests on internals instead of the public seam. Unreadable tests, which protect nothing because nobody can tell what they guarantee: a name that doesn't state the behavior, one test asserting several behaviors, logic in the test (`if`, loops), setup that hides what the test depends on, fixtures shared and mutated across tests. Say what they should assert, or how to split them. |
|
|
22
22
|
|
|
23
23
|
Every finding: `file:line`, the concrete failure scenario (inputs or
|
|
24
24
|
interleaving → wrong result), and the fix. "Consider reviewing" is not a
|
package/skills-manifest.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"schemaVersion": 1,
|
|
3
|
-
"generatedAt": "2026-09-24T15:
|
|
3
|
+
"generatedAt": "2026-09-24T15:47:23.496Z",
|
|
4
4
|
"skills": [
|
|
5
5
|
{
|
|
6
6
|
"name": "backlog",
|
|
@@ -70,8 +70,8 @@
|
|
|
70
70
|
},
|
|
71
71
|
{
|
|
72
72
|
"name": "review-diff",
|
|
73
|
-
"version": "0.1.
|
|
74
|
-
"hash": "sha256-
|
|
73
|
+
"version": "0.1.1",
|
|
74
|
+
"hash": "sha256-ac4b526f0436f06acc4e5e2254b83b5318a14065caab3f922f20fa7da9e87c5f",
|
|
75
75
|
"description": "Review a branch before merge: first a gate (the repo's check command plus crap-gate), then three independent reviewers in parallel — spec (did we build what was asked, no more, no less), correctness via Codex (races, idempotency, money, time, authz, indexes, N+1, migrations, error paths, test quality) and structure (deep-quality-review). `--quick` runs only spec and correctness, shortened, for a live interview. Use when the user says \"/review-diff\", \"review this branch\", \"review this slice\", \"review before merge\", or before closing out a spec task."
|
|
76
76
|
},
|
|
77
77
|
{
|