@jeroenpol/eslint-config 1.0.1 → 1.0.3

package/.eslintrc

@@ -1,5 +1,4 @@
 {
-  "files": ["*.ts", "*.tsx"],
   "parser": "@typescript-eslint/parser",
   "extends": "./index.js",
   "rules": {}

package/configuration/best-practices.js

@@ -3,28 +3,24 @@ module.exports = {
     {
       files: ['*.ts', '*.tsx'],
       parser: '@typescript-eslint/parser',
-      plugins: ['@typescript-eslint', 'rxjs-angular', 'sonarjs', 'redundant-undefined'],
+      parserOptions: {
+        ecmaVersion: 2020,
+        sourceType: 'module',
+      },
+      plugins: ['@typescript-eslint', 'rxjs-angular', 'sonarjs'],
       rules: {
         // Code complexity rules
-        'max-depth': ['error', 3], // Goal value: 2
-        'max-nested-callbacks': ['error', 5], // Goal value: 2-3
-        'max-statements-per-line': ['error', { max: 1 }],
-        complexity: ['error', { max: 8 }], // GOAL VALUE: 7
-        'sonarjs/cognitive-complexity': ['error', 10], // GOAL VALUE: 6
+        'max-depth': ['error', 8], // Goal value: 2
+        'max-nested-callbacks': ['error', 8], // Goal value: 2-3
+        "max-statements-per-line": ['error', { "max": 1 }],
+        'complexity': ['error', { max: 15 }], // GOAL VALUE: 7
+        'sonarjs/cognitive-complexity': ['error', 15], // GOAL VALUE: 6
 
         // Prevent code smells
-        'max-lines-per-function': ['error', { max: 60, skipBlankLines: true, skipComments: true }], // Goal value: 40
+        'max-lines-per-function': ['error', { 'max': 60, 'skipBlankLines': true, 'skipComments': true }], // Goal value: 40
         'max-statements': ['error', 20], // Goal value: 16-18?
         'sonarjs/max-switch-cases': ['error', 10],
         'sonarjs/no-nested-switch': 'error',
-        'default-case-last': 'error',
-        'default-param-last': 'error',
-        'sonarjs/no-small-switch': 'error',
-        'sonarjs/no-identical-functions': 'error',
-        'sonarjs/no-redundant-jump': 'error',
-        'no-empty-function': ['error', { allow: ['constructors'] }],
-        'redundant-undefined/redundant-undefined': 'error',
-        "@typescript-eslint/no-unnecessary-type-assertion": "error",
 
         // Prevent accidental bugs
         'no-param-reassign': 'error',
@@ -41,7 +37,7 @@ module.exports = {
         '@typescript-eslint/no-non-null-assertion': 'error',
 
         // Type safety
-        '@typescript-eslint/no-explicit-any': 'error',
+        '@typescript-eslint/no-explicit-any': 'warn', // TODO: set to error
         '@typescript-eslint/explicit-function-return-type': ['error', { allowHigherOrderFunctions: true }],
 
         // Disable JS features
@@ -49,6 +45,7 @@ module.exports = {
         'no-console': 'error',
 
         // Disabled ESLint rules
+        '@typescript-eslint/array-type': 'off',
         '@typescript-eslint/interface-name-prefix': 'off',
         'max-classes-per-file': 'off',
         '@typescript-eslint/no-inferrable-types': 'off',
@@ -59,7 +56,6 @@ module.exports = {
 
         // Conventions
         'no-array-constructor': 'error',
-        '@typescript-eslint/array-type': 'error',
         'quote-props': ['warn', 'as-needed'],
         '@typescript-eslint/ban-types': [
           'error',
@@ -106,14 +102,14 @@ module.exports = {
         ],
 
         // Performance improvements + preventing memory leaks
-        'rxjs-angular/prefer-takeuntil': [
-          'error',
+        "rxjs-angular/prefer-takeuntil": [
+          "error",
           {
-            alias: ['untilDestroyed', 'takeUntilDestroyed'],
-            checkDecorators: ['Component'],
-            checkComplete: false,
-            checkDestroy: false,
-          },
+            "alias": ["untilDestroyed"],
+            "checkComplete": true,
+            "checkDecorators": ["Component"],
+            "checkDestroy": true
+          }
         ],
       },
     },

package/configuration/code-style.js

@@ -1,16 +1,16 @@
 module.exports = {
   rules: {
     '@typescript-eslint/explicit-member-accessibility': 'off',
-    '@angular-eslint/use-lifecycle-interface': ['error'],
-    '@angular-eslint/sort-lifecycle-methods': ['error'],
-    '@angular-eslint/no-lifecycle-call': ['error'],
-    '@angular-eslint/no-empty-lifecycle-method': ['error'],
-    '@angular-eslint/no-async-lifecycle-method': ['error'],
   },
   overrides: [
     {
       files: ['*.ts', '*.tsx'],
       parser: '@typescript-eslint/parser',
+      parserOptions: {
+        ecmaVersion: 2020,
+        sourceType: 'module',
+        project: './tsconfig.json', 
+      },
       plugins: ['@typescript-eslint', 'simple-import-sort', 'unused-imports'],
       rules: {
         'array-bracket-newline': ['warn', 'consistent'],
@@ -35,14 +35,14 @@ module.exports = {
         curly: ['warn', 'all'],
         'dot-location': ['warn', 'property'],
         'eol-last': 'warn',
-        '@typescript-eslint/func-call-spacing': 'error',
+        'func-call-spacing': 'warn',
         'function-call-argument-newline': ['warn', 'consistent'],
         'function-paren-newline': ['warn', 'multiline-arguments'],
         'generator-star-spacing': 'off',
         'implicit-arrow-linebreak': 'off',
         indent: 'off',
         '@typescript-eslint/indent': [
-          'error',
+          'warn',
           2,
           {
             SwitchCase: 1,
@@ -57,7 +57,7 @@ module.exports = {
 
         'keyword-spacing': 'off', // overridden by @typescript-eslint
         '@typescript-eslint/keyword-spacing': ['warn', { after: true, before: true }],
-        '@typescript-eslint/type-annotation-spacing': 'warn',
+
         'linebreak-style': 'off',
         'max-len': [
           'error',
@@ -81,18 +81,18 @@ module.exports = {
         'no-mixed-operators': ['error'],
         'no-mixed-spaces-and-tabs': 'error',
         'no-multi-spaces': 'error',
-        'no-multiple-empty-lines': ['warn', { max: 1, maxEOF: 0, maxBOF: 0 }], // overwritten NG default
+        'no-multiple-empty-lines': ['warn', { max: 1 }], // overwritten NG default
         'no-tabs': 'error',
         'no-trailing-spaces': 'warn',
         'no-unexpected-multiline': 'error',
-        'no-unused-vars': 'off', // off: conflict unused-imports/no-unused-vars
-        '@typescript-eslint/no-unused-vars': 'off', // off: conflict unused-imports/no-unused-vars
-        'unused-imports/no-unused-imports': 'error',
-        'unused-imports/no-unused-vars': [
-          'error',
-          { vars: 'all', varsIgnorePattern: '^_', args: 'after-used', argsIgnorePattern: '^_' },
+
+        "@typescript-eslint/no-unused-vars": "off",
+		    "unused-imports/no-unused-imports": "error",
+		    "unused-imports/no-unused-vars": [
+          "warn",
+          { "vars": "all", "varsIgnorePattern": "^_", "args": "after-used", "argsIgnorePattern": "^_" }
         ],
-        'no-duplicate-imports': 'error',
+        'no-duplicate-imports': 'warn',
 
         'no-useless-constructor': 'off', // overridden by @typescript-eslint
         '@typescript-eslint/no-useless-constructor': ['error'],
@@ -122,7 +122,6 @@ module.exports = {
         'space-before-function-paren': ['warn', { anonymous: 'always', named: 'never', asyncArrow: 'always' }],
         'space-in-parens': 'warn',
         'space-infix-ops': 'warn',
-        '@typescript-eslint/space-infix-ops': 'warn',
         'space-unary-ops': 'warn',
         'switch-colon-spacing': 'warn',
         'template-curly-spacing': 'warn',
@@ -132,9 +131,8 @@ module.exports = {
         'yield-star-spacing': 'error',
         'no-unused-expressions': 'error',
         'prefer-const': 'error',
-        'id-length': ['error', { min: 2, properties: 'never', exceptions: ['i', 'e', 'a', 'b', 'x', 'y', '_'] }], // TODO: remove some of these exceptions
         '@typescript-eslint/no-parameter-properties': 'off',
-        '@typescript-eslint/member-ordering': ['error'],
+        '@typescript-eslint/member-ordering': ['warn'],
         '@typescript-eslint/explicit-member-accessibility': [
           'error',
           {

package/configuration/imports.js

@@ -6,6 +6,7 @@ module.exports = {
       parserOptions: {
         ecmaVersion: 2020,
         sourceType: 'module',
+        project: './tsconfig.json',
       },
       plugins: ['@typescript-eslint', 'simple-import-sort'],
       rules: {
@@ -14,7 +15,6 @@ module.exports = {
         'simple-import-sort/exports': 'error',
         'sort-imports': 'off',
         'import/order': 'off',
-        '@typescript-eslint/no-require-imports': 'error',
         'no-restricted-imports': [
           'error',
           {

package/index.js

@@ -4,6 +4,7 @@ module.exports = {
     './configuration/code-style.js',
     './configuration/imports.js',
   ].map(require.resolve),
+  parser: "@typescript-eslint/parser",
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: 'module',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jeroenpol/eslint-config",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "ES Lint config made for Angular, configured by Polware",
   "main": "index.js",
   "exports": {
@@ -47,11 +47,23 @@
     "eslint-plugin-sonarjs": "1.0.3",
     "eslint-plugin-unused-imports": "3.2.0",
     "@typescript-eslint/eslint-plugin": "6.19.0",
-    "@typescript-eslint/parser": "^6.19.0"
+    "@typescript-eslint/parser": "^6.19.0",
+    "typescript": "~5.4.5",
+    "typescript-eslint": "^7.16.1"
   },
   "peerDependencies": {
     "eslint": "8.57.0",
-    "eslint-plugin-import": "^2.29.1"
+    "eslint-config-prettier": "9.1.0",
+    "eslint-plugin-functional": "6.5.1",
+    "eslint-plugin-redundant-undefined": "^1.0.0",
+    "eslint-plugin-rxjs-angular": "2.0.1",
+    "eslint-plugin-simple-import-sort": "10.0.0",
+    "eslint-plugin-sonarjs": "1.0.3",
+    "eslint-plugin-unused-imports": "3.2.0",
+    "@typescript-eslint/eslint-plugin": "6.19.0",
+    "@typescript-eslint/parser": "^6.19.0",
+    "typescript": "~5.4.5",
+    "typescript-eslint": "^7.16.1"
   },
   "engines": {
     "node": "20"

package/tsconfig.json

@@ -0,0 +1,18 @@
+{
+  "compileOnSave": false,
+  "compilerOptions": {
+    "baseUrl": ".",
+    "outDir": "./dist/out-tsc",
+    "sourceMap": true,
+    "declaration": false,
+    "downlevelIteration": true,
+    "experimentalDecorators": true,
+    "module": "esnext",
+    "moduleResolution": "node",
+    "importHelpers": true,
+    "target": "ES2022",
+    "typeRoots": ["node_modules/@types"],
+    "lib": ["es2018", "dom"],
+    "useDefineForClassFields": false
+  }
+}