@jeroenpol/eslint-config 1.0.0 → 1.0.1

package/.eslintrc

@@ -0,0 +1,6 @@
+{
+  "files": ["*.ts", "*.tsx"],
+  "parser": "@typescript-eslint/parser",
+  "extends": "./index.js",
+  "rules": {}
+}

package/CHANGELOG.md

@@ -0,0 +1,3 @@
+1.0.0 / 2024-08-07
+==================
+ - [major] Release

package/LICENSE.md

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2012 Airbnb
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -0,0 +1,25 @@
+# polware eslint-config <sup>[![Version Badge][npm-version-svg]][package-url]</sup>
+
+[![npm version](https://badge.fury.io/js/eslint-config-airbnb-base.svg)][package-url]
+
+## Usage
+
+Use this esLint config as a basis for you Angular projects.
+
+### Installation
+
+  ```sh
+  npm i --save-dev jeroenpol/eslint-config
+```
+
+1. Install the correct versions of each package, which are listed by the command:
+
+  ```sh
+  npm info "jeroenpol/eslint-config@latest" peerDependencies
+  ```
+
+  If using **npm 5+**, use this shortcut
+
+  ```sh
+  npx install-peerdeps --dev polware/eslint-config
+  ```

package/{config → configuration}/best-practices.js

@@ -3,25 +3,28 @@ module.exports = {
     {
       files: ['*.ts', '*.tsx'],
       parser: '@typescript-eslint/parser',
-      parserOptions: {
-        ecmaVersion: 2020,
-        sourceType: 'module',
-        project: './tsconfig.*json',
-      },
-      plugins: ['@typescript-eslint', 'rxjs-angular', 'sonarjs'],
+      plugins: ['@typescript-eslint', 'rxjs-angular', 'sonarjs', 'redundant-undefined'],
       rules: {
         // Code complexity rules
         'max-depth': ['error', 3], // Goal value: 2
         'max-nested-callbacks': ['error', 5], // Goal value: 2-3
-        "max-statements-per-line": ['error', { "max": 1 }],
-        'complexity': ['error', { max: 8 }], // GOAL VALUE: 7
+        'max-statements-per-line': ['error', { max: 1 }],
+        complexity: ['error', { max: 8 }], // GOAL VALUE: 7
         'sonarjs/cognitive-complexity': ['error', 10], // GOAL VALUE: 6
 
         // Prevent code smells
-        'max-lines-per-function': ['error', {'max': 60, 'skipBlankLines': true, 'skipComments': true}], // Goal value: 40
+        'max-lines-per-function': ['error', { max: 60, skipBlankLines: true, skipComments: true }], // Goal value: 40
         'max-statements': ['error', 20], // Goal value: 16-18?
         'sonarjs/max-switch-cases': ['error', 10],
         'sonarjs/no-nested-switch': 'error',
+        'default-case-last': 'error',
+        'default-param-last': 'error',
+        'sonarjs/no-small-switch': 'error',
+        'sonarjs/no-identical-functions': 'error',
+        'sonarjs/no-redundant-jump': 'error',
+        'no-empty-function': ['error', { allow: ['constructors'] }],
+        'redundant-undefined/redundant-undefined': 'error',
+        "@typescript-eslint/no-unnecessary-type-assertion": "error",
 
         // Prevent accidental bugs
         'no-param-reassign': 'error',
@@ -38,7 +41,7 @@ module.exports = {
         '@typescript-eslint/no-non-null-assertion': 'error',
 
         // Type safety
-        '@typescript-eslint/no-explicit-any': 'warn', // TODO: set to error
+        '@typescript-eslint/no-explicit-any': 'error',
         '@typescript-eslint/explicit-function-return-type': ['error', { allowHigherOrderFunctions: true }],
 
         // Disable JS features
@@ -46,7 +49,6 @@ module.exports = {
         'no-console': 'error',
 
         // Disabled ESLint rules
-        '@typescript-eslint/array-type': 'off',
         '@typescript-eslint/interface-name-prefix': 'off',
         'max-classes-per-file': 'off',
         '@typescript-eslint/no-inferrable-types': 'off',
@@ -57,6 +59,7 @@ module.exports = {
 
         // Conventions
         'no-array-constructor': 'error',
+        '@typescript-eslint/array-type': 'error',
         'quote-props': ['warn', 'as-needed'],
         '@typescript-eslint/ban-types': [
           'error',
@@ -103,14 +106,14 @@ module.exports = {
         ],
 
         // Performance improvements + preventing memory leaks
-        "rxjs-angular/prefer-takeuntil": [
-          "error",
+        'rxjs-angular/prefer-takeuntil': [
+          'error',
           {
-            "alias": ["untilDestroyed"],
-            "checkComplete": true,
-            "checkDecorators": ["Component"],
-            "checkDestroy": true
-          }
+            alias: ['untilDestroyed', 'takeUntilDestroyed'],
+            checkDecorators: ['Component'],
+            checkComplete: false,
+            checkDestroy: false,
+          },
         ],
       },
     },

package/{config → configuration}/code-style.js

@@ -1,16 +1,16 @@
 module.exports = {
   rules: {
     '@typescript-eslint/explicit-member-accessibility': 'off',
+    '@angular-eslint/use-lifecycle-interface': ['error'],
+    '@angular-eslint/sort-lifecycle-methods': ['error'],
+    '@angular-eslint/no-lifecycle-call': ['error'],
+    '@angular-eslint/no-empty-lifecycle-method': ['error'],
+    '@angular-eslint/no-async-lifecycle-method': ['error'],
   },
   overrides: [
     {
       files: ['*.ts', '*.tsx'],
       parser: '@typescript-eslint/parser',
-      parserOptions: {
-        ecmaVersion: 2020,
-        sourceType: 'module',
-        project: './tsconfig.*json',
-      },
       plugins: ['@typescript-eslint', 'simple-import-sort', 'unused-imports'],
       rules: {
         'array-bracket-newline': ['warn', 'consistent'],
@@ -35,14 +35,14 @@ module.exports = {
         curly: ['warn', 'all'],
         'dot-location': ['warn', 'property'],
         'eol-last': 'warn',
-        'func-call-spacing': 'warn',
+        '@typescript-eslint/func-call-spacing': 'error',
         'function-call-argument-newline': ['warn', 'consistent'],
         'function-paren-newline': ['warn', 'multiline-arguments'],
         'generator-star-spacing': 'off',
         'implicit-arrow-linebreak': 'off',
         indent: 'off',
         '@typescript-eslint/indent': [
-          'warn',
+          'error',
           2,
           {
             SwitchCase: 1,
@@ -57,7 +57,7 @@ module.exports = {
 
         'keyword-spacing': 'off', // overridden by @typescript-eslint
         '@typescript-eslint/keyword-spacing': ['warn', { after: true, before: true }],
-
+        '@typescript-eslint/type-annotation-spacing': 'warn',
         'linebreak-style': 'off',
         'max-len': [
           'error',
@@ -81,18 +81,18 @@ module.exports = {
         'no-mixed-operators': ['error'],
         'no-mixed-spaces-and-tabs': 'error',
         'no-multi-spaces': 'error',
-        'no-multiple-empty-lines': ['warn', { max: 1 }], // overwritten NG default
+        'no-multiple-empty-lines': ['warn', { max: 1, maxEOF: 0, maxBOF: 0 }], // overwritten NG default
         'no-tabs': 'error',
         'no-trailing-spaces': 'warn',
         'no-unexpected-multiline': 'error',
-
-        "@typescript-eslint/no-unused-vars": "off",
-		    "unused-imports/no-unused-imports": "error",
-		    "unused-imports/no-unused-vars": [
-          "warn",
-          { "vars": "all", "varsIgnorePattern": "^_", "args": "after-used", "argsIgnorePattern": "^_" }
+        'no-unused-vars': 'off', // off: conflict unused-imports/no-unused-vars
+        '@typescript-eslint/no-unused-vars': 'off', // off: conflict unused-imports/no-unused-vars
+        'unused-imports/no-unused-imports': 'error',
+        'unused-imports/no-unused-vars': [
+          'error',
+          { vars: 'all', varsIgnorePattern: '^_', args: 'after-used', argsIgnorePattern: '^_' },
         ],
-        'no-duplicate-imports': 'warn',
+        'no-duplicate-imports': 'error',
 
         'no-useless-constructor': 'off', // overridden by @typescript-eslint
         '@typescript-eslint/no-useless-constructor': ['error'],
@@ -122,6 +122,7 @@ module.exports = {
         'space-before-function-paren': ['warn', { anonymous: 'always', named: 'never', asyncArrow: 'always' }],
         'space-in-parens': 'warn',
         'space-infix-ops': 'warn',
+        '@typescript-eslint/space-infix-ops': 'warn',
         'space-unary-ops': 'warn',
         'switch-colon-spacing': 'warn',
         'template-curly-spacing': 'warn',
@@ -131,9 +132,9 @@ module.exports = {
         'yield-star-spacing': 'error',
         'no-unused-expressions': 'error',
         'prefer-const': 'error',
-        'id-length': ['error',  { 'min': 2, 'properties': 'never', 'exceptions': ['i', 'e', 'a', 'b', '_'] }], // TODO: remove some of these exceptions
+        'id-length': ['error', { min: 2, properties: 'never', exceptions: ['i', 'e', 'a', 'b', 'x', 'y', '_'] }], // TODO: remove some of these exceptions
         '@typescript-eslint/no-parameter-properties': 'off',
-        '@typescript-eslint/member-ordering': ['warn'],
+        '@typescript-eslint/member-ordering': ['error'],
         '@typescript-eslint/explicit-member-accessibility': [
           'error',
           {

package/{config → configuration}/imports.js

@@ -6,7 +6,6 @@ module.exports = {
       parserOptions: {
         ecmaVersion: 2020,
         sourceType: 'module',
-        project: './tsconfig.*json',
       },
       plugins: ['@typescript-eslint', 'simple-import-sort'],
       rules: {
@@ -15,6 +14,7 @@ module.exports = {
         'simple-import-sort/exports': 'error',
         'sort-imports': 'off',
         'import/order': 'off',
+        '@typescript-eslint/no-require-imports': 'error',
         'no-restricted-imports': [
           'error',
           {

package/index.js

@@ -1 +1,12 @@
-module.exports = require('./.eslintrc.json')
+module.exports = {
+  extends: [
+    './configuration/best-practices.js',
+    './configuration/code-style.js',
+    './configuration/imports.js',
+  ].map(require.resolve),
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module',
+  },
+  rules: {},
+};

package/package.json

@@ -1,71 +1,62 @@
 {
   "name": "@jeroenpol/eslint-config",
-  "version": "1.0.0",
-  "description": "eslint-config as configured by Jeroen Pol",
+  "version": "1.0.1",
+  "description": "ES Lint config made for Angular, configured by Polware",
   "main": "index.js",
-  "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+  "exports": {
+    ".": "./index.js",
+    "./configuration/best-practices": "./configuration/best-practices.js",
+    "./configuration/code-style": "./configuration/code-style.js",
+    "./configuration/imports": "./configuration/imports.js",
+    "./package.json": "./package.json"
   },
+  "scripts": {},
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/jeroenpol/eslint-config.git"
+    "url": "https://github.com/airbnb/javascript"
   },
   "keywords": [
-    "JavaScript Standard Style",
-    "check",
-    "checker",
-    "code",
-    "code checker",
-    "code linter",
-    "code standards",
-    "code style",
-    "enforce",
     "eslint",
     "eslintconfig",
-    "hint",
-    "jscs",
-    "jshint",
-    "lint",
-    "eslint",
-    "es-lint",
-    "policy",
-    "quality",
-    "simple",
-    "standard",
-    "standard style",
-    "style",
-    "style checker",
-    "style linter",
-    "verify",
-    "TypeScript"
+    "config",
+    "javascript",
+    "typescript",
+    "angular",
+    "styleguide",
+    "polware"
+  ],
+  "author": "Jeroen Pol (https://www.linkedin.com/in/jeroenpol)",
+  "contributors": [
+    {
+      "name": "Jeroen Pol",
+      "url": "https://www.linkedin.com/in/jeroenpol"
+    }
   ],
-  "author": "Jeroen Pol",
-  "license": "ISC",
+  "license": "MIT",
   "bugs": {
-    "url": "https://github.com/jeroenpol/eslint-config/issues"
+    "url": "https://github.com/TOADD"
   },
-  "homepage": "https://github.com/jeroenpol/eslint-config#readme",
-  "dependencies": {
-    "@typescript-eslint/parser": "^5.43.0"
+  "homepage": "https://github.com/TOADD",
+  "devDependencies": {
+    "eslint": "8.57.0",
+    "eslint-config-prettier": "9.1.0",
+    "eslint-plugin-functional": "6.5.1",
+    "eslint-plugin-redundant-undefined": "^1.0.0",
+    "eslint-plugin-rxjs-angular": "2.0.1",
+    "eslint-plugin-simple-import-sort": "10.0.0",
+    "eslint-plugin-sonarjs": "1.0.3",
+    "eslint-plugin-unused-imports": "3.2.0",
+    "@typescript-eslint/eslint-plugin": "6.19.0",
+    "@typescript-eslint/parser": "^6.19.0"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.43.0",
-    "eslint": "^8.0.1",
-    "eslint-plugin-import": "^2.25.2",
-    "eslint-plugin-n": "^15.0.0",
-    "eslint-plugin-promise": "^6.0.0",
-    "typescript": "*"
+    "eslint": "8.57.0",
+    "eslint-plugin-import": "^2.29.1"
   },
-  "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.57.1",
-    "@typescript-eslint/parser": "^5.57.1",
-    "eslint": "^8.38.0",
-    "eslint-config-prettier": "^8.8.0",
-    "eslint-plugin-functional": "^5.0.7",
-    "eslint-plugin-rxjs-angular": "^2.0.0",
-    "eslint-plugin-simple-import-sort": "^10.0.0",
-    "eslint-plugin-sonarjs": "^0.19.0",
-    "eslint-plugin-unused-imports": "^2.0.0",
-    "typescript": "^5.0.4"
+  "engines": {
+    "node": "20"
+  },
+  "dependencies": {
+    "confusing-browser-globals": "^1.0.11"
   }
-}
+}