@jeffober/thatch 0.2.5 → 0.2.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +48 -25
- package/artifacts/skills/common.md +1 -0
- package/artifacts/skills/thatch-code-archaeology.md +9 -0
- package/artifacts/skills/thatch-code-review.md +16 -8
- package/artifacts/skills/thatch-plan-refinement.md +33 -4
- package/artifacts/skills/thatch-refine-personal.md +5 -0
- package/artifacts/skills/thatch-refine.md +7 -1
- package/artifacts/skills/thatch-review-context.md +55 -2
- package/artifacts/skills/thatch-review-followup.md +4 -4
- package/artifacts/skills/thatch-review-response.md +1 -1
- package/artifacts/skills/thatch-review-synthesizer.md +21 -1
- package/bin/thatch +21 -12
- package/docs/dev/README.md +11 -8
- package/docs/dev/features/README.md +1 -1
- package/docs/dev/features/behavior-engine.md +10 -0
- package/docs/dev/features/cli.md +2 -1
- package/docs/dev/features/commands.md +40 -9
- package/docs/dev/features/cross-session-chat.md +85 -21
- package/docs/dev/features/database.md +4 -4
- package/docs/dev/features/nudge-pipeline.md +14 -0
- package/docs/dev/features/opencode-plugin.md +41 -15
- package/docs/dev/features/prediction-engine.md +27 -1
- package/docs/dev/features/qa-system.md +19 -3
- package/docs/dev/features/session-lifecycle.md +6 -6
- package/docs/dev/features/session-tabs.md +11 -5
- package/docs/dev/gotchas.md +21 -0
- package/docs/dev/mcp-parity.md +3 -3
- package/docs/dev/skills.md +11 -8
- package/docs/user/README.md +19 -12
- package/docs/user/behavior-engine.md +7 -1
- package/docs/user/cli.md +2 -1
- package/docs/user/code-review.md +43 -2
- package/docs/user/commands.md +27 -7
- package/docs/user/cross-session-chat.md +47 -20
- package/docs/user/prediction-engine.md +12 -1
- package/docs/user/skills.md +8 -6
- package/package.json +1 -1
- package/src/capabilities.ts +20 -6
- package/src/chat.ts +39 -17
- package/src/commands.ts +109 -18
- package/src/db.ts +23 -2
- package/src/mcp.ts +6 -2
- package/src/opencode/tui-plugin.ts +29 -9
- package/src/opencode/v2.ts +247 -66
- package/src/prompts.ts +54 -6
- package/src/runtime.ts +122 -17
- package/src/scoring-engine.ts +40 -9
- package/src/session-tab-shared.ts +55 -4
- package/src/skills.ts +5 -9
- package/src/tab-state.ts +125 -0
- package/src/tool-defs.ts +42 -21
package/src/db.ts
CHANGED
|
@@ -60,9 +60,15 @@ export class ThatchDB {
|
|
|
60
60
|
#predictionsStore!: PredictionEngine;
|
|
61
61
|
#behaviorsStore!: BehaviorEngine;
|
|
62
62
|
#chatStore!: ChatStore;
|
|
63
|
+
// The open-tab provider for broadcast targeting (roster OPEN-vs-RECENT).
|
|
64
|
+
// Optional: unwired (tests, callers with no tab reader) means no tab
|
|
65
|
+
// signal, so every fresh opencode row degrades to RECENT - honest, never
|
|
66
|
+
// a false OPEN. Production callers wire chatOpenTabs(src/tab-state.ts).
|
|
67
|
+
#chatOpenTabs?: () => ReadonlySet<string>;
|
|
63
68
|
|
|
64
|
-
constructor(path: string) {
|
|
69
|
+
constructor(path: string, opts: { chatOpenTabs?: () => ReadonlySet<string> } = {}) {
|
|
65
70
|
this.#path = path;
|
|
71
|
+
this.#chatOpenTabs = opts.chatOpenTabs;
|
|
66
72
|
this.#open();
|
|
67
73
|
}
|
|
68
74
|
|
|
@@ -1086,7 +1092,22 @@ export class ThatchDB {
|
|
|
1086
1092
|
}
|
|
1087
1093
|
|
|
1088
1094
|
broadcastChatMessage(fromSession: string, body: string) {
|
|
1089
|
-
return this.#chat.broadcast(fromSession, body);
|
|
1095
|
+
return this.#chat.broadcast(fromSession, body, this.#chatOpenTabs?.());
|
|
1096
|
+
}
|
|
1097
|
+
|
|
1098
|
+
/**
|
|
1099
|
+
* Confirmed tab closes recorded by the roster (the session_tab tool's
|
|
1100
|
+
* bridge event). Readers subtract the fresh ones from the open-tab set
|
|
1101
|
+
* (effectiveOpenTabs) so a residue tabs.json row cannot read OPEN right
|
|
1102
|
+
* after a confirmed close.
|
|
1103
|
+
*/
|
|
1104
|
+
chatTabClosures(): { sessionID: string; at: string }[] {
|
|
1105
|
+
return this.runtimeStateAll()
|
|
1106
|
+
.filter((r) => r.kind === "chat_tab_closed")
|
|
1107
|
+
.flatMap((r) => {
|
|
1108
|
+
const at = (r.value as { at?: string } | null)?.at;
|
|
1109
|
+
return typeof at === "string" ? [{ sessionID: r.sessionID, at }] : [];
|
|
1110
|
+
});
|
|
1090
1111
|
}
|
|
1091
1112
|
|
|
1092
1113
|
chatMessageStatus(sessionID: string) {
|
package/src/mcp.ts
CHANGED
|
@@ -6,6 +6,7 @@ import { BgeEmbeddingModel } from "./embeddings";
|
|
|
6
6
|
import { detectRepo } from "./git";
|
|
7
7
|
import { checkSetup, setupClaudeCode, setupCursor } from "./setup";
|
|
8
8
|
import { TOOL_DEFS, type CoreContext, type ToolDef } from "./tool-defs";
|
|
9
|
+
import { chatOpenTabs as chatOpenTabsProvider } from "./tab-state";
|
|
9
10
|
import { actionDefs, type ActionDef } from "./commands";
|
|
10
11
|
import { mcpToolName } from "./prompts";
|
|
11
12
|
import { SidebandServer, sidebandSocketPath } from "./sideband";
|
|
@@ -136,7 +137,7 @@ export async function runMcpServer(): Promise<void> {
|
|
|
136
137
|
|
|
137
138
|
// The DB must exist before identity detection: detectRepo consults the
|
|
138
139
|
// repo_paths cache when the project directory is gone (deleted worktree).
|
|
139
|
-
const db = new ThatchDB(dbPath);
|
|
140
|
+
const db: ThatchDB = new ThatchDB(dbPath, { chatOpenTabs: chatOpenTabsProvider(() => db.chatTabClosures()) });
|
|
140
141
|
const detected = await detectRepo(projectDir, repoPathCache(db));
|
|
141
142
|
// unknown-to-global, matching the hook's mapping (bin/thatch): chat
|
|
142
143
|
// registration must follow the same store the tools would read, and
|
|
@@ -173,6 +174,9 @@ export async function runMcpServer(): Promise<void> {
|
|
|
173
174
|
defaultStore: repo,
|
|
174
175
|
extractionPayloadProvider,
|
|
175
176
|
drainExtractionQueue,
|
|
177
|
+
// Same-machine tab reader: the MCP server can read the local opencode
|
|
178
|
+
// state tree, so its roster renders the same open/recent split.
|
|
179
|
+
openTabs: chatOpenTabsProvider(() => db.chatTabClosures()),
|
|
176
180
|
// Claude Code identity anchor, two model-proof layers:
|
|
177
181
|
// 1. The hooks record (parent pid -> session) from payloads the model
|
|
178
182
|
// cannot influence, and this server is a child of the same Claude
|
|
@@ -478,7 +482,7 @@ async function dispatch(
|
|
|
478
482
|
arguments: [
|
|
479
483
|
{
|
|
480
484
|
name: "focus",
|
|
481
|
-
description: "Optional
|
|
485
|
+
description: "Optional text for the action: a scope (for example, which store to work on), a review target (branch, PR, MR, or git range), or other context",
|
|
482
486
|
required: false,
|
|
483
487
|
},
|
|
484
488
|
],
|
|
@@ -20,7 +20,7 @@
|
|
|
20
20
|
// peer).
|
|
21
21
|
|
|
22
22
|
import { Plugin } from "@opencode/plugin/tui";
|
|
23
|
-
import { isTabClosedEvent, isTabOpenedEvent, passesDirectoryGuard } from "../session-tab-shared";
|
|
23
|
+
import { isExitTabClosedEvent, isTabClosedEvent, isTabOpenedEvent, isToastEvent, passesDirectoryGuard } from "../session-tab-shared";
|
|
24
24
|
|
|
25
25
|
export default Plugin.define({
|
|
26
26
|
id: "jeffober-thatch-tui",
|
|
@@ -28,16 +28,19 @@ export default Plugin.define({
|
|
|
28
28
|
const off = context.data.listen(({ details }) => {
|
|
29
29
|
const windowDirectory = context.location?.directory ?? context.data.location.default().directory;
|
|
30
30
|
if (!passesDirectoryGuard(details.location?.directory, windowDirectory)) return;
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
//
|
|
37
|
-
//
|
|
31
|
+
// Two close events, one TUI action: tab-closed (the session_tab_close
|
|
32
|
+
// tool's confirmed close - the pump also runs its death bookkeeping)
|
|
33
|
+
// and exit-tab-closed (the wrap-up exit's close - the runtime records
|
|
34
|
+
// the deaths itself before emitting, so the pump ignores that one).
|
|
35
|
+
if (isTabClosedEvent(details.type) || isExitTabClosedEvent(details.type)) {
|
|
36
|
+
// Close the tab if THIS window has one for the session. Windows that
|
|
37
|
+
// never opened it (and windows at other directories, filtered above)
|
|
38
|
+
// return false - that is the correct no-op, not an error. The close
|
|
39
|
+
// is reopenable by the user (the strip's reopen stack), so this is
|
|
40
|
+
// tab-level, not session deletion.
|
|
38
41
|
const closeID = (details.data as { sessionID?: string }).sessionID;
|
|
39
42
|
if (!closeID) {
|
|
40
|
-
console.error("[thatch] tab-
|
|
43
|
+
console.error("[thatch] tab-close event without a sessionID");
|
|
41
44
|
return;
|
|
42
45
|
}
|
|
43
46
|
if (!context.ui.tabs.close(closeID)) {
|
|
@@ -45,6 +48,23 @@ export default Plugin.define({
|
|
|
45
48
|
}
|
|
46
49
|
return;
|
|
47
50
|
}
|
|
51
|
+
// The toast request: the server-side runtime's only TUI feedback
|
|
52
|
+
// channel (alerts, extraction metrics, chat registration, blocked
|
|
53
|
+
// wrap-ups). Best-effort like every toast - the event is ephemeral,
|
|
54
|
+
// so a TUI that is absent simply never shows it.
|
|
55
|
+
if (isToastEvent(details.type)) {
|
|
56
|
+
const toast = details.data as { message?: string; variant?: string; duration?: number };
|
|
57
|
+
if (typeof toast.message !== "string") {
|
|
58
|
+
console.error("[thatch] toast event without a message");
|
|
59
|
+
return;
|
|
60
|
+
}
|
|
61
|
+
context.ui.toast.show({
|
|
62
|
+
message: toast.message,
|
|
63
|
+
variant: (toast.variant as "info" | "success" | "warning" | "error") ?? "info",
|
|
64
|
+
duration: typeof toast.duration === "number" ? toast.duration : undefined,
|
|
65
|
+
});
|
|
66
|
+
return;
|
|
67
|
+
}
|
|
48
68
|
if (!isTabOpenedEvent(details.type)) return;
|
|
49
69
|
const sessionID = (details.data as { sessionID?: string }).sessionID;
|
|
50
70
|
if (!sessionID) {
|
package/src/opencode/v2.ts
CHANGED
|
@@ -5,11 +5,11 @@ import type { ToolContext as V2ToolContext } from "@opencode/plugin/promise/tool
|
|
|
5
5
|
import type { ThatchDB } from "../db";
|
|
6
6
|
import type { HostCapabilities, PromptPart, ToastInput } from "../capabilities";
|
|
7
7
|
import { createRuntime } from "../runtime";
|
|
8
|
-
import { wrapUpCommandContent } from "../commands";
|
|
8
|
+
import { wrapUpCommandContent, wrapUpCommandDescription } from "../commands";
|
|
9
9
|
import { deriveTitle } from "../extraction";
|
|
10
10
|
import { detectRepo, detectWorktreeKind } from "../git";
|
|
11
11
|
import { chatEnabled, loadConfig } from "../config";
|
|
12
|
-
import { SESSION_TAB_RPC, TAB_CLOSED_EVENT, TAB_OPENED_EVENT, buildSubordinatePrompt, tabClosedEventType, tabOpenedEventType } from "../session-tab-shared";
|
|
12
|
+
import { EXIT_TAB_CLOSED_EVENT, SESSION_TAB_RPC, TAB_CLOSED_EVENT, TAB_OPENED_EVENT, TOAST_EVENT, buildSubordinatePrompt, tabClosedEventType, tabOpenedEventType } from "../session-tab-shared";
|
|
13
13
|
import { TOOL_DEFS, trimHostContext, type HostToolContext, type SessionTabCloseInput, type SessionTabHost, type SessionTabSpawnInput, type SessionTabSpawnResult } from "../tool-defs";
|
|
14
14
|
|
|
15
15
|
// The opencode v2 adapter (opencode 2.x, plugin API @opencode/plugin 2.x).
|
|
@@ -29,9 +29,9 @@ import { TOOL_DEFS, trimHostContext, type HostToolContext, type SessionTabCloseI
|
|
|
29
29
|
// array; the runtime's plain strings convert to {type: "text", text}
|
|
30
30
|
// parts at the boundary.
|
|
31
31
|
// - per-message nudges: the prompt hook computes the turn's injections;
|
|
32
|
-
// the
|
|
33
|
-
//
|
|
34
|
-
// Injections stay out of the stored prompt text.
|
|
32
|
+
// the context hook appends them to the outbound request's user message
|
|
33
|
+
// that matches the entry's prompt text (v2 wire Messages have no
|
|
34
|
+
// `parts` field). Injections stay out of the stored prompt text.
|
|
35
35
|
// - noReply deliveries (chat echoes, session-start reminder): v2's prompt
|
|
36
36
|
// endpoint cannot suppress the model turn, so the runtime gates them off
|
|
37
37
|
// via capabilities.noReplyDelivery.
|
|
@@ -46,18 +46,52 @@ import { TOOL_DEFS, trimHostContext, type HostToolContext, type SessionTabCloseI
|
|
|
46
46
|
// - TUI reach: the ONLY server-to-TUI channel is the rpc event bridge - the
|
|
47
47
|
// session-tab rpc definition is registered at setup and its events reach
|
|
48
48
|
// the TUI CLI plugin (the package's ./tui entrypoint), which drives the
|
|
49
|
-
// tab strip (ui.tabs)
|
|
50
|
-
//
|
|
49
|
+
// tab strip (ui.tabs) and shows toasts (ui.toast). Keymap-command pushes
|
|
50
|
+
// still have no surface.
|
|
51
|
+
// - wrap-up actions: compact rides session.compact on the promise domain
|
|
52
|
+
// (upstream #52385, newer than the pinned dev types, so runtime-guarded);
|
|
53
|
+
// exit records the session's watcher deaths synchronously in the runtime
|
|
54
|
+
// and then emits the bridge's exit-tab-closed event, which the TUI plugin
|
|
55
|
+
// turns into closing the session's OWN tab (see exitHost in
|
|
56
|
+
// buildCapabilities).
|
|
57
|
+
// - toasts ride the bridge's toast event (TUI plugin's ui.toast.show);
|
|
58
|
+
// extraction-child cleanup rides session.remove (upstream #52387, also
|
|
59
|
+
// runtime-guarded). tui commands, session list endpoints:
|
|
51
60
|
// no v2 surface reachable from a plugin - degrades as no-op/null.
|
|
52
61
|
// fetchStatuses returns {} because the wake gate treats an unknown session
|
|
53
62
|
// as idle; the event-fed status map inside the runtime does the gating.
|
|
54
63
|
// Session MESSAGES are readable via session.context (mapped into the v1
|
|
55
|
-
// shape), so the wrap-up greenlight check works
|
|
56
|
-
// does not (no session.compact on the promise domain).
|
|
64
|
+
// shape), so the wrap-up greenlight check works.
|
|
57
65
|
|
|
58
66
|
type V2Context = Plugin.Context;
|
|
59
67
|
type V2Cleanup = Plugin.Cleanup;
|
|
60
68
|
|
|
69
|
+
// Both ends of the prompt-text binding must reconstruct text the same way:
|
|
70
|
+
// the prompt-session adapter joins outbound prompt parts with this helper,
|
|
71
|
+
// and the context hook joins a wire message's text parts with it before
|
|
72
|
+
// comparing against the stored prompt text. A separator mismatch would
|
|
73
|
+
// silently fail the equality and drop the turn's nudges.
|
|
74
|
+
function joinTextParts(parts: Array<{ text: string }>): string {
|
|
75
|
+
return parts.map((p) => p.text).join("\n\n");
|
|
76
|
+
}
|
|
77
|
+
|
|
78
|
+
// Reconstructs a wire message's text for the prompt-text binding. A string
|
|
79
|
+
// content is the common case; multi-part messages join with joinTextParts
|
|
80
|
+
// so the read side agrees with the write side's separator.
|
|
81
|
+
function messageText(message: { content: unknown }): string {
|
|
82
|
+
if (typeof message.content === "string") return message.content;
|
|
83
|
+
const parts = (Array.isArray(message.content) ? message.content : []).filter(
|
|
84
|
+
(p: any) => p?.type === "text",
|
|
85
|
+
);
|
|
86
|
+
return joinTextParts(parts);
|
|
87
|
+
}
|
|
88
|
+
|
|
89
|
+
// The wrap-up exit's tab-close emitter, late-bound in setup (see the
|
|
90
|
+
// tuiBridge holder there). One shape, referenced at the holder, the
|
|
91
|
+
// buildCapabilities seam, and the assignment - a local alias so the payload
|
|
92
|
+
// shape has a single drift point in this file.
|
|
93
|
+
type ExitTabCloseEmitter = (data: { sessionID: string }) => Promise<unknown>;
|
|
94
|
+
|
|
61
95
|
// Raw setup function: the dual entry (src/index.ts) owns the plugin id and
|
|
62
96
|
// the merged default export; this adapter only implements the v2 setup.
|
|
63
97
|
export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
@@ -77,14 +111,26 @@ export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
|
77
111
|
// differs from this instance's directory whenever opencode is launched
|
|
78
112
|
// below the project root. Their events would never pass the directory
|
|
79
113
|
// filter, so they are forwarded by ID: sessionCreate records every child
|
|
80
|
-
// here, and the pump lets their events through.
|
|
114
|
+
// here, and the pump lets their events through. Ids are never removed
|
|
115
|
+
// (children are deleted, but their id never recurs and the set dies with
|
|
116
|
+
// this activation - only a long-lived instance grows it).
|
|
81
117
|
const childSessions = new Set<string>();
|
|
82
118
|
|
|
83
119
|
// Tool executions currently running against this instance's runtime (see
|
|
84
120
|
// the counter in the tool execute wrapper below).
|
|
85
121
|
let inflightTools = 0;
|
|
86
122
|
|
|
87
|
-
|
|
123
|
+
// TUI-bridge holder: the wrap-up exit emits the exit-tab-closed rpc event
|
|
124
|
+
// (the TUI plugin closes the session's own tab) and every runtime toast
|
|
125
|
+
// rides the toast event - both through this late-bound holder, because
|
|
126
|
+
// capabilities are built before the rpc registration exists. Assigned when
|
|
127
|
+
// the registration wires (below); undefined forever on an SDK floor
|
|
128
|
+
// without the rpc surface, which both emitters' guards degrade.
|
|
129
|
+
const tuiBridge: {
|
|
130
|
+
emitExitTabClose?: ExitTabCloseEmitter;
|
|
131
|
+
emitToast?: (toast: ToastInput) => Promise<unknown>;
|
|
132
|
+
} = {};
|
|
133
|
+
const capabilities = buildCapabilities(context, worktree, childSessions, tuiBridge);
|
|
88
134
|
const runtime = await createRuntime({ capabilities, directory, worktree, v2Tools: true });
|
|
89
135
|
// Seed the forwarding set from rehydrated child bookkeeping: after a
|
|
90
136
|
// reload, an in-flight extraction child's maps come back from the journal,
|
|
@@ -111,13 +157,27 @@ export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
|
111
157
|
if (tabRegistration) {
|
|
112
158
|
const emitTabOpened = (data: { sessionID: string; directory: string }) =>
|
|
113
159
|
tabRegistration.events.emit(TAB_OPENED_EVENT, data);
|
|
160
|
+
// The session_tab_close tool's confirmed-close emitter: the pump
|
|
161
|
+
// translates this event into the runtime's death path, so it is the
|
|
162
|
+
// tool's only route to that bookkeeping.
|
|
163
|
+
const emitTabClosed = (data: { sessionID: string; chatName: string | null }) =>
|
|
164
|
+
tabRegistration.events.emit(TAB_CLOSED_EVENT, data);
|
|
165
|
+
// The wrap-up exit's own emitter: TUI-only (the runtime records the
|
|
166
|
+
// exit's deaths synchronously before the action fires, so the pump
|
|
167
|
+
// deliberately never translates this one).
|
|
168
|
+
tuiBridge.emitExitTabClose = (data) => tabRegistration.events.emit(EXIT_TAB_CLOSED_EVENT, data);
|
|
169
|
+
// Every runtime toast rides this emitter (alerts, extraction metrics,
|
|
170
|
+
// chat registration, blocked wrap-ups) - TUI-only by nature. The spread
|
|
171
|
+
// widens the interface into a plain object type: the rpc emit's
|
|
172
|
+
// schema-inferred input wants an index signature, which interfaces
|
|
173
|
+
// never carry.
|
|
174
|
+
tuiBridge.emitToast = (toast) => tabRegistration.events.emit(TOAST_EVENT, { ...toast });
|
|
114
175
|
runtime.coreContext.sessionTabHost = buildSessionTabHost({
|
|
115
176
|
context,
|
|
116
177
|
directory,
|
|
117
178
|
db: runtime.coreContext.db,
|
|
118
179
|
emitTabOpened,
|
|
119
|
-
emitTabClosed
|
|
120
|
-
tabRegistration.events.emit(TAB_CLOSED_EVENT, data),
|
|
180
|
+
emitTabClosed,
|
|
121
181
|
debug: runtime.debug,
|
|
122
182
|
});
|
|
123
183
|
} else {
|
|
@@ -199,12 +259,34 @@ export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
|
199
259
|
// (the v1 contract); v2's system parts are { type: "text", text }
|
|
200
260
|
// objects, so convert at the boundary.
|
|
201
261
|
// - per-turn nudges: append the prompt hook's stored injections to the
|
|
202
|
-
// OUTBOUND request's
|
|
203
|
-
//
|
|
204
|
-
//
|
|
205
|
-
//
|
|
206
|
-
//
|
|
207
|
-
|
|
262
|
+
// OUTBOUND request's user message whose text matches the entry's
|
|
263
|
+
// stored prompt (see the binding check below). The stored user message
|
|
264
|
+
// stays clean (v1 delivered nudges as TUI-hidden synthetic parts; v2's
|
|
265
|
+
// prompt text IS the stored message), and the request is rebuilt per
|
|
266
|
+
// round trip, so injecting here reproduces v1's
|
|
267
|
+
// persistent-synthetic-part semantics: the model sees the nudges on
|
|
268
|
+
// every call of the turn.
|
|
269
|
+
// Per-turn nudge injections, keyed by session, then by the prompt text
|
|
270
|
+
// they were computed from. Each entry is bound to that text: the context
|
|
271
|
+
// hook injects an entry only when the request contains a user message
|
|
272
|
+
// whose text equals it. A bare sessionID-keyed entry that outlives its
|
|
273
|
+
// turn (the prompt hook missed or failed on a later message) replays a
|
|
274
|
+
// stale nudge block onto a message it was never computed for - deleted
|
|
275
|
+
// predictions surfaced as current with their old confidence labels (the
|
|
276
|
+
// October 2026 staleness report).
|
|
277
|
+
//
|
|
278
|
+
// The per-session set holds a small bounded number of entries (oldest
|
|
279
|
+
// evicted) so a prompt queued mid-turn keeps its own fresh entry instead
|
|
280
|
+
// of evicting the running turn's: the running turn's remaining rounds
|
|
281
|
+
// still match their own prompt, and the queued prompt's turn matches
|
|
282
|
+
// its own. A prompt whose nudge computation comes up empty clears the
|
|
283
|
+
// session's whole set - an entry left behind would match its own prompt
|
|
284
|
+
// text in the session HISTORY of later requests and replay a stale block
|
|
285
|
+
// there - so a queued prompt with no nudges drops the running turn's
|
|
286
|
+
// remaining-round block. That cost is smaller than the staleness it
|
|
287
|
+
// prevents; opencode-plugin.md discloses it.
|
|
288
|
+
const PENDING_INJECTION_CAP = 3;
|
|
289
|
+
const pendingInjections = new Map<string, Map<string, { promptText: string; injections: string[] }>>();
|
|
208
290
|
const registerSystem = await context.session.hook(
|
|
209
291
|
"context",
|
|
210
292
|
async (request: { sessionID: string; system: unknown[]; messages?: any[] }) => {
|
|
@@ -213,16 +295,51 @@ export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
|
213
295
|
for (const part of pushed) {
|
|
214
296
|
request.system.push(typeof part === "string" ? { type: "text", text: part } : part);
|
|
215
297
|
}
|
|
216
|
-
const
|
|
217
|
-
if (!
|
|
218
|
-
|
|
219
|
-
|
|
298
|
+
const pending = pendingInjections.get(request.sessionID);
|
|
299
|
+
if (!pending?.size) return;
|
|
300
|
+
// Binding check: a stored v2 user message IS its prompt text (the
|
|
301
|
+
// prompt hook's injections are computed from it), so text equality
|
|
302
|
+
// identifies the message an entry belongs to. Wire message ids are
|
|
303
|
+
// optional on the v2 Message schema and cannot be relied on here.
|
|
304
|
+
//
|
|
305
|
+
// The match searches the request's user messages for the LAST one
|
|
306
|
+
// whose joined text equals the entry's prompt - it is not simply the
|
|
307
|
+
// request's last user message. Sibling context hooks (opencode's plan
|
|
308
|
+
// plugin) splice their own user-role reminder into the request
|
|
309
|
+
// mid-turn: BEFORE the prompt when the request's last message is
|
|
310
|
+
// user-role, but AT THE TAIL when it is not (mid-turn rounds), which
|
|
311
|
+
// would make the reminder the last user message, fail the equality,
|
|
312
|
+
// and silently drop every nudge for the turn. Injecting into the
|
|
313
|
+
// prompt's own message is v1's persistent-synthetic-part semantics.
|
|
314
|
+
//
|
|
315
|
+
// Entries are tried newest first: when several are pending for the
|
|
316
|
+
// session, the latest prompt-hook run wins a text match.
|
|
317
|
+
//
|
|
318
|
+
// Text equality is the tightest binding available here, not an
|
|
319
|
+
// airtight one: an identical prompt re-submitted after a missed
|
|
320
|
+
// prompt hook still matches and replays. The next prompt-hook run
|
|
321
|
+
// that fires is the recovery.
|
|
322
|
+
let target: any;
|
|
323
|
+
let matched: { promptText: string; injections: string[] } | undefined;
|
|
324
|
+
for (const entry of [...pending.values()].reverse()) {
|
|
325
|
+
target = [...(request.messages ?? [])]
|
|
326
|
+
.reverse()
|
|
327
|
+
.find((m) => m?.role === "user" && messageText(m) === entry.promptText);
|
|
328
|
+
if (target) {
|
|
329
|
+
matched = entry;
|
|
330
|
+
break;
|
|
331
|
+
}
|
|
332
|
+
}
|
|
333
|
+
if (!matched) {
|
|
334
|
+
runtime.debug("v2:hook:context", `session=${request.sessionID} no user message matches a stored prompt; skipping injections`);
|
|
335
|
+
return;
|
|
336
|
+
}
|
|
220
337
|
// v2's wire Message carries parts in `content: Array<ContentPart>` -
|
|
221
338
|
// it has no `parts` field, so injecting there would write a stray
|
|
222
339
|
// property the provider formatter never reads (silent nudge loss).
|
|
223
|
-
const content = Array.isArray(
|
|
224
|
-
for (const text of injections) content.push({ type: "text", text });
|
|
225
|
-
runtime.debug("v2:hook:context", `session=${request.sessionID} injected=${injections.length} messages=${request.messages?.length}`);
|
|
340
|
+
const content = Array.isArray(target.content) ? target.content : (target.content = []);
|
|
341
|
+
for (const text of matched.injections) content.push({ type: "text", text });
|
|
342
|
+
runtime.debug("v2:hook:context", `session=${request.sessionID} injected=${matched.injections.length} messages=${request.messages?.length}`);
|
|
226
343
|
},
|
|
227
344
|
);
|
|
228
345
|
|
|
@@ -241,12 +358,29 @@ export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
|
241
358
|
);
|
|
242
359
|
} catch (err) {
|
|
243
360
|
console.error(`[thatch] v2 prompt hook failed: ${err}`);
|
|
361
|
+
// The hook owns no fresh entry for this prompt; a retained one
|
|
362
|
+
// belongs to a superseded prompt and would replay on an identical
|
|
363
|
+
// re-submission. Drop the session's whole set.
|
|
364
|
+
pendingInjections.delete(request.sessionID);
|
|
244
365
|
return;
|
|
245
366
|
}
|
|
246
367
|
const injections = parts.slice(1).map((part) => part.text);
|
|
247
368
|
if (injections.length > 0) runtime.debug("v2:hook:prompt", `session=${request.sessionID} injections=${injections.length}`);
|
|
248
|
-
if (injections.length > 0)
|
|
249
|
-
|
|
369
|
+
if (injections.length > 0) {
|
|
370
|
+
const entries = pendingInjections.get(request.sessionID) ?? new Map();
|
|
371
|
+
if (!entries.has(request.prompt.text) && entries.size >= PENDING_INJECTION_CAP) {
|
|
372
|
+
// Bounded set: evict the oldest entry (insertion order).
|
|
373
|
+
entries.delete(entries.keys().next().value!);
|
|
374
|
+
}
|
|
375
|
+
entries.set(request.prompt.text, { promptText: request.prompt.text, injections });
|
|
376
|
+
pendingInjections.set(request.sessionID, entries);
|
|
377
|
+
} else {
|
|
378
|
+
// A prompt that produced no nudges clears the session's whole set:
|
|
379
|
+
// an entry left behind would match its own prompt text in the
|
|
380
|
+
// session history of later requests and replay a stale block there.
|
|
381
|
+
// See the pendingInjections comment above for the disclosed cost.
|
|
382
|
+
pendingInjections.delete(request.sessionID);
|
|
383
|
+
}
|
|
250
384
|
},
|
|
251
385
|
);
|
|
252
386
|
|
|
@@ -278,10 +412,9 @@ export async function setup(context: V2Context): Promise<V2Cleanup | void> {
|
|
|
278
412
|
for (const kind of ["compact", "exit"] as const) {
|
|
279
413
|
editor.add({
|
|
280
414
|
name: `thatch/${kind}`,
|
|
281
|
-
|
|
282
|
-
|
|
283
|
-
|
|
284
|
-
: "Flush thatch persistence, check for loose ends, then exit opencode if clear",
|
|
415
|
+
// Shared with the v1 command file's frontmatter so the two hosts'
|
|
416
|
+
// menu descriptions cannot drift.
|
|
417
|
+
description: wrapUpCommandDescription(kind),
|
|
285
418
|
// The user's typed arguments ride invocation.prompt (a
|
|
286
419
|
// PromptInput.Prompt with a text field). v1's host expanded
|
|
287
420
|
// $ARGUMENTS from the command file; v2's session.prompt does no
|
|
@@ -699,14 +832,41 @@ function buildSessionTabHost(input: {
|
|
|
699
832
|
};
|
|
700
833
|
}
|
|
701
834
|
|
|
835
|
+
// Runtime guard for promise-domain members newer than the pinned dev types
|
|
836
|
+
// (compact - upstream #52385; remove - #52387): a typed call fails tsc
|
|
837
|
+
// against the pin, and an unguarded cast crashes on an older host. Returns
|
|
838
|
+
// the member as a callable, or undefined on the floor - the CALLER owns the
|
|
839
|
+
// degrade (a log for user-requested actions like compact; silence for
|
|
840
|
+
// best-effort ones like the child cleanup). The rpc registration guard in
|
|
841
|
+
// setup is the same idiom at domain granularity and stays inline: it gates
|
|
842
|
+
// a whole registration, not one call.
|
|
843
|
+
export function optionalDomainMethod(
|
|
844
|
+
domain: object,
|
|
845
|
+
method: string,
|
|
846
|
+
): ((input: unknown) => Promise<unknown>) | undefined {
|
|
847
|
+
const fn = (domain as Record<string, unknown>)[method];
|
|
848
|
+
return typeof fn === "function" ? (fn as (input: unknown) => Promise<unknown>) : undefined;
|
|
849
|
+
}
|
|
850
|
+
|
|
702
851
|
// The HostCapabilities implementation over the v2 promise context. Every
|
|
703
852
|
// operation the v2 surface lacks degrades as a no-op or null - the shared
|
|
704
853
|
// runtime's callers treat those results as best-effort and log, never crash.
|
|
705
|
-
function buildCapabilities(
|
|
854
|
+
function buildCapabilities(
|
|
855
|
+
context: V2Context,
|
|
856
|
+
worktree: string,
|
|
857
|
+
childSessions: Set<string>,
|
|
858
|
+
tuiBridge: {
|
|
859
|
+
emitExitTabClose?: ExitTabCloseEmitter;
|
|
860
|
+
emitToast?: (toast: ToastInput) => Promise<unknown>;
|
|
861
|
+
},
|
|
862
|
+
): HostCapabilities {
|
|
706
863
|
// Typed against the SDK's own SessionDomain: the shape errors the
|
|
707
864
|
// original cast (as unknown as {...}) suppressed are exactly what the
|
|
708
|
-
// review caught (message.list
|
|
709
|
-
// {sessionID}).
|
|
865
|
+
// review caught (message.list does not exist here; get takes
|
|
866
|
+
// {sessionID}). compact and remove DO exist on newer SDK builds but not
|
|
867
|
+
// on the pinned dev types - both calls go through optionalDomainMethod
|
|
868
|
+
// (above). Let the typecheck keep holding that line for the pinned
|
|
869
|
+
// surface.
|
|
710
870
|
const session = context.session;
|
|
711
871
|
|
|
712
872
|
return {
|
|
@@ -731,14 +891,20 @@ function buildCapabilities(context: V2Context, worktree: string, childSessions:
|
|
|
731
891
|
childSessions.add(id);
|
|
732
892
|
return { id };
|
|
733
893
|
},
|
|
734
|
-
//
|
|
735
|
-
//
|
|
736
|
-
//
|
|
737
|
-
//
|
|
738
|
-
//
|
|
739
|
-
//
|
|
740
|
-
//
|
|
741
|
-
|
|
894
|
+
// Extraction child cleanup: upstream exposed session.remove on the
|
|
895
|
+
// promise domain (#52387), the same era as compact - guarded the same
|
|
896
|
+
// way (optionalDomainMethod; the pinned dev types predate the surface).
|
|
897
|
+
// An older host keeps the documented gap: the session picker accumulates
|
|
898
|
+
// one thatch-extraction entry per extraction, and "continue last session"
|
|
899
|
+
// (-c) logic that picks the newest top-level session lands in an
|
|
900
|
+
// extraction child after any session that triggered extraction,
|
|
901
|
+
// because the child is top-level and newer.
|
|
902
|
+
sessionDelete: async (id: string) => {
|
|
903
|
+
const remove = optionalDomainMethod(session, "remove");
|
|
904
|
+
// Best-effort by the caller's contract: the floor degrades silently.
|
|
905
|
+
if (!remove) return;
|
|
906
|
+
await remove({ sessionID: id });
|
|
907
|
+
},
|
|
742
908
|
promptSession: async (sessionID, body, _mode) => {
|
|
743
909
|
// v2's prompt endpoint takes text, not parts, and has no synthetic /
|
|
744
910
|
// noReply semantics. Nudge injections ride the prompt hook.
|
|
@@ -749,7 +915,7 @@ function buildCapabilities(context: V2Context, worktree: string, childSessions:
|
|
|
749
915
|
// prompt); v2's prompt enqueues the message and returns while the
|
|
750
916
|
// model turn runs asynchronously, so the extraction background flag
|
|
751
917
|
// degrades: both modes enqueue the same way.
|
|
752
|
-
const text = body.parts
|
|
918
|
+
const text = joinTextParts(body.parts);
|
|
753
919
|
if (!body.noReply && body.parts.length > 0 && body.parts.every((part) => part.synthetic)) {
|
|
754
920
|
await session.synthetic({ sessionID, text });
|
|
755
921
|
return;
|
|
@@ -764,36 +930,51 @@ function buildCapabilities(context: V2Context, worktree: string, childSessions:
|
|
|
764
930
|
},
|
|
765
931
|
sessionList: async () => null,
|
|
766
932
|
sessionMessages: async (id) => {
|
|
767
|
-
// The
|
|
768
|
-
//
|
|
933
|
+
// The pinned promise domain has no message-list endpoint (no `message`
|
|
934
|
+
// accessor; compact/remove exist on newer SDK builds but not here).
|
|
769
935
|
// `session.context` IS exposed and returns the session's message list
|
|
770
936
|
// (Array<SessionMessageInfo>); map into the v1 shape the wrap-up
|
|
771
937
|
// greenlight check reads.
|
|
772
938
|
const result = await session.context({ sessionID: id });
|
|
773
939
|
return mapSessionContextMessages(result);
|
|
774
940
|
},
|
|
775
|
-
showToast: async (
|
|
776
|
-
//
|
|
777
|
-
//
|
|
778
|
-
//
|
|
779
|
-
//
|
|
941
|
+
showToast: async (toast: ToastInput) => {
|
|
942
|
+
// The toast rpc event is the only TUI feedback channel on v2 - the
|
|
943
|
+
// TUI plugin's ui.toast.show. Best-effort by contract (the runtime's
|
|
944
|
+
// call sites catch-and-ignore): a TUI-less environment (headless run,
|
|
945
|
+
// still connecting) or an rpc-less SDK floor simply never shows it,
|
|
946
|
+
// and that is the correct silent degrade, not an error.
|
|
947
|
+
const emit = tuiBridge.emitToast;
|
|
948
|
+
if (!emit) return;
|
|
949
|
+
await emit(toast);
|
|
780
950
|
},
|
|
781
|
-
compactSession: async () => {
|
|
782
|
-
//
|
|
783
|
-
//
|
|
784
|
-
//
|
|
785
|
-
//
|
|
786
|
-
//
|
|
787
|
-
|
|
788
|
-
|
|
951
|
+
compactSession: async (sessionID: string) => {
|
|
952
|
+
// Upstream exposed session.compact on the promise SessionDomain
|
|
953
|
+
// (#52385) - the same core compaction the built-in /compact runs.
|
|
954
|
+
// The pinned dev types predate that surface, so the call goes through
|
|
955
|
+
// optionalDomainMethod: an older host degrades to a logged no-op (the
|
|
956
|
+
// wrap-up checklist and flush still ran).
|
|
957
|
+
const compact = optionalDomainMethod(session, "compact");
|
|
958
|
+
if (!compact) {
|
|
959
|
+
console.error("[thatch] v2: compaction trigger unavailable; wrap-up checklist ran, compact skipped");
|
|
960
|
+
return;
|
|
961
|
+
}
|
|
962
|
+
await compact({ sessionID });
|
|
789
963
|
},
|
|
790
|
-
exitHost: async () => {
|
|
791
|
-
//
|
|
792
|
-
// the
|
|
793
|
-
//
|
|
794
|
-
//
|
|
795
|
-
//
|
|
796
|
-
//
|
|
964
|
+
exitHost: async (sessionID: string) => {
|
|
965
|
+
// Tab-scoped close (the close anomalyco/opencode#50984 asks for):
|
|
966
|
+
// the daemon hosts every tab, so app.exit would take down unrelated
|
|
967
|
+
// sessions. This emit is TUI-only - the runtime records the
|
|
968
|
+
// session's watcher deaths synchronously BEFORE calling here, and
|
|
969
|
+
// the pump deliberately never translates this event (a second
|
|
970
|
+
// death pass would erase the durable death row the first one
|
|
971
|
+
// wrote).
|
|
972
|
+
const emit = tuiBridge.emitExitTabClose;
|
|
973
|
+
if (!emit) {
|
|
974
|
+
console.error("[thatch] v2: rpc surface unavailable; wrap-up checklist ran, tab close skipped");
|
|
975
|
+
return;
|
|
976
|
+
}
|
|
977
|
+
await emit({ sessionID });
|
|
797
978
|
},
|
|
798
979
|
};
|
|
799
980
|
}
|