@jcbuisson/express-x 1.0.2 → 1.0.4

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@jcbuisson/express-x",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "",
-  "main": "src/expressX.js",
+  "main": "src/index.js",
   "repository": {
     "type": "git",
     "url": "git@gitlab.com:buisson31/express-x.git"
@@ -17,7 +17,6 @@
     "@prisma/client": "^4.10.1",
     "config": "^3.3.9",
     "express": "^4.18.2",
-    "jsonwebtoken": "^9.0.0",
     "socket.io": "^4.6.0"
   },
   "devDependencies": {

package/src/{expressX.js → index.js}

@@ -19,44 +19,39 @@ function expressX(app) {
    /*
     * create a service `name` based on Prisma table `entity`
     */
-   function createDatabaseService({ name, entity=name, client='prisma' }) {
-      return createService({
-         name,
-         entity,
-
-         methods: {
-            create: (data) => prisma[entity].create({
-               data,
-            }),
-
-            get: (id) => prisma[entity].findUnique({
-               where: {
-                  id,
-               },
-            }),
-
-            patch: (id, data) => prisma[entity].update({
-               where: {
-                  id,
-               },
-               data,
-            }),
-
-            remove: (id, data) => prisma[entity].delete({
-               where: {
-                  id,
-               },
-            }),
-
-            find: (options) => prisma[entity].findMany(options),
-         }
+   function createDatabaseService(name, { entity=name, client='prisma' }) {
+      return createService(name, {
+         create: (data) => prisma[entity].create({
+            data,
+         }),
+
+         get: (id) => prisma[entity].findUnique({
+            where: {
+               id,
+            },
+         }),
+
+         patch: (id, data) => prisma[entity].update({
+            where: {
+               id,
+            },
+            data,
+         }),
+
+         remove: (id, data) => prisma[entity].delete({
+            where: {
+               id,
+            },
+         }),
+
+         find: (options) => prisma[entity].findMany(options),
       })
    }
 
    /*
     * create a service `name` with given `methods`
     */
-   function createService({ name, methods }) {
+   function createService(name, methods) {
       const service = { name }
 
       for (const methodName in methods) {
@@ -64,9 +59,12 @@ function expressX(app) {
 
          // `context` is the context of execution (transport type, connection, app)
          // `args` is the list of arguments of the method
-         service[methodName] = async (context, ...args) => {
+         service['__' + methodName] = async (context, ...args) => {
             context.args = args
 
+            // if a hook or the method throws an error, it will be caught by `socket.on('client-request'`
+            // and the client will get a rejected promise
+
             // call 'before' hooks, modifying `context.args`
             const beforeMethodHooks = service?.hooks?.before && service.hooks.before[methodName] || []
             const beforeAllHooks = service?.hooks?.before?.all || []
@@ -86,11 +84,11 @@ function expressX(app) {
             }
             return result
          }
-      }
 
-      // un-hooked versions of methods: `_create`, etc.
-      for (const methodName in methods) {
-         const method = methods[methodName]
+         // hooked version of method: `create`, etc., to be called from backend with no context
+         service[methodName] = method
+
+         // un-hooked version of method: `_create`, etc., to be called from backend with no context
          service['_' + methodName] = method
       }
 
@@ -109,8 +107,9 @@ function expressX(app) {
       return service
    }
 
-   // get service from `services` cache
+   // `app.service(name)` starts here!
    function service(name) {
+      // get service from `services` cache
       if (name in services) return services[name]
       throw Error(`there is no service named '${name}'`)
    }
@@ -130,27 +129,27 @@ function expressX(app) {
       }
 
       app.post(path, async (req, res) => {
-         const value = await service.create(context, req.body)
+         const value = await service.__create(context, req.body)
          res.json(value)
       })
 
       app.get(path, async (req, res) => {
-         const values = await service.find(context, req.body)
+         const values = await service.__find(context, req.body)
          res.json(values)
       })
 
       app.get(`${path}/:id`, async (req, res) => {
-         const value = await service.get(context, parseInt(req.params.id))
+         const value = await service.__get(context, parseInt(req.params.id))
          res.json(value)
       })
 
       app.patch(`${path}/:id`, async (req, res) => {
-         const value = await service.patch(context, parseInt(req.params.id), req.body)
+         const value = await service.__patch(context, parseInt(req.params.id), req.body)
          res.json(value)
       })
 
       app.delete(`${path}/:id`, async (req, res) => {
-         const value = await service.remove(context, parseInt(req.params.id))
+         const value = await service.__remove(context, parseInt(req.params.id))
          res.json(value)
       })
    }
@@ -192,12 +191,14 @@ function expressX(app) {
          if (name in services) {
             const service = services[name]
             try {
-               const serviceMethod = service[action]
+               const serviceMethod = service['__' + action]
 
                const context = {
                   app,
                   transport: 'ws',
                   connection,
+                  name,
+                  action,
                }
                const result = await serviceMethod(context, ...args)
 
@@ -224,7 +225,6 @@ function expressX(app) {
                   }
                }
             } catch(error) {
-               console.log('error', error)
                io.emit('client-response', {
                   uid,
                   error,