@jcbuisson/express-x-plugins 4.0.9 → 4.0.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jcbuisson/express-x-plugins",
-  "version": "4.0.9",
+  "version": "4.0.10",
   "description": "Plugins for express-x",
   "type": "module",
   "main": "./src/electric-server-plugin.mjs",

package/src/electric-server-plugin.mjs

@@ -91,7 +91,7 @@ export function electricOfflinePlugin(app, db, models, options = {}) {
 
          update: async function(id, data) {
             await authorize(this, model.name, 'update', [id, data])
-            const set = buildSet(data)
+            const set = buildSet(data, model.primaryKey)
             return withTransaction(db, async client => {
                const result = await client.query(
                   `UPDATE ${model.quotedTable} SET ${set.sql} WHERE ${model.quotedPrimaryKey} = $${set.values.length + 1} RETURNING *`,
@@ -208,9 +208,9 @@ function buildWhere(where, startIndex = 1) {
    return { sql: clauses.length ? clauses.join(' AND ') : 'TRUE', values }
 }
 
-function buildSet(data, startIndex = 1) {
+function buildSet(data, primaryKey, startIndex = 1) {
    assertPlainObject(data, 'mutation data')
-   const entries = Object.entries(data).filter(([key, value]) => key !== 'uid' && value !== undefined)
+   const entries = Object.entries(data).filter(([key, value]) => key !== primaryKey && value !== undefined)
    if (entries.length === 0) throw new TypeError('mutation data must contain at least one field')
    return {
       sql: entries.map(([column], index) => `${quoteIdentifier(column, 'data column')} = $${startIndex + index}`).join(', '),

package/src/reload-client-plugin.mjs

@@ -1,5 +1,3 @@
-import { useSessionStorage } from '@vueuse/core'
-
 /**
  * Enrich `app` with listeners handling socket data transfer on page reload
  *
@@ -8,20 +6,18 @@ import { useSessionStorage } from '@vueuse/core'
  */
 export async function reloadPlugin(app) {
 
-   const cnxid = useSessionStorage('cnxid', '')
-   const cnxtoken = useSessionStorage('cnxtoken', '')
    const handleTransferToken = token => {
-      if (typeof token === 'string') cnxtoken.value = token
+      if (typeof token === 'string') sessionStorage.setItem('cnxtoken', token)
    }
 
    app.addConnectListener(async (socket) => {
       const socketId = socket.id
       console.log('connect', socketId)
-      const prevSocketId = cnxid.value
-      const prevTransferToken = cnxtoken.value
+      const prevSocketId = sessionStorage.getItem('cnxid') ?? ''
+      const prevTransferToken = sessionStorage.getItem('cnxtoken') ?? ''
       socket.off('cnx-transfer-token', handleTransferToken)
       socket.on('cnx-transfer-token', handleTransferToken)
-      cnxid.value = socketId
+      sessionStorage.setItem('cnxid', socketId)
       if (prevSocketId && prevTransferToken) {
          console.log('cnx-transfer', prevSocketId, 'to', socketId)
          let timeout

package/test/electric-client-plugin.test.mjs

@@ -77,23 +77,6 @@ test('getObservable emits Shape rows and cleans up its subscription', () => {
    subscription.unsubscribe()
 })
 
-test('getVueRef returns Shape rows in a Vue ref and cleans up with its scope', () => {
-   const app = { service: () => ({}) }
-   electricClientPlugin(app, { ShapeStream: FakeStream, Shape: FakeShape })
-   const todo = app.createElectricModel('todos')
-   const scope = effectScope()
-   let rows
-
-   scope.run(() => { rows = todo.getVueRef({ completed: false }) })
-
-   assert.equal(isRef(rows), true)
-   assert.deepEqual(rows.value, [{ uid: 'one', completed: false }])
-   const shape = FakeStream.instances.at(-1).shape
-   assert.equal(shape.unsubscribed, undefined)
-   scope.stop()
-   assert.equal(shape.unsubscribed, true)
-})
-
 test('findMany resolves with the first Shape rows and cleans up its subscription', async () => {
    const app = { service: () => ({}) }
    electricClientPlugin(app, { ShapeStream: FakeStream, Shape: FakeShape })

package/test/electric-server-plugin.test.mjs

@@ -48,6 +48,32 @@ test('allows the database to generate a primary key', async () => {
    assert.equal(queries[1].sql, 'INSERT INTO "todos" DEFAULT VALUES RETURNING *')
 })
 
+test('protects the configured primary key during updates', async () => {
+   const services = new Map()
+   const queries = []
+   const db = {
+      async query(sql, values = []) {
+         queries.push({ sql, values })
+         return { rows: [] }
+      },
+   }
+   const app = {
+      createService(name, methods) { services.set(name, methods) },
+      get() {},
+   }
+   electricOfflinePlugin(app, db, [{ name: 'people', primaryKey: 'id' }], {
+      authorize: async () => true,
+   })
+
+   await services.get('people').update.call({}, 7, { id: 99, uid: 'editable', name: 'Ada' })
+
+   assert.equal(
+      queries[0].sql,
+      'UPDATE "people" SET "uid" = $1, "name" = $2 WHERE "id" = $3 RETURNING *',
+   )
+   assert.deepEqual(queries[0].values, ['editable', 'Ada', 7])
+})
+
 test('requires authorization and reports forbidden calls', async () => {
    const { services } = fixture({ authorize: async () => false })
    await assert.rejects(