@jbrowse/product-core 5.0.0-beta.1 → 5.0.0-beta.3

package/esm/RootModel/BaseRootModel.js

@@ -1,9 +1,9 @@
 import TextSearchManager from '@jbrowse/core/TextSearch/TextSearchManager';
 import assemblyManagerFactory from '@jbrowse/core/assemblyManager';
 import RpcManager from '@jbrowse/core/rpc/RpcManager';
+import { scheduleDetachedDestroy } from '@jbrowse/core/util';
 import { cast, detach, getType, isStateTreeNode, types, } from '@jbrowse/mobx-state-tree';
 import { describeUnbuildableNodes, pruneUnbuildableNodes, } from '../pruneUnbuildableNodes.js';
-import { scheduleDetachedDestroy } from '../scheduleDetachedDestroy.js';
 import { migrateSessionSnapshot } from '../sessionMigrations/index.js';
 import { filterSessionInPlace } from '../sessionUtils.js';
 // `session` is a `types.maybe(sessionModelType)` where `sessionModelType` is the
@@ -87,6 +87,7 @@ export function BaseRootModelFactory({ pluginManager, jbrowseModelType, sessionM
             const unbuildable = [];
             let migrated = sessionSnapshot;
             if (sessionSnapshot && typeof sessionSnapshot === 'object') {
+                pluginManager.assertSessionTypesLoaded(sessionSnapshot);
                 // before the cast, because a type this build has no plugin for is a
                 // union failure the try below never gets to see
                 const pruned = pruneUnbuildableNodes(migrateSessionSnapshot(sessionSnapshot), pluginManager, sessionModelType);

package/esm/RootModel/PreferencesConfig.d.ts

@@ -50,4 +50,19 @@ export declare function PreferencesConfigSchemaFactory(): import("@jbrowse/core/
         readonly type: "boolean";
         readonly defaultValue: false;
     };
+    /**
+     * #slot configuration.preferences.developerMode
+     * when true, the ordering-contract checks a display or plugin can break
+     * report themselves in the app rather than only in a development build.
+     * Off by default and deliberately not in the Preferences dialog: the
+     * messages are about code, and a reader who cannot change the code cannot
+     * act on one. Turn it on for a site that is running a plugin under
+     * development; a plugin author needs nothing here, since a plugin served
+     * from localhost arms the same channel on its own, as does
+     * `localStorage.jbrowseDeveloperMode`. Takes effect on reload.
+     */
+    readonly developerMode: {
+        readonly type: "boolean";
+        readonly defaultValue: false;
+    };
 }, import("@jbrowse/core/configuration/configurationSchema").ConfigurationSchemaOptions<undefined, undefined>>;

package/esm/RootModel/PreferencesConfig.js

@@ -57,5 +57,20 @@ export function PreferencesConfigSchemaFactory() {
             type: 'boolean',
             defaultValue: false,
         },
+        /**
+         * #slot configuration.preferences.developerMode
+         * when true, the ordering-contract checks a display or plugin can break
+         * report themselves in the app rather than only in a development build.
+         * Off by default and deliberately not in the Preferences dialog: the
+         * messages are about code, and a reader who cannot change the code cannot
+         * act on one. Turn it on for a site that is running a plugin under
+         * development; a plugin author needs nothing here, since a plugin served
+         * from localhost arms the same channel on its own, as does
+         * `localStorage.jbrowseDeveloperMode`. Takes effect on reload.
+         */
+        developerMode: {
+            type: 'boolean',
+            defaultValue: false,
+        },
     });
 }

package/esm/RootModel/createConfigModel.d.ts

@@ -66,6 +66,10 @@ declare function rootConfigurationSchema(): import("@jbrowse/core/configuration/
             readonly type: "boolean";
             readonly defaultValue: false;
         };
+        readonly developerMode: {
+            readonly type: "boolean";
+            readonly defaultValue: false;
+        };
     }, import("@jbrowse/core/configuration/configurationSchema").ConfigurationSchemaOptions<undefined, undefined>>;
     readonly formatDetails: import("@jbrowse/core/configuration/configurationSchema").ConfigurationSchemaType<{
         readonly feature: {
@@ -178,6 +182,10 @@ export declare function createConfigModel(pluginManager: PluginManager, assembly
                 readonly type: "boolean";
                 readonly defaultValue: false;
             };
+            readonly developerMode: {
+                readonly type: "boolean";
+                readonly defaultValue: false;
+            };
         }, import("@jbrowse/core/configuration/configurationSchema").ConfigurationSchemaOptions<undefined, undefined>>;
         readonly formatDetails: import("@jbrowse/core/configuration/configurationSchema").ConfigurationSchemaType<{
             readonly feature: {

package/esm/Session/BaseSession.d.ts

@@ -162,11 +162,8 @@ export declare function BaseSessionModel<ROOT_MODEL_TYPE extends BaseRootModelTy
      * `{ displayType, slot, value }` — the inventory the Preferences dialog
      * lists and clears one at a time (`setDisplayTypeDefault(…, undefined)`).
      *
-     * Here rather than filtered out of `getPreferenceChanges` by the dialog,
-     * because the composite-key layout is this file's: a consumer that
-     * recognized these rows by matching the path head is exactly the coupling
-     * `DISPLAY_TYPE_DEFAULTS_PATH_HEAD` stopped being exported over, where a
-     * rename on one side alone silently no-ops the other.
+     * Parsed here rather than by the dialog, because the composite-key
+     * layout is this file's and nothing outside it should depend on it.
      */
     getDisplayTypeDefaults(): {
         displayType: string;
@@ -175,14 +172,13 @@ export declare function BaseSessionModel<ROOT_MODEL_TYPE extends BaseRootModelTy
     }[];
     /**
      * #method
-     * every runtime preference-override that currently differs from its
-     * config/admin default, as `{ path, from, to }` rows — the exact set
-     * `clearPreferenceOverrides` reverts. Backs the confirmation diff shown
-     * before "Reset to defaults" (mirrors the per-track changes dialog). A
-     * scalar pref (animationMode, scrollZoom) whose override equals the
-     * default is omitted (reverting it is a no-op); each promoted
-     * per-display-type default is always a difference from the un-promoted
-     * state, so `from` reads "(default)".
+     * every scalar preference override that currently differs from its
+     * config/admin default, as `{ path, from, to }` rows whose path is the
+     * override's own key. A scalar pref (animationMode, scrollZoom) whose
+     * override equals the default is omitted, since reverting it is a no-op.
+     * Promoted display-type defaults share the map but are not here: they
+     * are `getDisplayTypeDefaults`, and the Preferences dialog lists them
+     * through one builder on both of its surfaces.
      */
     getPreferenceChanges(): TrackConfigChange[];
 } & {
@@ -261,19 +257,6 @@ export declare function BaseSessionModel<ROOT_MODEL_TYPE extends BaseRootModelTy
      * Preferences dialog "Reset to defaults" confirmation.
      */
     clearPreferenceOverride(key: string): void;
-    /**
-     * #action
-     * revert one row emitted by `getPreferenceChanges`, addressed by its
-     * display `path`. Backs the per-entry reset in the Preferences dialog's
-     * "Reset to defaults" confirmation.
-     *
-     * Lives here rather than in that dialog because this model owns both path
-     * shapes it has to undo: a promoted per-display-type default, whose row
-     * path is a readable label over a flat composite storage key, and every
-     * other override, whose path *is* its key. The dialog used to re-derive
-     * the first case from an exported path-head constant.
-     */
-    resetPreferenceChange(path: string[]): void;
     /**
      * #action
      * set the global scroll-to-zoom preference (see the `scrollZoom` getter)
@@ -322,6 +305,8 @@ export declare function BaseSessionModel<ROOT_MODEL_TYPE extends BaseRootModelTy
     pushSnackbarMessage(message: string, level?: import("@jbrowse/core/util").NotificationLevel, actions?: import("@jbrowse/core/util").SnackAction[]): void;
     popSnackbarMessage(): import("@jbrowse/core/ui/SnackbarModel").SnackbarMessage | undefined;
     removeSnackbarMessage(message: string): void;
+} & {
+    afterAttach(): void;
 }, import("@jbrowse/mobx-state-tree")._NotCustomized, import("@jbrowse/mobx-state-tree")._NotCustomized>;
 /** Session mixin MST type for the most basic session */
 export type BaseSessionType = ReturnType<typeof BaseSessionModel>;

package/esm/Session/BaseSession.js

@@ -6,6 +6,7 @@ import { isFeature, unwrapFeature } from '@jbrowse/core/util/simpleFeature';
 import { ElementId } from '@jbrowse/core/util/types/mst';
 import { getParent, isStateTreeNode, types } from '@jbrowse/mobx-state-tree';
 import { observable } from 'mobx';
+import { applyDeveloperMode } from './developerMode.js';
 function isAnimationMode(val) {
     return val === 'system' || val === 'enabled' || val === 'disabled';
 }
@@ -38,18 +39,6 @@ function parseDisplayTypeDefaultKey(key) {
     const [displayType, slot] = rest.split('\0');
     return displayType && slot ? { displayType, slot } : undefined;
 }
-// Head of the display path a promoted default takes in a `getPreferenceChanges`
-// row: `[DISPLAY_TYPE_DEFAULTS_PATH_HEAD, displayType, slot]`. Purely a
-// readable row label, deliberately distinct from the flat
-// `DISPLAY_TYPE_DEFAULT_PREFIX` storage key above.
-//
-// Module-private, like the storage key: both the producer
-// (`getPreferenceChanges`) and the consumer (`resetPreferenceChange`) are
-// methods on this model, so the two path shapes this file emits are the only
-// ones it has to undo. It used to be exported for the Preferences dialog to
-// match on and re-route back through `setDisplayTypeDefault`, which meant a
-// rename on one side alone would silently no-op that dialog's per-row reset.
-const DISPLAY_TYPE_DEFAULTS_PATH_HEAD = 'displayTypeDefaults';
 /**
  * #stateModel BaseSessionModel
  *
@@ -244,11 +233,8 @@ export function BaseSessionModel(_pluginManager) {
          * `{ displayType, slot, value }` — the inventory the Preferences dialog
          * lists and clears one at a time (`setDisplayTypeDefault(…, undefined)`).
          *
-         * Here rather than filtered out of `getPreferenceChanges` by the dialog,
-         * because the composite-key layout is this file's: a consumer that
-         * recognized these rows by matching the path head is exactly the coupling
-         * `DISPLAY_TYPE_DEFAULTS_PATH_HEAD` stopped being exported over, where a
-         * rename on one side alone silently no-ops the other.
+         * Parsed here rather than by the dialog, because the composite-key
+         * layout is this file's and nothing outside it should depend on it.
          */
         getDisplayTypeDefaults() {
             const found = [];
@@ -262,31 +248,18 @@ export function BaseSessionModel(_pluginManager) {
         },
         /**
          * #method
-         * every runtime preference-override that currently differs from its
-         * config/admin default, as `{ path, from, to }` rows — the exact set
-         * `clearPreferenceOverrides` reverts. Backs the confirmation diff shown
-         * before "Reset to defaults" (mirrors the per-track changes dialog). A
-         * scalar pref (animationMode, scrollZoom) whose override equals the
-         * default is omitted (reverting it is a no-op); each promoted
-         * per-display-type default is always a difference from the un-promoted
-         * state, so `from` reads "(default)".
+         * every scalar preference override that currently differs from its
+         * config/admin default, as `{ path, from, to }` rows whose path is the
+         * override's own key. A scalar pref (animationMode, scrollZoom) whose
+         * override equals the default is omitted, since reverting it is a no-op.
+         * Promoted display-type defaults share the map but are not here: they
+         * are `getDisplayTypeDefaults`, and the Preferences dialog lists them
+         * through one builder on both of its surfaces.
          */
         getPreferenceChanges() {
             const changes = [];
             for (const [key, value] of self.preferencesOverrides.entries()) {
-                const dtd = parseDisplayTypeDefaultKey(key);
-                if (dtd) {
-                    changes.push({
-                        path: [
-                            DISPLAY_TYPE_DEFAULTS_PATH_HEAD,
-                            dtd.displayType,
-                            dtd.slot,
-                        ],
-                        from: undefined,
-                        to: value,
-                    });
-                }
-                else {
+                if (!key.startsWith(DISPLAY_TYPE_DEFAULT_PREFIX)) {
                     const dflt = this.getPreferenceDefault(key);
                     if (value !== dflt) {
                         changes.push({
@@ -417,27 +390,6 @@ export function BaseSessionModel(_pluginManager) {
         clearPreferenceOverride(key) {
             self.preferencesOverrides.delete(key);
         },
-        /**
-         * #action
-         * revert one row emitted by `getPreferenceChanges`, addressed by its
-         * display `path`. Backs the per-entry reset in the Preferences dialog's
-         * "Reset to defaults" confirmation.
-         *
-         * Lives here rather than in that dialog because this model owns both path
-         * shapes it has to undo: a promoted per-display-type default, whose row
-         * path is a readable label over a flat composite storage key, and every
-         * other override, whose path *is* its key. The dialog used to re-derive
-         * the first case from an exported path-head constant.
-         */
-        resetPreferenceChange(path) {
-            const [head, displayType, slot] = path;
-            if (head === DISPLAY_TYPE_DEFAULTS_PATH_HEAD && displayType && slot) {
-                this.setDisplayTypeDefault(displayType, slot, undefined);
-            }
-            else if (head) {
-                this.clearPreferenceOverride(head);
-            }
-        },
         /**
          * #action
          * set the global scroll-to-zoom preference (see the `scrollZoom` getter)
@@ -490,7 +442,16 @@ export function BaseSessionModel(_pluginManager) {
             self.queueOfDialogs = [...self.queueOfDialogs, [component, props]];
         },
     }));
-    return types.compose(baseModel, SnackbarModel());
+    return types.compose(baseModel, SnackbarModel()).actions(self => ({
+        // after the compose rather than in the afterAttach above, because the
+        // notices land in the snackbar this line is the first place to hold both
+        // halves of. Web and desktop reach it a second time once the user's stored
+        // overrides are loaded (`PreferencesSessionMixin`), and our MST fork
+        // auto-chains both hooks.
+        afterAttach() {
+            applyDeveloperMode(self);
+        },
+    }));
 }
 /** Type guard for BaseSession */
 export function isBaseSession(thing) {

package/esm/Session/MultipleViews.d.ts

@@ -1,4 +1,5 @@
 import type PluginManager from '@jbrowse/core/PluginManager';
+import type { ViewSnapshotInput } from '@jbrowse/core/PluginManager';
 import type { IBaseViewModel } from '@jbrowse/core/pluggableElementTypes';
 import type { IAnyStateTreeNode, Instance } from '@jbrowse/mobx-state-tree';
 /**
@@ -1659,7 +1660,6 @@ export declare function MultipleViewsSessionMixin(pluginManager: PluginManager):
     setPreferenceOverride(key: string, value: unknown): void;
     clearPreferenceOverrides(): void;
     clearPreferenceOverride(key: string): void;
-    resetPreferenceChange(path: string[]): void;
     setScrollZoom(flag: boolean): void;
     setDisplayTypeDefault(displayType: string, slot: string, value: unknown): void;
     setName(str: string): void;
@@ -1678,6 +1678,8 @@ export declare function MultipleViewsSessionMixin(pluginManager: PluginManager):
     pushSnackbarMessage(message: string, level?: import("@jbrowse/core/util").NotificationLevel, actions?: import("@jbrowse/core/util").SnackAction[]): void;
     popSnackbarMessage(): import("@jbrowse/core/ui/SnackbarModel").SnackbarMessage | undefined;
     removeSnackbarMessage(message: string): void;
+} & {
+    afterAttach(): void;
 } & {
     readonly visibleWidget: import("@jbrowse/core/util").Widget | undefined;
 } & {
@@ -1752,8 +1754,10 @@ export declare function MultipleViewsSessionMixin(pluginManager: PluginManager):
     orderViews(ids: string[]): void;
     /**
      * #action
+     * Requires the view type's state model to be loaded; for a lazily
+     * registered type use `launchView`.
      */
-    addView(typeName: string, initialState?: any): any;
+    addView<N extends string>(typeName: N, initialState?: NoInfer<ViewSnapshotInput<N>>): any;
     /**
      * #action
      * swap `view` for a new view of `typeName`, in the slot it occupied.
@@ -1783,7 +1787,7 @@ export declare function MultipleViewsSessionMixin(pluginManager: PluginManager):
      * its panel, and the launch that offers a replace is a click on that
      * view's own menu.
      */
-    replaceView(view: IBaseViewModel, typeName: string, initialState?: any): any;
+    replaceView<N extends string>(view: IBaseViewModel, typeName: N, initialState?: NoInfer<ViewSnapshotInput<N>>): any;
     /**
      * #action
      */
@@ -1845,6 +1849,16 @@ export declare function MultipleViewsSessionMixin(pluginManager: PluginManager):
      */
     resetUseWorkspaces(): void;
     afterAttach(): void;
+} & {
+    /**
+     * #action
+     * `addView` for view types whose state model may be lazily loaded. The
+     * view is not in `session.views` until the promise resolves.
+     * `getViewType` first so an unknown type name fails by that name; the
+     * snapshot walk skips unregistered names and covers the displays of the
+     * tracks a launch opens with.
+     */
+    launchView<N extends string>(typeName: N, initialState?: NoInfer<ViewSnapshotInput<N>>): Promise<any>;
 }, import("@jbrowse/mobx-state-tree")._NotCustomized, import("@jbrowse/mobx-state-tree").ModelSnapshotType<Omit<Omit<Omit<{
     id: import("@jbrowse/mobx-state-tree").IOptionalIType<import("@jbrowse/mobx-state-tree").ISimpleType<string>, [undefined]>;
     name: import("@jbrowse/mobx-state-tree").ISimpleType<string>;

package/esm/Session/MultipleViews.js

@@ -1,7 +1,6 @@
-import { applyOrderWithin, localStorageGetBoolean, localStorageSetBoolean, reorderWithin, } from '@jbrowse/core/util';
+import { applyOrderWithin, localStorageGetBoolean, localStorageSetBoolean, reorderWithin, scheduleDetachedDestroy, } from '@jbrowse/core/util';
 import { addDisposer, applyPatch, cast, detach, getMembers, getParent, hasParent, isReferenceType, isStateTreeNode, types, } from '@jbrowse/mobx-state-tree';
 import { autorun } from 'mobx';
-import { scheduleDetachedDestroy } from '../scheduleDetachedDestroy.js';
 import { BaseSessionModel, isBaseSession } from './BaseSession.js';
 import { DrawerWidgetSessionMixin } from './DrawerWidgets.js';
 // Whether `node` IS `view` or lives somewhere under it. A view can CONTAIN
@@ -54,10 +53,24 @@ function dropRefsInto(holder, view) {
     }
     return found;
 }
+// A session snapshot's `views`, or undefined for anything that is not one
+function viewsOfSessionSnapshot(snapshot) {
+    const views = typeof snapshot === 'object' && snapshot !== null && 'views' in snapshot
+        ? snapshot.views
+        : undefined;
+    return Array.isArray(views) ? views : undefined;
+}
 /**
  * #stateModel MultipleViewsSessionMixin
  */
 export function MultipleViewsSessionMixin(pluginManager) {
+    // an unknown type name passes through to fail at the union as it always has
+    function assertViewStateModelLoaded(typeName) {
+        if (pluginManager.getElementTypeRecord('view').has(typeName) &&
+            !pluginManager.getViewType(typeName).isStateModelLoaded) {
+            throw new Error(`state model for view type ${typeName} is not loaded yet — use launchView(), or await getViewType('${typeName}').loadStateModel() first`);
+        }
+    }
     return types
         .compose(BaseSessionModel(pluginManager), DrawerWidgetSessionMixin(pluginManager), types.model({
         /**
@@ -208,8 +221,11 @@ export function MultipleViewsSessionMixin(pluginManager) {
             },
             /**
              * #action
+             * Requires the view type's state model to be loaded; for a lazily
+             * registered type use `launchView`.
              */
-            addView(typeName, initialState = {}) {
+            addView(typeName, initialState) {
+                assertViewStateModelLoaded(typeName);
                 const length = self.views.push({
                     ...initialState,
                     type: typeName,
@@ -245,7 +261,8 @@ export function MultipleViewsSessionMixin(pluginManager) {
              * its panel, and the launch that offers a replace is a click on that
              * view's own menu.
              */
-            replaceView(view, typeName, initialState = {}) {
+            replaceView(view, typeName, initialState) {
+                assertViewStateModelLoaded(typeName);
                 // read before the removal, which is what makes both stale
                 const idx = self.views.indexOf(view);
                 // `idx` first, so a view already gone from the session short-circuits
@@ -305,7 +322,13 @@ export function MultipleViewsSessionMixin(pluginManager) {
              * lands, which is why ADR-069's rule stops there.
              */
             takeOutViewsMissingFrom(snapshot) {
-                const incoming = snapshot?.views ?? [];
+                const incoming = viewsOfSessionSnapshot(snapshot);
+                // an argument that is not a session snapshot used to read as "keep
+                // none" and close every view: an agent introspecting the actions
+                // called this with a tab id and a keep-list and lost its session
+                if (!incoming) {
+                    throw new Error('takeOutViewsMissingFrom takes a session snapshot (it is what undo and redo call to close the views a snapshot no longer has); to close one view, session.removeView(view)');
+                }
                 const kept = new Map(incoming.map(v => [v.id, v.type]));
                 // a copy, because `takeOut` splices the array it is iterating
                 for (const view of [...self.views]) {
@@ -359,6 +382,23 @@ export function MultipleViewsSessionMixin(pluginManager) {
             },
         };
     })
+        .actions(self => ({
+        /**
+         * #action
+         * `addView` for view types whose state model may be lazily loaded. The
+         * view is not in `session.views` until the promise resolves.
+         * `getViewType` first so an unknown type name fails by that name; the
+         * snapshot walk skips unregistered names and covers the displays of the
+         * tracks a launch opens with.
+         */
+        async launchView(typeName, initialState) {
+            await pluginManager.getViewType(typeName).loadStateModel();
+            await pluginManager.preloadSessionTypes({
+                views: [{ type: typeName, ...initialState }],
+            });
+            return self.addView(typeName, initialState);
+        },
+    }))
         .postProcessSnapshot(snap => {
         // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
         if (!snap) {

package/esm/Session/Preferences.d.ts

@@ -1641,7 +1641,6 @@ export declare function PreferencesSessionMixin(pluginManager: PluginManager): i
     setPreferenceOverride(key: string, value: unknown): void;
     clearPreferenceOverrides(): void;
     clearPreferenceOverride(key: string): void;
-    resetPreferenceChange(path: string[]): void;
     setScrollZoom(flag: boolean): void;
     setDisplayTypeDefault(displayType: string, slot: string, value: unknown): void;
     setName(str: string): void;
@@ -1662,4 +1661,6 @@ export declare function PreferencesSessionMixin(pluginManager: PluginManager): i
     removeSnackbarMessage(message: string): void;
 } & {
     afterAttach(): void;
+} & {
+    afterAttach(): void;
 }, import("@jbrowse/mobx-state-tree")._NotCustomized, import("@jbrowse/mobx-state-tree")._NotCustomized>;

package/esm/Session/Preferences.js

@@ -3,6 +3,7 @@ import { freezeDeep } from '@jbrowse/core/util/freezeDeep';
 import { addDisposer, types } from '@jbrowse/mobx-state-tree';
 import { autorun } from 'mobx';
 import { BaseSessionModel } from './BaseSession.js';
+import { applyDeveloperMode } from './developerMode.js';
 const PREFS_KEY = 'jbrowsePreferences';
 function loadStoredPreferences() {
     const stored = localStorageGetItem(PREFS_KEY);
@@ -43,6 +44,10 @@ export function PreferencesSessionMixin(pluginManager) {
             // main-thread update would leave the app formatted two ways at once.
             // The dialog says a reload is needed; this is where the reload lands.
             setNumberGrouping(self.numberGrouping);
+            // and the same second pass for the developer-notice channel, whose
+            // admin default BaseSession already read: a user's stored override is
+            // only loaded a line above this
+            applyDeveloperMode(self);
             addDisposer(self, autorun(function persistPreferences() {
                 // observable.map doesn't JSON-serialize to an object on its own;
                 // fromEntries also reads every key so the autorun re-persists on

package/esm/Session/SessionTracks.d.ts

@@ -1670,7 +1670,6 @@ export declare function SessionTracksManagerSessionMixin(pluginManager: PluginMa
     setPreferenceOverride(key: string, value: unknown): void;
     clearPreferenceOverrides(): void;
     clearPreferenceOverride(key: string): void;
-    resetPreferenceChange(path: string[]): void;
     setScrollZoom(flag: boolean): void;
     setDisplayTypeDefault(displayType: string, slot: string, value: unknown): void;
     setName(str: string): void;
@@ -1689,6 +1688,8 @@ export declare function SessionTracksManagerSessionMixin(pluginManager: PluginMa
     pushSnackbarMessage(message: string, level?: import("@jbrowse/core/util").NotificationLevel, actions?: import("@jbrowse/core/util").SnackAction[]): void;
     popSnackbarMessage(): import("@jbrowse/core/ui/SnackbarModel").SnackbarMessage | undefined;
     removeSnackbarMessage(message: string): void;
+} & {
+    afterAttach(): void;
 } & {
     getReferringMultiple(trackIds: string[]): Map<string, import("./ReferenceManagement.ts").ReferringNode[]>;
 } & {
@@ -1700,6 +1701,8 @@ export declare function SessionTracksManagerSessionMixin(pluginManager: PluginMa
 } & {
     getTrackById(id: string): AnyConfigurationModel | undefined;
     getTracksById(): Record<string, AnyConfigurationModel>;
+} & {
+    afterAttach(): void;
 } & {
     addSessionTrackConf(trackConf: AnyConfiguration): any;
     publishTrackConf(trackConf: AnyConfiguration): any;

package/esm/Session/SessionTracks.js

@@ -4,6 +4,7 @@ import { expandLooseTrackConfig } from '@jbrowse/core/util/tracks';
 import { applySnapshot, getSnapshot, isStateTreeNode, types, } from '@jbrowse/mobx-state-tree';
 import { compareStructural } from 'mobx';
 import { TracksManagerSessionMixin } from './Tracks.js';
+import { assertNotReaddedDifferently } from './readdedTrackConf.js';
 import { assertTrackConfOutlivesItsAssemblies } from './temporaryAssemblyTracks.js';
 // jbrowse.tracks holds frozen plain objects (app-core, web/desktop) or MST
 // config nodes (product-core, embedded react views); the delta math reads both
@@ -342,6 +343,13 @@ export function SessionTracksManagerSessionMixin(pluginManager) {
             // and dropping its trackConfigDeltas override semantics.
             const existing = self.getTrackById(trackId);
             if (existing) {
+                if (self.sessionTracks.includes(existing)) {
+                    assertNotReaddedDifferently(pluginManager, existing, {
+                        ...trackConf,
+                        trackId,
+                        type,
+                    });
+                }
                 return existing;
             }
             // sessionTracks is a typed MST array (unlike the frozen

package/esm/Session/TrackMenu.js

@@ -44,7 +44,7 @@ export function trackActionItems({ session, config, view, canEdit, isSessionOver
     // visitor is served, one per click since the copy's stamped trackId defeats
     // the dedupe, and a non-admin's lands as the dead `sessionTracks` entry
     // ADR-084 removed the sweep for. Neither is worth offering, so the item says
-    // so instead of producing garbage; the dev-only contract check on the adders
+    // so instead of producing garbage; the contract check on the adders
     // is what found this.
     //
     // Greying a row tells nobody anything, and this reason is one nobody guesses:
@@ -86,7 +86,7 @@ export function trackActionItems({ session, config, view, canEdit, isSessionOver
             onClick: () => {
                 const snap = makeCopy();
                 if (session.publishTrackConf(snap)) {
-                    view.showTrack(snap.trackId);
+                    void view.launchTrack(snap.trackId);
                 }
             },
         },

package/esm/Session/Tracks.d.ts

@@ -1638,7 +1638,6 @@ export declare function TracksManagerSessionMixin(pluginManager: PluginManager):
     setPreferenceOverride(key: string, value: unknown): void;
     clearPreferenceOverrides(): void;
     clearPreferenceOverride(key: string): void;
-    resetPreferenceChange(path: string[]): void;
     setScrollZoom(flag: boolean): void;
     setDisplayTypeDefault(displayType: string, slot: string, value: unknown): void;
     setName(str: string): void;
@@ -1657,6 +1656,8 @@ export declare function TracksManagerSessionMixin(pluginManager: PluginManager):
     pushSnackbarMessage(message: string, level?: import("@jbrowse/core/util").NotificationLevel, actions?: import("@jbrowse/core/util").SnackAction[]): void;
     popSnackbarMessage(): import("@jbrowse/core/ui/SnackbarModel").SnackbarMessage | undefined;
     removeSnackbarMessage(message: string): void;
+} & {
+    afterAttach(): void;
 } & {
     getReferringMultiple(trackIds: string[]): Map<string, import("./ReferenceManagement.ts").ReferringNode[]>;
 } & {
@@ -1689,6 +1690,8 @@ export declare function TracksManagerSessionMixin(pluginManager: PluginManager):
      * @deprecated
      */
     getTracksById(): Record<string, AnyConfigurationModel>;
+} & {
+    afterAttach(): void;
 } & {
     /**
      * #action
@@ -1734,10 +1737,6 @@ export declare function TracksManagerSessionMixin(pluginManager: PluginManager):
      * session, which is the destination every such caller wanted: a track a
      * plugin stands up for one user is not a catalog entry. Nothing in tree
      * may call it — `no-restricted-syntax` says so.
-     *
-     * Spelled out rather than delegating through `this`, for the reason
-     * `SessionTracks.addToSession` is a plain closure: an action whose return
-     * type is inferred from a sibling's makes the pair circular.
      */
     addTrackConf(trackConf: AnyConfiguration): any;
     /**