@jbrowse/plugin-legacy-jbrowse 1.4.4 → 1.5.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jbrowse/plugin-legacy-jbrowse",
-  "version": "1.4.4",
+  "version": "1.5.3",
   "description": "JBrowse 2 plugin for connecting to and reading JBrowse 1 data",
   "keywords": [
     "jbrowse",
@@ -36,8 +36,10 @@
   },
   "dependencies": {
     "@gmod/nclist": "^0.1.1",
+    "buffer-crc32": "^0.2.13",
+    "generic-filehandle": "^2.2.2",
     "get-value": "^3.0.1",
-    "set-value": "^3.0.0"
+    "set-value": "^4.0.1"
   },
   "peerDependencies": {
     "@jbrowse/core": "^1.0.0",
@@ -47,5 +49,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "c12a2b1cef07dbc5ea40be5c76e03b655b7f3636"
+  "gitHead": "cea9023ebce8bbe5c08ae9e00c4e74fe3f02a7f1"
 }

package/src/JBrowse1Connection/configSchema.ts

@@ -6,7 +6,10 @@ export default ConfigurationSchema(
   {
     dataDirLocation: {
       type: 'fileLocation',
-      defaultValue: { uri: 'http://mysite.com/jbrowse/data/' },
+      defaultValue: {
+        uri: 'http://mysite.com/jbrowse/data/',
+        locationType: 'UriLocation',
+      },
       description:
         'the location of the JBrowse 1 data directory, often something like http://mysite.com/jbrowse/data/',
     },

package/src/JBrowse1Connection/jb1ConfigLoad.ts

@@ -21,11 +21,11 @@ function isLocalPathLocation(
 }
 
 export async function fetchJb1(
-  dataRoot: JBLocation = { uri: '' },
+  dataRoot: JBLocation = { uri: '', locationType: 'UriLocation' },
   baseConfig: Config = {
     include: ['{dataRoot}/trackList.json', '{dataRoot}/tracks.conf'],
   },
-  baseConfigRoot: JBLocation = { uri: '' },
+  baseConfigRoot: JBLocation = { uri: '', locationType: 'UriLocation' },
 ): Promise<Config> {
   const protocol = 'uri' in dataRoot ? 'uri' : 'localPath'
   const dataRootReg = JSON.parse(JSON.stringify(dataRoot))
@@ -224,15 +224,14 @@ async function loadIncludes(inputConfig: Config): Promise<Config> {
     )
     delete config.include
 
-    const loads = includes.map(
-      async (include): Promise<Config> => {
-        include.cacheBuster = inputConfig.cacheBuster
-        const includedData = await fetchConfigFile({
-          uri: new URL(include.url, sourceUrl).href,
-        })
-        return loadRecur(includedData, newUpstreamConf)
-      },
-    )
+    const loads = includes.map(async (include): Promise<Config> => {
+      include.cacheBuster = inputConfig.cacheBuster
+      const includedData = await fetchConfigFile({
+        uri: new URL(include.url, sourceUrl).href,
+        locationType: 'UriLocation',
+      })
+      return loadRecur(includedData, newUpstreamConf)
+    })
     const includedDataObjects = await Promise.all(loads)
     includedDataObjects.forEach((includedData): void => {
       config = mergeConfigs(config, includedData) || config
@@ -255,23 +254,21 @@ function regularizeIncludes(
     includes = [includes]
   }
 
-  return includes.map(
-    (include): Include => {
-      // coerce bare strings in the includes to URLs
-      if (typeof include === 'string') {
-        include = { url: include }
-      }
+  return includes.map((include): Include => {
+    // coerce bare strings in the includes to URLs
+    if (typeof include === 'string') {
+      include = { url: include }
+    }
 
-      // set defaults for format and version
-      if (!('format' in include)) {
-        include.format = include.url.endsWith('.conf') ? 'conf' : 'JB_json'
-      }
-      if (include.format === 'JB_json' && !('version' in include)) {
-        include.version = 1
-      }
-      return include
-    },
-  )
+    // set defaults for format and version
+    if (!('format' in include)) {
+      include.format = include.url.endsWith('.conf') ? 'conf' : 'JB_json'
+    }
+    if (include.format === 'JB_json' && !('version' in include)) {
+      include.version = 1
+    }
+    return include
+  })
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any

package/src/JBrowse1Connection/jb1ConfigParse.ts

@@ -208,19 +208,17 @@ export function regularizeConf(conf: Config, url: string): Config {
     }
 
     // coerce any string source defs to be URLs, and try to detect their types
-    meta.sources = meta.sources.map(
-      (sourceDef: string | Source): Source => {
-        if (typeof sourceDef === 'string') {
-          const newSourceDef: Source = { url: sourceDef }
-          const typeMatch = sourceDef.match(/\.(\w+)$/)
-          if (typeMatch) {
-            newSourceDef.type = typeMatch[1].toLowerCase()
-          }
-          return newSourceDef
+    meta.sources = meta.sources.map((sourceDef: string | Source): Source => {
+      if (typeof sourceDef === 'string') {
+        const newSourceDef: Source = { url: sourceDef }
+        const typeMatch = sourceDef.match(/\.(\w+)$/)
+        if (typeMatch) {
+          newSourceDef.type = typeMatch[1].toLowerCase()
         }
-        return sourceDef
-      },
-    )
+        return newSourceDef
+      }
+      return sourceDef
+    })
   }
 
   conf.sourceUrl = conf.sourceUrl || url

package/src/JBrowse1Connection/jb1ToJb2.ts

@@ -51,6 +51,7 @@ interface Jb2Location {
   uri?: string
   localPath?: string
   blobId?: string
+  locationType?: string
 }
 
 export function convertTrackConfig(
@@ -102,19 +103,27 @@ export function convertTrackConfig(
     if (storeClass === 'JBrowse/Store/SeqFeature/BAM') {
       const adapter: Jb2Adapter = {
         type: 'BamAdapter',
-        bamLocation: { uri: urlTemplate },
+        bamLocation: { uri: urlTemplate, locationType: 'UriLocation' },
       }
       if (jb1TrackConfig.baiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.baiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.baiUrlTemplate),
+            locationType: 'UriLocation',
+          },
         }
       } else if (jb1TrackConfig.csiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate),
+            locationType: 'UriLocation',
+          },
           indexType: 'CSI',
         }
       } else {
-        adapter.index = { location: { uri: `${urlTemplate}.bai` } }
+        adapter.index = {
+          location: { uri: `${urlTemplate}.bai`, locationType: 'UriLocation' },
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -125,15 +134,19 @@ export function convertTrackConfig(
     if (storeClass === 'JBrowse/Store/SeqFeature/CRAM') {
       const adapter: Jb2Adapter = {
         type: 'CramAdapter',
-        cramLocation: { uri: urlTemplate },
+        cramLocation: { uri: urlTemplate, locationType: 'UriLocation' },
         sequenceAdapter,
       }
       if (jb1TrackConfig.craiUrlTemplate) {
         adapter.craiLocation = {
           uri: resolveUrlTemplate(jb1TrackConfig.craiUrlTemplate),
+          locationType: 'UriLocation',
         }
       } else {
-        adapter.craiLocation = { uri: `${urlTemplate}.crai` }
+        adapter.craiLocation = {
+          uri: `${urlTemplate}.crai`,
+          locationType: 'UriLocation',
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -147,7 +160,7 @@ export function convertTrackConfig(
         type: 'FeatureTrack',
         adapter: {
           type: 'NCListAdapter',
-          rootUrlTemplate: { uri: urlTemplate },
+          rootUrlTemplate: { uri: urlTemplate, locationType: 'UriLocation' },
         },
       }
     }
@@ -168,26 +181,34 @@ export function convertTrackConfig(
         type: 'QuantitativeTrack',
         adapter: {
           type: 'BigWigAdapter',
-          bigWigLocation: { uri: urlTemplate },
+          bigWigLocation: { uri: urlTemplate, locationType: 'UriLocation' },
         },
       }
     }
     if (storeClass === 'JBrowse/Store/SeqFeature/VCFTabix') {
       const adapter: Jb2Adapter = {
         type: 'VcfTabixAdapter',
-        vcfGzLocation: { uri: urlTemplate },
+        vcfGzLocation: { uri: urlTemplate, locationType: 'UriLocation' },
       }
       if (jb1TrackConfig.tbiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.tbiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.tbiUrlTemplate),
+            locationType: 'UriLocation',
+          },
         }
       } else if (jb1TrackConfig.csiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate),
+            locationType: 'UriLocation',
+          },
           indexType: 'CSI',
         }
       } else {
-        adapter.index = { location: { uri: `${urlTemplate}.tbi` } }
+        adapter.index = {
+          location: { uri: `${urlTemplate}.tbi`, locationType: 'UriLocation' },
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -215,26 +236,34 @@ export function convertTrackConfig(
         type: 'FeatureTrack',
         adapter: {
           type: 'BigBedAdapter',
-          bigBedLocation: { uri: urlTemplate },
+          bigBedLocation: { uri: urlTemplate, locationType: 'UriLocation' },
         },
       }
     }
     if (storeClass === 'JBrowse/Store/SeqFeature/GFF3Tabix') {
       const adapter: Jb2Adapter = {
         type: 'Gff3TabixAdapter',
-        gffGzLocation: { uri: urlTemplate },
+        gffGzLocation: { uri: urlTemplate, locationType: 'UriLocation' },
       }
       if (jb1TrackConfig.tbiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.tbiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.tbiUrlTemplate),
+            locationType: 'UriLocation',
+          },
         }
       } else if (jb1TrackConfig.csiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate),
+            locationType: 'UriLocation',
+          },
           indexType: 'CSI',
         }
       } else {
-        adapter.index = { location: { uri: `${urlTemplate}.tbi` } }
+        adapter.index = {
+          location: { uri: `${urlTemplate}.tbi`, locationType: 'UriLocation' },
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -252,19 +281,27 @@ export function convertTrackConfig(
     if (storeClass === 'JBrowse/Store/SeqFeature/BEDTabix') {
       const adapter: Jb2Adapter = {
         type: 'BedTabixAdapter',
-        bedGzLocation: { uri: urlTemplate },
+        bedGzLocation: { uri: urlTemplate, locationType: 'UriLocation' },
       }
       if (jb1TrackConfig.tbiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.tbiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.tbiUrlTemplate),
+            locationType: 'UriLocation',
+          },
         }
       } else if (jb1TrackConfig.csiUrlTemplate) {
         adapter.index = {
-          location: { uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate) },
+          location: {
+            uri: resolveUrlTemplate(jb1TrackConfig.csiUrlTemplate),
+            locationType: 'UriLocation',
+          },
           indexType: 'CSI',
         }
       } else {
-        adapter.index = { location: { uri: `${urlTemplate}.tbi` } }
+        adapter.index = {
+          location: { uri: `${urlTemplate}.tbi`, locationType: 'UriLocation' },
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -299,14 +336,18 @@ export function convertTrackConfig(
     if (storeClass === 'JBrowse/Store/SeqFeature/IndexedFasta') {
       const adapter: Jb2Adapter = {
         type: 'IndexedFastaAdapter',
-        fastaLocation: { uri: urlTemplate },
+        fastaLocation: { uri: urlTemplate, locationType: 'UriLocation' },
       }
       if (jb1TrackConfig.faiUrlTemplate) {
         adapter.faiLocation = {
           uri: resolveUrlTemplate(jb1TrackConfig.faiUrlTemplate),
+          locationType: 'UriLocation',
         }
       } else {
-        adapter.faiLocation = { uri: `${urlTemplate}.fai` }
+        adapter.faiLocation = {
+          uri: `${urlTemplate}.fai`,
+          locationType: 'UriLocation',
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -317,21 +358,29 @@ export function convertTrackConfig(
     if (storeClass === 'JBrowse/Store/SeqFeature/BgzipIndexedFasta') {
       const adapter: Jb2Adapter = {
         type: 'BgzipFastaAdapter',
-        fastaLocation: { uri: urlTemplate },
+        fastaLocation: { uri: urlTemplate, locationType: 'UriLocation' },
       }
       if (jb1TrackConfig.faiUrlTemplate) {
         adapter.faiLocation = {
           uri: resolveUrlTemplate(jb1TrackConfig.faiUrlTemplate),
+          locationType: 'UriLocation',
         }
       } else {
-        adapter.faiLocation = { uri: `${urlTemplate}.fai` }
+        adapter.faiLocation = {
+          uri: `${urlTemplate}.fai`,
+          locationType: 'UriLocation',
+        }
       }
       if (jb1TrackConfig.gziUrlTemplate) {
         adapter.gziLocation = {
           uri: resolveUrlTemplate(jb1TrackConfig.gziUrlTemplate),
+          locationType: 'UriLocation',
         }
       } else {
-        adapter.gziLocation = { uri: `${urlTemplate}.gzi` }
+        adapter.gziLocation = {
+          uri: `${urlTemplate}.gzi`,
+          locationType: 'UriLocation',
+        }
       }
       return {
         ...jb2TrackConfig,
@@ -345,7 +394,7 @@ export function convertTrackConfig(
         type: 'ReferenceSequenceTrack',
         adapter: {
           type: 'TwoBitAdapter',
-          twoBitLocation: { uri: urlTemplate },
+          twoBitLocation: { uri: urlTemplate, locationType: 'UriLocation' },
         },
       }
     }
@@ -353,9 +402,9 @@ export function convertTrackConfig(
 
   // If we don't recogize the store class, make a best effort to guess by file type
   jb2TrackConfig.adapter = guessAdapter(
-    { uri: urlTemplate },
+    { uri: urlTemplate, locationType: 'UriLocation' },
     undefined,
-    () => urlTemplate,
+    urlTemplate,
   )
   if (!jb2TrackConfig.adapter) {
     throw new Error('Could not determine adapter')
@@ -394,16 +443,14 @@ function generateFromConfigTrackConfig(
   jb2TrackConfig: Jb2Track,
 ): Jb2Track {
   const jb1Features = jb1TrackConfig.features || []
-  const jb2Features = jb1Features.map(
-    (feature): Jb2Feature => {
-      const jb2Feature: Jb2Feature = JSON.parse(JSON.stringify(feature))
-      jb2Feature.refName = feature.seq_id
-      jb2Feature.uniqueId = `${feature.seq_id}:${feature.start}-${
-        feature.end
-      }:${feature.name || ''}`
-      return jb2Feature
-    },
-  )
+  const jb2Features = jb1Features.map((feature): Jb2Feature => {
+    const jb2Feature: Jb2Feature = JSON.parse(JSON.stringify(feature))
+    jb2Feature.refName = feature.seq_id
+    jb2Feature.uniqueId = `${feature.seq_id}:${feature.start}-${feature.end}:${
+      feature.name || ''
+    }`
+    return jb2Feature
+  })
   jb2TrackConfig.adapter = {
     type: 'FromConfigAdapter',
     features: jb2Features,
@@ -429,16 +476,18 @@ export async function createRefSeqsAdapter(
         type: 'IndexedFastaAdapter',
         fastaLocation: {
           uri: refSeqs.url.slice(0, -4),
+          locationType: 'UriLocation',
         },
         faiLocation: {
           uri: refSeqs.url,
+          locationType: 'UriLocation',
         },
       }
     }
     if (refSeqs.url.match(/.2bit$/)) {
       return {
         type: 'TwoBitAdapter',
-        twoBitLocation: { uri: refSeqs.url },
+        twoBitLocation: { uri: refSeqs.url, locationType: 'UriLocation' },
       }
     }
     if (refSeqs.url.match(/.fa$/)) {
@@ -447,9 +496,10 @@ export async function createRefSeqsAdapter(
     if (refSeqs.url.match(/.sizes/)) {
       throw new Error('chromosome SIZES adapter not available')
     }
-    const refSeqsJson = await openLocation({ uri: refSeqs.url }).readFile(
-      'utf8',
-    )
+    const refSeqsJson = await openLocation({
+      uri: refSeqs.url,
+      locationType: 'UriLocation',
+    }).readFile('utf8')
     const refSeqsData: RefSeq[] = JSON.parse(refSeqsJson as string)
     return refSeqAdapterFromConfig(refSeqsData)
   }

package/src/JBrowse1Connection/types.ts

@@ -94,10 +94,12 @@ export interface Config {
 export interface UriLocation {
   uri: string
   baseUri?: string
+  locationType: 'UriLocation'
 }
 
 export interface LocalPathLocation {
   localPath: string
+  locationType: 'LocalPathLocation'
 }
 
 export type JBLocation = UriLocation | LocalPathLocation

package/src/JBrowse1TextSeachAdapter/HttpMap.test.ts

@@ -22,19 +22,13 @@ describe('test JBrowse1 hash implementation', () => {
     spy.mockImplementation(mockFetch as any)
     const hashMap = new HttpMap({
       url: rootTemplate,
-      isElectron: false,
     })
-    const headers = {
-      'Access-Control-Allow-Origin': '*',
-      'Content-Type': 'application/json',
-    }
+
     await hashMap.getBucket('apple')
-    expect(spy).toHaveBeenNthCalledWith(1, `${rootTemplate}/meta.json`, {
-      headers,
-    })
+
     // test compress and hash hex characters are set after initial search
-    expect(hashMap.compress).toBe(0)
-    expect(hashMap.hash_hex_characters).toBe(1)
+    expect(await hashMap.getHashHexCharacters()).toBe(1)
+    expect(await hashMap.getCompress()).toBe(0)
   })
   test('get bucket contents', async () => {
     function mockFetch(url: string): Promise<Response> {
@@ -59,18 +53,12 @@ describe('test JBrowse1 hash implementation', () => {
     spy.mockImplementation(mockFetch as any)
     const hashMap = new HttpMap({
       url: rootTemplate,
-      isElectron: false,
     })
-    const headers = {
-      'Access-Control-Allow-Origin': '*',
-      'Content-Type': 'application/json',
-    }
+
     await hashMap.getBucket('apple')
-    expect(spy).toHaveBeenNthCalledWith(1, `${rootTemplate}/meta.json`, {
-      headers,
-    })
-    expect(spy).toHaveBeenLastCalledWith(`${rootTemplate}/0.json`, { headers })
+    expect(spy).toHaveBeenLastCalledWith(`${rootTemplate}/0.json`)
+
     await hashMap.getBucket('apple3')
-    expect(spy).toHaveBeenLastCalledWith(`${rootTemplate}/f.json`, { headers })
+    expect(spy).toHaveBeenLastCalledWith(`${rootTemplate}/f.json`)
   })
 })

package/src/JBrowse1TextSeachAdapter/HttpMap.ts

@@ -1,75 +1,38 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 /*
  * Helper class allows reading names index generated in JBrowse1
  * Adapted from https://github.com/GMOD/jbrowse/blob/master/src/JBrowse/Store/Hash.js
  */
-import { crc32 } from './Crc32'
+import crc32 from 'buffer-crc32'
 
 export default class HttpMap {
   url: string
 
-  isElectron: boolean
-
-  hash_hex_characters?: number
-
-  compress?: number
-
-  tracks?: string[]
-
-  constructor(args: { url: string; isElectron: boolean }) {
+  constructor(args: { url: string }) {
     // make sure url has a trailing slash
     this.url = /\/$/.test(args.url) ? args.url : `${args.url}/`
-
-    this.isElectron = args.isElectron
   }
 
   /**
    * loads meta.json file from names directory and reads number of hash_bits used
    */
   async readMeta() {
-    try {
-      const meta = await this.loadFile('meta.json')
-      if (meta !== {}) {
-        const { compress, track_names: tracks } = meta
-        this.compress = compress
-        const hashHexCharacters = Math.ceil(meta.hash_bits / 4)
-        this.hash_hex_characters = hashHexCharacters
-        this.tracks = tracks
-        return { hashHexCharacters, compress, tracks }
-      }
-      throw new Error('Error parsing meta.json')
-
-      // const { compress } = meta
-      // this.compress = compress
-      // const hashHexCharacters = Math.ceil(meta.hash_bits / 4)
-      // this.hash_hex_characters = hashHexCharacters
-    } catch (err) {
-      // throw Error(err)
-      console.warn(`Error: ${err}`)
-    }
-    return {}
+    const meta = await this.loadFile('meta.json')
+    const { compress, track_names: tracks } = meta
+    const hashHexCharacters = Math.ceil(meta.hash_bits / 4)
+    return { hashHexCharacters, compress, tracks }
   }
 
   async getHashHexCharacters() {
-    if (this.hash_hex_characters) {
-      return this.hash_hex_characters
-    }
     const meta = await this.readMeta()
     return meta.hashHexCharacters
   }
 
   async getCompress() {
-    if (this.compress) {
-      return this.compress
-    }
     const meta = await this.readMeta()
     return meta.compress
   }
 
   async getTrackNames() {
-    if (this.tracks) {
-      return this.tracks
-    }
     const meta = await this.readMeta()
     return meta.tracks
   }
@@ -79,7 +42,7 @@ export default class HttpMap {
    * @param key - string
    */
   async get(key: string) {
-    const bucket: Record<string, any> = await this.getBucket(key)
+    const bucket = await this.getBucket(key)
     return bucket[key]
   }
 
@@ -89,17 +52,8 @@ export default class HttpMap {
    */
   async getBucket(key: string) {
     const bucketIdent = this.hash(key)
-    try {
-      const hexToDirPath = await this.hexToDirPath(bucketIdent)
-      const value = await this.loadFile(hexToDirPath)
-      return value
-    } catch (err) {
-      if (this.isElectron || err.status === 404) {
-        // 404 is expected if the name is not in the store
-        return {}
-      }
-    }
-    return {}
+    const hexToDirPath = await this.hexToDirPath(bucketIdent)
+    return this.loadFile(hexToDirPath)
   }
 
   /**
@@ -108,21 +62,11 @@ export default class HttpMap {
    * @param id - string
    */
   async loadFile(id: string) {
-    const response = await fetch(`${this.url}${id}`, {
-      headers: {
-        'Content-Type': 'application/json',
-        'Access-Control-Allow-Origin': '*',
-      },
-    })
-    try {
-      const data = await response.json()
-      return data
-    } catch (err) {
-      // handle error
-      // throw Error(err)
-      console.warn(`Error: ${err}`)
+    const response = await fetch(`${this.url}${id}`)
+    if (!response.ok) {
+      throw new Error(`HTTP ${response.status} ${response.statusText}`)
     }
-    return {}
+    return response.json()
   }
 
   /**
@@ -147,12 +91,10 @@ export default class HttpMap {
     return ''
   }
 
-  /**
-   * Returns crc32 hash given a string.
-   * (Note: this is using JBrowse1 implementation of crc32.)
-   * @param data - string
-   */
   hash(data: string) {
-    return crc32(data).toString(16).toLowerCase().replace('-', 'n')
+    return crc32(Buffer.from(data))
+      .toString('hex')
+      .toLowerCase()
+      .replace('-', 'n')
   }
 }