@jbrowse/plugin-config 5.0.0-beta.10 → 5.0.0-beta.11

package/esm/ConfigurationEditorWidget/index.js

@@ -9,6 +9,7 @@ export default function registerConfigurationEditorWidget(pluginManager) {
     pluginManager.addWidgetType(() => {
         return new WidgetType({
             name: 'ConfigurationEditorWidget',
+            discardOnClose: true,
             HeadingComponent,
             configSchema,
             stateModel: stateModelFactory(pluginManager),

package/esm/ConfigurationEditorWidget/model.d.ts

@@ -15,4 +15,5 @@ export default function stateModelFactory(_pluginManager: PluginManager): import
     setTarget(newTarget: AnyConfigurationModel | undefined): void;
     setExpandedDisplayId(displayId: string | undefined): void;
     afterCreate(): void;
+    beforeDetach(): void;
 }, import("@jbrowse/mobx-state-tree")._NotCustomized, import("@jbrowse/mobx-state-tree")._NotCustomized>;

package/esm/ConfigurationEditorWidget/model.js

@@ -23,49 +23,54 @@ export default function stateModelFactory(_pluginManager) {
         // (incompatible/inactive) displays start collapsed
         expandedDisplayId: undefined,
     }))
-        .actions(self => ({
-        setTarget(newTarget) {
-            self.target = newTarget;
-        },
-        setExpandedDisplayId(displayId) {
-            self.expandedDisplayId = displayId;
-        },
-        afterCreate() {
-            let timeout;
-            // Auto-save configuration changes with 400ms debounce. The autorun
-            // reacts to any changes in the target configuration model and persists
-            // them back to the session after a short delay via
-            // updateTrackConfiguration, which routes admin edits to the jbrowse
-            // config in place and everyone else's to a shareable per-track delta
-            // (trackConfigDeltas) against the admin base. It keys off trackId; in
-            // practice the widget is only opened on track configs. A config with no
-            // trackId (assembly/connection) degrades gracefully: updateTrackConfiguration
-            // finds no base/session/connection home and the edit just applies to the
-            // live MST node in memory for this session.
-            //
-            // BaseTrackModel's afterAttach runs a sibling debounced save (a reaction
-            // on the same config node) for direct setSlot quick-edits on a *shown*
-            // track. Both intentionally coexist: this widget also handles an unshown
-            // track edited from the selector, which has no BaseTrackModel. When both
-            // fire they compute an identical delta, deduped in updateTrackConfiguration
-            // — don't drop one to "simplify".
-            addDisposer(self, autorun(() => {
-                if (self.target) {
-                    // track configs (the practical case) carry a trackId; a
-                    // trackId-less snapshot degrades to an in-memory edit (see above)
-                    const snapshot = getSnapshot(self.target);
+        .actions(self => {
+        let timeout;
+        let unsaved;
+        function save() {
+            clearTimeout(timeout);
+            if (unsaved) {
+                const session = getSession(self);
+                session.updateTrackConfiguration(unsaved);
+                unsaved = undefined;
+            }
+        }
+        return {
+            setTarget(newTarget) {
+                self.target = newTarget;
+            },
+            setExpandedDisplayId(displayId) {
+                self.expandedDisplayId = displayId;
+            },
+            afterCreate() {
+                // Auto-save configuration changes with 400ms debounce, through
+                // updateTrackConfiguration, which routes admin edits to the jbrowse
+                // config in place and everyone else's to a shareable per-track delta
+                // (trackConfigDeltas) against the admin base. A config with no
+                // trackId (assembly/connection) finds no home there, so the edit
+                // stays on the live MST node for this session.
+                //
+                // BaseTrackModel's afterAttach runs a sibling debounced save for
+                // direct setSlot quick-edits on a *shown* track. Both intentionally
+                // coexist: this widget also handles an unshown track edited from the
+                // selector, which has no BaseTrackModel. When both fire they compute
+                // an identical delta, deduped in updateTrackConfiguration — don't
+                // drop one to "simplify".
+                addDisposer(self, autorun(() => {
+                    if (self.target) {
+                        unsaved = getSnapshot(self.target);
+                        clearTimeout(timeout);
+                        timeout = setTimeout(save, 400);
+                    }
+                }));
+                addDisposer(self, () => {
                     clearTimeout(timeout);
-                    timeout = setTimeout(() => {
-                        const session = getSession(self);
-                        session.updateTrackConfiguration(snapshot);
-                    }, 400);
-                }
-            }));
-            // ensure a pending debounced save can't fire after disposal, where
-            // getSession(self) would throw on the now-detached node
-            addDisposer(self, () => {
-                clearTimeout(timeout);
-            });
-        },
-    }));
+                });
+            },
+            // closing the editor detaches it from the session, so an edit still
+            // inside the debounce saves now, while getSession(self) resolves
+            beforeDetach() {
+                save();
+            },
+        };
+    });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jbrowse/plugin-config",
-  "version": "5.0.0-beta.10",
+  "version": "5.0.0-beta.11",
   "type": "module",
   "description": "JBrowse 2 config utilities",
   "keywords": [
@@ -21,13 +21,13 @@
     "esm"
   ],
   "dependencies": {
-    "@jbrowse/mobx-state-tree": "^6.6.1",
+    "@jbrowse/mobx-state-tree": "^6.7.0",
     "@mui/icons-material": "^9.4.0",
     "@mui/material": "^9.4.0",
     "mobx": "^7.0.5",
     "mobx-react": "^10.0.2",
     "rxjs": "^7.8.2",
-    "@jbrowse/core": "^5.0.0-beta.10"
+    "@jbrowse/core": "^5.0.0-beta.11"
   },
   "peerDependencies": {
     "react": ">=19.0.0",