@jbrowse/embedded-core 5.0.0-beta.1 → 5.0.0-beta.11

package/esm/EmbeddedSessionMixin.js

@@ -8,18 +8,17 @@ import { EmbeddedSessionThemeMixin } from './EmbeddedSessionThemeMixin.js';
  * they compose and the three getters that read the root model. The twin of
  * {@link createEmbeddedRootModel} one level down.
  *
- * A mixin the product composes, deliberately, rather than a factory taking the
- * product's view type and tracks mixin as parameters. That factory is the
- * obvious shape and it does not work: `types.compose`'s overloads are declared
- * over `IModelType<P, O, FC, FS>`, so a model handed in as a naked type
- * parameter has nothing to infer those four from and the composed result
- * degrades — `session.view` becomes `any`, which typechecks at every embedder
- * call site and is caught by nothing. Keeping every argument to `compose`
- * concrete is what keeps the products' views typed.
+ * Each product composes this mixin. A factory taking the product's view type
+ * and tracks mixin as parameters does not typecheck usefully:
+ * `types.compose`'s overloads are declared over `IModelType<P, O, FC, FS>`, so
+ * a model passed as a naked type parameter gives nothing to infer those four
+ * from, and `session.view` becomes `any` at every embedder call site with no
+ * type error. Passing only concrete types to `compose` keeps the products'
+ * views typed.
  *
- * So each product still spells out its own tracks mixin, `view` prop, and the
- * `views`/`addView`/`removeView` members that read `self.view` — those are the
- * ones that need its concrete view type.
+ * Each product therefore declares its tracks mixin, `view` prop, and the
+ * `views`/`addView`/`removeView` members that read `self.view`, because those
+ * members need its concrete view type.
  */
 export function EmbeddedSessionMixin(pluginManager) {
     return types
@@ -28,6 +27,14 @@ export function EmbeddedSessionMixin(pluginManager) {
     // members, so their order relative to each other is not load-bearing
     ReferenceManagementSessionMixin(pluginManager), TrackMenuSessionMixin(pluginManager), EmbeddedSessionThemeMixin(pluginManager))
         .views(self => ({
+        /**
+         * #getter
+         * An embedded view is drawn with no title bar above it, so its menu lives
+         * in the view's own controls.
+         */
+        get viewTitleBars() {
+            return false;
+        },
         /**
          * #getter
          */
@@ -42,7 +49,7 @@ export function EmbeddedSessionMixin(pluginManager) {
         // them through `self.jbrowse` (= root.config), so re-declaring here would
         // just duplicate the base getters with looser types
         get assemblyNames() {
-            return [getParent(self).config.assemblyName];
+            return getParent(self).config.assemblyNames;
         },
         /**
          * #getter