@jbrowse/core 2.13.1 → 2.15.0

package/pluggableElementTypes/renderers/BoxRendererType.js

@@ -36,8 +36,7 @@ class LayoutSession {
      * @returns true if the given layout is a valid one to use for this session
      */
     cachedLayoutIsValid(cachedLayout) {
-        return (cachedLayout &&
-            cachedLayout.layout.subLayoutConstructorArgs.pitchX === this.bpPerPx &&
+        return (cachedLayout.layout.subLayoutConstructorArgs.pitchX === this.bpPerPx &&
             (0, fast_deep_equal_1.default)((0, configuration_1.readConfObject)(this.config), cachedLayout.config) &&
             (0, fast_deep_equal_1.default)(this.filters, cachedLayout.filters));
     }
@@ -67,18 +66,9 @@ class BoxRendererType extends FeatureRendererType_1.default {
         session.update(props);
         return session;
     }
-    // expands region for glyphs to use
     getExpandedRegion(region, renderArgs) {
-        if (!region) {
-            return region;
-        }
         const { bpPerPx, config } = renderArgs;
-        const maxFeatureGlyphExpansion = config === undefined
-            ? 0
-            : (0, configuration_1.readConfObject)(config, 'maxFeatureGlyphExpansion');
-        if (!maxFeatureGlyphExpansion) {
-            return region;
-        }
+        const maxFeatureGlyphExpansion = (0, configuration_1.readConfObject)(config, 'maxFeatureGlyphExpansion') || 0;
         const bpExpansion = Math.round(maxFeatureGlyphExpansion * bpPerPx);
         return {
             ...region,
@@ -92,16 +82,12 @@ class BoxRendererType extends FeatureRendererType_1.default {
     async freeResourcesInClient(rpcManager, args) {
         const { regions } = args;
         const key = (0, util_1.getLayoutId)(args);
-        let freed = 0;
         const session = this.sessions[key];
-        if (!regions && session) {
-            delete this.sessions[key];
-            freed = 1;
-        }
-        if (session && regions) {
-            session.layout.discardRange(regions[0].refName, regions[0].start, regions[0].end);
+        if (session) {
+            const region = regions[0];
+            session.layout.discardRange(region.refName, region.start, region.end);
         }
-        return freed + (await super.freeResourcesInClient(rpcManager, args));
+        return await super.freeResourcesInClient(rpcManager, args);
     }
     deserializeLayoutInClient(json) {
         return new PrecomputedLayout_1.default(json);
@@ -117,13 +103,11 @@ class BoxRendererType extends FeatureRendererType_1.default {
     }
     serializeResultsInWorker(results, args) {
         const serialized = super.serializeResultsInWorker(results, args);
-        const [region] = args.regions;
+        const region = args.regions[0];
         serialized.layout = results.layout.serializeRegion(this.getExpandedRegion(region, args));
-        if (serialized.layout.rectangles) {
-            serialized.features = serialized.features.filter(f => {
-                return Boolean(serialized.layout.rectangles[f.uniqueId]);
-            });
-        }
+        serialized.features = serialized.features.filter(f => {
+            return Boolean(serialized.layout.rectangles[f.uniqueId]);
+        });
         serialized.maxHeightReached = serialized.layout.maxHeightReached;
         return serialized;
     }

package/pluggableElementTypes/renderers/CircularChordRendererType.d.ts

@@ -8,7 +8,7 @@ export default class CircularChordRendererType extends FeatureRenderer {
         features: SimpleFeatureSerialized[];
         html: string;
     }, args: {
-        displayModel: any;
+        displayModel?: any;
         theme: ThemeOptions;
         exportSVG?: {
             rasterizeLayers?: boolean;

package/pluggableElementTypes/renderers/ComparativeServerSideRendererType.d.ts

@@ -1,16 +1,15 @@
 import { Feature } from '../../util/simpleFeature';
+import { Region } from '../../util/types';
 import ServerSideRenderer, { RenderArgs as ServerSideRenderArgs, RenderArgsSerialized as ServerSideRenderArgsSerialized, RenderArgsDeserialized as ServerSideRenderArgsDeserialized, ResultsSerialized as ServerSideResultsSerialized, ResultsDeserialized as ServerSideResultsDeserialized } from './ServerSideRendererType';
 import RpcManager from '../../rpc/RpcManager';
+import { AnyConfigurationModel } from '../../configuration';
 export interface RenderArgs extends ServerSideRenderArgs {
-    displayModel: {};
     blockKey: string;
 }
 export interface RenderArgsSerialized extends ServerSideRenderArgsSerialized {
-    displayModel: {};
     blockKey: string;
 }
 export interface RenderArgsDeserialized extends ServerSideRenderArgsDeserialized {
-    displayModel: {};
     blockKey: string;
 }
 export type ResultsSerialized = ServerSideResultsSerialized;
@@ -25,14 +24,8 @@ export interface ResultsSerializedSvgExport extends ResultsSerialized {
 }
 export default class ComparativeServerSideRenderer extends ServerSideRenderer {
     /**
-     * directly modifies the render arguments to prepare
-     * them to be serialized and sent to the worker.
-     *
-     * the base class replaces the `displayModel` param
-     * (which on the client is a MST model) with a stub
-     * that only contains the `selectedFeature`, since
-     * this is the only part of the track model that most
-     * renderers read.
+     * directly modifies the render arguments to prepare them to be serialized
+     * and sent to the worker.
      *
      * @param args - the arguments passed to render
      * @returns the same object
@@ -51,6 +44,10 @@ export default class ComparativeServerSideRenderer extends ServerSideRenderer {
      * @returns true if this feature passes all configured filters
      */
     featurePassesFilters(renderArgs: RenderArgsDeserialized, feature: Feature): boolean;
-    getFeatures(renderArgs: any): Promise<Feature[]>;
+    getFeatures(renderArgs: {
+        regions: Region[];
+        sessionId: string;
+        adapterConfig: AnyConfigurationModel;
+    }): Promise<Feature[]>;
 }
 export { type RenderResults } from './ServerSideRendererType';

package/pluggableElementTypes/renderers/ComparativeServerSideRendererType.js

@@ -3,7 +3,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-/* eslint-disable @typescript-eslint/no-explicit-any */
 const operators_1 = require("rxjs/operators");
 const ServerSideRendererType_1 = __importDefault(require("./ServerSideRendererType"));
 const dataAdapterCache_1 = require("../../data_adapters/dataAdapterCache");
@@ -14,14 +13,8 @@ function isSvgExport(e) {
 }
 class ComparativeServerSideRenderer extends ServerSideRendererType_1.default {
     /**
-     * directly modifies the render arguments to prepare
-     * them to be serialized and sent to the worker.
-     *
-     * the base class replaces the `displayModel` param
-     * (which on the client is a MST model) with a stub
-     * that only contains the `selectedFeature`, since
-     * this is the only part of the track model that most
-     * renderers read.
+     * directly modifies the render arguments to prepare them to be serialized
+     * and sent to the worker.
      *
      * @param args - the arguments passed to render
      * @returns the same object
@@ -32,14 +25,17 @@ class ComparativeServerSideRenderer extends ServerSideRendererType_1.default {
     serializeArgsInClient(args) {
         const deserializedArgs = {
             ...args,
-            displayModel: {},
+            displayModel: undefined,
         };
         return super.serializeArgsInClient(deserializedArgs);
     }
     // deserialize some of the results that came back from the worker
     deserializeResultsInClient(result, args) {
         const deserialized = super.deserializeResultsInClient(result, args);
-        return { ...deserialized, blockKey: args.blockKey };
+        return {
+            ...deserialized,
+            blockKey: args.blockKey,
+        };
     }
     /**
      * Render method called on the client. Serializes args, then
@@ -49,7 +45,7 @@ class ComparativeServerSideRenderer extends ServerSideRendererType_1.default {
         const results = (await rpcManager.call(args.sessionId, 'ComparativeRender', args));
         if (isSvgExport(results)) {
             results.html = await (0, util_1.getSerializedSvg)(results);
-            delete results.reactElement;
+            results.reactElement = undefined;
         }
         return results;
     }
@@ -65,13 +61,8 @@ class ComparativeServerSideRenderer extends ServerSideRendererType_1.default {
     }
     async getFeatures(renderArgs) {
         const pm = this.pluginManager;
-        const { sessionId, adapterConfig } = renderArgs;
+        const { regions, sessionId, adapterConfig } = renderArgs;
         const { dataAdapter } = await (0, dataAdapterCache_1.getAdapter)(pm, sessionId, adapterConfig);
-        const regions = renderArgs.regions;
-        if (!regions || regions.length === 0) {
-            console.warn('no regions supplied to comparative renderer');
-            return [];
-        }
         const requestRegions = regions.map(r => {
             // make sure the requested region's start and end are integers, if
             // there is a region specification.
@@ -87,7 +78,9 @@ class ComparativeServerSideRenderer extends ServerSideRendererType_1.default {
         // note that getFeaturesInMultipleRegions does not do glyph expansion
         const res = await (0, rxjs_1.firstValueFrom)(dataAdapter
             .getFeaturesInMultipleRegions(requestRegions, renderArgs)
-            .pipe((0, operators_1.filter)(f => this.featurePassesFilters(renderArgs, f)), (0, operators_1.toArray)()));
+            .pipe(
+        // @ts-expect-error
+        (0, operators_1.filter)(f => this.featurePassesFilters(renderArgs, f)), (0, operators_1.toArray)()));
         // dedupe needed xref https://github.com/GMOD/jbrowse-components/pull/3404/
         return (0, util_1.dedupe)(res, f => f.id());
     }

package/pluggableElementTypes/renderers/FeatureRendererType.d.ts

@@ -3,7 +3,7 @@ import { AugmentedRegion as Region } from '../../util/types';
 import ServerSideRendererType, { RenderArgs as ServerSideRenderArgs, RenderArgsSerialized as ServerSideRenderArgsSerialized, RenderArgsDeserialized as ServerSideRenderArgsDeserialized, RenderResults as ServerSideRenderResults, ResultsDeserialized as ServerSideResultsDeserialized, ResultsSerialized as ServerSideResultsSerialized } from './ServerSideRendererType';
 import { AnyConfigurationModel } from '../../configuration';
 export interface RenderArgs extends ServerSideRenderArgs {
-    displayModel: {
+    displayModel?: {
         id: string;
         selectedFeatureId?: string;
     };
@@ -11,7 +11,7 @@ export interface RenderArgs extends ServerSideRenderArgs {
     blockKey: string;
 }
 export interface RenderArgsSerialized extends ServerSideRenderArgsSerialized {
-    displayModel: {
+    displayModel?: {
         id: string;
         selectedFeatureId?: string;
     };
@@ -40,9 +40,9 @@ export interface ResultsDeserialized extends ServerSideResultsDeserialized {
 export default class FeatureRendererType extends ServerSideRendererType {
     /**
      * replaces the `displayModel` param (which on the client is a MST model)
-     * with a stub that only contains the `selectedFeature`, since this is the only
-     * part of the track model that most renderers read. also serializes the config
-     * and regions to JSON from MST objects.
+     * with a stub that only contains the `selectedFeature`, since this is the
+     * only part of the track model that most renderers read. also serializes the
+     * config and regions to JSON from MST objects.
      *
      * @param args - the arguments passed to render
      */

package/pluggableElementTypes/renderers/FeatureRendererType.js

@@ -15,20 +15,17 @@ const BaseAdapter_1 = require("../../data_adapters/BaseAdapter");
 class FeatureRendererType extends ServerSideRendererType_1.default {
     /**
      * replaces the `displayModel` param (which on the client is a MST model)
-     * with a stub that only contains the `selectedFeature`, since this is the only
-     * part of the track model that most renderers read. also serializes the config
-     * and regions to JSON from MST objects.
+     * with a stub that only contains the `selectedFeature`, since this is the
+     * only part of the track model that most renderers read. also serializes the
+     * config and regions to JSON from MST objects.
      *
      * @param args - the arguments passed to render
      */
     serializeArgsInClient(args) {
-        const { displayModel, regions } = args;
+        const { regions } = args;
         const serializedArgs = {
             ...args,
-            displayModel: displayModel && {
-                id: displayModel.id,
-                selectedFeatureId: displayModel.selectedFeatureId,
-            },
+            displayModel: undefined,
             regions: (0, clone_1.default)(regions),
         };
         return super.serializeArgsInClient(serializedArgs);
@@ -88,13 +85,9 @@ class FeatureRendererType extends ServerSideRendererType_1.default {
         if (!(0, BaseAdapter_1.isFeatureAdapter)(dataAdapter)) {
             throw new Error('Adapter does not support retrieving features');
         }
-        const features = new Map();
-        if (!regions || regions.length === 0) {
-            return features;
-        }
         // make sure the requested region's start and end are integers, if
         // there is a region specification.
-        const requestRegions = regions.map((r) => {
+        const requestRegions = regions.map(r => {
             const requestRegion = { ...r };
             if (requestRegion.start) {
                 requestRegion.start = Math.floor(requestRegion.start);

package/pluggableElementTypes/renderers/RendererType.js

@@ -4,7 +4,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 const react_1 = __importDefault(require("react"));
-const mst_reflection_1 = require("../../util/mst-reflection");
 const PluggableElementBase_1 = __importDefault(require("../PluggableElementBase"));
 class RendererType extends PluggableElementBase_1.default {
     constructor(stuff) {
@@ -13,15 +12,6 @@ class RendererType extends PluggableElementBase_1.default {
         this.ReactComponent = stuff.ReactComponent;
         this.configSchema = stuff.configSchema;
         this.pluginManager = stuff.pluginManager;
-        if (!this.ReactComponent) {
-            throw new Error(`no ReactComponent defined for renderer ${this.name}`);
-        }
-        if (!(0, mst_reflection_1.getDefaultValue)(this.configSchema).type) {
-            throw new Error(`${this.name} config schema ${this.configSchema.name} is not explicitlyTyped`);
-        }
-        if (!this.pluginManager) {
-            throw new Error(`no plugin manager defined for renderer ${this.name}`);
-        }
     }
     async render(props) {
         return {

package/pluggableElementTypes/renderers/RpcRenderedSvgGroup.d.ts

@@ -5,7 +5,7 @@ interface Props {
     html: string;
     features: Map<string, Feature>;
     theme: ThemeOptions;
-    displayModel: any;
+    displayModel?: any;
     RenderingComponent: AnyReactComponentType;
 }
 declare const RpcRenderedSvgGroup: (props: Props) => React.JSX.Element;

package/pluggableElementTypes/renderers/RpcRenderedSvgGroup.js

@@ -36,9 +36,7 @@ const NewHydrate = (0, mobx_react_1.observer)(function RpcRenderedSvgGroup(props
     const { html, theme, RenderingComponent, ...rest } = props;
     const ref = (0, react_1.useRef)(null);
     // this `any` is a react-dom/client::Root
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const rootRef = (0, react_1.useRef)();
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const root = (0, mobx_state_tree_1.getRoot)(props.displayModel);
     const hydrateRoot = root.hydrateFn;
     (0, react_1.useEffect)(() => {
@@ -53,15 +51,17 @@ const NewHydrate = (0, mobx_react_1.observer)(function RpcRenderedSvgGroup(props
                     react_1.default.createElement(RenderingComponent, { ...rest })));
         });
         return () => {
-            clearTimeout(renderTimeout);
+            if (renderTimeout !== undefined) {
+                clearTimeout(renderTimeout);
+            }
             const root = rootRef.current;
             rootRef.current = undefined;
             setTimeout(() => {
                 root === null || root === void 0 ? void 0 : root.unmount();
             });
         };
-    }, [html, RenderingComponent, hydrateRoot, theme, props, rest]);
-    // eslint-disable-next-line react/no-danger
+        // biome-ignore lint/correctness/useExhaustiveDependencies:
+    }, [RenderingComponent, hydrateRoot, theme, rest]);
     return react_1.default.createElement("g", { ref: ref, dangerouslySetInnerHTML: { __html: html } });
 });
 const OldHydrate = (0, mobx_react_1.observer)(function OldHydrate(props) {
@@ -72,16 +72,18 @@ const OldHydrate = (0, mobx_react_1.observer)(function OldHydrate(props) {
         function doHydrate() {
             if (domNode && html) {
                 if (domNode.innerHTML) {
+                    // eslint-disable-next-line @typescript-eslint/no-deprecated
                     (0, react_dom_1.unmountComponentAtNode)(domNode);
                 }
                 // setting outline:none fixes react "focusable" element issue. see
                 // https://github.com/GMOD/jbrowse-components/issues/2160
                 domNode.style.outline = 'none';
                 domNode.innerHTML = html;
-                // use requestIdleCallback to defer main-thread rendering
-                // and hydration for when we have some free time. helps
-                // keep the framerate up.
+                // use requestIdleCallback to defer main-thread rendering and
+                // hydration for when we have some free time. helps keep the
+                // framerate up.
                 (0, util_1.rIC)(() => {
+                    // eslint-disable-next-line @typescript-eslint/no-deprecated
                     (0, react_dom_1.hydrate)(react_1.default.createElement(RenderingComponent, { ...props }), domNode);
                 });
             }
@@ -89,6 +91,7 @@ const OldHydrate = (0, mobx_react_1.observer)(function OldHydrate(props) {
         doHydrate();
         return () => {
             if (domNode) {
+                // eslint-disable-next-line @typescript-eslint/no-deprecated
                 (0, react_dom_1.unmountComponentAtNode)(domNode);
             }
         };
@@ -96,7 +99,6 @@ const OldHydrate = (0, mobx_react_1.observer)(function OldHydrate(props) {
     return react_1.default.createElement("g", { ref: ref });
 });
 const RpcRenderedSvgGroup = (0, mobx_react_1.observer)(function (props) {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const root = (0, mobx_state_tree_1.getRoot)(props.displayModel);
     return root.hydrateFn ? react_1.default.createElement(NewHydrate, { ...props }) : react_1.default.createElement(OldHydrate, { ...props });
 });

package/pluggableElementTypes/renderers/ServerSideRenderedContent.js

@@ -34,14 +34,12 @@ const react_dom_1 = require("react-dom");
 const util_1 = require("../../util");
 const NewHydrate = (0, mobx_react_1.observer)(function ServerSideRenderedContent({ theme, html, RenderingComponent, ...rest }) {
     const ref = (0, react_1.useRef)(null);
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const rootRef = (0, react_1.useRef)();
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const { hydrateFn } = (0, mobx_state_tree_1.getRoot)(rest.displayModel);
     (0, react_1.useEffect)(() => {
-        // requestIdleCallback here helps to avoid hydration mismatch
-        // because it provides time for dangerouslySetInnerHTML to set the innerHTML
-        // contents of the node, otherwise ref.current.innerHTML can be empty
+        // requestIdleCallback here helps to avoid hydration mismatch because it
+        // provides time for dangerouslySetInnerHTML to set the innerHTML contents
+        // of the node, otherwise ref.current.innerHTML can be empty
         const renderTimeout = (0, util_1.rIC)(() => {
             var _a;
             if (!ref.current) {
@@ -57,17 +55,18 @@ const NewHydrate = (0, mobx_react_1.observer)(function ServerSideRenderedContent
                     react_1.default.createElement(RenderingComponent, { ...rest })));
         });
         return () => {
-            clearTimeout(renderTimeout);
+            if (renderTimeout !== undefined) {
+                clearTimeout(renderTimeout);
+            }
             const root = rootRef.current;
             rootRef.current = undefined;
             setTimeout(() => {
                 root === null || root === void 0 ? void 0 : root.unmount();
             });
         };
-    }, [html, theme, rest, hydrateFn, RenderingComponent]);
-    return (react_1.default.createElement("div", { "data-testid": "hydrationContainer", ref: ref, 
-        // eslint-disable-next-line react/no-danger
-        dangerouslySetInnerHTML: { __html: html } }));
+        /* biome-ignore lint/correctness/useExhaustiveDependencies: */
+    }, [theme, rest, hydrateFn, RenderingComponent]);
+    return (react_1.default.createElement("div", { "data-testid": "hydrationContainer", ref: ref, dangerouslySetInnerHTML: { __html: html } }));
 });
 const OldHydrate = (0, mobx_react_1.observer)(function ({ theme, html, RenderingComponent, ...rest }) {
     const ref = (0, react_1.useRef)(null);
@@ -76,11 +75,11 @@ const OldHydrate = (0, mobx_react_1.observer)(function ({ theme, html, Rendering
         const domNode = ref.current;
         function doHydrate() {
             if (domNode) {
-                if (domNode) {
-                    (0, react_dom_1.unmountComponentAtNode)(domNode);
-                }
+                // eslint-disable-next-line @typescript-eslint/no-deprecated
+                (0, react_dom_1.unmountComponentAtNode)(domNode);
                 domNode.innerHTML = html;
                 (0, util_1.rIC)(() => {
+                    // eslint-disable-next-line @typescript-eslint/no-deprecated
                     (0, react_dom_1.hydrate)(react_1.default.createElement(styles_1.ThemeProvider, { theme: jbrowseTheme },
                         react_1.default.createElement(RenderingComponent, { ...rest })), domNode);
                 });
@@ -89,14 +88,15 @@ const OldHydrate = (0, mobx_react_1.observer)(function ({ theme, html, Rendering
         doHydrate();
         return () => {
             if (domNode) {
+                // eslint-disable-next-line @typescript-eslint/no-deprecated
                 (0, react_dom_1.unmountComponentAtNode)(domNode);
             }
         };
+        /* biome-ignore lint/correctness/useExhaustiveDependencies: */
     }, [html, jbrowseTheme, rest, RenderingComponent]);
     return react_1.default.createElement("div", { ref: ref });
 });
 const ServerSideRenderedContent = (0, mobx_react_1.observer)(function (props) {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const root = (0, mobx_state_tree_1.getRoot)(props.displayModel);
     return root.hydrateFn ? react_1.default.createElement(NewHydrate, { ...props }) : react_1.default.createElement(OldHydrate, { ...props });
 });

package/pluggableElementTypes/renderers/ServerSideRendererType.d.ts

@@ -8,22 +8,22 @@ interface BaseRenderArgs extends RenderProps {
     sessionId: string;
     signal?: AbortSignal;
     theme: ThemeOptions;
-    exportSVG: {
+    exportSVG?: {
         rasterizeLayers?: boolean;
     };
 }
 export interface RenderArgs extends BaseRenderArgs {
     config: SnapshotOrInstance<AnyConfigurationModel>;
-    filters: SerializableFilterChain;
+    filters?: SerializableFilterChain;
 }
 export interface RenderArgsSerialized extends BaseRenderArgs {
     statusCallback?: (arg: string) => void;
     config: SnapshotIn<AnyConfigurationModel>;
-    filters: SerializedFilterChain;
+    filters?: SerializedFilterChain;
 }
 export interface RenderArgsDeserialized extends BaseRenderArgs {
     config: AnyConfigurationModel;
-    filters: SerializableFilterChain;
+    filters?: SerializableFilterChain;
 }
 export interface ResultsSerialized extends Omit<RenderResults, 'reactElement'> {
     html: string;

package/pluggableElementTypes/renderers/ServerSideRendererType.js

@@ -72,9 +72,11 @@ class ServerSideRenderer extends RendererType_1.default {
         deserialized.config = this.configSchema.create(args.config || {}, {
             pluginManager: this.pluginManager,
         });
-        deserialized.filters = new serializableFilterChain_1.default({
-            filters: args.filters,
-        });
+        deserialized.filters = args.filters
+            ? new serializableFilterChain_1.default({
+                filters: args.filters,
+            })
+            : undefined;
         return deserialized;
     }
     /**
@@ -87,7 +89,7 @@ class ServerSideRenderer extends RendererType_1.default {
      */
     serializeResultsInWorker(results, args) {
         const html = (0, server_1.renderToString)(react_1.default.createElement(styles_1.ThemeProvider, { theme: (0, ui_1.createJBrowseTheme)(args.theme) }, results.reactElement));
-        delete results.reactElement;
+        results.reactElement = undefined;
         return { ...results, html };
     }
     /**
@@ -101,7 +103,7 @@ class ServerSideRenderer extends RendererType_1.default {
         const results = (await rpcManager.call(args.sessionId, 'CoreRender', args));
         if (isSvgExport(results)) {
             results.html = await (0, util_1.getSerializedSvg)(results);
-            delete results.reactElement;
+            results.reactElement = undefined;
         }
         return results;
     }

package/pluggableElementTypes/renderers/util/serializableFilterChain.js

@@ -14,7 +14,6 @@ class SerializableFilterChain {
             throw new Error(`invalid inputFilter string "${inputFilter}"`);
         });
     }
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     passes(...args) {
         for (const entry of this.filterChain) {
             if (

package/rpc/BaseRpcDriver.d.ts

@@ -2,7 +2,7 @@ import PluginManager from '../PluginManager';
 import { AnyConfigurationModel } from '../configuration';
 export interface WorkerHandle {
     status?: string;
-    error?: Error;
+    error?: unknown;
     on?: (channel: string, callback: (message: unknown) => void) => void;
     off?: (channel: string, callback: (message: unknown) => void) => void;
     destroy(): void;

package/rpc/BaseRpcDriver.js

@@ -12,7 +12,7 @@ function isClonable(thing) {
 // the worker times out
 async function watchWorker(worker, pingTime, rpcDriverClassName) {
     // after first ping succeeds, apply wait for timeout
-    // eslint-disable-next-line no-constant-condition
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     while (true) {
         await worker.call('ping', [], {
             timeout: pingTime * 2,
@@ -38,19 +38,17 @@ class LazyWorker {
             this.workerP = this.driver
                 .makeWorker()
                 .then(worker => {
-                watchWorker(worker, this.driver.maxPingTime, this.driver.name).catch(error => {
-                    if (worker) {
-                        console.error('worker did not respond, killing and generating new one');
-                        console.error(error);
-                        worker.destroy();
-                        worker.status = 'killed';
-                        worker.error = error;
-                        this.workerP = undefined;
-                    }
+                watchWorker(worker, this.driver.maxPingTime, this.driver.name).catch((error) => {
+                    console.error('worker did not respond, killing and generating new one');
+                    console.error(error);
+                    worker.destroy();
+                    worker.status = 'killed';
+                    worker.error = error;
+                    this.workerP = undefined;
                 });
                 return worker;
             })
-                .catch(e => {
+                .catch((e) => {
                 this.workerP = undefined;
                 throw e;
             });
@@ -133,6 +131,9 @@ class BaseRpcDriver {
         const unextendedWorker = await this.getWorker(sessionId);
         const worker = pluginManager.evaluateExtensionPoint('Core-extendWorker', unextendedWorker);
         const rpcMethod = pluginManager.getRpcMethodType(functionName);
+        if (!rpcMethod) {
+            throw new Error(`unknown RPC method ${functionName}`);
+        }
         const serializedArgs = await rpcMethod.serializeArguments(args, this.name);
         const filteredAndSerializedArgs = this.filterArgs(serializedArgs, sessionId);
         // now actually call the worker

package/rpc/MainThreadRpcDriver.d.ts

@@ -2,7 +2,7 @@ import BaseRpcDriver, { RpcDriverConstructorArgs } from './BaseRpcDriver';
 import PluginManager from '../PluginManager';
 declare class DummyHandle {
     destroy(): void;
-    call(_functionName: string, _filteredArgs?: {}, _options?: {}): Promise<unknown>;
+    call(_functionName: string, _filteredArgs?: Record<string, unknown>, _options?: {}): Promise<unknown>;
 }
 /**
  * Stub RPC driver class that runs RPC functions in-band in the main thread.
@@ -13,6 +13,6 @@ export default class MainThreadRpcDriver extends BaseRpcDriver {
     name: string;
     makeWorker: () => Promise<DummyHandle>;
     constructor(args: RpcDriverConstructorArgs);
-    call(pm: PluginManager, sessionId: string, funcName: string, args: {}): Promise<unknown>;
+    call(pm: PluginManager, sessionId: string, funcName: string, args: Record<string, unknown>): Promise<unknown>;
 }
 export {};

package/rpc/MainThreadRpcDriver.js

@@ -26,6 +26,9 @@ class MainThreadRpcDriver extends BaseRpcDriver_1.default {
             throw new TypeError('sessionId is required');
         }
         const rpcMethod = pm.getRpcMethodType(funcName);
+        if (!rpcMethod) {
+            throw new Error(`unknown RPC method ${funcName}`);
+        }
         const serializedArgs = await rpcMethod.serializeArguments(args, this.name);
         const result = await rpcMethod.execute(serializedArgs, this.name);
         return rpcMethod.deserializeReturn(result, args, this.name);

package/rpc/RpcManager.d.ts

@@ -29,6 +29,6 @@ export default class RpcManager {
     getDriverForCall(_sessionId: string, _functionName: string, args: {
         rpcDriverName?: string;
     }): Promise<DriverClass>;
-    call(sessionId: string, functionName: string, args: {}, opts?: {}): Promise<unknown>;
+    call(sessionId: string, functionName: string, args: Record<string, unknown>, opts?: {}): Promise<unknown>;
 }
 export {};