@jaypie/express 1.2.12 → 1.2.14

package/dist/cjs/index.cjs

@@ -55,18 +55,21 @@ class LambdaRequest extends node_stream.Readable {
             remoteAddress: options.remoteAddress,
         };
         this.connection = this.socket;
-        // Schedule body push for next tick to ensure stream is ready
-        // This is needed for body parsers that consume the stream
-        if (this.bodyBuffer && this.bodyBuffer.length > 0) {
-            process.nextTick(() => {
-                if (!this.bodyPushed) {
+        // Schedule body push for next tick to ensure stream is ready.
+        // This is needed for body parsers that consume the stream.
+        // CRITICAL: Always schedule the push, even for empty bodies, to ensure
+        // the stream emits 'end'. Otherwise, middleware that waits for the request
+        // stream to end (like body parsers) will hang forever on GET requests.
+        process.nextTick(() => {
+            if (!this.bodyPushed) {
+                if (this.bodyBuffer && this.bodyBuffer.length > 0) {
                     this.push(this.bodyBuffer);
-                    this.push(null);
-                    this.bodyPushed = true;
-                    this.complete = true;
                 }
-            });
-        }
+                this.push(null); // Signal end of stream
+                this.bodyPushed = true;
+                this.complete = true;
+            }
+        });
     }
     //
     // Readable stream implementation
@@ -1389,71 +1392,61 @@ function getCurrentInvokeUuid(req) {
     return getJaypieAdapterUuid();
 }
 
-//
-//
-// Helpers
-//
 /**
- * Safely get a header value from response.
+ * Safely set a header value on response.
  * Handles both Express Response and Lambda adapter responses.
  * Defensive against dd-trace instrumentation issues.
  */
-function safeGetHeader(res, name) {
+function safeSetHeader(res, name, value) {
     try {
         // Try internal method first (completely bypasses dd-trace)
-        if (typeof res._internalGetHeader === "function") {
-            return res._internalGetHeader(name);
+        if (typeof res._internalSetHeader === "function") {
+            res._internalSetHeader(name, value);
+            return;
         }
         // Fall back to _headers Map access (Lambda adapter, avoids dd-trace)
         if (res._headers instanceof Map) {
-            const value = res._headers.get(name.toLowerCase());
-            return value ? String(value) : undefined;
+            res._headers.set(name.toLowerCase(), value);
+            return;
         }
-        // Fall back to getHeader (more standard than get)
-        if (typeof res.getHeader === "function") {
-            const value = res.getHeader(name);
-            return value ? String(value) : undefined;
+        // Fall back to setHeader (more standard than set)
+        if (typeof res.setHeader === "function") {
+            res.setHeader(name, value);
+            return;
         }
-        // Last resort: try get
-        if (typeof res.get === "function") {
-            const value = res.get(name);
-            return value ? String(value) : undefined;
+        // Last resort: try set
+        if (typeof res.set === "function") {
+            res.set(name, value);
         }
     }
     catch {
-        // Silently fail - caller will handle missing value
+        // Silently fail - header just won't be set
     }
-    return undefined;
 }
 /**
- * Safely set a header value on response.
+ * Safely remove a header from response.
  * Handles both Express Response and Lambda adapter responses.
  * Defensive against dd-trace instrumentation issues.
  */
-function safeSetHeader(res, name, value) {
+function safeRemoveHeader(res, name) {
     try {
         // Try internal method first (completely bypasses dd-trace)
-        if (typeof res._internalSetHeader === "function") {
-            res._internalSetHeader(name, value);
+        if (typeof res._internalRemoveHeader === "function") {
+            res._internalRemoveHeader(name);
             return;
         }
         // Fall back to _headers Map access (Lambda adapter, avoids dd-trace)
         if (res._headers instanceof Map) {
-            res._headers.set(name.toLowerCase(), value);
+            res._headers.delete(name.toLowerCase());
             return;
         }
-        // Fall back to setHeader (more standard than set)
-        if (typeof res.setHeader === "function") {
-            res.setHeader(name, value);
-            return;
-        }
-        // Last resort: try set
-        if (typeof res.set === "function") {
-            res.set(name, value);
+        // Fall back to removeHeader (standard Node.js http.ServerResponse)
+        if (typeof res.removeHeader === "function") {
+            res.removeHeader(name);
         }
     }
     catch {
-        // Silently fail - header just won't be set
+        // Silently fail - header just won't be removed
     }
 }
 //
@@ -1478,11 +1471,8 @@ const decorateResponse = (res, { handler = "", version = process.env.PROJECT_VER
         //
         // Decorate Headers
         //
-        // X-Powered-By, override "Express" but nothing else
-        const currentPoweredBy = safeGetHeader(extRes, kit.HTTP.HEADER.POWERED_BY);
-        if (!currentPoweredBy || currentPoweredBy === "Express") {
-            safeSetHeader(extRes, kit.HTTP.HEADER.POWERED_BY, kit.JAYPIE.LIB.EXPRESS);
-        }
+        // Remove X-Powered-By
+        safeRemoveHeader(extRes, kit.HTTP.HEADER.POWERED_BY);
         // X-Project-Environment
         if (process.env.PROJECT_ENV) {
             safeSetHeader(extRes, kit.HTTP.HEADER.PROJECT.ENVIRONMENT, process.env.PROJECT_ENV);