@jaypie/express 1.2.11-dev.4 → 1.2.11-dev.5

package/dist/cjs/adapter/LambdaResponseStreaming.d.ts

@@ -14,6 +14,7 @@ export declare class LambdaResponseStreaming extends Writable {
     };
     _headers: Map<string, string | string[]>;
     _headersSent: boolean;
+    private _convertedFrom204;
     private _pendingWrites;
     private _responseStream;
     private _wrappedStream;

package/dist/cjs/index.cjs

@@ -654,6 +654,7 @@ class LambdaResponseStreaming extends node_stream.Writable {
         // that need to bypass dd-trace interception
         this._headers = new Map();
         this._headersSent = false;
+        this._convertedFrom204 = false;
         this._pendingWrites = [];
         this._wrappedStream = null;
         this._responseStream = responseStream;
@@ -855,23 +856,21 @@ class LambdaResponseStreaming extends node_stream.Writable {
         for (const [key, value] of this._headers) {
             headers[key] = Array.isArray(value) ? value.join(", ") : String(value);
         }
+        // Lambda streaming requires body content for metadata to be transmitted.
+        // Convert 204 No Content to 200 OK with empty JSON body as workaround.
+        // See: https://github.com/finlaysonstudio/jaypie/issues/178
+        let statusCode = this.statusCode;
+        if (statusCode === 204) {
+            statusCode = 200;
+            this._convertedFrom204 = true;
+            // Set content-type for the JSON body we'll send
+            headers["content-type"] = "application/json";
+        }
         const metadata = {
             headers,
-            statusCode: this.statusCode,
+            statusCode,
         };
-        // For 204 No Content, write metadata directly without wrapped stream.
-        // Lambda streaming ignores metadata when no body content is written,
-        // so we write the prelude manually and skip creating a wrapped stream.
-        if (this.statusCode === 204) {
-            const prelude = JSON.stringify(metadata);
-            this._responseStream.write(prelude);
-            // Metadata separator (8 null bytes) signals end of prelude
-            this._responseStream.write("\0\0\0\0\0\0\0\0");
-            this._headersSent = true;
-            // Don't create wrapped stream - 204 has no body
-            return;
-        }
-        // Normal streaming: create wrapped stream
+        // Create wrapped stream with metadata
         this._wrappedStream = awslambda.HttpResponseStream.from(this._responseStream, metadata);
         this._headersSent = true;
         // Flush pending writes
@@ -964,13 +963,14 @@ class LambdaResponseStreaming extends node_stream.Writable {
         if (!this._headersSent) {
             this.flushHeaders();
         }
+        // For converted 204 responses, write empty JSON body
+        // Lambda streaming requires body content for metadata to be transmitted
+        if (this._convertedFrom204 && this._wrappedStream) {
+            this._wrappedStream.write("{}");
+        }
         if (this._wrappedStream) {
             this._wrappedStream.end();
         }
-        else {
-            // 204 case: headers were written directly, just end the response stream
-            this._responseStream.end();
-        }
         // Use setImmediate to ensure stream operations complete before callback
         setImmediate(callback);
     }