@jaybeeuu/agent-cortex 1.42.0 → 2.0.0

package/test/copilot-installer.test.mjs

@@ -1,308 +0,0 @@
-// Integration tests for `agent-cortex install copilot`: the install-time
-// generator for the Copilot CLI flat agent files (agents/*.agent.md). All tests
-// install into mkdtemp dirs so the real repo agents/ is never touched.
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { execFile } from "node:child_process";
-import { mkdtemp, mkdir, writeFile, rm, readFile, readdir, stat } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { fileURLToPath } from "node:url";
-import { join, dirname } from "node:path";
-import { installCopilot } from "../bin/installers/copilot.mjs";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const ROOT = join(__dirname, "..");
-const CLI_PATH = join(ROOT, "bin", "agent-cortex.mjs");
-
-/** True when a path exists (stat succeeds). */
-async function pathExists(p) {
-  try {
-    await stat(p);
-    return true;
-  } catch {
-    return false;
-  }
-}
-
-function runCli(args) {
-  return new Promise((resolve) => {
-    execFile(process.execPath, [CLI_PATH, ...args], (error, stdout, stderr) => {
-      resolve({ exitCode: error ? error.code ?? 1 : 0, stdout, stderr });
-    });
-  });
-}
-
-// ─── Fixtures ────────────────────────────────────────────────────────────────
-
-function tokenMap() {
-  return {
-    name: "fixture token map",
-    version: 1,
-    harnesses: ["copilot"],
-    tools: {
-      bash: { copilot: "bash" },
-      view: { copilot: "view" },
-      task: { copilot: "task" },
-      ask_user: { copilot: "ask_user" },
-    },
-    paths: {
-      plugin_root: { copilot: "~/.copilot/installed-plugins/_direct/agent-cortex" },
-      agents_dir: { copilot: { base: "plugin_root", relative: "agents" } },
-    },
-  };
-}
-
-async function makeFixture() {
-  const root = await mkdtemp(join(tmpdir(), "copilot-installer-"));
-  return {
-    root,
-    output: join(root, "generated"),
-    cleanup: async () => rm(root, { recursive: true, force: true }),
-  };
-}
-
-async function writeFixture(fx, relPath, content) {
-  const p = join(fx.root, relPath);
-  await mkdir(dirname(p), { recursive: true });
-  await writeFile(p, content);
-}
-
-/** Seed a minimal but realistic package tree (agents + token-map). */
-async function seedCopilotPackage(fx, opts = {}) {
-  const { agents = {} } = opts;
-  await writeFixture(fx, "token-map.json", JSON.stringify(tokenMap()));
-  for (const [name, def] of Object.entries(agents)) {
-    await writeFixture(fx, `agents/${name}/agent.md`, def.body ?? `# ${name}\nBody of ${name}.`);
-    await writeFixture(
-      fx,
-      `agents/${name}/copilot/frontmatter.json`,
-      JSON.stringify(
-        def.frontmatter ?? {
-          name: `agent-cortex:${name}`,
-          description: `Description of ${name}`,
-          tools: ["bash", "view"],
-          argumentHint: `Hint for ${name}`,
-        },
-      ),
-    );
-    for (const [section, content] of Object.entries(def.sections ?? {})) {
-      await writeFixture(fx, `agents/${name}/copilot/${section}.md`, content);
-    }
-  }
-}
-
-/** Deterministic snapshot of a directory: relative paths + byte content. */
-async function snapshot(dir) {
-  const entries = [];
-  const walk = async (p) => {
-    for (const e of (await readdir(p, { withFileTypes: true })).sort((a, b) => a.name.localeCompare(b.name))) {
-      const full = join(p, e.name);
-      if (e.isDirectory()) {
-        entries.push([e.name, "dir"]);
-        await walk(full);
-      } else entries.push([e.name, "file", await readFile(full, "utf-8")]);
-    }
-  };
-  await walk(dir);
-  return entries;
-}
-
-// ─── Agent composition ───────────────────────────────────────────────────────
-
-describe("installCopilot — agent composition", () => {
-  it("writes one flat <name>.agent.md per composable agent dir with copilot frontmatter and no leftover tokens", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, {
-        agents: {
-          alpha: {
-            body: "# alpha\nUse {{TOOL:view}} to read.\n{{SECTION:polling}}\nRead {{PATH:agents_dir}}.",
-            sections: { polling: "Spawn with {{TOOL:task}}." },
-            frontmatter: {
-              name: "agent-cortex:alpha",
-              description: "Reads things.",
-              tools: ["bash", "view"],
-              argumentHint: "Read something",
-            },
-          },
-        },
-      });
-
-      const result = await installCopilot({ root: fx.root, output: fx.output });
-
-      const file = join(fx.output, "alpha.agent.md");
-      assert.ok(await pathExists(file), "flat agent file written");
-      const content = await readFile(file, "utf-8");
-      assert.ok(content.startsWith("---\n"), "yaml frontmatter");
-      assert.ok(content.includes("# GENERATED from agents/alpha/ by scripts/build-copilot-agents.mjs — DO NOT EDIT."));
-      // Committed flat-file field order: description, name, tools (YAML array), argument-hint.
-      const order = ["description:", "name: \"agent-cortex:alpha\"", "tools: [", "argument-hint:"].map((s) => content.indexOf(s));
-      assert.ok(order.every((i) => i !== -1), "all frontmatter fields present");
-      assert.deepEqual([...order].sort((a, b) => a - b), order, "frontmatter fields in committed order");
-      assert.match(content, /tools: \["bash", "view"\]/, "copilot tools kept as a YAML array (no translation)");
-      assert.ok(content.includes("Use view to read."), "{{TOOL:view}} substituted");
-      assert.ok(content.includes("Spawn with task."), "{{SECTION:polling}} composed from copilot/polling.md");
-      assert.ok(!/{{/.test(content), "no literal tokens remain");
-      assert.equal(result.agents.length, 1);
-      assert.deepEqual(result.agents, ["alpha"]);
-      assert.equal(result.output, fx.output);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("skips non-composable entries in agents/ and never clobbers composable sources", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, { agents: { alpha: { body: "# alpha" } } });
-      await writeFixture(fx, "agents/README.md", "# agents dir docs\n");
-
-      const result = await installCopilot({ root: fx.root, output: fx.output });
-
-      assert.deepEqual((await readdir(fx.output)).sort(), ["alpha.agent.md"], "no README, no subdirectories written");
-      assert.deepEqual(result.agents, ["alpha"]);
-      // The composable source dir next to the generated file stays untouched.
-      assert.ok(await pathExists(join(fx.root, "agents", "alpha", "agent.md")), "composable source preserved");
-      assert.ok(await pathExists(join(fx.root, "agents", "alpha", "copilot", "frontmatter.json")), "harness dir preserved");
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("throws when a composable dir lacks copilot/frontmatter.json", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, { agents: { alpha: { body: "# alpha" } } });
-      await rm(join(fx.root, "agents", "alpha", "copilot"), { recursive: true, force: true });
-      await assert.rejects(
-        installCopilot({ root: fx.root, output: fx.output }),
-        /without copilot\/frontmatter\.json/,
-      );
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("defaults to the plugin-scanned agents/ dir of the package root (plugin.json \"agents\": \"agents/\")", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, { agents: { alpha: { body: "# alpha" } } });
-
-      const result = await installCopilot({ root: fx.root });
-
-      assert.equal(result.output, join(fx.root, "agents"), "default output is the dir plugin.json scans");
-      assert.ok(await pathExists(join(fx.root, "agents", "alpha.agent.md")), "flat file lands next to the composable dir");
-      assert.ok(await pathExists(join(fx.root, "agents", "alpha", "agent.md")), "composable source untouched");
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("throws on an unknown tool token", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, { agents: { alpha: { body: "# alpha\nUse {{TOOL:nope}} now." } } });
-      await assert.rejects(installCopilot({ root: fx.root, output: fx.output }), /unknown tool token {{TOOL:nope}}/);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-});
-
-// ─── Output / dry-run ────────────────────────────────────────────────────────
-
-describe("installCopilot — output & dry-run", () => {
-  it("dry-run reports the plan without writing anything", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, { agents: { alpha: { body: "# alpha" } } });
-
-      const result = await installCopilot({ root: fx.root, output: fx.output, dryRun: true });
-
-      assert.equal(result.dryRun, true);
-      assert.equal(await pathExists(fx.output), false, "no output dir created in dry-run");
-      assert.deepEqual(result.agents, ["alpha"], "planned files still reported");
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("is deterministic across repeated installs into the same output", async () => {
-    const fx = await makeFixture();
-    try {
-      await seedCopilotPackage(fx, {
-        agents: {
-          alpha: { body: "# alpha\n{{SECTION:polling}}", sections: { polling: "Poll with {{TOOL:task}}." } },
-          beta: { body: "# beta" },
-        },
-      });
-
-      await installCopilot({ root: fx.root, output: fx.output });
-      const first = await snapshot(fx.output);
-      await installCopilot({ root: fx.root, output: fx.output });
-      assert.deepEqual(await snapshot(fx.output), first);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-});
-
-// ─── Integration against the real repo ───────────────────────────────────────
-
-describe("installCopilot — real repo integration", () => {
-  it("regenerates byte-identical copies of the committed agents/*.agent.md files", async () => {
-    const fx = await makeFixture();
-    try {
-      const result = await installCopilot({ root: ROOT, output: fx.output });
-
-      assert.deepEqual(result.agents.sort(), ["plan", "ralph", "ralph-plan", "strategy"]);
-      for (const name of result.agents) {
-        const generated = await readFile(join(fx.output, `${name}.agent.md`), "utf-8");
-        const committed = await readFile(join(ROOT, "agents", `${name}.agent.md`), "utf-8");
-        assert.equal(generated, committed, `${name}.agent.md must match the committed flat file (CI drift check)`);
-      }
-    } finally {
-      await fx.cleanup();
-    }
-  });
-});
-
-// ─── CLI wiring ──────────────────────────────────────────────────────────────
-
-describe("CLI integration", () => {
-  it("exits 0 for install copilot --output <tmp> and writes the flat files", async () => {
-    const fx = await makeFixture();
-    try {
-      const { exitCode, stdout } = await runCli(["install", "copilot", "--output", fx.output]);
-      assert.equal(exitCode, 0);
-      assert.ok(stdout.includes("copilot"), "prints the harness name");
-      assert.ok(stdout.includes("Generated"), "prints the generation summary");
-      assert.ok(await pathExists(join(fx.output, "ralph.agent.md")), "agent files written");
-      assert.ok(await pathExists(join(fx.output, "plan.agent.md")));
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("exits 0 for install copilot --dry-run and writes nothing", async () => {
-    const fx = await makeFixture();
-    try {
-      const { exitCode, stdout } = await runCli(["install", "copilot", "--output", fx.output, "--dry-run"]);
-      assert.equal(exitCode, 0);
-      assert.ok(/dry-run/i.test(stdout));
-      assert.equal(await pathExists(fx.output), false, "no files written in dry-run");
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("exits 0 for install copilot (default output) without touching committed files", async () => {
-    const before = await readFile(join(ROOT, "agents", "ralph.agent.md"), "utf-8");
-    const { exitCode } = await runCli(["install", "copilot"]);
-    assert.equal(exitCode, 0);
-    // Default output regenerates the shared agents/ dir in place — output must
-    // stay byte-identical to what is committed.
-    assert.equal(await readFile(join(ROOT, "agents", "ralph.agent.md"), "utf-8"), before);
-  });
-});

package/test/pi-packages.test.mjs

@@ -1,295 +0,0 @@
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtemp, mkdir, writeFile, rm, chmod } from "node:fs/promises";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import {
-  loadRequiredPackages,
-  npmSourceName,
-  planPackageInstalls,
-  provisionPiPackages,
-  runPiInstall,
-} from "../lib/pi-packages.mjs";
-
-// ─── Fixtures ────────────────────────────────────────────────────────────────
-
-async function makePiRoot({ declared = [], installed = [], settingsRaw } = {}) {
-  const root = await mkdtemp(join(tmpdir(), "pi-packages-"));
-  if (settingsRaw !== undefined) {
-    await writeFile(join(root, "settings.json"), settingsRaw);
-  } else if (declared.length > 0) {
-    await writeFile(join(root, "settings.json"), JSON.stringify({ packages: declared }));
-  }
-  for (const name of installed) {
-    await mkdir(join(root, "npm", "node_modules", name), { recursive: true });
-  }
-  return { root, cleanup: async () => rm(root, { recursive: true, force: true }) };
-}
-
-/** A runner that records every source it is asked to install. */
-function recordingRunner({ results = {} } = {}) {
-  const calls = [];
-  const runner = async (source) => {
-    calls.push(source);
-    return results[source] ?? { ok: true, error: null };
-  };
-  return { runner, calls };
-}
-
-/** Run `fn` with PATH set to `pathValue`, restoring the previous PATH afterwards. */
-async function withPath(pathValue, fn) {
-  const original = process.env.PATH;
-  process.env.PATH = pathValue;
-  try {
-    return await fn();
-  } finally {
-    process.env.PATH = original;
-  }
-}
-
-/** Write an executable `pi` stub with the given shell body; returns its dir and cleanup. */
-async function makePiStub(body) {
-  const dir = await mkdtemp(join(tmpdir(), "pi-stub-"));
-  const file = join(dir, "pi");
-  await writeFile(file, `#!/bin/sh\n${body}\n`);
-  await chmod(file, 0o755);
-  return { dir, cleanup: async () => rm(dir, { recursive: true, force: true }) };
-}
-
-/** A directory with nothing on PATH, so any external command lookup fails. */
-async function makeEmptyPathDir() {
-  const dir = await mkdtemp(join(tmpdir(), "pi-stub-empty-"));
-  return { dir, cleanup: async () => rm(dir, { recursive: true, force: true }) };
-}
-
-// ─── Manifest ────────────────────────────────────────────────────────────────
-
-describe("loadRequiredPackages", () => {
-  it("reads the declared pi packages from the package manifest", async () => {
-    const root = await mkdtemp(join(tmpdir(), "pi-packages-manifest-"));
-    try {
-      await writeFile(
-        join(root, "package.json"),
-        JSON.stringify({ name: "x", pi: { extensions: ["./extensions"], packages: ["npm:pi-questions"] } }),
-      );
-      assert.deepEqual(await loadRequiredPackages(root), ["npm:pi-questions"]);
-    } finally {
-      await rm(root, { recursive: true, force: true });
-    }
-  });
-
-  it("returns no packages when the manifest does not declare any", async () => {
-    const root = await mkdtemp(join(tmpdir(), "pi-packages-manifest-"));
-    try {
-      await writeFile(join(root, "package.json"), JSON.stringify({ name: "x", pi: { skills: ["./skills"] } }));
-      assert.deepEqual(await loadRequiredPackages(root), []);
-    } finally {
-      await rm(root, { recursive: true, force: true });
-    }
-  });
-});
-
-// ─── Source parsing ──────────────────────────────────────────────────────────
-
-describe("npmSourceName", () => {
-  it("extracts the package name from npm sources, including scoped and pinned specs", () => {
-    assert.equal(npmSourceName("npm:pi-questions"), "pi-questions");
-    assert.equal(npmSourceName("npm:pi-web-access@0.10.7"), "pi-web-access");
-    assert.equal(npmSourceName("npm:@scope/pkg@1.2.3"), "@scope/pkg");
-  });
-
-  it("returns null for non-npm sources it cannot verify locally", () => {
-    assert.equal(npmSourceName("git:github.com/user/repo"), null);
-    assert.equal(npmSourceName("./local/path"), null);
-  });
-});
-
-// ─── Install plan ────────────────────────────────────────────────────────────
-
-describe("planPackageInstalls", () => {
-  it("plans nothing when every required package is declared and installed", () => {
-    assert.deepEqual(
-      planPackageInstalls(["npm:pi-questions"], {
-        declaredSources: ["npm:pi-questions"],
-        installedNames: ["pi-questions"],
-      }),
-      [],
-    );
-  });
-
-  it("plans a package that is declared but not installed", () => {
-    assert.deepEqual(
-      planPackageInstalls(["npm:pi-web-access@0.10.7"], {
-        declaredSources: ["npm:pi-web-access@0.10.7"],
-        installedNames: [],
-      }),
-      ["npm:pi-web-access@0.10.7"],
-    );
-  });
-
-  it("plans a package that is installed but not declared, so pi will load it", () => {
-    assert.deepEqual(
-      planPackageInstalls(["npm:pi-questions"], {
-        declaredSources: [],
-        installedNames: ["pi-questions"],
-      }),
-      ["npm:pi-questions"],
-    );
-  });
-});
-
-// ─── Provisioning ────────────────────────────────────────────────────────────
-
-describe("runPiInstall", () => {
-  it("degrades to a result when the pi CLI is not on PATH", async () => {
-    const empty = await makeEmptyPathDir();
-    try {
-      const result = await withPath(empty.dir, () => runPiInstall("npm:pi-questions"));
-      assert.deepEqual(result, { ok: false, error: "pi CLI not found on PATH" });
-    } finally {
-      await empty.cleanup();
-    }
-  });
-
-  it("maps a successful pi install to ok", async () => {
-    const stub = await makePiStub("exit 0");
-    try {
-      const result = await withPath(stub.dir, () => runPiInstall("npm:pi-questions"));
-      assert.deepEqual(result, { ok: true, error: null });
-    } finally {
-      await stub.cleanup();
-    }
-  });
-
-  it("maps a failing pi install to its stderr", async () => {
-    const stub = await makePiStub('echo "offline: no registry" >&2\nexit 1');
-    try {
-      const result = await withPath(stub.dir, () => runPiInstall("npm:pi-questions"));
-      assert.deepEqual(result, { ok: false, error: "offline: no registry" });
-    } finally {
-      await stub.cleanup();
-    }
-  });
-});
-
-describe("provisionPiPackages", () => {
-  it("installs missing packages and skips the ones already present", async () => {
-    const fx = await makePiRoot({ declared: ["npm:pi-questions"], installed: ["pi-questions"] });
-    try {
-      const { runner, calls } = await recordingRunner();
-
-      const result = await provisionPiPackages({
-        required: ["npm:pi-questions", "npm:pi-web-access@0.10.7"],
-        piRoot: fx.root,
-        runInstall: runner,
-      });
-
-      assert.deepEqual(calls, ["npm:pi-web-access@0.10.7"], "only the missing package is installed");
-      assert.deepEqual(result.installed, ["npm:pi-web-access@0.10.7"]);
-      assert.deepEqual(result.failed, []);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("is idempotent — a second run with everything present installs nothing", async () => {
-    const fx = await makePiRoot({
-      declared: ["npm:pi-questions", "npm:pi-web-access@0.10.7"],
-      installed: ["pi-questions", "pi-web-access"],
-    });
-    try {
-      const { runner, calls } = await recordingRunner();
-      const result = await provisionPiPackages({
-        required: ["npm:pi-questions", "npm:pi-web-access@0.10.7"],
-        piRoot: fx.root,
-        runInstall: runner,
-      });
-      assert.deepEqual(calls, []);
-      assert.deepEqual(result.installed, []);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("reports a failed install and continues with the rest", async () => {
-    const fx = await makePiRoot();
-    try {
-      const warnings = [];
-      const { runner, calls } = await recordingRunner({
-        results: { "npm:pi-questions": { ok: false, error: "offline" } },
-      });
-
-      const result = await provisionPiPackages({
-        required: ["npm:pi-questions", "npm:pi-web-access@0.10.7"],
-        piRoot: fx.root,
-        runInstall: runner,
-        warn: (msg) => warnings.push(msg),
-      });
-
-      assert.deepEqual(calls, ["npm:pi-questions", "npm:pi-web-access@0.10.7"], "failure does not abort the rest");
-      assert.deepEqual(result.installed, ["npm:pi-web-access@0.10.7"]);
-      assert.deepEqual(result.failed, [{ source: "npm:pi-questions", error: "offline" }]);
-      assert.ok(warnings.some((w) => w.includes("npm:pi-questions")), "failure is surfaced as a warning");
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("uses the pi CLI runner by default and warns when it is missing", async () => {
-    const fx = await makePiRoot();
-    const empty = await makeEmptyPathDir();
-    try {
-      const warnings = [];
-      const result = await withPath(empty.dir, () =>
-        provisionPiPackages({
-          required: ["npm:pi-questions"],
-          piRoot: fx.root,
-          warn: (msg) => warnings.push(msg),
-        }),
-      );
-
-      assert.deepEqual(result.failed, [{ source: "npm:pi-questions", error: "pi CLI not found on PATH" }]);
-      assert.ok(
-        warnings.some((w) => w.includes("pi CLI not found on PATH")),
-        "missing CLI is surfaced as a warning, not a thrown error",
-      );
-    } finally {
-      await empty.cleanup();
-      await fx.cleanup();
-    }
-  });
-
-  it("dry-run reports the plan without installing anything", async () => {
-    const fx = await makePiRoot();
-    try {
-      const { runner, calls } = await recordingRunner();
-      const result = await provisionPiPackages({
-        required: ["npm:pi-questions"],
-        piRoot: fx.root,
-        runInstall: runner,
-        dryRun: true,
-      });
-      assert.deepEqual(calls, []);
-      assert.deepEqual(result.planned, ["npm:pi-questions"]);
-      assert.deepEqual(result.installed, []);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-
-  it("treats an unreadable settings file as no declarations rather than failing the install", async () => {
-    const fx = await makePiRoot({ settingsRaw: "{ not json" });
-    try {
-      const { runner, calls } = await recordingRunner();
-      const result = await provisionPiPackages({
-        required: ["npm:pi-questions"],
-        piRoot: fx.root,
-        runInstall: runner,
-      });
-      assert.deepEqual(calls, ["npm:pi-questions"], "still attempts the install");
-      assert.deepEqual(result.installed, ["npm:pi-questions"]);
-    } finally {
-      await fx.cleanup();
-    }
-  });
-});