@jamesaphoenix/tx-core 0.4.2 → 0.4.4

package/dist/services/deduplication-service.js

@@ -1,6 +1,7 @@
 import { Context, Effect, Layer } from "effect";
 import { DeduplicationRepository } from "../repo/deduplication-repo.js";
 import { hashContent } from "../mappers/deduplication.js";
+import { BatchProcessingError } from "../errors.js";
 /**
  * Default batch size for hash checking operations.
  * Balances between query efficiency and memory usage.
@@ -18,24 +19,19 @@ export const DeduplicationServiceLive = Layer.effect(DeduplicationService, Effec
     return {
         processLine: (content, filePath, lineNumber) => Effect.gen(function* () {
             const hash = hashContent(content);
-            const exists = yield* repo.hashExists(hash);
-            if (exists) {
-                return {
-                    hash,
-                    isNew: false,
-                    lineNumber,
-                    content
-                };
-            }
-            // Record the new hash
-            yield* repo.insertHash({
+            // Use atomic insert-or-ignore to handle race conditions safely.
+            // If two concurrent calls try to process the same content:
+            // - First one succeeds with inserted=true
+            // - Second one gets inserted=false (hash already exists)
+            // No race window between check and insert.
+            const { inserted } = yield* repo.tryInsertHash({
                 contentHash: hash,
                 sourceFile: filePath,
                 sourceLine: lineNumber
             });
             return {
                 hash,
-                isNew: true,
+                isNew: inserted,
                 lineNumber,
                 content
             };
@@ -66,25 +62,66 @@ export const DeduplicationServiceLive = Layer.effect(DeduplicationService, Effec
                 ...l,
                 hash: hashContent(l.content)
             }));
-            // Check existing hashes in batches
+            // Check existing hashes in batches with error handling
             let existingHashes = new Set();
+            const totalBatches = Math.ceil(lineHashes.length / batchSize);
             for (let i = 0; i < lineHashes.length; i += batchSize) {
+                const batchIndex = Math.floor(i / batchSize);
                 const batch = lineHashes.slice(i, i + batchSize);
                 const batchHashes = batch.map(l => l.hash);
-                const batchExisting = yield* repo.hashesExist(batchHashes);
-                existingHashes = new Set([...existingHashes, ...batchExisting]);
+                const batchResult = yield* repo.hashesExist(batchHashes).pipe(Effect.mapError((cause) => {
+                    // Calculate partial results up to this point
+                    const checkedLines = lineHashes.slice(0, i);
+                    const newLinesPartial = checkedLines.filter(l => !existingHashes.has(l.hash));
+                    const skippedLinesPartial = checkedLines.filter(l => existingHashes.has(l.hash));
+                    const lastCheckedLine = checkedLines[checkedLines.length - 1];
+                    return new BatchProcessingError({
+                        operation: "hashesExist",
+                        batchIndex,
+                        totalBatches,
+                        partialResult: {
+                            filePath,
+                            totalLines: lines.length,
+                            newLines: newLinesPartial.length,
+                            skippedLines: skippedLinesPartial.length,
+                            startLine,
+                            endLine: lastCheckedLine?.lineNumber ?? startLine - 1,
+                            duration: Date.now() - startTime
+                        },
+                        cause
+                    });
+                }));
+                existingHashes = new Set([...existingHashes, ...batchResult]);
             }
             // Separate new and existing lines
             const newLines = lineHashes.filter(l => !existingHashes.has(l.hash));
             const skippedLines = lineHashes.filter(l => existingHashes.has(l.hash));
-            // Insert new hashes in batches
+            // Insert new hashes with error handling
             if (newLines.length > 0) {
                 const hashInputs = newLines.map(l => ({
                     contentHash: l.hash,
                     sourceFile: filePath,
                     sourceLine: l.lineNumber
                 }));
-                yield* repo.insertHashes(hashInputs);
+                yield* repo.insertHashes(hashInputs).pipe(Effect.mapError((cause) => {
+                    // All hash checks completed, but insert failed
+                    // Return partial result with check phase complete but no inserts
+                    return new BatchProcessingError({
+                        operation: "insertHashes",
+                        batchIndex: 0,
+                        totalBatches: 1,
+                        partialResult: {
+                            filePath,
+                            totalLines: lines.length,
+                            newLines: 0, // None were inserted
+                            skippedLines: skippedLines.length,
+                            startLine,
+                            endLine: lineHashes[lineHashes.length - 1]?.lineNumber ?? startLine - 1,
+                            duration: Date.now() - startTime
+                        },
+                        cause
+                    });
+                }));
             }
             // Calculate end line
             const lastLine = linesToProcess[linesToProcess.length - 1];
@@ -103,21 +140,38 @@ export const DeduplicationServiceLive = Layer.effect(DeduplicationService, Effec
             const hash = hashContent(content);
             return yield* repo.hashExists(hash);
         }),
-        filterProcessed: (contents) => Effect.gen(function* () {
+        filterProcessed: (contents, options = {}) => Effect.gen(function* () {
             if (contents.length === 0)
                 return new Set();
-            // Compute hashes and check
+            const batchSize = options.batchSize ?? DEFAULT_BATCH_SIZE;
+            // Compute hashes and build content-to-hash mapping
             const contentHashMap = new Map();
             for (const content of contents) {
                 contentHashMap.set(hashContent(content), content);
             }
-            const existingHashes = yield* repo.hashesExist([...contentHashMap.keys()]);
-            // Return the original content strings that have been processed
+            const allHashes = [...contentHashMap.keys()];
+            const totalBatches = Math.ceil(allHashes.length / batchSize);
             const processedContents = new Set();
-            for (const hash of existingHashes) {
-                const content = contentHashMap.get(hash);
-                if (content)
-                    processedContents.add(content);
+            // Check hashes in batches with error handling
+            for (let i = 0; i < allHashes.length; i += batchSize) {
+                const batchIndex = Math.floor(i / batchSize);
+                const batchHashes = allHashes.slice(i, i + batchSize);
+                const existingHashes = yield* repo.hashesExist(batchHashes).pipe(Effect.mapError((cause) => {
+                    // Return partial results collected so far
+                    return new BatchProcessingError({
+                        operation: "filterProcessed",
+                        batchIndex,
+                        totalBatches,
+                        partialResult: new Set(processedContents),
+                        cause
+                    });
+                }));
+                // Add found content strings to the result set
+                for (const hash of existingHashes) {
+                    const content = contentHashMap.get(hash);
+                    if (content)
+                        processedContents.add(content);
+                }
             }
             return processedContents;
         }),

package/dist/services/deduplication-service.js.map

@@ -1 +1 @@
-{"version":3,"file":"deduplication-service.js","sourceRoot":"","sources":["../../src/services/deduplication-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,EAAE,uBAAuB,EAAE,MAAM,+BAA+B,CAAA;AACvE,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAA;AASzD;;;GAGG;AACH,MAAM,kBAAkB,GAAG,GAAG,CAAA;AAE9B;;;;GAIG;AACH,MAAM,OAAO,oBAAqB,SAAQ,OAAO,CAAC,GAAG,CAAC,sBAAsB,CAAC,EAwE1E;CAAG;AAEN,MAAM,CAAC,MAAM,wBAAwB,GAAG,KAAK,CAAC,MAAM,CAClD,oBAAoB,EACpB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;IAClB,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,uBAAuB,CAAA;IAE3C,OAAO;QACL,WAAW,EAAE,CAAC,OAAO,EAAE,QAAQ,EAAE,UAAU,EAAE,EAAE,CAC7C,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,IAAI,GAAG,WAAW,CAAC,OAAO,CAAC,CAAA;YACjC,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;YAE3C,IAAI,MAAM,EAAE,CAAC;gBACX,OAAO;oBACL,IAAI;oBACJ,KAAK,EAAE,KAAK;oBACZ,UAAU;oBACV,OAAO;iBACR,CAAA;YACH,CAAC;YAED,sBAAsB;YACtB,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC;gBACrB,WAAW,EAAE,IAAI;gBACjB,UAAU,EAAE,QAAQ;gBACpB,UAAU,EAAE,UAAU;aACvB,CAAC,CAAA;YAEF,OAAO;gBACL,IAAI;gBACJ,KAAK,EAAE,IAAI;gBACX,UAAU;gBACV,OAAO;aACR,CAAA;QACH,CAAC,CAAC;QAEJ,YAAY,EAAE,CAAC,KAAK,EAAE,QAAQ,EAAE,OAAO,GAAG,EAAE,EAAE,EAAE,CAC9C,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAA;YAC5B,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,IAAI,kBAAkB,CAAA;YACzD,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,IAAI,CAAC,CAAA;YACxC,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,CAAA;YAEjC,oCAAoC;YACpC,IAAI,cAAc,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,IAAI,SAAS,CAAC,CAAA;YACjE,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;gBAC3B,cAAc,GAAG,cAAc,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAA;YACpD,CAAC;YAED,IAAI,cAAc,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBAChC,OAAO;oBACL,QAAQ;oBACR,UAAU,EAAE,KAAK,CAAC,MAAM;oBACxB,QAAQ,EAAE,CAAC;oBACX,YAAY,EAAE,CAAC;oBACf,SAAS;oBACT,OAAO,EAAE,SAAS,GAAG,CAAC;oBACtB,QAAQ,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;iBACjC,CAAA;YACH,CAAC;YAED,+BAA+B;YAC/B,MAAM,UAAU,GAAG,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;gBAC1C,GAAG,CAAC;gBACJ,IAAI,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC;aAC7B,CAAC,CAAC,CAAA;YAEH,mCAAmC;YACnC,IAAI,cAAc,GAAG,IAAI,GAAG,EAAU,CAAA;YACtC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,UAAU,CAAC,MAAM,EAAE,CAAC,IAAI,SAAS,EAAE,CAAC;gBACtD,MAAM,KAAK,GAAG,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,CAAA;gBAChD,MAAM,WAAW,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;gBAC1C,MAAM,aAAa,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,CAAA;gBAC1D,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,GAAG,cAAc,EAAE,GAAG,aAAa,CAAC,CAAC,CAAA;YACjE,CAAC;YAED,kCAAkC;YAClC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;YACpE,MAAM,YAAY,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;YAEvE,+BAA+B;YAC/B,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBACxB,MAAM,UAAU,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;oBACpC,WAAW,EAAE,CAAC,CAAC,IAAI;oBACnB,UAAU,EAAE,QAAQ;oBACpB,UAAU,EAAE,CAAC,CAAC,UAAU;iBACzB,CAAC,CAAC,CAAA;gBACH,KAAK,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,UAAU,CAAC,CAAA;YACtC,CAAC;YAED,qBAAqB;YACrB,MAAM,QAAQ,GAAG,cAAc,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC,CAAA;YAC1D,MAAM,OAAO,GAAG,QAAQ,EAAE,UAAU,IAAI,SAAS,GAAG,CAAC,CAAA;YAErD,OAAO;gBACL,QAAQ;gBACR,UAAU,EAAE,KAAK,CAAC,MAAM;gBACxB,QAAQ,EAAE,QAAQ,CAAC,MAAM;gBACzB,YAAY,EAAE,YAAY,CAAC,MAAM;gBACjC,SAAS;gBACT,OAAO;gBACP,QAAQ,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;aACjC,CAAA;QACH,CAAC,CAAC;QAEJ,WAAW,EAAE,CAAC,OAAO,EAAE,EAAE,CACvB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,IAAI,GAAG,WAAW,CAAC,OAAO,CAAC,CAAA;YACjC,OAAO,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;QACrC,CAAC,CAAC;QAEJ,eAAe,EAAE,CAAC,QAAQ,EAAE,EAAE,CAC5B,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO,IAAI,GAAG,EAAU,CAAA;YAEnD,2BAA2B;YAC3B,MAAM,cAAc,GAAG,IAAI,GAAG,EAAkB,CAAA;YAChD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC/B,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,CAAA;YACnD,CAAC;YAED,MAAM,cAAc,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,GAAG,cAAc,CAAC,IAAI,EAAE,CAAC,CAAC,CAAA;YAE1E,+DAA+D;YAC/D,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAU,CAAA;YAC3C,KAAK,MAAM,IAAI,IAAI,cAAc,EAAE,CAAC;gBAClC,MAAM,OAAO,GAAG,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;gBACxC,IAAI,OAAO;oBAAE,iBAAiB,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;YAC7C,CAAC;YAED,OAAO,iBAAiB,CAAA;QAC1B,CAAC,CAAC;QAEJ,WAAW,EAAE,CAAC,QAAQ,EAAE,EAAE,CAAC,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC;QAEzD,cAAc,EAAE,CAAC,QAAQ,EAAE,iBAAiB,EAAE,cAAc,EAAE,QAAQ,EAAE,YAAY,EAAE,EAAE,CACtF,IAAI,CAAC,kBAAkB,CAAC;YACtB,QAAQ;YACR,iBAAiB;YACjB,cAAc;YACd,QAAQ;YACR,YAAY;SACb,CAAC;QAEJ,SAAS,EAAE,CAAC,QAAQ,EAAE,EAAE,CACtB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,aAAa,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,mBAAmB,CAAC,QAAQ,CAAC,CAAA;YAC/D,KAAK,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,QAAQ,CAAC,CAAA;YACxC,OAAO,EAAE,aAAa,EAAE,CAAA;QAC1B,CAAC,CAAC;QAEJ,QAAQ,EAAE,GAAG,EAAE,CACb,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,WAAW,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,EAAE,CAAA;YAC7C,MAAM,YAAY,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,EAAE,CAAA;YAC7C,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,CAAA;QACtC,CAAC,CAAC;QAEJ,WAAW,EAAE,WAAW;KACzB,CAAA;AACH,CAAC,CAAC,CACH,CAAA"}
+{"version":3,"file":"deduplication-service.js","sourceRoot":"","sources":["../../src/services/deduplication-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,EAAE,uBAAuB,EAAE,MAAM,+BAA+B,CAAA;AACvE,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAA;AACzD,OAAO,EAAE,oBAAoB,EAAiB,MAAM,cAAc,CAAA;AAQlE;;;GAGG;AACH,MAAM,kBAAkB,GAAG,GAAG,CAAA;AAE9B;;;;GAIG;AACH,MAAM,OAAO,oBAAqB,SAAQ,OAAO,CAAC,GAAG,CAAC,sBAAsB,CAAC,EA6E1E;CAAG;AAEN,MAAM,CAAC,MAAM,wBAAwB,GAAG,KAAK,CAAC,MAAM,CAClD,oBAAoB,EACpB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;IAClB,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,uBAAuB,CAAA;IAE3C,OAAO;QACL,WAAW,EAAE,CAAC,OAAO,EAAE,QAAQ,EAAE,UAAU,EAAE,EAAE,CAC7C,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,IAAI,GAAG,WAAW,CAAC,OAAO,CAAC,CAAA;YAEjC,gEAAgE;YAChE,2DAA2D;YAC3D,0CAA0C;YAC1C,yDAAyD;YACzD,2CAA2C;YAC3C,MAAM,EAAE,QAAQ,EAAE,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC;gBAC7C,WAAW,EAAE,IAAI;gBACjB,UAAU,EAAE,QAAQ;gBACpB,UAAU,EAAE,UAAU;aACvB,CAAC,CAAA;YAEF,OAAO;gBACL,IAAI;gBACJ,KAAK,EAAE,QAAQ;gBACf,UAAU;gBACV,OAAO;aACR,CAAA;QACH,CAAC,CAAC;QAEJ,YAAY,EAAE,CAAC,KAAK,EAAE,QAAQ,EAAE,OAAO,GAAG,EAAE,EAAE,EAAE,CAC9C,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAA;YAC5B,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,IAAI,kBAAkB,CAAA;YACzD,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,IAAI,CAAC,CAAA;YACxC,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,CAAA;YAEjC,oCAAoC;YACpC,IAAI,cAAc,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,IAAI,SAAS,CAAC,CAAA;YACjE,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;gBAC3B,cAAc,GAAG,cAAc,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAA;YACpD,CAAC;YAED,IAAI,cAAc,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBAChC,OAAO;oBACL,QAAQ;oBACR,UAAU,EAAE,KAAK,CAAC,MAAM;oBACxB,QAAQ,EAAE,CAAC;oBACX,YAAY,EAAE,CAAC;oBACf,SAAS;oBACT,OAAO,EAAE,SAAS,GAAG,CAAC;oBACtB,QAAQ,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;iBACjC,CAAA;YACH,CAAC;YAED,+BAA+B;YAC/B,MAAM,UAAU,GAAG,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;gBAC1C,GAAG,CAAC;gBACJ,IAAI,EAAE,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC;aAC7B,CAAC,CAAC,CAAA;YAEH,uDAAuD;YACvD,IAAI,cAAc,GAAG,IAAI,GAAG,EAAU,CAAA;YACtC,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,MAAM,GAAG,SAAS,CAAC,CAAA;YAE7D,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,UAAU,CAAC,MAAM,EAAE,CAAC,IAAI,SAAS,EAAE,CAAC;gBACtD,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,SAAS,CAAC,CAAA;gBAC5C,MAAM,KAAK,GAAG,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,CAAA;gBAChD,MAAM,WAAW,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;gBAE1C,MAAM,WAAW,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC,IAAI,CAC3D,MAAM,CAAC,QAAQ,CAAC,CAAC,KAAK,EAAE,EAAE;oBACxB,6CAA6C;oBAC7C,MAAM,YAAY,GAAG,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAA;oBAC3C,MAAM,eAAe,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;oBAC7E,MAAM,mBAAmB,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;oBAChF,MAAM,eAAe,GAAG,YAAY,CAAC,YAAY,CAAC,MAAM,GAAG,CAAC,CAAC,CAAA;oBAE7D,OAAO,IAAI,oBAAoB,CAAC;wBAC9B,SAAS,EAAE,aAAa;wBACxB,UAAU;wBACV,YAAY;wBACZ,aAAa,EAAE;4BACb,QAAQ;4BACR,UAAU,EAAE,KAAK,CAAC,MAAM;4BACxB,QAAQ,EAAE,eAAe,CAAC,MAAM;4BAChC,YAAY,EAAE,mBAAmB,CAAC,MAAM;4BACxC,SAAS;4BACT,OAAO,EAAE,eAAe,EAAE,UAAU,IAAI,SAAS,GAAG,CAAC;4BACrD,QAAQ,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;yBACjC;wBACD,KAAK;qBACN,CAAC,CAAA;gBACJ,CAAC,CAAC,CACH,CAAA;gBAED,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,GAAG,cAAc,EAAE,GAAG,WAAW,CAAC,CAAC,CAAA;YAC/D,CAAC;YAED,kCAAkC;YAClC,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;YACpE,MAAM,YAAY,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAA;YAEvE,wCAAwC;YACxC,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBACxB,MAAM,UAAU,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;oBACpC,WAAW,EAAE,CAAC,CAAC,IAAI;oBACnB,UAAU,EAAE,QAAQ;oBACpB,UAAU,EAAE,CAAC,CAAC,UAAU;iBACzB,CAAC,CAAC,CAAA;gBAEH,KAAK,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,UAAU,CAAC,CAAC,IAAI,CACvC,MAAM,CAAC,QAAQ,CAAC,CAAC,KAAK,EAAE,EAAE;oBACxB,+CAA+C;oBAC/C,iEAAiE;oBACjE,OAAO,IAAI,oBAAoB,CAAC;wBAC9B,SAAS,EAAE,cAAc;wBACzB,UAAU,EAAE,CAAC;wBACb,YAAY,EAAE,CAAC;wBACf,aAAa,EAAE;4BACb,QAAQ;4BACR,UAAU,EAAE,KAAK,CAAC,MAAM;4BACxB,QAAQ,EAAE,CAAC,EAAE,qBAAqB;4BAClC,YAAY,EAAE,YAAY,CAAC,MAAM;4BACjC,SAAS;4BACT,OAAO,EAAE,UAAU,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,CAAC,EAAE,UAAU,IAAI,SAAS,GAAG,CAAC;4BACvE,QAAQ,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;yBACjC;wBACD,KAAK;qBACN,CAAC,CAAA;gBACJ,CAAC,CAAC,CACH,CAAA;YACH,CAAC;YAED,qBAAqB;YACrB,MAAM,QAAQ,GAAG,cAAc,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC,CAAA;YAC1D,MAAM,OAAO,GAAG,QAAQ,EAAE,UAAU,IAAI,SAAS,GAAG,CAAC,CAAA;YAErD,OAAO;gBACL,QAAQ;gBACR,UAAU,EAAE,KAAK,CAAC,MAAM;gBACxB,QAAQ,EAAE,QAAQ,CAAC,MAAM;gBACzB,YAAY,EAAE,YAAY,CAAC,MAAM;gBACjC,SAAS;gBACT,OAAO;gBACP,QAAQ,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;aACjC,CAAA;QACH,CAAC,CAAC;QAEJ,WAAW,EAAE,CAAC,OAAO,EAAE,EAAE,CACvB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,IAAI,GAAG,WAAW,CAAC,OAAO,CAAC,CAAA;YACjC,OAAO,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;QACrC,CAAC,CAAC;QAEJ,eAAe,EAAE,CAAC,QAAQ,EAAE,OAAO,GAAG,EAAE,EAAE,EAAE,CAC1C,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO,IAAI,GAAG,EAAU,CAAA;YAEnD,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,IAAI,kBAAkB,CAAA;YAEzD,mDAAmD;YACnD,MAAM,cAAc,GAAG,IAAI,GAAG,EAAkB,CAAA;YAChD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;gBAC/B,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,OAAO,CAAC,EAAE,OAAO,CAAC,CAAA;YACnD,CAAC;YAED,MAAM,SAAS,GAAG,CAAC,GAAG,cAAc,CAAC,IAAI,EAAE,CAAC,CAAA;YAC5C,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,GAAG,SAAS,CAAC,CAAA;YAC5D,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAU,CAAA;YAE3C,8CAA8C;YAC9C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,IAAI,SAAS,EAAE,CAAC;gBACrD,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,SAAS,CAAC,CAAA;gBAC5C,MAAM,WAAW,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,CAAA;gBAErD,MAAM,cAAc,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC,IAAI,CAC9D,MAAM,CAAC,QAAQ,CAAC,CAAC,KAAK,EAAE,EAAE;oBACxB,0CAA0C;oBAC1C,OAAO,IAAI,oBAAoB,CAAC;wBAC9B,SAAS,EAAE,iBAAiB;wBAC5B,UAAU;wBACV,YAAY;wBACZ,aAAa,EAAE,IAAI,GAAG,CAAC,iBAAiB,CAAC;wBACzC,KAAK;qBACN,CAAC,CAAA;gBACJ,CAAC,CAAC,CACH,CAAA;gBAED,8CAA8C;gBAC9C,KAAK,MAAM,IAAI,IAAI,cAAc,EAAE,CAAC;oBAClC,MAAM,OAAO,GAAG,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;oBACxC,IAAI,OAAO;wBAAE,iBAAiB,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;gBAC7C,CAAC;YACH,CAAC;YAED,OAAO,iBAAiB,CAAA;QAC1B,CAAC,CAAC;QAEJ,WAAW,EAAE,CAAC,QAAQ,EAAE,EAAE,CAAC,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC;QAEzD,cAAc,EAAE,CAAC,QAAQ,EAAE,iBAAiB,EAAE,cAAc,EAAE,QAAQ,EAAE,YAAY,EAAE,EAAE,CACtF,IAAI,CAAC,kBAAkB,CAAC;YACtB,QAAQ;YACR,iBAAiB;YACjB,cAAc;YACd,QAAQ;YACR,YAAY;SACb,CAAC;QAEJ,SAAS,EAAE,CAAC,QAAQ,EAAE,EAAE,CACtB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,aAAa,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,mBAAmB,CAAC,QAAQ,CAAC,CAAA;YAC/D,KAAK,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,QAAQ,CAAC,CAAA;YACxC,OAAO,EAAE,aAAa,EAAE,CAAA;QAC1B,CAAC,CAAC;QAEJ,QAAQ,EAAE,GAAG,EAAE,CACb,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,MAAM,WAAW,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,EAAE,CAAA;YAC7C,MAAM,YAAY,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,EAAE,CAAA;YAC7C,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,CAAA;QACtC,CAAC,CAAC;QAEJ,WAAW,EAAE,WAAW;KACzB,CAAA;AACH,CAAC,CAAC,CACH,CAAA"}

package/dist/services/dep-service.d.ts

@@ -1,11 +1,11 @@
 import { Context, Effect, Layer } from "effect";
 import { DependencyRepository } from "../repo/dep-repo.js";
 import { TaskRepository } from "../repo/task-repo.js";
-import { ValidationError, CircularDependencyError, TaskNotFoundError, DatabaseError } from "../errors.js";
+import { ValidationError, CircularDependencyError, TaskNotFoundError, DatabaseError, DependencyNotFoundError } from "../errors.js";
 import type { TaskId } from "@jamesaphoenix/tx-types";
 declare const DependencyService_base: Context.TagClass<DependencyService, "DependencyService", {
     readonly addBlocker: (taskId: TaskId, blockerId: TaskId) => Effect.Effect<void, ValidationError | CircularDependencyError | TaskNotFoundError | DatabaseError>;
-    readonly removeBlocker: (taskId: TaskId, blockerId: TaskId) => Effect.Effect<void, DatabaseError>;
+    readonly removeBlocker: (taskId: TaskId, blockerId: TaskId) => Effect.Effect<void, DatabaseError | DependencyNotFoundError>;
 }>;
 export declare class DependencyService extends DependencyService_base {
 }

package/dist/services/dep-service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dep-service.d.ts","sourceRoot":"","sources":["../../src/services/dep-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAA;AAC1D,OAAO,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAA;AACrD,OAAO,EAAE,eAAe,EAAE,uBAAuB,EAAE,iBAAiB,EAAE,aAAa,EAAE,MAAM,cAAc,CAAA;AACzG,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,yBAAyB,CAAA;;yBAK5B,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,eAAe,GAAG,uBAAuB,GAAG,iBAAiB,GAAG,aAAa,CAAC;4BACtI,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,aAAa,CAAC;;AAJrG,qBAAa,iBAAkB,SAAQ,sBAMpC;CAAG;AAEN,eAAO,MAAM,qBAAqB,8EAqCjC,CAAA"}
+{"version":3,"file":"dep-service.d.ts","sourceRoot":"","sources":["../../src/services/dep-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAA;AAC1D,OAAO,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAA;AACrD,OAAO,EAAE,eAAe,EAAE,uBAAuB,EAAE,iBAAiB,EAAE,aAAa,EAAE,uBAAuB,EAAE,MAAM,cAAc,CAAA;AAClI,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,yBAAyB,CAAA;;yBAK5B,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,eAAe,GAAG,uBAAuB,GAAG,iBAAiB,GAAG,aAAa,CAAC;4BACtI,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,aAAa,GAAG,uBAAuB,CAAC;;AAJ/H,qBAAa,iBAAkB,SAAQ,sBAMpC;CAAG;AAEN,eAAO,MAAM,qBAAqB,8EAwCjC,CAAA"}

package/dist/services/dep-service.js

@@ -20,13 +20,17 @@ export const DependencyServiceLive = Layer.effect(DependencyService, Effect.gen(
             if (!blocker) {
                 return yield* Effect.fail(new TaskNotFoundError({ id: blockerId }));
             }
-            // Cycle detection: check if there's already a path from taskId to blockerId
-            // (i.e., blockerId is transitively blocked by taskId)
-            const wouldCycle = yield* depRepo.hasPath(blockerId, taskId);
-            if (wouldCycle) {
+            // Atomically check for cycles and insert dependency in a single transaction.
+            // This prevents race conditions where two concurrent addBlocker calls could
+            // both pass cycle detection before either inserts (DOCTRINE RULE 4).
+            const result = yield* depRepo.insertWithCycleCheck(blockerId, taskId);
+            if (result._tag === "wouldCycle") {
                 return yield* Effect.fail(new CircularDependencyError({ taskId, blockerId }));
             }
-            yield* depRepo.insert(blockerId, taskId);
+            // Idempotent: dependency already exists, nothing to do
+            if (result._tag === "alreadyExists") {
+                return;
+            }
         }),
         removeBlocker: (taskId, blockerId) => depRepo.remove(blockerId, taskId)
     };

package/dist/services/dep-service.js.map

@@ -1 +1 @@
-{"version":3,"file":"dep-service.js","sourceRoot":"","sources":["../../src/services/dep-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAA;AAC1D,OAAO,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAA;AACrD,OAAO,EAAE,eAAe,EAAE,uBAAuB,EAAE,iBAAiB,EAAiB,MAAM,cAAc,CAAA;AAGzG,MAAM,OAAO,iBAAkB,SAAQ,OAAO,CAAC,GAAG,CAAC,mBAAmB,CAAC,EAMpE;CAAG;AAEN,MAAM,CAAC,MAAM,qBAAqB,GAAG,KAAK,CAAC,MAAM,CAC/C,iBAAiB,EACjB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;IAClB,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,oBAAoB,CAAA;IAC3C,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,cAAc,CAAA;IAEtC,OAAO;QACL,UAAU,EAAE,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,CAChC,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;gBACzB,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,eAAe,CAAC,EAAE,MAAM,EAAE,4BAA4B,EAAE,CAAC,CAAC,CAAA;YAC1F,CAAC;YAED,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAA;YAC7C,IAAI,CAAC,IAAI,EAAE,CAAC;gBACV,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,iBAAiB,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,CAAC,CAAC,CAAA;YAClE,CAAC;YAED,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAA;YACnD,IAAI,CAAC,OAAO,EAAE,CAAC;gBACb,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,iBAAiB,CAAC,EAAE,EAAE,EAAE,SAAS,EAAE,CAAC,CAAC,CAAA;YACrE,CAAC;YAED,4EAA4E;YAC5E,sDAAsD;YACtD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,MAAM,CAAC,CAAA;YAC5D,IAAI,UAAU,EAAE,CAAC;gBACf,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,uBAAuB,CAAC,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC,CAAA;YAC/E,CAAC;YAED,KAAK,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,MAAM,CAAC,CAAA;QAC1C,CAAC,CAAC;QAEJ,aAAa,EAAE,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,CACnC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,MAAM,CAAC;KACpC,CAAA;AACH,CAAC,CAAC,CACH,CAAA"}
+{"version":3,"file":"dep-service.js","sourceRoot":"","sources":["../../src/services/dep-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAA;AAC1D,OAAO,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAA;AACrD,OAAO,EAAE,eAAe,EAAE,uBAAuB,EAAE,iBAAiB,EAA0C,MAAM,cAAc,CAAA;AAGlI,MAAM,OAAO,iBAAkB,SAAQ,OAAO,CAAC,GAAG,CAAC,mBAAmB,CAAC,EAMpE;CAAG;AAEN,MAAM,CAAC,MAAM,qBAAqB,GAAG,KAAK,CAAC,MAAM,CAC/C,iBAAiB,EACjB,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;IAClB,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,oBAAoB,CAAA;IAC3C,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,cAAc,CAAA;IAEtC,OAAO;QACL,UAAU,EAAE,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,CAChC,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;YAClB,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;gBACzB,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,eAAe,CAAC,EAAE,MAAM,EAAE,4BAA4B,EAAE,CAAC,CAAC,CAAA;YAC1F,CAAC;YAED,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAA;YAC7C,IAAI,CAAC,IAAI,EAAE,CAAC;gBACV,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,iBAAiB,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,CAAC,CAAC,CAAA;YAClE,CAAC;YAED,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAA;YACnD,IAAI,CAAC,OAAO,EAAE,CAAC;gBACb,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,iBAAiB,CAAC,EAAE,EAAE,EAAE,SAAS,EAAE,CAAC,CAAC,CAAA;YACrE,CAAC;YAED,6EAA6E;YAC7E,4EAA4E;YAC5E,qEAAqE;YACrE,MAAM,MAAM,GAAG,KAAK,CAAC,CAAC,OAAO,CAAC,oBAAoB,CAAC,SAAS,EAAE,MAAM,CAAC,CAAA;YACrE,IAAI,MAAM,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;gBACjC,OAAO,KAAK,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,uBAAuB,CAAC,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC,CAAA;YAC/E,CAAC;YACD,uDAAuD;YACvD,IAAI,MAAM,CAAC,IAAI,KAAK,eAAe,EAAE,CAAC;gBACpC,OAAM;YACR,CAAC;QACH,CAAC,CAAC;QAEJ,aAAa,EAAE,CAAC,MAAM,EAAE,SAAS,EAAE,EAAE,CACnC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,MAAM,CAAC;KACpC,CAAA;AACH,CAAC,CAAC,CACH,CAAA"}

package/dist/services/diversifier-service.d.ts

@@ -1,5 +1,6 @@
 import { Context, Effect, Layer } from "effect";
 import type { LearningWithScore } from "@jamesaphoenix/tx-types";
+import { EmbeddingDimensionMismatchError } from "../errors.js";
 declare const DiversifierService_base: Context.TagClass<DiversifierService, "DiversifierService", {
     /**
      * Apply MMR diversification to scored candidates.
@@ -9,7 +10,7 @@ declare const DiversifierService_base: Context.TagClass<DiversifierService, "Div
      * @param lambda - Balance between relevance (1.0) and diversity (0.0), default 0.7
      * @returns Diversified list of learnings, maintaining score order within diversity constraints
      */
-    readonly mmrDiversify: (candidates: readonly LearningWithScore[], limit: number, lambda?: number) => Effect.Effect<readonly LearningWithScore[]>;
+    readonly mmrDiversify: (candidates: readonly LearningWithScore[], limit: number, lambda?: number) => Effect.Effect<readonly LearningWithScore[], EmbeddingDimensionMismatchError>;
 }>;
 /**
  * DiversifierService provides Maximal Marginal Relevance (MMR) diversification

package/dist/services/diversifier-service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"diversifier-service.d.ts","sourceRoot":"","sources":["../../src/services/diversifier-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAA;;IAgB5D;;;;;;;OAOG;2BACoB,CACrB,UAAU,EAAE,SAAS,iBAAiB,EAAE,EACxC,KAAK,EAAE,MAAM,EACb,MAAM,CAAC,EAAE,MAAM,KACZ,MAAM,CAAC,MAAM,CAAC,SAAS,iBAAiB,EAAE,CAAC;;AAzBpD;;;;;;;;;GASG;AACH,qBAAa,kBAAmB,SAAQ,uBAiBrC;CAAG;AAmGN;;;GAGG;AACH,eAAO,MAAM,sBAAsB,+CAMlC,CAAA;AAED;;;;;;;;GAQG;AACH,eAAO,MAAM,sBAAsB,+CAyElC,CAAA;AA4CD;;GAEG;AACH,eAAO,MAAM,sBAAsB,+CAAyB,CAAA"}
+{"version":3,"file":"diversifier-service.d.ts","sourceRoot":"","sources":["../../src/services/diversifier-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAC/C,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAA;AAEhE,OAAO,EAAE,+BAA+B,EAAE,MAAM,cAAc,CAAA;;IAe1D;;;;;;;OAOG;2BACoB,CACrB,UAAU,EAAE,SAAS,iBAAiB,EAAE,EACxC,KAAK,EAAE,MAAM,EACb,MAAM,CAAC,EAAE,MAAM,KACZ,MAAM,CAAC,MAAM,CAAC,SAAS,iBAAiB,EAAE,EAAE,+BAA+B,CAAC;;AAzBrF;;;;;;;;;GASG;AACH,qBAAa,kBAAmB,SAAQ,uBAiBrC;CAAG;AAkGN;;;GAGG;AACH,eAAO,MAAM,sBAAsB,+CAMlC,CAAA;AAgCD;;;;;;;;GAQG;AACH,eAAO,MAAM,sBAAsB,+CAsDlC,CAAA;AA4CD;;GAEG;AACH,eAAO,MAAM,sBAAsB,+CAAyB,CAAA"}

package/dist/services/diversifier-service.js

@@ -31,25 +31,17 @@ const CATEGORY_MAX_PER_TOP_N = 2;
 const maxSimilarityToSelected = (candidate, selected) => {
     // No embedding means we can't compute similarity
     if (!candidate.embedding) {
-        return 0;
+        return Effect.succeed(0);
     }
     // No selected items yet
     if (selected.length === 0) {
-        return 0;
+        return Effect.succeed(0);
     }
-    let maxSim = -Infinity;
-    for (const item of selected) {
-        // Skip items without embeddings
-        if (!item.embedding) {
-            continue;
-        }
-        const sim = cosineSimilarity(candidate.embedding, item.embedding);
-        if (sim > maxSim) {
-            maxSim = sim;
-        }
+    const itemsWithEmbeddings = selected.filter((item) => item.embedding !== null);
+    if (itemsWithEmbeddings.length === 0) {
+        return Effect.succeed(0);
     }
-    // If no valid comparisons were made, return 0
-    return maxSim === -Infinity ? 0 : maxSim;
+    return Effect.forEach(itemsWithEmbeddings, item => cosineSimilarity(candidate.embedding, item.embedding)).pipe(Effect.map(similarities => Math.max(...similarities)));
 };
 /**
  * Calculate MMR score for a candidate.
@@ -61,8 +53,7 @@ const maxSimilarityToSelected = (candidate, selected) => {
  */
 const mmrScore = (candidate, selected, lambda) => {
     const relevance = candidate.relevanceScore;
-    const maxSim = maxSimilarityToSelected(candidate, selected);
-    return lambda * relevance - (1 - lambda) * maxSim;
+    return maxSimilarityToSelected(candidate, selected).pipe(Effect.map(maxSim => lambda * relevance - (1 - lambda) * maxSim));
 };
 /**
  * Check if adding a candidate would violate category limits in top N.
@@ -90,6 +81,26 @@ const wouldViolateCategoryLimit = (candidate, selected, topN = CATEGORY_LIMIT_TO
 export const DiversifierServiceNoop = Layer.succeed(DiversifierService, {
     mmrDiversify: (candidates, limit, _lambda) => Effect.succeed(candidates.slice(0, limit))
 });
+/**
+ * Find the best candidate from remaining items using MMR scoring.
+ * Returns the candidate with the highest MMR score that doesn't violate category limits.
+ */
+const findBestCandidate = (remaining, selected, lambda, checkCategoryLimits) => Effect.gen(function* () {
+    let bestCandidate = null;
+    let bestScore = -Infinity;
+    for (const candidate of remaining) {
+        // Skip if would violate category limit (when checking is enabled)
+        if (checkCategoryLimits && wouldViolateCategoryLimit(candidate, selected)) {
+            continue;
+        }
+        const score = yield* mmrScore(candidate, selected, lambda);
+        if (score > bestScore) {
+            bestScore = score;
+            bestCandidate = candidate;
+        }
+    }
+    return bestCandidate ? { candidate: bestCandidate, score: bestScore } : null;
+});
 /**
  * Live implementation with full MMR algorithm and category limits.
  *
@@ -100,7 +111,7 @@ export const DiversifierServiceNoop = Layer.succeed(DiversifierService, {
  * 4. Repeat until limit reached or no candidates remain
  */
 export const DiversifierServiceLive = Layer.succeed(DiversifierService, {
-    mmrDiversify: (candidates, limit, lambda = DEFAULT_LAMBDA) => Effect.sync(() => {
+    mmrDiversify: (candidates, limit, lambda = DEFAULT_LAMBDA) => Effect.gen(function* () {
         // Edge case: empty candidates
         if (candidates.length === 0) {
             return [];
@@ -109,8 +120,8 @@ export const DiversifierServiceLive = Layer.succeed(DiversifierService, {
         if (limit <= 0) {
             return [];
         }
-        // Edge case: only one candidate or limit is 1
-        if (candidates.length === 1 || limit === 1) {
+        // Edge case: only one candidate
+        if (candidates.length === 1) {
             return candidates.slice(0, 1);
         }
         // Check if any candidates have embeddings
@@ -123,36 +134,19 @@ export const DiversifierServiceLive = Layer.succeed(DiversifierService, {
         const selected = [];
         const remaining = new Set(candidates);
         while (selected.length < limit && remaining.size > 0) {
-            let bestCandidate = null;
-            let bestScore = -Infinity;
-            for (const candidate of remaining) {
-                // Skip if would violate category limit
-                if (wouldViolateCategoryLimit(candidate, selected)) {
-                    continue;
-                }
-                const score = mmrScore(candidate, selected, lambda);
-                if (score > bestScore) {
-                    bestScore = score;
-                    bestCandidate = candidate;
-                }
-            }
+            // Try to find best candidate respecting category limits
+            let result = yield* findBestCandidate(remaining, selected, lambda, true);
             // If no valid candidate found (all remaining violate category limits),
             // try to find any candidate without category limit check
-            if (!bestCandidate) {
-                for (const candidate of remaining) {
-                    const score = mmrScore(candidate, selected, lambda);
-                    if (score > bestScore) {
-                        bestScore = score;
-                        bestCandidate = candidate;
-                    }
-                }
+            if (!result) {
+                result = yield* findBestCandidate(remaining, selected, lambda, false);
             }
             // Still no candidate? We're done
-            if (!bestCandidate) {
+            if (!result) {
                 break;
             }
-            selected.push(bestCandidate);
-            remaining.delete(bestCandidate);
+            selected.push(result.candidate);
+            remaining.delete(result.candidate);
         }
         return selected;
     })

package/dist/services/diversifier-service.js.map

@@ -1 +1 @@
-{"version":3,"file":"diversifier-service.js","sourceRoot":"","sources":["../../src/services/diversifier-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAE/C,OAAO,EAAE,gBAAgB,EAAE,MAAM,kBAAkB,CAAA;AAEnD;;;;;;;;;GASG;AACH,MAAM,OAAO,kBAAmB,SAAQ,OAAO,CAAC,GAAG,CAAC,oBAAoB,CAAC,EAiBtE;CAAG;AAEN;;;;GAIG;AACH,MAAM,cAAc,GAAG,GAAG,CAAA;AAE1B;;;GAGG;AACH,MAAM,oBAAoB,GAAG,CAAC,CAAA;AAC9B,MAAM,sBAAsB,GAAG,CAAC,CAAA;AAEhC;;;GAGG;AACH,MAAM,uBAAuB,GAAG,CAC9B,SAA4B,EAC5B,QAAsC,EAC9B,EAAE;IACV,iDAAiD;IACjD,IAAI,CAAC,SAAS,CAAC,SAAS,EAAE,CAAC;QACzB,OAAO,CAAC,CAAA;IACV,CAAC;IAED,wBAAwB;IACxB,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC1B,OAAO,CAAC,CAAA;IACV,CAAC;IAED,IAAI,MAAM,GAAG,CAAC,QAAQ,CAAA;IACtB,KAAK,MAAM,IAAI,IAAI,QAAQ,EAAE,CAAC;QAC5B,gCAAgC;QAChC,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;YACpB,SAAQ;QACV,CAAC;QACD,MAAM,GAAG,GAAG,gBAAgB,CAAC,SAAS,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,CAAA;QACjE,IAAI,GAAG,GAAG,MAAM,EAAE,CAAC;YACjB,MAAM,GAAG,GAAG,CAAA;QACd,CAAC;IACH,CAAC;IAED,8CAA8C;IAC9C,OAAO,MAAM,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAA;AAC1C,CAAC,CAAA;AAED;;;;;;;GAOG;AACH,MAAM,QAAQ,GAAG,CACf,SAA4B,EAC5B,QAAsC,EACtC,MAAc,EACN,EAAE;IACV,MAAM,SAAS,GAAG,SAAS,CAAC,cAAc,CAAA;IAC1C,MAAM,MAAM,GAAG,uBAAuB,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAA;IAE3D,OAAO,MAAM,GAAG,SAAS,GAAG,CAAC,CAAC,GAAG,MAAM,CAAC,GAAG,MAAM,CAAA;AACnD,CAAC,CAAA;AAED;;;;;GAKG;AACH,MAAM,yBAAyB,GAAG,CAChC,SAA4B,EAC5B,QAAsC,EACtC,OAAe,oBAAoB,EACnC,aAAqB,sBAAsB,EAClC,EAAE;IACX,yBAAyB;IACzB,IAAI,CAAC,SAAS,CAAC,QAAQ,EAAE,CAAC;QACxB,OAAO,KAAK,CAAA;IACd,CAAC;IAED,+CAA+C;IAC/C,IAAI,QAAQ,CAAC,MAAM,IAAI,IAAI,EAAE,CAAC;QAC5B,OAAO,KAAK,CAAA;IACd,CAAC;IAED,0DAA0D;IAC1D,MAAM,aAAa,GAAG,QAAQ,CAAC,MAAM,CACnC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,KAAK,SAAS,CAAC,QAAQ,CAC7C,CAAC,MAAM,CAAA;IAER,OAAO,aAAa,IAAI,UAAU,CAAA;AACpC,CAAC,CAAA;AAED;;;GAGG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,KAAK,CAAC,OAAO,CACjD,kBAAkB,EAClB;IACE,YAAY,EAAE,CAAC,UAAU,EAAE,KAAK,EAAE,OAAO,EAAE,EAAE,CAC3C,MAAM,CAAC,OAAO,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;CAC7C,CACF,CAAA;AAED;;;;;;;;GAQG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,KAAK,CAAC,OAAO,CACjD,kBAAkB,EAClB;IACE,YAAY,EAAE,CAAC,UAAU,EAAE,KAAK,EAAE,MAAM,GAAG,cAAc,EAAE,EAAE,CAC3D,MAAM,CAAC,IAAI,CAAC,GAAG,EAAE;QACf,8BAA8B;QAC9B,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,EAAE,CAAA;QACX,CAAC;QAED,wBAAwB;QACxB,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;YACf,OAAO,EAAE,CAAA;QACX,CAAC;QAED,8CAA8C;QAC9C,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,EAAE,CAAC;YAC3C,OAAO,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAA;QAC/B,CAAC;QAED,0CAA0C;QAC1C,MAAM,aAAa,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,SAAS,KAAK,IAAI,CAAC,CAAA;QAEhE,kFAAkF;QAClF,IAAI,CAAC,aAAa,EAAE,CAAC;YACnB,OAAO,+BAA+B,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAC3D,CAAC;QAED,qBAAqB;QACrB,MAAM,QAAQ,GAAwB,EAAE,CAAA;QACxC,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC,UAAU,CAAC,CAAA;QAErC,OAAO,QAAQ,CAAC,MAAM,GAAG,KAAK,IAAI,SAAS,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;YACrD,IAAI,aAAa,GAA6B,IAAI,CAAA;YAClD,IAAI,SAAS,GAAG,CAAC,QAAQ,CAAA;YAEzB,KAAK,MAAM,SAAS,IAAI,SAAS,EAAE,CAAC;gBAClC,uCAAuC;gBACvC,IAAI,yBAAyB,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,CAAC;oBACnD,SAAQ;gBACV,CAAC;gBAED,MAAM,KAAK,GAAG,QAAQ,CAAC,SAAS,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAA;gBACnD,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;oBACtB,SAAS,GAAG,KAAK,CAAA;oBACjB,aAAa,GAAG,SAAS,CAAA;gBAC3B,CAAC;YACH,CAAC;YAED,uEAAuE;YACvE,yDAAyD;YACzD,IAAI,CAAC,aAAa,EAAE,CAAC;gBACnB,KAAK,MAAM,SAAS,IAAI,SAAS,EAAE,CAAC;oBAClC,MAAM,KAAK,GAAG,QAAQ,CAAC,SAAS,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAA;oBACnD,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;wBACtB,SAAS,GAAG,KAAK,CAAA;wBACjB,aAAa,GAAG,SAAS,CAAA;oBAC3B,CAAC;gBACH,CAAC;YACH,CAAC;YAED,iCAAiC;YACjC,IAAI,CAAC,aAAa,EAAE,CAAC;gBACnB,MAAK;YACP,CAAC;YAED,QAAQ,CAAC,IAAI,CAAC,aAAa,CAAC,CAAA;YAC5B,SAAS,CAAC,MAAM,CAAC,aAAa,CAAC,CAAA;QACjC,CAAC;QAED,OAAO,QAAQ,CAAA;IACjB,CAAC,CAAC;CACL,CACF,CAAA;AAED;;;;;;GAMG;AACH,MAAM,+BAA+B,GAAG,CACtC,UAAwC,EACxC,KAAa,EACiB,EAAE;IAChC,MAAM,QAAQ,GAAwB,EAAE,CAAA;IAExC,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;QACnC,IAAI,QAAQ,CAAC,MAAM,IAAI,KAAK,EAAE,CAAC;YAC7B,MAAK;QACP,CAAC;QAED,uCAAuC;QACvC,IAAI,yBAAyB,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,CAAC;YACnD,SAAQ;QACV,CAAC;QAED,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IAC1B,CAAC;IAED,sEAAsE;IACtE,IAAI,QAAQ,CAAC,MAAM,GAAG,KAAK,EAAE,CAAC;QAC5B,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,CAAA;QACrC,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;YACnC,IAAI,QAAQ,CAAC,MAAM,IAAI,KAAK,EAAE,CAAC;gBAC7B,MAAK;YACP,CAAC;YACD,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;gBAChC,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;YAC1B,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAA;AACjB,CAAC,CAAA;AAED;;GAEG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,sBAAsB,CAAA"}
+{"version":3,"file":"diversifier-service.js","sourceRoot":"","sources":["../../src/services/diversifier-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAE/C,OAAO,EAAE,gBAAgB,EAAE,MAAM,kBAAkB,CAAA;AAGnD;;;;;;;;;GASG;AACH,MAAM,OAAO,kBAAmB,SAAQ,OAAO,CAAC,GAAG,CAAC,oBAAoB,CAAC,EAiBtE;CAAG;AAEN;;;;GAIG;AACH,MAAM,cAAc,GAAG,GAAG,CAAA;AAE1B;;;GAGG;AACH,MAAM,oBAAoB,GAAG,CAAC,CAAA;AAC9B,MAAM,sBAAsB,GAAG,CAAC,CAAA;AAEhC;;;GAGG;AACH,MAAM,uBAAuB,GAAG,CAC9B,SAA4B,EAC5B,QAAsC,EACkB,EAAE;IAC1D,iDAAiD;IACjD,IAAI,CAAC,SAAS,CAAC,SAAS,EAAE,CAAC;QACzB,OAAO,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAA;IAC1B,CAAC;IAED,wBAAwB;IACxB,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC1B,OAAO,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAA;IAC1B,CAAC;IAED,MAAM,mBAAmB,GAAG,QAAQ,CAAC,MAAM,CACzC,CAAC,IAAI,EAA2D,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,IAAI,CAC3F,CAAA;IAED,IAAI,mBAAmB,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACrC,OAAO,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAA;IAC1B,CAAC;IAED,OAAO,MAAM,CAAC,OAAO,CAAC,mBAAmB,EAAE,IAAI,CAAC,EAAE,CAChD,gBAAgB,CAAC,SAAS,CAAC,SAAU,EAAE,IAAI,CAAC,SAAS,CAAC,CACvD,CAAC,IAAI,CACJ,MAAM,CAAC,GAAG,CAAC,YAAY,CAAC,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,GAAG,YAAY,CAAC,CAAC,CACtD,CAAA;AACH,CAAC,CAAA;AAED;;;;;;;GAOG;AACH,MAAM,QAAQ,GAAG,CACf,SAA4B,EAC5B,QAAsC,EACtC,MAAc,EAC0C,EAAE;IAC1D,MAAM,SAAS,GAAG,SAAS,CAAC,cAAc,CAAA;IAC1C,OAAO,uBAAuB,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,IAAI,CACtD,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,GAAG,SAAS,GAAG,CAAC,CAAC,GAAG,MAAM,CAAC,GAAG,MAAM,CAAC,CACjE,CAAA;AACH,CAAC,CAAA;AAED;;;;;GAKG;AACH,MAAM,yBAAyB,GAAG,CAChC,SAA4B,EAC5B,QAAsC,EACtC,OAAe,oBAAoB,EACnC,aAAqB,sBAAsB,EAClC,EAAE;IACX,yBAAyB;IACzB,IAAI,CAAC,SAAS,CAAC,QAAQ,EAAE,CAAC;QACxB,OAAO,KAAK,CAAA;IACd,CAAC;IAED,+CAA+C;IAC/C,IAAI,QAAQ,CAAC,MAAM,IAAI,IAAI,EAAE,CAAC;QAC5B,OAAO,KAAK,CAAA;IACd,CAAC;IAED,0DAA0D;IAC1D,MAAM,aAAa,GAAG,QAAQ,CAAC,MAAM,CACnC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,KAAK,SAAS,CAAC,QAAQ,CAC7C,CAAC,MAAM,CAAA;IAER,OAAO,aAAa,IAAI,UAAU,CAAA;AACpC,CAAC,CAAA;AAED;;;GAGG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,KAAK,CAAC,OAAO,CACjD,kBAAkB,EAClB;IACE,YAAY,EAAE,CAAC,UAAU,EAAE,KAAK,EAAE,OAAO,EAAE,EAAE,CAC3C,MAAM,CAAC,OAAO,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;CAC7C,CACF,CAAA;AAED;;;GAGG;AACH,MAAM,iBAAiB,GAAG,CACxB,SAAiC,EACjC,QAAsC,EACtC,MAAc,EACd,mBAA4B,EAC4E,EAAE,CAC1G,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;IAClB,IAAI,aAAa,GAA6B,IAAI,CAAA;IAClD,IAAI,SAAS,GAAG,CAAC,QAAQ,CAAA;IAEzB,KAAK,MAAM,SAAS,IAAI,SAAS,EAAE,CAAC;QAClC,kEAAkE;QAClE,IAAI,mBAAmB,IAAI,yBAAyB,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,CAAC;YAC1E,SAAQ;QACV,CAAC;QAED,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,QAAQ,CAAC,SAAS,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAA;QAC1D,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;YACtB,SAAS,GAAG,KAAK,CAAA;YACjB,aAAa,GAAG,SAAS,CAAA;QAC3B,CAAC;IACH,CAAC;IAED,OAAO,aAAa,CAAC,CAAC,CAAC,EAAE,SAAS,EAAE,aAAa,EAAE,KAAK,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC,IAAI,CAAA;AAC9E,CAAC,CAAC,CAAA;AAEJ;;;;;;;;GAQG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,KAAK,CAAC,OAAO,CACjD,kBAAkB,EAClB;IACE,YAAY,EAAE,CAAC,UAAU,EAAE,KAAK,EAAE,MAAM,GAAG,cAAc,EAAE,EAAE,CAC3D,MAAM,CAAC,GAAG,CAAC,QAAQ,CAAC;QAClB,8BAA8B;QAC9B,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,EAAE,CAAA;QACX,CAAC;QAED,wBAAwB;QACxB,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;YACf,OAAO,EAAE,CAAA;QACX,CAAC;QAED,gCAAgC;QAChC,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,UAAU,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAA;QAC/B,CAAC;QAED,0CAA0C;QAC1C,MAAM,aAAa,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,SAAS,KAAK,IAAI,CAAC,CAAA;QAEhE,kFAAkF;QAClF,IAAI,CAAC,aAAa,EAAE,CAAC;YACnB,OAAO,+BAA+B,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAC3D,CAAC;QAED,qBAAqB;QACrB,MAAM,QAAQ,GAAwB,EAAE,CAAA;QACxC,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC,UAAU,CAAC,CAAA;QAErC,OAAO,QAAQ,CAAC,MAAM,GAAG,KAAK,IAAI,SAAS,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;YACrD,wDAAwD;YACxD,IAAI,MAAM,GAAG,KAAK,CAAC,CAAC,iBAAiB,CAAC,SAAS,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,CAAC,CAAA;YAExE,uEAAuE;YACvE,yDAAyD;YACzD,IAAI,CAAC,MAAM,EAAE,CAAC;gBACZ,MAAM,GAAG,KAAK,CAAC,CAAC,iBAAiB,CAAC,SAAS,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,CAAC,CAAA;YACvE,CAAC;YAED,iCAAiC;YACjC,IAAI,CAAC,MAAM,EAAE,CAAC;gBACZ,MAAK;YACP,CAAC;YAED,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,CAAA;YAC/B,SAAS,CAAC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAA;QACpC,CAAC;QAED,OAAO,QAAQ,CAAA;IACjB,CAAC,CAAC;CACL,CACF,CAAA;AAED;;;;;;GAMG;AACH,MAAM,+BAA+B,GAAG,CACtC,UAAwC,EACxC,KAAa,EACiB,EAAE;IAChC,MAAM,QAAQ,GAAwB,EAAE,CAAA;IAExC,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;QACnC,IAAI,QAAQ,CAAC,MAAM,IAAI,KAAK,EAAE,CAAC;YAC7B,MAAK;QACP,CAAC;QAED,uCAAuC;QACvC,IAAI,yBAAyB,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,CAAC;YACnD,SAAQ;QACV,CAAC;QAED,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IAC1B,CAAC;IAED,sEAAsE;IACtE,IAAI,QAAQ,CAAC,MAAM,GAAG,KAAK,EAAE,CAAC;QAC5B,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,CAAA;QACrC,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;YACnC,IAAI,QAAQ,CAAC,MAAM,IAAI,KAAK,EAAE,CAAC;gBAC7B,MAAK;YACP,CAAC;YACD,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;gBAChC,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;YAC1B,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAA;AACjB,CAAC,CAAA;AAED;;GAEG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,sBAAsB,CAAA"}

package/dist/services/doc-service.d.ts

@@ -0,0 +1,49 @@
+/**
+ * DocService — business logic for docs-as-primitives (DD-023).
+ *
+ * Manages doc lifecycle (create/update/lock/version), rendering (YAML→MD),
+ * linking (doc-doc, task-doc), invariant sync, drift detection, and graph data.
+ *
+ * YAML content lives on disk (.tx/docs/); DB stores metadata + links only.
+ */
+import { Context, Effect, Layer } from "effect";
+import { DocRepository } from "../repo/doc-repo.js";
+import { DatabaseError, ValidationError, DocNotFoundError, DocLockedError, InvalidDocYamlError, InvariantNotFoundError } from "../errors.js";
+import type { Doc, DocKind, DocStatus, DocLink, DocLinkType, Invariant, InvariantCheck, DocGraph } from "@jamesaphoenix/tx-types";
+declare const DocService_base: Context.TagClass<DocService, "DocService", {
+    readonly create: (input: {
+        kind: DocKind;
+        name: string;
+        title: string;
+        yamlContent: string;
+        metadata?: Record<string, unknown>;
+    }) => Effect.Effect<Doc, ValidationError | InvalidDocYamlError | DatabaseError>;
+    readonly get: (name: string, version?: number) => Effect.Effect<Doc, DocNotFoundError | DatabaseError>;
+    readonly update: (name: string, yamlContent: string) => Effect.Effect<Doc, DocNotFoundError | DocLockedError | InvalidDocYamlError | DatabaseError>;
+    readonly lock: (name: string) => Effect.Effect<Doc, DocNotFoundError | DatabaseError>;
+    readonly list: (filter?: {
+        kind?: DocKind;
+        status?: DocStatus;
+    }) => Effect.Effect<readonly Doc[], DatabaseError>;
+    readonly remove: (name: string) => Effect.Effect<void, DocNotFoundError | DocLockedError | DatabaseError>;
+    readonly render: (name?: string) => Effect.Effect<readonly string[], DocNotFoundError | InvalidDocYamlError | DatabaseError>;
+    readonly createVersion: (name: string) => Effect.Effect<Doc, DocNotFoundError | ValidationError | DatabaseError>;
+    readonly linkDocs: (fromName: string, toName: string, linkType?: DocLinkType) => Effect.Effect<DocLink, DocNotFoundError | ValidationError | DatabaseError>;
+    readonly attachTask: (taskId: string, docName: string, linkType?: "implements" | "references") => Effect.Effect<void, DocNotFoundError | DatabaseError>;
+    readonly createPatch: (designName: string, patchName: string, patchTitle: string) => Effect.Effect<Doc, DocNotFoundError | ValidationError | InvalidDocYamlError | DatabaseError>;
+    readonly validate: () => Effect.Effect<readonly string[], DatabaseError>;
+    readonly detectDrift: (name: string) => Effect.Effect<readonly string[], DocNotFoundError | DatabaseError>;
+    readonly generateIndex: () => Effect.Effect<void, DatabaseError>;
+    readonly syncInvariants: (docName?: string) => Effect.Effect<readonly Invariant[], DocNotFoundError | InvalidDocYamlError | DatabaseError>;
+    readonly listInvariants: (filter?: {
+        subsystem?: string;
+        enforcement?: string;
+    }) => Effect.Effect<readonly Invariant[], DatabaseError>;
+    readonly recordInvariantCheck: (id: string, passed: boolean, details?: string, durationMs?: number) => Effect.Effect<InvariantCheck, InvariantNotFoundError | DatabaseError>;
+    readonly getDocGraph: () => Effect.Effect<DocGraph, DatabaseError>;
+}>;
+export declare class DocService extends DocService_base {
+}
+export declare const DocServiceLive: Layer.Layer<DocService, never, DocRepository>;
+export {};
+//# sourceMappingURL=doc-service.d.ts.map

package/dist/services/doc-service.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"doc-service.d.ts","sourceRoot":"","sources":["../../src/services/doc-service.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAIH,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,QAAQ,CAAA;AAE/C,OAAO,EAAE,aAAa,EAAuB,MAAM,qBAAqB,CAAA;AACxE,OAAO,EACL,aAAa,EACb,eAAe,EACf,gBAAgB,EAChB,cAAc,EACd,mBAAmB,EACnB,sBAAsB,EACvB,MAAM,cAAc,CAAA;AAIrB,OAAO,KAAK,EACV,GAAG,EACH,OAAO,EACP,SAAS,EACT,OAAO,EACP,WAAW,EACX,SAAS,EACT,cAAc,EACd,QAAQ,EAIT,MAAM,yBAAyB,CAAA;;qBA8DX,CAAC,KAAK,EAAE;QAAE,IAAI,EAAE,OAAO,CAAC;QAAC,IAAI,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,MAAM,CAAC;QAAC,QAAQ,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAA;KAAE,KAAK,MAAM,CAAC,MAAM,CAAC,GAAG,EAAE,eAAe,GAAG,mBAAmB,GAAG,aAAa,CAAC;kBAChM,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,GAAG,EAAE,gBAAgB,GAAG,aAAa,CAAC;qBACrF,CAAC,IAAI,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,GAAG,EAAE,gBAAgB,GAAG,cAAc,GAAG,mBAAmB,GAAG,aAAa,CAAC;mBACpI,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,GAAG,EAAE,gBAAgB,GAAG,aAAa,CAAC;mBACtE,CAAC,MAAM,CAAC,EAAE;QAAE,IAAI,CAAC,EAAE,OAAO,CAAC;QAAC,MAAM,CAAC,EAAE,SAAS,CAAA;KAAE,KAAK,MAAM,CAAC,MAAM,CAAC,SAAS,GAAG,EAAE,EAAE,aAAa,CAAC;qBAC/F,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,gBAAgB,GAAG,cAAc,GAAG,aAAa,CAAC;qBAGxF,CAAC,IAAI,CAAC,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,SAAS,MAAM,EAAE,EAAE,gBAAgB,GAAG,mBAAmB,GAAG,aAAa,CAAC;4BAGpG,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,GAAG,EAAE,gBAAgB,GAAG,eAAe,GAAG,aAAa,CAAC;uBAG7F,CAAC,QAAQ,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,QAAQ,CAAC,EAAE,WAAW,KAAK,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,gBAAgB,GAAG,eAAe,GAAG,aAAa,CAAC;yBACtI,CAAC,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,QAAQ,CAAC,EAAE,YAAY,GAAG,YAAY,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,gBAAgB,GAAG,aAAa,CAAC;0BACjI,CAAC,UAAU,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,GAAG,EAAE,gBAAgB,GAAG,eAAe,GAAG,mBAAmB,GAAG,aAAa,CAAC;uBAG9J,MAAM,MAAM,CAAC,MAAM,CAAC,SAAS,MAAM,EAAE,EAAE,aAAa,CAAC;0BAClD,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,SAAS,MAAM,EAAE,EAAE,gBAAgB,GAAG,aAAa,CAAC;4BAGlF,MAAM,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,aAAa,CAAC;6BAGvC,CAAC,OAAO,CAAC,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,SAAS,SAAS,EAAE,EAAE,gBAAgB,GAAG,mBAAmB,GAAG,aAAa,CAAC;6BACjH,CAAC,MAAM,CAAC,EAAE;QAAE,SAAS,CAAC,EAAE,MAAM,CAAC;QAAC,WAAW,CAAC,EAAE,MAAM,CAAA;KAAE,KAAK,MAAM,CAAC,MAAM,CAAC,SAAS,SAAS,EAAE,EAAE,aAAa,CAAC;mCACvG,CAAC,EAAE,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,CAAC,EAAE,MAAM,EAAE,UAAU,CAAC,EAAE,MAAM,KAAK,MAAM,CAAC,MAAM,CAAC,cAAc,EAAE,sBAAsB,GAAG,aAAa,CAAC;0BAGtJ,MAAM,MAAM,CAAC,MAAM,CAAC,QAAQ,EAAE,aAAa,CAAC;;AAnCtE,qBAAa,UAAW,SAAQ,eAqC7B;CAAG;AAEN,eAAO,MAAM,cAAc,+CA6mB1B,CAAA"}