@jambonz/time-series 0.2.20 → 0.2.22

package/index.js

@@ -22,7 +22,9 @@ const AlertType = {
   ACCOUNT_INACTIVE: 'account is inactive or suspended',
   PLAY_FILENOTFOUND: 'play-url-notfound',
   TTS_STREAMING_CONNECTION_FAILURE: 'tts-streaming-connection-failure',
-  APPLICATION: 'alert-from-application'
+  KRISP_NOT_PROVISIONED: 'no-krisp',
+  APPLICATION: 'alert-from-application',
+  ERROR_UPDATING_CALL: 'error-updating-call'
 };
 
 const schemas = {
@@ -734,11 +736,19 @@ const writeAlerts = async(client, alerts) => {
           case AlertType.TTS_STREAMING_CONNECTION_FAILURE:
             message = `Failed to connect to tts streaming service at ${vendor}`;
             break;
+          case AlertType.ERROR_UPDATING_CALL:
+            message = `error updating call${detail ? `: ${detail}` : ''}`;
+            break;
           default:
             break;
         }
       }
-      let fields =  { message };
+      /* Never write an undefined/empty (or non-string) message field. In line
+       * protocol an undefined value serializes to the bare token `undefined`,
+       * which InfluxDB rejects ("invalid boolean") and fails the entire batch
+       * write — taking down every alert in the same flush. */
+      if (!message) message = alert_type || 'unknown alert';
+      let fields =  { message: String(message) };
       if (target_sid) fields = Object.assign(fields, {target_sid});
       const obj = {measurement: 'alerts', fields: fields, tags: { alert_type, service_provider_sid, account_sid,
         ...(vendor && {vendor})}};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jambonz/time-series",
-  "version": "0.2.20",
+  "version": "0.2.22",
   "description": "write and query data to time series daetabase",
   "main": "index.js",
   "scripts": {

package/test/unit-tests.js

@@ -214,6 +214,41 @@ test('write timeseries data', async(t) => {
   //console.log(result);
   t.ok(result.data.length === 15, 'queried alerts by service_provider_sid');
 
+  /* regression: an alert with no resolvable message must not poison the write.
+   * Previously `message: undefined` serialized to the bare token `undefined`
+   * in line protocol and InfluxDB rejected the whole batch ("invalid boolean").
+   * Distinct account_sids (a tag) so each is its own series and a shared
+   * service_provider_sid that doesn't collide with the counts above. */
+  await writeAlerts([
+    {
+      // ERROR_UPDATING_CALL with an undefined message + detail (the prod shape)
+      alert_type: AlertType.ERROR_UPDATING_CALL,
+      service_provider_sid: 'sp-guard',
+      account_sid: 'acct-guard-1',
+      message: undefined,
+      detail: 'cannot read property foo of undefined',
+      target_sid: 'call-guard'
+    },
+    {
+      // ERROR_UPDATING_CALL with neither message nor detail (bare default)
+      alert_type: AlertType.ERROR_UPDATING_CALL,
+      service_provider_sid: 'sp-guard',
+      account_sid: 'acct-guard-2'
+    },
+    {
+      // an unknown alert_type with no message must still produce a valid write
+      alert_type: 'some-unknown-alert-type',
+      service_provider_sid: 'sp-guard',
+      account_sid: 'acct-guard-3'
+    }
+  ]);
+  t.pass('wrote alerts with undefined/missing message without poisoning the batch');
+
+  result = await queryAlertsSP({service_provider_sid: 'sp-guard', page: 1, page_size: 25, days: 7});
+  t.ok(result.data.length === 3, 'all three guard alerts were stored (write was not rejected)');
+  t.ok(result.data.every((a) => typeof a.message === 'string' && a.message.length > 0),
+    'every stored alert has a non-empty string message');
+
   result = await writeCallCount(
     {
       calls_in_progress: 49,