@jambonz/node-red-contrib-jambonz 2.3.2 → 2.3.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jambonz/node-red-contrib-jambonz",
-  "version": "2.3.2",
+  "version": "2.3.4",
   "description": "Node-RED nodes for jambonz platform",
   "keywords": [
     "node-red"

package/src/nodes/create_call.html

@@ -258,18 +258,21 @@
 <script type="text/html" data-help-name="create-call">
   <p>Create an outbound call</p>
   <h3>Properties</h3>
-    <p><code>Server</code> -jambonz server to connect to</p>
+    <p><code>Server</code> - Jambonz server to connect to</p>
     <p><code>From</code> - Calling party phone number</p>
     <p><code>To</code> - Called party phone number, or other identifier</p>
     <p><code>Call type</code> - Type of destination: phone number, registered user, sip endpoint, or microsoft teams</p>
     <p><code>Application</code> - Application to execute when call is answered</p>
-  
+    <p><code>Webhooks</code> - Webhooks to execute when call is answered</p>
+
   <h3>Outputs</h3>
   <dl class="message-properties">
     <dt>statusCode<span class="property-type">int</span></dt>
-    <dd> <code>msg.statusCode</code> will contain the response code from Jambomnz to the createCall request</dd>
+    <dd> <code>msg.statusCode</code> will contain the response code from Jambonz to the createCall request</dd>
     <dt>callSid<span class="property-type">string</span></dt>
     <dd> <code>msg.callSid</code> will contain the SID of the call that was created</dd>
+    <dt>callId<span class="property-type">string</span></dt>
+    <dd> <code>msg.callId</code> will contain the call id of the call that was created</dd>
   </dl>
   
   <h3>Details</h3>

package/src/nodes/create_call.js

@@ -31,23 +31,23 @@ module.exports = function(RED) {
 
       switch (config.mode) {
         case 'app':
-          opts.application_sid =  config.application 
+          opts.application_sid = config.application;
           break
         case 'url':
           opts.call_hook = {
-            url: config.call_hook_url,
+            url: v_resolve(config.call_hook_url, config.call_hook_urlType, this.context(), msg),
             method: config.call_hook_method
-          }
+          };
           opts.call_status_hook = {
-            url: config.call_status_url,
+            url: v_resolve(config.call_status_url, config.call_status_urlType, this.context(), msg),
             method: config.call_status_method
-          }
-          opts.speech_synthesis_vendor = config.vendor
-          opts.speech_synthesis_language = config.lang
-          opts.speech_synthesis_voice = config.voice
-          opts.speech_recognizer_vendor = config.transcriptionvendor
-          opts.speech_recognizer_language = config.recognizerlang
-          break
+          };
+          opts.speech_synthesis_vendor = config.vendor;
+          opts.speech_synthesis_language = config.lang;
+          opts.speech_synthesis_voice = config.voice;
+          opts.speech_recognizer_vendor = config.transcriptionvendor;
+          opts.speech_recognizer_language = config.recognizerlang;
+          break;
       }
 
       if (config.timeout) {
@@ -73,19 +73,25 @@ module.exports = function(RED) {
           send(msg);
           return;
       }
-      node.log(JSON.stringify(opts))
       try {
+        node.log(`sending create call ${JSON.stringify(opts)}`);
         const res = await doCreateCall(url, accountSid, apiToken, opts);
-        msg.statusCode = 202;
+        msg.statusCode = 201;
         msg.callSid = res.sid;
+        msg.callId = res.callId;
       } catch (err) {
         if (err.statusCode) {
-          console.log(JSON.stringify(err))
-          node.error(`create-call failed with ${err.statusCode}`);
+          node.log(JSON.stringify(err));
+          try {
+            const responseBody = await err.json();
+            node.error(`create-call failed with ${err.statusCode}. Response ${JSON.stringify(responseBody)}`);
+          } catch (e) {
+            node.error(`create-call failed with ${err.statusCode}`);
+          }
           msg.statusCode = err.statusCode;
         }
         else {
-          node.error(`Error sending create all ${JSON.stringify(err)}`);
+          node.error(`Error sending create call ${JSON.stringify(err)}`);
           if (done) done(err);
           else node.error(err, msg);
           send(msg);

package/src/nodes/create_sms.html

@@ -82,13 +82,22 @@
   
 <!-- Help Text -->
 <script type="text/html" data-help-name="create-sms">
-    <p>Send an SMS</p>
-    <h3>Properties</h3>
-    <p><code>Server</code> -  jambonz server to connect to</p>
-    <p><code>From</code> -  Sending party phone number</p>
-    <p><code>To</code> -  Destination phone number</p>
+  <p>Create an outbound SMS message</p>
+  <h3>Properties</h3>
+    <p><code>Server</code> - Jambonz server to connect to</p>
+    <p><code>From</code> - Sending party phone number</p>
+    <p><code>To</code> - Destination phone number</p>
     <p><code>Text</code> - Text message</p>
 
+  <h3>Outputs</h3>
+  <dl class="message-properties">
+    <dt>statusCode<span class="property-type">int</span></dt>
+    <dd> <code>msg.statusCode</code> will contain the response code from Jambonz to the createMessage request</dd>
+    <dt>messageSid<span class="property-type">string</span></dt>
+    <dd> <code>msg.messageSid</code> will contain the SID of the message that was created</dd>
+    <dt>providerResponse<span class="property-type">string</span></dt>
+    <dd> <code>msg.providerResponse</code> will contain the provider response of the call that was created</dd>
+  </dl>  
   <h3>Details</h3>
-  The create message command is used to send an SMS message.  
+  The create message command is used to send an outbound SMS message.  
 </script>

package/src/nodes/create_sms.js

@@ -30,17 +30,21 @@ function create_sms(config) {
         text,
         provider
       };
-
       try {
         node.log(`sending create message ${JSON.stringify(opts)}`);
         const res = await doCreateMessage(url, accountSid, apiToken, opts);
-        msg.statusCode = 202;
+        msg.statusCode = 201;
         msg.messageSid = res.sid;
         msg.providerResponse = res.providerResponse;
-        node.log(`successfully launched call with messageSid ${msg.messageSid}`);
       } catch (err) {
         if (err.statusCode) {
-          node.log(`create_message failed with ${err.statusCode}`);
+          node.log(JSON.stringify(err));
+          try {
+            const responseBody = await err.json();
+            node.error(`create_sms failed with ${err.statusCode}. Response ${JSON.stringify(responseBody)}`);
+          } catch (e) {
+            node.error(`create_sms failed with ${err.statusCode}`);
+          }
           msg.statusCode = err.statusCode;
         }
         else {
@@ -56,5 +60,4 @@ function create_sms(config) {
     });
   }
   RED.nodes.registerType('create-sms', create_sms);
-
 }