@jambonz/mrf 0.1.3 → 0.1.5

package/lib/endpoint.js

@@ -1,4 +1,5 @@
 const { EventEmitter } = require('events');
+const { randomUUID } = require('crypto');
 const { parseSdp, translatePlayUrl } = require('./utils');
 
 // mediajam normalized wire events -> legacy ESL event names the
@@ -48,15 +49,27 @@ class Endpoint extends EventEmitter {
     }
     const files = Array.isArray(file) ? file : [file];
     const urls = files.map(translatePlayUrl);
-    const data = { urls };
+    /* the client supplies the playId so _pendingPlays is populated BEFORE
+     * anything hits the wire — the server's play.start event can arrive in
+     * the same tcp chunk as the command response, which processes ahead of
+     * the awaiter's microtask; a lookup keyed on the response's playId
+     * misses that window (seen live: playback-start without file). */
+    const playId = randomUUID();
+    const data = { urls, playId };
     if (seekOffset > 0) data.seekOffset = parseInt(seekOffset, 10);
-    const { playId } = await this._request('play.start', data);
-    return new Promise((resolve, reject) => {
+    const result = new Promise((resolve, reject) => {
       // file (the caller's original, untranslated path) rides on the
       // playback-start/stop events: FS parity — the say/play tasks match
       // events to plays by evt.file when there is no tts playback id
       this._pendingPlays.set(playId, { resolve, reject, file: files[0] });
     });
+    try {
+      await this._request('play.start', data);
+    } catch (err) {
+      this._pendingPlays.delete(playId);
+      throw err;
+    }
+    return result;
   }
 
   /** fsmrf api() passthrough: translate the FS api commands in use. */
@@ -528,13 +541,23 @@ class Endpoint extends EventEmitter {
  */
 function ttsVars(tts) {
   if (!tts) return {};
-  return {
+  const out = {
     ...(tts.playbackId && {variable_tts_playback_id: tts.playbackId}),
     ...(tts.ttfbMs !== undefined && {variable_tts_time_to_first_byte_ms: String(tts.ttfbMs)}),
     ...(tts.cacheFilename && {variable_tts_cache_filename: tts.cacheFilename}),
     ...(tts.error && {variable_tts_error: tts.error}),
     ...(tts.responseCode !== undefined && {variable_tts_response_code: String(tts.responseCode)}),
   };
+  /* vendor dial/response metadata (request id, connect timings, voice):
+   * FS modules exposed these as tts_<vendor>_<field> channel variables
+   * and the feature-server turns every variable_tts_* into an otel span
+   * attribute */
+  if (tts.vendor && tts.info) {
+    for (const [k, v] of Object.entries(tts.info)) {
+      out[`variable_tts_${tts.vendor}_${k}`] = String(v);
+    }
+  }
+  return out;
 }
 
 module.exports = Endpoint;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jambonz/mrf",
-  "version": "0.1.3",
+  "version": "0.1.5",
   "main": "index.js",
   "scripts": {
     "test": "node --test",

package/test/support/mock-server.js

@@ -97,7 +97,7 @@ class MockMediajam {
       case 'play.start': {
         const ep = this.endpoints.get(frame.ep);
         if (!ep) return fail('unknown_endpoint', frame.ep);
-        const playId = randomUUID().slice(0, 8);
+        const playId = frame.data?.playId || randomUUID().slice(0, 8);
         res({ playId });
         this.send(socket, { t: 'evt', ep: frame.ep, evt: 'play.start', data: { playId } });
         const t = setTimeout(() => {