@jam-mcp/server 1.4.2 → 1.4.3

package/README.md

@@ -74,10 +74,10 @@ auth login   Store Jira credentials in this user's OS secret store
 runtime      Show or change which JAM build this machine runs
 ```
 
-Written out, that is `npx --yes @jam-mcp/launcher@1.4.2 doctor`, or just `jam
+Written out, that is `npx --yes @jam-mcp/launcher@1.4.3 doctor`, or just `jam
 doctor` if you took the launcher's optional global install. Starting from
 nothing — no install, no runtime chosen yet — use
-`npx --yes @jam-mcp/bootstrap@1.4.2 init` instead.
+`npx --yes @jam-mcp/bootstrap@1.4.3 init` instead.
 
 Credentials come from the process environment or this user's OS secret store —
 never from a repository file — and never appear in logs, telemetry, or tool

package/dist/bootstrap/host-mcp.d.ts

@@ -42,6 +42,16 @@ export type HostRunResult = {
 /** Injected by tests. Nothing in this module may reach a real CLI unasked. */
 export type HostRunner = (command: HostCommand) => HostRunResult;
 export declare const defaultHostRunner: HostRunner;
+/**
+ * A runner that only sees what is persistently installed on this machine.
+ *
+ * Under `npx --yes @jam-mcp/bootstrap@X`, PATH carries npx's cache
+ * `node_modules/.bin` - which contains a `jam` shim that vanishes when npx
+ * exits. Any measurement of "does a global jam exist" through the normal PATH
+ * therefore lies during bootstrap, which is exactly when the answer matters
+ * most. This runner strips those entries first.
+ */
+export declare const persistentHostRunner: HostRunner;
 export declare function hostRegistration(id: HostId, options?: {
     bare?: boolean;
 }): HostCommand | undefined;
@@ -80,6 +90,10 @@ export declare function isBareJamEntry(line: string): boolean;
  *
  * undefined when `jam` is not on PATH or does not answer: a registration that
  * cannot be measured counts as stale, same as an unreadable pin.
+ *
+ * Measured through persistentHostRunner by default: under an npx bootstrap
+ * the ordinary PATH resolves `jam` to npx's own ephemeral cache shim, and a
+ * bare registration decided on that evidence dies as soon as npx exits.
  */
 export declare function bareJamVersion(run?: HostRunner): string | undefined;
 /** Is this measured launcher version the one this release registers? */

package/dist/bootstrap/host-mcp.js

@@ -1,18 +1,43 @@
 import { spawnSync } from "node:child_process";
 import { JAM_MCP_ENTRY } from "./mcp-config-merger.js";
+import { shellInvocation, stripPackageRunnerPath } from "./shell-command.js";
 /**
  * These boot a whole Node CLI, and Claude Code health-checks every configured
  * server while listing, which is seconds rather than milliseconds.
  */
 const HOST_TIMEOUT_MS = 20_000;
 export const defaultHostRunner = ({ command, args }) => {
-    const result = spawnSync(command, args, {
+    // Both CLIs are npm shims on Windows, and Node refuses to spawn a .cmd
+    // without a shell. Every argument JAM passes is a bare token - no JSON, no
+    // spaces - and shellInvocation validates exactly that before joining the
+    // argv into one line (an args array plus shell:true is DEP0190).
+    const invocation = shellInvocation(command, args);
+    const result = spawnSync(invocation.command, invocation.args, {
         encoding: "utf8",
         timeout: HOST_TIMEOUT_MS,
-        // Both CLIs are npm shims on Windows, and Node refuses to spawn a .cmd
-        // without a shell. Every argument JAM passes is a bare token - no JSON, no
-        // spaces - precisely so this cannot become a quoting hazard.
-        shell: process.platform === "win32",
+        shell: invocation.shell,
+    });
+    if (result.error)
+        return { status: null, failed: true, stdout: "" };
+    return { status: result.status, failed: false, stdout: result.stdout ?? "" };
+};
+/**
+ * A runner that only sees what is persistently installed on this machine.
+ *
+ * Under `npx --yes @jam-mcp/bootstrap@X`, PATH carries npx's cache
+ * `node_modules/.bin` - which contains a `jam` shim that vanishes when npx
+ * exits. Any measurement of "does a global jam exist" through the normal PATH
+ * therefore lies during bootstrap, which is exactly when the answer matters
+ * most. This runner strips those entries first.
+ */
+export const persistentHostRunner = ({ command, args }) => {
+    const invocation = shellInvocation(command, args);
+    const pathValue = process.env.PATH ?? process.env.Path ?? "";
+    const result = spawnSync(invocation.command, invocation.args, {
+        encoding: "utf8",
+        timeout: HOST_TIMEOUT_MS,
+        shell: invocation.shell,
+        env: { ...process.env, PATH: stripPackageRunnerPath(pathValue) },
     });
     if (result.error)
         return { status: null, failed: true, stdout: "" };
@@ -106,8 +131,12 @@ export function isBareJamEntry(line) {
  *
  * undefined when `jam` is not on PATH or does not answer: a registration that
  * cannot be measured counts as stale, same as an unreadable pin.
+ *
+ * Measured through persistentHostRunner by default: under an npx bootstrap
+ * the ordinary PATH resolves `jam` to npx's own ephemeral cache shim, and a
+ * bare registration decided on that evidence dies as soon as npx exits.
  */
-export function bareJamVersion(run = defaultHostRunner) {
+export function bareJamVersion(run = persistentHostRunner) {
     const result = run({ command: "jam", args: ["runtime", "status", "--json"] });
     if (result.failed || result.status !== 0)
         return undefined;
@@ -187,7 +216,10 @@ function probeHosts(run) {
         };
     });
     function measuredBare() {
-        bareCache ??= { version: bareJamVersion(run) };
+        // The real probe runner sees npx's contaminated PATH; the persistent
+        // runner is the honest one for this question. An injected runner is a
+        // test, and stays in charge of its own answers.
+        bareCache ??= { version: bareJamVersion(run === defaultHostRunner ? persistentHostRunner : run) };
         return bareCache.version;
     }
 }

package/dist/bootstrap/live-toolset.js

@@ -1,4 +1,5 @@
 import { spawn } from "node:child_process";
+import { shellInvocation } from "./shell-command.js";
 import { SERVER_VERSION } from "@jam-mcp/launcher";
 import { TOOL_NAMES } from "../mcp/create-server.js";
 const HANDSHAKE_TIMEOUT_MS = 30_000;
@@ -9,9 +10,12 @@ export const expectedTools = () => [...TOOL_NAMES].sort();
  * one question that is three lines of JSON.
  */
 export const defaultToolsetProbe = ({ command, args }) => new Promise((resolve) => {
-    const child = spawn(command, args, {
+    // npm shims need a shell on Windows; the argv is joined by shellInvocation
+    // (validated bare tokens) because an args array plus shell:true is DEP0190.
+    const invocation = shellInvocation(command, args);
+    const child = spawn(invocation.command, invocation.args, {
         stdio: ["pipe", "pipe", "ignore"],
-        shell: process.platform === "win32",
+        shell: invocation.shell,
     });
     let buffer = "";
     let settled = false;

package/dist/bootstrap/mcp-config-merger.d.ts

@@ -13,7 +13,7 @@ import { LAUNCHER_PACKAGE_SPEC } from "@jam-mcp/launcher";
 export { LAUNCHER_PACKAGE_SPEC };
 export declare const JAM_MCP_ENTRY: {
     readonly command: "npx";
-    readonly args: readonly ["--yes", "@jam-mcp/launcher@1.4.2", "serve"];
+    readonly args: readonly ["--yes", "@jam-mcp/launcher@1.4.3", "serve"];
 };
 /**
  * Recognise wiring from before the launcher existed: a hard-coded `node` path

package/dist/bootstrap/migration-target.js

@@ -1,13 +1,16 @@
 import { spawnSync } from "node:child_process";
+import { shellInvocation } from "./shell-command.js";
 import { LAUNCHER_PACKAGE_SPEC } from "./mcp-config-merger.js";
 import { computeSetupPlan } from "./setup-plan.js";
 const PROBE_TIMEOUT_MS = 10_000;
 function runNpm(command, args) {
-    const result = spawnSync(command, args, {
+    // npm on Windows is a shell script, not an executable; shellInvocation
+    // joins the validated argv because an args array plus shell:true is DEP0190.
+    const invocation = shellInvocation(command, args);
+    const result = spawnSync(invocation.command, invocation.args, {
         encoding: "utf8",
         timeout: PROBE_TIMEOUT_MS,
-        // npm on Windows is a shell script, not an executable.
-        shell: process.platform === "win32",
+        shell: invocation.shell,
     });
     return {
         status: result.status,

package/dist/bootstrap/shell-command.d.ts

@@ -0,0 +1,36 @@
+/**
+ * How to hand an npm-shim CLI to spawnSync without tripping DEP0190.
+ *
+ * npm-installed CLIs (`claude`, `codex`, `npm`, `npx`, `jam`) are `.cmd`
+ * shims on Windows, and Node only runs those through a shell. But passing an
+ * args ARRAY together with `shell: true` is deprecated (DEP0190): Node
+ * concatenates the arguments without escaping, so the array form is an
+ * illusion of safety. On Windows the argv is therefore joined into a single
+ * command line HERE, deliberately - and every token is validated bare first,
+ * so the join cannot become a quoting hazard. A token that would need cmd.exe
+ * quoting is refused outright rather than escaped: nothing JAM runs ever
+ * carries one, so meeting one means the input is not ours to guess about.
+ *
+ * On every other platform the array form without a shell is correct and
+ * unchanged.
+ */
+export type ShellInvocation = {
+    command: string;
+    args: string[];
+    shell: boolean;
+};
+export declare function shellInvocation(command: string, args: readonly string[], platform?: NodeJS.Platform): ShellInvocation;
+/**
+ * PATH with package-runner injections removed.
+ *
+ * `npx --yes @jam-mcp/bootstrap@X` prepends its cache's `node_modules/.bin`
+ * to PATH, and that directory contains a `jam` shim - so inside a bootstrap
+ * run, `jam` resolves even on a machine where nothing is installed. Measuring
+ * "does this machine have a persistent jam" through that PATH answered yes on
+ * every fresh machine, and setup then registered a bare `jam serve` that died
+ * the moment npx's directory evaporated (the v1.4.2 fresh-install field
+ * failure). A persistent install lives in npm's global bin, never under a
+ * `node_modules` or `_npx` directory, so those entries are dropped before the
+ * measurement.
+ */
+export declare function stripPackageRunnerPath(pathValue: string, separator?: string): string;

package/dist/bootstrap/shell-command.js

@@ -0,0 +1,31 @@
+import { delimiter } from "node:path";
+/** Anything cmd.exe would re-interpret, plus whitespace and quotes. */
+const CMD_UNSAFE = /[\s&|<>^"'`;()]/;
+export function shellInvocation(command, args, platform = process.platform) {
+    if (platform !== "win32")
+        return { command, args: [...args], shell: false };
+    const unsafe = [command, ...args].find((token) => token === "" || CMD_UNSAFE.test(token));
+    if (unsafe !== undefined) {
+        throw new Error(`refusing to pass a token through cmd.exe unquoted: ${JSON.stringify(unsafe)}`);
+    }
+    return { command: [command, ...args].join(" "), args: [], shell: true };
+}
+/**
+ * PATH with package-runner injections removed.
+ *
+ * `npx --yes @jam-mcp/bootstrap@X` prepends its cache's `node_modules/.bin`
+ * to PATH, and that directory contains a `jam` shim - so inside a bootstrap
+ * run, `jam` resolves even on a machine where nothing is installed. Measuring
+ * "does this machine have a persistent jam" through that PATH answered yes on
+ * every fresh machine, and setup then registered a bare `jam serve` that died
+ * the moment npx's directory evaporated (the v1.4.2 fresh-install field
+ * failure). A persistent install lives in npm's global bin, never under a
+ * `node_modules` or `_npx` directory, so those entries are dropped before the
+ * measurement.
+ */
+export function stripPackageRunnerPath(pathValue, separator = delimiter) {
+    return pathValue
+        .split(separator)
+        .filter((entry) => !/[\\/]node_modules[\\/]|[\\/]_npx[\\/]/.test(`${entry}/`.replace(/[\\/]+$/, "/")))
+        .join(separator);
+}

package/dist/cli/agent-api.js

@@ -69,11 +69,23 @@ export async function setupApplyCommand(options = {}) {
         ...(options.home ? { home: options.home } : {}),
         ...(options.runHost ? { runHost: options.runHost } : {}),
     });
-    emitJson({ ...plan, status: applyStatus(plan), changesApplied: result.changesApplied });
+    emitJson({
+        ...plan,
+        status: applyStatus(plan, result.changesApplied),
+        changesApplied: result.changesApplied,
+    });
     return plan.requiresUserAction ? 1 : 0;
 }
-function applyStatus(plan) {
-    return plan.requiresUserAction ? "user_action_required" : "already_configured";
+/**
+ * The status of an apply, after it ran. "already_configured" means nothing
+ * was executed; when changes did run the answer is "applied" - reporting
+ * "already_configured" alongside changesApplied:true made the two fields
+ * contradict each other, and an agent could believe either one.
+ */
+function applyStatus(plan, changesApplied) {
+    if (plan.requiresUserAction)
+        return "user_action_required";
+    return changesApplied ? "applied" : "already_configured";
 }
 /**
  * `jam setup --agent` - one shot: detect, plan, apply what is safe, verify.

package/dist/cli/setup.js

@@ -1,4 +1,5 @@
 import { spawnSync } from "node:child_process";
+import { shellInvocation } from "../bootstrap/shell-command.js";
 import { existsSync } from "node:fs";
 import { join } from "node:path";
 import { runHealthGate } from "../bootstrap/boot-health-gate.js";
@@ -178,10 +179,13 @@ async function installAndBuild(root) {
         { name: "Build", args: ["run", "build"] },
     ]) {
         line(`\n> npm ${step.args.join(" ")}`);
-        const res = spawnSync("npm", step.args, {
+        // npm is a .cmd shim on Windows; shellInvocation joins the validated argv
+        // because an args array plus shell:true is DEP0190.
+        const invocation = shellInvocation("npm", step.args);
+        const res = spawnSync(invocation.command, invocation.args, {
             cwd: root,
             stdio: "inherit",
-            shell: process.platform === "win32",
+            shell: invocation.shell,
         });
         if (res.status !== 0) {
             line(`[FAIL] ${step.name}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jam-mcp/server",
-  "version": "1.4.2",
+  "version": "1.4.3",
   "description": "JAM (Jira Agent MCP) - agent-facing Jira access layer: MCP server, setup core, and CLI",
   "keywords": [
     "jira",
@@ -41,7 +41,7 @@
     "test:watch": "vitest"
   },
   "dependencies": {
-    "@jam-mcp/launcher": "1.4.2",
+    "@jam-mcp/launcher": "1.4.3",
     "@modelcontextprotocol/sdk": "^1.30.0",
     "yaml": "^2.9.0",
     "zod": "^4.4.3"