@jalvin/ui 2.0.36 → 2.0.38

package/dist/__tests__/children-signature.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=children-signature.test.d.ts.map

package/dist/__tests__/children-signature.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"children-signature.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/children-signature.test.ts"],"names":[],"mappings":""}

package/dist/__tests__/children-signature.test.js

@@ -0,0 +1,106 @@
+import { describe, it, expect } from "vitest";
+import * as fs from "fs";
+import * as path from "path";
+/**
+ * Tests to ensure all child-accepting UI components use consistent
+ * second-argument children signature (not props-style).
+ *
+ * This prevents runtime mismatches like the 2.0.35 incident where
+ * Scaffold/Card took children as second arg, but Column/Row read from props.
+ */
+describe("UI children signature consistency", () => {
+    // Components that accept children
+    const CHILD_COMPONENTS = [
+        "Scaffold",
+        "Card",
+        "Column",
+        "Row",
+        "Box",
+        "Button",
+        "IconButton",
+    ];
+    // Text is intentionally different (uses props.children and props.text)
+    const INTENTIONAL_EXCEPTIONS = ["Text"];
+    it("all child-accepting components use second-argument style in TypeScript", () => {
+        const srcDir = path.join(__dirname, "..");
+        const tsxFiles = [
+            path.join(srcDir, "surface.tsx"),
+            path.join(srcDir, "layout.tsx"),
+            path.join(srcDir, "button.tsx"),
+        ];
+        const content = tsxFiles
+            .map((f) => fs.readFileSync(f, "utf-8"))
+            .join("\n");
+        for (const component of CHILD_COMPONENTS) {
+            // Find the component function definition
+            const componentRegex = new RegExp(`export function ${component}\\([\\s\\S]*?\\):\\s*React\\.ReactElement`, "");
+            const match = content.match(componentRegex);
+            expect(match, `${component} function not found`).toBeTruthy();
+            const functionSig = match[0];
+            // Check: should have children as second parameter (after Props)
+            // Pattern: }: PropType, children?: React.ReactNode
+            // (handles multi-line with whitespace variations)
+            const hasSecondArgChildren = /:\s*\w+Props\s*,\s*children\?/s.test(functionSig);
+            expect(hasSecondArgChildren, `${component} should have children as second-argument, not in props`).toBe(true);
+            // Check: should NOT have children in props destructuring
+            // Pattern: { ..., children... }
+            const propsMatch = functionSig.match(/\{[\s\S]*?\}:\s*\w+Props/);
+            if (propsMatch) {
+                const propsBody = propsMatch[0];
+                expect(!propsBody.includes("children"), `${component} props should NOT include children field`).toBe(true);
+            }
+        }
+    });
+    it("interface props do not include children field", () => {
+        const srcDir = path.join(__dirname, "..");
+        const tsxFiles = [
+            path.join(srcDir, "surface.tsx"),
+            path.join(srcDir, "layout.tsx"),
+            path.join(srcDir, "button.tsx"),
+        ];
+        const content = tsxFiles
+            .map((f) => fs.readFileSync(f, "utf-8"))
+            .join("\n");
+        // Get interface definitions for components with children
+        for (const component of CHILD_COMPONENTS) {
+            // Look for interfaces like ScaffoldProps, CardProps, etc.
+            const interfaceName = `${component}Props`;
+            const interfacePattern = new RegExp(`export interface ${interfaceName}\\s*\\{[^}]*?\\}`, "s");
+            const match = content.match(interfacePattern);
+            if (match) {
+                const interfaceBody = match[0];
+                // For non-exception components, children should NOT be in the interface
+                if (!INTENTIONAL_EXCEPTIONS.includes(component)) {
+                    expect(!interfaceBody.includes("children"), `${interfaceName} should NOT include children field (children are second-argument)`).toBe(true);
+                }
+            }
+        }
+    });
+    it("component implementations spread children correctly as second arg", () => {
+        const srcDir = path.join(__dirname, "..");
+        const layoutContent = fs.readFileSync(path.join(srcDir, "layout.tsx"), "utf-8");
+        // Check that Column/Row/Box all use ...(children ?? []) pattern
+        for (const component of ["Column", "Row", "Box"]) {
+            // Should have pattern: ...(children ?? [])
+            expect(layoutContent.includes(`...(children ?? [])`), `${component} should spread children with ...(children ?? []) pattern`).toBe(true);
+        }
+    });
+    it("compiled dist files maintain second-argument children signature", () => {
+        const distDir = path.join(__dirname, "../../dist");
+        // Check if dist exists (it will after build)
+        if (!fs.existsSync(distDir)) {
+            console.warn("dist/ not found; skipping compiled output check");
+            return;
+        }
+        const jsFiles = [
+            path.join(distDir, "surface.js"),
+            path.join(distDir, "layout.js"),
+            path.join(distDir, "button.js"),
+        ].filter((f) => fs.existsSync(f));
+        const content = jsFiles.map((f) => fs.readFileSync(f, "utf-8")).join("\n");
+        // Check that second-argument children patterns exist in compiled code
+        // Pattern: }, children) or }, children =
+        expect(/},\s*children\s*[),=]/m.test(content), "Compiled code should have children as second parameter").toBe(true);
+    });
+});
+//# sourceMappingURL=children-signature.test.js.map

package/dist/__tests__/children-signature.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"children-signature.test.js","sourceRoot":"","sources":["../../src/__tests__/children-signature.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,KAAK,EAAE,MAAM,IAAI,CAAC;AACzB,OAAO,KAAK,IAAI,MAAM,MAAM,CAAC;AAE7B;;;;;;GAMG;AAEH,QAAQ,CAAC,mCAAmC,EAAE,GAAG,EAAE;IACjD,kCAAkC;IAClC,MAAM,gBAAgB,GAAG;QACvB,UAAU;QACV,MAAM;QACN,QAAQ;QACR,KAAK;QACL,KAAK;QACL,QAAQ;QACR,YAAY;KACb,CAAC;IAEF,uEAAuE;IACvE,MAAM,sBAAsB,GAAG,CAAC,MAAM,CAAC,CAAC;IAExC,EAAE,CAAC,wEAAwE,EAAE,GAAG,EAAE;QAChF,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;QAC1C,MAAM,QAAQ,GAAG;YACf,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,aAAa,CAAC;YAChC,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,YAAY,CAAC;YAC/B,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,YAAY,CAAC;SAChC,CAAC;QAEF,MAAM,OAAO,GAAG,QAAQ;aACrB,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,EAAE,OAAO,CAAC,CAAC;aACvC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEd,KAAK,MAAM,SAAS,IAAI,gBAAgB,EAAE,CAAC;YACzC,yCAAyC;YACzC,MAAM,cAAc,GAAG,IAAI,MAAM,CAC/B,mBAAmB,SAAS,2CAA2C,EACvE,EAAE,CACH,CAAC;YACF,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC;YAC5C,MAAM,CAAC,KAAK,EAAE,GAAG,SAAS,qBAAqB,CAAC,CAAC,UAAU,EAAE,CAAC;YAE9D,MAAM,WAAW,GAAG,KAAM,CAAC,CAAC,CAAC,CAAC;YAE9B,gEAAgE;YAChE,mDAAmD;YACnD,kDAAkD;YAClD,MAAM,oBAAoB,GACxB,gCAAgC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YACrD,MAAM,CACJ,oBAAoB,EACpB,GAAG,SAAS,wDAAwD,CACrE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAEb,yDAAyD;YACzD,gCAAgC;YAChC,MAAM,UAAU,GAAG,WAAW,CAAC,KAAK,CAAC,0BAA0B,CAAC,CAAC;YACjE,IAAI,UAAU,EAAE,CAAC;gBACf,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;gBAChC,MAAM,CACJ,CAAC,SAAS,CAAC,QAAQ,CAAC,UAAU,CAAC,EAC/B,GAAG,SAAS,0CAA0C,CACvD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACf,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;QAC1C,MAAM,QAAQ,GAAG;YACf,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,aAAa,CAAC;YAChC,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,YAAY,CAAC;YAC/B,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,YAAY,CAAC;SAChC,CAAC;QAEF,MAAM,OAAO,GAAG,QAAQ;aACrB,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,EAAE,OAAO,CAAC,CAAC;aACvC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEd,yDAAyD;QACzD,KAAK,MAAM,SAAS,IAAI,gBAAgB,EAAE,CAAC;YACzC,0DAA0D;YAC1D,MAAM,aAAa,GAAG,GAAG,SAAS,OAAO,CAAC;YAC1C,MAAM,gBAAgB,GAAG,IAAI,MAAM,CACjC,oBAAoB,aAAa,kBAAkB,EACnD,GAAG,CACJ,CAAC;YACF,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;YAE9C,IAAI,KAAK,EAAE,CAAC;gBACV,MAAM,aAAa,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;gBAE/B,wEAAwE;gBACxE,IAAI,CAAC,sBAAsB,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;oBAChD,MAAM,CACJ,CAAC,aAAa,CAAC,QAAQ,CAAC,UAAU,CAAC,EACnC,GAAG,aAAa,mEAAmE,CACpF,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBACf,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mEAAmE,EAAE,GAAG,EAAE;QAC3E,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;QAC1C,MAAM,aAAa,GAAG,EAAE,CAAC,YAAY,CACnC,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,YAAY,CAAC,EAC/B,OAAO,CACR,CAAC;QAEF,gEAAgE;QAChE,KAAK,MAAM,SAAS,IAAI,CAAC,QAAQ,EAAE,KAAK,EAAE,KAAK,CAAC,EAAE,CAAC;YACjD,2CAA2C;YAC3C,MAAM,CACJ,aAAa,CAAC,QAAQ,CAAC,qBAAqB,CAAC,EAC7C,GAAG,SAAS,0DAA0D,CACvE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACf,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QACzE,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;QAEnD,6CAA6C;QAC7C,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,IAAI,CAAC,iDAAiD,CAAC,CAAC;YAChE,OAAO;QACT,CAAC;QAED,MAAM,OAAO,GAAG;YACd,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,YAAY,CAAC;YAChC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,WAAW,CAAC;YAC/B,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,WAAW,CAAC;SAChC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC;QAElC,MAAM,OAAO,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,EAAE,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAE3E,sEAAsE;QACtE,yCAAyC;QACzC,MAAM,CACJ,wBAAwB,CAAC,IAAI,CAAC,OAAO,CAAC,EACtC,wDAAwD,CACzD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACf,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jalvin/ui",
-  "version": "2.0.36",
+  "version": "2.0.38",
   "description": "Jalvin UI — Compose-style component library (Column, Row, Box, Button, Text, …)",
   "type": "module",
   "main": "dist/index.js",
@@ -21,7 +21,7 @@
     "react": ">=18.0.0"
   },
   "devDependencies": {
-    "@jalvin/runtime": "^2.0.36",
+    "@jalvin/runtime": "^2.0.38",
     "@testing-library/jest-dom": "^6.9.1",
     "@testing-library/react": "^16.3.2",
     "@types/node": "^20.0.0",