@jahia/agentic 0.5.0 → 0.5.1

package/dist/kiro/.kiro/skills/jahia-review-code/SKILL.md

@@ -0,0 +1,228 @@
+---
+name: jahia-review-code
+description: Reviews a Jahia JavaScript module for generic and Jahia-specific best practices. Scans CND definitions, TypeScript views, and page templates. Reports issues in order of importance with fix suggestions. Covers 8 critical checks, 9 warnings, and 10 suggestions.
+allowed-tools: Bash, Read
+---
+
+# Skill: jahia-review-code
+
+Reviews a Jahia JavaScript module for correctness and best practices. Scans real files, reports issues in order of severity (🔴 Critical → 🟡 Warning → 🔵 Suggestion), and proposes fixes.
+
+---
+
+## Step 1 — Locate the module
+
+Find the module root: look for `package.json` with `@jahia/javascript-modules-library`. Determine the `src/` directory.
+
+```bash
+find . -name "package.json" -not -path "*/node_modules/*" | xargs grep -l "javascript-modules-library" 2>/dev/null | head -1
+```
+
+---
+
+## Step 2 — Collect files to review
+
+```bash
+find src/ -name "definition.cnd" | sort
+find src/ -name "*.server.tsx" | sort
+find src/ -name "*.client.tsx" | sort
+find src/ -name "types.ts" | sort
+find src/templates/ -name "*.server.tsx" | sort
+cat settings/definitions.cnd
+```
+
+Read ALL collected files before starting the review.
+
+---
+
+## Step 3 — Run checks in order of severity
+
+### 🔴 CRITICAL — Will cause broken editor UX, broken pages, or security issues
+
+**C1 — `jmix:droppableContent` used directly**
+Check: any CND type (not mixin declarations in settings/definitions.cnd) extending `jmix:droppableContent` directly.
+Fix: extend the module's custom component mixin (e.g. `namespacemix:component`) instead.
+
+**C2 — `fullPage` view uses `componentType: "template"`**
+Check: any `name: "fullPage"` view that also has `componentType: "template"`.
+Fix: change to `componentType: "view"`. The `src/templates/MainResource/default.server.tsx` template already routes `jmix:mainResource` nodes to the `fullPage` view.
+
+**C3 — `j:linknode` or `j:url` explicitly declared in CND**
+Check: any CND type that explicitly declares `j:linknode` or `j:url` fields alongside `choicelist[linkTypeInitializer]`.
+Fix: remove those two fields from the CND. They are injected automatically by Jahia's mixins at runtime. Only declare `- j:linkType (string, choicelist[linkTypeInitializer])`. The fields remain available in `types.ts` and in the view.
+
+**C4 — `j:linkType` used as a URL in a view**
+Check: any `.server.tsx` or `.client.tsx` file that uses `props["j:linkType"]` or `j:linkType` directly as an `href`.
+Fix: use a `switch (props["j:linkType"])` with `buildNodeUrl(props["j:linknode"])` for internal and `props["j:url"]` for external.
+
+**C5 — Weakreference node properties read directly in a view (cache issue)**
+Check: views that access `.getPropertyAsString()`, `.getProperty(...)`, or property destructuring from a weakreference prop (other than `buildNodeUrl`).
+Fix: render the referenced node via `<Render node={refNode} view="..." />` to get proper cache invalidation.
+
+**C6 — Client component imports server-only APIs**
+Check: any `.client.tsx` file that imports from `@jahia/javascript-modules-library` (except `Island` which is re-exported).
+Fix: move server-side logic to the `.server.tsx` wrapper and pass results as serializable props to the Island.
+
+**C7 — Cache explicitly disabled (`cache.expiration="0"`)**
+Check: any `jahiaComponent` call with `properties: { "cache.expiration": "0" }`.
+Fix: never set expiration to 0. If truly fresh data is needed, use a small value like `"5"` (5 seconds) to still protect under load.
+
+**C8 — Generic area type used for every Area**
+Check: page templates where every `<Area>` uses the same generic area type (e.g. `nodeType="namespace:pageArea"` everywhere). This means editors see ALL `pageComponent` types as droppable options in every area — a hero section will appear as an option in a feature card grid.
+Fix: create **one typed area node per section** in `settings/definitions.cnd`, each with a tight child constraint:
+```cnd
+[namespace:heroArea] > jnt:content, jmix:list, jmix:hiddenType orderable
+ + * (namespace:heroSection)
+
+[namespace:featuresArea] > jnt:content, jmix:list, jmix:hiddenType orderable
+ + * (namespace:featureCard)
+```
+Only use a generic `pageArea` for flexible areas (e.g. footer) where any component is valid.
+
+---
+
+### 🟡 WARNING — Will likely cause editor confusion, stale content, or runtime errors
+
+**W1 — User-facing string fields without `i18n`**
+Check: CND string/textarea/richtext properties that don't have `i18n` (exclude system properties like `j:linkType`, `j:url`, non-user-facing fields).
+Fix: add `i18n` to all user-visible text properties.
+
+**W2 — `jmix:mainResource` on non-content types**
+Check: CND types that have `jmix:mainResource` but no richtext body or no obvious "detail page" use case (e.g. a visual composition type like a card or hero).
+Fix: only use `jmix:mainResource` for content that genuinely needs both a listing card AND a full-page detail view.
+
+**W3 — Structural container types missing `jmix:hiddenType`**
+Check: CND types that have no `namespacemix:component` mixin (so they can't be dropped as components) but also don't have `jmix:hiddenType` — editors would never see them but they don't show up with a clear "hidden" intent.
+Fix: add `jmix:hiddenType` to structural/container types. Do NOT use `jmix:studioOnly` — it can interfere with area rendering.
+
+**W4 — Props not typed as optional (`?:`) / not guarded in views**
+Check: (a) `types.ts` props typed as required (`title: string`) — all props must use `?:` because Jahia does not guarantee values are present at render time. (b) Views that use props without null/undefined guards, especially `buildNodeUrl(prop)` — passing `undefined` throws `"Expected a node in buildNodeUrl, received undefined"`.
+Fix: use `?:` for all props in `types.ts`. Add conditional rendering (`{prop && <span>{prop}</span>}`) and guard node URLs (`prop ? { backgroundImage: \`url(${buildNodeUrl(prop)})\` } : undefined`).
+
+**W5 — `weakreference multiple` not null-filtered before `.map()`**
+Check: views mapping over a `weakreference multiple` prop without `.filter(x => x !== null)`.
+Fix: `items?.filter(item => item !== null).map(...)`.
+
+**W6 — Cache not configured for views using external/dynamic data**
+Check: views that call external functions, use `Date.now()`, or fetch data, without `properties: { "cache.expiration": "..." }`.
+Fix: add `cache.expiration` to the `jahiaComponent` properties.
+
+**W7 — Missing `import.xml` or no homepage defined**
+Check: look for `import.xml` at the module root. If absent or if it doesn't contain `j:isHomePage="true"`, editors won't have a default homepage.
+Fix: add an `import.xml` with a homepage node (`j:isHomePage="true"`). Also add "Offline pages/Models", "Offline pages/Drafts", "Offline pages/Archive" folders with `jmix:systemNameReadonly` and `jmix:nolive` mixins. Add content folders with `jmix:contributeMode` restrictions where appropriate.
+
+**W8 — Node type extends something other than `jnt:content`**
+Check: CND types that extend anything other than `jnt:content`, `jnt:page`, `jmix:*`, or standard Jahia base types.
+Fix: extend only `jnt:content` (or `jnt:page` for page types). To add fields to a type you don't control, use a mixin with `extends=<targetType>`. Unusual inheritance chains break edition interfaces in unpredictable ways.
+
+**W9 — Hardcoded link URLs in views**
+Check: any `.server.tsx`, `.client.tsx`, or template file containing a literal `href="http`, `href="/"`, or `href="/en/` (except in edit-mode chrome helpers). Also flag plain string `src="http` for non-bundled assets. Also flag any content data with `j:linkType: "external"` pointing to a path that looks like an internal Jahia URL (e.g. `/sites/`, `/cms/`, `/en/`).
+Fix: **All navigable URLs must come from contributed content.** Use `j:linkType`/`j:linknode`/`j:url` props for editorial links, `buildNodeUrl(node)` for JCR node links.
+🚫 **NEVER use `j:linkType: "external"` to link to an internal Jahia page** — use `"internal"` + `j:linknode`. An external URL pointing internally breaks on environment changes, language switches, live/preview workspace toggling, and vanity URL rewrites. If no target page exists yet, omit the link; do not substitute an external workaround.
+
+---
+
+### 🔵 SUGGESTION — Quality improvements
+
+**S1 — Non-semantic HTML**
+Check: views that use `<div>` where `<article>`, `<section>`, `<nav>`, `<header>`, or `<footer>` would be more appropriate.
+Fix: use semantic HTML for better accessibility and SEO.
+
+**S2 — Images without meaningful alt text**
+Check: `<img>` tags with `alt=""` or no `alt` attribute (unless there's a comment saying it's decorative).
+Fix: add descriptive alt text. Decorative images should have `alt=""` with a comment.
+
+**S3 — Accessibility violations (axe-core audit)**
+Check: run `/jahia-dev-accessibility` against all live pages. A clean module has zero `critical` or `serious` violations.
+Common issues in Jahia modules:
+- `color-contrast`: hardcoded colours with insufficient contrast ratio — check with https://webaim.org/resources/contrastchecker/
+- `image-alt`: `<img>` missing a meaningful `alt` prop sourced from CND
+- `button-name`: icon-only `<button>` or `<a>` without `aria-label`
+- `landmark-one-main`: page template missing a `<main>` wrapper
+- `page-has-heading-one`: no `<h1>` rendered on any page
+- `heading-order`: skipped heading levels between components (e.g. h1 → h3)
+- `html-has-lang`: template not setting `lang` via `useServerContext().currentLanguage`
+- `focus-visible` suppressed: global `* { outline: none }` in CSS kills keyboard navigation
+
+Fix: identify each violating component by matching the axe target selector to a `.server.tsx` file, apply the fix, rebuild, and re-run the audit.
+
+**S4 — Types using `any`**
+Check: `types.ts` files or view files using TypeScript `any`.
+Fix: use `JCRNodeWrapper` for node references, `string` / `number` / `boolean` for primitives.
+
+**S5 — Bare `<Area>` without a `nodeType`**
+Check: page templates using `<Area name="..." />` without a `nodeType` prop.
+Fix: create a custom area type with `jmix:list`, `jmix:hiddenType`, and `orderable`, and reference it with `nodeType="namespace:areaType"`.
+
+**S6 — `mix:title` inherited but `jcr:title` not in `types.ts`**
+Check: CND types that extend `mix:title` but whose `types.ts` doesn't include `"jcr:title": string`.
+Fix: add `"jcr:title"?: string` to the Props type.
+
+**S7 — Missing `.properties` file entries or icon for new content types**
+Check: for each node type found in `definition.cnd` files, verify that `settings/resources/<module>.properties` has a label (`cndNamespace_typeName=...`) and a corresponding icon exists at `settings/content-types-icons/<cndNamespace>_<typeName>.png`. The prefix must be the CND namespace (e.g. `ns_heroSection.png`), **not** the module name with hyphens (e.g. `my-module_heroSection.png` is wrong — the archetype generates wrong names that must be manually corrected).
+Fix: add labels (and optionally `ui.tooltip` for fields) to the properties files. Rename any icons that use the module name with hyphens to use the CND namespace. Create a 32×32 PNG icon (free source: [flaticon.com](https://www.flaticon.com/)). Without these, editors see raw technical names and blank icon squares in the content picker.
+
+**S8 — Hardcoded user-visible strings in views**
+Check: `.server.tsx` / `.client.tsx` files with JSX string literals that are not coming from props or i18n functions (e.g. `<p>Learn more</p>`, `<button>Submit</button>`).
+Fix: move UI labels to `settings/locales/en.json` and `fr.json` and resolve them with `useTranslation()`. Hardcoded strings break multilingual sites.
+
+**S9 — Content list queries not using `ISDESCENDANTNODE` (non-recursive)**
+Check: JCR-SQL2 queries using `jcr:path LIKE '/sites/.../content/%'` or a fixed path to limit results, instead of `ISDESCENDANTNODE(node, '/sites/.../content')`.
+Fix: use `ISDESCENDANTNODE` to ensure queries work correctly even if editors reorganize content into sub-folders.
+
+**S10 — No escape hatch when using a custom component mixin**
+Check: a custom section type that restricts children to a custom mixin (e.g. `+ * (namespacemix:component)`) but the module provides no "content stack" escape hatch type that itself accepts `jmix:droppableContent`.
+Fix: add a `namespace:contentStack > jnt:content, namespacemix:component + * (jmix:droppableContent)` type so power editors can still add arbitrary content when needed.
+
+**S11 — Scaffold/boilerplate components still present**
+Check: components under `src/components/Hello/` (or any other archetype-generated boilerplate) that are no longer referenced in `settings/import.xml` and no longer used by any view or page template.
+```bash
+# Check if Hello components are still referenced anywhere
+grep -r "helloWorld\|helloCard\|Hello/" src/templates/ settings/ --include="*.tsx" --include="*.xml" --include="*.cnd"
+```
+Fix: once `import.xml` no longer provisions Hello World content and no template uses them, delete the entire `src/components/Hello/` directory, remove their entries from `.properties` files, and delete their icons from `settings/content-types-icons/`. Keeping dead components inflates the content picker and confuses editors.
+
+---
+
+## Step 4 — Report results
+
+Format the output as:
+
+```
+## Jahia Module Review — <module name>
+
+### 🔴 Critical (N issues)
+[C1] src/components/Hero/Section/definition.cnd — `jmix:droppableContent` used directly
+     Fix: extend `namespacemix:component` instead
+
+### 🟡 Warnings (N issues)
+...
+
+### 🔵 Suggestions (N issues)
+...
+
+### ✅ Summary
+- N critical issues (must fix before shipping)
+- N warnings (fix before sharing with editors)
+- N suggestions (improve when time allows)
+```
+
+If no issues found in a category, print `✅ None`.
+
+---
+
+## Step 5 — Ask to fix
+
+After the report, ask: **"Would you like me to fix any of these issues?"**
+
+If yes, fix them — use the guidance from the relevant skill (`jahia-cnd-author`, `jahia-dev-create-view`) and run `yarn build && yarn jahia-deploy` to push changes.
+
+---
+
+## References
+
+- Native Jahia mixins & node types: https://github.com/Jahia/jahia/tree/master/war/src/main/webapp/WEB-INF/etc/repository/nodetypes
+- Integration best practices: https://github.com/Jahia/gautier-braindump/blob/main/articles/integration-best-practices/README.md
+- Developer training: https://github.com/Jahia/developer-training/blob/main/js-training/slides.md
+
+> If a check result is uncertain (e.g. "does this mixin exist?"), fetch the nodetypes directory above before reporting.

package/dist/kiro/.kiro/skills/jahia-review-site/SKILL.md

@@ -0,0 +1,52 @@
+---
+name: jahia-review-site
+description: Scores live pages for accessibility and SEO.
+allowed-tools: Bash, Read, Write, Edit
+---
+
+# Skill: jahia-review-site
+
+Reads URLs from `pages-to-review.json`, runs automated a11y and SEO checks, and — only if all checks pass — writes `pages.json`. Exits non-zero without writing `pages.json` if any violation is found.
+
+**A11y:** axe-core full ruleset (WCAG + best-practice) — any violation fails.
+
+**SEO:** Lighthouse SEO category — any failing audit fails. Violations reported by audit ID (e.g. `document-title`, `meta-description`, `hreflang`, `is-crawlable`, `link-text`, `image-alt`).
+
+---
+
+## Step 1 — Ensure tooling is installed
+
+```bash
+node -e "require('@axe-core/playwright'); require('playwright')" 2>/dev/null || \
+  npm install --no-save @axe-core/playwright playwright && npx playwright install chromium --with-deps
+```
+
+---
+
+## Step 2 — Run the review
+
+```bash
+SCRIPT=$(find .claude .agents -name "review-pages.mjs" 2>/dev/null | head -1)
+node "$SCRIPT" 2>&1 | tee /tmp/site-review.txt
+```
+
+---
+
+## Step 3 — Interpret and fix
+
+The script exits 1 if any page has any a11y violation or any failing Lighthouse SEO audit.
+
+After fixing, redeploy and re-run:
+
+```bash
+yarn build && yarn jahia-deploy
+node "$SCRIPT"
+```
+
+Iterate until the script exits 0 and `pages.json` is written.
+
+---
+
+## Validation checklist
+- [ ] Script exits 0 (zero a11y violations, zero failing SEO audits)
+- [ ] `pages.json` exists (created by the script on pass)

package/dist/kiro/.kiro/skills/jahia-review-site/scripts/review-pages.mjs

@@ -0,0 +1,74 @@
+#!/usr/bin/env node
+// Reads URLs from pages-to-review.json, runs a11y (axe-core) + SEO (Lighthouse) checks.
+// On pass: writes pages.json and exits 0. On fail: exits 1 without writing pages.json.
+import { chromium } from "playwright";
+import { AxeBuilder } from "@axe-core/playwright";
+import lighthouse from "lighthouse";
+import { readFileSync, writeFileSync } from "fs";
+
+const SCORED_MODES = new Set(["binary", "numeric"]);
+
+const draft = readFileSync("pages-to-review.json", "utf-8");
+const urls = JSON.parse(draft);
+const port = 9222;
+const browser = await chromium.launch({
+  args: ["--no-sandbox", `--remote-debugging-port=${port}`],
+});
+const context = await browser.newContext();
+const page = await context.newPage();
+
+const results = [];
+
+for (const url of urls) {
+  process.stdout.write(`\nChecking ${url} … `);
+  await page.goto(url, { waitUntil: "networkidle", timeout: 30_000 });
+
+  // A11y
+  const axe = await new AxeBuilder({ page }).analyze();
+
+  // SEO — Lighthouse reuses the already-open browser via the debug port
+  const lhr = (await lighthouse(url, { port, output: "json", onlyCategories: ["seo"] }))?.lhr;
+  const seoViolations = lhr
+    ? Object.values(lhr.audits).filter(
+        a => SCORED_MODES.has(a.scoreDisplayMode) && a.score !== null && a.score < 1,
+      )
+    : [];
+
+  process.stdout.write(`a11y=${axe.violations.length} violation(s) seo=${seoViolations.length} violation(s)\n`);
+  results.push({ url, violations: axe.violations, seoViolations });
+}
+
+await browser.close();
+
+// ── Report ──────────────────────────────────────────────────────────────────
+let failed = false;
+
+for (const r of results) {
+  const pageOk = r.violations.length === 0 && r.seoViolations.length === 0;
+  if (!pageOk) failed = true;
+
+  console.log(`\n${"─".repeat(70)}`);
+  console.log(`${pageOk ? "✅" : "❌"} ${r.url}`);
+
+  for (const v of r.violations) {
+    console.log(`   ❌ A11y [${v.id}] — ${v.description} (${v.nodes.length} node${v.nodes.length !== 1 ? "s" : ""})`);
+    for (const node of v.nodes.slice(0, 3)) {
+      console.log(`        ${node.html.slice(0, 100)}`);
+    }
+  }
+
+  for (const a of r.seoViolations) {
+    console.log(`   ❌ SEO  [${a.id}] — ${a.title}`);
+    if (a.description) console.log(`        ${a.description.slice(0, 120)}`);
+  }
+}
+
+console.log(`\n${"═".repeat(70)}`);
+if (failed) {
+  console.log("\n❌ FAIL — fix the issues above, redeploy, and re-run.");
+  process.exit(1);
+} else {
+  writeFileSync("pages.json", draft);
+  console.log("\n✅ PASS — pages.json written.");
+  process.exit(0);
+}

package/dist/kiro/.kiro/steering/jahia.md

@@ -22,7 +22,7 @@ You are helping develop a **Jahia JavaScript Module** — a React-based template
 7a. **`yarn` and `npx` must be run from the module root** — the module is a standalone project, not part of a monorepo. Running `yarn` from a parent directory fails with a workspace boundary error. Always `cd` to the module directory first.
 7b. **Use `grep`, not `ugrep`** — `ugrep` is not available on all systems and does not support the same regex syntax. Use `grep -rn` for plain text, `grep -rn -E` for extended regex, or `grep -rn -P` for Perl-compatible patterns (e.g. lookaheads). Never use `ugrep` or `(?m)` flags.
 8. **Build accessible HTML from the start** — every view must use semantic HTML (`<main>`, `<header>`, `<nav>`, `<footer>`, `<section>`, `<article>`), include exactly one `<h1>` per page (in the template from `jcr:title` — never inside a component), use a strict heading hierarchy (h1 in template → h2 in components → h3 for sub-items), add `alt` text to every `<img>` with a meaningful fallback (`imageAlt || title || 'Image'` — never empty string), ensure sufficient colour contrast (≥ 4.5:1 for body text), include a skip link at the top of the template, and never leave a landmark (`<nav>`, `<footer>`) empty.
-9. **Review quality after each deploy** — after deploying and populating content, run `/jahia-dev-site-review` to get a scored a11y + SEO report. Fix any critical/serious violations before moving on. Do not write `pages.json` until the review passes.
+9. **Review quality after each deploy** — after deploying and populating content, write the live page URLs to `pages-to-review.json`, then invoke `/jahia-review` to run a full code and site review via subagents. Fix all reported violations and iterate until `/jahia-review-site` exits 0. The review script writes `pages.json` on pass — never write it manually.
 10. **Deploy iteratively** — deploy after each component with `yarn build && yarn jahia-deploy`, verify it renders, then move to the next. Don't accumulate components before deploying; a broken component is easier to diagnose in isolation.
 11. **Collocate everything per component** — each component lives in `src/components/<Category>/<Name>/` containing its `definition.cnd`, `default.server.tsx`, `component.module.css`, and `types.ts`. Never centralize content types in `settings/definitions.cnd` — that file holds only namespace declarations and the module base mixin.
 12. **Always build a page template first** — every website needs a root template at `src/templates/<ModuleName>Template/default.server.tsx`. It must include: a skip link, a `<nav>` built inline from children of the site's home node using `getChildNodes(renderContext.getSite().getNode('home'), -1, 0, n => n.isNodeType('jnt:page'))` (pages live under `home`, not directly under the site), a `<main id="main-content">` with `<h1>{title}</h1>` and Areas, and a `<footer>` that is never empty. The `<title>` tag must be `{title} | {siteName}` — never set `jcr:title` to the full `Page | Site` string; `jcr:title` is always just the short page name (e.g. "Car Insurance"). Build and deploy before any page-specific components.

package/dist/kiro/AGENTS.md

@@ -1,6 +1,6 @@
 # AGENTS.md
 <!-- Generated by APM CLI from distributed .apm/ primitives -->
-<!-- Build ID: f8784ff296c9 -->
+<!-- Build ID: 6604f2c9e98d -->
 <!-- APM Version: 0.21.0 -->
 
 ## Global Instructions
@@ -25,7 +25,7 @@ You are helping develop a **Jahia JavaScript Module** — a React-based template
 7a. **`yarn` and `npx` must be run from the module root** — the module is a standalone project, not part of a monorepo. Running `yarn` from a parent directory fails with a workspace boundary error. Always `cd` to the module directory first.
 7b. **Use `grep`, not `ugrep`** — `ugrep` is not available on all systems and does not support the same regex syntax. Use `grep -rn` for plain text, `grep -rn -E` for extended regex, or `grep -rn -P` for Perl-compatible patterns (e.g. lookaheads). Never use `ugrep` or `(?m)` flags.
 8. **Build accessible HTML from the start** — every view must use semantic HTML (`<main>`, `<header>`, `<nav>`, `<footer>`, `<section>`, `<article>`), include exactly one `<h1>` per page (in the template from `jcr:title` — never inside a component), use a strict heading hierarchy (h1 in template → h2 in components → h3 for sub-items), add `alt` text to every `<img>` with a meaningful fallback (`imageAlt || title || 'Image'` — never empty string), ensure sufficient colour contrast (≥ 4.5:1 for body text), include a skip link at the top of the template, and never leave a landmark (`<nav>`, `<footer>`) empty.
-9. **Review quality after each deploy** — after deploying and populating content, run `/jahia-dev-site-review` to get a scored a11y + SEO report. Fix any critical/serious violations before moving on. Do not write `pages.json` until the review passes.
+9. **Review quality after each deploy** — after deploying and populating content, write the live page URLs to `pages-to-review.json`, then invoke `/jahia-review` to run a full code and site review via subagents. Fix all reported violations and iterate until `/jahia-review-site` exits 0. The review script writes `pages.json` on pass — never write it manually.
 10. **Deploy iteratively** — deploy after each component with `yarn build && yarn jahia-deploy`, verify it renders, then move to the next. Don't accumulate components before deploying; a broken component is easier to diagnose in isolation.
 11. **Collocate everything per component** — each component lives in `src/components/<Category>/<Name>/` containing its `definition.cnd`, `default.server.tsx`, `component.module.css`, and `types.ts`. Never centralize content types in `settings/definitions.cnd` — that file holds only namespace declarations and the module base mixin.
 12. **Always build a page template first** — every website needs a root template at `src/templates/<ModuleName>Template/default.server.tsx`. It must include: a skip link, a `<nav>` built inline from children of the site's home node using `getChildNodes(renderContext.getSite().getNode('home'), -1, 0, n => n.isNodeType('jnt:page'))` (pages live under `home`, not directly under the site), a `<main id="main-content">` with `<h1>{title}</h1>` and Areas, and a `<footer>` that is never empty. The `<title>` tag must be `{title} | {siteName}` — never set `jcr:title` to the full `Page | Site` string; `jcr:title` is always just the short page name (e.g. "Car Insurance"). Build and deploy before any page-specific components.

package/dist/opencode/.agents/skills/jahia-dev-build-component/SKILL.md

@@ -1,13 +1,13 @@
 ---
 name: jahia-dev-build-component
-description: Builds a complete Jahia component (content type + view + CSS) from a description. Meta-skill that orchestrates jahia-dev-define-content-type and jahia-dev-create-view. Use when asked to build a new UI component or section.
+description: Builds a complete Jahia component (content type + view + CSS) from a description. Meta-skill that orchestrates jahia-cnd-author and jahia-dev-create-view. Use when asked to build a new UI component or section.
 ---
 
 ## Overview
 
 This meta-skill builds a complete **Single Directory Component (SDC)** — the standard Jahia component pattern — by sequencing two atomic skills:
 
-1. `jahia-dev-define-content-type` → create the CND definition and `types.ts`
+1. `jahia-cnd-author` → create the CND definition and `types.ts`
 2. `jahia-dev-create-view` → implement the React view and CSS Module
 
 Run these steps in order. Do not skip to the view before the content type is defined.

package/dist/opencode/.agents/skills/jahia-dev-create-view/SKILL.md

@@ -144,7 +144,7 @@ Always import `Props` from `./types.js` (not `./types.ts` — use `.js` extensio
 import type { Props } from "./types.js";
 ```
 
-If `types.ts` doesn't exist yet, create it first (see `jahia-dev-define-content-type` skill).
+If `types.ts` doesn't exist yet, create it first (see `jahia-cnd-author` skill).
 
 ---
 
@@ -294,7 +294,7 @@ jahiaComponent(
 );
 ```
 
-The `Props` type must be a discriminated union (see `jahia-dev-define-content-type` skill).
+The `Props` type must be a discriminated union (see `jahia-cnd-author` skill).
 
 ### Cache properties — controlling fragment caching
 

package/dist/opencode/.agents/skills/jahia-dev-import-from/SKILL.md

@@ -106,7 +106,7 @@ Report findings, then ask: **"Should I import any of these? (yes / no / specific
 
 ### Step 5a — CND and view
 
-Using the confirmed field split from Step 3, run the `jahia-dev-define-content-type` and `jahia-dev-create-view` patterns to create:
+Using the confirmed field split from Step 3, run the `jahia-cnd-author` and `jahia-dev-create-view` patterns to create:
 
 - `src/components/<Category>/<Name>/definition.cnd`
 - `src/components/<Category>/<Name>/types.ts`

package/dist/opencode/.agents/skills/jahia-dev-properties/SKILL.md

@@ -143,5 +143,5 @@ See [references/all-properties.md](references/all-properties.md) for all ~90 pro
 
 Search tip:
 ```bash
-grep -i "keyword" ~/.claude/skills/jahia-properties/references/all-properties.md
+grep -i "keyword" $(find .claude .agents -name "all-properties.md" 2>/dev/null | head -1)
 ```

package/dist/opencode/.agents/skills/jahia-dev-query-content/SKILL.md

@@ -200,5 +200,5 @@ Use `ISDESCENDANTNODE` to cover nested folder trees automatically. Switch to `IS
 
 - `/jahia-jcr-sql2` — SQL2 syntax, full-text, joins, pagination, and performance
 - `/jahia-dev-build-component` — build the listing component that renders query results
-- `/jahia-dev-define-content-type` — create the queried content type and folder types
+- `/jahia-cnd-author` — create the queried content type and folder types
 

package/dist/opencode/.agents/skills/jahia-jcr-sql2/SKILL.md

@@ -253,6 +253,5 @@ If a user can choose the sort field, validate it against a whitelist before inte
 ## Related skills
 
 - `/jahia-dev-query-content` — apply SQL2 inside Page Builder queries and JS module views
-- `/jahia-dev-define-content-type` — define the content types you will query
-- `/jahia-java-jcr` — implement back-end JCR logic around the query
+- `/jahia-cnd-author` — define the content types you will query
 

package/dist/opencode/.agents/skills/jahia-review/SKILL.md

@@ -0,0 +1,63 @@
+---
+name: jahia-review
+description: Full quality review of a Jahia JavaScript module — runs code review and live site review in parallel via subagents. Use after deploying to get a complete pass/fail signal before finalizing work.
+allowed-tools: Agent, Bash, Read
+---
+
+# Skill: jahia-review
+
+Runs both `/jahia-review-code` and `/jahia-review-site` in parallel via independent subagents, then consolidates their findings. Use this before writing `pages.json` or marking work complete.
+
+---
+
+## Step 1 — Collect live URLs
+
+Read `pages.json` to get the list of live page URLs:
+
+```bash
+cat pages.json
+```
+
+---
+
+## Step 2 — Spawn review subagents in parallel
+
+Invoke two subagents simultaneously:
+
+**Subagent A — code review:**
+> Invoke `/jahia-review-code` on this module. Scan all CND files, TypeScript views, and page templates. Report every issue found (critical, warning, suggestion) with file locations and fix guidance.
+
+**Subagent B — site review:**
+> Invoke `/jahia-review-site` against the URLs in `pages.json`. Run the review script and report every a11y and SEO violation found.
+
+---
+
+## Step 3 — Consolidate and report
+
+Combine findings from both subagents into a single report:
+
+```
+## Review Results
+
+### Code (jahia-review-code)
+[findings from subagent A]
+
+### Site (jahia-review-site)
+[findings from subagent B]
+
+### Verdict
+✅ PASS — no violations found.
+❌ FAIL — N issue(s) must be fixed before finalizing.
+```
+
+---
+
+## Step 4 — Fix and iterate
+
+If any violations were found:
+
+1. Fix every reported issue
+2. Redeploy: `yarn build && yarn jahia-deploy`
+3. Re-run `/jahia-review` until the verdict is ✅ PASS
+
+Only proceed (write `pages.json`, mark work complete) once the review passes.