@jadenrazo/cloudcost-mcp 0.1.7 → 0.1.8

package/README.md

@@ -322,27 +322,27 @@ Configuration priority: environment variables > config file > built-in defaults.
                         │        (src/server.ts)        │
                         └──────────────┬────────────────┘
                                        │
-              ┌────────────────────────┼─────────────────────────┐
-              │                        │                         │
-    ┌─────────▼─────────┐   ┌─────────▼─────────┐    ┌─────────▼─────────┐
-    │   Tool Handlers   │   │   HCL Parsers     │    │   Cost Engine     │
-    │  (src/tools/*.ts)  │   │  (src/parsers/)   │    │  (src/calculator/) │
-    └─────────┬─────────┘   └───────────────────┘    └─────────┬─────────┘
-              │                                                 │
-    ┌─────────▼──────────────────────────────────────────────────▼─────────┐
-    │                       PricingEngine (router)                        │
-    │                   (src/pricing/pricing-engine.ts)                    │
-    └───────┬────────────────────┬──────────────────────┬─────────────────┘
-            │                    │                      │
-  ┌─────────▼──────┐  ┌─────────▼──────┐    ┌──────────▼──────┐
-  │  AWS Bulk      │  │  Azure Retail  │    │  GCP Bundled    │
-  │  Loader        │  │  Client        │    │  Loader         │
-  │  (CSV + JSON)  │  │  (REST API)    │    │  (static JSON)  │
-  └───────┬────────┘  └───────┬────────┘    └────────┬────────┘
-          │                   │                      │
-          ▼                   ▼                      ▼
-  AWS Bulk Pricing   Azure Retail API        data/gcp-pricing/
-  CSV (public)       (public, no auth)       (bundled files)
+              ┌────────────────────────┼───────────────────────┐
+              │                        │                       │
+    ┌─────────▼─────────┐    ┌─────────▼─────────┐   ┌─────────▼─────────┐
+    │   Tool Handlers   │    │   HCL Parsers     │   │   Cost Engine     │
+    │ (src/tools/*.ts)  │    │  (src/parsers/)   │   │ (src/calculator/) │
+    └─────────┬─────────┘    └───────────────────┘   └─────────┬─────────┘
+              │                                                │
+    ┌─────────▼────────────────────────────────────────────────▼─────────┐
+    │                       PricingEngine (router)                       │
+    │                  (src/pricing/pricing-engine.ts)                   │
+    └──────┬───────────────────┬─────────────────────┬───────────────────┘
+           │                   │                     │
+  ┌────────▼───────┐  ┌────────▼───────┐    ┌────────▼───────┐
+  │  AWS Bulk      │  │  Azure Retail  │    │  GCP Bundled   │
+  │  Loader        │  │  Client        │    │  Loader        │
+  │  (CSV + JSON)  │  │  (REST API)    │    │  (static JSON) │
+  └────────┬───────┘  └────────┬───────┘    └────────┬───────┘
+           │                   │                     │
+           ▼                   ▼                     ▼
+  AWS Bulk Pricing   Azure Retail API       data/gcp-pricing/
+  CSV (public)       (public, no auth)      (bundled files)
 ```
 
 ### Key Design Decisions

package/dist/index.js

@@ -270,17 +270,30 @@ function extractUnit(priceDimensions) {
   }
   return "Hrs";
 }
+function extractFromTerms(onDemandTerms, defaultUnit) {
+  for (const skuTerms of Object.values(onDemandTerms)) {
+    if (skuTerms?.priceDimensions) {
+      return {
+        price: extractUsdPrice(skuTerms.priceDimensions),
+        unit: extractUnit(skuTerms.priceDimensions)
+      };
+    }
+    for (const offerTerm of Object.values(skuTerms ?? {})) {
+      const dims = offerTerm?.priceDimensions;
+      if (dims) {
+        return {
+          price: extractUsdPrice(dims),
+          unit: extractUnit(dims)
+        };
+      }
+    }
+  }
+  return { price: 0, unit: defaultUnit };
+}
 function normalizeAwsCompute(rawProduct, rawPrice, region) {
   const attrs = rawProduct?.attributes ?? {};
   const terms = rawPrice?.terms?.OnDemand ?? {};
-  let price = 0;
-  let unit = "Hrs";
-  for (const term of Object.values(terms)) {
-    const dims = term?.priceDimensions ?? {};
-    price = extractUsdPrice(dims);
-    unit = extractUnit(dims);
-    break;
-  }
+  const { price, unit } = extractFromTerms(terms, "Hrs");
   return {
     provider: "aws",
     service: "ec2",
@@ -295,7 +308,8 @@ function normalizeAwsCompute(rawProduct, rawPrice, region) {
       vcpu: attrs.vcpu ?? "",
       memory: attrs.memory ?? "",
       operating_system: attrs.operatingSystem ?? "Linux",
-      tenancy: attrs.tenancy ?? "Shared"
+      tenancy: attrs.tenancy ?? "Shared",
+      pricing_source: "live"
     },
     effective_date: (/* @__PURE__ */ new Date()).toISOString()
   };
@@ -303,14 +317,7 @@ function normalizeAwsCompute(rawProduct, rawPrice, region) {
 function normalizeAwsDatabase(rawProduct, rawPrice, region) {
   const attrs = rawProduct?.attributes ?? {};
   const terms = rawPrice?.terms?.OnDemand ?? {};
-  let price = 0;
-  let unit = "Hrs";
-  for (const term of Object.values(terms)) {
-    const dims = term?.priceDimensions ?? {};
-    price = extractUsdPrice(dims);
-    unit = extractUnit(dims);
-    break;
-  }
+  const { price, unit } = extractFromTerms(terms, "Hrs");
   return {
     provider: "aws",
     service: "rds",
@@ -325,7 +332,8 @@ function normalizeAwsDatabase(rawProduct, rawPrice, region) {
       database_engine: attrs.databaseEngine ?? "",
       deployment_option: attrs.deploymentOption ?? "Single-AZ",
       vcpu: attrs.vcpu ?? "",
-      memory: attrs.memory ?? ""
+      memory: attrs.memory ?? "",
+      pricing_source: "live"
     },
     effective_date: (/* @__PURE__ */ new Date()).toISOString()
   };
@@ -333,14 +341,7 @@ function normalizeAwsDatabase(rawProduct, rawPrice, region) {
 function normalizeAwsStorage(rawProduct, rawPrice, region) {
   const attrs = rawProduct?.attributes ?? {};
   const terms = rawPrice?.terms?.OnDemand ?? {};
-  let price = 0;
-  let unit = "GB-Mo";
-  for (const term of Object.values(terms)) {
-    const dims = term?.priceDimensions ?? {};
-    price = extractUsdPrice(dims);
-    unit = extractUnit(dims);
-    break;
-  }
+  const { price, unit } = extractFromTerms(terms, "GB-Mo");
   const volumeType = attrs.volumeApiName ?? attrs.volumeType ?? "gp3";
   return {
     provider: "aws",
@@ -354,7 +355,8 @@ function normalizeAwsStorage(rawProduct, rawPrice, region) {
     attributes: {
       volume_type: volumeType,
       max_iops: attrs.maxIopsvolume ?? "",
-      max_throughput: attrs.maxThroughputvolume ?? ""
+      max_throughput: attrs.maxThroughputvolume ?? "",
+      pricing_source: "live"
     },
     effective_date: (/* @__PURE__ */ new Date()).toISOString()
   };
@@ -579,7 +581,7 @@ var AwsBulkLoader = class _AwsBulkLoader {
         if (afterCsv) return afterCsv;
       }
     } catch (err) {
-      logger.debug("AWS EC2 CSV streaming failed", {
+      logger.warn("AWS EC2 CSV streaming failed", {
         region,
         instanceType,
         err: err instanceof Error ? err.message : String(err)
@@ -595,7 +597,7 @@ var AwsBulkLoader = class _AwsBulkLoader {
         }
       }
     } catch (err) {
-      logger.debug("AWS bulk EC2 JSON fetch failed, using fallback", {
+      logger.warn("AWS bulk EC2 JSON fetch failed, using fallback", {
         region,
         instanceType,
         err: err instanceof Error ? err.message : String(err)
@@ -617,7 +619,7 @@ var AwsBulkLoader = class _AwsBulkLoader {
         }
       }
     } catch (err) {
-      logger.debug("AWS bulk RDS fetch failed, using fallback", {
+      logger.warn("AWS bulk RDS fetch failed, using fallback", {
         region,
         instanceClass,
         err: err instanceof Error ? err.message : String(err)
@@ -639,7 +641,7 @@ var AwsBulkLoader = class _AwsBulkLoader {
         }
       }
     } catch (err) {
-      logger.debug("AWS bulk EBS fetch failed, using fallback", {
+      logger.warn("AWS bulk EBS fetch failed, using fallback", {
         region,
         volumeType,
         err: err instanceof Error ? err.message : String(err)
@@ -1296,7 +1298,7 @@ var AzureRetailClient = class {
         return result;
       }
     } catch (err) {
-      logger.debug("Azure Retail API VM fetch failed, using fallback", {
+      logger.warn("Azure Retail API VM fetch failed, using fallback", {
         region,
         vmSize,
         err: err instanceof Error ? err.message : String(err)
@@ -1311,15 +1313,18 @@ var AzureRetailClient = class {
     try {
       const armRegion = region.toLowerCase().replace(/\s+/g, "");
       const serviceName = `Azure Database for ${engine}`;
-      const filter = this.buildODataFilter(serviceName, armRegion, tier);
-      const items = await this.queryPricing(filter);
-      if (items.length > 0) {
-        const result = normalizeAzureDatabase(items[0]);
+      const result = await this.queryDatabasePrice(tier, armRegion, serviceName);
+      if (result) {
         this.cache.set(cacheKey, result, "azure", "db", region, CACHE_TTL2);
         return result;
       }
+      logger.warn("Azure Retail API returned no matching DB pricing", {
+        region,
+        tier,
+        engine
+      });
     } catch (err) {
-      logger.debug("Azure Retail API DB fetch failed, using fallback", {
+      logger.warn("Azure Retail API DB fetch failed, using fallback", {
         region,
         tier,
         err: err instanceof Error ? err.message : String(err)
@@ -1327,6 +1332,56 @@ var AzureRetailClient = class {
     }
     return this.fallbackDatabasePrice(tier, region, engine, cacheKey);
   }
+  /**
+   * Azure DB flexible server tier names follow the pattern:
+   *   GP_Standard_D2s_v3  →  General Purpose, D-series, 2 vCPUs, v3
+   *   MO_Standard_E4ds_v5 →  Memory Optimized, E-series, 4 vCPUs, v5
+   *
+   * The Retail API prices DB compute in two ways:
+   *   1. Per-instance entries with armSkuName like "Standard_D2ds_v5" (total price)
+   *   2. Per-vCore entries for a series (e.g., Dsv3Series_Compute) × vCPU count
+   *
+   * This method tries approach 1 first, then falls back to approach 2.
+   */
+  async queryDatabasePrice(tier, armRegion, serviceName) {
+    const vmName = tier.replace(/^(GP|MO|BC|GEN)_/i, "");
+    const exactFilter = `serviceName eq '${serviceName}' and armRegionName eq '${armRegion}' and priceType eq 'Consumption' and armSkuName eq '${vmName}'`;
+    const exactItems = await this.queryPricing(exactFilter);
+    if (exactItems.length > 0) {
+      const match = exactItems.find(
+        (i) => (i.meterName ?? "").toLowerCase().includes("vcore")
+      ) ?? exactItems[0];
+      return normalizeAzureDatabase(match);
+    }
+    const parsed = this.parseVmSeries(vmName);
+    if (!parsed) return null;
+    const tierPrefix = tier.match(/^(GP|MO|BC|GEN)_/i)?.[1]?.toUpperCase();
+    const seriesFamily = tierPrefix === "MO" ? "Memory_Optimized" : "General_Purpose";
+    const seriesFilter = `serviceName eq '${serviceName}' and armRegionName eq '${armRegion}' and priceType eq 'Consumption' and contains(armSkuName, '${seriesFamily}') and contains(armSkuName, '${parsed.series}')`;
+    const seriesItems = await this.queryPricing(seriesFilter);
+    if (seriesItems.length > 0) {
+      const perVcore = seriesItems[0].retailPrice ?? 0;
+      const totalPrice = perVcore * parsed.vcpus;
+      const adjusted = { ...seriesItems[0], retailPrice: totalPrice };
+      return normalizeAzureDatabase(adjusted);
+    }
+    return null;
+  }
+  /**
+   * Parse a VM name like "Standard_D2s_v3" into series info.
+   * Returns { series: "Dsv3", vcpus: 2 } or null if unparseable.
+   */
+  parseVmSeries(vmName) {
+    const match = vmName.match(
+      /Standard_([A-Z])(\d+)([a-z]*)_v(\d+)/i
+    );
+    if (!match) return null;
+    const [, family, vcpuStr, variant, version] = match;
+    const vcpus = parseInt(vcpuStr, 10);
+    if (isNaN(vcpus) || vcpus === 0) return null;
+    const series = `${family}${variant}v${version}`;
+    return { series, vcpus };
+  }
   async getStoragePrice(diskType, region) {
     const cacheKey = this.buildCacheKey("disk", region, diskType);
     const cached = this.cache.get(cacheKey);
@@ -1340,8 +1395,12 @@ var AzureRetailClient = class {
         this.cache.set(cacheKey, result, "azure", "storage", region, CACHE_TTL2);
         return result;
       }
+      logger.warn("Azure Retail API returned no matching storage pricing", {
+        region,
+        diskType
+      });
     } catch (err) {
-      logger.debug("Azure Retail API storage fetch failed, using fallback", {
+      logger.warn("Azure Retail API storage fetch failed, using fallback", {
         region,
         diskType,
         err: err instanceof Error ? err.message : String(err)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jadenrazo/cloudcost-mcp",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "description": "MCP server for multi-cloud cost analysis of Terraform codebases",
   "type": "module",
   "license": "MIT",