@jacques_gordon/expo-mapbox-navigation 2.2.9 → 2.2.10

package/app.plugin.js

@@ -216,13 +216,44 @@ def _expo_mapbox_nav_add_spm(installer)
   end
   pods_project.save
 
-  # ── NOTE: We do NOT add products to the user app target ────────────────────
-  # Adding MapboxNavigationCore/UIKit directly to the app target causes
-  # "Multiple commands produce" errors for MapboxCommon, MapboxCoreMaps, Turf
-  # because @rnmapbox/maps already embeds them via CocoaPods/SPM.
-  # The ExpoMapboxNavigation pod target is sufficient: when CocoaPods links
-  # the pod into the app, SPM resolves the transitive dependencies correctly
-  # without re-embedding them.
+  # ── Step 2: Add package REFERENCE to user_project (NOT products) ────────────
+  # Critical distinction learned from build logs:
+  #
+  # v2.2.8 (Step 2 with products on user target):
+  #   → SPM resolved correctly ✅
+  #   → But caused "Multiple commands produce MapboxCommon/Turf/MapboxCoreMaps" ❌
+  #   → Because @rnmapbox/maps already embeds those transitive dependencies
+  #
+  # v2.2.9 (Step 2 removed entirely):
+  #   → No "Multiple commands produce" ✅
+  #   → But "Missing package product MapboxNavigationCore/UIKit" ❌
+  #   → Because Pods.xcodeproj is rebuilt by CocoaPods each time, so the
+  #     package reference injected into pods_project does not persist.
+  #     Without a reference in user_project (Navio.xcodeproj, which persists),
+  #     Xcode does not resolve the SPM package and the products are not found.
+  #
+  # v2.2.10 (this version — package reference only in user_project):
+  #   → Add ONLY the XCRemoteSwiftPackageReference to user_project ✅
+  #   → Do NOT add XCSwiftPackageProductDependency to user_target ✅
+  #   → This registers the package in the Xcode workspace SPM graph so it
+  #     gets resolved and downloaded, without embedding its frameworks again.
+  installer.aggregate_targets.each do |agg|
+    user_project = agg.user_project
+
+    # Add only the package reference — not the product dependencies
+    user_pkg = user_project.root_object.package_references.find { |p|
+      p.class == pkg_class && p.repositoryURL == url
+    }
+    unless user_pkg
+      user_pkg = user_project.new(pkg_class)
+      user_pkg.repositoryURL = url
+      user_pkg.requirement   = requirement
+      user_project.root_object.package_references << user_pkg
+      puts "[ExpoMapboxNavigation] Registered mapbox-navigation-ios in #{user_project.path.basename}"
+    end
+
+    user_project.save
+  end
 end
 `;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacques_gordon/expo-mapbox-navigation",
-  "version": "2.2.9",
+  "version": "2.2.10",
   "description": "Expo module for Mapbox Navigation SDK with 16KB page size support, NDK27, and Mapbox Maps v11.11.0+",
   "main": "build/index.js",
   "types": "build/index.d.ts",

package/plugin/src/index.js

@@ -216,13 +216,44 @@ def _expo_mapbox_nav_add_spm(installer)
   end
   pods_project.save
 
-  # ── NOTE: We do NOT add products to the user app target ────────────────────
-  # Adding MapboxNavigationCore/UIKit directly to the app target causes
-  # "Multiple commands produce" errors for MapboxCommon, MapboxCoreMaps, Turf
-  # because @rnmapbox/maps already embeds them via CocoaPods/SPM.
-  # The ExpoMapboxNavigation pod target is sufficient: when CocoaPods links
-  # the pod into the app, SPM resolves the transitive dependencies correctly
-  # without re-embedding them.
+  # ── Step 2: Add package REFERENCE to user_project (NOT products) ────────────
+  # Critical distinction learned from build logs:
+  #
+  # v2.2.8 (Step 2 with products on user target):
+  #   → SPM resolved correctly ✅
+  #   → But caused "Multiple commands produce MapboxCommon/Turf/MapboxCoreMaps" ❌
+  #   → Because @rnmapbox/maps already embeds those transitive dependencies
+  #
+  # v2.2.9 (Step 2 removed entirely):
+  #   → No "Multiple commands produce" ✅
+  #   → But "Missing package product MapboxNavigationCore/UIKit" ❌
+  #   → Because Pods.xcodeproj is rebuilt by CocoaPods each time, so the
+  #     package reference injected into pods_project does not persist.
+  #     Without a reference in user_project (Navio.xcodeproj, which persists),
+  #     Xcode does not resolve the SPM package and the products are not found.
+  #
+  # v2.2.10 (this version — package reference only in user_project):
+  #   → Add ONLY the XCRemoteSwiftPackageReference to user_project ✅
+  #   → Do NOT add XCSwiftPackageProductDependency to user_target ✅
+  #   → This registers the package in the Xcode workspace SPM graph so it
+  #     gets resolved and downloaded, without embedding its frameworks again.
+  installer.aggregate_targets.each do |agg|
+    user_project = agg.user_project
+
+    # Add only the package reference — not the product dependencies
+    user_pkg = user_project.root_object.package_references.find { |p|
+      p.class == pkg_class && p.repositoryURL == url
+    }
+    unless user_pkg
+      user_pkg = user_project.new(pkg_class)
+      user_pkg.repositoryURL = url
+      user_pkg.requirement   = requirement
+      user_project.root_object.package_references << user_pkg
+      puts "[ExpoMapboxNavigation] Registered mapbox-navigation-ios in #{user_project.path.basename}"
+    end
+
+    user_project.save
+  end
 end
 `;