@jacques_gordon/expo-mapbox-navigation 2.2.14 → 2.2.16

package/app.plugin.js

@@ -159,7 +159,16 @@ const withMapboxNavigation = (config, options = {}) => {
 
       console.log(`[@jacques_gordon/expo-mapbox-navigation] Maps ${mapsVersion} (minor=${mapsMinor}) → Navigation ${navMin}..<3.${navMinor+1}.0`);
       console.log(`[@jacques_gordon/expo-mapbox-navigation] Phase: ${mapsMinor <= 15 ? `1 (offset -3: ${mapsMinor}-3=${navMinor})` : `2 (aligned: ${navMinor})`}`);
+
+      // IMPORTANT: spmHook below is a JS template literal. Any dollar-brace
+      // interpolation syntax written directly inside it is evaluated as JS,
+      // NOT left as text for Ruby. Ruby build-setting variables that must
+      // survive into the generated Podfile (e.g. PODS_CONFIGURATION_BUILD_DIR)
+      // are built here as plain JS strings and interpolated via a named
+      // variable, so the literal dollar-brace text reaches the Ruby side
+      // untouched instead of being evaluated as a JS expression.
       const podsBuildDir = '$' + '{PODS_CONFIGURATION_BUILD_DIR}';
+
       // The Ruby hook — identical pattern to @rnmapbox/maps _add_spm_to_target
       const spmHook = `
 # [ExpoMapboxNavigation] SPM hook — injected by @jacques_gordon/expo-mapbox-navigation
@@ -170,6 +179,26 @@ def _expo_mapbox_nav_add_spm(installer)
   requirement = { kind: 'upToNextMinorVersion', minimumVersion: '${navMin}' }
   products    = ['MapboxNavigationCore', 'MapboxNavigationUIKit']
 
+  # MapboxNavigationCore links against MapboxNavigationNative (a separate
+  # remote SPM package: mapbox-navigation-native-ios), which ships the
+  # precompiled binary defining native ObjC classes (e.g. MBNNAmenity).
+  # Without adding it explicitly as a product dependency on our own pod
+  # target, MapboxNavigationCore.swift compiles fine (headers are visible
+  # via the resolved workspace package graph) but the app fails to LINK,
+  # with "Undefined symbols ... _OBJC_CLASS_$_MBNNAmenity", because the
+  # xcframework binary itself was never added to any target's link phase.
+  native_url         = 'https://github.com/mapbox/mapbox-navigation-native-ios.git'
+  # NOTE: MapboxNavigationNative's "major" version is really just an
+  # incrementing build counter (has been 124, 206, 310, 324... over time),
+  # not semantic versioning. A narrow upToNextMajorVersion window would
+  # exclude whatever version mapbox-navigation-ios actually resolves to
+  # internally, causing SPM dependency resolution to fail outright. We use
+  # a deliberately wide range instead — the real version lock already comes
+  # from mapbox-navigation-ios's own Package.swift; this reference only
+  # needs to expose the product, not add a second constraint.
+  native_requirement = { kind: 'range', minimumVersion: '1.0.0', maximumVersion: '9999.0.0' }
+  native_product      = 'MapboxNavigationNative'
+
   pkg_class = Xcodeproj::Project::Object::XCRemoteSwiftPackageReference
   ref_class = Xcodeproj::Project::Object::XCSwiftPackageProductDependency
   dep_class = Xcodeproj::Project::Object::PBXTargetDependency
@@ -188,6 +217,21 @@ def _expo_mapbox_nav_add_spm(installer)
     puts '[ExpoMapboxNavigation] Added mapbox-navigation-ios to pods_project'
   end
 
+  # ── Step 1a: Register mapbox-navigation-native-ios as its own package ─────
+  # This is a SEPARATE remote repo from mapbox-navigation-ios, so it needs
+  # its own XCRemoteSwiftPackageReference — it cannot be listed as a
+  # product of the main package reference above.
+  native_pkg = pods_project.root_object.package_references.find { |p|
+    p.class == pkg_class && p.repositoryURL == native_url
+  }
+  unless native_pkg
+    native_pkg = pods_project.new(pkg_class)
+    native_pkg.repositoryURL = native_url
+    native_pkg.requirement   = native_requirement
+    pods_project.root_object.package_references << native_pkg
+    puts '[ExpoMapboxNavigation] Added mapbox-navigation-native-ios to pods_project'
+  end
+
   expo_target = pods_project.targets.find { |t| t.name == 'ExpoMapboxNavigation' }
   expo_target ||= pods_project.targets.find { |t| t.name.include?('ExpoMapboxNavigation') }
   if expo_target
@@ -206,8 +250,21 @@ def _expo_mapbox_nav_add_spm(installer)
       end
     end
 
+    # 1b. MapboxNavigationNative product dependency (fixes MBNNAmenity
+    #     and other native symbols being undefined at final app link)
+    native_prod_ref = expo_target.package_product_dependencies.find { |r|
+      r.class == ref_class && r.package == native_pkg && r.product_name == native_product
+    }
+    unless native_prod_ref
+      native_prod_ref = pods_project.new(ref_class)
+      native_prod_ref.package      = native_pkg
+      native_prod_ref.product_name = native_product
+      expo_target.package_product_dependencies << native_prod_ref
+      puts "[ExpoMapboxNavigation] Added package_product_dependency: #{native_product}"
+    end
+
     # ── SWIFT_INCLUDE_PATHS fix ──────────────────────────────────────────────
-    # SPM compiles .swiftmodule into ${PODS_CONFIGURATION_BUILD_DIR}.
+    # SPM compiles .swiftmodule into PODS_CONFIGURATION_BUILD_DIR.
     # Without adding this path, Xcode throws "no such module MapboxNavigationCore".
     # Source: https://trinhngocthuyen.com/posts/tech/spm-with-cocoapods/
     expo_target.build_configurations.each do |config|
@@ -244,6 +301,18 @@ def _expo_mapbox_nav_add_spm(installer)
       user_project.root_object.package_references << user_pkg
       puts "[ExpoMapboxNavigation] Registered package ref in #{user_project.path.basename}"
     end
+
+    user_native_pkg = user_project.root_object.package_references.find { |p|
+      p.class == pkg_class && p.repositoryURL == native_url
+    }
+    unless user_native_pkg
+      user_native_pkg = user_project.new(pkg_class)
+      user_native_pkg.repositoryURL = native_url
+      user_native_pkg.requirement   = native_requirement
+      user_project.root_object.package_references << user_native_pkg
+      puts "[ExpoMapboxNavigation] Registered native package ref in #{user_project.path.basename}"
+    end
+
     user_project.save
   end
 end

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacques_gordon/expo-mapbox-navigation",
-  "version": "2.2.14",
+  "version": "2.2.16",
   "description": "Expo module for Mapbox Navigation SDK with 16KB page size support, NDK27, and Mapbox Maps v11.11.0+",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -9,7 +9,7 @@
     "clean": "rm -rf build",
     "lint": "tsc --noEmit",
     "test": "echo \"Tests require a full Expo project with EAS Build. See README.\"",
-    "prepublishOnly": ""
+    "prepublishOnly": "npm run build"
   },
   "keywords": [
     "expo",

package/plugin/src/index.js

@@ -159,7 +159,16 @@ const withMapboxNavigation = (config, options = {}) => {
 
       console.log(`[@jacques_gordon/expo-mapbox-navigation] Maps ${mapsVersion} (minor=${mapsMinor}) → Navigation ${navMin}..<3.${navMinor+1}.0`);
       console.log(`[@jacques_gordon/expo-mapbox-navigation] Phase: ${mapsMinor <= 15 ? `1 (offset -3: ${mapsMinor}-3=${navMinor})` : `2 (aligned: ${navMinor})`}`);
+
+      // IMPORTANT: spmHook below is a JS template literal. Any dollar-brace
+      // interpolation syntax written directly inside it is evaluated as JS,
+      // NOT left as text for Ruby. Ruby build-setting variables that must
+      // survive into the generated Podfile (e.g. PODS_CONFIGURATION_BUILD_DIR)
+      // are built here as plain JS strings and interpolated via a named
+      // variable, so the literal dollar-brace text reaches the Ruby side
+      // untouched instead of being evaluated as a JS expression.
       const podsBuildDir = '$' + '{PODS_CONFIGURATION_BUILD_DIR}';
+
       // The Ruby hook — identical pattern to @rnmapbox/maps _add_spm_to_target
       const spmHook = `
 # [ExpoMapboxNavigation] SPM hook — injected by @jacques_gordon/expo-mapbox-navigation
@@ -170,6 +179,26 @@ def _expo_mapbox_nav_add_spm(installer)
   requirement = { kind: 'upToNextMinorVersion', minimumVersion: '${navMin}' }
   products    = ['MapboxNavigationCore', 'MapboxNavigationUIKit']
 
+  # MapboxNavigationCore links against MapboxNavigationNative (a separate
+  # remote SPM package: mapbox-navigation-native-ios), which ships the
+  # precompiled binary defining native ObjC classes (e.g. MBNNAmenity).
+  # Without adding it explicitly as a product dependency on our own pod
+  # target, MapboxNavigationCore.swift compiles fine (headers are visible
+  # via the resolved workspace package graph) but the app fails to LINK,
+  # with "Undefined symbols ... _OBJC_CLASS_$_MBNNAmenity", because the
+  # xcframework binary itself was never added to any target's link phase.
+  native_url         = 'https://github.com/mapbox/mapbox-navigation-native-ios.git'
+  # NOTE: MapboxNavigationNative's "major" version is really just an
+  # incrementing build counter (has been 124, 206, 310, 324... over time),
+  # not semantic versioning. A narrow upToNextMajorVersion window would
+  # exclude whatever version mapbox-navigation-ios actually resolves to
+  # internally, causing SPM dependency resolution to fail outright. We use
+  # a deliberately wide range instead — the real version lock already comes
+  # from mapbox-navigation-ios's own Package.swift; this reference only
+  # needs to expose the product, not add a second constraint.
+  native_requirement = { kind: 'range', minimumVersion: '1.0.0', maximumVersion: '9999.0.0' }
+  native_product      = 'MapboxNavigationNative'
+
   pkg_class = Xcodeproj::Project::Object::XCRemoteSwiftPackageReference
   ref_class = Xcodeproj::Project::Object::XCSwiftPackageProductDependency
   dep_class = Xcodeproj::Project::Object::PBXTargetDependency
@@ -188,6 +217,21 @@ def _expo_mapbox_nav_add_spm(installer)
     puts '[ExpoMapboxNavigation] Added mapbox-navigation-ios to pods_project'
   end
 
+  # ── Step 1a: Register mapbox-navigation-native-ios as its own package ─────
+  # This is a SEPARATE remote repo from mapbox-navigation-ios, so it needs
+  # its own XCRemoteSwiftPackageReference — it cannot be listed as a
+  # product of the main package reference above.
+  native_pkg = pods_project.root_object.package_references.find { |p|
+    p.class == pkg_class && p.repositoryURL == native_url
+  }
+  unless native_pkg
+    native_pkg = pods_project.new(pkg_class)
+    native_pkg.repositoryURL = native_url
+    native_pkg.requirement   = native_requirement
+    pods_project.root_object.package_references << native_pkg
+    puts '[ExpoMapboxNavigation] Added mapbox-navigation-native-ios to pods_project'
+  end
+
   expo_target = pods_project.targets.find { |t| t.name == 'ExpoMapboxNavigation' }
   expo_target ||= pods_project.targets.find { |t| t.name.include?('ExpoMapboxNavigation') }
   if expo_target
@@ -206,8 +250,21 @@ def _expo_mapbox_nav_add_spm(installer)
       end
     end
 
+    # 1b. MapboxNavigationNative product dependency (fixes MBNNAmenity
+    #     and other native symbols being undefined at final app link)
+    native_prod_ref = expo_target.package_product_dependencies.find { |r|
+      r.class == ref_class && r.package == native_pkg && r.product_name == native_product
+    }
+    unless native_prod_ref
+      native_prod_ref = pods_project.new(ref_class)
+      native_prod_ref.package      = native_pkg
+      native_prod_ref.product_name = native_product
+      expo_target.package_product_dependencies << native_prod_ref
+      puts "[ExpoMapboxNavigation] Added package_product_dependency: #{native_product}"
+    end
+
     # ── SWIFT_INCLUDE_PATHS fix ──────────────────────────────────────────────
-    # SPM compiles .swiftmodule into ${PODS_CONFIGURATION_BUILD_DIR}.
+    # SPM compiles .swiftmodule into PODS_CONFIGURATION_BUILD_DIR.
     # Without adding this path, Xcode throws "no such module MapboxNavigationCore".
     # Source: https://trinhngocthuyen.com/posts/tech/spm-with-cocoapods/
     expo_target.build_configurations.each do |config|
@@ -244,6 +301,18 @@ def _expo_mapbox_nav_add_spm(installer)
       user_project.root_object.package_references << user_pkg
       puts "[ExpoMapboxNavigation] Registered package ref in #{user_project.path.basename}"
     end
+
+    user_native_pkg = user_project.root_object.package_references.find { |p|
+      p.class == pkg_class && p.repositoryURL == native_url
+    }
+    unless user_native_pkg
+      user_native_pkg = user_project.new(pkg_class)
+      user_native_pkg.repositoryURL = native_url
+      user_native_pkg.requirement   = native_requirement
+      user_project.root_object.package_references << user_native_pkg
+      puts "[ExpoMapboxNavigation] Registered native package ref in #{user_project.path.basename}"
+    end
+
     user_project.save
   end
 end

package/android/.gradle/buildOutputCleanup/cache.properties

@@ -1,2 +0,0 @@
-#Wed Jul 01 20:44:58 CEST 2026
-gradle.version=8.9