@jacques_gordon/expo-mapbox-navigation 1.0.7 → 2.0.1

package/android/src/main/java/expo/modules/mapboxnavigation/ExpoMapboxNavigationModule.kt

@@ -4,82 +4,86 @@ import expo.modules.kotlin.modules.Module
 import expo.modules.kotlin.modules.ModuleDefinition
 
 class ExpoMapboxNavigationModule : Module() {
-  override fun definition() = ModuleDefinition {
-    Name("ExpoMapboxNavigation")
-
-    View(ExpoMapboxNavigationView::class) {
-
-      // ─── Props ──────────────────────────────────────────────────────
-
-      Prop("coordinates") { view: ExpoMapboxNavigationView, value: List<Map<String, Double>> ->
-        view.coordinates = value
-        view.startNavigationIfReady()
-      }
-
-      Prop("waypointIndices") { view: ExpoMapboxNavigationView, value: List<Int> ->
-        view.waypointIndices = value
-      }
-
-      Prop("useRouteMatchingApi") { view: ExpoMapboxNavigationView, value: Boolean ->
-        view.useRouteMatchingApi = value
-      }
-
-      Prop("locale") { view: ExpoMapboxNavigationView, value: String ->
-        view.locale = value
-      }
-
-      Prop("routeProfile") { view: ExpoMapboxNavigationView, value: String ->
-        // Android: sans le préfixe "mapbox/"
-        view.routeProfile = value.removePrefix("mapbox/")
-      }
-
-      Prop("routeExcludeList") { view: ExpoMapboxNavigationView, value: List<String> ->
-        view.routeExcludeList = value
-      }
-
-      Prop("mapStyle") { view: ExpoMapboxNavigationView, value: String ->
-        view.mapStyle = value
-      }
-
-      Prop("mute") { view: ExpoMapboxNavigationView, value: Boolean ->
-        view.mute = value
-      }
-
-      Prop("vehicleMaxHeight") { view: ExpoMapboxNavigationView, value: Double ->
-        view.vehicleMaxHeight = value
-      }
-
-      Prop("vehicleMaxWidth") { view: ExpoMapboxNavigationView, value: Double ->
-        view.vehicleMaxWidth = value
-      }
-
-      Prop("customRasterSourceUrl") { view: ExpoMapboxNavigationView, value: String ->
-        view.customRasterSourceUrl = value
-      }
-
-      Prop("placeCustomRasterLayerAbove") { view: ExpoMapboxNavigationView, value: String ->
-        view.placeCustomRasterLayerAbove = value
-      }
-
-      Prop("disableAlternativeRoutes") { view: ExpoMapboxNavigationView, value: Boolean ->
-        view.disableAlternativeRoutes = value
-      }
-
-      Prop("showsEndOfRouteFeedback") { view: ExpoMapboxNavigationView, value: Boolean ->
-        view.showsEndOfRouteFeedback = value
-      }
-
-      // ─── Events ─────────────────────────────────────────────────────
-
-      Events(
-        "onRouteProgressChanged",
-        "onWaypointArrival",
-        "onFinalDestinationArrival",
-        "onCancelNavigation",
-        "onRouteChanged",
-        "onUserOffRoute",
-        "onRoutesLoaded"
-      )
+    override fun definition() = ModuleDefinition {
+        Name("ExpoMapboxNavigation")
+
+        View(ExpoMapboxNavigationView::class) {
+            Events(
+                "onRouteProgressChanged",
+                "onRoutesReady",
+                "onNavigationFinished",
+                "onNavigationCancelled",
+                "onRoutesFailed",
+                "onArrival"
+            )
+
+            // Coordinates: Array of {latitude, longitude} objects
+            Prop("coordinates") { view: ExpoMapboxNavigationView, coordinates: List<Map<String, Double>> ->
+                view.setCoordinates(coordinates)
+            }
+
+            // Waypoint indices
+            Prop("waypointIndices") { view: ExpoMapboxNavigationView, indices: List<Int>? ->
+                view.setWaypointIndices(indices)
+            }
+
+            // Language/locale
+            Prop("language") { view: ExpoMapboxNavigationView, language: String? ->
+                view.setLanguage(language)
+            }
+
+            // ─────────────────────────────────────────────────────────────
+            // voiceUnits prop — fixes Issue #31 (metric/imperial selection)
+            // Accepts: "metric" | "imperial" | null (auto from locale)
+            // ─────────────────────────────────────────────────────────────
+            Prop("voiceUnits") { view: ExpoMapboxNavigationView, units: String? ->
+                view.setVoiceUnits(units)
+            }
+
+            // Navigation profile
+            Prop("navigationProfile") { view: ExpoMapboxNavigationView, profile: String? ->
+                view.setNavigationProfile(profile)
+            }
+
+            // Excluded road types
+            Prop("excludeTypes") { view: ExpoMapboxNavigationView, types: List<String>? ->
+                view.setExcludeTypes(types)
+            }
+
+            // Map style URL
+            Prop("mapStyle") { view: ExpoMapboxNavigationView, style: String? ->
+                view.setMapStyle(style)
+            }
+
+            // Mute navigation audio
+            Prop("mute") { view: ExpoMapboxNavigationView, mute: Boolean ->
+                view.setMute(mute)
+            }
+
+            // Vehicle height restriction (meters)
+            Prop("maxHeight") { view: ExpoMapboxNavigationView, height: Double? ->
+                view.setMaxHeight(height)
+            }
+
+            // Vehicle width restriction (meters)
+            Prop("maxWidth") { view: ExpoMapboxNavigationView, width: Double? ->
+                view.setMaxWidth(width)
+            }
+
+            // Map matching mode
+            Prop("useMapMatching") { view: ExpoMapboxNavigationView, use: Boolean ->
+                view.setUseMapMatching(use)
+            }
+
+            // Custom raster tile URL
+            Prop("customRasterTileUrl") { view: ExpoMapboxNavigationView, url: String? ->
+                view.setCustomRasterTileUrl(url)
+            }
+
+            // Layer ID above which custom raster goes
+            Prop("customRasterAboveLayerId") { view: ExpoMapboxNavigationView, layerId: String? ->
+                view.setCustomRasterAboveLayerId(layerId)
+            }
+        }
     }
-  }
 }

package/android/src/main/java/expo/modules/mapboxnavigation/ExpoMapboxNavigationView.kt

@@ -1,184 +1,302 @@
 package expo.modules.mapboxnavigation
 
 import android.content.Context
-import android.view.ViewGroup
-import com.mapbox.api.directions.v5.DirectionsCriteria
+import android.util.Log
+import androidx.lifecycle.DefaultLifecycleObserver
+import androidx.lifecycle.LifecycleOwner
 import com.mapbox.api.directions.v5.models.RouteOptions
+import com.mapbox.common.location.AccuracyLevel
+import com.mapbox.common.location.DeviceLocationProviderFactory
+import com.mapbox.common.location.IntervalSettings
+import com.mapbox.common.location.LocationProviderRequest
 import com.mapbox.geojson.Point
+import com.mapbox.maps.MapView
+import com.mapbox.maps.Style
+import com.mapbox.navigation.base.TimeFormat
 import com.mapbox.navigation.base.extensions.applyDefaultNavigationOptions
 import com.mapbox.navigation.base.extensions.applyLanguageAndVoiceUnitOptions
+import com.mapbox.navigation.base.formatter.DistanceFormatterOptions
+import com.mapbox.navigation.base.formatter.UnitType
+import com.mapbox.navigation.base.options.NavigationOptions
 import com.mapbox.navigation.base.route.NavigationRoute
-import com.mapbox.navigation.base.route.NavigationRouterCallback
-import com.mapbox.navigation.base.route.RouterFailure
 import com.mapbox.navigation.base.route.RouterOrigin
-import com.mapbox.navigation.base.trip.model.RouteProgress
-import com.mapbox.navigation.base.trip.model.RouteProgressState
 import com.mapbox.navigation.core.MapboxNavigation
 import com.mapbox.navigation.core.MapboxNavigationProvider
 import com.mapbox.navigation.core.directions.session.RoutesObserver
 import com.mapbox.navigation.core.lifecycle.MapboxNavigationApp
+import com.mapbox.navigation.core.replay.MapboxReplayer
 import com.mapbox.navigation.core.trip.session.RouteProgressObserver
+import com.mapbox.navigation.core.trip.session.VoiceInstructionsObserver
 import com.mapbox.navigation.dropin.NavigationView
-import com.mapbox.navigation.dropin.map.MapStyleLoader
+import com.mapbox.navigation.dropin.NavigationViewListener
+import com.mapbox.navigation.ui.base.util.MapboxNavigationConsumer
 import expo.modules.kotlin.AppContext
 import expo.modules.kotlin.views.ExpoView
 import java.util.Locale
 
-class ExpoMapboxNavigationView(context: Context, appContext: AppContext) : ExpoView(context, appContext) {
-
-  // ─── Props ──────────────────────────────────────────────────────────────
-  var coordinates: List<Map<String, Double>> = emptyList()
-  var waypointIndices: List<Int> = emptyList()
-  var useRouteMatchingApi: Boolean = false
-  var locale: String = ""
-  var routeProfile: String = "driving-traffic"
-  var routeExcludeList: List<String> = emptyList()
-  var mapStyle: String? = null
-  var mute: Boolean = false
-  var vehicleMaxHeight: Double? = null
-  var vehicleMaxWidth: Double? = null
-  var customRasterSourceUrl: String? = null
-  var placeCustomRasterLayerAbove: String? = null
-  var disableAlternativeRoutes: Boolean = false
-  var showsEndOfRouteFeedback: Boolean = false
-
-  // ─── Events ─────────────────────────────────────────────────────────────
-  private val onRouteProgressChanged by lazy { appContext.eventDispatcher("onRouteProgressChanged") }
-  private val onWaypointArrival by lazy { appContext.eventDispatcher("onWaypointArrival") }
-  private val onFinalDestinationArrival by lazy { appContext.eventDispatcher("onFinalDestinationArrival") }
-  private val onCancelNavigation by lazy { appContext.eventDispatcher("onCancelNavigation") }
-  private val onRouteChanged by lazy { appContext.eventDispatcher("onRouteChanged") }
-  private val onUserOffRoute by lazy { appContext.eventDispatcher("onUserOffRoute") }
-  private val onRoutesLoaded by lazy { appContext.eventDispatcher("onRoutesLoaded") }
-
-  // ─── Internal ───────────────────────────────────────────────────────────
-  private var navigationView: NavigationView? = null
-  private var isStarted = false
-  private var currentWaypointIndex = 0
-  private var mapboxNavigation: MapboxNavigation? = null
-
-  fun startNavigationIfReady() {
-    if (coordinates.size >= 2 && !isStarted) {
-      isStarted = true
-      post { setupNavigationView() }
-    }
-  }
-
-  private fun setupNavigationView() {
-    val activity = context as? androidx.fragment.app.FragmentActivity ?: return
-
-    // Créer la NavigationView (drop-in UI Mapbox)
-    val navView = NavigationView(context).also {
-      it.layoutParams = ViewGroup.LayoutParams(
-        ViewGroup.LayoutParams.MATCH_PARENT,
-        ViewGroup.LayoutParams.MATCH_PARENT
-      )
-    }
-    navigationView = navView
-    addView(navView)
-
-    // Observer la progression
-    navView.registerRouteProgressObserver(object : RouteProgressObserver {
-      override fun onRouteProgressChanged(routeProgress: RouteProgress) {
-        val progressData = mapOf(
-          "distanceRemaining" to routeProgress.distanceRemaining,
-          "distanceTraveled" to routeProgress.distanceTraveled,
-          "durationRemaining" to routeProgress.durationRemaining,
-          "fractionTraveled" to routeProgress.fractionTraveled
-        )
-
-        onRouteProgressChanged.emit(progressData)
-
-        // Arrivée à un waypoint intermédiaire
-        if (routeProgress.currentState == RouteProgressState.COMPLETE) {
-          val legIndex = routeProgress.currentLegProgress?.legIndex ?: 0
-          val totalLegs = routeProgress.navigationRoute?.directionsRoute?.legs()?.size ?: 1
-
-          if (legIndex < totalLegs - 1) {
-            onWaypointArrival.emit(progressData)
-          } else {
-            onFinalDestinationArrival.emit(emptyMap<String, Any>())
-          }
+private const val TAG = "ExpoMapboxNavigation"
+
+/**
+ * ExpoMapboxNavigationView — Full-featured navigation view wrapping the Mapbox Drop-In UI.
+ *
+ * Fixes:
+ *  - Issue #43: CameraAnimationsUtils.calculateCameraAnimationHint NoSuchMethodError
+ *    Root cause: version mismatch between Navigation SDK and Maps SDK.
+ *    Fix: build.gradle now pins mapbox-maps-android to ≥ 11.11.0 and navigation to 3.7.0,
+ *    which ensures the method signature exists at runtime. The camera call is also wrapped
+ *    in a try/catch to degrade gracefully if ever encountered.
+ *
+ *  - Issue #31: Voice units always imperial regardless of device locale
+ *    Fix: new `voiceUnits` prop ("metric" | "imperial" | null) exposed via module.
+ *    The value is forwarded to RouteOptions via applyLanguageAndVoiceUnitOptions
+ *    with an explicit UnitType override.
+ */
+class ExpoMapboxNavigationView(context: Context, appContext: AppContext) :
+    ExpoView(context, appContext) {
+
+    private var navigationView: NavigationView? = null
+    private var mapboxNavigation: MapboxNavigation? = null
+
+    // Props
+    private var coordinates: List<Map<String, Double>> = emptyList()
+    private var waypointIndices: List<Int>? = null
+    private var language: String? = null
+    private var voiceUnits: String? = null   // "metric" | "imperial" | null
+    private var navigationProfile: String? = null
+    private var excludeTypes: List<String>? = null
+    private var mapStyle: String? = null
+    private var mute: Boolean = false
+    private var maxHeight: Double? = null
+    private var maxWidth: Double? = null
+    private var useMapMatching: Boolean = false
+    private var customRasterTileUrl: String? = null
+    private var customRasterAboveLayerId: String? = null
+
+    init {
+        setupNavigationView()
+    }
+
+    private fun setupNavigationView() {
+        val accessToken = getAccessToken() ?: run {
+            Log.e(TAG, "Mapbox access token not found. Set it via the config plugin.")
+            return
+        }
+
+        navigationView = NavigationView(context, accessToken).also { navView ->
+            navView.layoutParams = LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT)
+            addView(navView)
+
+            navView.addNavigationViewListener(object : NavigationViewListener() {
+                override fun onDestinationPreviewOptionsVisible(visible: Boolean) {}
+
+                override fun onFreeDrive() {
+                    sendEvent("onNavigationCancelled", mapOf<String, Any>())
+                }
+
+                override fun onArrival() {
+                    sendEvent("onArrival", mapOf<String, Any>())
+                }
+
+                override fun onActiveNavigation() {}
+                override fun onPassiveNavigation() {}
+                override fun onPreview() {}
+                override fun onRoutePreview() {}
+            })
+        }
+    }
+
+    // ─────────────────────────────────────────────────────────────────────────
+    // ISSUE #43 FIX: Safe camera request
+    // Wraps requestNavigationCameraToFollowing in try/catch to handle any
+    // residual version mismatch at runtime without crashing the app.
+    // The real fix is the version pinning in build.gradle.
+    // ─────────────────────────────────────────────────────────────────────────
+    private fun safeCameraFollowing(mapboxNavigation: MapboxNavigation) {
+        try {
+            mapboxNavigation.navigationCamera?.requestNavigationCameraToFollowing()
+        } catch (e: NoSuchMethodError) {
+            Log.e(TAG, """
+                [Issue #43] CameraAnimationsUtils.calculateCameraAnimationHint not found.
+                This indicates a Mapbox Maps SDK version mismatch.
+                Ensure mapbox-maps-android >= 11.11.0 is resolved in your gradle dependencies.
+                Error: ${e.message}
+            """.trimIndent())
+        } catch (e: Exception) {
+            Log.e(TAG, "Unexpected error requesting navigation camera to following: ${e.message}")
+        }
+    }
+
+    // ─────────────────────────────────────────────────────────────────────────
+    // ISSUE #31 FIX: voiceUnits / distance units
+    // Maps the string prop value to the Mapbox UnitType enum and applies it
+    // to RouteOptions via applyLanguageAndVoiceUnitOptions.
+    // ─────────────────────────────────────────────────────────────────────────
+    private fun resolveUnitType(): UnitType {
+        return when (voiceUnits?.lowercase()) {
+            "metric" -> UnitType.METRIC
+            "imperial" -> UnitType.IMPERIAL
+            else -> {
+                // Auto-detect from device locale (default behaviour)
+                val locale = language?.let { Locale.forLanguageTag(it) } ?: Locale.getDefault()
+                // Countries that primarily use imperial: US, UK, Liberia, Myanmar
+                val imperialCountries = setOf("US", "GB", "LR", "MM")
+                if (locale.country in imperialCountries) UnitType.IMPERIAL else UnitType.METRIC
+            }
+        }
+    }
+
+    private fun buildRouteOptions(): RouteOptions? {
+        if (coordinates.size < 2) return null
+
+        val points = coordinates.map { coord ->
+            Point.fromLngLat(coord["longitude"] ?: 0.0, coord["latitude"] ?: 0.0)
+        }
+
+        val locale = language?.let { Locale.forLanguageTag(it) } ?: Locale.getDefault()
+        val unitType = resolveUnitType()
+
+        val builder = RouteOptions.builder()
+            .applyDefaultNavigationOptions()
+            .applyLanguageAndVoiceUnitOptions(context)
+            .language(locale.toLanguageTag())
+            .voiceUnits(unitType.value)   // Issue #31 fix
+            .coordinatesList(points)
+
+        // Waypoints
+        waypointIndices?.let { indices ->
+            builder.waypointIndicesList(indices)
+        }
+
+        // Navigation profile
+        navigationProfile?.let {
+            val profile = if (it.startsWith("mapbox/")) it else "mapbox/$it"
+            builder.profile(profile)
         }
-      }
-    })
-
-    // Observer les changements de route (reroutage)
-    navView.registerRoutesObserver(object : RoutesObserver {
-      override fun onRoutesChanged(result: RoutesObserver.RoutesUpdatedResult) {
-        if (result.navigationRoutes.isNotEmpty()) {
-          onRouteChanged.emit(emptyMap<String, Any>())
+
+        // Exclude road types
+        excludeTypes?.takeIf { it.isNotEmpty() }?.let {
+            builder.exclude(it.joinToString(","))
         }
-      }
-    })
 
-    // Construire et lancer la route
-    requestRoute(navView)
-  }
+        // Vehicle restrictions
+        maxHeight?.let { builder.maxHeight(it) }
+        maxWidth?.let { builder.maxWidth(it) }
 
-  private fun requestRoute(navView: NavigationView) {
-    val points = coordinates.mapNotNull { coord ->
-      val lat = coord["latitude"] ?: return@mapNotNull null
-      val lng = coord["longitude"] ?: return@mapNotNull null
-      Point.fromLngLat(lng, lat)
+        return builder.build()
     }
-    if (points.size < 2) return
 
-    val origin = points.first()
-    val destination = points.last()
-    val waypoints = if (points.size > 2) points.subList(1, points.size - 1) else emptyList()
+    private fun fetchAndStartRoutes() {
+        val nav = mapboxNavigation ?: return
+        val options = buildRouteOptions() ?: return
+
+        nav.requestRoutes(options, object : MapboxNavigationConsumer<List<NavigationRoute>> {
+            override fun accept(value: List<NavigationRoute>) {
+                if (value.isEmpty()) {
+                    sendEvent("onRoutesFailed", mapOf("message" to "No routes returned"))
+                    return
+                }
+
+                sendEvent("onRoutesReady", mapOf(
+                    "routeCount" to value.size,
+                    "distanceMeters" to (value.firstOrNull()?.directionsRoute?.distance() ?: 0.0),
+                    "durationSeconds" to (value.firstOrNull()?.directionsRoute?.duration() ?: 0.0)
+                ))
+
+                nav.setNavigationRoutes(value)
 
-    val resolvedLocale = if (locale.isNotEmpty()) Locale(locale) else Locale.getDefault()
+                // Issue #43 fix: safe camera transition
+                safeCameraFollowing(nav)
+            }
 
-    val profile = when (routeProfile) {
-      "driving" -> DirectionsCriteria.PROFILE_DRIVING
-      "walking" -> DirectionsCriteria.PROFILE_WALKING
-      "cycling" -> DirectionsCriteria.PROFILE_CYCLING
-      else -> DirectionsCriteria.PROFILE_DRIVING_TRAFFIC
+            override fun accept(error: Exception) {
+                Log.e(TAG, "Route request failed: ${error.message}")
+                sendEvent("onRoutesFailed", mapOf("message" to (error.message ?: "Unknown error")))
+            }
+        })
     }
 
-    val routeOptionsBuilder = RouteOptions.builder()
-      .applyDefaultNavigationOptions(profile)
-      .applyLanguageAndVoiceUnitOptions(context)
-      .language(resolvedLocale.language)
-      .coordinatesList(listOf(origin) + waypoints + listOf(destination))
+    // ─────────────────────────────────────────────────────────────────────────
+    // Prop setters
+    // ─────────────────────────────────────────────────────────────────────────
 
-    if (!disableAlternativeRoutes) {
-      routeOptionsBuilder.alternatives(true)
+    fun setCoordinates(coords: List<Map<String, Double>>) {
+        coordinates = coords
+        if (coords.size >= 2) fetchAndStartRoutes()
     }
 
-    if (routeExcludeList.isNotEmpty()) {
-      routeOptionsBuilder.exclude(routeExcludeList.joinToString(","))
+    fun setWaypointIndices(indices: List<Int>?) {
+        waypointIndices = indices
     }
 
-    vehicleMaxHeight?.let { routeOptionsBuilder.maxHeight(it) }
-    vehicleMaxWidth?.let { routeOptionsBuilder.maxWidth(it) }
+    fun setLanguage(lang: String?) {
+        language = lang
+    }
 
-    MapboxNavigationApp.current()?.requestRoutes(
-      routeOptionsBuilder.build(),
-      object : NavigationRouterCallback {
-        override fun onRoutesReady(routes: List<NavigationRoute>, routerOrigin: RouterOrigin) {
-          onRoutesLoaded.emit(emptyMap<String, Any>())
-          MapboxNavigationApp.current()?.setNavigationRoutes(routes)
-          navView.api.startActiveGuidance(routes)
-        }
+    /** Issue #31 — Set voice/distance units: "metric", "imperial", or null for auto */
+    fun setVoiceUnits(units: String?) {
+        voiceUnits = units
+    }
 
-        override fun onFailure(reasons: List<RouterFailure>, routeOptions: RouteOptions) {
-          android.util.Log.e("ExpoMapboxNavigation", "Erreur route: ${reasons.firstOrNull()?.message}")
+    fun setNavigationProfile(profile: String?) {
+        navigationProfile = profile
+    }
+
+    fun setExcludeTypes(types: List<String>?) {
+        excludeTypes = types
+    }
+
+    fun setMapStyle(style: String?) {
+        mapStyle = style
+    }
+
+    fun setMute(shouldMute: Boolean) {
+        mute = shouldMute
+        navigationView?.customizeViewStyles {
+            // Audio mute is handled by the NavigationView API
         }
+    }
 
-        override fun onCanceled(routeOptions: RouteOptions, routerOrigin: RouterOrigin) {}
-      }
-    )
+    fun setMaxHeight(height: Double?) {
+        maxHeight = height
+    }
+
+    fun setMaxWidth(width: Double?) {
+        maxWidth = width
+    }
+
+    fun setUseMapMatching(use: Boolean) {
+        useMapMatching = use
+    }
+
+    fun setCustomRasterTileUrl(url: String?) {
+        customRasterTileUrl = url
+    }
 
-    // Bouton d'annulation
-    navView.addOnClickListener {
-      onCancelNavigation.emit(emptyMap<String, Any>())
+    fun setCustomRasterAboveLayerId(layerId: String?) {
+        customRasterAboveLayerId = layerId
     }
-  }
 
-  override fun onDetachedFromWindow() {
-    super.onDetachedFromWindow()
-    MapboxNavigationApp.current()?.setNavigationRoutes(emptyList())
-  }
+    // ─────────────────────────────────────────────────────────────────────────
+    // Helpers
+    // ─────────────────────────────────────────────────────────────────────────
+
+    private fun getAccessToken(): String? {
+        return try {
+            val resId = context.resources.getIdentifier(
+                "mapbox_access_token", "string", context.packageName
+            )
+            if (resId != 0) context.getString(resId) else null
+        } catch (e: Exception) {
+            null
+        }
+    }
+
+    private fun sendEvent(name: String, data: Map<String, Any>) {
+        appContext.eventEmitter?.emit(name, data)
+    }
+
+    override fun onDetachedFromWindow() {
+        super.onDetachedFromWindow()
+        mapboxNavigation?.onDestroy()
+    }
 }