@jacobknightley/fabric-format 0.0.8 → 0.0.9

package/dist/formatters/python/config.d.ts

@@ -42,8 +42,16 @@ export declare const RUFF_WASM_CONFIG: {
  *   These would incorrectly flag code that's used in other cells.
  * - Import-adding rules (RUF017, SIM105, PLR1722, PTH*)
  *   These would add imports without knowing if they're already imported elsewhere.
+ * - PySpark incompatible rules (E712 true-false-comparison)
+ *   E712 transforms Column boolean comparisons (e.g., `col != True` -> `not col`)
+ *   which breaks PySpark's operator overloading. See regression tests for details.
  *
  * All included rules perform in-cell syntactic transformations only.
+ *
+ * PySpark Compatibility Note:
+ * Other rules like SIM210/211 (bool() coercion) and SIM220/221 (logical simplification)
+ * theoretically could affect Column objects, but either don't have auto-fixes or don't
+ * trigger on PySpark patterns in practice. E712 is the only rule known to cause issues.
  */
 export declare const SAFE_LINT_RULES: string[];
 /** Ruff WASM lint config for safe auto-fixes */

package/dist/formatters/python/config.js

@@ -38,8 +38,16 @@ export const RUFF_WASM_CONFIG = {
  *   These would incorrectly flag code that's used in other cells.
  * - Import-adding rules (RUF017, SIM105, PLR1722, PTH*)
  *   These would add imports without knowing if they're already imported elsewhere.
+ * - PySpark incompatible rules (E712 true-false-comparison)
+ *   E712 transforms Column boolean comparisons (e.g., `col != True` -> `not col`)
+ *   which breaks PySpark's operator overloading. See regression tests for details.
  *
  * All included rules perform in-cell syntactic transformations only.
+ *
+ * PySpark Compatibility Note:
+ * Other rules like SIM210/211 (bool() coercion) and SIM220/221 (logical simplification)
+ * theoretically could affect Column objects, but either don't have auto-fixes or don't
+ * trigger on PySpark patterns in practice. E712 is the only rule known to cause issues.
  */
 export const SAFE_LINT_RULES = [
     // I - isort (import sorting within cell)
@@ -105,7 +113,11 @@ export const SAFE_LINT_RULES = [
     'E401', // multiple-imports-on-one-line
     'E703', // useless-semicolon
     'E711', // none-comparison
-    'E712', // true-false-comparison
+    // NOTE: E712 (true-false-comparison) excluded - causes PySpark incompatibility.
+    // Transforms `F.col("Active") != True` to `not F.col("Active")` and
+    // `F.col("status") == False` to `not F.col("status")`, which doesn't work
+    // with PySpark Column objects that require explicit comparison operators.
+    // See regression tests in tests/python/regression-bugs.test.ts
     'E713', // not-in-test
     'E714', // not-is-test
     // F - Pyflakes (only cell-safe rules)

package/dist/formatters/sparksql/generated/SqlBaseParser.d.ts

@@ -173,7 +173,8 @@ declare class SqlBaseParser extends antlr4.Parser {
     functionTableNamedArgumentExpression(): FunctionTableNamedArgumentExpressionContext;
     functionTableReferenceArgument(): FunctionTableReferenceArgumentContext;
     functionTableArgument(): FunctionTableArgumentContext;
-    functionTable(): FunctionTableContext;
+    tableFunctionCall(): TableFunctionCallContext;
+    tableFunctionCallWithTrailingClauses(): TableFunctionCallWithTrailingClausesContext;
     tableAlias(): TableAliasContext;
     rowFormat(): RowFormatContext;
     multipartIdentifierList(): MultipartIdentifierListContext;
@@ -919,7 +920,8 @@ declare namespace SqlBaseParser {
     export let RULE_functionTableNamedArgumentExpression: number;
     export let RULE_functionTableReferenceArgument: number;
     export let RULE_functionTableArgument: number;
-    export let RULE_functionTable: number;
+    export let RULE_tableFunctionCall: number;
+    export let RULE_tableFunctionCallWithTrailingClauses: number;
     export let RULE_tableAlias: number;
     export let RULE_rowFormat: number;
     export let RULE_multipartIdentifierList: number;
@@ -1130,6 +1132,7 @@ declare namespace SqlBaseParser {
     export { CacheTableContext };
     export { AddTableColumnsContext };
     export { SetTablePropertiesContext };
+    export { StreamTableValuedFunctionContext };
     export { StreamTableNameContext };
     export { SetQuotedConfigurationContext };
     export { ResetQuotedConfigurationContext };
@@ -1406,7 +1409,8 @@ declare namespace SqlBaseParser {
     export { FunctionTableNamedArgumentExpressionContext };
     export { FunctionTableReferenceArgumentContext };
     export { FunctionTableArgumentContext };
-    export { FunctionTableContext };
+    export { TableFunctionCallContext };
+    export { TableFunctionCallWithTrailingClausesContext };
     export { TableAliasContext };
     export { RowFormatContext };
     export { MultipartIdentifierListContext };
@@ -3482,22 +3486,32 @@ declare class FunctionTableArgumentContext {
     exitRule(listener: any): void;
     accept(visitor: any): any;
 }
-declare class FunctionTableContext {
+declare class TableFunctionCallContext {
     constructor(parser: any, parent: any, invokingState: any);
     parser: any;
     ruleIndex: number;
     funcName: any;
     LEFT_PAREN(): any;
     RIGHT_PAREN(): any;
-    tableAlias(): any;
     functionName(): any;
     functionTableArgument: (i: any) => any;
-    watermarkClause(): any;
     COMMA: (i: any) => any;
     enterRule(listener: any): void;
     exitRule(listener: any): void;
     accept(visitor: any): any;
 }
+declare class TableFunctionCallWithTrailingClausesContext {
+    constructor(parser: any, parent: any, invokingState: any);
+    parser: any;
+    ruleIndex: number;
+    tableFunctionCall(): any;
+    tableAlias(): any;
+    identifiedByClause(): any;
+    watermarkClause(): any;
+    enterRule(listener: any): void;
+    exitRule(listener: any): void;
+    accept(visitor: any): any;
+}
 declare class TableAliasContext {
     constructor(parser: any, parent: any, invokingState: any);
     parser: any;
@@ -4907,7 +4921,7 @@ declare class OperatorPipeRightSideContext {
     SET(): any;
     operatorPipeSetAssignmentSeq(): any;
     DROP(): any;
-    identifierSeq(): any;
+    multipartIdentifierList(): any;
     AS(): any;
     errorCapturingIdentifier(): any;
     whereClause(): any;
@@ -6874,6 +6888,20 @@ declare class SetTablePropertiesContext extends StatementContext {
     exitRule(listener: any): void;
     accept(visitor: any): any;
 }
+declare class StreamTableValuedFunctionContext extends StreamRelationPrimaryContext {
+    constructor(parser: any, ctx: any);
+    STREAM(): any;
+    tableFunctionCallWithTrailingClauses(): any;
+    LEFT_PAREN(): any;
+    tableFunctionCall(): any;
+    RIGHT_PAREN(): any;
+    tableAlias(): any;
+    identifiedByClause(): any;
+    watermarkClause(): any;
+    enterRule(listener: any): void;
+    exitRule(listener: any): void;
+    accept(visitor: any): any;
+}
 declare class StreamTableNameContext extends StreamRelationPrimaryContext {
     constructor(parser: any, ctx: any);
     STREAM(): any;
@@ -7322,7 +7350,7 @@ declare class StreamRelationContext extends RelationPrimaryContext {
 }
 declare class TableValuedFunctionContext extends RelationPrimaryContext {
     constructor(parser: any, ctx: any);
-    functionTable(): any;
+    tableFunctionCallWithTrailingClauses(): any;
     enterRule(listener: any): void;
     exitRule(listener: any): void;
     accept(visitor: any): any;