@jacebenson/jsn 4.3.7-dev.38 → 4.3.7-dev.39

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacebenson/jsn",
-  "version": "4.3.7-dev.38",
+  "version": "4.3.7-dev.39",
   "description": "A command-line interface for ServiceNow that follows the Unix philosophy: simple, composable, and scriptable.",
   "type": "module",
   "bin": {

package/src/flow-create.js

@@ -230,14 +230,20 @@ export async function readActionDefinition(sdk, instance, actionTypeId, scope, {
   return { definition, schema };
 }
 
-function buildTypedInputs(action, schema) {
+export function buildTypedInputs(action, schema) {
   const supplied = action.inputs || {};
-  const allowed = new Set(schema.map(field => field.name));
+  const allowed = new Set(schema.map(field => field?.name).filter(Boolean));
   for (const key of Object.keys(supplied)) if (!allowed.has(key)) throw new Error(`Unsupported input "${key}" for action ${action.type}`);
   return schema.map(field => {
-    if (!field || typeof field !== 'object' || !field.id || !field.parameter || typeof field.parameter !== 'object') {
+    // The instance's own definition is the contract: identity is required,
+    // everything else (including an optional `parameter` block) is echoed back
+    // untouched. Demanding a key the provider omits breaks real actions.
+    if (!field || typeof field !== 'object' || !field.id || !field.name) {
       throw new Error(`Action ${action.type} returned an incomplete input schema; refusing to invent input metadata for "${field?.name || 'unknown'}"`);
     }
+    if (field.parameter !== undefined && (typeof field.parameter !== 'object' || field.parameter === null || Array.isArray(field.parameter))) {
+      throw new Error(`Action ${action.type} input "${field.name}" has a malformed parameter block; refusing to change it`);
+    }
     const suppliedValue = Object.prototype.hasOwnProperty.call(supplied, field.name) ? supplied[field.name] : field.default;
     if ((suppliedValue === undefined || suppliedValue === null) && (field.mandatory === true || field.required === true)) throw new Error(`Missing required input "${field.name}" for action ${action.type}`);
     const value = suppliedValue ?? null;

package/src/flow-designer-interactive.js

@@ -265,8 +265,8 @@ export async function guidedFlowCreate(argv, app) {
     const { schema } = await readActionDefinition(app.sdk, app.getEffectiveInstance(), id, manifest.scope, { requireTypes: true });
     const inputs = {};
     for (const field of schema) {
-      if (!field.id || !field.parameter || typeof field.parameter !== 'object' || Array.isArray(field.parameter)) {
-        throw errUsage(`Published action input ${field.name} lacks provider id/parameter metadata; no flow was allocated`);
+      if (!field.id || !field.name) {
+        throw errUsage(`Published action input ${field.name || 'unknown'} lacks the provider identity needed to bind a value; no flow was allocated`);
       }
       inputs[field.name] = await promptSchemaValue(app, field, field.default, 'Action input: ');
     }