@jacebenson/jsn 4.3.7-dev.30 → 4.3.7-dev.32

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacebenson/jsn",
-  "version": "4.3.7-dev.30",
+  "version": "4.3.7-dev.32",
   "description": "A command-line interface for ServiceNow that follows the Unix philosophy: simple, composable, and scriptable.",
   "type": "module",
   "bin": {

package/src/commands/midservers.js

@@ -17,7 +17,7 @@ declareCapabilities('midservers', { mutationSubcommands: ['add', 'remove', 'exec
 
 function agentName(record) {
   const name = getStringField(record, 'name');
-  return name.startsWith('mid.server.') ? name : `mid.server.${name}`;
+  return `mid.server.${name}`;
 }
 
 function queueValue(value) {
@@ -150,8 +150,8 @@ export function assertMidServerUp(record) {
 export function assertMidServerReady(record) {
   assertMidServerUp(record);
   const name = getStringField(record, 'name') || getStringField(record, 'sys_id') || 'MID Server';
-  const validated = getStringField(record, 'validated').toLowerCase();
-  if (validated !== 'validated') {
+  const validated = queueValue(record.validated).toLowerCase();
+  if (validated !== 'true') {
     const error = new Error(`MID Server '${name}' is not validated yet (validation: ${validated || 'unknown'}). Wait for ServiceNow validation to complete before executing a command.`);
     error.code = 'midserver_not_validated';
     throw error;
@@ -186,9 +186,9 @@ async function promptMidCredentials(app, argv) {
   }
 }
 
-async function waitForMidServerUp(app, name, timeoutMs, intervalMs) {
+export async function waitForMidServerUp(app, name, timeoutMs, intervalMs) {
   const started = Date.now();
-  const fullName = `mid.server.${name.replace(/^mid\.server\./, '')}`;
+  const fullName = name;
   while (Date.now() - started <= timeoutMs) {
     const params = new URLSearchParams({
       sysparm_query: `name=${fullName}`,
@@ -457,12 +457,21 @@ export function midserversCmd(wrap) {
           const responseError = getStringField(response, 'error');
           if (responseError) throw new Error(`MID Server command failed: ${responseError}`);
           const result = parseCommandResult(queueValue(response.payload));
+          const responseSysId = unwrapSysId(response);
+          const responseURL = responseSysId
+            ? new URL(`/ecc_queue.do?sys_id=${encodeURIComponent(responseSysId)}`, app.getEffectiveInstance()).href
+            : '';
+          const summary = `Executed command on MID Server '${getStringField(record, 'name')}'`;
+          const lines = [summary, '', result.stdout || '(no stdout)'];
+          if (result.stderr) lines.push('', 'stderr:', result.stderr);
+          if (responseURL) lines.push('', `ECC input: ${responseURL}`);
           app.ok({
             mid_server: getStringField(record, 'name'),
             command,
             output: { sys_id: outputSysId, ...output },
-            response: { ...response, ...result },
-          }, { summary: `Executed command on MID Server '${getStringField(record, 'name')}'` });
+            response: { ...response, ...result, url: responseURL },
+            _formatted: `${lines.join('\n')}\n`,
+          }, { summary });
         }),
       }),
     handler: () => {

package/src/midserver-install.js

@@ -108,7 +108,7 @@ export async function installDockerMidServer({
 }) {
   const dockerAvailable = detectDocker(run).available;
   const shortName = normalizeMidName(name);
-  const displayName = `mid.server.${shortName}`;
+  const displayName = shortName;
   const releaseName = suppliedReleaseName || (await validateMidCredentials(instanceURL, username, password, fetchImpl)).releaseName;
   const recipeURL = buildMidRecipeUrl(releaseName);
   const installDir = directory || midInstallDirectory(instanceURL, name);