@jacebenson/jsn 4.3.6 → 4.3.7-dev.12

package/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2026 Jace Benson
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -193,7 +193,7 @@ npm install
 npm test
 ```
 
-Releases are manual. After changes land on `main`, run `npm run release -- patch` (or `minor`, `major`) to test, bump the version, and push the commit and tag. When ready, publish to npm with `npm publish --access public`. Git tags mark releases; GitHub Release entries are not required.
+Releases run from the GitHub Actions workflow. Dispatch `Release production` with `patch`, `minor`, or `major`. The workflow tests and lints the repo, bumps the version, pushes the commit and tag, dispatches the npm publish workflow, and creates the GitHub release.
 
 ## License
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacebenson/jsn",
-  "version": "4.3.6",
+  "version": "4.3.7-dev.12",
   "description": "A command-line interface for ServiceNow that follows the Unix philosophy: simple, composable, and scriptable.",
   "type": "module",
   "bin": {
@@ -12,9 +12,7 @@
     "lint": "npx eslint src/ bin/ test/",
     "start": "node bin/jsn.js",
     "docs": "npm --prefix docs run build",
-    "docs:serve": "npm --prefix docs run serve",
-    "tag-reminder": "node scripts/tag-reminder.js",
-    "release": "node scripts/release.js"
+    "docs:serve": "npm --prefix docs run serve"
   },
   "keywords": [
     "servicenow",
@@ -43,7 +41,6 @@
     "bin/jsn.js",
     "src/",
     "skills/",
-    "scripts/",
     "README.md",
     "LICENSE"
   ]

package/skills/servicenow/SKILL.md

@@ -14,7 +14,7 @@ compatibility: |
   Works with Claude Code, OpenCode, Cursor, and agentskills-compatible tools.
 metadata:
   author: jacebenson
-  version: "4.0.0"
+  version: "4.3.6"
   repository: https://github.com/jacebenson/jsn
 ---
 
@@ -65,7 +65,7 @@ Pick the most specific tool for the job. **Never default to eval** — it's the
 |--------|---------|
 | **Core** | `incidents`, `changes`, `requests`, `tasks` |
 | **Catalog** | `catalogitems list/show/create` — items with variables and flow info |
-| **Automation** | `flows`, `actions`, `rules`, `workflows`, `triggers`, `scheduledjobs` |
+| **Automation** | `flows`, `actions`, `rules`, `triggers`, `scheduledjobs` |
 | **Access** | `acls`, `b4rules`, `roles`, `groups`, `users` |
 | **UX** | `forms` (section/element layout), `lists`, `clientscripts`, `uipolicies` |
 | **Data** | `tables`, `columns`, `includes`, `logs`, `properties`, `records` |
@@ -73,16 +73,16 @@ Pick the most specific tool for the job. **Never default to eval** — it's the
 | **Docs** | `docs sync`, `docs status`, `docs search`, `docs serve` |
 | **Developer** | `eval`, `rest`, `skill`, `version` |
 
-### `jsn rest` examples
+### Table and raw REST examples
 
 ```bash
-# Query any table by name
-jsn rest --table incident --query "active=true" --limit 5 --json
+# Query a table with the normal records command
+jsn records list --table incident --query "active=true" --limit 5 --json
 
-# GET a single record
-jsn rest --table incident --sys-id abc123... --json
+# Get a single record
+jsn records get --table incident --sys-id abc123... --json
 
-# Raw endpoint access
+# Raw endpoint access when no specific command fits
 jsn rest "/api/now/table/incident?sysparm_limit=3" --json
 ```
 
@@ -106,8 +106,6 @@ jsn docs search "REST API" --bundle it-service-management --json
 # Start the web UI
 jsn docs serve
 
-# Share on your network
-jsn docs serve --expose
 ```
 
 **Re-running `jsn docs sync`** does a smart incremental refresh — pulls latest docs and only rebuilds changed files (seconds, not minutes).
@@ -129,5 +127,5 @@ Check order (priority):
 ```
 ~/.config/servicenow/
 ├── config.json               # Profiles and settings
-└── credentials.json          # Auth tokens (fallback)
+└── credentials/              # Auth tokens (fallback, one file per key)
 ```

package/src/commands/catalog/enrich.js

@@ -68,7 +68,6 @@ export async function enrichCatalogItem({ sdk, instanceUrl, sysID }) {
     flowCmd = `jsn flows show ${flowVal.value}`;
   }
   const wfName = getStringField(item, 'workflow') || '';
-  const wfID = item.workflow?.value || '';
   const planName = getStringField(item, 'delivery_plan') || getStringField(item, 'execution_plan') || '';
 
   const data = {
@@ -80,7 +79,7 @@ export async function enrichCatalogItem({ sdk, instanceUrl, sysID }) {
     flow: flowName || undefined,
     flow_cmd: flowCmd || undefined,
     workflow: wfName || undefined,
-    workflow_cmd: (wfName && wfID) ? `jsn workflows show ${wfID}` : undefined,
+
     execution_plan: planName || undefined,
     variables: totalVars > 0 ? {
       count: totalVars,
@@ -117,7 +116,6 @@ export function buildCatalogFormatted(data, standalone, setVars, totalVars) {
   if (data.workflow) {
     lines.push('─ Workflow ─');
     lines.push(`  ${data.workflow}`);
-    if (data.workflow_cmd) lines.push(`  → ${data.workflow_cmd}`);
     lines.push('');
   }
   if (totalVars > 0) {

package/src/commands/perf.js

@@ -1,5 +1,6 @@
 import { errUsageHint, errUsage } from '../errors.js';
 import { captureRun, listRuns, getRun, compareRuns, formatRunDetailed, formatRunList, formatComparisonDetailed } from '../perf.js';
+import { topTransactionsCmd } from './transactions.js';
 import { paginatedSearch } from '../paginated-search.js';
 
 function pickerEnabled(app) {
@@ -107,6 +108,11 @@ export function perfCmd(wrap) {
           });
         }),
       })
+      .command({
+        command: 'transactions [subcommand]',
+        describe: 'Inspect Client Transaction Timings',
+        builder: (b) => b.command(topTransactionsCmd(wrap)),
+      })
       .command({
         command: 'compare [baseline] [new]',
         describe: 'Compare exactly two saved captures',

package/src/commands/transactions.js

@@ -39,6 +39,7 @@ export function classifyTransactionType(type, url = '') {
 }
 
 function numericValue(value) {
+  if (value == null || String(value).trim() === '') return null;
   const n = Number(String(value ?? '').replaceAll(',', ''));
   return Number.isFinite(n) ? n : null;
 }
@@ -65,6 +66,83 @@ function summarizeGroup(group) {
   };
 }
 
+function topQuery(argv = {}) {
+  const parts = [];
+  if (argv.query) parts.push(String(argv.query));
+  for (const field of ['type', 'table', 'view']) if (argv[field]) parts.push(`${field}=${argv[field]}`);
+  if (argv.window != null && String(argv.window) !== '') {
+    const days = Math.max(1, Math.min(30, Number(argv.window) || 1));
+    parts.push(`sys_created_on>=javascript:gs.daysAgoStart(${days})`);
+  }
+  if (argv.since) parts.push(`sys_created_on>=${argv.since}`);
+  if (argv.until) parts.push(`sys_created_on<=${argv.until}`);
+  return normalizeTransactionQuery(parts.join('^'));
+}
+
+function topGroup(group) {
+  const stats = group?.stats || {};
+  return {
+    type: groupValue(group, 'type') || 'unavailable',
+    table: groupValue(group, 'table') || 'unavailable',
+    view: groupValue(group, 'view') || 'unavailable',
+    count: numericValue(stats.count) ?? 0,
+    avg_response_time_ms: metricValue(stats, 'avg', 'response_time'),
+    min_response_time_ms: metricValue(stats, 'min', 'response_time'),
+    max_response_time_ms: metricValue(stats, 'max', 'response_time'),
+  };
+}
+
+function formatTopTransactions(groups) {
+  const value = metric => metric == null ? 'unavailable' : `${Math.round(metric * 100) / 100} ms`;
+  const lines = [
+    'TYPE         TABLE              VIEW             COUNT  AVG          MIN          MAX',
+    '-----------  -----------------  ---------------  -----  -----------  -----------  -----------',
+  ];
+  for (const row of groups) lines.push(`${String(row.type).slice(0, 11).padEnd(11)}  ${String(row.table).slice(0, 17).padEnd(17)}  ${String(row.view).slice(0, 15).padEnd(15)}  ${String(row.count).padStart(5)}  ${value(row.avg_response_time_ms).padEnd(11)}  ${value(row.min_response_time_ms).padEnd(11)}  ${value(row.max_response_time_ms)}`);
+  if (groups.length === 0) lines.push('(no transaction groups)');
+  return `${lines.join('\\n')}\\n`;
+}
+
+export function topTransactionsCmd(wrap) {
+  return {
+    command: 'top',
+    describe: 'Rank Client Transaction Timings by type, table, and view',
+    builder: (y) => y
+      .option('type', { type: 'string', describe: 'Filter transaction type' })
+      .option('table', { type: 'string', describe: 'Filter transaction table' })
+      .option('view', { type: 'string', describe: 'Filter transaction view' })
+      .option('query', { type: 'string', describe: 'Additional encoded query' })
+      .option('window', { type: 'number', default: 1, describe: 'Look back this many days (max 30)' })
+      .option('since', { type: 'string', describe: 'Only records on or after this timestamp' })
+      .option('until', { type: 'string', describe: 'Only records on or before this timestamp' })
+      .option('limit', { alias: 'l', type: 'number', default: 20, describe: 'Maximum groups to return' }),
+    handler: wrap(async (argv, app) => {
+      app.requireInstance();
+      const query = topQuery(argv);
+      const limit = Math.max(1, Math.min(100, Number(argv.limit) || 20));
+      const result = await app.sdk.aggregate('syslog_transaction', {
+        query,
+        groupBy: ['type', 'table', 'view'],
+        count: true,
+        averageFields: ['response_time'],
+        minimumFields: ['response_time'],
+        maximumFields: ['response_time'],
+        orderBy: 'countDESC',
+      });
+      const groups = (Array.isArray(result.groups) ? result.groups : []).map(topGroup).slice(0, limit);
+      app.ok({
+        table: 'syslog_transaction',
+        query,
+        group_by: ['type', 'table', 'view'],
+        response_time_unit: 'ms',
+        groups,
+        _formatted: formatTopTransactions(groups),
+        context: { instance_url: app.getEffectiveInstance() },
+      }, { summary: `Top transaction groups: ${groups.length}` });
+    }),
+  };
+}
+
 export function transactionsCmd(wrap) {
   return {
     command: 'transactions',

package/scripts/pre-commit-check.sh

@@ -1,61 +0,0 @@
-#!/bin/bash
-# pre-commit-check.sh - Run this before committing to check architecture compliance
-
-echo "🔍 Checking architecture patterns..."
-
-# Check for forbidden SDK patterns
-FORBIDDEN_PATTERNS=(
-    "func.*Client.*ListForm"
-    "func.*Client.*ListList"
-    "func.*Client.*GetSP"
-    "func.*Client.*ListSP"
-)
-
-ERRORS=0
-
-for pattern in "${FORBIDDEN_PATTERNS[@]}"; do
-    matches=$(grep -r "$pattern" internal/sdk/*.go 2>/dev/null | grep -v "_test.go" | grep -v "^Binary")
-    if [ ! -z "$matches" ]; then
-        echo "❌ Found forbidden SDK pattern: $pattern"
-        echo "$matches"
-        ERRORS=$((ERRORS + 1))
-    fi
-done
-
-# Check that commands don't import old SDK types
-BAD_IMPORTS=(
-    "sdk.FormSection"
-    "sdk.FormElement"
-    "sdk.ListLayout"
-    "sdk.ListElement"
-    "sdk.SPPage"
-    "sdk.SPWidgetInstance"
-)
-
-for pattern in "${BAD_IMPORTS[@]}"; do
-    matches=$(grep -r "$pattern" internal/commands/**/*.go 2>/dev/null)
-    if [ ! -z "$matches" ]; then
-        echo "❌ Command using SDK type instead of local type: $pattern"
-        echo "$matches"
-        ERRORS=$((ERRORS + 1))
-    fi
-done
-
-# Run architecture tests
-echo "🧪 Running architecture tests..."
-if ! go test ./internal/sdk -run TestNoSDKHelperMethods -run TestCommandsUseDirectSDKList > /dev/null 2>&1; then
-    echo "❌ Architecture tests failed"
-    go test ./internal/sdk -v -run "TestNoSDKHelperMethods|TestCommandsUseDirectSDKList"
-    ERRORS=$((ERRORS + 1))
-fi
-
-if [ $ERRORS -eq 0 ]; then
-    echo "✅ All architecture checks passed!"
-    exit 0
-else
-    echo ""
-    echo "⚠️  Architecture violations found!"
-    echo "   Remember: Commands should call app.SDK.List() directly with local types."
-    echo "   See internal/commands/forms.go for the correct pattern."
-    exit 1
-fi

package/scripts/release.js

@@ -1,62 +0,0 @@
-#!/usr/bin/env node
-import { execSync } from 'child_process';
-import { readFileSync } from 'fs';
-import { fileURLToPath } from 'url';
-import { dirname, join } from 'path';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const pkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf8'));
-
-const type = process.argv[2];
-if (!type || !['patch', 'minor', 'major'].includes(type)) {
-  console.error('Usage: npm run release -- <patch|minor|major>');
-  process.exit(1);
-}
-
-let branch;
-try {
-  branch = execSync('git rev-parse --abbrev-ref HEAD', { encoding: 'utf8' }).trim();
-} catch {
-  console.error('Error: Not in a git repository');
-  process.exit(1);
-}
-
-if (branch !== 'main') {
-  console.error(`Error: Releases can only be made from 'main' branch (currently on '${branch}')`);
-  process.exit(1);
-}
-
-const prefix = 'v';
-
-console.log('');
-console.log(`🚀 Releasing from '${branch}'`);
-console.log(`   Bump: ${type}`);
-console.log('');
-
-// Run tests
-console.log('⏳ Running tests...');
-try {
-  execSync('npm test', { stdio: 'inherit' });
-} catch {
-  console.error('');
-  console.error('❌ Tests failed. Release aborted.');
-  process.exit(1);
-}
-
-// Bump version with correct tag prefix
-console.log('');
-console.log(`⏳ Bumping version (${type})...`);
-execSync(`npm version ${type} --tag-version-prefix=${prefix}`, { stdio: 'inherit' });
-
-// Push commits and tags
-console.log('');
-console.log('⏳ Pushing to origin...');
-execSync('git push && git push --tags', { stdio: 'inherit' });
-
-// Show final state
-const newPkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf8'));
-console.log('');
-console.log('✅ Release complete!');
-console.log(`   Version: ${newPkg.version}`);
-console.log(`   Tag:     ${prefix}${newPkg.version}`);
-console.log('');

package/scripts/tag-reminder.js

@@ -1,30 +0,0 @@
-#!/usr/bin/env node
-import { execSync } from 'child_process';
-import { readFileSync } from 'fs';
-import { fileURLToPath } from 'url';
-import { dirname, join } from 'path';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const pkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf8'));
-
-let branch;
-try {
-  branch = execSync('git rev-parse --abbrev-ref HEAD', { encoding: 'utf8' }).trim();
-} catch {
-  branch = 'unknown';
-}
-
-const version = pkg.version;
-const prefix = 'v';
-
-console.log('');
-console.log('📦 Release Reminder');
-console.log('');
-console.log(`   Current version: ${version}`);
-console.log(`   Current branch:  ${branch}`);
-console.log('');
-console.log('   To create a release tag, run:');
-console.log('');
-console.log(`     git tag ${prefix}${version}`);
-console.log('     git push origin --tags');
-console.log('');