@jacebenson/jsn 4.3.5 → 4.3.6-dev.10

package/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2026 Jace Benson
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -193,7 +193,7 @@ npm install
 npm test
 ```
 
-Releases are manual. After changes land on `main`, run `npm run release -- patch` (or `minor`, `major`) to test, bump the version, and push the commit and tag. When ready, publish to npm with `npm publish --access public`. Git tags mark releases; GitHub Release entries are not required.
+Releases run from the GitHub Actions workflow. Dispatch `Release production` with `patch`, `minor`, or `major`. The workflow tests and lints the repo, bumps the version, pushes the commit and tag, dispatches the npm publish workflow, and creates the GitHub release.
 
 ## License
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacebenson/jsn",
-  "version": "4.3.5",
+  "version": "4.3.6-dev.10",
   "description": "A command-line interface for ServiceNow that follows the Unix philosophy: simple, composable, and scriptable.",
   "type": "module",
   "bin": {
@@ -12,9 +12,7 @@
     "lint": "npx eslint src/ bin/ test/",
     "start": "node bin/jsn.js",
     "docs": "npm --prefix docs run build",
-    "docs:serve": "npm --prefix docs run serve",
-    "tag-reminder": "node scripts/tag-reminder.js",
-    "release": "node scripts/release.js"
+    "docs:serve": "npm --prefix docs run serve"
   },
   "keywords": [
     "servicenow",
@@ -43,7 +41,6 @@
     "bin/jsn.js",
     "src/",
     "skills/",
-    "scripts/",
     "README.md",
     "LICENSE"
   ]

package/skills/servicenow/SKILL.md

@@ -14,7 +14,7 @@ compatibility: |
   Works with Claude Code, OpenCode, Cursor, and agentskills-compatible tools.
 metadata:
   author: jacebenson
-  version: "4.0.0"
+  version: "4.3.6"
   repository: https://github.com/jacebenson/jsn
 ---
 
@@ -65,7 +65,7 @@ Pick the most specific tool for the job. **Never default to eval** — it's the
 |--------|---------|
 | **Core** | `incidents`, `changes`, `requests`, `tasks` |
 | **Catalog** | `catalogitems list/show/create` — items with variables and flow info |
-| **Automation** | `flows`, `actions`, `rules`, `workflows`, `triggers`, `scheduledjobs` |
+| **Automation** | `flows`, `actions`, `rules`, `triggers`, `scheduledjobs` |
 | **Access** | `acls`, `b4rules`, `roles`, `groups`, `users` |
 | **UX** | `forms` (section/element layout), `lists`, `clientscripts`, `uipolicies` |
 | **Data** | `tables`, `columns`, `includes`, `logs`, `properties`, `records` |
@@ -73,16 +73,16 @@ Pick the most specific tool for the job. **Never default to eval** — it's the
 | **Docs** | `docs sync`, `docs status`, `docs search`, `docs serve` |
 | **Developer** | `eval`, `rest`, `skill`, `version` |
 
-### `jsn rest` examples
+### Table and raw REST examples
 
 ```bash
-# Query any table by name
-jsn rest --table incident --query "active=true" --limit 5 --json
+# Query a table with the normal records command
+jsn records list --table incident --query "active=true" --limit 5 --json
 
-# GET a single record
-jsn rest --table incident --sys-id abc123... --json
+# Get a single record
+jsn records get --table incident --sys-id abc123... --json
 
-# Raw endpoint access
+# Raw endpoint access when no specific command fits
 jsn rest "/api/now/table/incident?sysparm_limit=3" --json
 ```
 
@@ -106,8 +106,6 @@ jsn docs search "REST API" --bundle it-service-management --json
 # Start the web UI
 jsn docs serve
 
-# Share on your network
-jsn docs serve --expose
 ```
 
 **Re-running `jsn docs sync`** does a smart incremental refresh — pulls latest docs and only rebuilds changed files (seconds, not minutes).
@@ -129,5 +127,5 @@ Check order (priority):
 ```
 ~/.config/servicenow/
 ├── config.json               # Profiles and settings
-└── credentials.json          # Auth tokens (fallback)
+└── credentials/              # Auth tokens (fallback, one file per key)
 ```

package/src/commands/catalog/enrich.js

@@ -68,7 +68,6 @@ export async function enrichCatalogItem({ sdk, instanceUrl, sysID }) {
     flowCmd = `jsn flows show ${flowVal.value}`;
   }
   const wfName = getStringField(item, 'workflow') || '';
-  const wfID = item.workflow?.value || '';
   const planName = getStringField(item, 'delivery_plan') || getStringField(item, 'execution_plan') || '';
 
   const data = {
@@ -80,7 +79,7 @@ export async function enrichCatalogItem({ sdk, instanceUrl, sysID }) {
     flow: flowName || undefined,
     flow_cmd: flowCmd || undefined,
     workflow: wfName || undefined,
-    workflow_cmd: (wfName && wfID) ? `jsn workflows show ${wfID}` : undefined,
+
     execution_plan: planName || undefined,
     variables: totalVars > 0 ? {
       count: totalVars,
@@ -117,7 +116,6 @@ export function buildCatalogFormatted(data, standalone, setVars, totalVars) {
   if (data.workflow) {
     lines.push('─ Workflow ─');
     lines.push(`  ${data.workflow}`);
-    if (data.workflow_cmd) lines.push(`  → ${data.workflow_cmd}`);
     lines.push('');
   }
   if (totalVars > 0) {

package/src/commands/updatesets.js

@@ -88,14 +88,144 @@ export async function resolveUpdateSetByName(app, name) {
   throw errUsage(`Multiple update sets named "${name}" (${records.length}): ${scopes}.${scopeNote}\nRun bare "jsn updatesets set" and pick by scope.`);
 }
 
+
+function rawReferenceId(value) {
+  if (!value) return '';
+  if (typeof value === 'object') return String(value.value || value.sys_id || '');
+  return String(value);
+}
+
+function referenceName(value) {
+  if (!value) return '';
+  if (typeof value === 'object') return String(value.display_value || value.name || value.value || value.sys_id || '');
+  return String(value);
+}
+
+function updateSetApplication(record) {
+  const appName = getStringField(record, 'application') || '';
+  const scopeName = getStringField(record, 'application.scope') || '';
+  return appName && scopeName ? `${appName}/${scopeName}` : (appName || scopeName || '?');
+}
+
+function updateSetHierarchyRow(record, { depth, kind, selected = false, missing = false } = {}) {
+  return {
+    sys_id: getStringField(record, 'sys_id'),
+    name: getStringField(record, 'name') || referenceName(record),
+    state: getStringField(record, 'state') || '?',
+    application: updateSetApplication(record),
+    scope: updateSetApplication(record),
+    parent: referenceName(record.parent),
+    depth,
+    kind,
+    selected,
+    missing,
+  };
+}
+
+async function fetchUpdateSetById(app, sysID) {
+  if (!sysID) return null;
+  const params = new URLSearchParams();
+  params.set('sysparm_query', `sys_id=${sysID}`);
+  params.set('sysparm_limit', '1');
+  params.set('sysparm_display_value', 'all');
+  params.set('sysparm_fields', 'sys_id,name,state,application,application.scope,parent,description,sys_created_on,sys_updated_on');
+  const records = await app.sdk.list('sys_update_set', params);
+  return Array.isArray(records) && records.length > 0 ? records[0] : null;
+}
+
+/** Build a safe, flat preorder hierarchy with ancestors before the selected set. */
+export async function buildUpdateSetHierarchy(app, selectedRecord) {
+  const selectedID = getStringField(selectedRecord, 'sys_id');
+  const visited = new Set(selectedID ? [selectedID] : []);
+  const cycleIds = new Set();
+  const missingParents = [];
+  const ancestors = [];
+  let parentRef = selectedRecord?.parent;
+
+  while (rawReferenceId(parentRef)) {
+    const parentID = rawReferenceId(parentRef);
+    const parentDisplay = referenceName(parentRef);
+    if (visited.has(parentID)) {
+      cycleIds.add(parentID);
+      break;
+    }
+    visited.add(parentID);
+    let parent;
+    try { parent = await fetchUpdateSetById(app, parentID); } catch { parent = null; }
+    if (!parent) {
+      missingParents.push(parentID);
+      ancestors.push({ sys_id: parentID, name: parentDisplay || `[missing parent ${parentID}]`, parent: null, missing: true });
+      break;
+    }
+    ancestors.push(parent);
+    parentRef = parent.parent;
+  }
+
+  const descendants = [];
+  async function walkChildren(parentID, depth) {
+    if (!parentID) return;
+    let children;
+    try {
+      const params = new URLSearchParams();
+      params.set('sysparm_query', `parent=${parentID}^ORDERBYname`);
+      params.set('sysparm_limit', '500');
+      params.set('sysparm_display_value', 'all');
+      params.set('sysparm_fields', 'sys_id,name,state,application,application.scope,parent,description,sys_created_on,sys_updated_on');
+      children = await app.sdk.list('sys_update_set', params);
+    } catch {
+      children = [];
+    }
+    if (!Array.isArray(children)) return;
+    for (const child of children) {
+      const childID = getStringField(child, 'sys_id');
+      if (!childID) continue;
+      if (visited.has(childID)) {
+        cycleIds.add(childID);
+        continue;
+      }
+      visited.add(childID);
+      descendants.push({ record: child, depth });
+      await walkChildren(childID, depth + 1);
+    }
+  }
+
+  const hierarchy = [
+    ...ancestors.reverse().map((record, index) => updateSetHierarchyRow(record, { depth: index, kind: 'ancestor', missing: record.missing })),
+    updateSetHierarchyRow(selectedRecord, { depth: ancestors.length, kind: 'selected', selected: true }),
+  ];
+  await walkChildren(selectedID, ancestors.length + 1);
+  hierarchy.push(...descendants.map(({ record, depth }) => updateSetHierarchyRow(record, { depth, kind: 'descendant' })));
+
+  return { hierarchy, cycleIds: [...cycleIds], missingParents };
+}
+
+function renderUpdateSetHierarchy(rows, cycleIds = [], missingParents = []) {
+  const lines = ['Update set hierarchy:'];
+  const hasLaterSibling = (index, depth) => {
+    for (let i = index + 1; i < rows.length; i += 1) {
+      if (rows[i].depth < depth) return false;
+      if (rows[i].depth === depth) return true;
+    }
+    return false;
+  };
+  rows.forEach((row, index) => {
+    const continuation = [];
+    for (let level = 0; level < row.depth - 1; level += 1) {
+      continuation.push(hasLaterSibling(index, level) ? '│   ' : '    ');
+    }
+    const connector = row.depth > 0 ? (hasLaterSibling(index, row.depth) ? '├── ' : '└── ') : '';
+    const marker = row.selected ? '◉' : '○';
+    const missing = row.missing ? ' [missing parent]' : '';
+    lines.push(`${continuation.join('')}${connector}${marker} ${row.name}${missing} [${row.state}] (${row.scope})`);
+  });
+  if (missingParents.length > 0) lines.push(`  ⚠️ Missing parent records: ${missingParents.join(', ')}`);
+  if (cycleIds.length > 0) lines.push(`  ⚠️ Hierarchy cycle detected; repeated branch omitted (${cycleIds.join(', ')})`);
+  return lines;
+}
+
 /**
- * Rich display for an update set: header fields + child update filenames.
- * Children (sys_update_xml) listed filename-only, sorted by sys_updated_on
- * descending (newest first). Shared by `list` pick and `show`.
- *
- * Fetches an enriched record itself (sysparm_display_value=all so the parent
- * reference renders as a name, not a sys_id) — callers can pass a thin
- * picker record; the formatter completes it.
+ * Rich display for an update set: header fields, update-set hierarchy, and
+ * separate child update payload details.
  */
 export async function formatUpdateSetDetail(app, record) {
   const sysID = getStringField(record, 'sys_id');
@@ -109,7 +239,7 @@ export async function formatUpdateSetDetail(app, record) {
     params.set('sysparm_query', `sys_id=${sysID}`);
     params.set('sysparm_limit', '1');
     params.set('sysparm_display_value', 'all');
-    params.set('sysparm_fields', 'sys_id,name,state,application,application.scope,parent,sys_created_on,sys_updated_on');
+    params.set('sysparm_fields', 'sys_id,name,state,application,application.scope,parent,description,sys_created_on,sys_updated_on');
     const recs = await app.sdk.list('sys_update_set', params);
     if (Array.isArray(recs) && recs.length > 0) full = recs[0];
   } catch {
@@ -123,6 +253,7 @@ export async function formatUpdateSetDetail(app, record) {
   const parent = getStringField(full, 'parent') || '';
   const created = getStringField(full, 'sys_created_on') || '';
   const updated = getStringField(full, 'sys_updated_on') || '';
+  const description = getStringField(full, 'description');
 
   // Child updates: filename only, newest first by sys_updated_on.
   // Also group by element type (sys_class_name) and flag risky types for
@@ -170,6 +301,7 @@ export async function formatUpdateSetDetail(app, record) {
     // children are best-effort — a broken query shouldn't kill the display
   }
 
+  const hierarchyData = await buildUpdateSetHierarchy(app, full);
   const lines = [];
   lines.push(`Update set: ${name}`);
   lines.push(`  State:     ${state}`);
@@ -177,7 +309,10 @@ export async function formatUpdateSetDetail(app, record) {
   if (parent) lines.push(`  Parent:    ${parent}`);
   if (created) lines.push(`  Created:   ${created}`);
   if (updated) lines.push(`  Updated:   ${updated}`);
-  lines.push(`Updates:   ${children.length}`);
+  if (description) lines.push(`  Description: ${description}`);
+  lines.push(...renderUpdateSetHierarchy(hierarchyData.hierarchy, hierarchyData.cycleIds, hierarchyData.missingParents));
+  lines.push('Payload / update XML:');
+  lines.push(`  Updates:   ${children.length}`);
   const typeEntries = Object.entries(byType).sort((a, b) => b[1] - a[1]);
   if (typeEntries.length > 0) {
     lines.push(`  By type:  ${typeEntries.map(([t, n]) => `${t}×${n}`).join(', ')}`);
@@ -243,6 +378,11 @@ export async function formatUpdateSetDetail(app, record) {
     parent,
     sys_created_on: created,
     sys_updated_on: updated,
+    description,
+    scope: application,
+    hierarchy: hierarchyData.hierarchy,
+    hierarchy_cycles: hierarchyData.cycleIds,
+    hierarchy_missing_parents: hierarchyData.missingParents,
     children,
     by_type: byType,
     risky_count: risky.length,

package/src/config.js

@@ -29,11 +29,17 @@ export function cacheDir() {
 export function normalizeInstanceURL(url) {
   if (!url) return '';
   url = url.trim();
-  url = url.replace(/\/$/, '');
   if (!/^https?:\/\//i.test(url)) {
     url = 'https://' + url;
   }
-  return url;
+  try {
+    // Profiles store the instance origin, never a page, API route, query, or
+    // fragment pasted from the browser.
+    return new URL(url).origin;
+  } catch {
+    // Preserve the old permissive behavior for non-standard local endpoints.
+    return url.replace(/\/$/, '');
+  }
 }
 
 function loadFromFile(cfg, filePath, source) {

package/scripts/pre-commit-check.sh

@@ -1,61 +0,0 @@
-#!/bin/bash
-# pre-commit-check.sh - Run this before committing to check architecture compliance
-
-echo "🔍 Checking architecture patterns..."
-
-# Check for forbidden SDK patterns
-FORBIDDEN_PATTERNS=(
-    "func.*Client.*ListForm"
-    "func.*Client.*ListList"
-    "func.*Client.*GetSP"
-    "func.*Client.*ListSP"
-)
-
-ERRORS=0
-
-for pattern in "${FORBIDDEN_PATTERNS[@]}"; do
-    matches=$(grep -r "$pattern" internal/sdk/*.go 2>/dev/null | grep -v "_test.go" | grep -v "^Binary")
-    if [ ! -z "$matches" ]; then
-        echo "❌ Found forbidden SDK pattern: $pattern"
-        echo "$matches"
-        ERRORS=$((ERRORS + 1))
-    fi
-done
-
-# Check that commands don't import old SDK types
-BAD_IMPORTS=(
-    "sdk.FormSection"
-    "sdk.FormElement"
-    "sdk.ListLayout"
-    "sdk.ListElement"
-    "sdk.SPPage"
-    "sdk.SPWidgetInstance"
-)
-
-for pattern in "${BAD_IMPORTS[@]}"; do
-    matches=$(grep -r "$pattern" internal/commands/**/*.go 2>/dev/null)
-    if [ ! -z "$matches" ]; then
-        echo "❌ Command using SDK type instead of local type: $pattern"
-        echo "$matches"
-        ERRORS=$((ERRORS + 1))
-    fi
-done
-
-# Run architecture tests
-echo "🧪 Running architecture tests..."
-if ! go test ./internal/sdk -run TestNoSDKHelperMethods -run TestCommandsUseDirectSDKList > /dev/null 2>&1; then
-    echo "❌ Architecture tests failed"
-    go test ./internal/sdk -v -run "TestNoSDKHelperMethods|TestCommandsUseDirectSDKList"
-    ERRORS=$((ERRORS + 1))
-fi
-
-if [ $ERRORS -eq 0 ]; then
-    echo "✅ All architecture checks passed!"
-    exit 0
-else
-    echo ""
-    echo "⚠️  Architecture violations found!"
-    echo "   Remember: Commands should call app.SDK.List() directly with local types."
-    echo "   See internal/commands/forms.go for the correct pattern."
-    exit 1
-fi

package/scripts/release.js

@@ -1,62 +0,0 @@
-#!/usr/bin/env node
-import { execSync } from 'child_process';
-import { readFileSync } from 'fs';
-import { fileURLToPath } from 'url';
-import { dirname, join } from 'path';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const pkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf8'));
-
-const type = process.argv[2];
-if (!type || !['patch', 'minor', 'major'].includes(type)) {
-  console.error('Usage: npm run release -- <patch|minor|major>');
-  process.exit(1);
-}
-
-let branch;
-try {
-  branch = execSync('git rev-parse --abbrev-ref HEAD', { encoding: 'utf8' }).trim();
-} catch {
-  console.error('Error: Not in a git repository');
-  process.exit(1);
-}
-
-if (branch !== 'main') {
-  console.error(`Error: Releases can only be made from 'main' branch (currently on '${branch}')`);
-  process.exit(1);
-}
-
-const prefix = 'v';
-
-console.log('');
-console.log(`🚀 Releasing from '${branch}'`);
-console.log(`   Bump: ${type}`);
-console.log('');
-
-// Run tests
-console.log('⏳ Running tests...');
-try {
-  execSync('npm test', { stdio: 'inherit' });
-} catch {
-  console.error('');
-  console.error('❌ Tests failed. Release aborted.');
-  process.exit(1);
-}
-
-// Bump version with correct tag prefix
-console.log('');
-console.log(`⏳ Bumping version (${type})...`);
-execSync(`npm version ${type} --tag-version-prefix=${prefix}`, { stdio: 'inherit' });
-
-// Push commits and tags
-console.log('');
-console.log('⏳ Pushing to origin...');
-execSync('git push && git push --tags', { stdio: 'inherit' });
-
-// Show final state
-const newPkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf8'));
-console.log('');
-console.log('✅ Release complete!');
-console.log(`   Version: ${newPkg.version}`);
-console.log(`   Tag:     ${prefix}${newPkg.version}`);
-console.log('');

package/scripts/tag-reminder.js

@@ -1,30 +0,0 @@
-#!/usr/bin/env node
-import { execSync } from 'child_process';
-import { readFileSync } from 'fs';
-import { fileURLToPath } from 'url';
-import { dirname, join } from 'path';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const pkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf8'));
-
-let branch;
-try {
-  branch = execSync('git rev-parse --abbrev-ref HEAD', { encoding: 'utf8' }).trim();
-} catch {
-  branch = 'unknown';
-}
-
-const version = pkg.version;
-const prefix = 'v';
-
-console.log('');
-console.log('📦 Release Reminder');
-console.log('');
-console.log(`   Current version: ${version}`);
-console.log(`   Current branch:  ${branch}`);
-console.log('');
-console.log('   To create a release tag, run:');
-console.log('');
-console.log(`     git tag ${prefix}${version}`);
-console.log('     git push origin --tags');
-console.log('');