@jacebenson/jsn 4.3.4 → 4.3.5-dev.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jacebenson/jsn",
-  "version": "4.3.4",
+  "version": "4.3.5-dev.7",
   "description": "A command-line interface for ServiceNow that follows the Unix philosophy: simple, composable, and scriptable.",
   "type": "module",
   "bin": {
@@ -23,6 +23,7 @@
     "automation"
   ],
   "author": "Jace Benson",
+  "repository": "https://github.com/jacebenson/jsn",
   "license": "MIT",
   "engines": {
     "node": ">=22.5.0"

package/src/commands/setup.js

@@ -1,3 +1,4 @@
+import { createPrompt, useKeypress, usePagination, useState, isDownKey, isEnterKey, isUpKey } from '@inquirer/core';
 import { loginWizard, modifyProfile, removeProfile, pickProfile } from './auth.js';
 import { setActiveProfile } from '../config.js';
 import { errUsage } from '../errors.js';
@@ -7,18 +8,44 @@ import { declareCapabilities } from '../capabilities.js';
 // (Not in the daily-check skip-list: legacy behavior checks for updates here.)
 declareCapabilities('setup', { noInstance: true });
 
-/** Interactive hub: what do you want to do? Returns 'add' | 'switch' | 'remove' | 'modify'. */
-export async function authHubMenu() {
-  const { select } = await import('@inquirer/prompts');
-  return select({
-    message: 'What would you like to do?',
-    choices: [
-      { name: 'Add a new instance', value: 'add' },
-      { name: 'Switch to a different instance', value: 'switch' },
-      { name: 'Remove an instance', value: 'remove' },
-      { name: 'Modify an instance', value: 'modify' },
-    ],
+const HUB_CHOICES = [
+  { name: 'Add a new instance', value: 'add' },
+  { name: 'Switch to a different instance', value: 'switch' },
+  { name: 'Remove an instance', value: 'remove' },
+  { name: 'Modify an instance', value: 'modify' },
+];
+
+/** The setup hub prompt; q and Escape resolve with no selected action. */
+export const authHubPrompt = createPrompt((config, done) => {
+  const [active, setActive] = useState(0);
+  const choices = config.choices;
+
+  useKeypress((key) => {
+    if (key.name === 'q' || key.name === 'escape') {
+      done(undefined);
+      return;
+    }
+    if (isEnterKey(key)) {
+      done(choices[active].value);
+      return;
+    }
+    if (isUpKey(key) && active > 0) setActive(active - 1);
+    if (isDownKey(key) && active < choices.length - 1) setActive(active + 1);
   });
+
+  const page = usePagination({
+    items: choices,
+    active,
+    pageSize: choices.length,
+    loop: false,
+    renderItem: ({ item, isActive }) => `${isActive ? '❯' : ' '} ${item.name}`,
+  });
+  return `${config.message}\n${page}\n\n↑↓ navigate • ⏎ select • q/Esc exit`;
+});
+
+/** Interactive hub: what do you want to do? Returns an action or undefined on exit. */
+export async function authHubMenu({ promptFn = authHubPrompt, input, output } = {}) {
+  return promptFn({ message: 'What would you like to do?', choices: HUB_CHOICES }, { input, output });
 }
 
 /**
@@ -36,7 +63,7 @@ export async function dispatchSetupAction(app, argv, action) {
   } else if (action === 'remove') {
     const name = await pickProfile(app, 'Remove which instance?');
     await removeProfile(app, name);
-  } else { // modify
+  } else if (action === 'modify') {
     await modifyProfile(app, argv);
   }
 }
@@ -60,6 +87,7 @@ export function setupCmd(wrap) {
         return;
       }
       const action = await authHubMenu();
+      if (action === undefined) return;
       await dispatchSetupAction(app, argv, action);
     }),
   };

package/src/sdk.js

@@ -266,6 +266,8 @@ export class SDKClient {
 
   /**
    * Upload a file as a new attachment on a record.
+   * Uses ServiceNow's binary attachment endpoint so file bytes are not expanded
+   * into base64 or embedded in a sys.scripts.do form body.
    * @param {string} table - parent table name (e.g. 'incident')
    * @param {string} sysID - parent record sys_id
    * @param {Buffer|string} content - file bytes or path
@@ -274,29 +276,30 @@ export class SDKClient {
    */
   async addAttachment(table, sysID, content, fileName) {
     const contentBuffer = Buffer.isBuffer(content) ? content : Buffer.from(String(content));
-    const script = [
-      '(function() {',
-      `  var record = new GlideRecord(${scriptString(table)});`,
-      `  if (!record.get(${scriptString(sysID)})) throw new Error('Record not found');`,
-      '  var attachment = new GlideSysAttachment();',
-      `  var fileName = ${scriptString(fileName)};`,
-      `  var content = ${scriptString(contentBuffer.toString('base64'))};`,
-      '  var sysId;',
-      "  if (typeof attachment.writeBase64 === 'function') {",
-      "    sysId = attachment.writeBase64(record, fileName, 'application/octet-stream', content);",
-      '  } else {',
-      "    sysId = new Attachment().write(record.getTableName(), record.getUniqueValue(), fileName, 'application/octet-stream', GlideStringUtil.base64DecodeAsBytes(content));",
-      '  }',
-      "  if (!sysId) throw new Error('Attachment was not created');",
-      "  gs.print('JSN_ATTACHMENT_RESULT:' + JSON.stringify({ sys_id: sysId }));",
-      '}());',
-    ].join('\n');
-    const output = await this.executeScript(script, '');
-    const result = parseAttachmentResult(output);
-    if (!result?.sys_id) {
-      throw new Error('Attachment upload returned no attachment sys_id');
+    const params = new URLSearchParams({
+      table_name: String(table),
+      table_sys_id: String(sysID),
+      file_name: String(fileName),
+    });
+    const endpoint = `${this.baseURL}/api/now/attachment/file?${params.toString()}`;
+
+    try {
+      const response = await this.request(endpoint, {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/octet-stream' },
+        body: contentBuffer,
+      });
+      const result = response?.result;
+      if (!result?.sys_id) {
+        throw new Error('Attachment upload returned no attachment sys_id');
+      }
+      return result;
+    } catch (err) {
+      if (err?.status === 413) {
+        throw errAPI(413, 'Attachment is too large for the ServiceNow attachment endpoint. Reduce the file size or increase the instance attachment limit.');
+      }
+      throw err;
     }
-    return result;
   }
 
   async getCurrentUser({ touchLastSeen = true } = {}) {
@@ -921,27 +924,6 @@ export class SDKClient {
   }
 }
 
-function scriptString(value) {
-  return JSON.stringify(String(value)).replace(/\u2028/g, '\\u2028').replace(/\u2029/g, '\\u2029');
-}
-
-function parseAttachmentResult(output) {
-  if (!output) return null;
-  const lines = String(output).split(/\r?\n/).reverse();
-  for (const line of lines) {
-    const candidate = line.replace(/^\*\*\* Script:\s*/, '').trim();
-    const markerCandidate = candidate.replace(/^JSN_ATTACHMENT_RESULT:\s*/, '');
-    if (!markerCandidate.startsWith('{')) continue;
-    try {
-      const result = JSON.parse(markerCandidate);
-      if (result && typeof result === 'object') return result;
-    } catch {
-      // Ignore unrelated script output and keep looking for the result marker.
-    }
-  }
-  return null;
-}
-
 function detectScriptError(output) {
   const lines = String(output || '').split(/\r?\n/).map(line => line.trim()).filter(Boolean);
   const errorLine = lines.find(line => /(?:ReferenceError|TypeError|RhinoEcmaError|Script execution error|undefined is not a function|is not defined)/i.test(line));