@j0hanz/code-review-analyst-mcp 1.4.1 → 1.4.3

package/dist/lib/gemini.js

@@ -4,7 +4,7 @@ import { EventEmitter } from 'node:events';
 import { performance } from 'node:perf_hooks';
 import { setTimeout as sleep } from 'node:timers/promises';
 import { debuglog } from 'node:util';
-import { GoogleGenAI, HarmBlockThreshold, HarmCategory } from '@google/genai';
+import { FinishReason, GoogleGenAI, HarmBlockThreshold, HarmCategory, } from '@google/genai';
 import { createCachedEnvInt } from './env-config.js';
 import { getErrorMessage, RETRYABLE_UPSTREAM_ERROR_PATTERN } from './errors.js';
 // Lazy-cached: first call happens after parseCommandLineArgs() sets GEMINI_MODEL.
@@ -370,14 +370,20 @@ async function executeAttempt(request, model, timeoutMs, attempt, onLog) {
     const startedAt = performance.now();
     const response = await generateContentWithTimeout(request, model, timeoutMs);
     const latencyMs = Math.round(performance.now() - startedAt);
+    const finishReason = response.candidates?.[0]?.finishReason;
     await emitGeminiLog(onLog, 'info', {
         event: 'gemini_call',
         details: {
             attempt,
             latencyMs,
+            finishReason: finishReason ?? null,
             usageMetadata: response.usageMetadata ?? null,
         },
     });
+    if (finishReason === FinishReason.MAX_TOKENS) {
+        const limit = request.maxOutputTokens ?? DEFAULT_MAX_OUTPUT_TOKENS;
+        throw new Error(`Response truncated: model output exceeds limit (maxOutputTokens=${formatNumber(limit)}). Increase maxOutputTokens or reduce prompt complexity.`);
+    }
     return parseStructuredResponse(response.text);
 }
 async function waitBeforeRetry(attempt, error, onLog, requestSignal) {

package/dist/lib/model-config.d.ts

@@ -7,7 +7,7 @@ export declare const FLASH_THINKING_BUDGET: 8192;
 /** Thinking budget (tokens) for Pro model deep-analysis tasks (code quality inspection). */
 export declare const PRO_THINKING_BUDGET: 16384;
 /** Output cap for Flash triage tools (impact, summary). */
-export declare const FLASH_TRIAGE_MAX_OUTPUT_TOKENS: 2048;
+export declare const FLASH_TRIAGE_MAX_OUTPUT_TOKENS: 4096;
 /** Output cap for API breaking-change detection (migration guidance needs room). */
 export declare const FLASH_API_BREAKING_MAX_OUTPUT_TOKENS: 4096;
 /** Output cap for test-plan generation (includes pseudocode snippets). */

package/dist/lib/model-config.js

@@ -7,7 +7,7 @@ const THINKING_BUDGET_TOKENS = {
     pro: 16_384,
 };
 const OUTPUT_TOKEN_BUDGET = {
-    flashTriage: 2_048,
+    flashTriage: 4_096,
     flashTestPlan: 4_096,
     flashApiBreaking: 4_096,
     flashComplexity: 2_048,

package/dist/lib/tool-contracts.d.ts

@@ -1,3 +1,4 @@
+export declare const INSPECTION_FOCUS_AREAS: readonly ["security", "correctness", "performance", "regressions", "tests", "maintainability", "concurrency"];
 export interface ToolParameterContract {
     name: string;
     type: string;
@@ -42,7 +43,7 @@ export declare const TOOL_CONTRACTS: readonly [{
     readonly purpose: "Assess severity, categories, breaking changes, and rollback complexity.";
     readonly model: "gemini-2.5-flash";
     readonly timeoutMs: 90000;
-    readonly maxOutputTokens: 2048;
+    readonly maxOutputTokens: 4096;
     readonly params: readonly [{
         readonly name: "repository";
         readonly type: "string";
@@ -64,7 +65,7 @@ export declare const TOOL_CONTRACTS: readonly [{
     readonly purpose: "Produce PR summary, risk rating, and merge recommendation.";
     readonly model: "gemini-2.5-flash";
     readonly timeoutMs: 90000;
-    readonly maxOutputTokens: 2048;
+    readonly maxOutputTokens: 4096;
     readonly params: readonly [{
         readonly name: "repository";
         readonly type: "string";
@@ -105,7 +106,7 @@ export declare const TOOL_CONTRACTS: readonly [{
         readonly type: "string[]";
         readonly required: false;
         readonly constraints: "1-12 items, 2-80 chars each";
-        readonly description: "Focused inspection categories.";
+        readonly description: `Focused inspection categories (e.g. ${string}).`;
     }, {
         readonly name: "maxFindings";
         readonly type: "number";

package/dist/lib/tool-contracts.js

@@ -1,5 +1,14 @@
 import { DEFAULT_TIMEOUT_PRO_MS, FLASH_API_BREAKING_MAX_OUTPUT_TOKENS, FLASH_COMPLEXITY_MAX_OUTPUT_TOKENS, FLASH_MODEL, FLASH_TEST_PLAN_MAX_OUTPUT_TOKENS, FLASH_THINKING_BUDGET, FLASH_TRIAGE_MAX_OUTPUT_TOKENS, PRO_MODEL, PRO_PATCH_MAX_OUTPUT_TOKENS, PRO_REVIEW_MAX_OUTPUT_TOKENS, PRO_THINKING_BUDGET, } from './model-config.js';
 const DEFAULT_TIMEOUT_FLASH_MS = 90_000;
+export const INSPECTION_FOCUS_AREAS = [
+    'security',
+    'correctness',
+    'performance',
+    'regressions',
+    'tests',
+    'maintainability',
+    'concurrency',
+];
 export const TOOL_CONTRACTS = [
     {
         name: 'generate_diff',
@@ -115,7 +124,7 @@ export const TOOL_CONTRACTS = [
                 type: 'string[]',
                 required: false,
                 constraints: '1-12 items, 2-80 chars each',
-                description: 'Focused inspection categories.',
+                description: `Focused inspection categories (e.g. ${INSPECTION_FOCUS_AREAS.join(', ')}).`,
             },
             {
                 name: 'maxFindings',

package/dist/lib/tool-factory.d.ts

@@ -1,5 +1,6 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import type { ZodRawShapeCompat } from '@modelcontextprotocol/sdk/server/zod-compat.js';
+import type { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
 import { z } from 'zod';
 import { type DiffSlot } from './diff-store.js';
 import { createErrorToolResponse } from './tool-response.js';
@@ -17,6 +18,22 @@ export interface PromptParts {
 export interface ToolExecutionContext {
     readonly diffSlot: DiffSlot | undefined;
 }
+type ProgressToken = string | number;
+interface ProgressNotificationParams {
+    progressToken: ProgressToken;
+    progress: number;
+    total?: number;
+    message?: string;
+}
+interface ProgressExtra {
+    _meta?: {
+        progressToken?: unknown;
+    };
+    sendNotification: (notification: {
+        method: 'notifications/progress';
+        params: ProgressNotificationParams;
+    }) => Promise<void>;
+}
 export interface StructuredToolTaskConfig<TInput extends object = Record<string, unknown>, TResult extends object = Record<string, unknown>, TFinal extends TResult = TResult> {
     /** Tool name registered with the MCP server (e.g. 'analyze_pr_impact'). */
     name: string;
@@ -57,4 +74,9 @@ export interface StructuredToolTaskConfig<TInput extends object = Record<string,
     /** Builds the system instruction and user prompt from parsed tool input. */
     buildPrompt: (input: TInput, ctx: ToolExecutionContext) => PromptParts;
 }
+export declare function wrapToolHandler<TInput, TResult extends CallToolResult>(options: {
+    toolName: string;
+    progressContext?: (input: TInput) => string;
+}, handler: (input: TInput, extra: ProgressExtra) => Promise<TResult> | TResult): (input: TInput, extra: ProgressExtra) => Promise<TResult>;
 export declare function registerStructuredToolTask<TInput extends object, TResult extends object = Record<string, unknown>, TFinal extends TResult = TResult>(server: McpServer, config: StructuredToolTaskConfig<TInput, TResult, TFinal>): void;
+export {};

package/dist/lib/tool-factory.js

@@ -218,6 +218,43 @@ function createGeminiLogger(server, taskId) {
         }
     };
 }
+export function wrapToolHandler(options, handler) {
+    return async (input, extra) => {
+        const context = normalizeProgressContext(options.progressContext?.(input));
+        // Start progress (0/1)
+        await sendTaskProgress(extra, {
+            current: 0,
+            total: 1,
+            message: formatProgressStep(options.toolName, context, 'starting'),
+        });
+        try {
+            const result = await handler(input, extra);
+            // End progress (1/1)
+            const outcome = result.isError ? 'failed' : 'completed';
+            const success = !result.isError;
+            await sendTaskProgress(extra, {
+                current: 1,
+                total: 1,
+                message: formatProgressCompletion(options.toolName, context, outcome, success),
+            });
+            return result;
+        }
+        catch (error) {
+            // Progress is best-effort; must never mask the original error.
+            try {
+                await sendTaskProgress(extra, {
+                    current: 1,
+                    total: 1,
+                    message: formatProgressCompletion(options.toolName, context, 'failed', false),
+                });
+            }
+            catch {
+                // Swallow progress delivery errors so the original error propagates.
+            }
+            throw error;
+        }
+    };
+}
 export function registerStructuredToolTask(server, config) {
     const responseSchema = createGeminiResponseSchema({
         geminiSchema: config.geminiSchema,

package/dist/prompts/index.d.ts

@@ -1,2 +1,11 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
+export declare const PROMPT_DEFINITIONS: readonly [{
+    readonly name: "get-help";
+    readonly title: "Get Help";
+    readonly description: "Server instructions.";
+}, {
+    readonly name: "review-guide";
+    readonly title: "Review Guide";
+    readonly description: "Workflow guide for tool/focus area.";
+}];
 export declare function registerAllPrompts(server: McpServer, instructions: string): void;

package/dist/prompts/index.js

@@ -1,20 +1,19 @@
 import { completable } from '@modelcontextprotocol/sdk/server/completable.js';
 import { z } from 'zod';
-import { getToolContract, getToolContractNames, } from '../lib/tool-contracts.js';
-const HELP_PROMPT_NAME = 'get-help';
-const HELP_PROMPT_TITLE = 'Get Help';
-const HELP_PROMPT_DESCRIPTION = 'Server instructions.';
-const REVIEW_GUIDE_PROMPT_NAME = 'review-guide';
-const REVIEW_GUIDE_PROMPT_TITLE = 'Review Guide';
-const REVIEW_GUIDE_PROMPT_DESCRIPTION = 'Workflow guide for tool/focus area.';
-const TOOLS = getToolContractNames();
-const FOCUS_AREAS = [
-    'security',
-    'correctness',
-    'performance',
-    'regressions',
-    'tests',
+import { getToolContract, getToolContractNames, INSPECTION_FOCUS_AREAS, } from '../lib/tool-contracts.js';
+export const PROMPT_DEFINITIONS = [
+    {
+        name: 'get-help',
+        title: 'Get Help',
+        description: 'Server instructions.',
+    },
+    {
+        name: 'review-guide',
+        title: 'Review Guide',
+        description: 'Workflow guide for tool/focus area.',
+    },
 ];
+const TOOLS = getToolContractNames();
 const TOOL_DESCRIPTION_TEXT = 'Select tool for review guide.';
 const FOCUS_DESCRIPTION_TEXT = 'Select focus area.';
 const FOCUS_AREA_GUIDES = {
@@ -23,6 +22,8 @@ const FOCUS_AREA_GUIDES = {
     performance: 'Focus: Complexity, allocations, I/O, queries.',
     regressions: 'Focus: Behavior changes, guards, types, breaks.',
     tests: 'Focus: Coverage, edge cases, flakes, error paths.',
+    maintainability: 'Focus: Complexity, readability, structure, patterns.',
+    concurrency: 'Focus: Race conditions, deadlocks, shared state.',
 };
 function completeByPrefix(values, prefix) {
     const matches = [];
@@ -52,11 +53,12 @@ function getFocusAreaGuide(focusArea) {
     return getGuide(FOCUS_AREA_GUIDES, focusArea, (area) => `Focus on ${area} concerns.`);
 }
 function registerHelpPrompt(server, instructions) {
-    server.registerPrompt(HELP_PROMPT_NAME, {
-        title: HELP_PROMPT_TITLE,
-        description: HELP_PROMPT_DESCRIPTION,
+    const def = PROMPT_DEFINITIONS[0];
+    server.registerPrompt(def.name, {
+        title: def.title,
+        description: def.description,
     }, () => ({
-        description: HELP_PROMPT_DESCRIPTION,
+        description: def.description,
         messages: [
             {
                 role: 'user',
@@ -85,12 +87,13 @@ function buildReviewGuideText(tool, focusArea) {
         `> Tip: Run \`get-help\` for full server documentation.`);
 }
 function registerReviewGuidePrompt(server) {
-    server.registerPrompt(REVIEW_GUIDE_PROMPT_NAME, {
-        title: REVIEW_GUIDE_PROMPT_TITLE,
-        description: REVIEW_GUIDE_PROMPT_DESCRIPTION,
+    const def = PROMPT_DEFINITIONS[1];
+    server.registerPrompt(def.name, {
+        title: def.title,
+        description: def.description,
         argsSchema: {
             tool: completable(z.string().describe(TOOL_DESCRIPTION_TEXT), (value) => completeByPrefix(TOOLS, value)),
-            focusArea: completable(z.string().describe(FOCUS_DESCRIPTION_TEXT), (value) => completeByPrefix(FOCUS_AREAS, value)),
+            focusArea: completable(z.string().describe(FOCUS_DESCRIPTION_TEXT), (value) => completeByPrefix(INSPECTION_FOCUS_AREAS, value)),
         },
     }, ({ tool, focusArea }) => ({
         description: `Code review guide: ${tool} / ${focusArea}`,

package/dist/resources/index.d.ts

@@ -1,2 +1,12 @@
 import { type McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
+export interface StaticResourceDef {
+    id: string;
+    uri: string;
+    title: string;
+    description: string;
+    priority: number;
+    content: () => string;
+}
+export declare const STATIC_RESOURCES: readonly StaticResourceDef[];
+export declare const DIFF_RESOURCE_DESCRIPTION = "The most recently generated diff, cached by generate_diff. Read by all review tools automatically.";
 export declare function registerAllResources(server: McpServer, instructions: string): void;

package/dist/resources/index.js

@@ -9,7 +9,7 @@ const RESOURCE_AUDIENCE = ['assistant'];
 function createMarkdownContent(uri, text) {
     return { uri: uri.href, mimeType: RESOURCE_MIME_TYPE, text };
 }
-const STATIC_RESOURCES = [
+export const STATIC_RESOURCES = [
     {
         id: 'server-instructions',
         uri: 'internal://instructions',
@@ -77,10 +77,11 @@ function registerToolInfoResources(server) {
         return { contents: [createMarkdownContent(uri, text)] };
     });
 }
+export const DIFF_RESOURCE_DESCRIPTION = 'The most recently generated diff, cached by generate_diff. Read by all review tools automatically.';
 function registerDiffResource(server) {
     server.registerResource('diff-current', new ResourceTemplate(DIFF_RESOURCE_URI, { list: undefined }), {
         title: 'Current Diff',
-        description: 'The most recently generated diff, cached by generate_diff. Read by all review tools automatically.',
+        description: DIFF_RESOURCE_DESCRIPTION,
         mimeType: 'text/x-patch',
         annotations: {
             audience: ['assistant'],

package/dist/resources/instructions.js

@@ -1,16 +1,12 @@
 import { getToolContracts } from '../lib/tool-contracts.js';
+import { PROMPT_DEFINITIONS } from '../prompts/index.js';
+import { DIFF_RESOURCE_DESCRIPTION, STATIC_RESOURCES } from './index.js';
 import { getSharedConstraints } from './tool-info.js';
-const PROMPT_LIST = [
-    '- `get-help`: Returns these server instructions.',
-    '- `review-guide`: Workflow guide for a selected tool and focus area.',
-];
+const PROMPT_LIST = PROMPT_DEFINITIONS.map((def) => `- \`${def.name}\`: ${def.description}`);
 const RESOURCE_LIST = [
-    '- `internal://instructions`: This document.',
-    '- `internal://tool-catalog`: Tool matrix and cross-tool data flow.',
-    '- `internal://workflows`: Recommended multi-step tool workflows.',
-    '- `internal://server-config`: Runtime limits and model configuration.',
+    ...STATIC_RESOURCES.map((def) => `- \`${def.uri}\`: ${def.description}`),
     '- `internal://tool-info/{toolName}`: Per-tool contract details.',
-    '- `diff://current`: Cached diff from the most recent generate_diff run.',
+    `- \`diff://current\`: ${DIFF_RESOURCE_DESCRIPTION}`,
 ];
 function formatParameterLine(parameter) {
     const required = parameter.required ? 'required' : 'optional';

package/dist/schemas/inputs.js

@@ -51,7 +51,7 @@ export const InspectCodeQualityInputSchema = z.strictObject({
         .min(1)
         .max(INPUT_LIMITS.focusArea.maxItems)
         .optional()
-        .describe('Review focus areas. Standard tags: security, performance, correctness, maintainability, concurrency. Omit for general review.'),
+        .describe('Review focus areas. Standard tags: security, correctness, performance, regressions, tests, maintainability, concurrency. Omit for general review.'),
     maxFindings: createOptionalBoundedInteger(INPUT_LIMITS.maxFindings.min, INPUT_LIMITS.maxFindings.max, 'Max findings (1-25). Default: 10.'),
     files: z
         .array(FileContextSchema)

package/dist/tools/generate-diff.js

@@ -3,6 +3,7 @@ import { z } from 'zod';
 import { cleanDiff, isEmptyDiff, NOISY_EXCLUDE_PATHSPECS, } from '../lib/diff-cleaner.js';
 import { computeDiffStatsFromFiles, parseDiffFiles, } from '../lib/diff-parser.js';
 import { DIFF_RESOURCE_URI, storeDiff } from '../lib/diff-store.js';
+import { wrapToolHandler } from '../lib/tool-factory.js';
 import { createErrorToolResponse, createToolResponse, } from '../lib/tool-response.js';
 const GIT_TIMEOUT_MS = 30_000;
 const GIT_MAX_BUFFER = 10 * 1024 * 1024; // 10 MB
@@ -29,6 +30,9 @@ export function registerGenerateDiffTool(server) {
                 .enum(['unstaged', 'staged'])
                 .describe('"unstaged": working-tree changes not yet staged. "staged": changes added to the index with git add.'),
         },
+    }, wrapToolHandler({
+        toolName: 'generate_diff',
+        progressContext: (input) => input.mode,
     }, (input) => {
         const { mode } = input;
         const args = buildGitArgs(mode);
@@ -67,5 +71,5 @@ export function registerGenerateDiffTool(server) {
                 message: summary,
             },
         }, summary);
-    });
+    }));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@j0hanz/code-review-analyst-mcp",
-  "version": "1.4.1",
+  "version": "1.4.3",
   "mcpName": "io.github.j0hanz/code-review-analyst",
   "description": "Gemini-powered MCP server for code review analysis.",
   "type": "module",