@j-o-r/sh 1.0.6 → 1.0.7

package/lib/SHDispatch.js

@@ -140,11 +140,11 @@ class SHDispatch {
 		// @ts-ignore
 		return new SHExec(this.#cmd, this.#options).runSync(payload);
 	}
-	async kill() {
-		try {
-			await this.#proc.kill();
-		} catch (_e) { }
+	async kill(signal = 'SIGTERM') {
+		let res = [];
+		res = await this.#proc.kill(signal);
 		this.#proc = undefined;
+		return res;
 	}
 }
 

package/lib/SHExecute.js

@@ -20,7 +20,7 @@ const killProcesses = (processPid, signal) => {
 				reject(new Error(stderr));
 				return;
 			}
-			const pids = stdout.split(/\r?\n/).filter(pid => pid);
+			const pids = stdout.split(/\r?\n/).filter(pid => pid) || [];
 			// Kill each child process
 			try {
 				for (const pid of pids) {
@@ -48,6 +48,7 @@ class SHExecute {
 	/**
 	* @type {import('child_process').ChildProcess}
 	*/
+	#forcedKill = false;
 	#proc;
 	#command = '';
 	#options = {};
@@ -127,6 +128,11 @@ class SHExecute {
 			}
 			this.#proc.on('close', (code) => {
 				if (timeout) clearTimeout(timeout);
+				if (this.#forcedKill) {
+					// Resolve without content
+					resolve();
+					return;
+				}
 				if (code === 0) {
 					resolve(this.#stdout.trim());
 				} else {
@@ -140,13 +146,16 @@ class SHExecute {
 		});
 	}
 	/**
+	* @param {string} signal - kill signal
 	* @returns {Promise<number[]>}
 	*/
 	async kill(signal = 'SIGTERM') {
 		if (!this.#proc) throw new Error('Trying to kill a process without creating one.');
 		if (!this.#proc.pid) throw new Error('The process pid is undefined.');
-
-		return killProcesses(this.#proc.pid, signal);
+		this.#forcedKill = true;
+		const res = killProcesses(this.#proc.pid, signal);
+		this.#proc = undefined;
+		return res;
 	}
 }
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "@j-o-r/sh",
   "author": "Jorrit Duin <j-o-r@duin.work>",
   "type": "module",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Execute shell commands on Linux-based systems from javascript",
   "main": "lib/SH.js",
   "types": "types/SH.d.ts",

package/types/SHDispatch.d.ts

@@ -77,6 +77,6 @@ declare class SHDispatch {
     * @returns {SpawnSyncResponse}
     */
     runSync(payload?: string | undefined): SpawnSyncResponse;
-    kill(): Promise<void>;
+    kill(signal?: string): Promise<number[]>;
     #private;
 }

package/types/SHExecute.d.ts

@@ -16,6 +16,7 @@ declare class SHExecute {
     */
     run(payload?: string | undefined): Promise<any>;
     /**
+    * @param {string} signal - kill signal
     * @returns {Promise<number[]>}
     */
     kill(signal?: string): Promise<number[]>;