@izkac/forgekit 0.3.12 → 0.3.14

package/src/doctor.test.mjs

@@ -1,114 +1,114 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import path from 'node:path';
-import { Writable } from 'node:stream';
-import {
-  OPENSPEC_INSTALL_CMD,
-  checkOpenSpecCli,
-  checkOpenSpecProject,
-  runDoctor,
-  runDoctorChecks,
-  warnIfDoctorFails,
-} from './doctor.mjs';
-
-function capture() {
-  let text = '';
-  const stream = new Writable({
-    write(chunk, _enc, cb) {
-      text += String(chunk);
-      cb();
-    },
-  });
-  return { stream, text: () => text };
-}
-
-test('checkOpenSpecProject ok when config exists', () => {
-  const result = checkOpenSpecProject({
-    cwd: '/repo',
-    existsSync: (p) => p.replace(/\\/g, '/') === '/repo/openspec/config.yaml',
-  });
-  assert.equal(result.ok, true);
-});
-
-test('checkOpenSpecProject fails when missing', () => {
-  const result = checkOpenSpecProject({
-    cwd: '/repo',
-    existsSync: () => false,
-  });
-  assert.equal(result.ok, false);
-});
-
-test('checkOpenSpecCli ok when version exits 0', () => {
-  const result = checkOpenSpecCli({
-    runCommand: () => ({ status: 0, stdout: '1.2.0\n', stderr: '' }),
-  });
-  assert.equal(result.ok, true);
-  assert.equal(result.version, '1.2.0');
-});
-
-test('checkOpenSpecCli missing offers install', () => {
-  const result = checkOpenSpecCli({
-    runCommand: () => ({ status: 1, stdout: '', stderr: 'not found' }),
-  });
-  assert.equal(result.ok, false);
-  assert.match(result.message, /@fission-ai\/openspec/);
-  assert.equal(result.installCommand, OPENSPEC_INSTALL_CMD);
-});
-
-test('runDoctorChecks aggregates', () => {
-  const report = runDoctorChecks({
-    cwd: '/repo',
-    existsSync: () => true,
-    runCommand: () => ({ status: 0, stdout: '1.0.0', stderr: '' }),
-  });
-  assert.equal(report.ok, true);
-});
-
-test('runDoctor --warn-only exits 0 on failure', () => {
-  const out = capture();
-  const err = capture();
-  const code = runDoctor(['--warn-only'], {
-    cwd: '/repo',
-    stdout: out.stream,
-    stderr: err.stream,
-    existsSync: () => true,
-    runCommand: () => ({ status: 1, stdout: '', stderr: 'missing' }),
-  });
-  assert.equal(code, 0);
-  assert.match(out.text(), /FAIL|not found|Install/i);
-});
-
-test('runDoctor exits 1 when CLI missing', () => {
-  const out = capture();
-  const err = capture();
-  const code = runDoctor([], {
-    cwd: '/repo',
-    stdout: out.stream,
-    stderr: err.stream,
-    existsSync: () => true,
-    runCommand: () => ({ status: 1, stdout: '', stderr: 'missing' }),
-  });
-  assert.equal(code, 1);
-  assert.match(out.text(), /npm install -g @fission-ai\/openspec/);
-});
-
-test('warnIfDoctorFails writes to stderr', () => {
-  const err = capture();
-  const report = warnIfDoctorFails({
-    cwd: '/repo',
-    stderr: err.stream,
-    existsSync: () => false,
-    runCommand: () => ({ status: 1, stdout: '', stderr: '' }),
-  });
-  assert.equal(report.ok, false);
-  assert.match(err.text(), /forge:doctor/);
-  assert.match(err.text(), /install/i);
-});
-
-test('path join uses openspec/config.yaml', () => {
-  const result = checkOpenSpecProject({
-    cwd: path.join('S:', 'Projects', 'janus'),
-    existsSync: (p) => p.endsWith(path.join('openspec', 'config.yaml')),
-  });
-  assert.equal(result.ok, true);
-});
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import path from 'node:path';
+import { Writable } from 'node:stream';
+import {
+  OPENSPEC_INSTALL_CMD,
+  checkOpenSpecCli,
+  checkOpenSpecProject,
+  runDoctor,
+  runDoctorChecks,
+  warnIfDoctorFails,
+} from './doctor.mjs';
+
+function capture() {
+  let text = '';
+  const stream = new Writable({
+    write(chunk, _enc, cb) {
+      text += String(chunk);
+      cb();
+    },
+  });
+  return { stream, text: () => text };
+}
+
+test('checkOpenSpecProject ok when config exists', () => {
+  const result = checkOpenSpecProject({
+    cwd: '/repo',
+    existsSync: (p) => p.replace(/\\/g, '/') === '/repo/openspec/config.yaml',
+  });
+  assert.equal(result.ok, true);
+});
+
+test('checkOpenSpecProject fails when missing', () => {
+  const result = checkOpenSpecProject({
+    cwd: '/repo',
+    existsSync: () => false,
+  });
+  assert.equal(result.ok, false);
+});
+
+test('checkOpenSpecCli ok when version exits 0', () => {
+  const result = checkOpenSpecCli({
+    runCommand: () => ({ status: 0, stdout: '1.2.0\n', stderr: '' }),
+  });
+  assert.equal(result.ok, true);
+  assert.equal(result.version, '1.2.0');
+});
+
+test('checkOpenSpecCli missing offers install', () => {
+  const result = checkOpenSpecCli({
+    runCommand: () => ({ status: 1, stdout: '', stderr: 'not found' }),
+  });
+  assert.equal(result.ok, false);
+  assert.match(result.message, /@fission-ai\/openspec/);
+  assert.equal(result.installCommand, OPENSPEC_INSTALL_CMD);
+});
+
+test('runDoctorChecks aggregates', () => {
+  const report = runDoctorChecks({
+    cwd: '/repo',
+    existsSync: () => true,
+    runCommand: () => ({ status: 0, stdout: '1.0.0', stderr: '' }),
+  });
+  assert.equal(report.ok, true);
+});
+
+test('runDoctor --warn-only exits 0 on failure', () => {
+  const out = capture();
+  const err = capture();
+  const code = runDoctor(['--warn-only'], {
+    cwd: '/repo',
+    stdout: out.stream,
+    stderr: err.stream,
+    existsSync: () => true,
+    runCommand: () => ({ status: 1, stdout: '', stderr: 'missing' }),
+  });
+  assert.equal(code, 0);
+  assert.match(out.text(), /FAIL|not found|Install/i);
+});
+
+test('runDoctor exits 1 when CLI missing', () => {
+  const out = capture();
+  const err = capture();
+  const code = runDoctor([], {
+    cwd: '/repo',
+    stdout: out.stream,
+    stderr: err.stream,
+    existsSync: () => true,
+    runCommand: () => ({ status: 1, stdout: '', stderr: 'missing' }),
+  });
+  assert.equal(code, 1);
+  assert.match(out.text(), /npm install -g @fission-ai\/openspec/);
+});
+
+test('warnIfDoctorFails writes to stderr', () => {
+  const err = capture();
+  const report = warnIfDoctorFails({
+    cwd: '/repo',
+    stderr: err.stream,
+    existsSync: () => false,
+    runCommand: () => ({ status: 1, stdout: '', stderr: '' }),
+  });
+  assert.equal(report.ok, false);
+  assert.match(err.text(), /forge:doctor/);
+  assert.match(err.text(), /install/i);
+});
+
+test('path join uses openspec/config.yaml', () => {
+  const result = checkOpenSpecProject({
+    cwd: path.join('S:', 'Projects', 'janus'),
+    existsSync: (p) => p.endsWith(path.join('openspec', 'config.yaml')),
+  });
+  assert.equal(result.ok, true);
+});

package/src/fleet.test.mjs

@@ -80,6 +80,56 @@ test('listFleet self-heals entries whose session dir is gone', () => {
   assert.equal(fs.existsSync(entryFile(project, 'gone')), false);
 });
 
+test('listFleet reconciles a stale entry against session.json on disk', () => {
+  // Regression: the registry is a cache, not a source of truth. A session
+  // whose phase advanced without a mirroring write (older CLI, a crash, a
+  // hand-edited record) showed its first-registered phase forever — helm's
+  // phase-0 sat at `brainstorm` in `forge fleet list` after reaching `done`.
+  process.env.FORGEKIT_FLEET_DIR = path.join(tmp('fleet-reconcile-'), 'sessions');
+  const project = tmp('fleet-proj-');
+  const sessionDir = makeProject(project, 's5');
+
+  registerSession(project, makeSession('s5', { phase: 'brainstorm', tasksComplete: 0 }));
+  // Disk moves on without the registry.
+  const later = new Date(Date.now() + 60_000).toISOString();
+  fs.writeFileSync(
+    path.join(sessionDir, 'session.json'),
+    `${JSON.stringify(
+      makeSession('s5', {
+        phase: 'done',
+        tasksTotal: 20,
+        tasksComplete: 20,
+        openspecChange: 'phase-0',
+        updatedAt: later,
+      }),
+    )}\n`,
+    'utf8',
+  );
+
+  const [entry] = listFleet();
+  assert.equal(entry.phase, 'done');
+  assert.equal(entry.tasksComplete, 20);
+  assert.equal(entry.tasksTotal, 20);
+  assert.equal(entry.openspecChange, 'phase-0');
+  assert.equal(entry.updatedAt, later);
+  // Reconciliation is persisted, so the next read is already correct.
+  assert.equal(JSON.parse(fs.readFileSync(entryFile(project, 's5'), 'utf8')).phase, 'done');
+  // lastSeen is a heartbeat, not a session field — reconciling must not forge one.
+  assert.ok(entry.lastSeen <= new Date().toISOString());
+});
+
+test('listFleet keeps registry-only fields when session.json is unreadable', () => {
+  process.env.FORGEKIT_FLEET_DIR = path.join(tmp('fleet-unreadable-'), 'sessions');
+  const project = tmp('fleet-proj-');
+  const sessionDir = makeProject(project, 's6');
+  registerSession(project, makeSession('s6', { phase: 'verify' }));
+  fs.writeFileSync(path.join(sessionDir, 'session.json'), '{ not json', 'utf8');
+
+  const [entry] = listFleet();
+  assert.equal(entry.phase, 'verify');
+  assert.equal(entry.missing, false);
+});
+
 test('saveSession mirrors into the fleet registry', () => {
   process.env.FORGEKIT_FLEET_DIR = path.join(tmp('fleet-mirror-'), 'sessions');
   const project = tmp('fleet-proj-');