@izkac/forgekit 0.3.11 → 0.3.13

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (116) hide show
  1. package/bin/forge.mjs +107 -107
  2. package/bin/forgekit.mjs +83 -83
  3. package/bin/review.mjs +81 -81
  4. package/package.json +1 -1
  5. package/scripts/prepack.mjs +78 -78
  6. package/scripts/run-tests.mjs +50 -50
  7. package/src/adr.mjs +236 -236
  8. package/src/adr.test.mjs +170 -170
  9. package/src/change.mjs +327 -234
  10. package/src/change.test.mjs +145 -83
  11. package/src/cleanup-sessions.mjs +84 -84
  12. package/src/config.mjs +103 -103
  13. package/src/defer.mjs +75 -75
  14. package/src/doctor.mjs +350 -341
  15. package/src/doctor.test.mjs +114 -114
  16. package/src/init.mjs +680 -621
  17. package/src/install.mjs +815 -815
  18. package/src/install.test.mjs +180 -180
  19. package/src/integrity-check.mjs +60 -60
  20. package/src/integrity.mjs +682 -682
  21. package/src/integrity.test.mjs +566 -566
  22. package/src/lib.mjs +143 -143
  23. package/src/models.defaults.json +41 -41
  24. package/src/new-session.mjs +99 -99
  25. package/src/openspec-overlays/README.md +19 -19
  26. package/src/openspec-overlays/openspec-apply-change-footer.md +14 -14
  27. package/src/openspec-overlays/opsx-apply-completion-step.md +1 -1
  28. package/src/openspec-overlays/opsx-apply-implement-step.md +11 -11
  29. package/src/paths.mjs +92 -92
  30. package/src/plan-engine.mjs +321 -278
  31. package/src/plan-engine.test.mjs +447 -283
  32. package/src/preferences.defaults.json +78 -78
  33. package/src/preferences.mjs +438 -438
  34. package/src/preferences.test.mjs +174 -174
  35. package/src/record-evidence.mjs +204 -204
  36. package/src/resolve-model.mjs +312 -312
  37. package/src/resolve-model.test.mjs +194 -194
  38. package/src/review/cli.test.mjs +117 -117
  39. package/src/review/export.mjs +172 -172
  40. package/src/review/export.test.mjs +197 -197
  41. package/src/review/fixtures/valid-review.json +42 -42
  42. package/src/review/lib.mjs +894 -894
  43. package/src/review/lib.test.mjs +266 -266
  44. package/src/review/schema.json +196 -196
  45. package/src/review/signals.test.mjs +62 -62
  46. package/src/score-cli.mjs +68 -68
  47. package/src/score.mjs +568 -566
  48. package/src/score.test.mjs +366 -340
  49. package/src/session-reminder.mjs +207 -207
  50. package/src/session-status.mjs +70 -70
  51. package/src/set-models.mjs +186 -186
  52. package/src/set-phase.mjs +205 -205
  53. package/src/set-prefs.mjs +294 -294
  54. package/src/specs-sync.mjs +234 -0
  55. package/src/specs-sync.test.mjs +114 -0
  56. package/src/spine.mjs +93 -93
  57. package/src/triage-prompt.mjs +175 -175
  58. package/src/triage-prompt.test.mjs +50 -50
  59. package/src/vendor-openspec-overlays.mjs +176 -176
  60. package/src/vendor-openspec-overlays.test.mjs +62 -62
  61. package/vendor/skills/archive-to-adr/SKILL.md +149 -149
  62. package/vendor/skills/forge/SKILL.md +136 -136
  63. package/vendor/skills/forge/docs/forge.md +650 -647
  64. package/vendor/skills/forge/phases/brainstorm.md +23 -23
  65. package/vendor/skills/forge/phases/finish.md +90 -87
  66. package/vendor/skills/forge/phases/implement.md +77 -77
  67. package/vendor/skills/forge/phases/plan-openspec.md +60 -60
  68. package/vendor/skills/forge/phases/plan-specs.md +163 -117
  69. package/vendor/skills/forge/phases/review.md +25 -25
  70. package/vendor/skills/forge/phases/verify.md +124 -124
  71. package/vendor/skills/forge/references/forge-layout.md +85 -85
  72. package/vendor/skills/forge/references/pace.md +115 -115
  73. package/vendor/skills/forge/references/plan-routing.md +52 -51
  74. package/vendor/skills/forge/references/runtime-integrity.md +232 -225
  75. package/vendor/skills/forge/references/substantial-work.md +37 -37
  76. package/vendor/skills/forge/references/test-evidence.md +30 -30
  77. package/vendor/skills/forge/references/test-strategy.md +68 -68
  78. package/vendor/skills/forge/skills/subagent-driven-development/SKILL.md +87 -87
  79. package/vendor/skills/forge/subagents/final-reviewer-prompt.md +56 -56
  80. package/vendor/skills/forge/subagents/implementer-prompt.md +38 -38
  81. package/vendor/skills/git-resolve-adr-conflict/SKILL.md +132 -132
  82. package/vendor/skills/thorough-code-review/SKILL.md +290 -290
  83. package/vendor/skills/thorough-code-review/examples.md +133 -133
  84. package/vendor/skills/thorough-code-review/reference/accepted-risks.md +26 -26
  85. package/vendor/skills/thorough-code-review/reference/lenses.md +96 -96
  86. package/vendor/skills/thorough-code-review/reference/phase1-scout.md +62 -62
  87. package/vendor/skills/thorough-code-review/reference/phase2-skeptic.md +105 -105
  88. package/vendor/skills/thorough-code-review/reference/report-schema.json +222 -222
  89. package/vendor/skills/thorough-code-review/reference/report-template.md +115 -115
  90. package/vendor/skills/thorough-code-review/reference/severity-rubric.md +49 -49
  91. package/vendor/skills/thorough-code-review/reference/signals-preflight.md +55 -55
  92. package/vendor/templates/adr/README.md +7 -7
  93. package/vendor/templates/adr/decisions.md +141 -141
  94. package/vendor/templates/adr/hooks/check-pending-adrs.mjs +74 -74
  95. package/vendor/templates/adr/hooks/check-pending-adrs.sh +3 -3
  96. package/vendor/templates/adr/hooks/openspec-archive-agent-message.mjs +52 -52
  97. package/vendor/templates/adr/hooks/openspec-archive-agent-message.sh +3 -3
  98. package/vendor/templates/project/claude/commands/forge-apply.md +75 -75
  99. package/vendor/templates/project/claude/commands/forge-brainstorm.md +7 -7
  100. package/vendor/templates/project/claude/commands/forge-build.md +17 -17
  101. package/vendor/templates/project/claude/commands/forge-plan.md +12 -12
  102. package/vendor/templates/project/claude/commands/forge-skip.md +14 -14
  103. package/vendor/templates/project/claude/commands/forge-status.md +16 -16
  104. package/vendor/templates/project/claude/commands/forge.md +16 -16
  105. package/vendor/templates/project/claude/hooks/forge-prompt-hook.mjs +73 -73
  106. package/vendor/templates/project/claude/hooks/forge-session-start.mjs +19 -19
  107. package/vendor/templates/project/claude/hooks/forge-triage-hook.mjs +77 -77
  108. package/vendor/templates/project/cursor/commands/forge-apply.md +75 -75
  109. package/vendor/templates/project/cursor/commands/forge-brainstorm.md +10 -10
  110. package/vendor/templates/project/cursor/commands/forge-build.md +17 -17
  111. package/vendor/templates/project/cursor/commands/forge-plan.md +15 -15
  112. package/vendor/templates/project/cursor/commands/forge-skip.md +14 -14
  113. package/vendor/templates/project/cursor/commands/forge-status.md +16 -16
  114. package/vendor/templates/project/cursor/commands/forge.md +16 -16
  115. package/vendor/templates/project/cursor/hooks/forge-session-start.mjs +30 -30
  116. package/vendor/templates/project/cursor/hooks/forge-session-start.sh +3 -3
@@ -1,566 +1,566 @@
1
- import test from 'node:test';
2
- import assert from 'node:assert/strict';
3
- import fs from 'node:fs';
4
- import path from 'node:path';
5
- import { tmpdir } from 'node:os';
6
- import {
7
- JOBS_SIGNAL_RE,
8
- addDeferral,
9
- checkE2eGate,
10
- e2ePath,
11
- e2eStepsHash,
12
- e2eTemplate,
13
- initE2e,
14
- initSpine,
15
- loadDeferrals,
16
- openDeferrals,
17
- resolveChangeDir,
18
- resolveDeferral,
19
- runE2eSteps,
20
- runIntegrityChecks,
21
- sessionJobsSignalText,
22
- spinePath,
23
- spineTemplate,
24
- validateE2e,
25
- validateSpine,
26
- writeE2eResults,
27
- } from './integrity.mjs';
28
-
29
- function tmp(prefix) {
30
- return fs.mkdtempSync(path.join(tmpdir(), prefix));
31
- }
32
-
33
- function validRow(overrides = {}) {
34
- return {
35
- capability: 'REQ-GOV-01 matching',
36
- library: 'services/etl-core/matcher.py',
37
- runtimeOwner: 'worker job analyze_study',
38
- writes: 'study_proposals',
39
- reads: 'N/A',
40
- uiConsumer: 'Proposals page',
41
- evidence: 'tasks/12-analyze/test-evidence.md',
42
- ...overrides,
43
- };
44
- }
45
-
46
- test('validateSpine: filled rows pass', () => {
47
- const result = validateSpine({ change: 'x', notApplicable: null, rows: [validRow()] });
48
- assert.equal(result.ok, true);
49
- assert.deepEqual(result.problems, []);
50
- });
51
-
52
- test('validateSpine: library-only row fails (missing runtimeOwner/writes/evidence)', () => {
53
- const result = validateSpine({
54
- rows: [validRow({ runtimeOwner: '', writes: '', evidence: '' })],
55
- });
56
- assert.equal(result.ok, false);
57
- assert.equal(result.problems.length, 3);
58
- assert.match(result.problems.join('\n'), /runtimeOwner/);
59
- assert.match(result.problems.join('\n'), /writes/);
60
- assert.match(result.problems.join('\n'), /evidence/);
61
- });
62
-
63
- test('validateSpine: scaffold placeholders are rejected', () => {
64
- const result = validateSpine(spineTemplate({ change: 'x' }));
65
- assert.equal(result.ok, false);
66
- assert.match(result.problems.join('\n'), /scaffold placeholder/);
67
- });
68
-
69
- test('validateSpine: empty rows fail; notApplicable opt-out passes', () => {
70
- assert.equal(validateSpine({ rows: [] }).ok, false);
71
- assert.equal(validateSpine({ rows: [], notApplicable: 'docs-only change' }).ok, true);
72
- });
73
-
74
- test('spine init writes template and refuses overwrite without force', () => {
75
- const dir = tmp('forge-spine-');
76
- try {
77
- const file = path.join(dir, 'spine.json');
78
- initSpine({ file, change: 'my-change' });
79
- const doc = JSON.parse(fs.readFileSync(file, 'utf8'));
80
- assert.equal(doc.change, 'my-change');
81
- assert.throws(() => initSpine({ file, change: 'my-change' }), /already exists/);
82
- initSpine({ file, change: 'other', force: true });
83
- assert.equal(JSON.parse(fs.readFileSync(file, 'utf8')).change, 'other');
84
- } finally {
85
- fs.rmSync(dir, { recursive: true, force: true });
86
- }
87
- });
88
-
89
- test('resolveChangeDir: openspec plan type and session-dir fallback', () => {
90
- const cwd = tmp('forge-changedir-');
91
- try {
92
- const dir = resolveChangeDir({
93
- cwd,
94
- session: { planType: 'openspec', openspecChange: 'my-change' },
95
- });
96
- assert.equal(dir, path.join(cwd, 'openspec', 'changes', 'my-change'));
97
- assert.equal(resolveChangeDir({ cwd, session: { openspecChange: null } }), null);
98
- const sessionDir = path.join(cwd, '.forge', 'sessions', 's1');
99
- assert.equal(
100
- spinePath({ cwd, session: { openspecChange: null }, sessionDir }),
101
- path.join(sessionDir, 'spine.json'),
102
- );
103
- } finally {
104
- fs.rmSync(cwd, { recursive: true, force: true });
105
- }
106
- });
107
-
108
- test('resolveChangeDir: falls back to the archived copy after archive', () => {
109
- for (const [planType, root] of [
110
- ['openspec', ['openspec', 'changes']],
111
- ['specs', ['specs', 'changes']],
112
- ]) {
113
- const cwd = tmp('forge-changedir-arch-');
114
- try {
115
- const changesDir = path.join(cwd, ...root);
116
- const liveDir = path.join(changesDir, 'add-customer-registry');
117
- fs.mkdirSync(liveDir, { recursive: true });
118
- const session = { planType, openspecChange: 'add-customer-registry' };
119
-
120
- // Live dir present → live path.
121
- assert.equal(resolveChangeDir({ cwd, session }), liveDir);
122
-
123
- // Archive moves it → resolve follows into changes/archive/<date>-<name>.
124
- const archived = path.join(changesDir, 'archive', '2026-07-20-add-customer-registry');
125
- fs.mkdirSync(path.dirname(archived), { recursive: true });
126
- fs.renameSync(liveDir, archived);
127
- assert.equal(resolveChangeDir({ cwd, session }), archived);
128
-
129
- // Newest archive wins when a change name recurs.
130
- const older = path.join(changesDir, 'archive', '2025-01-01-add-customer-registry');
131
- fs.mkdirSync(older, { recursive: true });
132
- assert.equal(resolveChangeDir({ cwd, session }), archived);
133
-
134
- // No false match on a different change that ends with the same words.
135
- fs.mkdirSync(path.join(changesDir, 'archive', '2026-07-20-extra-add-customer-registry'), {
136
- recursive: true,
137
- });
138
- assert.equal(resolveChangeDir({ cwd, session }), archived);
139
-
140
- // forWrite (spine/e2e init) never follows into the archive — writes must
141
- // target the live change dir so scaffolding can't corrupt frozen history.
142
- assert.equal(resolveChangeDir({ cwd, session, forWrite: true }), liveDir);
143
- } finally {
144
- fs.rmSync(cwd, { recursive: true, force: true });
145
- }
146
- }
147
- });
148
-
149
- test('spinePath/e2ePath forWrite target the live dir even after archive', () => {
150
- const cwd = tmp('forge-write-guard-');
151
- try {
152
- const session = { planType: 'openspec', openspecChange: 'add-customer-registry' };
153
- const changesDir = path.join(cwd, 'openspec', 'changes');
154
- // Only the archived copy exists — mimics running init after archive.
155
- const archived = path.join(changesDir, 'archive', '2026-07-20-add-customer-registry');
156
- fs.mkdirSync(archived, { recursive: true });
157
- const liveDir = path.join(changesDir, 'add-customer-registry');
158
-
159
- // Read path resolves the archive; write path stays on the (absent) live dir.
160
- assert.equal(spinePath({ cwd, session }), path.join(archived, 'spine.json'));
161
- assert.equal(spinePath({ cwd, session, forWrite: true }), path.join(liveDir, 'spine.json'));
162
- assert.equal(e2ePath({ cwd, session }), path.join(archived, 'e2e.json'));
163
- assert.equal(e2ePath({ cwd, session, forWrite: true }), path.join(liveDir, 'e2e.json'));
164
- } finally {
165
- fs.rmSync(cwd, { recursive: true, force: true });
166
- }
167
- });
168
-
169
- test('runIntegrityChecks: passes after archive (spine resolves in archive dir)', () => {
170
- const cwd = tmp('forge-int-archived-');
171
- try {
172
- const sessionDir = makeSessionDir(cwd);
173
- const session = { planType: 'openspec', openspecChange: 'add-customer-registry', slug: 'add-customer-registry' };
174
-
175
- // Green while live: spine in the change dir (sync-only notApplicable).
176
- const liveDir = path.join(cwd, 'openspec', 'changes', 'add-customer-registry');
177
- fs.mkdirSync(liveDir, { recursive: true });
178
- fs.writeFileSync(
179
- path.join(liveDir, 'spine.json'),
180
- `${JSON.stringify({ rows: [], notApplicable: 'sync HTTP only' }, null, 2)}\n`,
181
- 'utf8',
182
- );
183
- assert.equal(runIntegrityChecks({ cwd, sessionDir, session }).ok, true);
184
-
185
- // Archive the change — the mechanical gate must STILL pass (the bug: it
186
- // used to look only at the vanished live path and fail).
187
- const archived = path.join(cwd, 'openspec', 'changes', 'archive', '2026-07-20-add-customer-registry');
188
- fs.mkdirSync(path.dirname(archived), { recursive: true });
189
- fs.renameSync(liveDir, archived);
190
- assert.equal(runIntegrityChecks({ cwd, sessionDir, session }).ok, true);
191
- } finally {
192
- fs.rmSync(cwd, { recursive: true, force: true });
193
- }
194
- });
195
-
196
- test('deferrals: add, list, resolve lifecycle', () => {
197
- const dir = tmp('forge-defer-');
198
- try {
199
- addDeferral(dir, { task: '9.2', reason: 'wiring lands in 9.7' });
200
- assert.equal(openDeferrals(dir).length, 1);
201
- assert.throws(() => addDeferral(dir, { task: '9.2', reason: 'dup' }), /already open/);
202
- resolveDeferral(dir, '9.2');
203
- assert.equal(openDeferrals(dir).length, 0);
204
- assert.equal(loadDeferrals(dir).deferrals.length, 1);
205
- assert.throws(() => resolveDeferral(dir, '9.2'), /No open deferral/);
206
- } finally {
207
- fs.rmSync(dir, { recursive: true, force: true });
208
- }
209
- });
210
-
211
- test('deferrals: add requires task and reason', () => {
212
- const dir = tmp('forge-defer-req-');
213
- try {
214
- assert.throws(() => addDeferral(dir, { task: '', reason: 'x' }), /--task/);
215
- assert.throws(() => addDeferral(dir, { task: '1.1', reason: '' }), /--reason/);
216
- } finally {
217
- fs.rmSync(dir, { recursive: true, force: true });
218
- }
219
- });
220
-
221
- test('JOBS_SIGNAL_RE + sessionJobsSignalText', () => {
222
- assert.equal(JOBS_SIGNAL_RE.test('etl-surveydb-harmonization-platform worker'), true);
223
- assert.equal(JOBS_SIGNAL_RE.test('fix toolbar padding'), false);
224
- assert.equal(
225
- sessionJobsSignalText({ paceSignal: null, slug: 'my-slug', openspecChange: 'chg' }),
226
- 'my-slug chg',
227
- );
228
- });
229
-
230
- function makeSessionDir(root) {
231
- const dir = path.join(root, '.forge', 'sessions', 's1');
232
- fs.mkdirSync(dir, { recursive: true });
233
- return dir;
234
- }
235
-
236
- test('runIntegrityChecks: missing spine always fails (not keyword-gated)', () => {
237
- const cwd = tmp('forge-int-clean-');
238
- try {
239
- const sessionDir = makeSessionDir(cwd);
240
- const result = runIntegrityChecks({
241
- cwd,
242
- sessionDir,
243
- session: { slug: 'fix-toolbar', openspecChange: null },
244
- });
245
- assert.equal(result.ok, false);
246
- assert.match(result.problems.join('\n'), /spine\.json required/);
247
- } finally {
248
- fs.rmSync(cwd, { recursive: true, force: true });
249
- }
250
- });
251
-
252
- test('runIntegrityChecks: notApplicable spine allows sync-only without product-loop', () => {
253
- const cwd = tmp('forge-int-na-sync-');
254
- try {
255
- const sessionDir = makeSessionDir(cwd);
256
- fs.writeFileSync(
257
- path.join(sessionDir, 'spine.json'),
258
- `${JSON.stringify(
259
- { rows: [], notApplicable: 'sync HTTP only — no async producer/consumer' },
260
- null,
261
- 2,
262
- )}\n`,
263
- 'utf8',
264
- );
265
- const result = runIntegrityChecks({
266
- cwd,
267
- sessionDir,
268
- session: { slug: 'fix-toolbar', openspecChange: null },
269
- });
270
- assert.equal(result.ok, true);
271
- } finally {
272
- fs.rmSync(cwd, { recursive: true, force: true });
273
- }
274
- });
275
-
276
- test('runIntegrityChecks: unresolved deferral fails', () => {
277
- const cwd = tmp('forge-int-defer-');
278
- try {
279
- const sessionDir = makeSessionDir(cwd);
280
- fs.writeFileSync(
281
- path.join(sessionDir, 'spine.json'),
282
- `${JSON.stringify({ rows: [], notApplicable: 'sync only' }, null, 2)}\n`,
283
- 'utf8',
284
- );
285
- addDeferral(sessionDir, { task: '9.2', reason: 'later' });
286
- const result = runIntegrityChecks({
287
- cwd,
288
- sessionDir,
289
- session: { slug: 'fix-toolbar', openspecChange: null },
290
- });
291
- assert.equal(result.ok, false);
292
- assert.match(result.problems.join('\n'), /unresolved deferrals: 9\.2/);
293
- } finally {
294
- fs.rmSync(cwd, { recursive: true, force: true });
295
- }
296
- });
297
-
298
- test('runIntegrityChecks: empty slug without spine still fails', () => {
299
- const cwd = tmp('forge-int-jobs-');
300
- try {
301
- const sessionDir = makeSessionDir(cwd);
302
- const result = runIntegrityChecks({
303
- cwd,
304
- sessionDir,
305
- session: { slug: 'add-harmonization-platform', openspecChange: null },
306
- });
307
- assert.equal(result.ok, false);
308
- assert.match(result.problems.join('\n'), /spine\.json required/);
309
- } finally {
310
- fs.rmSync(cwd, { recursive: true, force: true });
311
- }
312
- });
313
-
314
- function greenStep(overrides = {}) {
315
- return {
316
- name: 'produce',
317
- cmd: 'node -e "console.log(\'proposals: 3\')"',
318
- ...overrides,
319
- };
320
- }
321
-
322
- function writeSpineWithRows(sessionDir) {
323
- fs.writeFileSync(
324
- path.join(sessionDir, 'spine.json'),
325
- `${JSON.stringify({ change: null, notApplicable: null, rows: [validRow()] }, null, 2)}\n`,
326
- 'utf8',
327
- );
328
- }
329
-
330
- function writeE2eDoc(sessionDir, doc) {
331
- fs.writeFileSync(path.join(sessionDir, 'e2e.json'), `${JSON.stringify(doc, null, 2)}\n`, 'utf8');
332
- }
333
-
334
- test('validateE2e: filled steps pass; template placeholders rejected', () => {
335
- assert.equal(validateE2e({ notApplicable: null, steps: [greenStep()] }).ok, true);
336
- const scaffold = validateE2e(e2eTemplate({ change: 'x' }));
337
- assert.equal(scaffold.ok, false);
338
- assert.match(scaffold.problems.join('\n'), /scaffold placeholder/);
339
- });
340
-
341
- test('validateE2e: missing cmd, bad regex, bad timeout, empty steps', () => {
342
- assert.match(
343
- validateE2e({ steps: [{ name: 'x', cmd: '' }] }).problems.join('\n'),
344
- /missing cmd/,
345
- );
346
- assert.match(
347
- validateE2e({ steps: [greenStep({ expect: '(' })] }).problems.join('\n'),
348
- /not a valid regex/,
349
- );
350
- assert.match(
351
- validateE2e({ steps: [greenStep({ timeoutMs: -5 })] }).problems.join('\n'),
352
- /timeoutMs/,
353
- );
354
- assert.match(validateE2e({ steps: [] }).problems.join('\n'), /steps is empty/);
355
- assert.equal(validateE2e({ steps: [], notApplicable: 'no headless env — manual device loop' }).ok, true);
356
- });
357
-
358
- test('e2e init writes template and refuses overwrite without force', () => {
359
- const dir = tmp('forge-e2e-init-');
360
- try {
361
- const file = path.join(dir, 'e2e.json');
362
- initE2e({ file, change: 'my-change' });
363
- assert.equal(JSON.parse(fs.readFileSync(file, 'utf8')).change, 'my-change');
364
- assert.throws(() => initE2e({ file, change: 'my-change' }), /already exists/);
365
- initE2e({ file, change: 'other', force: true });
366
- assert.equal(JSON.parse(fs.readFileSync(file, 'utf8')).change, 'other');
367
- assert.equal(
368
- e2ePath({ cwd: dir, session: { openspecChange: null }, sessionDir: dir }),
369
- file,
370
- );
371
- } finally {
372
- fs.rmSync(dir, { recursive: true, force: true });
373
- }
374
- });
375
-
376
- test('runE2eSteps: green run with expect match', () => {
377
- const results = runE2eSteps({ steps: [greenStep({ expect: 'proposals: \\d+' })] });
378
- assert.equal(results.ok, true);
379
- assert.equal(results.steps[0].exitCode, 0);
380
- assert.equal(results.steps[0].expectMatched, true);
381
- assert.equal(results.stepsHash, e2eStepsHash([greenStep({ expect: 'proposals: \\d+' })]));
382
- });
383
-
384
- test('runE2eSteps: non-zero exit fails and skips later steps', () => {
385
- const results = runE2eSteps({
386
- steps: [
387
- { name: 'boom', cmd: 'node -e "process.exit(3)"' },
388
- greenStep({ name: 'never' }),
389
- ],
390
- });
391
- assert.equal(results.ok, false);
392
- assert.equal(results.steps[0].exitCode, 3);
393
- assert.equal(results.steps[1].skipped, true);
394
- });
395
-
396
- test('runE2eSteps: exit 0 but expect mismatch fails', () => {
397
- const results = runE2eSteps({ steps: [greenStep({ expect: 'ratified: \\d+' })] });
398
- assert.equal(results.ok, false);
399
- assert.equal(results.steps[0].expectMatched, false);
400
- });
401
-
402
- test('checkE2eGate: missing file, missing results, stale hash, failed run, green, notApplicable', () => {
403
- const dir = tmp('forge-e2e-gate-');
404
- try {
405
- const e2eFile = path.join(dir, 'e2e.json');
406
-
407
- let gate = checkE2eGate({ e2eFile, sessionDir: dir });
408
- assert.match(gate.problems.join('\n'), /e2e\.json required/);
409
-
410
- writeE2eDoc(dir, { notApplicable: null, steps: [greenStep()] });
411
- gate = checkE2eGate({ e2eFile, sessionDir: dir });
412
- assert.match(gate.problems.join('\n'), /e2e-results\.json missing/);
413
-
414
- const results = runE2eSteps({ steps: [greenStep()] });
415
- writeE2eResults(dir, results);
416
- gate = checkE2eGate({ e2eFile, sessionDir: dir });
417
- assert.deepEqual(gate.problems, []);
418
-
419
- writeE2eDoc(dir, { notApplicable: null, steps: [greenStep({ name: 'edited' })] });
420
- gate = checkE2eGate({ e2eFile, sessionDir: dir });
421
- assert.match(gate.problems.join('\n'), /stale/);
422
-
423
- writeE2eDoc(dir, { notApplicable: null, steps: [{ name: 'boom', cmd: 'node -e "process.exit(1)"' }] });
424
- writeE2eResults(dir, runE2eSteps({ steps: [{ name: 'boom', cmd: 'node -e "process.exit(1)"' }] }));
425
- gate = checkE2eGate({ e2eFile, sessionDir: dir });
426
- assert.match(gate.problems.join('\n'), /failed at step "boom"/);
427
-
428
- writeE2eDoc(dir, { notApplicable: 'loop needs a physical device', steps: [] });
429
- gate = checkE2eGate({ e2eFile, sessionDir: dir });
430
- assert.deepEqual(gate.problems, []);
431
- assert.equal(gate.notApplicable, true);
432
- } finally {
433
- fs.rmSync(dir, { recursive: true, force: true });
434
- }
435
- });
436
-
437
- test('runIntegrityChecks: spine rows demand an executed green e2e run', () => {
438
- const cwd = tmp('forge-int-loop-');
439
- try {
440
- const sessionDir = makeSessionDir(cwd);
441
- writeSpineWithRows(sessionDir);
442
- const session = { slug: 'wire-worker-jobs', openspecChange: null };
443
-
444
- let result = runIntegrityChecks({ cwd, sessionDir, session });
445
- assert.equal(result.ok, false);
446
- assert.match(result.problems.join('\n'), /e2e\.json required/);
447
-
448
- writeE2eDoc(sessionDir, { notApplicable: null, steps: [greenStep()] });
449
- result = runIntegrityChecks({ cwd, sessionDir, session });
450
- assert.equal(result.ok, false);
451
- assert.match(result.problems.join('\n'), /e2e-results\.json missing/);
452
-
453
- writeE2eResults(sessionDir, runE2eSteps({ steps: [greenStep()] }));
454
- result = runIntegrityChecks({ cwd, sessionDir, session });
455
- assert.equal(result.ok, true);
456
- assert.equal(result.e2eFile, path.join(sessionDir, 'e2e.json'));
457
-
458
- // prose "## Product loop" alone no longer satisfies the gate
459
- fs.rmSync(path.join(sessionDir, 'e2e-results.json'));
460
- fs.writeFileSync(
461
- path.join(sessionDir, 'verify-evidence.md'),
462
- '# Verify\n\n## Product loop\n\ningest -> analyze -> ratify: output differs\n',
463
- 'utf8',
464
- );
465
- result = runIntegrityChecks({ cwd, sessionDir, session });
466
- assert.equal(result.ok, false);
467
- assert.match(result.problems.join('\n'), /e2e-results\.json missing/);
468
- } finally {
469
- fs.rmSync(cwd, { recursive: true, force: true });
470
- }
471
- });
472
-
473
- test('runIntegrityChecks: project-level e2e disable skips the executed-run demand', () => {
474
- const cwd = tmp('forge-int-e2eoff-');
475
- try {
476
- const sessionDir = makeSessionDir(cwd);
477
- writeSpineWithRows(sessionDir);
478
- const session = { slug: 'wire-worker-jobs', openspecChange: null };
479
-
480
- let result = runIntegrityChecks({ cwd, sessionDir, session });
481
- assert.equal(result.ok, false);
482
- assert.match(result.problems.join('\n'), /e2e\.json required/);
483
-
484
- fs.writeFileSync(
485
- path.join(cwd, '.forge', 'config.json'),
486
- `${JSON.stringify({ e2e: { disabled: 'operator accepts manual verification' } }, null, 2)}\n`,
487
- 'utf8',
488
- );
489
- result = runIntegrityChecks({ cwd, sessionDir, session });
490
- assert.equal(result.ok, true);
491
- assert.equal(result.e2eDisabled, 'operator accepts manual verification');
492
-
493
- // BLOCKED evidence still blocks — the off switch only drops the run demand.
494
- fs.writeFileSync(path.join(sessionDir, 'verify-evidence.md'), 'BLOCKED: cannot verify\n', 'utf8');
495
- result = runIntegrityChecks({ cwd, sessionDir, session });
496
- assert.equal(result.ok, false);
497
- assert.match(result.problems.join('\n'), /BLOCKED/);
498
- } finally {
499
- fs.rmSync(cwd, { recursive: true, force: true });
500
- }
501
- });
502
-
503
- test('runIntegrityChecks: BLOCKED in verify-evidence blocks even with green e2e', () => {
504
- const cwd = tmp('forge-int-blocked-');
505
- try {
506
- const sessionDir = makeSessionDir(cwd);
507
- writeSpineWithRows(sessionDir);
508
- writeE2eDoc(sessionDir, { notApplicable: null, steps: [greenStep()] });
509
- writeE2eResults(sessionDir, runE2eSteps({ steps: [greenStep()] }));
510
- fs.writeFileSync(
511
- path.join(sessionDir, 'verify-evidence.md'),
512
- '# Verify\n\nBLOCKED: ratify UI unreachable in CI\n',
513
- 'utf8',
514
- );
515
- const result = runIntegrityChecks({
516
- cwd,
517
- sessionDir,
518
- session: { slug: 'wire-worker-jobs', openspecChange: null },
519
- });
520
- assert.equal(result.ok, false);
521
- assert.match(result.problems.join('\n'), /BLOCKED/);
522
- } finally {
523
- fs.rmSync(cwd, { recursive: true, force: true });
524
- }
525
- });
526
-
527
- test('runIntegrityChecks: invalid spine fails even without jobs signal', () => {
528
- const cwd = tmp('forge-int-badspine-');
529
- try {
530
- const sessionDir = makeSessionDir(cwd);
531
- fs.writeFileSync(
532
- path.join(sessionDir, 'spine.json'),
533
- `${JSON.stringify({ rows: [validRow({ runtimeOwner: '' })] }, null, 2)}\n`,
534
- 'utf8',
535
- );
536
- const result = runIntegrityChecks({
537
- cwd,
538
- sessionDir,
539
- session: { slug: 'fix-toolbar', openspecChange: null },
540
- });
541
- assert.equal(result.ok, false);
542
- assert.match(result.problems.join('\n'), /spine: .*runtimeOwner/);
543
- } finally {
544
- fs.rmSync(cwd, { recursive: true, force: true });
545
- }
546
- });
547
-
548
- test('runIntegrityChecks: notApplicable spine passes without evidence demands', () => {
549
- const cwd = tmp('forge-int-na-');
550
- try {
551
- const sessionDir = makeSessionDir(cwd);
552
- fs.writeFileSync(
553
- path.join(sessionDir, 'spine.json'),
554
- `${JSON.stringify({ rows: [], notApplicable: 'docs-only change' }, null, 2)}\n`,
555
- 'utf8',
556
- );
557
- const result = runIntegrityChecks({
558
- cwd,
559
- sessionDir,
560
- session: { slug: 'wire-worker-jobs', openspecChange: null },
561
- });
562
- assert.equal(result.ok, true);
563
- } finally {
564
- fs.rmSync(cwd, { recursive: true, force: true });
565
- }
566
- });
1
+ import test from 'node:test';
2
+ import assert from 'node:assert/strict';
3
+ import fs from 'node:fs';
4
+ import path from 'node:path';
5
+ import { tmpdir } from 'node:os';
6
+ import {
7
+ JOBS_SIGNAL_RE,
8
+ addDeferral,
9
+ checkE2eGate,
10
+ e2ePath,
11
+ e2eStepsHash,
12
+ e2eTemplate,
13
+ initE2e,
14
+ initSpine,
15
+ loadDeferrals,
16
+ openDeferrals,
17
+ resolveChangeDir,
18
+ resolveDeferral,
19
+ runE2eSteps,
20
+ runIntegrityChecks,
21
+ sessionJobsSignalText,
22
+ spinePath,
23
+ spineTemplate,
24
+ validateE2e,
25
+ validateSpine,
26
+ writeE2eResults,
27
+ } from './integrity.mjs';
28
+
29
+ function tmp(prefix) {
30
+ return fs.mkdtempSync(path.join(tmpdir(), prefix));
31
+ }
32
+
33
+ function validRow(overrides = {}) {
34
+ return {
35
+ capability: 'REQ-GOV-01 matching',
36
+ library: 'services/etl-core/matcher.py',
37
+ runtimeOwner: 'worker job analyze_study',
38
+ writes: 'study_proposals',
39
+ reads: 'N/A',
40
+ uiConsumer: 'Proposals page',
41
+ evidence: 'tasks/12-analyze/test-evidence.md',
42
+ ...overrides,
43
+ };
44
+ }
45
+
46
+ test('validateSpine: filled rows pass', () => {
47
+ const result = validateSpine({ change: 'x', notApplicable: null, rows: [validRow()] });
48
+ assert.equal(result.ok, true);
49
+ assert.deepEqual(result.problems, []);
50
+ });
51
+
52
+ test('validateSpine: library-only row fails (missing runtimeOwner/writes/evidence)', () => {
53
+ const result = validateSpine({
54
+ rows: [validRow({ runtimeOwner: '', writes: '', evidence: '' })],
55
+ });
56
+ assert.equal(result.ok, false);
57
+ assert.equal(result.problems.length, 3);
58
+ assert.match(result.problems.join('\n'), /runtimeOwner/);
59
+ assert.match(result.problems.join('\n'), /writes/);
60
+ assert.match(result.problems.join('\n'), /evidence/);
61
+ });
62
+
63
+ test('validateSpine: scaffold placeholders are rejected', () => {
64
+ const result = validateSpine(spineTemplate({ change: 'x' }));
65
+ assert.equal(result.ok, false);
66
+ assert.match(result.problems.join('\n'), /scaffold placeholder/);
67
+ });
68
+
69
+ test('validateSpine: empty rows fail; notApplicable opt-out passes', () => {
70
+ assert.equal(validateSpine({ rows: [] }).ok, false);
71
+ assert.equal(validateSpine({ rows: [], notApplicable: 'docs-only change' }).ok, true);
72
+ });
73
+
74
+ test('spine init writes template and refuses overwrite without force', () => {
75
+ const dir = tmp('forge-spine-');
76
+ try {
77
+ const file = path.join(dir, 'spine.json');
78
+ initSpine({ file, change: 'my-change' });
79
+ const doc = JSON.parse(fs.readFileSync(file, 'utf8'));
80
+ assert.equal(doc.change, 'my-change');
81
+ assert.throws(() => initSpine({ file, change: 'my-change' }), /already exists/);
82
+ initSpine({ file, change: 'other', force: true });
83
+ assert.equal(JSON.parse(fs.readFileSync(file, 'utf8')).change, 'other');
84
+ } finally {
85
+ fs.rmSync(dir, { recursive: true, force: true });
86
+ }
87
+ });
88
+
89
+ test('resolveChangeDir: openspec plan type and session-dir fallback', () => {
90
+ const cwd = tmp('forge-changedir-');
91
+ try {
92
+ const dir = resolveChangeDir({
93
+ cwd,
94
+ session: { planType: 'openspec', openspecChange: 'my-change' },
95
+ });
96
+ assert.equal(dir, path.join(cwd, 'openspec', 'changes', 'my-change'));
97
+ assert.equal(resolveChangeDir({ cwd, session: { openspecChange: null } }), null);
98
+ const sessionDir = path.join(cwd, '.forge', 'sessions', 's1');
99
+ assert.equal(
100
+ spinePath({ cwd, session: { openspecChange: null }, sessionDir }),
101
+ path.join(sessionDir, 'spine.json'),
102
+ );
103
+ } finally {
104
+ fs.rmSync(cwd, { recursive: true, force: true });
105
+ }
106
+ });
107
+
108
+ test('resolveChangeDir: falls back to the archived copy after archive', () => {
109
+ for (const [planType, root] of [
110
+ ['openspec', ['openspec', 'changes']],
111
+ ['specs', ['specs', 'changes']],
112
+ ]) {
113
+ const cwd = tmp('forge-changedir-arch-');
114
+ try {
115
+ const changesDir = path.join(cwd, ...root);
116
+ const liveDir = path.join(changesDir, 'add-customer-registry');
117
+ fs.mkdirSync(liveDir, { recursive: true });
118
+ const session = { planType, openspecChange: 'add-customer-registry' };
119
+
120
+ // Live dir present → live path.
121
+ assert.equal(resolveChangeDir({ cwd, session }), liveDir);
122
+
123
+ // Archive moves it → resolve follows into changes/archive/<date>-<name>.
124
+ const archived = path.join(changesDir, 'archive', '2026-07-20-add-customer-registry');
125
+ fs.mkdirSync(path.dirname(archived), { recursive: true });
126
+ fs.renameSync(liveDir, archived);
127
+ assert.equal(resolveChangeDir({ cwd, session }), archived);
128
+
129
+ // Newest archive wins when a change name recurs.
130
+ const older = path.join(changesDir, 'archive', '2025-01-01-add-customer-registry');
131
+ fs.mkdirSync(older, { recursive: true });
132
+ assert.equal(resolveChangeDir({ cwd, session }), archived);
133
+
134
+ // No false match on a different change that ends with the same words.
135
+ fs.mkdirSync(path.join(changesDir, 'archive', '2026-07-20-extra-add-customer-registry'), {
136
+ recursive: true,
137
+ });
138
+ assert.equal(resolveChangeDir({ cwd, session }), archived);
139
+
140
+ // forWrite (spine/e2e init) never follows into the archive — writes must
141
+ // target the live change dir so scaffolding can't corrupt frozen history.
142
+ assert.equal(resolveChangeDir({ cwd, session, forWrite: true }), liveDir);
143
+ } finally {
144
+ fs.rmSync(cwd, { recursive: true, force: true });
145
+ }
146
+ }
147
+ });
148
+
149
+ test('spinePath/e2ePath forWrite target the live dir even after archive', () => {
150
+ const cwd = tmp('forge-write-guard-');
151
+ try {
152
+ const session = { planType: 'openspec', openspecChange: 'add-customer-registry' };
153
+ const changesDir = path.join(cwd, 'openspec', 'changes');
154
+ // Only the archived copy exists — mimics running init after archive.
155
+ const archived = path.join(changesDir, 'archive', '2026-07-20-add-customer-registry');
156
+ fs.mkdirSync(archived, { recursive: true });
157
+ const liveDir = path.join(changesDir, 'add-customer-registry');
158
+
159
+ // Read path resolves the archive; write path stays on the (absent) live dir.
160
+ assert.equal(spinePath({ cwd, session }), path.join(archived, 'spine.json'));
161
+ assert.equal(spinePath({ cwd, session, forWrite: true }), path.join(liveDir, 'spine.json'));
162
+ assert.equal(e2ePath({ cwd, session }), path.join(archived, 'e2e.json'));
163
+ assert.equal(e2ePath({ cwd, session, forWrite: true }), path.join(liveDir, 'e2e.json'));
164
+ } finally {
165
+ fs.rmSync(cwd, { recursive: true, force: true });
166
+ }
167
+ });
168
+
169
+ test('runIntegrityChecks: passes after archive (spine resolves in archive dir)', () => {
170
+ const cwd = tmp('forge-int-archived-');
171
+ try {
172
+ const sessionDir = makeSessionDir(cwd);
173
+ const session = { planType: 'openspec', openspecChange: 'add-customer-registry', slug: 'add-customer-registry' };
174
+
175
+ // Green while live: spine in the change dir (sync-only notApplicable).
176
+ const liveDir = path.join(cwd, 'openspec', 'changes', 'add-customer-registry');
177
+ fs.mkdirSync(liveDir, { recursive: true });
178
+ fs.writeFileSync(
179
+ path.join(liveDir, 'spine.json'),
180
+ `${JSON.stringify({ rows: [], notApplicable: 'sync HTTP only' }, null, 2)}\n`,
181
+ 'utf8',
182
+ );
183
+ assert.equal(runIntegrityChecks({ cwd, sessionDir, session }).ok, true);
184
+
185
+ // Archive the change — the mechanical gate must STILL pass (the bug: it
186
+ // used to look only at the vanished live path and fail).
187
+ const archived = path.join(cwd, 'openspec', 'changes', 'archive', '2026-07-20-add-customer-registry');
188
+ fs.mkdirSync(path.dirname(archived), { recursive: true });
189
+ fs.renameSync(liveDir, archived);
190
+ assert.equal(runIntegrityChecks({ cwd, sessionDir, session }).ok, true);
191
+ } finally {
192
+ fs.rmSync(cwd, { recursive: true, force: true });
193
+ }
194
+ });
195
+
196
+ test('deferrals: add, list, resolve lifecycle', () => {
197
+ const dir = tmp('forge-defer-');
198
+ try {
199
+ addDeferral(dir, { task: '9.2', reason: 'wiring lands in 9.7' });
200
+ assert.equal(openDeferrals(dir).length, 1);
201
+ assert.throws(() => addDeferral(dir, { task: '9.2', reason: 'dup' }), /already open/);
202
+ resolveDeferral(dir, '9.2');
203
+ assert.equal(openDeferrals(dir).length, 0);
204
+ assert.equal(loadDeferrals(dir).deferrals.length, 1);
205
+ assert.throws(() => resolveDeferral(dir, '9.2'), /No open deferral/);
206
+ } finally {
207
+ fs.rmSync(dir, { recursive: true, force: true });
208
+ }
209
+ });
210
+
211
+ test('deferrals: add requires task and reason', () => {
212
+ const dir = tmp('forge-defer-req-');
213
+ try {
214
+ assert.throws(() => addDeferral(dir, { task: '', reason: 'x' }), /--task/);
215
+ assert.throws(() => addDeferral(dir, { task: '1.1', reason: '' }), /--reason/);
216
+ } finally {
217
+ fs.rmSync(dir, { recursive: true, force: true });
218
+ }
219
+ });
220
+
221
+ test('JOBS_SIGNAL_RE + sessionJobsSignalText', () => {
222
+ assert.equal(JOBS_SIGNAL_RE.test('etl-surveydb-harmonization-platform worker'), true);
223
+ assert.equal(JOBS_SIGNAL_RE.test('fix toolbar padding'), false);
224
+ assert.equal(
225
+ sessionJobsSignalText({ paceSignal: null, slug: 'my-slug', openspecChange: 'chg' }),
226
+ 'my-slug chg',
227
+ );
228
+ });
229
+
230
+ function makeSessionDir(root) {
231
+ const dir = path.join(root, '.forge', 'sessions', 's1');
232
+ fs.mkdirSync(dir, { recursive: true });
233
+ return dir;
234
+ }
235
+
236
+ test('runIntegrityChecks: missing spine always fails (not keyword-gated)', () => {
237
+ const cwd = tmp('forge-int-clean-');
238
+ try {
239
+ const sessionDir = makeSessionDir(cwd);
240
+ const result = runIntegrityChecks({
241
+ cwd,
242
+ sessionDir,
243
+ session: { slug: 'fix-toolbar', openspecChange: null },
244
+ });
245
+ assert.equal(result.ok, false);
246
+ assert.match(result.problems.join('\n'), /spine\.json required/);
247
+ } finally {
248
+ fs.rmSync(cwd, { recursive: true, force: true });
249
+ }
250
+ });
251
+
252
+ test('runIntegrityChecks: notApplicable spine allows sync-only without product-loop', () => {
253
+ const cwd = tmp('forge-int-na-sync-');
254
+ try {
255
+ const sessionDir = makeSessionDir(cwd);
256
+ fs.writeFileSync(
257
+ path.join(sessionDir, 'spine.json'),
258
+ `${JSON.stringify(
259
+ { rows: [], notApplicable: 'sync HTTP only — no async producer/consumer' },
260
+ null,
261
+ 2,
262
+ )}\n`,
263
+ 'utf8',
264
+ );
265
+ const result = runIntegrityChecks({
266
+ cwd,
267
+ sessionDir,
268
+ session: { slug: 'fix-toolbar', openspecChange: null },
269
+ });
270
+ assert.equal(result.ok, true);
271
+ } finally {
272
+ fs.rmSync(cwd, { recursive: true, force: true });
273
+ }
274
+ });
275
+
276
+ test('runIntegrityChecks: unresolved deferral fails', () => {
277
+ const cwd = tmp('forge-int-defer-');
278
+ try {
279
+ const sessionDir = makeSessionDir(cwd);
280
+ fs.writeFileSync(
281
+ path.join(sessionDir, 'spine.json'),
282
+ `${JSON.stringify({ rows: [], notApplicable: 'sync only' }, null, 2)}\n`,
283
+ 'utf8',
284
+ );
285
+ addDeferral(sessionDir, { task: '9.2', reason: 'later' });
286
+ const result = runIntegrityChecks({
287
+ cwd,
288
+ sessionDir,
289
+ session: { slug: 'fix-toolbar', openspecChange: null },
290
+ });
291
+ assert.equal(result.ok, false);
292
+ assert.match(result.problems.join('\n'), /unresolved deferrals: 9\.2/);
293
+ } finally {
294
+ fs.rmSync(cwd, { recursive: true, force: true });
295
+ }
296
+ });
297
+
298
+ test('runIntegrityChecks: empty slug without spine still fails', () => {
299
+ const cwd = tmp('forge-int-jobs-');
300
+ try {
301
+ const sessionDir = makeSessionDir(cwd);
302
+ const result = runIntegrityChecks({
303
+ cwd,
304
+ sessionDir,
305
+ session: { slug: 'add-harmonization-platform', openspecChange: null },
306
+ });
307
+ assert.equal(result.ok, false);
308
+ assert.match(result.problems.join('\n'), /spine\.json required/);
309
+ } finally {
310
+ fs.rmSync(cwd, { recursive: true, force: true });
311
+ }
312
+ });
313
+
314
+ function greenStep(overrides = {}) {
315
+ return {
316
+ name: 'produce',
317
+ cmd: 'node -e "console.log(\'proposals: 3\')"',
318
+ ...overrides,
319
+ };
320
+ }
321
+
322
+ function writeSpineWithRows(sessionDir) {
323
+ fs.writeFileSync(
324
+ path.join(sessionDir, 'spine.json'),
325
+ `${JSON.stringify({ change: null, notApplicable: null, rows: [validRow()] }, null, 2)}\n`,
326
+ 'utf8',
327
+ );
328
+ }
329
+
330
+ function writeE2eDoc(sessionDir, doc) {
331
+ fs.writeFileSync(path.join(sessionDir, 'e2e.json'), `${JSON.stringify(doc, null, 2)}\n`, 'utf8');
332
+ }
333
+
334
+ test('validateE2e: filled steps pass; template placeholders rejected', () => {
335
+ assert.equal(validateE2e({ notApplicable: null, steps: [greenStep()] }).ok, true);
336
+ const scaffold = validateE2e(e2eTemplate({ change: 'x' }));
337
+ assert.equal(scaffold.ok, false);
338
+ assert.match(scaffold.problems.join('\n'), /scaffold placeholder/);
339
+ });
340
+
341
+ test('validateE2e: missing cmd, bad regex, bad timeout, empty steps', () => {
342
+ assert.match(
343
+ validateE2e({ steps: [{ name: 'x', cmd: '' }] }).problems.join('\n'),
344
+ /missing cmd/,
345
+ );
346
+ assert.match(
347
+ validateE2e({ steps: [greenStep({ expect: '(' })] }).problems.join('\n'),
348
+ /not a valid regex/,
349
+ );
350
+ assert.match(
351
+ validateE2e({ steps: [greenStep({ timeoutMs: -5 })] }).problems.join('\n'),
352
+ /timeoutMs/,
353
+ );
354
+ assert.match(validateE2e({ steps: [] }).problems.join('\n'), /steps is empty/);
355
+ assert.equal(validateE2e({ steps: [], notApplicable: 'no headless env — manual device loop' }).ok, true);
356
+ });
357
+
358
+ test('e2e init writes template and refuses overwrite without force', () => {
359
+ const dir = tmp('forge-e2e-init-');
360
+ try {
361
+ const file = path.join(dir, 'e2e.json');
362
+ initE2e({ file, change: 'my-change' });
363
+ assert.equal(JSON.parse(fs.readFileSync(file, 'utf8')).change, 'my-change');
364
+ assert.throws(() => initE2e({ file, change: 'my-change' }), /already exists/);
365
+ initE2e({ file, change: 'other', force: true });
366
+ assert.equal(JSON.parse(fs.readFileSync(file, 'utf8')).change, 'other');
367
+ assert.equal(
368
+ e2ePath({ cwd: dir, session: { openspecChange: null }, sessionDir: dir }),
369
+ file,
370
+ );
371
+ } finally {
372
+ fs.rmSync(dir, { recursive: true, force: true });
373
+ }
374
+ });
375
+
376
+ test('runE2eSteps: green run with expect match', () => {
377
+ const results = runE2eSteps({ steps: [greenStep({ expect: 'proposals: \\d+' })] });
378
+ assert.equal(results.ok, true);
379
+ assert.equal(results.steps[0].exitCode, 0);
380
+ assert.equal(results.steps[0].expectMatched, true);
381
+ assert.equal(results.stepsHash, e2eStepsHash([greenStep({ expect: 'proposals: \\d+' })]));
382
+ });
383
+
384
+ test('runE2eSteps: non-zero exit fails and skips later steps', () => {
385
+ const results = runE2eSteps({
386
+ steps: [
387
+ { name: 'boom', cmd: 'node -e "process.exit(3)"' },
388
+ greenStep({ name: 'never' }),
389
+ ],
390
+ });
391
+ assert.equal(results.ok, false);
392
+ assert.equal(results.steps[0].exitCode, 3);
393
+ assert.equal(results.steps[1].skipped, true);
394
+ });
395
+
396
+ test('runE2eSteps: exit 0 but expect mismatch fails', () => {
397
+ const results = runE2eSteps({ steps: [greenStep({ expect: 'ratified: \\d+' })] });
398
+ assert.equal(results.ok, false);
399
+ assert.equal(results.steps[0].expectMatched, false);
400
+ });
401
+
402
+ test('checkE2eGate: missing file, missing results, stale hash, failed run, green, notApplicable', () => {
403
+ const dir = tmp('forge-e2e-gate-');
404
+ try {
405
+ const e2eFile = path.join(dir, 'e2e.json');
406
+
407
+ let gate = checkE2eGate({ e2eFile, sessionDir: dir });
408
+ assert.match(gate.problems.join('\n'), /e2e\.json required/);
409
+
410
+ writeE2eDoc(dir, { notApplicable: null, steps: [greenStep()] });
411
+ gate = checkE2eGate({ e2eFile, sessionDir: dir });
412
+ assert.match(gate.problems.join('\n'), /e2e-results\.json missing/);
413
+
414
+ const results = runE2eSteps({ steps: [greenStep()] });
415
+ writeE2eResults(dir, results);
416
+ gate = checkE2eGate({ e2eFile, sessionDir: dir });
417
+ assert.deepEqual(gate.problems, []);
418
+
419
+ writeE2eDoc(dir, { notApplicable: null, steps: [greenStep({ name: 'edited' })] });
420
+ gate = checkE2eGate({ e2eFile, sessionDir: dir });
421
+ assert.match(gate.problems.join('\n'), /stale/);
422
+
423
+ writeE2eDoc(dir, { notApplicable: null, steps: [{ name: 'boom', cmd: 'node -e "process.exit(1)"' }] });
424
+ writeE2eResults(dir, runE2eSteps({ steps: [{ name: 'boom', cmd: 'node -e "process.exit(1)"' }] }));
425
+ gate = checkE2eGate({ e2eFile, sessionDir: dir });
426
+ assert.match(gate.problems.join('\n'), /failed at step "boom"/);
427
+
428
+ writeE2eDoc(dir, { notApplicable: 'loop needs a physical device', steps: [] });
429
+ gate = checkE2eGate({ e2eFile, sessionDir: dir });
430
+ assert.deepEqual(gate.problems, []);
431
+ assert.equal(gate.notApplicable, true);
432
+ } finally {
433
+ fs.rmSync(dir, { recursive: true, force: true });
434
+ }
435
+ });
436
+
437
+ test('runIntegrityChecks: spine rows demand an executed green e2e run', () => {
438
+ const cwd = tmp('forge-int-loop-');
439
+ try {
440
+ const sessionDir = makeSessionDir(cwd);
441
+ writeSpineWithRows(sessionDir);
442
+ const session = { slug: 'wire-worker-jobs', openspecChange: null };
443
+
444
+ let result = runIntegrityChecks({ cwd, sessionDir, session });
445
+ assert.equal(result.ok, false);
446
+ assert.match(result.problems.join('\n'), /e2e\.json required/);
447
+
448
+ writeE2eDoc(sessionDir, { notApplicable: null, steps: [greenStep()] });
449
+ result = runIntegrityChecks({ cwd, sessionDir, session });
450
+ assert.equal(result.ok, false);
451
+ assert.match(result.problems.join('\n'), /e2e-results\.json missing/);
452
+
453
+ writeE2eResults(sessionDir, runE2eSteps({ steps: [greenStep()] }));
454
+ result = runIntegrityChecks({ cwd, sessionDir, session });
455
+ assert.equal(result.ok, true);
456
+ assert.equal(result.e2eFile, path.join(sessionDir, 'e2e.json'));
457
+
458
+ // prose "## Product loop" alone no longer satisfies the gate
459
+ fs.rmSync(path.join(sessionDir, 'e2e-results.json'));
460
+ fs.writeFileSync(
461
+ path.join(sessionDir, 'verify-evidence.md'),
462
+ '# Verify\n\n## Product loop\n\ningest -> analyze -> ratify: output differs\n',
463
+ 'utf8',
464
+ );
465
+ result = runIntegrityChecks({ cwd, sessionDir, session });
466
+ assert.equal(result.ok, false);
467
+ assert.match(result.problems.join('\n'), /e2e-results\.json missing/);
468
+ } finally {
469
+ fs.rmSync(cwd, { recursive: true, force: true });
470
+ }
471
+ });
472
+
473
+ test('runIntegrityChecks: project-level e2e disable skips the executed-run demand', () => {
474
+ const cwd = tmp('forge-int-e2eoff-');
475
+ try {
476
+ const sessionDir = makeSessionDir(cwd);
477
+ writeSpineWithRows(sessionDir);
478
+ const session = { slug: 'wire-worker-jobs', openspecChange: null };
479
+
480
+ let result = runIntegrityChecks({ cwd, sessionDir, session });
481
+ assert.equal(result.ok, false);
482
+ assert.match(result.problems.join('\n'), /e2e\.json required/);
483
+
484
+ fs.writeFileSync(
485
+ path.join(cwd, '.forge', 'config.json'),
486
+ `${JSON.stringify({ e2e: { disabled: 'operator accepts manual verification' } }, null, 2)}\n`,
487
+ 'utf8',
488
+ );
489
+ result = runIntegrityChecks({ cwd, sessionDir, session });
490
+ assert.equal(result.ok, true);
491
+ assert.equal(result.e2eDisabled, 'operator accepts manual verification');
492
+
493
+ // BLOCKED evidence still blocks — the off switch only drops the run demand.
494
+ fs.writeFileSync(path.join(sessionDir, 'verify-evidence.md'), 'BLOCKED: cannot verify\n', 'utf8');
495
+ result = runIntegrityChecks({ cwd, sessionDir, session });
496
+ assert.equal(result.ok, false);
497
+ assert.match(result.problems.join('\n'), /BLOCKED/);
498
+ } finally {
499
+ fs.rmSync(cwd, { recursive: true, force: true });
500
+ }
501
+ });
502
+
503
+ test('runIntegrityChecks: BLOCKED in verify-evidence blocks even with green e2e', () => {
504
+ const cwd = tmp('forge-int-blocked-');
505
+ try {
506
+ const sessionDir = makeSessionDir(cwd);
507
+ writeSpineWithRows(sessionDir);
508
+ writeE2eDoc(sessionDir, { notApplicable: null, steps: [greenStep()] });
509
+ writeE2eResults(sessionDir, runE2eSteps({ steps: [greenStep()] }));
510
+ fs.writeFileSync(
511
+ path.join(sessionDir, 'verify-evidence.md'),
512
+ '# Verify\n\nBLOCKED: ratify UI unreachable in CI\n',
513
+ 'utf8',
514
+ );
515
+ const result = runIntegrityChecks({
516
+ cwd,
517
+ sessionDir,
518
+ session: { slug: 'wire-worker-jobs', openspecChange: null },
519
+ });
520
+ assert.equal(result.ok, false);
521
+ assert.match(result.problems.join('\n'), /BLOCKED/);
522
+ } finally {
523
+ fs.rmSync(cwd, { recursive: true, force: true });
524
+ }
525
+ });
526
+
527
+ test('runIntegrityChecks: invalid spine fails even without jobs signal', () => {
528
+ const cwd = tmp('forge-int-badspine-');
529
+ try {
530
+ const sessionDir = makeSessionDir(cwd);
531
+ fs.writeFileSync(
532
+ path.join(sessionDir, 'spine.json'),
533
+ `${JSON.stringify({ rows: [validRow({ runtimeOwner: '' })] }, null, 2)}\n`,
534
+ 'utf8',
535
+ );
536
+ const result = runIntegrityChecks({
537
+ cwd,
538
+ sessionDir,
539
+ session: { slug: 'fix-toolbar', openspecChange: null },
540
+ });
541
+ assert.equal(result.ok, false);
542
+ assert.match(result.problems.join('\n'), /spine: .*runtimeOwner/);
543
+ } finally {
544
+ fs.rmSync(cwd, { recursive: true, force: true });
545
+ }
546
+ });
547
+
548
+ test('runIntegrityChecks: notApplicable spine passes without evidence demands', () => {
549
+ const cwd = tmp('forge-int-na-');
550
+ try {
551
+ const sessionDir = makeSessionDir(cwd);
552
+ fs.writeFileSync(
553
+ path.join(sessionDir, 'spine.json'),
554
+ `${JSON.stringify({ rows: [], notApplicable: 'docs-only change' }, null, 2)}\n`,
555
+ 'utf8',
556
+ );
557
+ const result = runIntegrityChecks({
558
+ cwd,
559
+ sessionDir,
560
+ session: { slug: 'wire-worker-jobs', openspecChange: null },
561
+ });
562
+ assert.equal(result.ok, true);
563
+ } finally {
564
+ fs.rmSync(cwd, { recursive: true, force: true });
565
+ }
566
+ });