@izara_project/izara-core-generate-service-code 1.0.93 → 1.0.95

package/test/core.test.js

@@ -34,6 +34,19 @@ test('compiles a request and commits only declared relative artifacts', async ()
 test('rejects invalid generation inputs before writing files', async () => {
   assert.throws(() => compileProject({}), /rootPath/);
 
+  const corruptPath = await mkdtemp(
+    join(tmpdir(), 'generate-service-code-v2-corrupt-yml-')
+  );
+  await mkdir(join(corruptPath, 'config'), { recursive: true });
+  await writeFile(
+    join(corruptPath, 'config/serverless.config.yml'),
+    'main_config: [unbalanced brackets:'
+  );
+  assert.throws(
+    () => compileProject({ rootPath: corruptPath }),
+    /Failed to read or parse configuration at/
+  );
+
   const outputPath = await mkdtemp(
     join(tmpdir(), 'generate-service-code-v2-invalid-')
   );

package/test/customFlowApplicationArtifacts.test.js

@@ -88,6 +88,15 @@ test('emits handlers, function YAML, and IAM roles for supported custom flow eve
   assert.match(iam, /ApiRole:/);
   assert.match(iam, /OwnRole:/);
   assert.match(iam, /UploadRole:/);
+  const customSqsYaml = await readFile(
+    join(
+      rootPath,
+      'resource/sls_yaml/generatedCode/source/generated-sns-sqs-custom-flows.yml'
+    ),
+    'utf8'
+  );
+  assert.match(customSqsYaml, /ExtHdrSqs:/);
+  assert.doesNotMatch(customSqsYaml, /ProcessExtHdrSqs/);
   assert.match(
     await readFile(
       join(
@@ -254,7 +263,7 @@ test('removes only V2-owned custom-flow application artifacts when supported eve
   await generateCustomFlowApplicationArtifacts(rootPath);
   await writeFile(
     join(rootPath, 'app/src/schemas/FlowSchemas/Flows.js'),
-    "export default [{ flowTag: 'later', event: ['unsupported'] }];\n"
+    "export default [];\n"
   );
 
   assert.deepEqual(
@@ -469,6 +478,53 @@ test('emits and removes the trigger-cache artifact suite when triggerFlowTypes i
   );
 });
 
+test('triggerCache entrypoint Cart_Main.js contains correct library import and logic', async () => {
+  const rootPath = await createTriggerCacheProject(['OrderCheckout']);
+  await generateCustomFlowApplicationArtifacts(rootPath);
+
+  const source = 'app/src/generatedCode/FlowSchemas/Cart/source';
+  const mainContent = await readFile(
+    join(rootPath, `${source}/Cart_Main.js`),
+    'utf8'
+  );
+
+  assert.match(
+    mainContent,
+    /import \{ triggeredCacheSharedLibV2 \} from '@izara_project\/izara-core-library-trigger-cache'/,
+    'should import triggeredCacheSharedLibV2'
+  );
+  assert.match(
+    mainContent,
+    /triggeredCacheSharedLibV2\.checkTriggerResetedV2/,
+    'should call checkTriggerResetedV2'
+  );
+  assert.match(
+    mainContent,
+    /triggeredCacheSharedLibV2\.checkTriggeredCacheV2/,
+    'should call checkTriggeredCacheV2'
+  );
+  assert.match(
+    mainContent,
+    /\/\/\(<beforeCheckTriggeredCache>\)/,
+    'should have beforeCheckTriggeredCache hook'
+  );
+  assert.match(
+    mainContent,
+    /\/\/\(<dispatchTriggerFlowHook>\)/,
+    'should have dispatchTriggerFlowHook hook'
+  );
+  assert.match(
+    mainContent,
+    /if \(triggeredCacheResult\?\.hasPendingTasks\)/,
+    'should guard dispatch with hasPendingTasks check'
+  );
+  assert.doesNotMatch(
+    mainContent,
+    /checkStoredCacheStatus/,
+    'should not contain storedCache logic'
+  );
+});
+
 test('uses custom CheckTrigger step if provided by developer in flowSteps', async () => {
   const rootPath = await mkdtemp(
     join(tmpdir(), 'generate-service-code-v2-trigger-cache-custom-')
@@ -494,28 +550,77 @@ test('uses custom CheckTrigger step if provided by developer in flowSteps', asyn
   assert.match(flowYaml, /^CartCheckTriggerCustomStepHdrSqs:/m);
 });
 
-test('does not emit check trigger-cache artifacts when triggerFlowTypes is empty, null, undefined, or missing', async () => {
+test('uses full {flowTag}{stepName} queue name when stepName starts with flowTag', async () => {
+  const rootPath = await createTriggerCacheProject(['OrderCheckout']);
+  await writeFile(
+    join(rootPath, 'app/src/schemas/FlowSchemas/Cart.js'),
+    "export default { flowTag: 'cart', event: ['ownTopic'], statusType: 'triggerCache', triggerFlowTypes: ['OrderCheckout'], objType: { serviceTag: 'Order' }, flowSteps: [{ stepName: 'start' }, { stepName: 'CartCheckX', event: ['extTopic'] }] };\n"
+  );
+  await generateCustomFlowApplicationArtifacts(rootPath);
+  await generateResourceArtifacts(rootPath);
+
+  const source = 'app/src/generatedCode/FlowSchemas/Cart/source';
+  for (const fileName of [
+    'CartCartCheckX_Main.js',
+    'CartCartCheckX_HdrSqs.js'
+  ]) {
+    const path = join(rootPath, source, fileName);
+    await access(path);
+    await parseAsEsm(path);
+  }
+
+  const flowYaml = await readFile(
+    join(rootPath, 'app/sls_yaml/generatedCode/source/flow-schema.yml'),
+    'utf8'
+  );
+  assert.match(flowYaml, /^CartCartCheckXHdrSqs:/m);
+  assert.match(
+    await readFile(join(rootPath, `${source}/CartCartCheckX_HdrSqs.js`), 'utf8'),
+    /CartCartCheckXHdrSqs/
+  );
+
+  const resources = await readFile(
+    join(
+      rootPath,
+      'resource/sls_yaml/generatedCode/source/generated-sns-sqs-custom-flows.yml'
+    ),
+    'utf8'
+  );
+  assert.match(
+    resources,
+    new RegExp(
+      'QueueName: \\$\\{self:custom\\.iz_resourcePrefix\\}CartCartCheckXHdrSqs'
+    )
+  );
+});
+
+test('rejects when statusType triggerCache has triggerFlowTypes empty, null, undefined, or missing', async () => {
   for (const emptyTriggerFlowTypes of [[], null, undefined]) {
     const rootPath = await createTriggerCacheProject(emptyTriggerFlowTypes);
-    await generateCustomFlowApplicationArtifacts(rootPath);
-    await generateResourceArtifacts(rootPath);
-
-    const source = 'app/src/generatedCode/FlowSchemas/Cart/source';
-    await assert.rejects(
-      readFile(join(rootPath, `${source}/CartCheckTriggerFlows_Main.js`))
-    );
     await assert.rejects(
-      readFile(join(rootPath, `${source}/CartCheckTriggerFlows_HdrSqs.js`))
+      generateCustomFlowApplicationArtifacts(rootPath),
+      /FlowSchema validation error.*triggerCache.*requires a non-empty 'triggerFlowTypes' array/
     );
-
-    const flowYaml = await readFile(
-      join(rootPath, 'app/sls_yaml/generatedCode/source/flow-schema.yml'),
-      'utf8'
-    );
-    assert.doesNotMatch(flowYaml, /CartCheckTriggerFlowsHdrSqs/);
   }
 });
 
+test('rejects when statusType storedCache cannot resolve DynamoDB table from objType', async () => {
+  const rootPath = await mkdtemp(
+    join(tmpdir(), 'generate-service-code-v2-stored-cache-err-')
+  );
+  roots.add(rootPath);
+  const schemaRoot = join(rootPath, 'app/src/schemas/FlowSchemas');
+  await mkdir(schemaRoot, { recursive: true });
+  await writeFile(
+    join(schemaRoot, 'CacheFlow.js'),
+    "export default { flowTag: 'cacheFlow', event: ['ownTopic'], statusType: 'storedCache', objType: { objectType: 'missingObj' }, flowSteps: [{ stepName: 'Start' }] };\n"
+  );
+  await assert.rejects(
+    generateCustomFlowApplicationArtifacts(rootPath),
+    /FlowSchema validation error.*storedCache.*cannot resolve DynamoDB tableName/
+  );
+});
+
 test('rejects an EventBridge schedule without a deployable name and rate', () => {
   assert.throws(
     () =>
@@ -565,7 +670,7 @@ export default [
   { ...base, flowTag: 'cache', event: ['ownTopic'], statusType: 'storedCache', objType: { objectType: 'order', serviceTag: 'Current' } },
   { ...base, flowTag: 'mixed', event: ['ownTopic', 'extTopic'] },
   { ...base, flowTag: 'generated', event: ['ownTopic'], generatedCodeConfig: { generatedCodeTag: 'create' } },
-  { ...base, flowTag: 'upload', event: ['s3'] }
+  { ...base, flowTag: 'upload', event: ['s3'], bucketName: 'UploadBucket' }
 ];
 `
   );
@@ -1271,3 +1376,166 @@ test('emits handler and YAML for flow with event generateCode and invocationType
   assert.match(yaml, /GenSyncHdrInv:/);
 });
 
+test('rejects FlowSchema with event storedCache at loader', async () => {
+  const rootPath = await createProject();
+  await writeFile(
+    join(rootPath, 'app/src/schemas/FlowSchemas/BadEvent.js'),
+    `export default {
+  flowTag: 'badEvent',
+  event: ['storedCache'],
+  statusType: 'storedCache',
+  objType: { objectType: 'order' },
+  flowSteps: [{ stepName: 'Start' }]
+};\n`
+  );
+
+  await assert.rejects(
+    () => generateCustomFlowApplicationArtifacts(rootPath),
+    /Flow 'badEvent' event\[0\] 'storedCache' is invalid\. Must be one of/
+  );
+});
+
+test('emits early return cacheMain on cache hit in FlowEndpoint_Main for storedCache', async () => {
+  const rootPath = await createProject();
+  await writeFile(
+    join(rootPath, 'app/src/schemas/FlowSchemas/CacheFlow.js'),
+    `export default {
+  flowTag: 'cacheOrder',
+  event: ['ownTopic'],
+  statusType: 'storedCache',
+  objType: { objectType: 'order', serviceTag: 'Current' },
+  flowSteps: [{ stepName: 'Start' }]
+};\n`
+  );
+
+  await generateCustomFlowApplicationArtifacts(rootPath);
+
+  const mainPath = join(
+    rootPath,
+    'app/src/generatedCode/FlowSchemas/CacheOrder/source/CacheOrder_Main.js'
+  );
+  const mainContent = await readFile(mainPath, 'utf8');
+  assert.match(mainContent, /checkStoredCacheStatus/);
+  assert.match(mainContent, /if \(cacheMainStatus === 'complete'\) \{/);
+  assert.match(mainContent, /return cacheMain;/);
+  await parseAsEsm(mainPath);
+});
+
+test('does not emit RbacCallback artifacts or duplicate artifact paths for custom flow with RBAC', async () => {
+  const { generate } = await import('../src/generate.js');
+  const rootPath = await createProject();
+  await writeFile(
+    join(rootPath, 'app/src/schemas/ObjectSchemas/ComAcc.js'),
+    `export default {
+  objectType: 'comAcc',
+  belongTo: {
+    objectType: 'user',
+    serviceTag: 'UserAccount'
+  }
+};\n`
+  );
+  await writeFile(
+    join(
+      rootPath,
+      'app/src/schemas/FlowSchemas/CreateBusinessToComAcc.js'
+    ),
+    `export default {
+  flowTag: 'createBusinessToComAcc',
+  event: ['lambdaSyncInv', 'ownTopic'],
+  objType: {
+    objectType: 'comAcc',
+    serviceTag: 'ComAcc'
+  },
+  flowSteps: [{ stepName: 'Start' }]
+};\n`
+  );
+
+  const result = await generate(rootPath, {
+    serviceTag: 'BusinessService'
+  });
+  assert.ok(result);
+
+  const sourceDir = join(
+    rootPath,
+    'app/src/generatedCode/FlowSchemas/CreateBusinessToComAcc/source'
+  );
+  const mainPath = join(sourceDir, 'CreateBusinessToComAcc_Main.js');
+  const mainContent = await readFile(mainPath, 'utf8');
+  assert.match(mainContent, /checkRbacPermission/);
+  assert.doesNotMatch(mainContent, /CreateBusinessToComAccRbacCallback/);
+
+  await assert.rejects(
+    () =>
+      readFile(
+        join(sourceDir, 'CreateBusinessToComAccRbacCallback_Main.js'),
+        'utf8'
+      ),
+    { code: 'ENOENT' }
+  );
+  await assert.rejects(
+    () =>
+      readFile(
+        join(sourceDir, 'CreateBusinessToComAccRbacCallback_HdrSqs.js'),
+        'utf8'
+      ),
+    { code: 'ENOENT' }
+  );
+
+  const initialSetupConfigContent = await readFile(
+    join(
+      rootPath,
+      'app/src/generatedCode/CoreFunctions/InitialSetupConfig.js'
+    ),
+    'utf8'
+  );
+  assert.doesNotMatch(
+    initialSetupConfigContent,
+    /CreateBusinessToComAccRbacCallbackHdrSqs/
+  );
+});
+
+test('skips checkRbacPermission in FlowEndpoint_Main when initiateBy is systemNoUser', async () => {
+  const { generate } = await import('../src/generate.js');
+  const rootPath = await createProject();
+  await writeFile(
+    join(rootPath, 'app/src/schemas/ObjectSchemas/ComAcc.js'),
+    `export default {
+  objectType: 'comAcc',
+  belongTo: {
+    objectType: 'user',
+    serviceTag: 'UserAccount'
+  }
+};\n`
+  );
+  await writeFile(
+    join(
+      rootPath,
+      'app/src/schemas/FlowSchemas/SystemCronFlow.js'
+    ),
+    `export default {
+  flowTag: 'systemCronFlow',
+  event: ['ownTopic'],
+  initiateBy: 'systemNoUser',
+  objType: {
+    objectType: 'comAcc',
+    serviceTag: 'ComAcc'
+  },
+  flowSteps: [{ stepName: 'Start' }]
+};\n`
+  );
+
+  const result = await generate(rootPath, {
+    serviceTag: 'BusinessService'
+  });
+  assert.ok(result);
+
+  const mainPath = join(
+    rootPath,
+    'app/src/generatedCode/FlowSchemas/SystemCronFlow/source/SystemCronFlow_Main.js'
+  );
+  const mainContent = await readFile(mainPath, 'utf8');
+  assert.doesNotMatch(mainContent, /checkRbacPermission/);
+  await parseAsEsm(mainPath);
+});
+
+