@ixo/oracle-runtime-workers 0.29.0 → 0.30.0

package/src/plugins/ixo-chain/rest.ts

@@ -2,11 +2,12 @@
  * Chain REST (the node's LCD gateway) reads: one GET, bounded and parsed,
  * under the shared retry policy.
  */
-import type { z } from 'zod';
+import { z } from 'zod';
 import {
   exchange,
   unavailable,
   withRetry,
+  type Attempt,
   type ChainCall,
   type Outcome,
 } from './http';
@@ -15,65 +16,139 @@ export const REST_MAX_BYTES = 512 * 1024;
 /** Per-attempt wall bound for one REST read. */
 export const REST_ATTEMPT_TIMEOUT_MS = 8_000;
 
+/** How one REST read is bounded, and which answers mean "none". */
+export interface RestOptions {
+  /** Names the read in log lines (never the path: it carries an address). */
+  label: string;
+  timeoutMs?: number;
+  maxBytes?: number;
+  /** A 404 is a quiet `not_found` failure instead of `unavailable`. */
+  notFoundOn404?: boolean;
+  /**
+   * HTTP statuses that mean "there is none" for this resource (e.g.
+   * `[400, 404]` for a vote never cast): such an answer is `Absent`, an
+   * `ok` result, neither retried nor logged. Meant for 4xx statuses; it
+   * takes precedence over `notFoundOn404`. A 400 counts only when its body
+   * is a gRPC-gateway error with code 3 (InvalidArgument) or 5 (NotFound);
+   * any other 400 is a failure.
+   */
+  noneOn?: readonly number[];
+}
+
+/** gRPC InvalidArgument and NotFound: the codes of a gateway 400 that says "there is none". */
+const NONE_GRPC_CODES: readonly number[] = [3, 5];
+const grpcError = z.object({ code: z.number() });
+
+/** Whether `answer` is one of the `noneOn` statuses, a 400 only with a "none" gRPC code. */
+function isNone(
+  answer: Extract<Attempt<string>, { ok: false }>,
+  noneOn: readonly number[] | undefined,
+): boolean {
+  if (answer.status === undefined || !noneOn?.includes(answer.status))
+    return false;
+  if (answer.status !== 400) return true;
+  if (answer.errorBody === undefined) return false;
+  let body: unknown;
+  try {
+    body = JSON.parse(answer.errorBody);
+  } catch {
+    return false;
+  }
+  const parsed = grpcError.safeParse(body);
+  return parsed.success && NONE_GRPC_CODES.includes(parsed.data.code);
+}
+
+/** The answer of a read whose upstream answered one of its `noneOn` statuses. */
+export type Absent = { ok: true; absent: true };
+
+/** What one attempt found: the parsed body, or a "none" status. */
+type Found<T> = { absent: false; value: T } | { absent: true };
+
 /**
- * `GET ${restUrl}${path}` parsed by `schema`. `label` names the read in the
- * log line (never the path: it carries an address). A body that is not
- * JSON or not the expected shape is `unavailable` and is not retried. A 404
- * is `unavailable` unless `notFoundOn404` (a resource that may be absent).
+ * `GET ${restUrl}${path}` parsed by `schema`. A body that is not JSON or
+ * not the expected shape is `unavailable` and is not retried. A 404 is
+ * `unavailable` unless `notFoundOn404` (a resource that may be absent); a
+ * status in `noneOn` is {@link Absent} (a 400 only with a gRPC code 3 or
+ * 5, read from at most 8 KiB of its body).
  */
 export function restJson<S extends z.ZodType>(
   call: ChainCall,
   path: string,
   schema: S,
-  opts: {
-    label: string;
-    timeoutMs?: number;
-    maxBytes?: number;
-    notFoundOn404?: boolean;
-  },
-): Promise<Outcome<z.infer<S>>> {
+  opts: RestOptions & { noneOn?: undefined },
+): Promise<Outcome<z.infer<S>>>;
+export function restJson<S extends z.ZodType>(
+  call: ChainCall,
+  path: string,
+  schema: S,
+  opts: RestOptions & { noneOn: readonly number[] },
+): Promise<Outcome<z.infer<S>> | Absent>;
+export function restJson<S extends z.ZodType>(
+  call: ChainCall,
+  path: string,
+  schema: S,
+  opts: RestOptions,
+): Promise<Outcome<z.infer<S>> | Absent>;
+export async function restJson<S extends z.ZodType>(
+  call: ChainCall,
+  path: string,
+  schema: S,
+  opts: RestOptions,
+): Promise<Outcome<z.infer<S>> | Absent> {
   const base = call.restUrl.replace(/\/+$/, '');
   const url = `${base}${path}`;
-  return withRetry(call, { label: opts.label, upstream: base }, async () => {
-    const answer = await exchange(
-      call,
-      'chain',
-      url,
-      { method: 'GET', headers: { accept: 'application/json' } },
-      {
-        timeoutMs: opts.timeoutMs ?? REST_ATTEMPT_TIMEOUT_MS,
-        maxBytes: opts.maxBytes ?? REST_MAX_BYTES,
-        notFoundOn404: opts.notFoundOn404 ?? false,
-      },
-    );
-    if (!answer.ok) return answer;
-    let body: unknown;
-    try {
-      body = JSON.parse(answer.value);
-    } catch {
-      return {
-        ok: false,
-        failure: unavailable(
-          'chain',
-          'it answered something that is not JSON',
-          false,
-        ),
-        retry: false,
-        note: 'malformed JSON',
-      };
-    }
-    const parsed = schema.safeParse(body);
-    if (!parsed.success)
-      return {
-        ok: false,
-        failure: unavailable(
-          'chain',
-          'it answered in an unexpected shape',
-          false,
-        ),
-        retry: false,
-        note: 'unexpected shape',
-      };
-    return { ok: true, value: parsed.data };
-  });
+  const read = await withRetry<Found<z.infer<S>>>(
+    call,
+    { label: opts.label, upstream: base },
+    async () => {
+      const answer = await exchange(
+        call,
+        'chain',
+        url,
+        { method: 'GET', headers: { accept: 'application/json' } },
+        {
+          timeoutMs: opts.timeoutMs ?? REST_ATTEMPT_TIMEOUT_MS,
+          maxBytes: opts.maxBytes ?? REST_MAX_BYTES,
+          notFoundOn404: opts.notFoundOn404 ?? false,
+          ...(opts.noneOn?.includes(400) ? { errorBodyOn: [400] } : {}),
+        },
+      );
+      if (!answer.ok)
+        return isNone(answer, opts.noneOn)
+          ? { ok: true, value: { absent: true } }
+          : answer;
+      let body: unknown;
+      try {
+        body = JSON.parse(answer.value);
+      } catch {
+        return {
+          ok: false,
+          failure: unavailable(
+            'chain',
+            'it answered something that is not JSON',
+            false,
+          ),
+          retry: false,
+          note: 'malformed JSON',
+        };
+      }
+      const parsed = schema.safeParse(body);
+      if (!parsed.success)
+        return {
+          ok: false,
+          failure: unavailable(
+            'chain',
+            'it answered in an unexpected shape',
+            false,
+          ),
+          retry: false,
+          note: 'unexpected shape',
+        };
+      return { ok: true, value: { absent: false, value: parsed.data } };
+    },
+  );
+  if (!read.ok) return read;
+  return read.value.absent
+    ? { ok: true, absent: true }
+    : { ok: true, value: read.value.value };
 }

package/src/plugins/ixo-chain/summaries.ts

@@ -60,7 +60,8 @@ export const ENTITY_STATUS_NOTE =
 /** `entities` reads `ID_DESC`, and an entity id is a hash: the order says nothing about age. */
 export const ENTITIES_ORDER = 'id (text)';
 
-function clip(text: string, max: number): string {
+/** `text` cut to `max` characters, the last one an ellipsis when cut. */
+export function clip(text: string, max: number): string {
   return text.length > max ? `${text.slice(0, max - 1)}…` : text;
 }
 
@@ -69,7 +70,7 @@ export function isRecord(value: unknown): value is Record<string, unknown> {
 }
 
 /** A non-empty string field, clipped; undefined otherwise. */
-function text(value: unknown, max = TEXT_CHARS): string | undefined {
+export function text(value: unknown, max = TEXT_CHARS): string | undefined {
   return typeof value === 'string' && value ? clip(value, max) : undefined;
 }