@ixiam/n8n-nodes-civicrm 0.4.4 → 1.0.0

package/nodes/CiviCrm/CiviCrm.node.ts

@@ -1,4 +1,3 @@
-
 import type {
 	IExecuteFunctions,
 	ILoadOptionsFunctions,
@@ -13,42 +12,31 @@ import { civicrmApiRequest } from '../transport/GenericFunctions';
 import { resourceProp, operationProp } from './descriptions/resources';
 import { genericFields, upsertFields } from './descriptions/generic';
 
-/**
- * Recursos soportados
- */
+/* ============================================================================
+   RESOURCES
+============================================================================ */
+
 type Resource =
 	| 'contact'
-	| 'event'
-	| 'case'
-	| 'contribution'
 	| 'membership'
-	| 'participant'
 	| 'group'
 	| 'relationship'
-	| 'email'
 	| 'activity';
 
+type Operation = 'get' | 'getMany' | 'create' | 'update' | 'delete';
+
 const ENTITY_MAP: Record<Resource, string> = {
 	contact: 'Contact',
-	event: 'Event',
-	case: 'Case',
-	contribution: 'Contribution',
 	membership: 'Membership',
-	participant: 'Participant',
 	group: 'Group',
 	relationship: 'Relationship',
-	email: 'Email',
 	activity: 'Activity',
 };
 
-type Operation = 'get' | 'getMany' | 'create' | 'update' | 'delete';
+/* ============================================================================
+   LOCATION TYPE CACHE
+============================================================================ */
 
-/**
- * Caché global de location types
- * Se rellena la primera vez que se usa y dura hasta que se reinicia n8n.
- * key: normalizado (lowercase, sin espacios/ símbolos)
- * value: option_value.name (para usar en location_type_id:name)
- */
 let locationTypeCache: Record<string, string> | null = null;
 
 function normalizeLocationKey(s: string): string {
@@ -66,27 +54,26 @@ async function getLocationTypeMap(this: IExecuteFunctions): Promise<Record<strin
 		limit: 0,
 	});
 
-	const values = (res?.values || []) as Array<{ name?: string; label?: string }>;
 	const map: Record<string, string> = {};
+	const values = (res?.values || []) as Array<{ name?: string; label?: string }>;
 
 	for (const v of values) {
 		const name = v.name || '';
 		const label = v.label || '';
-
-		const normName = normalizeLocationKey(name);
-		const normLabel = normalizeLocationKey(label);
-
-		if (normName) map[normName] = name;
-		if (normLabel) map[normLabel] = name;
+		const k1 = normalizeLocationKey(name);
+		const k2 = normalizeLocationKey(label);
+		if (k1) map[k1] = name;
+		if (k2) map[k2] = name;
 	}
 
 	locationTypeCache = map;
 	return map;
 }
 
-/**
- * Nodo principal CiviCRM para n8n
- */
+/* ============================================================================
+   NODE DEFINITION
+============================================================================ */
+
 export class CiviCrm implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'CiviCRM',
@@ -95,43 +82,25 @@ export class CiviCrm implements INodeType {
 		group: ['transform'],
 		version: 1,
 		description:
-			'Interact with CiviCRM API v4 (Civi-Go compatible).\\n\\n' +
-			'Email / Phone / Address mapping:\\n' +
-			'- You can send simple fields: email, phone, address.city, address.country_id, etc.\\n' +
-			'- You can also use dynamic prefixes based on real CiviCRM Location Types.\\n' +
-			'  Example prefixes (from Location Types): Home, Work, Billing, Mobile, Oficina, etc.\\n' +
-			'- Prefix format: <location-prefix>.<entity>[.<subfield>]\\n' +
-			'  Examples:\\n' +
-			'    email = test@ixiam.com\\n' +
-			'    phone = 600123123\\n' +
-			'    address.city = Barcelona\\n' +
-			'    work.email = test@company.com  (Location Type = Work)\\n' +
-			'    billing.address.postal_code = 28010  (Location Type = Billing)\\n' +
-			'    home.phone.phone_type_id = 2  (Location Type = Home)\\n\\n' +
-			'Subfields examples:\\n' +
-			'- email.is_primary, email.signature_html, email.signature_text\\n' +
-			'- phone.phone_type_id, phone.phone_ext\\n' +
-			'- address.country_id, address.state_province_id, address.postal_code, address.street_address\\n\\n' +
-			'Prefixes and Location Types:\\n' +
-			'- The prefix (e.g. work, home, billing, oficina) is matched against CiviCRM Location Types (name/label).\\n' +
-			'- If the prefix matches, the node sets location_type_id:name automatically.\\n' +
-			'- If no prefix is used (e.g. email, phone, address.city), the node uses the Location Type selectors.\\n\\n' +
-			'birth_date:\\n' +
-			'- Accepted formats: YYYY-MM-DD, DD/MM/YYYY, DD-MM-YYYY, YYYY/MM/DD, YYYY.MM.DD.\\n' +
-			'- The node normalizes and validates the date before sending it to CiviCRM.\\n\\n' +
-			'Filters in GET MANY:\\n' +
-			'- Use API4 "where" JSON array format, e.g.:\\n' +
-			'  [ ["contact_type","=","Individual"] ]\\n' +
-			'  [ ["first_name","LIKE","Jul%"] ]\\n' +
-			'  [ ["birth_date",">","1990-01-01"] ]\\n' +
-			'  [ ["gender_id","IN",[1,2]] ]',
+			'Interact with CiviCRM API v4 (Civi-Go compatible).\n\n' +
+			'Supports Contact, Membership, Group, Relationship and Activity entities.\n' +
+			'Includes dynamic mapping of email, phone, address and location types.\n' +
+			'Includes birth_date validation and JSON filters for GET MANY.\n',
 		defaults: { name: 'CiviCRM' },
 		inputs: ['main'],
 		outputs: ['main'],
 		credentials: [{ name: 'civiCrmApi', required: true }],
+
 		properties: [
+			//
+			// RESOURCE + OPERATION
+			//
 			resourceProp,
 			operationProp,
+
+			//
+			// CONTACT TYPE
+			//
 			{
 				displayName: 'Contact Type',
 				name: 'contactType',
@@ -143,10 +112,11 @@ export class CiviCrm implements INodeType {
 					{ name: 'Household', value: 'Household' },
 				],
 				displayOptions: { show: { resource: ['contact'] } },
-				description:
-					'Contact type to filter (GET MANY) or assign (CREATE/UPDATE). ' +
-					'For GET MANY, if set, a condition [ "contact_type", "=", selectedType ] is added to the where.',
 			},
+
+			//
+			// LOCATION TYPES
+			//
 			{
 				displayName: 'Email Location Type',
 				name: 'emailLocation',
@@ -158,11 +128,6 @@ export class CiviCrm implements INodeType {
 					{ name: 'Other', value: 'Other' },
 				],
 				displayOptions: { show: { resource: ['contact'], operation: ['create', 'update'] } },
-				description:
-					'Default Location Type used for email when no prefix is provided.\\n' +
-					'- If you use "email" or "email.xxx" as field name, this Location Type will be used.\\n' +
-					'- If you use a prefixed field like "work.email", "home.email", etc., ' +
-					'the prefix overrides this selector and maps to the matching CiviCRM Location Type.',
 			},
 			{
 				displayName: 'Phone Location Type',
@@ -176,11 +141,6 @@ export class CiviCrm implements INodeType {
 					{ name: 'Other', value: 'Other' },
 				],
 				displayOptions: { show: { resource: ['contact'], operation: ['create', 'update'] } },
-				description:
-					'Default Location Type used for phone when no prefix is provided.\\n' +
-					'- If you use "phone" or "phone.xxx" as field name, this Location Type will be used.\\n' +
-					'- If you use a prefixed field like "mobile.phone", "work.phone", etc., ' +
-					'the prefix overrides this selector and maps to the matching CiviCRM Location Type.',
 			},
 			{
 				displayName: 'Address Location Type',
@@ -194,22 +154,22 @@ export class CiviCrm implements INodeType {
 					{ name: 'Other', value: 'Other' },
 				],
 				displayOptions: { show: { resource: ['contact'], operation: ['create', 'update'] } },
-				description:
-					'Default Location Type used for address when no prefix is provided.\\n' +
-					'- If you use "address.city", "address.country_id", etc., this Location Type will be used.\\n' +
-					'- If you use a prefixed field like "billing.address.postal_code", "home.address.city", etc., ' +
-					'the prefix overrides this selector and maps to the matching CiviCRM Location Type.',
 			},
+
+			//
+			// PRIMARY FLAG
+			//
 			{
 				displayName: 'Mark as Primary',
 				name: 'isPrimary',
 				type: 'boolean',
 				default: true,
 				displayOptions: { show: { resource: ['contact'], operation: ['create', 'update'] } },
-				description:
-					'If enabled, previous primary email/phone/address for this contact are deleted before creating the new ones. ' +
-					'Useful when you want to replace existing primary contact details.',
 			},
+
+			//
+			// ID for GET / UPDATE / DELETE
+			//
 			{
 				displayName: 'ID',
 				name: 'id',
@@ -217,35 +177,42 @@ export class CiviCrm implements INodeType {
 				default: 0,
 				required: true,
 				displayOptions: { show: { operation: ['get', 'update', 'delete'] } },
-				description: 'Record ID of the selected entity (Contact, Event, Case, etc.).',
 			},
+
+			//
+			// DYNAMIC FIELDS
+			//
 			...genericFields,
 			...upsertFields,
 		],
 	};
 
+	/* ============================================================================
+	   LOAD OPTIONS (required by n8n verification)
+	============================================================================ */
+
 	methods = {
 		loadOptions: {
-			async getOptionValues(this: ILoadOptionsFunctions) {
+			async loadOptionValues(this: ILoadOptionsFunctions) {
 				const { baseUrl, apiToken } = (await this.getCredentials('civiCrmApi')) as {
 					baseUrl: string;
 					apiToken: string;
 				};
 
-				const url = `${baseUrl.replace(/\/$/, '')}/civicrm/ajax/api4/OptionValue/get`;
 				const res = await this.helpers.httpRequest({
 					method: 'POST',
-					url,
+					url: `${baseUrl.replace(/\/$/, '')}/civicrm/ajax/api4/OptionValue/get`,
 					headers: {
 						'X-Civi-Auth': `Bearer ${apiToken}`,
 						'Content-Type': 'application/x-www-form-urlencoded',
 					},
-					body: { params: JSON.stringify({ limit: 5 }) },
+					body: { params: JSON.stringify({ limit: 50, select: ['id', 'label'] }) },
 					json: true,
 				});
 
 				const values = (res?.values || []) as Array<{ id: number; label: string }>;
-				return values.map((v): INodePropertyOptions => ({
+
+				return values.map((v) => ({
 					name: v.label,
 					value: v.id,
 				}));
@@ -253,6 +220,10 @@ export class CiviCrm implements INodeType {
 		},
 	};
 
+	/* ============================================================================
+	   EXECUTE
+	============================================================================ */
+
 	async execute(this: IExecuteFunctions) {
 		const items = this.getInputData();
 		const out: INodeExecutionData[] = [];
@@ -267,451 +238,416 @@ export class CiviCrm implements INodeType {
 			const addressLocationParam = this.getNodeParameter('addressLocation', i, 'Home') as string;
 			const isPrimary = this.getNodeParameter('isPrimary', i, true) as boolean;
 
-			// Valores de location type efectivos (pueden ser sobreescritos por prefijo)
 			let emailLocationName = emailLocationParam;
 			let phoneLocationName = phoneLocationParam;
 			let addressLocationName = addressLocationParam;
 
-			// =========== GET ===========
+			/* ======================================================
+			   GET
+			====================================================== */
 			if (operation === 'get') {
 				const id = this.getNodeParameter('id', i) as number;
-				const where = [['id', '=', id]];
 
-				if (resource === 'contact') {
-					const params = {
-						where,
-						limit: 1,
-						select: [
-							'id',
-							'display_name',
-							'first_name',
-							'last_name',
-							'contact_type',
-							'gender_id',
-							'gender_id:name',
-							'birth_date',
-						],
-						chain: {
-							emails: ['Email', 'get', { where: [['contact_id', '=', '$id']] }],
-							phones: ['Phone', 'get', { where: [['contact_id', '=', '$id']] }],
-							addresses: ['Address', 'get', { where: [['contact_id', '=', '$id']] }],
-						},
-					};
-					const res = await civicrmApiRequest.call(
-						this,
-						'POST',
-						'/civicrm/ajax/api4/Contact/get',
-						params,
-					);
-					out.push({ json: (res?.values?.[0] ?? {}) as IDataObject });
-				} else {
-					const params = {
-						where,
-						limit: 1,
-						select: ['id', 'name', 'title', 'subject', 'display_name'],
-					};
-					const res = await civicrmApiRequest.call(
-						this,
-						'POST',
-						`/civicrm/ajax/api4/${entity}/get`,
-						params,
-					);
-					out.push({ json: (res?.values?.[0] ?? {}) as IDataObject });
-				}
+				const params =
+					resource === 'contact'
+						? {
+								where: [['id', '=', id]],
+								limit: 1,
+								select: [
+									'id',
+									'display_name',
+									'first_name',
+									'last_name',
+									'contact_type',
+									'gender_id',
+									'gender_id:name',
+									'birth_date',
+								],
+								chain: {
+									emails: ['Email', 'get', { where: [['contact_id', '=', '$id']] }],
+									phones: ['Phone', 'get', { where: [['contact_id', '=', '$id']] }],
+									addresses: ['Address', 'get', { where: [['contact_id', '=', '$id']] }],
+								},
+						  }
+						: {
+								where: [['id', '=', id]],
+								limit: 1,
+								select: ['id', 'name', 'title', 'subject', 'display_name'],
+						  };
+
+				const res = await civicrmApiRequest.call(
+					this,
+					'POST',
+					`/civicrm/ajax/api4/${entity}/get`,
+					params,
+				);
+
+				out.push({ json: res?.values?.[0] ?? {} });
+				continue;
 			}
 
-			// =========== GET MANY ===========
+			/* ======================================================
+			   GET MANY
+			====================================================== */
 			if (operation === 'getMany') {
-				const returnAll = this.getNodeParameter('returnAll', i, false) as boolean;
 				const limit = this.getNodeParameter('limit', i, 100) as number;
+				const returnAll = this.getNodeParameter('returnAll', i, false) as boolean;
 				const whereJson = this.getNodeParameter('whereJson', i, '') as string;
 
-				let where = whereJson ? JSON.parse(whereJson) : [];
+				let where: any[] = [];
+				if (whereJson) {
+					try {
+						where = JSON.parse(whereJson);
+					} catch {
+						throw new Error('Invalid JSON in whereJson');
+					}
+				}
 
 				if (resource === 'contact') {
 					const contactType = this.getNodeParameter('contactType', i, '') as string;
 					if (contactType) where.push(['contact_type', '=', contactType]);
 				}
 
-				let baseParams: Record<string, unknown>;
-
-				if (resource === 'contact') {
-					baseParams = {
-						where,
-						select: [
-							'id',
-							'display_name',
-							'first_name',
-							'last_name',
-							'contact_type',
-							'gender_id',
-							'gender_id:name',
-							'birth_date',
-						],
-						chain: {
-							emails: ['Email', 'get', { where: [['contact_id', '=', '$id']] }],
-							phones: ['Phone', 'get', { where: [['contact_id', '=', '$id']] }],
-							addresses: ['Address', 'get', { where: [['contact_id', '=', '$id']] }],
-						},
-					};
-				} else {
-					baseParams = {
-						where,
-						select: ['id', 'name', 'title', 'subject', 'display_name'],
-					};
-				}
+				const params =
+					resource === 'contact'
+						? {
+								where,
+								select: [
+									'id',
+									'display_name',
+									'first_name',
+									'last_name',
+									'contact_type',
+									'gender_id',
+									'gender_id:name',
+									'birth_date',
+								],
+								chain: {
+									emails: ['Email', 'get', { where: [['contact_id', '=', '$id']] }],
+									phones: ['Phone', 'get', { where: [['contact_id', '=', '$id']] }],
+									addresses: ['Address', 'get', { where: [['contact_id', '=', '$id']] }],
+								},
+						  }
+						: {
+								where,
+								select: ['id', 'name', 'title', 'subject', 'display_name'],
+						  };
 
 				if (returnAll) {
 					let offset = 0;
 					const page = 500;
 
 					while (true) {
-						const res = await civicrmApiRequest.call(
+						const r = await civicrmApiRequest.call(
 							this,
 							'POST',
 							`/civicrm/ajax/api4/${entity}/get`,
-							{ ...baseParams, limit: page, offset },
+							{ ...params, limit: page, offset },
 						);
 
-						const vals = (res?.values ?? []) as IDataObject[];
+						const vals = r?.values ?? [];
 						for (const v of vals) out.push({ json: v });
 
 						if (vals.length < page) break;
 						offset += page;
 					}
 				} else {
-					const res = await civicrmApiRequest.call(
+					const r = await civicrmApiRequest.call(
 						this,
 						'POST',
 						`/civicrm/ajax/api4/${entity}/get`,
-						{ ...baseParams, limit },
+						{ ...params, limit },
 					);
-					const vals = (res?.values ?? []) as IDataObject[];
+
+					const vals = r?.values ?? [];
 					for (const v of vals) out.push({ json: v });
 				}
+
+				continue;
 			}
 
-			// =========== CREATE / UPDATE ===========
-			const isCreate = operation === 'create';
-			if (isCreate || operation === 'update') {
-				const id = !isCreate ? (this.getNodeParameter('id', i) as number) : undefined;
+			/* ======================================================
+			   DELETE
+			====================================================== */
+			if (operation === 'delete') {
+				const id = this.getNodeParameter('id', i) as number;
 
-				const pairs = this.getNodeParameter('fields.field', i, []) as Array<{
-					fieldName: string;
-					fieldValue: string;
-				}>;
+				const r = await civicrmApiRequest.call(
+					this,
+					'POST',
+					`/civicrm/ajax/api4/${entity}/delete`,
+					{
+						where: [['id', '=', id]],
+					},
+				);
 
-				const values: Record<string, unknown> = {};
-				const emailData: Record<string, unknown> = {};
-				const phoneData: Record<string, unknown> = {};
-				const addressData: Record<string, unknown> = {};
+				out.push({
+					json: {
+						success: true,
+						message: `${entity} ${id} deleted`,
+						deleted_id: id,
+						api_response: r,
+					},
+				});
 
-				// Normaliza birth_date a YYYY-MM-DD con validación
-				function normalizeBirthDate(input: string): string {
-					if (!input) return input;
+				continue;
+			}
 
-					let val = input.trim();
+			/* ======================================================
+			   CREATE / UPDATE
+			====================================================== */
 
-					// YYYY-MM-DD
-					if (/^\d{4}-\d{2}-\d{2}$/.test(val)) return val;
+			const isCreate = operation === 'create';
+			const id = !isCreate ? (this.getNodeParameter('id', i) as number) : undefined;
+
+			const pairs = this.getNodeParameter('fields.field', i, []) as Array<{
+				fieldName: string;
+				fieldValue: string;
+			}>;
+
+			const values: Record<string, unknown> = {};
+			const emailData: Record<string, unknown> = {};
+			const phoneData: Record<string, unknown> = {};
+			const addressData: Record<string, unknown> = {};
+
+			function normalizeBirthDate(input: string): string {
+				if (!input) return input;
+				let v = input.trim();
+
+				if (/^\d{4}-\d{2}-\d{2}$/.test(v)) {
+				} else if (/^\d{2}\/\d{2}\/\d{4}$/.test(v)) {
+					const [d, m, y] = v.split('/');
+					v = `${y}-${m}-${d}`;
+				} else if (/^\d{2}-\d{2}-\d{4}$/.test(v)) {
+					const [d, m, y] = v.split('-');
+					v = `${y}-${m}-${d}`;
+				} else if (/^\d{4}\/\d{2}\/\d{2}$/.test(v)) {
+					v = v.replace(/\//g, '-');
+				} else if (/^\d{4}\.\d{2}\.\d{2}$/.test(v)) {
+					v = v.replace(/\./g, '-');
+				}
 
-					// DD/MM/YYYY
-					if (/^\d{2}\/\d{2}\/\d{4}$/.test(val)) {
-						const [d, m, y] = val.split('/');
-						val = `${y}-${m}-${d}`;
-					}
-					// DD-MM-YYYY
-					else if (/^\d{2}-\d{2}-\d{4}$/.test(val)) {
-						const [d, m, y] = val.split('-');
-						val = `${y}-${m}-${d}`;
-					}
-					// YYYY/MM/DD
-					else if (/^\d{4}\/\d{2}\/\d{2}$/.test(val)) {
-						val = val.replace(/\//g, '-');
-					}
-					// YYYY.MM.DD
-					else if (/^\d{4}\.\d{2}\.\d{2}$/.test(val)) {
-						val = val.replace(/\./g, '-');
-					}
+				const dt = new Date(v);
+				if (isNaN(dt.getTime())) throw new Error(`Invalid birth_date: ${input}`);
+				return v;
+			}
 
-					const date = new Date(val);
-					if (isNaN(date.getTime())) {
-						throw new Error(`Invalid birth_date format: ${input}`);
-					}
+			let locationTypeMap: Record<string, string> = {};
+			if (resource === 'contact') {
+				locationTypeMap = await getLocationTypeMap.call(this);
+			}
 
-					return val;
-				}
+			for (const p of pairs) {
+				if (!p.fieldName) continue;
 
-				// Cargar mapa de location types solo si estamos en contacto
-				let locationTypeMap: Record<string, string> = {};
-				if (resource === 'contact') {
-					locationTypeMap = await getLocationTypeMap.call(this);
+				const key = p.fieldName.trim();
+				const rawVal = convertValue(p.fieldValue);
+				const val = rawVal;
+
+				/* Email simple */
+				if (key === 'email') {
+					emailData.email = val;
+					continue;
+				}
+				if (key.startsWith('email.')) {
+					emailData[key.replace(/^email\./, '')] = val;
+					continue;
 				}
 
-				// Field mapping con soporte para:
-				// - email, email.xxx
-				// - phone, phone.xxx
-				// - address.xxx
-				// - <prefix>.email[.field]
-				// - <prefix>.phone[.field]
-				// - <prefix>.address[.field]
-				for (const p of pairs) {
-					if (!p.fieldName) continue;
-
-					const key = p.fieldName.trim();
-					const rawVal = convertValue(p.fieldValue);
-					const val = rawVal;
-
-					// 1) Casos simples sin prefijo: email / email.xxx / phone / phone.xxx / address.xxx
-
-					// Email simple
-					if (key === 'email') {
-						emailData.email = val;
-						continue;
-					}
-					if (key.startsWith('email.')) {
-						emailData[key.replace(/^email\./, '')] = val;
-						continue;
-					}
+				/* Phone simple */
+				if (key === 'phone') {
+					phoneData.phone = val;
+					continue;
+				}
+				if (key.startsWith('phone.')) {
+					phoneData[key.replace(/^phone\./, '')] = val;
+					continue;
+				}
 
-					// Phone simple
-					if (key === 'phone') {
-						phoneData.phone = val;
-						continue;
-					}
-					if (key.startsWith('phone.')) {
-						phoneData[key.replace(/^phone\./, '')] = val;
-						continue;
-					}
+				/* Address */
+				if (key.startsWith('address.')) {
+					addressData[key.replace(/^address\./, '')] = val;
+					continue;
+				}
 
-					// Address simple
-					if (key.startsWith('address.')) {
-						addressData[key.replace(/^address\./, '')] = val;
-						continue;
-					}
+				/* Prefijo dinámico */
+				const segments = key.split('.');
+				if (segments.length >= 2 && resource === 'contact') {
+					const prefixRaw = segments[0];
+					const root = segments[1];
+					const subfield = segments.slice(2).join('.') || '';
+
+					const normalizedPrefix = normalizeLocationKey(prefixRaw);
+					const mappedLocationName = locationTypeMap[normalizedPrefix];
+
+					if (root === 'email' || root === 'phone' || root === 'address') {
+						if (mappedLocationName) {
+							if (root === 'email') emailLocationName = mappedLocationName;
+							if (root === 'phone') phoneLocationName = mappedLocationName;
+							if (root === 'address') addressLocationName = mappedLocationName;
+						}
 
-					// 2) Prefijo dinámico: <prefix>.email[.field], <prefix>.phone[.field], <prefix>.address[.field]
-					const segments = key.split('.');
-					if (segments.length >= 2 && resource === 'contact') {
-						const prefixRaw = segments[0];
-						const root = segments[1]; // email / phone / address
-						const subfield = segments.slice(2).join('.') || '';
-
-						const normalizedPrefix = normalizeLocationKey(prefixRaw);
-						const mappedLocationName = locationTypeMap[normalizedPrefix];
-
-						if (root === 'email' || root === 'phone' || root === 'address') {
-							// Si el prefijo coincide con un location type, sobreescribir el locationName correspondiente
-							if (mappedLocationName) {
-								if (root === 'email') emailLocationName = mappedLocationName;
-								if (root === 'phone') phoneLocationName = mappedLocationName;
-								if (root === 'address') addressLocationName = mappedLocationName;
-							}
-
-							// Asignar campo
-							if (root === 'email') {
-								if (!subfield) {
-									emailData.email = val;
-								} else {
-									emailData[subfield] = val;
-								}
-								continue;
-							}
-
-							if (root === 'phone') {
-								if (!subfield) {
-									phoneData.phone = val;
-								} else {
-									phoneData[subfield] = val;
-								}
-								continue;
-							}
-
-							if (root === 'address') {
-								if (!subfield) {
-									// No existe campo address "plano", así que ignoramos si no hay subfield
-								} else {
-									addressData[subfield] = val;
-								}
-								continue;
-							}
+						if (root === 'email') {
+							if (!subfield) emailData.email = val;
+							else emailData[subfield] = val;
+							continue;
 						}
-					}
 
-					// 3) gender
-					if (key === 'gender' || key === 'gender_id') {
-						values.gender_id = val;
-						continue;
-					}
+						if (root === 'phone') {
+							if (!subfield) phoneData.phone = val;
+							else phoneData[subfield] = val;
+							continue;
+						}
 
-					// 4) birth_date
-					if (key === 'birth_date' || key === 'birth') {
-						values.birth_date = normalizeBirthDate(String(val));
-						continue;
+						if (root === 'address') {
+							if (subfield) addressData[subfield] = val;
+							continue;
+						}
 					}
-
-					// 5) default → campo de Contact o de la entidad
-					values[key] = val;
 				}
 
-				// contact_type
-				const contactType = this.getNodeParameter('contactType', i, '') as string;
-				if (resource === 'contact' && contactType) {
-					values.contact_type = contactType;
+				/* gender */
+				if (key === 'gender' || key === 'gender_id') {
+					values.gender_id = val;
+					continue;
 				}
 
-				// --- CREATE / UPDATE CONTACT ---
-				let contactId = id;
-				if (isCreate) {
-					const contactRes = await civicrmApiRequest.call(
-						this,
-						'POST',
-						'/civicrm/ajax/api4/Contact/create',
-						{ values },
-					);
-
-					contactId = contactRes?.values?.[0]?.id;
-					if (!contactId) throw new Error('Failed to create contact.');
-				} else {
-					await civicrmApiRequest.call(
-						this,
-						'POST',
-						`/civicrm/ajax/api4/${entity}/update`,
-						{
-							values,
-							where: [['id', '=', contactId]],
-						},
-					);
+				/* birth_date */
+				if (key === 'birth_date' || key === 'birth') {
+					values.birth_date = normalizeBirthDate(String(val));
+					continue;
 				}
 
-				// --- SUBENTITIES (solo para contact) ---
-				if (resource === 'contact') {
-					// Si es primary, limpiar anteriores
-					if (isPrimary) {
-						await civicrmApiRequest.call(
-							this,
-							'POST',
-							'/civicrm/ajax/api4/Email/delete',
-							{
-								where: [
-									['contact_id', '=', contactId],
-									['is_primary', '=', true],
-								],
-							},
-						);
-						await civicrmApiRequest.call(
-							this,
-							'POST',
-							'/civicrm/ajax/api4/Phone/delete',
-							{
-								where: [
-									['contact_id', '=', contactId],
-									['is_primary', '=', true],
-								],
-							},
-						);
-						await civicrmApiRequest.call(
-							this,
-							'POST',
-							'/civicrm/ajax/api4/Address/delete',
-							{
-								where: [
-									['contact_id', '=', contactId],
-									['is_primary', '=', true],
-								],
-							},
-						);
-					}
-
-					// Email
-					if (Object.keys(emailData).length) {
-						await civicrmApiRequest.call(
-							this,
-							'POST',
-							'/civicrm/ajax/api4/Email/create',
-							{
-								values: {
-									...emailData,
-									contact_id: contactId,
-									is_primary: isPrimary,
-									'location_type_id:name': emailLocationName,
-								},
-							},
-						);
-					}
-
-					// Phone
-					if (Object.keys(phoneData).length) {
-						await civicrmApiRequest.call(
-							this,
-							'POST',
-							'/civicrm/ajax/api4/Phone/create',
-							{
-								values: {
-									...phoneData,
-									contact_id: contactId,
-									is_primary: isPrimary,
-									'location_type_id:name': phoneLocationName,
-								},
-							},
-						);
-					}
+				/* default */
+				values[key] = val;
+			}
 
-					// Address
-					if (Object.keys(addressData).length) {
-						await civicrmApiRequest.call(
-							this,
-							'POST',
-							'/civicrm/ajax/api4/Address/create',
-							{
-								values: {
-									...addressData,
-									contact_id: contactId,
-									is_primary: isPrimary,
-									'location_type_id:name': addressLocationName,
-								},
-							},
-						);
-					}
-				}
+			/* Contact type */
+			const contactType = this.getNodeParameter('contactType', i, '') as string;
+			if (resource === 'contact' && contactType) {
+				values.contact_type = contactType;
+			}
 
-				// --- FINAL GET (con gender + birth_date + chain) ---
-				const res = await civicrmApiRequest.call(
+			/* CREATE/UPDATE contact */
+			let contactId = id;
+			if (isCreate) {
+				const r = await civicrmApiRequest.call(
 					this,
 					'POST',
-					`/civicrm/ajax/api4/${entity}/get`,
+					'/civicrm/ajax/api4/Contact/create',
+					{ values },
+				);
+				contactId = r?.values?.[0]?.id;
+				if (!contactId) throw new Error('Failed to create contact.');
+			} else {
+				await civicrmApiRequest.call(
+					this,
+					'POST',
+					`/civicrm/ajax/api4/${entity}/update`,
 					{
+						values,
 						where: [['id', '=', contactId]],
-						select: [
-							'id',
-							'display_name',
-							'first_name',
-							'last_name',
-							'contact_type',
-							'gender_id',
-							'gender_id:name',
-							'birth_date',
-						],
-						...(resource === 'contact'
-							? {
-									chain: {
-										emails: ['Email', 'get', { where: [['contact_id', '=', '$id']] }],
-										phones: ['Phone', 'get', { where: [['contact_id', '=', '$id']] }],
-										addresses: ['Address', 'get', { where: [['contact_id', '=', '$id']] }],
-									},
-							  }
-							: {}),
 					},
 				);
+			}
+
+			/* SUBENTITIES */
+			if (resource === 'contact') {
+				if (isPrimary) {
+					await civicrmApiRequest.call(this, 'POST', '/civicrm/ajax/api4/Email/delete', {
+						where: [
+							['contact_id', '=', contactId],
+							['is_primary', '=', true],
+						],
+					});
+					await civicrmApiRequest.call(this, 'POST', '/civicrm/ajax/api4/Phone/delete', {
+						where: [
+							['contact_id', '=', contactId],
+							['is_primary', '=', true],
+						],
+					});
+					await civicrmApiRequest.call(this, 'POST', '/civicrm/ajax/api4/Address/delete', {
+						where: [
+							['contact_id', '=', contactId],
+							['is_primary', '=', true],
+						],
+					});
+				}
+
+				if (Object.keys(emailData).length) {
+					await civicrmApiRequest.call(this, 'POST', '/civicrm/ajax/api4/Email/create', {
+						values: {
+							...emailData,
+							contact_id: contactId,
+							is_primary: isPrimary,
+							'location_type_id:name': emailLocationName,
+						},
+					});
+				}
 
-				out.push({ json: (res?.values?.[0] ?? {}) as IDataObject });
+				if (Object.keys(phoneData).length) {
+					await civicrmApiRequest.call(this, 'POST', '/civicrm/ajax/api4/Phone/create', {
+						values: {
+							...phoneData,
+							contact_id: contactId,
+							is_primary: isPrimary,
+							'location_type_id:name': phoneLocationName,
+						},
+					});
+				}
+
+				if (Object.keys(addressData).length) {
+					await civicrmApiRequest.call(this, 'POST', '/civicrm/ajax/api4/Address/create', {
+						values: {
+							...addressData,
+							contact_id: contactId,
+							is_primary: isPrimary,
+							'location_type_id:name': addressLocationName,
+						},
+					});
+				}
 			}
+
+			/* FINAL GET */
+			const res = await civicrmApiRequest.call(
+				this,
+				'POST',
+				`/civicrm/ajax/api4/${entity}/get`,
+				{
+					where: [['id', '=', contactId]],
+					select: [
+						'id',
+						'display_name',
+						'first_name',
+						'last_name',
+						'contact_type',
+						'gender_id',
+						'gender_id:name',
+						'birth_date',
+					],
+					...(resource === 'contact'
+						? {
+								chain: {
+									emails: ['Email', 'get', { where: [['contact_id', '=', '$id']] }],
+									phones: ['Phone', 'get', { where: [['contact_id', '=', '$id']] }],
+									addresses: ['Address', 'get', { where: [['contact_id', '=', '$id']] }],
+								},
+						  }
+						: {}),
+				},
+			);
+
+			out.push({ json: res?.values?.[0] ?? {} });
 		}
 
 		return [out];
 	}
 }
 
+/* ============================================================================
+   UTILS
+============================================================================ */
+
 function convertValue(val: string): unknown {
 	const t = String(val ?? '').trim();
 	if (t === '') return '';