@iwer/devui 0.2.0 → 0.2.1

package/build/iwer-devui.js

@@ -5834,7 +5834,7 @@
 	 * Copyright 2010-2024 Three.js Authors
 	 * SPDX-License-Identifier: MIT
 	 */
-	const REVISION = '169';
+	const REVISION = '168';
 	const CullFaceNone = 0;
 	const CullFaceBack = 1;
 	const CullFaceFront = 2;
@@ -7139,38 +7139,6 @@
 
 	}
 
-	function toNormalizedProjectionMatrix( projectionMatrix ) {
-
-		const m = projectionMatrix.elements;
-
-		// Convert [-1, 1] to [0, 1] projection matrix
-		m[ 2 ] = 0.5 * m[ 2 ] + 0.5 * m[ 3 ];
-		m[ 6 ] = 0.5 * m[ 6 ] + 0.5 * m[ 7 ];
-		m[ 10 ] = 0.5 * m[ 10 ] + 0.5 * m[ 11 ];
-		m[ 14 ] = 0.5 * m[ 14 ] + 0.5 * m[ 15 ];
-
-	}
-
-	function toReversedProjectionMatrix( projectionMatrix ) {
-
-		const m = projectionMatrix.elements;
-		const isPerspectiveMatrix = m[ 11 ] === - 1;
-
-		// Reverse [0, 1] projection matrix
-		if ( isPerspectiveMatrix ) {
-
-			m[ 10 ] = - m[ 10 ] - 1;
-			m[ 14 ] = - m[ 14 ];
-
-		} else {
-
-			m[ 10 ] = - m[ 10 ];
-			m[ 14 ] = - m[ 14 ] + 1;
-
-		}
-
-	}
-
 	/**
 	 * Matrices converting P3 <-> Rec. 709 primaries, without gamut mapping
 	 * or clipping. Based on W3C specifications for sRGB and Display P3,
@@ -13730,10 +13698,6 @@
 	const _vbp = /*@__PURE__*/ new Vector3();
 	const _vcp = /*@__PURE__*/ new Vector3();
 
-	const _v40 = /*@__PURE__*/ new Vector4();
-	const _v41 = /*@__PURE__*/ new Vector4();
-	const _v42 = /*@__PURE__*/ new Vector4();
-
 	class Triangle {
 
 		constructor( a = new Vector3(), b = new Vector3(), c = new Vector3() ) {
@@ -13828,25 +13792,6 @@
 
 		}
 
-		static getInterpolatedAttribute( attr, i1, i2, i3, barycoord, target ) {
-
-			_v40.setScalar( 0 );
-			_v41.setScalar( 0 );
-			_v42.setScalar( 0 );
-
-			_v40.fromBufferAttribute( attr, i1 );
-			_v41.fromBufferAttribute( attr, i2 );
-			_v42.fromBufferAttribute( attr, i3 );
-
-			target.setScalar( 0 );
-			target.addScaledVector( _v40, barycoord.x );
-			target.addScaledVector( _v41, barycoord.y );
-			target.addScaledVector( _v42, barycoord.z );
-
-			return target;
-
-		}
-
 		static isFrontFacing( a, b, c, direction ) {
 
 			_v0$2.subVectors( c, b );
@@ -15293,6 +15238,7 @@
 			this.normalized = normalized;
 
 			this.usage = StaticDrawUsage;
+			this._updateRange = { offset: 0, count: - 1 };
 			this.updateRanges = [];
 			this.gpuType = FloatType;
 
@@ -15308,6 +15254,13 @@
 
 		}
 
+		get updateRange() {
+
+			warnOnce( 'THREE.BufferAttribute: updateRange() is deprecated and will be removed in r169. Use addUpdateRange() instead.' ); // @deprecated, r159
+			return this._updateRange;
+
+		}
+
 		setUsage( value ) {
 
 			this.usage = value;
@@ -16748,6 +16701,14 @@
 	const _tempA = /*@__PURE__*/ new Vector3();
 	const _morphA = /*@__PURE__*/ new Vector3();
 
+	const _uvA$1 = /*@__PURE__*/ new Vector2();
+	const _uvB$1 = /*@__PURE__*/ new Vector2();
+	const _uvC$1 = /*@__PURE__*/ new Vector2();
+
+	const _normalA = /*@__PURE__*/ new Vector3();
+	const _normalB = /*@__PURE__*/ new Vector3();
+	const _normalC = /*@__PURE__*/ new Vector3();
+
 	const _intersectionPoint = /*@__PURE__*/ new Vector3();
 	const _intersectionPointWorld = /*@__PURE__*/ new Vector3();
 
@@ -17090,24 +17051,33 @@
 
 		if ( intersection ) {
 
-			const barycoord = new Vector3();
-			Triangle.getBarycoord( _intersectionPoint, _vA$1, _vB$1, _vC$1, barycoord );
-
 			if ( uv ) {
 
-				intersection.uv = Triangle.getInterpolatedAttribute( uv, a, b, c, barycoord, new Vector2() );
+				_uvA$1.fromBufferAttribute( uv, a );
+				_uvB$1.fromBufferAttribute( uv, b );
+				_uvC$1.fromBufferAttribute( uv, c );
+
+				intersection.uv = Triangle.getInterpolation( _intersectionPoint, _vA$1, _vB$1, _vC$1, _uvA$1, _uvB$1, _uvC$1, new Vector2() );
 
 			}
 
 			if ( uv1 ) {
 
-				intersection.uv1 = Triangle.getInterpolatedAttribute( uv1, a, b, c, barycoord, new Vector2() );
+				_uvA$1.fromBufferAttribute( uv1, a );
+				_uvB$1.fromBufferAttribute( uv1, b );
+				_uvC$1.fromBufferAttribute( uv1, c );
+
+				intersection.uv1 = Triangle.getInterpolation( _intersectionPoint, _vA$1, _vB$1, _vC$1, _uvA$1, _uvB$1, _uvC$1, new Vector2() );
 
 			}
 
 			if ( normal ) {
 
-				intersection.normal = Triangle.getInterpolatedAttribute( normal, a, b, c, barycoord, new Vector3() );
+				_normalA.fromBufferAttribute( normal, a );
+				_normalB.fromBufferAttribute( normal, b );
+				_normalC.fromBufferAttribute( normal, c );
+
+				intersection.normal = Triangle.getInterpolation( _intersectionPoint, _vA$1, _vB$1, _vC$1, _normalA, _normalB, _normalC, new Vector3() );
 
 				if ( intersection.normal.dot( ray.direction ) > 0 ) {
 
@@ -17128,7 +17098,6 @@
 			Triangle.getNormal( _vA$1, _vB$1, _vC$1, face.normal );
 
 			intersection.face = face;
-			intersection.barycoord = barycoord;
 
 		}
 
@@ -18772,60 +18741,19 @@
 		function updateBuffer( buffer, attribute, bufferType ) {
 
 			const array = attribute.array;
+			const updateRange = attribute._updateRange; // @deprecated, r159
 			const updateRanges = attribute.updateRanges;
 
 			gl.bindBuffer( bufferType, buffer );
 
-			if ( updateRanges.length === 0 ) {
+			if ( updateRange.count === - 1 && updateRanges.length === 0 ) {
 
 				// Not using update ranges
 				gl.bufferSubData( bufferType, 0, array );
 
-			} else {
-
-				// Before applying update ranges, we merge any adjacent / overlapping
-				// ranges to reduce load on `gl.bufferSubData`. Empirically, this has led
-				// to performance improvements for applications which make heavy use of
-				// update ranges. Likely due to GPU command overhead.
-				//
-				// Note that to reduce garbage collection between frames, we merge the
-				// update ranges in-place. This is safe because this method will clear the
-				// update ranges once updated.
-
-				updateRanges.sort( ( a, b ) => a.start - b.start );
-
-				// To merge the update ranges in-place, we work from left to right in the
-				// existing updateRanges array, merging ranges. This may result in a final
-				// array which is smaller than the original. This index tracks the last
-				// index representing a merged range, any data after this index can be
-				// trimmed once the merge algorithm is completed.
-				let mergeIndex = 0;
-
-				for ( let i = 1; i < updateRanges.length; i ++ ) {
-
-					const previousRange = updateRanges[ mergeIndex ];
-					const range = updateRanges[ i ];
-
-					// We add one here to merge adjacent ranges. This is safe because ranges
-					// operate over positive integers.
-					if ( range.start <= previousRange.start + previousRange.count + 1 ) {
-
-						previousRange.count = Math.max(
-							previousRange.count,
-							range.start + range.count - previousRange.start
-						);
-
-					} else {
-
-						++ mergeIndex;
-						updateRanges[ mergeIndex ] = range;
-
-					}
-
-				}
+			}
 
-				// Trim the array to only contain the merged ranges.
-				updateRanges.length = mergeIndex + 1;
+			if ( updateRanges.length !== 0 ) {
 
 				for ( let i = 0, l = updateRanges.length; i < l; i ++ ) {
 
@@ -18840,6 +18768,16 @@
 
 			}
 
+			// @deprecated, r159
+			if ( updateRange.count !== - 1 ) {
+
+				gl.bufferSubData( bufferType, updateRange.offset * array.BYTES_PER_ELEMENT,
+					array, updateRange.offset, updateRange.count );
+
+				updateRange.count = - 1; // reset range
+
+			}
+
 			attribute.onUploadCallback();
 
 		}
@@ -19297,7 +19235,7 @@
 
 	const fragment$2 = "uniform vec3 color;\nuniform float opacity;\n#include <common>\n#include <packing>\n#include <fog_pars_fragment>\n#include <bsdfs>\n#include <lights_pars_begin>\n#include <logdepthbuf_pars_fragment>\n#include <shadowmap_pars_fragment>\n#include <shadowmask_pars_fragment>\nvoid main() {\n\t#include <logdepthbuf_fragment>\n\tgl_FragColor = vec4( color, opacity * ( 1.0 - getShadowMask() ) );\n\t#include <tonemapping_fragment>\n\t#include <colorspace_fragment>\n\t#include <fog_fragment>\n}";
 
-	const vertex$1 = "uniform float rotation;\nuniform vec2 center;\n#include <common>\n#include <uv_pars_vertex>\n#include <fog_pars_vertex>\n#include <logdepthbuf_pars_vertex>\n#include <clipping_planes_pars_vertex>\nvoid main() {\n\t#include <uv_vertex>\n\tvec4 mvPosition = modelViewMatrix[ 3 ];\n\tvec2 scale = vec2( length( modelMatrix[ 0 ].xyz ), length( modelMatrix[ 1 ].xyz ) );\n\t#ifndef USE_SIZEATTENUATION\n\t\tbool isPerspective = isPerspectiveMatrix( projectionMatrix );\n\t\tif ( isPerspective ) scale *= - mvPosition.z;\n\t#endif\n\tvec2 alignedPosition = ( position.xy - ( center - vec2( 0.5 ) ) ) * scale;\n\tvec2 rotatedPosition;\n\trotatedPosition.x = cos( rotation ) * alignedPosition.x - sin( rotation ) * alignedPosition.y;\n\trotatedPosition.y = sin( rotation ) * alignedPosition.x + cos( rotation ) * alignedPosition.y;\n\tmvPosition.xy += rotatedPosition;\n\tgl_Position = projectionMatrix * mvPosition;\n\t#include <logdepthbuf_vertex>\n\t#include <clipping_planes_vertex>\n\t#include <fog_vertex>\n}";
+	const vertex$1 = "uniform float rotation;\nuniform vec2 center;\n#include <common>\n#include <uv_pars_vertex>\n#include <fog_pars_vertex>\n#include <logdepthbuf_pars_vertex>\n#include <clipping_planes_pars_vertex>\nvoid main() {\n\t#include <uv_vertex>\n\tvec4 mvPosition = modelViewMatrix * vec4( 0.0, 0.0, 0.0, 1.0 );\n\tvec2 scale;\n\tscale.x = length( vec3( modelMatrix[ 0 ].x, modelMatrix[ 0 ].y, modelMatrix[ 0 ].z ) );\n\tscale.y = length( vec3( modelMatrix[ 1 ].x, modelMatrix[ 1 ].y, modelMatrix[ 1 ].z ) );\n\t#ifndef USE_SIZEATTENUATION\n\t\tbool isPerspective = isPerspectiveMatrix( projectionMatrix );\n\t\tif ( isPerspective ) scale *= - mvPosition.z;\n\t#endif\n\tvec2 alignedPosition = ( position.xy - ( center - vec2( 0.5 ) ) ) * scale;\n\tvec2 rotatedPosition;\n\trotatedPosition.x = cos( rotation ) * alignedPosition.x - sin( rotation ) * alignedPosition.y;\n\trotatedPosition.y = sin( rotation ) * alignedPosition.x + cos( rotation ) * alignedPosition.y;\n\tmvPosition.xy += rotatedPosition;\n\tgl_Position = projectionMatrix * mvPosition;\n\t#include <logdepthbuf_vertex>\n\t#include <clipping_planes_vertex>\n\t#include <fog_vertex>\n}";
 
 	const fragment$1 = "uniform vec3 diffuse;\nuniform float opacity;\n#include <common>\n#include <uv_pars_fragment>\n#include <map_pars_fragment>\n#include <alphamap_pars_fragment>\n#include <alphatest_pars_fragment>\n#include <alphahash_pars_fragment>\n#include <fog_pars_fragment>\n#include <logdepthbuf_pars_fragment>\n#include <clipping_planes_pars_fragment>\nvoid main() {\n\tvec4 diffuseColor = vec4( diffuse, opacity );\n\t#include <clipping_planes_fragment>\n\tvec3 outgoingLight = vec3( 0.0 );\n\t#include <logdepthbuf_fragment>\n\t#include <map_fragment>\n\t#include <alphamap_fragment>\n\t#include <alphatest_fragment>\n\t#include <alphahash_fragment>\n\toutgoingLight = diffuseColor.rgb;\n\t#include <opaque_fragment>\n\t#include <tonemapping_fragment>\n\t#include <colorspace_fragment>\n\t#include <fog_fragment>\n}";
 
@@ -21063,14 +21001,6 @@
 		}
 
 		const logarithmicDepthBuffer = parameters.logarithmicDepthBuffer === true;
-		const reverseDepthBuffer = parameters.reverseDepthBuffer === true && extensions.has( 'EXT_clip_control' );
-
-		if ( reverseDepthBuffer === true ) {
-
-			const ext = extensions.get( 'EXT_clip_control' );
-			ext.clipControlEXT( ext.LOWER_LEFT_EXT, ext.ZERO_TO_ONE_EXT );
-
-		}
 
 		const maxTextures = gl.getParameter( gl.MAX_TEXTURE_IMAGE_UNITS );
 		const maxVertexTextures = gl.getParameter( gl.MAX_VERTEX_TEXTURE_IMAGE_UNITS );
@@ -21098,7 +21028,6 @@
 
 			precision: precision,
 			logarithmicDepthBuffer: logarithmicDepthBuffer,
-			reverseDepthBuffer: reverseDepthBuffer,
 
 			maxTextures: maxTextures,
 			maxVertexTextures: maxVertexTextures,
@@ -25116,7 +25045,6 @@
 				parameters.numLightProbes > 0 ? '#define USE_LIGHT_PROBES' : '',
 
 				parameters.logarithmicDepthBuffer ? '#define USE_LOGDEPTHBUF' : '',
-				parameters.reverseDepthBuffer ? '#define USE_REVERSEDEPTHBUF' : '',
 
 				'uniform mat4 modelMatrix;',
 				'uniform mat4 modelViewMatrix;',
@@ -25282,7 +25210,6 @@
 				parameters.decodeVideoTexture ? '#define DECODE_VIDEO_TEXTURE' : '',
 
 				parameters.logarithmicDepthBuffer ? '#define USE_LOGDEPTHBUF' : '',
-				parameters.reverseDepthBuffer ? '#define USE_REVERSEDEPTHBUF' : '',
 
 				'uniform mat4 viewMatrix;',
 				'uniform vec3 cameraPosition;',
@@ -25675,7 +25602,6 @@
 		const programs = [];
 
 		const logarithmicDepthBuffer = capabilities.logarithmicDepthBuffer;
-		const reverseDepthBuffer = capabilities.reverseDepthBuffer;
 		const SUPPORTS_VERTEX_TEXTURES = capabilities.vertexTextures;
 
 		let precision = capabilities.precision;
@@ -25967,7 +25893,6 @@
 
 				sizeAttenuation: material.sizeAttenuation === true,
 				logarithmicDepthBuffer: logarithmicDepthBuffer,
-				reverseDepthBuffer: reverseDepthBuffer,
 
 				skinning: object.isSkinnedMesh === true,
 
@@ -26187,40 +26112,38 @@
 				_programLayers.enable( 2 );
 			if ( parameters.logarithmicDepthBuffer )
 				_programLayers.enable( 3 );
-			if ( parameters.reverseDepthBuffer )
-				_programLayers.enable( 4 );
 			if ( parameters.skinning )
-				_programLayers.enable( 5 );
+				_programLayers.enable( 4 );
 			if ( parameters.morphTargets )
-				_programLayers.enable( 6 );
+				_programLayers.enable( 5 );
 			if ( parameters.morphNormals )
-				_programLayers.enable( 7 );
+				_programLayers.enable( 6 );
 			if ( parameters.morphColors )
-				_programLayers.enable( 8 );
+				_programLayers.enable( 7 );
 			if ( parameters.premultipliedAlpha )
-				_programLayers.enable( 9 );
+				_programLayers.enable( 8 );
 			if ( parameters.shadowMapEnabled )
-				_programLayers.enable( 10 );
+				_programLayers.enable( 9 );
 			if ( parameters.doubleSided )
-				_programLayers.enable( 11 );
+				_programLayers.enable( 10 );
 			if ( parameters.flipSided )
-				_programLayers.enable( 12 );
+				_programLayers.enable( 11 );
 			if ( parameters.useDepthPacking )
-				_programLayers.enable( 13 );
+				_programLayers.enable( 12 );
 			if ( parameters.dithering )
-				_programLayers.enable( 14 );
+				_programLayers.enable( 13 );
 			if ( parameters.transmission )
-				_programLayers.enable( 15 );
+				_programLayers.enable( 14 );
 			if ( parameters.sheen )
-				_programLayers.enable( 16 );
+				_programLayers.enable( 15 );
 			if ( parameters.opaque )
-				_programLayers.enable( 17 );
+				_programLayers.enable( 16 );
 			if ( parameters.pointsUvs )
-				_programLayers.enable( 18 );
+				_programLayers.enable( 17 );
 			if ( parameters.decodeVideoTexture )
-				_programLayers.enable( 19 );
+				_programLayers.enable( 18 );
 			if ( parameters.alphaToCoverage )
-				_programLayers.enable( 20 );
+				_programLayers.enable( 19 );
 
 			array.push( _programLayers.mask );
 
@@ -27778,18 +27701,6 @@
 
 	}
 
-	const reversedFuncs = {
-		[ NeverDepth ]: AlwaysDepth,
-		[ LessDepth ]: GreaterDepth,
-		[ EqualDepth ]: NotEqualDepth,
-		[ LessEqualDepth ]: GreaterEqualDepth,
-
-		[ AlwaysDepth ]: NeverDepth,
-		[ GreaterDepth ]: LessDepth,
-		[ NotEqualDepth ]: EqualDepth,
-		[ GreaterEqualDepth ]: LessEqualDepth,
-	};
-
 	function WebGLState( gl ) {
 
 		function ColorBuffer() {
@@ -27854,7 +27765,6 @@
 		function DepthBuffer() {
 
 			let locked = false;
-			let reversed = false;
 
 			let currentDepthMask = null;
 			let currentDepthFunc = null;
@@ -27862,12 +27772,6 @@
 
 			return {
 
-				setReversed: function ( value ) {
-
-					reversed = value;
-
-				},
-
 				setTest: function ( depthTest ) {
 
 					if ( depthTest ) {
@@ -27895,8 +27799,6 @@
 
 				setFunc: function ( depthFunc ) {
 
-					if ( reversed ) depthFunc = reversedFuncs[ depthFunc ];
-
 					if ( currentDepthFunc !== depthFunc ) {
 
 						switch ( depthFunc ) {
@@ -29367,28 +29269,6 @@
 
 			}
 
-			if ( glFormat === _gl.RGB_INTEGER ) {
-
-				if ( glType === _gl.UNSIGNED_BYTE ) internalFormat = _gl.RGB8UI;
-				if ( glType === _gl.UNSIGNED_SHORT ) internalFormat = _gl.RGB16UI;
-				if ( glType === _gl.UNSIGNED_INT ) internalFormat = _gl.RGB32UI;
-				if ( glType === _gl.BYTE ) internalFormat = _gl.RGB8I;
-				if ( glType === _gl.SHORT ) internalFormat = _gl.RGB16I;
-				if ( glType === _gl.INT ) internalFormat = _gl.RGB32I;
-
-			}
-
-			if ( glFormat === _gl.RGBA_INTEGER ) {
-
-				if ( glType === _gl.UNSIGNED_BYTE ) internalFormat = _gl.RGBA8UI;
-				if ( glType === _gl.UNSIGNED_SHORT ) internalFormat = _gl.RGBA16UI;
-				if ( glType === _gl.UNSIGNED_INT ) internalFormat = _gl.RGBA32UI;
-				if ( glType === _gl.BYTE ) internalFormat = _gl.RGBA8I;
-				if ( glType === _gl.SHORT ) internalFormat = _gl.RGBA16I;
-				if ( glType === _gl.INT ) internalFormat = _gl.RGBA32I;
-
-			}
-
 			if ( glFormat === _gl.RGB ) {
 
 				if ( glType === _gl.UNSIGNED_INT_5_9_9_9_REV ) internalFormat = _gl.RGB9_E5;
@@ -33982,7 +33862,6 @@ void main() {
 
 			// camera matrices cache
 
-			const _currentProjectionMatrix = new Matrix4();
 			const _projScreenMatrix = new Matrix4();
 
 			const _vector3 = new Vector3();
@@ -34078,8 +33957,6 @@ void main() {
 
 				state = new WebGLState( _gl );
 
-				if ( capabilities.reverseDepthBuffer ) state.buffers.depth.setReversed( true );
-
 				info = new WebGLInfo( _gl );
 				properties = new WebGLProperties();
 				textures = new WebGLTextures( _gl, extensions, state, properties, capabilities, utils, info );
@@ -34379,13 +34256,7 @@ void main() {
 
 				}
 
-				if ( depth ) {
-
-					bits |= _gl.DEPTH_BUFFER_BIT;
-					_gl.clearDepth( this.capabilities.reverseDepthBuffer ? 0 : 1 );
-
-				}
-
+				if ( depth ) bits |= _gl.DEPTH_BUFFER_BIT;
 				if ( stencil ) {
 
 					bits |= _gl.STENCIL_BUFFER_BIT;
@@ -34774,12 +34645,6 @@ void main() {
 
 				scene.traverse( function ( object ) {
 
-					if ( ! ( object.isMesh || object.isPoints || object.isLine || object.isSprite ) ) {
-
-						return;
-
-					}
-
 					const material = object.material;
 
 					if ( material ) {
@@ -35766,21 +35631,7 @@ void main() {
 
 					// common camera uniforms
 
-					if ( capabilities.reverseDepthBuffer ) {
-
-						_currentProjectionMatrix.copy( camera.projectionMatrix );
-
-						toNormalizedProjectionMatrix( _currentProjectionMatrix );
-						toReversedProjectionMatrix( _currentProjectionMatrix );
-
-						p_uniforms.setValue( _gl, 'projectionMatrix', _currentProjectionMatrix );
-
-					} else {
-
-						p_uniforms.setValue( _gl, 'projectionMatrix', camera.projectionMatrix );
-
-					}
-
+					p_uniforms.setValue( _gl, 'projectionMatrix', camera.projectionMatrix );
 					p_uniforms.setValue( _gl, 'viewMatrix', camera.matrixWorldInverse );
 
 					const uCamPos = p_uniforms.map.cameraPosition;
@@ -36261,55 +36112,61 @@ void main() {
 
 				if ( framebuffer ) {
 
-					const texture = renderTarget.texture;
-					const textureFormat = texture.format;
-					const textureType = texture.type;
+					state.bindFramebuffer( _gl.FRAMEBUFFER, framebuffer );
 
-					if ( ! capabilities.textureFormatReadable( textureFormat ) ) {
+					try {
 
-						throw new Error( 'THREE.WebGLRenderer.readRenderTargetPixelsAsync: renderTarget is not in RGBA or implementation defined format.' );
+						const texture = renderTarget.texture;
+						const textureFormat = texture.format;
+						const textureType = texture.type;
 
-					}
+						if ( ! capabilities.textureFormatReadable( textureFormat ) ) {
 
-					if ( ! capabilities.textureTypeReadable( textureType ) ) {
+							throw new Error( 'THREE.WebGLRenderer.readRenderTargetPixelsAsync: renderTarget is not in RGBA or implementation defined format.' );
 
-						throw new Error( 'THREE.WebGLRenderer.readRenderTargetPixelsAsync: renderTarget is not in UnsignedByteType or implementation defined type.' );
+						}
 
-					}
+						if ( ! capabilities.textureTypeReadable( textureType ) ) {
 
-					// the following if statement ensures valid read requests (no out-of-bounds pixels, see #8604)
-					if ( ( x >= 0 && x <= ( renderTarget.width - width ) ) && ( y >= 0 && y <= ( renderTarget.height - height ) ) ) {
+							throw new Error( 'THREE.WebGLRenderer.readRenderTargetPixelsAsync: renderTarget is not in UnsignedByteType or implementation defined type.' );
 
-						// set the active frame buffer to the one we want to read
-						state.bindFramebuffer( _gl.FRAMEBUFFER, framebuffer );
+						}
 
-						const glBuffer = _gl.createBuffer();
-						_gl.bindBuffer( _gl.PIXEL_PACK_BUFFER, glBuffer );
-						_gl.bufferData( _gl.PIXEL_PACK_BUFFER, buffer.byteLength, _gl.STREAM_READ );
-						_gl.readPixels( x, y, width, height, utils.convert( textureFormat ), utils.convert( textureType ), 0 );
+						// the following if statement ensures valid read requests (no out-of-bounds pixels, see #8604)
+						if ( ( x >= 0 && x <= ( renderTarget.width - width ) ) && ( y >= 0 && y <= ( renderTarget.height - height ) ) ) {
 
-						// reset the frame buffer to the currently set buffer before waiting
-						const currFramebuffer = _currentRenderTarget !== null ? properties.get( _currentRenderTarget ).__webglFramebuffer : null;
-						state.bindFramebuffer( _gl.FRAMEBUFFER, currFramebuffer );
+							const glBuffer = _gl.createBuffer();
+							_gl.bindBuffer( _gl.PIXEL_PACK_BUFFER, glBuffer );
+							_gl.bufferData( _gl.PIXEL_PACK_BUFFER, buffer.byteLength, _gl.STREAM_READ );
+							_gl.readPixels( x, y, width, height, utils.convert( textureFormat ), utils.convert( textureType ), 0 );
+							_gl.flush();
 
-						// check if the commands have finished every 8 ms
-						const sync = _gl.fenceSync( _gl.SYNC_GPU_COMMANDS_COMPLETE, 0 );
+							// check if the commands have finished every 8 ms
+							const sync = _gl.fenceSync( _gl.SYNC_GPU_COMMANDS_COMPLETE, 0 );
+							await probeAsync( _gl, sync, 4 );
 
-						_gl.flush();
+							try {
 
-						await probeAsync( _gl, sync, 4 );
+								_gl.bindBuffer( _gl.PIXEL_PACK_BUFFER, glBuffer );
+								_gl.getBufferSubData( _gl.PIXEL_PACK_BUFFER, 0, buffer );
 
-						// read the data and delete the buffer
-						_gl.bindBuffer( _gl.PIXEL_PACK_BUFFER, glBuffer );
-						_gl.getBufferSubData( _gl.PIXEL_PACK_BUFFER, 0, buffer );
-						_gl.deleteBuffer( glBuffer );
-						_gl.deleteSync( sync );
+							} finally {
 
-						return buffer;
+								_gl.deleteBuffer( glBuffer );
+								_gl.deleteSync( sync );
 
-					} else {
+							}
+
+							return buffer;
+
+						}
+
+					} finally {
 
-						throw new Error( 'THREE.WebGLRenderer.readRenderTargetPixelsAsync: requested read bounds are out of range.' );
+						// restore framebuffer of current render target if necessary
+
+						const framebuffer = ( _currentRenderTarget !== null ) ? properties.get( _currentRenderTarget ).__webglFramebuffer : null;
+						state.bindFramebuffer( _gl.FRAMEBUFFER, framebuffer );
 
 					}
 
@@ -36991,7 +36848,6 @@ void main() {
 			index: a,
 			face: null,
 			faceIndex: null,
-			barycoord: null,
 			object: object
 
 		};
@@ -37128,19 +36984,12 @@ void main() {
 
 						// faces
 
-						if ( radiusTop > 0 ) {
-
-							indices.push( a, b, d );
-							groupCount += 3;
-
-						}
-
-						if ( radiusBottom > 0 ) {
+						indices.push( a, b, d );
+						indices.push( b, c, d );
 
-							indices.push( b, c, d );
-							groupCount += 3;
+						// update group counter
 
-						}
+						groupCount += 6;
 
 					}
 
@@ -38122,35 +37971,6 @@ void main() {
 
 	}
 
-	class Controls extends EventDispatcher {
-
-		constructor( object, domElement = null ) {
-
-			super();
-
-			this.object = object;
-			this.domElement = domElement;
-
-			this.enabled = true;
-
-			this.state = - 1;
-
-			this.keys = {};
-			this.mouseButtons = { LEFT: null, MIDDLE: null, RIGHT: null };
-			this.touches = { ONE: null, TWO: null };
-
-		}
-
-		connect() {}
-
-		disconnect() {}
-
-		dispose() {}
-
-		update( /* delta */ ) {}
-
-	}
-
 	if ( typeof __THREE_DEVTOOLS__ !== 'undefined' ) {
 
 		__THREE_DEVTOOLS__.dispatchEvent( new CustomEvent( 'register', { detail: {
@@ -38189,22 +38009,32 @@ void main() {
 	const _mouseUpEvent = { type: 'mouseUp', mode: null };
 	const _objectChangeEvent = { type: 'objectChange' };
 
-	class TransformControls extends Controls {
+	class TransformControls extends Object3D {
+
+		constructor( camera, domElement ) {
+
+			super();
+
+			if ( domElement === undefined ) {
 
-		constructor( camera, domElement = null ) {
+				console.warn( 'THREE.TransformControls: The second parameter "domElement" is now mandatory.' );
+				domElement = document;
 
-			super( undefined, domElement );
+			}
+
+			this.isTransformControls = true;
 
-			const root = new TransformControlsRoot( this );
-			this._root = root;
+			this.visible = false;
+			this.domElement = domElement;
+			this.domElement.style.touchAction = 'none'; // disable touch scroll
 
-			const gizmo = new TransformControlsGizmo();
-			this._gizmo = gizmo;
-			root.add( gizmo );
+			const _gizmo = new TransformControlsGizmo();
+			this._gizmo = _gizmo;
+			this.add( _gizmo );
 
-			const plane = new TransformControlsPlane();
-			this._plane = plane;
-			root.add( plane );
+			const _plane = new TransformControlsPlane();
+			this._plane = _plane;
+			this.add( _plane );
 
 			const scope = this;
 
@@ -38226,8 +38056,8 @@ void main() {
 						if ( propValue !== value ) {
 
 							propValue = value;
-							plane[ propName ] = value;
-							gizmo[ propName ] = value;
+							_plane[ propName ] = value;
+							_gizmo[ propName ] = value;
 
 							scope.dispatchEvent( { type: propName + '-changed', value: value } );
 							scope.dispatchEvent( _changeEvent );
@@ -38239,8 +38069,8 @@ void main() {
 				} );
 
 				scope[ propName ] = defaultValue;
-				plane[ propName ] = defaultValue;
-				gizmo[ propName ] = defaultValue;
+				_plane[ propName ] = defaultValue;
+				_gizmo[ propName ] = defaultValue;
 
 			}
 
@@ -38315,38 +38145,50 @@ void main() {
 			this._onPointerMove = onPointerMove.bind( this );
 			this._onPointerUp = onPointerUp.bind( this );
 
-			if ( domElement !== null ) {
+			this.domElement.addEventListener( 'pointerdown', this._onPointerDown );
+			this.domElement.addEventListener( 'pointermove', this._onPointerHover );
+			this.domElement.addEventListener( 'pointerup', this._onPointerUp );
 
-				this.connect();
+		}
 
-			}
+		// updateMatrixWorld updates key transformation variables
+		updateMatrixWorld( force ) {
 
-		}
+			if ( this.object !== undefined ) {
 
-		connect() {
+				this.object.updateMatrixWorld();
 
-			this.domElement.addEventListener( 'pointerdown', this._onPointerDown );
-			this.domElement.addEventListener( 'pointermove', this._onPointerHover );
-			this.domElement.addEventListener( 'pointerup', this._onPointerUp );
+				if ( this.object.parent === null ) {
 
-			this.domElement.style.touchAction = 'none'; // disable touch scroll
+					console.error( 'TransformControls: The attached 3D object must be a part of the scene graph.' );
 
-		}
+				} else {
 
-		disconnect() {
+					this.object.parent.matrixWorld.decompose( this._parentPosition, this._parentQuaternion, this._parentScale );
 
-			this.domElement.removeEventListener( 'pointerdown', this._onPointerDown );
-			this.domElement.removeEventListener( 'pointermove', this._onPointerHover );
-			this.domElement.removeEventListener( 'pointermove', this._onPointerMove );
-			this.domElement.removeEventListener( 'pointerup', this._onPointerUp );
+				}
 
-			this.domElement.style.touchAction = 'auto';
+				this.object.matrixWorld.decompose( this.worldPosition, this.worldQuaternion, this._worldScale );
 
-		}
+				this._parentQuaternionInv.copy( this._parentQuaternion ).invert();
+				this._worldQuaternionInv.copy( this.worldQuaternion ).invert();
+
+			}
+
+			this.camera.updateMatrixWorld();
+			this.camera.matrixWorld.decompose( this.cameraPosition, this.cameraQuaternion, this._cameraScale );
+
+			if ( this.camera.isOrthographicCamera ) {
+
+				this.camera.getWorldDirection( this.eye ).negate();
+
+			} else {
+
+				this.eye.copy( this.cameraPosition ).sub( this.worldPosition ).normalize();
 
-		getHelper() {
+			}
 
-			return this._root;
+			super.updateMatrixWorld( force );
 
 		}
 
@@ -38686,7 +38528,10 @@ void main() {
 
 		dispose() {
 
-			this.disconnect();
+			this.domElement.removeEventListener( 'pointerdown', this._onPointerDown );
+			this.domElement.removeEventListener( 'pointermove', this._onPointerHover );
+			this.domElement.removeEventListener( 'pointermove', this._onPointerMove );
+			this.domElement.removeEventListener( 'pointerup', this._onPointerUp );
 
 			this.traverse( function ( child ) {
 
@@ -38701,7 +38546,7 @@ void main() {
 		attach( object ) {
 
 			this.object = object;
-			this._root.visible = true;
+			this.visible = true;
 
 			return this;
 
@@ -38711,10 +38556,9 @@ void main() {
 		detach() {
 
 			this.object = undefined;
+			this.visible = false;
 			this.axis = null;
 
-			this._root.visible = false;
-
 			return this;
 
 		}
@@ -38907,64 +38751,6 @@ void main() {
 	const _v2 = new Vector3();
 	const _v3 = new Vector3();
 
-	class TransformControlsRoot extends Object3D {
-
-		constructor( controls ) {
-
-			super();
-
-			this.isTransformControlsRoot = true;
-
-			this.controls = controls;
-			this.visible = false;
-
-		}
-
-		// updateMatrixWorld updates key transformation variables
-		updateMatrixWorld( force ) {
-
-			const controls = this.controls;
-
-			if ( controls.object !== undefined ) {
-
-				controls.object.updateMatrixWorld();
-
-				if ( controls.object.parent === null ) {
-
-					console.error( 'TransformControls: The attached 3D object must be a part of the scene graph.' );
-
-				} else {
-
-					controls.object.parent.matrixWorld.decompose( controls._parentPosition, controls._parentQuaternion, controls._parentScale );
-
-				}
-
-				controls.object.matrixWorld.decompose( controls.worldPosition, controls.worldQuaternion, controls._worldScale );
-
-				controls._parentQuaternionInv.copy( controls._parentQuaternion ).invert();
-				controls._worldQuaternionInv.copy( controls.worldQuaternion ).invert();
-
-			}
-
-			controls.camera.updateMatrixWorld();
-			controls.camera.matrixWorld.decompose( controls.cameraPosition, controls.cameraQuaternion, controls._cameraScale );
-
-			if ( controls.camera.isOrthographicCamera ) {
-
-				controls.camera.getWorldDirection( controls.eye ).negate();
-
-			} else {
-
-				controls.eye.copy( controls.cameraPosition ).sub( controls.worldPosition ).normalize();
-
-			}
-
-			super.updateMatrixWorld( force );
-
-		}
-
-	}
-
 	class TransformControlsGizmo extends Object3D {
 
 		constructor() {