@ivanmaxlogiudice/eslint-config 3.0.0-beta.5 → 3.0.0-beta.7

package/dist/index.js

@@ -140,7 +140,14 @@ async function interopDefault(m) {
   return resolved.default || resolved;
 }
 function isInEditorEnv() {
-  return !!((process.env.VSCODE_PID || process.env.VSCODE_CWD || process.env.JETBRAINS_IDE || process.env.VIM || process.env.NVIM) && !process.env.CI);
+  if (process.env.CI)
+    return false;
+  if (isInGitHooksOrLintStaged())
+    return false;
+  return !!(process.env.VSCODE_PID || process.env.VSCODE_CWD || process.env.JETBRAINS_IDE || process.env.VIM || process.env.NVIM);
+}
+function isInGitHooksOrLintStaged() {
+  return !!(process.env.GIT_PARAMS || process.env.VSCODE_GIT_COMMAND || process.env.npm_lifecycle_script?.startsWith("lint-staged"));
 }
 async function spawnAsync(command, args, options) {
   return new Promise((resolve, reject) => {
@@ -466,7 +473,7 @@ function jsdoc() {
 
 // src/configs/jsonc.ts
 import plugin4 from "eslint-plugin-jsonc";
-import parser from "jsonc-eslint-parser";
+import * as parser from "jsonc-eslint-parser";
 function jsonc(options = {}) {
   const {
     files = [GLOB_JSON, GLOB_JSON5, GLOB_JSONC],
@@ -537,12 +544,12 @@ async function markdown(options = {}) {
     overrides = {}
   } = options;
   await ensurePackages(["eslint-plugin-markdown"]);
-  const plugin10 = await interopDefault(import("eslint-plugin-markdown"));
+  const plugin9 = await interopDefault(import("eslint-plugin-markdown"));
   return [
     {
       name: "ivanmaxlogiudice/markdown/setup",
       plugins: {
-        markdown: plugin10
+        markdown: plugin9
       }
     },
     {
@@ -660,15 +667,15 @@ async function regexp(options = {}) {
     overrides = {}
   } = options;
   await ensurePackages(["eslint-plugin-regexp"]);
-  const plugin10 = await interopDefault(import("eslint-plugin-regexp"));
+  const plugin9 = await interopDefault(import("eslint-plugin-regexp"));
   return [
     {
       name: "ivanmaxlogiudice/regexp/rules",
       plugins: {
-        regexp: plugin10
+        regexp: plugin9
       },
       rules: {
-        ...plugin10.configs["flat/recommended"].rules,
+        ...plugin9.configs["flat/recommended"].rules,
         ...overrides
       }
     }
@@ -963,41 +970,93 @@ async function test(options = {}) {
 }
 
 // src/configs/typescript.ts
-import plugin8 from "@typescript-eslint/eslint-plugin";
-import parser2 from "@typescript-eslint/parser";
-function typescript(options = {}) {
+import process2 from "node:process";
+async function typescript(options = {}) {
   const {
     componentExts = [],
     overrides = {},
+    overridesTypeAware = {},
+    parserOptions = {},
     type = "app"
   } = options;
   const files = options.files ?? [GLOB_TS, ...componentExts.map((ext) => `**/*.${ext}`)];
-  return [
-    {
-      name: "ivanmaxlogiudice/typescript/setup",
-      plugins: {
-        ts: plugin8
-      }
-    },
-    {
-      name: "ivanmaxlogiudice/typescript/parser",
-      files,
+  const filesTypeAware = options.filesTypeAware ?? [GLOB_TS];
+  const ignoresTypeAware = options.ignoresTypeAware ?? [`${GLOB_MARKDOWN}/**`];
+  const tsconfigPath = options?.tsconfigPath ? options.tsconfigPath : void 0;
+  const isTypeAware = !!tsconfigPath;
+  const typeAwareRules = {
+    "dot-notation": "off",
+    "no-implied-eval": "off",
+    "ts/await-thenable": "error",
+    "ts/dot-notation": ["error", { allowKeywords: true }],
+    "ts/no-floating-promises": "error",
+    "ts/no-for-in-array": "error",
+    "ts/no-implied-eval": "error",
+    "ts/no-misused-promises": "error",
+    "ts/no-unnecessary-type-assertion": "error",
+    "ts/no-unsafe-argument": "error",
+    "ts/no-unsafe-assignment": "error",
+    "ts/no-unsafe-call": "error",
+    "ts/no-unsafe-member-access": "error",
+    "ts/no-unsafe-return": "error",
+    "ts/promise-function-async": "error",
+    "ts/restrict-plus-operands": "error",
+    "ts/restrict-template-expressions": "error",
+    "ts/return-await": ["error", "in-try-catch"],
+    "ts/strict-boolean-expressions": ["error", { allowNullableBoolean: true, allowNullableObject: true }],
+    "ts/switch-exhaustiveness-check": "error",
+    "ts/unbound-method": "error"
+  };
+  const [plugin9, parser2] = await Promise.all([
+    interopDefault(import("@typescript-eslint/eslint-plugin")),
+    interopDefault(import("@typescript-eslint/parser"))
+  ]);
+  function makeParser(typeAware, files2, ignores2) {
+    return {
+      files: files2,
+      ...ignores2 ? { ignores: ignores2 } : {},
+      name: `ivanmaxlogiudice/typescript/${typeAware ? "type-aware-parser" : "parser"}`,
       languageOptions: {
         parser: parser2,
         parserOptions: {
           extraFileExtensions: componentExts.map((ext) => `.${ext}`),
-          sourceType: "module"
+          sourceType: "module",
+          ...typeAware ? {
+            projectService: {
+              allowDefaultProject: ["./*.js"],
+              defaultProject: tsconfigPath
+            },
+            tsconfigRootDir: process2.cwd()
+          } : {},
+          ...parserOptions
         }
       }
+    };
+  }
+  return [
+    {
+      // Install the plugins without globs, so they can be configured separately.
+      name: "ivanmaxlogiudice/typescript/setup",
+      plugins: {
+        ts: plugin9
+      }
     },
+    // assign type-aware parser for type-aware files and type-unaware parser for the rest
+    ...isTypeAware ? [
+      makeParser(false, files),
+      makeParser(true, filesTypeAware, ignoresTypeAware)
+    ] : [
+      makeParser(false, files)
+    ],
     {
       name: "ivanmaxlogiudice/typescript/rules",
       files,
       rules: {
         // Disable eslint rules which are already handled by TypeScript.
-        ...renameRules(plugin8.configs["eslint-recommended"].overrides[0].rules, "@typescript-eslint", "ts"),
-        ...renameRules(plugin8.configs.strict.rules, "@typescript-eslint", "ts"),
+        ...renameRules(plugin9.configs["eslint-recommended"].overrides[0].rules, "@typescript-eslint", "ts"),
+        ...renameRules(plugin9.configs.strict.rules, "@typescript-eslint", "ts"),
         "no-dupe-class-members": "off",
+        "no-loss-of-precision": "off",
         "no-redeclare": "off",
         "no-use-before-define": "off",
         "no-useless-constructor": "off",
@@ -1035,6 +1094,15 @@ function typescript(options = {}) {
         ...overrides
       }
     },
+    ...isTypeAware ? [{
+      name: "ivanmaxlogiudice/typescript/rules-type-aware",
+      files: filesTypeAware,
+      ignores: ignoresTypeAware,
+      rules: {
+        ...typeAwareRules,
+        ...overridesTypeAware
+      }
+    }] : [],
     {
       name: "ivanmaxlogiudice/typescript/disables/dts",
       files: ["**/*.d.?([cm])ts"],
@@ -1056,20 +1124,21 @@ function typescript(options = {}) {
       name: "ivanmaxlogiudice/typescript/disables/cjs",
       files: ["**/*.js", "**/*.cjs"],
       rules: {
-        "ts/no-require-imports": "off"
+        "ts/no-require-imports": "off",
+        "ts/no-var-requires": "off"
       }
     }
   ];
 }
 
 // src/configs/unicorn.ts
-import plugin9 from "eslint-plugin-unicorn";
+import plugin8 from "eslint-plugin-unicorn";
 function unicorn() {
   return [
     {
       name: "ivanmaxlogiudice/unicorn/rules",
       plugins: {
-        unicorn: plugin9
+        unicorn: plugin8
       },
       rules: {
         // Pass error message when throwing errors
@@ -1111,14 +1180,14 @@ async function unocss(options = {}) {
     strict = false
   } = options;
   await ensurePackages(["@unocss/eslint-plugin"]);
-  const [plugin10] = await Promise.all([
+  const [plugin9] = await Promise.all([
     interopDefault(import("@unocss/eslint-plugin"))
   ]);
   return [
     {
       name: "ivanmaxlogiudice/unocss/rules",
       plugins: {
-        unocss: plugin10
+        unocss: plugin9
       },
       rules: {
         "unocss/order": "warn",
@@ -1137,7 +1206,7 @@ async function vue(options = {}) {
     overrides = {}
   } = options;
   await ensurePackages(["eslint-plugin-vue", "vue-eslint-parser"]);
-  const [plugin10, parser3] = await Promise.all([
+  const [plugin9, parser2] = await Promise.all([
     // @ts-expect-error missing types
     interopDefault(import("eslint-plugin-vue")),
     interopDefault(import("vue-eslint-parser"))
@@ -1146,7 +1215,7 @@ async function vue(options = {}) {
     {
       name: "ivanmaxlogiudice/vue/setup",
       plugins: {
-        vue: plugin10
+        vue: plugin9
       },
       // This allows Vue plugin to work with auto imports
       // https://github.com/vuejs/eslint-plugin-vue/pull/2422
@@ -1173,7 +1242,7 @@ async function vue(options = {}) {
       name: "ivanmaxlogiudice/vue/rules",
       files,
       languageOptions: {
-        parser: parser3,
+        parser: parser2,
         parserOptions: {
           ecmaFeatures: {
             jsx: true
@@ -1183,15 +1252,15 @@ async function vue(options = {}) {
           sourceType: "module"
         }
       },
-      processor: plugin10.processors[".vue"],
+      processor: plugin9.processors[".vue"],
       rules: {
-        ...plugin10.configs.base.rules,
-        ...plugin10.configs["vue3-essential"].rules,
-        ...plugin10.configs["vue3-strongly-recommended"].rules,
-        ...plugin10.configs["vue3-recommended"].rules,
+        ...plugin9.configs.base.rules,
+        ...plugin9.configs["vue3-essential"].rules,
+        ...plugin9.configs["vue3-strongly-recommended"].rules,
+        ...plugin9.configs["vue3-recommended"].rules,
         "node/prefer-global/process": "off",
         "vue/block-order": ["error", {
-          order: ["template", "script", "style"]
+          order: ["script", "template", "style"]
         }],
         "vue/component-name-in-template-casing": ["error", "PascalCase"],
         "vue/component-options-name-casing": ["error", "PascalCase"],
@@ -1277,7 +1346,7 @@ async function yaml(options = {}) {
     overrides = {}
   } = options;
   await ensurePackages(["eslint-plugin-yml", "yaml-eslint-parser"]);
-  const [plugin10, parser3] = await Promise.all([
+  const [plugin9, parser2] = await Promise.all([
     interopDefault(import("eslint-plugin-yml")),
     interopDefault(import("yaml-eslint-parser"))
   ]);
@@ -1285,14 +1354,14 @@ async function yaml(options = {}) {
     {
       name: "ivanmaxlogiudice/yaml/setup",
       plugins: {
-        yaml: plugin10
+        yaml: plugin9
       }
     },
     {
       name: "ivanmaxlogiudice/yaml/rules",
       files,
       languageOptions: {
-        parser: parser3
+        parser: parser2
       },
       rules: {
         // TODO: Check rules (https://github.com/ota-meshi/eslint-plugin-yml)
@@ -1326,12 +1395,18 @@ async function yaml(options = {}) {
 async function config2(options = {}, ...userConfigs) {
   const {
     componentExts = [],
-    isInEditor = isInEditorEnv(),
     regexp: enableRegexp = false,
     typescript: enableTypeScript = isPackageInScope("typescript"),
     unocss: enableUnoCSS = hasSomePackage(["unocss", "@unocss/nuxt"]),
     vue: enableVue = hasSomePackage(["vue", "nuxt", "vitepress", "@slidev/cli"])
   } = options;
+  let isInEditor = options.isInEditor;
+  if (isInEditor == null) {
+    isInEditor = isInEditorEnv();
+    if (isInEditor) {
+      console.log("[@ivanmaxlogiudice/eslint-config] Detected running in editor, some rules are disabled.");
+    }
+  }
   const configs = [
     comments(),
     ignores(),
@@ -1359,6 +1434,7 @@ async function config2(options = {}, ...userConfigs) {
   }
   if (enableTypeScript) {
     configs.push(typescript({
+      ...resolveSubOptions(options, "typescript"),
       componentExts,
       overrides: getOverrides(options, "typescript"),
       type: options.type
@@ -1412,7 +1488,6 @@ function resolveSubOptions(options, key) {
 function getOverrides(options, key) {
   const sub = resolveSubOptions(options, key);
   return {
-    ...options.overrides?.[key],
     ..."overrides" in sub ? sub.overrides : {}
   };
 }
@@ -1446,6 +1521,7 @@ export {
   imports,
   interopDefault,
   isInEditorEnv,
+  isInGitHooksOrLintStaged,
   isPackageInScope,
   javascript,
   jsdoc,

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@ivanmaxlogiudice/eslint-config",
-    "version": "3.0.0-beta.5",
-    "packageManager": "bun@1.1.24",
+    "version": "3.0.0-beta.7",
+    "packageManager": "bun@1.1.26",
     "description": "Personal ESLint config",
     "type": "module",
     "keywords": ["eslint-config"],
@@ -32,7 +32,7 @@
         "dev": "config-inspector --config eslint.config.ts",
         "build": "bun run typegen && tsup --format esm --clean --dts",
         "test": "vitest",
-        "lint": "eslint . --fix",
+        "lint": "eslint --flag unstable_ts_config --fix .",
         "typegen": "bun scripts/typegen.ts",
         "prepack": "bun run build",
         "release": "bumpp && npm publish",
@@ -73,19 +73,19 @@
     },
     "dependencies": {
         "@clack/prompts": "^0.7.0",
-        "@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
+        "@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
         "@ivanmaxlogiudice/gitignore": "^0.0.2",
-        "@stylistic/eslint-plugin": "^2.6.2",
-        "@typescript-eslint/eslint-plugin": "^8.1.0",
-        "@typescript-eslint/parser": "^8.1.0",
-        "@vitest/eslint-plugin": "^1.0.2",
-        "eslint-plugin-antfu": "^2.3.5",
+        "@stylistic/eslint-plugin": "^2.6.4",
+        "@typescript-eslint/eslint-plugin": "^8.2.0",
+        "@typescript-eslint/parser": "^8.2.0",
+        "@vitest/eslint-plugin": "^1.0.3",
+        "eslint-plugin-antfu": "^2.3.6",
         "eslint-plugin-import-x": "^3.1.0",
         "eslint-plugin-jsdoc": "^50.2.2",
         "eslint-plugin-jsonc": "^2.16.0",
         "eslint-plugin-n": "^17.10.2",
-        "eslint-plugin-no-only-tests": "^3.1.0",
-        "eslint-plugin-perfectionist": "^3.1.3",
+        "eslint-plugin-no-only-tests": "^3.3.0",
+        "eslint-plugin-perfectionist": "^3.2.0",
         "eslint-plugin-unicorn": "^55.0.0",
         "eslint-plugin-unused-imports": "^4.1.3",
         "globals": "^15.9.0",
@@ -95,26 +95,33 @@
         "yargs": "^17.7.2"
     },
     "devDependencies": {
-        "@eslint/config-inspector": "^0.5.2",
-        "@stylistic/eslint-plugin-migrate": "^2.6.2",
+        "@eslint/config-inspector": "^0.5.4",
+        "@stylistic/eslint-plugin-migrate": "^2.6.4",
         "@types/eslint": "^9.6.0",
-        "@types/node": "^22.3.0",
+        "@types/node": "^22.5.0",
         "@types/yargs": "^17.0.33",
-        "@unocss/eslint-plugin": "^0.62.1",
-        "bumpp": "^9.5.1",
-        "bun-types": "^1.1.24",
-        "bundle-require": "^5.0.0",
-        "eslint": "^9.9.0",
+        "@unocss/eslint-plugin": "^0.62.3",
+        "bumpp": "^9.5.2",
+        "bun-types": "^1.1.26",
+        "eslint": "^9.9.1",
         "eslint-plugin-markdown": "^5.1.0",
         "eslint-plugin-regexp": "^2.6.0",
         "eslint-plugin-vue": "^9.27.0",
         "eslint-plugin-yml": "^1.14.0",
-        "eslint-typegen": "^0.3.0",
+        "eslint-typegen": "^0.3.1",
+        "lint-staged": "^15.2.9",
+        "simple-git-hooks": "^2.11.1",
         "tsup": "^8.2.4",
         "typescript": "^5.5.4",
         "unbuild": "^2.0.0",
         "vitest": "^2.0.5",
         "vue-eslint-parser": "^9.4.3",
         "yaml-eslint-parser": "^1.2.3"
+    },
+    "simple-git-hooks": {
+        "pre-commit": "bunx lint-staged"
+    },
+    "lint-staged": {
+        "*": "eslint --flag unstable_ts_config --fix"
     }
 }