@itwin/saved-views-react 1.2.4 → 1.2.6

package/lib/LayeredDropdownMenu/LayeredDropdownMenu.d.ts

@@ -7,7 +7,7 @@ interface LayeredDropdownMenuProps {
      */
     menuItems: ReactElement[] | ((close: () => void) => ReactElement[]);
     /** Dropdown menu trigger to pass to iTwinUI `<DropdownMenu />` component. */
-    children: ReactNode;
+    children: React.JSX.Element;
 }
 /**
  * An extended version of iTwinUI `<DropdownMenu />` component with support for layered dropdown menu items.

package/lib/applySavedView.js

@@ -26,9 +26,16 @@ function applyCameraOptions(seedViewStateProps, _iModel, viewport, savedViewData
                 viewDef.angles = YawPitchRollAngles.createFromMatrix3d(cameraProps.rotation)?.toJSON();
                 viewDef.camera = cameraProps.camera;
             }
-            else {
+            else if (!(cameraProps instanceof ViewPose)) {
                 const cameraProps3d = cameraProps;
-                viewDef.cameraOn = cameraProps3d.camera !== undefined;
+                // cameraOn property only exists on ViewDefinitionProps (from viewport),
+                // not on ViewData/ViewITwin3d. For saved view data, infer from camera presence.
+                if (settings.camera === "keep") {
+                    viewDef.cameraOn = cameraProps.cameraOn ?? false;
+                }
+                else {
+                    viewDef.cameraOn = cameraProps3d.camera !== undefined;
+                }
                 viewDef.origin = cameraProps3d.origin;
                 viewDef.extents = cameraProps3d.extents;
                 viewDef.angles = cameraProps3d.angles;
@@ -82,7 +89,7 @@ async function applyViewStateProps(viewStateProps, iModel, viewport, savedViewDa
     });
     viewport.changeView(viewState, settings.viewChangeOptions);
     if (settings.subcategories !== "ignore") {
-        // If subcategories are not ignored, we need to reset them here, 
+        // If subcategories are not ignored, we need to reset them here,
         // otherwise we might end up with subcategories not shown correctly
         const { addCategories, dropCategories } = await sortCategories(iModel, savedViewData.viewData, categories);
         viewport.changeCategoryDisplay(dropCategories, false);

package/lib/captureSavedViewData.js

@@ -138,7 +138,7 @@ function createSheetSavedViewObject(vp, hiddenCategories) {
         },
         width: viewState.sheetSize.x,
         height: viewState.sheetSize.y,
-        sheetAttachments: viewState.attachmentIds,
+        sheetAttachments: [...viewState.attachmentIds],
         viewDetails: extractViewDetails2dFromLegacy(viewDefinitionProps),
     };
 }

package/lib/translation/displayStyleExtractor.d.ts

@@ -4,6 +4,7 @@ import type { DisplayStyle3dSettingsProps, DisplayStyleSettingsProps } from "@it
 import { type ExtractionFunc } from "./extractionUtilities.js";
 export declare const featureAppearanceMappings: ExtractionFunc<void, void>[];
 export declare const featureAppearanceLegacyMappings: ExtractionFunc<void, void>[];
+export declare const realityModelDisplayMappings: ExtractionFunc<void, void>[];
 /**
  * Extracts the display style from a legacy view displayStyle field
  * And transforms it into our schema

package/lib/translation/displayStyleExtractor.js

@@ -133,6 +133,28 @@ const displayStyleModelAppearanceLegacyMappings = [
     ...featureAppearanceLegacyMappings,
     extractString("modelId"),
 ];
+export const realityModelDisplayMappings = [
+    extractObject([
+        extractString("sizeMode"),
+        extractNumber("voxelScale"),
+        extractNumber("minPixelsPerVoxel"),
+        extractNumber("maxPixelsPerVoxel"),
+        extractNumber("pixelSize"),
+        extractString("shape"),
+        extractString("edlMode"),
+        extractNumber("edlStrength"),
+        extractNumber("edlRadius"),
+        extractNumber("edlFilter"),
+        extractNumber("edlMixWts1"),
+        extractNumber("edlMixWts2"),
+        extractNumber("edlMixWts4"),
+    ], "pointCloud"),
+    extractNumber("overrideColorRatio"),
+];
+const displayStyleRealityModelDisplayMappings = [
+    ...realityModelDisplayMappings,
+    extractString("modelId"),
+];
 const contextRealityModelsMappings = [
     extractObject([
         extractString("provider"),
@@ -157,6 +179,7 @@ const contextRealityModelsMappings = [
     ], "classifiers"),
     extractObject(planarClipMaskMappings, "planarClipMask"),
     extractObject(featureAppearanceMappings, "appearanceOverrides"),
+    extractObject(realityModelDisplayMappings, "displaySettings"),
 ];
 const contextRealityModelsLegacyMappings = [
     extractObject([
@@ -182,6 +205,7 @@ const contextRealityModelsLegacyMappings = [
     ], "classifiers"),
     extractObject(planarClipMaskMappings, "planarClipMask"),
     extractObject(featureAppearanceLegacyMappings, "appearanceOverrides"),
+    extractObject(realityModelDisplayMappings, "displaySettings"),
 ];
 const commonMapLayerPropsMapping = [
     extractBoolean("visible"),
@@ -401,6 +425,7 @@ const displayStylesMapping = [
     extractStringOrArray("excludedElements"),
     extractObject(mapImageryMapping, "mapImagery"),
     extractArray(displayStyleModelAppearanceMappings, "modelOverrides", "modelOvr"),
+    extractArray(displayStyleRealityModelDisplayMappings, "realityModelDisplay"),
     extractObject(clipStyleMappings, "clipStyle"),
     extractArray(displayStylePlanarClipMaskMappings, "planarClipOverrides", "planarClipOvr"),
 ];
@@ -417,6 +442,7 @@ const displayStylesLegacyMapping = [
     extractStringOrArray("excludedElements"),
     extractObject(mapImageryLegacyMapping, "mapImagery"),
     extractArray(displayStyleModelAppearanceLegacyMappings, "modelOvr", "modelOverrides"),
+    extractArrayElementsConditionally((value) => value && !value.invisible, displayStyleRealityModelDisplayMappings, "realityModelDisplay"),
     extractObject(clipStyleLegacyMappings, "clipStyle"),
     extractArray(displayStylePlanarClipMaskMappings, "planarClipOvr", "planarClipOverrides"),
 ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@itwin/saved-views-react",
-  "version": "1.2.4",
+  "version": "1.2.6",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -49,7 +49,7 @@
     "react-dom": "^18.0.0",
     "recursive-readdir": "^2.2.3",
     "typescript": "^5.5.4",
-    "vite": "^6.0.0",
+    "vite": "^6.4.1",
     "vitest": "^4.0.16"
   },
   "peerDependencies": {
@@ -66,7 +66,7 @@
     "@itwin/itwinui-icons-react": "^2.9.0",
     "@itwin/itwinui-react": "^3.15.0",
     "fuse.js": "^6.6.2",
-    "@itwin/saved-views-client": "^0.6.2"
+    "@itwin/saved-views-client": "^0.6.4"
   },
   "scripts": {
     "build": "run-p build:*",