@itwin/map-layers-formats 4.1.0-dev.8 → 4.1.0-dev.80

package/lib/test/junit_results.xml

@@ -1,159 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="Mocha Tests" time="0.684" tests="69" failures="0">
-  <testsuite name="Root Suite" timestamp="2023-05-19T05:14:27" tests="0" time="0.000" failures="0">
-  </testsuite>
-  <testsuite name="ArcGisFeaturePBF" timestamp="2023-05-19T05:14:27" tests="2" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureFeatureFormats.test.js" time="0.014" failures="0">
-    <testcase name="ArcGisFeaturePBF should createImageryProvider" time="0.001" classname="should createImageryProvider">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should validateSource" time="0.004" classname="should validateSource">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisFeatureJSON" timestamp="2023-05-19T05:14:27" tests="9" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureJSON.test.js" time="0.034" failures="0">
-    <testcase name="ArcGisFeatureJSON should read FeatureInfo in JSON (phillyTansportation)" time="0.013" classname="should read FeatureInfo in JSON (phillyTansportation)">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should read FeatureInfo in JSON (phillyAirport)" time="0.000" classname="should read FeatureInfo in JSON (phillyAirport)">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should deflate coordinates array" time="0.001" classname="should deflate coordinates array">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender single ring polygon feature" time="0.003" classname="should readAndRender single ring polygon feature">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender multiple ring polygon feature" time="0.002" classname="should readAndRender multiple ring polygon feature">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender simple path" time="0.001" classname="should readAndRender simple path">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender multi path" time="0.001" classname="should readAndRender multi path">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender simple point" time="0.004" classname="should readAndRender simple point">
-    </testcase>
-    <testcase name="ArcGisFeatureJSON should log error when readAndRender /  readFeatureInfo is called invalid response Data" time="0.002" classname="should log error when readAndRender /  readFeatureInfo is called invalid response Data">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisFeaturePBF" timestamp="2023-05-19T05:14:27" tests="10" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeaturePBF.test.js" time="0.044" failures="0">
-    <testcase name="ArcGisFeaturePBF should convert pbf geometry type to Esri types" time="0.001" classname="should convert pbf geometry type to Esri types">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should read FeatureInfo in PBF" time="0.014" classname="should read FeatureInfo in PBF">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should read FeatureInfo from PBF (philly transportation)" time="0.010" classname="should read FeatureInfo from PBF (philly transportation)">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should read all data types from FeatureInfo " time="0.003" classname="should read all data types from FeatureInfo ">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender single ring polygon feature" time="0.002" classname="should readAndRender single ring polygon feature">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender multiple ring polygon feature" time="0.002" classname="should readAndRender multiple ring polygon feature">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender simple path" time="0.001" classname="should readAndRender simple path">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender multi path" time="0.001" classname="should readAndRender multi path">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender simple point" time="0.003" classname="should readAndRender simple point">
-    </testcase>
-    <testcase name="ArcGisFeaturePBF should log error when readAndRender /  readFeatureInfo is called invalid response Data" time="0.002" classname="should log error when readAndRender /  readFeatureInfo is called invalid response Data">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisFeatureProvider" timestamp="2023-05-19T05:14:27" tests="23" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureProvider.test.js" time="0.430" failures="0">
-    <testcase name="ArcGisFeatureProvider should initialize with valid data" time="0.004" classname="should initialize with valid data">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should not initialize with no service metadata" time="0.003" classname="should not initialize with no service metadata">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should update status when invalid token error from service" time="0.002" classname="should update status when invalid token error from service">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should throw    query capability not supported" time="0.002" classname="should throw    query capability not supported">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should pick the first visible sub-layer when multiple visible sub-layers" time="0.004" classname="should pick the first visible sub-layer when multiple visible sub-layers">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should pick sub-layers from service metadata if none provided on layer settings" time="0.002" classname="should pick sub-layers from service metadata if none provided on layer settings">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should throw error if no layers in capabilities" time="0.000" classname="should throw error if no layers in capabilities">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should throw if no layer metadata from service" time="0.001" classname="should throw if no layer metadata from service">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should read supported supported format" time="0.003" classname="should read supported supported format">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should compute minLod/maxLod" time="0.001" classname="should compute minLod/maxLod">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should construct empty url" time="0.000" classname="should construct empty url">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should construct feature query url" time="0.026" classname="should construct feature query url">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should log error when getFeatureInfo cannot be performed" time="0.004" classname="should log error when getFeatureInfo cannot be performed">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should process data in getFeatureInfo" time="0.017" classname="should process data in getFeatureInfo">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should log error when exceed transfert limit" time="0.123" classname="should log error when exceed transfert limit">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should log error when exceed exception thrown limit" time="0.013" classname="should log error when exceed exception thrown limit">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should debug Feature Geom" time="0.027" classname="should debug Feature Geom">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should compute computeTileWorld2CanvasTransform" time="0.003" classname="should compute computeTileWorld2CanvasTransform">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should loadTile from PBF request" time="0.007" classname="should loadTile from PBF request">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should loadTile from JSON request" time="0.005" classname="should loadTile from JSON request">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider should make sub request if loadtile request return &apos;exceedTransferLimit&apos;" time="0.005" classname="should make sub request if loadtile request return &apos;exceedTransferLimit&apos;">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider fetchTile should return undefined when to format defined" time="0.005" classname="fetchTile should return undefined when to format defined">
-    </testcase>
-    <testcase name="ArcGisFeatureProvider fetchTile should call fetch with the proper URL" time="0.003" classname="fetchTile should call fetch with the proper URL">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisFeatureQuery" timestamp="2023-05-19T05:14:28" tests="3" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureQuery.test.js" time="0.047" failures="0">
-    <testcase name="ArcGisFeatureQuery should not apply different switches if not needed" time="0.003" classname="should not apply different switches if not needed">
-    </testcase>
-    <testcase name="ArcGisFeatureQuery should not apply different switches if not needed" time="0.007" classname="should not apply different switches if not needed">
-    </testcase>
-    <testcase name="ArcGisFeatureQuery should not include geometry only when applicable" time="0.003" classname="should not include geometry only when applicable">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisFeatureRenderer" timestamp="2023-05-19T05:14:28" tests="12" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureRenderer.test.js" time="0.084" failures="0">
-    <testcase name="ArcGisFeatureRenderer should render simple path, stride = 2" time="0.001" classname="should render simple path, stride = 2">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render simple filled path" time="0.002" classname="should render simple filled path">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render simple Path, stride = 3" time="0.001" classname="should render simple Path, stride = 3">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render multiple Paths, stride = 2" time="0.001" classname="should render multiple Paths, stride = 2">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should not render invalid with stride value" time="0.000" classname="should not render invalid with stride value">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render Path and apply transform, relativeCoords OFF" time="0.001" classname="should render Path and apply transform, relativeCoords OFF">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render single Point, no transform, relativeCoords OFF" time="0.001" classname="should render single Point, no transform, relativeCoords OFF">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render single Point and apply transform, relativeCoords OFF" time="0.001" classname="should render single Point and apply transform, relativeCoords OFF">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render multi Point, transform, relativeCoords OFF" time="0.001" classname="should render multi Point, transform, relativeCoords OFF">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render multi Point and apply transform, relativeCoords OFF" time="0.002" classname="should render multi Point and apply transform, relativeCoords OFF">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render multi Point and apply transform, relativeCoords ON" time="0.008" classname="should render multi Point and apply transform, relativeCoords ON">
-    </testcase>
-    <testcase name="ArcGisFeatureRenderer should render and apply transform, relativeCoords ON" time="0.000" classname="should render and apply transform, relativeCoords ON">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisFeatureResponse" timestamp="2023-05-19T05:14:28" tests="7" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureResponse.test.js" time="0.019" failures="0">
-    <testcase name="ArcGisFeatureResponse should return undefined if http error" time="0.000" classname="should return undefined if http error">
-    </testcase>
-    <testcase name="ArcGisFeatureResponse should return undefined if invalid PBF data" time="0.000" classname="should return undefined if invalid PBF data">
-    </testcase>
-    <testcase name="ArcGisFeatureResponse should create FeatureCollectionPBuffer from PBF data" time="0.004" classname="should create FeatureCollectionPBuffer from PBF data">
-    </testcase>
-    <testcase name="ArcGisFeatureResponse should report exceededTransferLimit from PBF object" time="0.007" classname="should report exceededTransferLimit from PBF object">
-    </testcase>
-    <testcase name="ArcGisFeatureResponse should return undefined if invalid JSON" time="0.000" classname="should return undefined if invalid JSON">
-    </testcase>
-    <testcase name="ArcGisFeatureResponse should return JSON data" time="0.000" classname="should return JSON data">
-    </testcase>
-    <testcase name="ArcGisFeatureResponse should report exceededTransferLimit from JSON object" time="0.000" classname="should report exceededTransferLimit from JSON object">
-    </testcase>
-  </testsuite>
-  <testsuite name="ArcGisSymbologyRenderer" timestamp="2023-05-19T05:14:28" tests="3" file="D:\vsts_a\7\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisSymbologyRenderer.test.js" time="0.006" failures="0">
-    <testcase name="ArcGisSymbologyRenderer should construct renderer from incomplete drawing info" time="0.003" classname="should construct renderer from incomplete drawing info">
-    </testcase>
-    <testcase name="ArcGisSymbologyRenderer should construct renderer from unique value drawing info" time="0.000" classname="should construct renderer from unique value drawing info">
-    </testcase>
-    <testcase name="ArcGisSymbologyRenderer should construct renderer from point symbology drawing info" time="0.000" classname="should construct renderer from point symbology drawing info">
-    </testcase>
-  </testsuite>
-</testsuites>

package/map-layers-formats.build.log

@@ -1,30 +0,0 @@
-Invoking: betools docs --includes=../../generated-docs/extract --json=../../generated-docs/core/map-layers-formats/file.json --tsIndexFile=./map-layers-formats.ts --onlyJson --excludes=**/ArcGisFeature/*.ts,**/*.gen.ts 
-Running command:
-node D:\vsts_a\7\s\tools\build\scripts\docs.js --json ../../generated-docs/core/map-layers-formats/file.json --includes ../../generated-docs/extract --excludes **/ArcGisFeature/*.ts,**/*.gen.ts --tsIndexFile ./map-layers-formats.ts --onlyJson
-Arguments to TypeDoc: [
-  "--entryPointStrategy",
-  "expand",
-  "D:\\vsts_a\\7\\s\\extensions\\map-layers-formats\\src",
-  "--excludePrivate",
-  "--hideGenerator",
-  "--logLevel",
-  "Error",
-  "--exclude",
-  "**/node_modules/**/*",
-  "--exclude",
-  "**/*test*/**/*",
-  "--exclude",
-  "**/**/ArcGisFeature/*.ts",
-  "--exclude",
-  "**/*.gen.ts/**/*",
-  "--json",
-  "../../generated-docs/core/map-layers-formats/file.json",
-  "--readme",
-  "none",
-  "--plugin",
-  "typedoc-plugin-merge-modules",
-  "--mergeModulesMergeMode",
-  "module",
-  "--includes",
-  "../../generated-docs/extract"
-]

package/src/ArcGisFeature/ArcGisFeatureFormat.ts

@@ -1,16 +0,0 @@
-/*---------------------------------------------------------------------------------------------
-* Copyright (c) Bentley Systems, Incorporated. All rights reserved.
-* See LICENSE.md in the project root for license terms and full copyright notice.
-*--------------------------------------------------------------------------------------------*/
-import { ImageMapLayerSettings } from "@itwin/core-common";
-import { ArcGisUtilities, ImageryMapLayerFormat, MapLayerImageryProvider, MapLayerSourceValidation } from "@itwin/core-frontend";
-import { ArcGisFeatureProvider } from "./ArcGisFeatureProvider";
-
-/** @internal */
-export class ArcGisFeatureMapLayerFormat extends ImageryMapLayerFormat {
-  public static override formatId = "ArcGISFeature";
-  public static override createImageryProvider(settings: ImageMapLayerSettings): MapLayerImageryProvider | undefined { return new ArcGisFeatureProvider(settings); }
-  public static override async validateSource(url: string, userName?: string, password?: string, ignoreCache?: boolean): Promise<MapLayerSourceValidation> {
-    return ArcGisUtilities.validateSource(url, this.formatId, ["query"], userName, password, ignoreCache);
-  }
-}

package/src/ArcGisFeature/ArcGisFeatureJSON.ts

@@ -1,155 +0,0 @@
-/*---------------------------------------------------------------------------------------------
-* Copyright (c) Bentley Systems, Incorporated. All rights reserved.
-* See LICENSE.md in the project root for license terms and full copyright notice.
-*--------------------------------------------------------------------------------------------*/
-
-import { PrimitiveValue, PropertyValueFormat, StandardTypeNames } from "@itwin/appui-abstract";
-import { ImageMapLayerSettings } from "@itwin/core-common";
-import { MapFeatureInfoRecord, MapLayerFeatureInfo, MapSubLayerFeatureInfo } from "@itwin/core-frontend";
-import { Transform } from "@itwin/core-geometry";
-import { ArcGisFeatureReader } from "./ArcGisFeatureReader";
-import { ArcGisFeatureRenderer } from "./ArcGisFeatureRenderer";
-import { ArcGisFieldType, ArcGisResponseData } from "./ArcGisFeatureResponse";
-
-/** @internal */
-export class ArcGisFeatureJSON  extends ArcGisFeatureReader {
-  public transform: Transform|undefined;
-
-  public constructor(settings: ImageMapLayerSettings, layerMetadata: any) {
-    super(settings, layerMetadata);
-  }
-
-  public readAndRender(response: ArcGisResponseData, renderer: ArcGisFeatureRenderer) {
-    const responseObj = response.data;
-
-    if (responseObj?.geometryType === "esriGeometryPolyline" || responseObj?.geometryType === "esriGeometryPolygon") {
-      const fill = (responseObj.geometryType === "esriGeometryPolygon");
-      for (const feature of responseObj.features) {
-        let offset = 0;
-        const lengths: number[] = [];
-        const coords: number[] = [];
-
-        if (feature?.geometry?.rings) {
-          for (const ring of feature?.geometry?.rings) {
-            offset = ArcGisFeatureJSON.deflateCoordinates(ring, coords, 2, offset);
-            lengths.push(ring.length);
-          }
-        } else if (feature?.geometry?.paths) {
-          for (const path of feature?.geometry?.paths) {
-            offset = ArcGisFeatureJSON.deflateCoordinates(path, coords, 2, offset);
-            lengths.push(path.length);
-          }
-        }
-        renderer.renderPath(lengths, coords, fill, 2, renderer.transform === undefined);
-
-      }
-    } else if (responseObj?.geometryType === "esriGeometryPoint" || responseObj?.geometryType === "esriGeometryMultiPoint") {
-      for (const feature of responseObj.features) {
-        // TODO: Add support for multipoint
-        if (feature.geometry) {
-          const lengths: number[] = [];
-          const coords: number[] = [feature.geometry.x, feature.geometry.y];
-          renderer.renderPoint(lengths, coords, 2, renderer.transform === undefined);
-        }
-      }
-    }
-  }
-
-  // Converts an [[x1,y1], [x2,y2], ...] to [x1,y1,x2,y2, ...]
-  // stride is the number of dimensions
-  // https://github.com/openlayers/openlayers/blob/7a2f87caca9ddc1912d910f56eb5637445fc11f6/src/ol/geom/flat/deflate.js#L26
-  protected static deflateCoordinates( coordinates: number[][], flatCoordinates: number[], stride: number, offset: number) {
-    for (let i = 0, ii = coordinates.length; i < ii; ++i) {
-      const coordinate = coordinates[i];
-      for (let j = 0; j < stride; ++j)
-        flatCoordinates[offset++] = coordinate[j];
-    }
-
-    return offset;
-  }
-
-  public readFeatureInfo(response: ArcGisResponseData, featureInfos: MapLayerFeatureInfo[]) {
-    const responseObj = response.data;
-    if (responseObj === undefined || !Array.isArray(responseObj.features))
-      return;
-
-    const layerInfo: MapLayerFeatureInfo = {layerName: this._settings.name};
-
-    // Create a signature index for every field name / type.
-    const fieldsType: {[key: string]: ArcGisFieldType} = {};
-    for (const fieldInfo of responseObj.fields) {
-      fieldsType[fieldInfo.name] = fieldInfo.type;
-    }
-
-    const getStandardTypeName = (fieldType: ArcGisFieldType) => {
-      switch (fieldType) {
-        case "esriFieldTypeInteger":
-        case "esriFieldTypeSmallInteger":
-        case "esriFieldTypeOID":
-          return StandardTypeNames.Integer;
-        case "esriFieldTypeDouble":
-          return StandardTypeNames.Double;
-        case "esriFieldTypeSingle":
-          return StandardTypeNames.Float;
-        case "esriFieldTypeDate":
-          return StandardTypeNames.DateTime;
-        default:
-          return StandardTypeNames.String;
-      }
-    };
-
-    const getRecordInfo = (fieldName: string, value: any) => {
-      const propertyValue: PrimitiveValue = {valueFormat: PropertyValueFormat.Primitive};
-
-      if (value === null) {
-        value = undefined;
-      }
-
-      const strValue = `${value}`;
-      const fieldType = fieldsType[fieldName];
-      switch (fieldType) {
-        case "esriFieldTypeInteger":
-        case "esriFieldTypeSmallInteger":
-        case "esriFieldTypeOID":
-          propertyValue.value = value as number;
-          break;
-        case "esriFieldTypeDouble":
-        case "esriFieldTypeSingle":
-          propertyValue.value = this.toFixedWithoutPadding(value);
-          break;
-        case "esriFieldTypeDate":
-          propertyValue.value = new Date(value);
-          break;
-        default:
-          if (value !== undefined)
-            propertyValue.value = strValue;
-
-          break;
-      }
-
-      const typename = getStandardTypeName(fieldType);
-      propertyValue.displayValue = this.getDisplayValue(typename, propertyValue.value);
-
-      return new MapFeatureInfoRecord (propertyValue, {name: fieldName, displayLabel: fieldName,  typename});
-    };
-
-    for (const feature of responseObj.features) {
-      const subLayerInfo: MapSubLayerFeatureInfo = {
-        subLayerName: this._layerMetadata.name,
-        displayFieldName: this._layerMetadata.name,
-        records : [],
-      };
-
-      for (const [key, value] of Object.entries(feature.attributes))
-        subLayerInfo.records?.push(getRecordInfo(key,value));
-
-      if (layerInfo.info === undefined)
-        layerInfo.info = [];
-
-      if (!(layerInfo.info instanceof HTMLElement))
-        layerInfo.info.push(subLayerInfo);
-    }
-
-    featureInfos.push(layerInfo);
-  }
-}

package/src/ArcGisFeature/ArcGisFeaturePBF.ts

@@ -1,215 +0,0 @@
-/*---------------------------------------------------------------------------------------------
-* Copyright (c) Bentley Systems, Incorporated. All rights reserved.
-* See LICENSE.md in the project root for license terms and full copyright notice.
-*--------------------------------------------------------------------------------------------*/
-
-import { ArcGisFeatureRenderer } from "./ArcGisFeatureRenderer";
-import { esriPBuffer } from "../ArcGisFeature/esriPBuffer.gen";
-import { MapFeatureInfoRecord, MapLayerFeatureInfo, MapSubLayerFeatureInfo } from "@itwin/core-frontend";
-import { PrimitiveValue, PropertyValueFormat, StandardTypeNames } from "@itwin/appui-abstract";
-import { ImageMapLayerSettings } from "@itwin/core-common";
-import { ArcGisFeatureReader } from "./ArcGisFeatureReader";
-import { ArcGisResponseData } from "./ArcGisFeatureResponse";
-import { Logger } from "@itwin/core-bentley";
-import { ArcGisFeatureGeometryType } from "./ArcGisFeatureQuery";
-
-const esriGeometryType = esriPBuffer.FeatureCollectionPBuffer.GeometryType;
-const loggerCategory =  "MapLayersFormats.ArcGISFeature";
-
-interface PbfFieldInfo {
-  name: string;
-  type: esriPBuffer.FeatureCollectionPBuffer.FieldType;
-}
-
-/** @internal */
-export class ArcGisFeaturePBF extends ArcGisFeatureReader {
-  public constructor(settings: ImageMapLayerSettings, layerMetadata: any) {
-    super(settings, layerMetadata);
-  }
-
-  public static getArcGisFeatureGeometryType(geomType: esriPBuffer.FeatureCollectionPBuffer.GeometryType): ArcGisFeatureGeometryType  {
-    switch (geomType) {
-      case esriPBuffer.FeatureCollectionPBuffer.GeometryType.esriGeometryTypeMultipatch:
-        return "esriGeometryMultiPatch";
-      case esriPBuffer.FeatureCollectionPBuffer.GeometryType.esriGeometryTypeMultipoint:
-        return "esriGeometryMultipoint";
-      case esriPBuffer.FeatureCollectionPBuffer.GeometryType.esriGeometryTypePoint:
-        return "esriGeometryPoint";
-      case esriPBuffer.FeatureCollectionPBuffer.GeometryType.esriGeometryTypePolygon:
-        return "esriGeometryPolygon";
-      case esriPBuffer.FeatureCollectionPBuffer.GeometryType.esriGeometryTypePolyline:
-        return "esriGeometryPolyline";
-      default:
-        return "esriGeometryNull";
-    }
-  }
-
-  public readAndRender(response: ArcGisResponseData, renderer: ArcGisFeatureRenderer) {
-    if (!(response.data instanceof esriPBuffer.FeatureCollectionPBuffer)) {
-      const msg = "Response was not in PBF format";
-      Logger.logError(loggerCategory, msg);
-      return;
-    }
-
-    const collection = response.data;
-    if (!collection.has_queryResult || !collection.queryResult.has_featureResult || collection?.queryResult?.featureResult?.features === undefined)
-      return;
-
-    const geomType = collection.queryResult.featureResult.geometryType;
-    const stride = (collection.queryResult.featureResult.hasM || collection.queryResult.featureResult.hasZ) ? 3 : 2;
-
-    // console.log(`Nb Feature: ${collection.queryResult.featureResult.features.length}`);
-    if (geomType === esriGeometryType.esriGeometryTypePoint ||
-      geomType === esriGeometryType.esriGeometryTypeMultipoint) {
-      for (const feature of collection.queryResult.featureResult.features)
-        renderer.renderPoint(feature.geometry.lengths, feature.geometry.coords, stride, renderer.transform === undefined);
-    } else if (geomType === esriGeometryType.esriGeometryTypePolyline || geomType === esriGeometryType.esriGeometryTypePolygon) {
-      const fill = (geomType === esriGeometryType.esriGeometryTypePolygon);
-      for (const feature of collection.queryResult.featureResult.features)
-        if (feature?.has_geometry)
-          renderer.renderPath(feature.geometry.lengths, feature.geometry.coords, fill, stride, renderer.transform === undefined);
-    }
-  }
-
-  public readFeatureInfo(response: ArcGisResponseData, featureInfos: MapLayerFeatureInfo[]) {
-    if (!(response.data instanceof esriPBuffer.FeatureCollectionPBuffer)) {
-
-      Logger.logError(loggerCategory, "Response was not in PBF format");
-    }
-
-    const collection = response.data as esriPBuffer.FeatureCollectionPBuffer;
-    if (!collection.has_queryResult || !collection.queryResult.has_featureResult || collection?.queryResult?.featureResult?.features === undefined)
-      return;
-
-    const layerInfo: MapLayerFeatureInfo = { layerName: this._settings.name, info: [] };
-
-    // Fields metadata is stored outside feature results, create dedicated array first
-    const fields: PbfFieldInfo[] = [];
-    for (const field of collection.queryResult.featureResult.fields)
-      fields.push({name: field.name, type:field.fieldType});
-
-    const getNumericValue = (attrValue: esriPBuffer.FeatureCollectionPBuffer.Value) => {
-      const propertyValue: PrimitiveValue = { valueFormat: PropertyValueFormat.Primitive };
-      let typename = StandardTypeNames.Number;
-      if (attrValue.has_double_value) {
-        const value = this.toFixedWithoutPadding(attrValue.double_value);
-        propertyValue.value = value;
-        typename = StandardTypeNames.Double;
-      } else if (attrValue.has_float_value) {
-        const value = this.toFixedWithoutPadding(attrValue.float_value);
-        propertyValue.value = value;
-        typename = StandardTypeNames.Float;
-      } else if (attrValue.has_int64_value) {
-        propertyValue.value = attrValue.int64_value;
-        typename = StandardTypeNames.Integer;
-      } else if (attrValue.has_sint64_value) {
-        propertyValue.value = attrValue.sint64_value;
-        typename = StandardTypeNames.Integer;
-      } else if (attrValue.has_sint_value) {
-        propertyValue.value = attrValue.sint_value;
-        typename = StandardTypeNames.Integer;
-      } else if (attrValue.has_uint64_value) {
-        propertyValue.value = attrValue.uint64_value;
-        typename = StandardTypeNames.Integer;
-      } else if (attrValue.has_uint_value) {
-        propertyValue.value = attrValue.uint_value;
-        typename = StandardTypeNames.Integer;
-      } else {
-        propertyValue.value = undefined;
-      }
-
-      return { propertyValue,  typename };
-    };
-
-    const getRecordInfo = (fieldInfo: PbfFieldInfo, attrValue: esriPBuffer.FeatureCollectionPBuffer.Value) => {
-      let propertyValue: PrimitiveValue = { valueFormat: PropertyValueFormat.Primitive };
-
-      let typename = StandardTypeNames.String;
-      if (fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeDouble
-        || fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeInteger
-        || fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeSmallInteger
-        || fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeOID
-        || fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeSingle
-        || fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeDate
-      ) {
-        const value = getNumericValue(attrValue);
-        if (value.propertyValue === undefined) {
-          Logger.logError(loggerCategory, `Could not read numeric value for field ${fieldInfo.name}`);
-          return undefined;
-        }
-
-        if (fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeDate) {
-          const test = (value.propertyValue.value as unknown) as number;
-          propertyValue.value = new Date(test);
-          typename = StandardTypeNames.DateTime;
-        } else {
-          typename = value.typename;
-          propertyValue = value.propertyValue;
-        }
-      } else if (fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeString) {
-        if (attrValue.has_string_value) {
-          propertyValue.value = attrValue.string_value;
-          typename = StandardTypeNames.String;
-        }
-      } else if (fieldInfo.type === esriPBuffer.FeatureCollectionPBuffer.FieldType.esriFieldTypeGlobalID) {
-        if (attrValue.has_string_value) {
-          propertyValue.value = attrValue.string_value;
-          typename = StandardTypeNames.String;
-        } else {
-          const value = getNumericValue(attrValue);
-          if (value.propertyValue === undefined) {
-            Logger.logError(loggerCategory, `Could not read GlobalId value for field ${fieldInfo.name}`);
-            return undefined;
-          }
-        }
-      } else if (attrValue.has_string_value) {
-        // If we reach this case that probably mean we don't support the field type, simply try to output string value
-        typename = StandardTypeNames.String;
-        propertyValue.value = attrValue.string_value;
-      } else if (attrValue.value_type === "none") {
-        // Sometimes fields are just empty, use an empty string
-        typename = StandardTypeNames.String;
-        propertyValue.value = undefined;
-      } else {
-        Logger.logError(loggerCategory, `Could not read value for field ${fieldInfo.name}`);
-        return undefined;
-      }
-
-      propertyValue.displayValue = this.getDisplayValue(typename, propertyValue.value);
-
-      return new MapFeatureInfoRecord(propertyValue, { name: fieldInfo.name, displayLabel: fieldInfo.name, typename });
-    };
-
-    // Read feature values
-    for (const feature of collection.queryResult.featureResult.features) {
-      const subLayerInfo: MapSubLayerFeatureInfo = {
-        subLayerName: this._layerMetadata.name,
-        displayFieldName: this._layerMetadata.name,
-        records: [],
-      };
-      let i = 0;
-
-      for (const attrValue of feature.attributes) {
-        if (i > fields.length) {
-          Logger.logError(loggerCategory, "Error while read feature info data: fields metadata missing");
-          break;
-        }
-        // Convert everything to string for now
-        const info = getRecordInfo(fields[i], attrValue);
-        if (info) {
-          subLayerInfo.records?.push(info);
-        }
-
-        i++;
-      }
-      if (layerInfo.info === undefined) {
-        layerInfo.info = [];
-      }
-      if (!(layerInfo.info instanceof HTMLElement)) {
-        layerInfo.info.push(subLayerInfo);
-      }
-    }
-
-    featureInfos.push(layerInfo);
-  }
-}