@itwin/map-layers-formats 3.5.0-dev.51 → 3.5.0-dev.53

package/lib/test/junit_results.xml

@@ -1,14 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="Mocha Tests" time="0.410" tests="70" failures="0">
-  <testsuite name="Root Suite" timestamp="2022-11-17T05:15:48" tests="0" time="0.000" failures="0">
+<testsuites name="Mocha Tests" time="0.467" tests="69" failures="0">
+  <testsuite name="Root Suite" timestamp="2022-11-19T05:15:33" tests="0" time="0.000" failures="0">
   </testsuite>
-  <testsuite name="ArcGisFeaturePBF" timestamp="2022-11-17T05:15:48" tests="2" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureFeatureFormats.test.js" time="0.016" failures="0">
+  <testsuite name="ArcGisFeaturePBF" timestamp="2022-11-19T05:15:33" tests="2" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureFeatureFormats.test.js" time="0.016" failures="0">
     <testcase name="ArcGisFeaturePBF should createImageryProvider" time="0.002" classname="should createImageryProvider">
     </testcase>
-    <testcase name="ArcGisFeaturePBF should validateSource" time="0.004" classname="should validateSource">
+    <testcase name="ArcGisFeaturePBF should validateSource" time="0.003" classname="should validateSource">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisFeatureJSON" timestamp="2022-11-17T05:15:48" tests="9" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureJSON.test.js" time="0.028" failures="0">
+  <testsuite name="ArcGisFeatureJSON" timestamp="2022-11-19T05:15:33" tests="9" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureJSON.test.js" time="0.029" failures="0">
     <testcase name="ArcGisFeatureJSON should read FeatureInfo in JSON (phillyTansportation)" time="0.004" classname="should read FeatureInfo in JSON (phillyTansportation)">
     </testcase>
     <testcase name="ArcGisFeatureJSON should read FeatureInfo in JSON (phillyAirport)" time="0.001" classname="should read FeatureInfo in JSON (phillyAirport)">
@@ -17,31 +17,31 @@
     </testcase>
     <testcase name="ArcGisFeatureJSON should readAndRender single ring polygon feature" time="0.004" classname="should readAndRender single ring polygon feature">
     </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender multiple ring polygon feature" time="0.001" classname="should readAndRender multiple ring polygon feature">
+    <testcase name="ArcGisFeatureJSON should readAndRender multiple ring polygon feature" time="0.002" classname="should readAndRender multiple ring polygon feature">
     </testcase>
     <testcase name="ArcGisFeatureJSON should readAndRender simple path" time="0.001" classname="should readAndRender simple path">
     </testcase>
     <testcase name="ArcGisFeatureJSON should readAndRender multi path" time="0.001" classname="should readAndRender multi path">
     </testcase>
-    <testcase name="ArcGisFeatureJSON should readAndRender simple point" time="0.005" classname="should readAndRender simple point">
+    <testcase name="ArcGisFeatureJSON should readAndRender simple point" time="0.004" classname="should readAndRender simple point">
     </testcase>
-    <testcase name="ArcGisFeatureJSON should log error when readAndRender /  readFeatureInfo is called invalid response Data" time="0.002" classname="should log error when readAndRender /  readFeatureInfo is called invalid response Data">
+    <testcase name="ArcGisFeatureJSON should log error when readAndRender /  readFeatureInfo is called invalid response Data" time="0.003" classname="should log error when readAndRender /  readFeatureInfo is called invalid response Data">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisFeaturePBF" timestamp="2022-11-17T05:15:48" tests="10" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeaturePBF.test.js" time="0.045" failures="0">
+  <testsuite name="ArcGisFeaturePBF" timestamp="2022-11-19T05:15:33" tests="10" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeaturePBF.test.js" time="0.046" failures="0">
     <testcase name="ArcGisFeaturePBF should convert pbf geometry type to Esri types" time="0.001" classname="should convert pbf geometry type to Esri types">
     </testcase>
     <testcase name="ArcGisFeaturePBF should read FeatureInfo in PBF" time="0.013" classname="should read FeatureInfo in PBF">
     </testcase>
-    <testcase name="ArcGisFeaturePBF should read FeatureInfo from PBF (philly transportation)" time="0.010" classname="should read FeatureInfo from PBF (philly transportation)">
+    <testcase name="ArcGisFeaturePBF should read FeatureInfo from PBF (philly transportation)" time="0.011" classname="should read FeatureInfo from PBF (philly transportation)">
     </testcase>
-    <testcase name="ArcGisFeaturePBF should read all data types from FeatureInfo " time="0.003" classname="should read all data types from FeatureInfo ">
+    <testcase name="ArcGisFeaturePBF should read all data types from FeatureInfo " time="0.004" classname="should read all data types from FeatureInfo ">
     </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender single ring polygon feature" time="0.002" classname="should readAndRender single ring polygon feature">
+    <testcase name="ArcGisFeaturePBF should readAndRender single ring polygon feature" time="0.003" classname="should readAndRender single ring polygon feature">
     </testcase>
     <testcase name="ArcGisFeaturePBF should readAndRender multiple ring polygon feature" time="0.002" classname="should readAndRender multiple ring polygon feature">
     </testcase>
-    <testcase name="ArcGisFeaturePBF should readAndRender simple path" time="0.002" classname="should readAndRender simple path">
+    <testcase name="ArcGisFeaturePBF should readAndRender simple path" time="0.001" classname="should readAndRender simple path">
     </testcase>
     <testcase name="ArcGisFeaturePBF should readAndRender multi path" time="0.001" classname="should readAndRender multi path">
     </testcase>
@@ -50,8 +50,8 @@
     <testcase name="ArcGisFeaturePBF should log error when readAndRender /  readFeatureInfo is called invalid response Data" time="0.002" classname="should log error when readAndRender /  readFeatureInfo is called invalid response Data">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisFeatureProvider" timestamp="2022-11-17T05:15:48" tests="23" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureProvider.test.js" time="0.255" failures="0">
-    <testcase name="ArcGisFeatureProvider should initialize with valid data" time="0.008" classname="should initialize with valid data">
+  <testsuite name="ArcGisFeatureProvider" timestamp="2022-11-19T05:15:33" tests="23" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureProvider.test.js" time="0.295" failures="0">
+    <testcase name="ArcGisFeatureProvider should initialize with valid data" time="0.005" classname="should initialize with valid data">
     </testcase>
     <testcase name="ArcGisFeatureProvider should not initialize with no service metadata" time="0.003" classname="should not initialize with no service metadata">
     </testcase>
@@ -61,35 +61,35 @@
     </testcase>
     <testcase name="ArcGisFeatureProvider should pick the first visible sub-layer when multiple visible sub-layers" time="0.003" classname="should pick the first visible sub-layer when multiple visible sub-layers">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should pick sub-layers from service metadata if none provided on layer settings" time="0.002" classname="should pick sub-layers from service metadata if none provided on layer settings">
+    <testcase name="ArcGisFeatureProvider should pick sub-layers from service metadata if none provided on layer settings" time="0.003" classname="should pick sub-layers from service metadata if none provided on layer settings">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should throw error if no layers in capabilities" time="0.000" classname="should throw error if no layers in capabilities">
+    <testcase name="ArcGisFeatureProvider should throw error if no layers in capabilities" time="0.001" classname="should throw error if no layers in capabilities">
     </testcase>
     <testcase name="ArcGisFeatureProvider should throw if no layer metadata from service" time="0.002" classname="should throw if no layer metadata from service">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should read supported supported format" time="0.003" classname="should read supported supported format">
+    <testcase name="ArcGisFeatureProvider should read supported supported format" time="0.004" classname="should read supported supported format">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should compute minLod/maxLod" time="0.001" classname="should compute minLod/maxLod">
+    <testcase name="ArcGisFeatureProvider should compute minLod/maxLod" time="0.003" classname="should compute minLod/maxLod">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should construct empty url" time="0.000" classname="should construct empty url">
+    <testcase name="ArcGisFeatureProvider should construct empty url" time="0.001" classname="should construct empty url">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should construct feature query url" time="0.007" classname="should construct feature query url">
+    <testcase name="ArcGisFeatureProvider should construct feature query url" time="0.029" classname="should construct feature query url">
     </testcase>
     <testcase name="ArcGisFeatureProvider should log error when getFeatureInfo cannot be performed" time="0.003" classname="should log error when getFeatureInfo cannot be performed">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should process data in getFeatureInfo" time="0.014" classname="should process data in getFeatureInfo">
+    <testcase name="ArcGisFeatureProvider should process data in getFeatureInfo" time="0.020" classname="should process data in getFeatureInfo">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should log error when exceed transfert limit" time="0.125" classname="should log error when exceed transfert limit">
+    <testcase name="ArcGisFeatureProvider should log error when exceed transfert limit" time="0.127" classname="should log error when exceed transfert limit">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should log error when exceed exception thrown limit" time="0.010" classname="should log error when exceed exception thrown limit">
+    <testcase name="ArcGisFeatureProvider should log error when exceed exception thrown limit" time="0.013" classname="should log error when exceed exception thrown limit">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should debug Feature Geom" time="0.025" classname="should debug Feature Geom">
+    <testcase name="ArcGisFeatureProvider should debug Feature Geom" time="0.035" classname="should debug Feature Geom">
     </testcase>
     <testcase name="ArcGisFeatureProvider should compute computeTileWorld2CanvasTransform" time="0.003" classname="should compute computeTileWorld2CanvasTransform">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should loadTile from PBF request" time="0.008" classname="should loadTile from PBF request">
+    <testcase name="ArcGisFeatureProvider should loadTile from PBF request" time="0.007" classname="should loadTile from PBF request">
     </testcase>
-    <testcase name="ArcGisFeatureProvider should loadTile from JSON request" time="0.005" classname="should loadTile from JSON request">
+    <testcase name="ArcGisFeatureProvider should loadTile from JSON request" time="0.004" classname="should loadTile from JSON request">
     </testcase>
     <testcase name="ArcGisFeatureProvider should make sub request if loadtile request return &apos;exceedTransferLimit&apos;" time="0.005" classname="should make sub request if loadtile request return &apos;exceedTransferLimit&apos;">
     </testcase>
@@ -98,18 +98,16 @@
     <testcase name="ArcGisFeatureProvider fetchTile should call fetch with the proper URL" time="0.002" classname="fetchTile should call fetch with the proper URL">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisFeatureQuery" timestamp="2022-11-17T05:15:48" tests="4" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureQuery.test.js" time="0.008" failures="0">
-    <testcase name="ArcGisFeatureQuery should not apply different switches if not needed" time="0.002" classname="should not apply different switches if not needed">
+  <testsuite name="ArcGisFeatureQuery" timestamp="2022-11-19T05:15:33" tests="3" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureQuery.test.js" time="0.015" failures="0">
+    <testcase name="ArcGisFeatureQuery should not apply different switches if not needed" time="0.004" classname="should not apply different switches if not needed">
     </testcase>
-    <testcase name="ArcGisFeatureQuery should not apply different switches if not needed" time="0.001" classname="should not apply different switches if not needed">
+    <testcase name="ArcGisFeatureQuery should not apply different switches if not needed" time="0.007" classname="should not apply different switches if not needed">
     </testcase>
-    <testcase name="ArcGisFeatureQuery should not include geometry only when applicable" time="0.002" classname="should not include geometry only when applicable">
-    </testcase>
-    <testcase name="ArcGisFeatureQuery should not include empty param" time="0.001" classname="should not include empty param">
+    <testcase name="ArcGisFeatureQuery should not include geometry only when applicable" time="0.003" classname="should not include geometry only when applicable">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisFeatureRenderer" timestamp="2022-11-17T05:15:48" tests="12" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureRenderer.test.js" time="0.037" failures="0">
-    <testcase name="ArcGisFeatureRenderer should render simple path, stride = 2" time="0.002" classname="should render simple path, stride = 2">
+  <testsuite name="ArcGisFeatureRenderer" timestamp="2022-11-19T05:15:33" tests="12" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureRenderer.test.js" time="0.041" failures="0">
+    <testcase name="ArcGisFeatureRenderer should render simple path, stride = 2" time="0.001" classname="should render simple path, stride = 2">
     </testcase>
     <testcase name="ArcGisFeatureRenderer should render simple filled path" time="0.001" classname="should render simple filled path">
     </testcase>
@@ -131,31 +129,31 @@
     </testcase>
     <testcase name="ArcGisFeatureRenderer should render multi Point and apply transform, relativeCoords ON" time="0.002" classname="should render multi Point and apply transform, relativeCoords ON">
     </testcase>
-    <testcase name="ArcGisFeatureRenderer should render and apply transform, relativeCoords ON" time="0.001" classname="should render and apply transform, relativeCoords ON">
+    <testcase name="ArcGisFeatureRenderer should render and apply transform, relativeCoords ON" time="0.002" classname="should render and apply transform, relativeCoords ON">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisFeatureResponse" timestamp="2022-11-17T05:15:48" tests="7" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureResponse.test.js" time="0.014" failures="0">
+  <testsuite name="ArcGisFeatureResponse" timestamp="2022-11-19T05:15:33" tests="7" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisFeatureResponse.test.js" time="0.014" failures="0">
     <testcase name="ArcGisFeatureResponse should return undefined if http error" time="0.000" classname="should return undefined if http error">
     </testcase>
-    <testcase name="ArcGisFeatureResponse should return undefined if invalid PBF data" time="0.001" classname="should return undefined if invalid PBF data">
+    <testcase name="ArcGisFeatureResponse should return undefined if invalid PBF data" time="0.000" classname="should return undefined if invalid PBF data">
     </testcase>
-    <testcase name="ArcGisFeatureResponse should create FeatureCollectionPBuffer from PBF data" time="0.004" classname="should create FeatureCollectionPBuffer from PBF data">
+    <testcase name="ArcGisFeatureResponse should create FeatureCollectionPBuffer from PBF data" time="0.005" classname="should create FeatureCollectionPBuffer from PBF data">
     </testcase>
     <testcase name="ArcGisFeatureResponse should report exceededTransferLimit from PBF object" time="0.005" classname="should report exceededTransferLimit from PBF object">
     </testcase>
-    <testcase name="ArcGisFeatureResponse should return undefined if invalid JSON" time="0.000" classname="should return undefined if invalid JSON">
+    <testcase name="ArcGisFeatureResponse should return undefined if invalid JSON" time="0.001" classname="should return undefined if invalid JSON">
     </testcase>
-    <testcase name="ArcGisFeatureResponse should return JSON data" time="0.001" classname="should return JSON data">
+    <testcase name="ArcGisFeatureResponse should return JSON data" time="0.000" classname="should return JSON data">
     </testcase>
     <testcase name="ArcGisFeatureResponse should report exceededTransferLimit from JSON object" time="0.000" classname="should report exceededTransferLimit from JSON object">
     </testcase>
   </testsuite>
-  <testsuite name="ArcGisSymbologyRenderer" timestamp="2022-11-17T05:15:48" tests="3" file="D:\vsts_b\15\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisSymbologyRenderer.test.js" time="0.004" failures="0">
-    <testcase name="ArcGisSymbologyRenderer should construct renderer from incomplete drawing info" time="0.001" classname="should construct renderer from incomplete drawing info">
+  <testsuite name="ArcGisSymbologyRenderer" timestamp="2022-11-19T05:15:33" tests="3" file="D:\vsts_a\3\s\extensions\map-layers-formats\lib\cjs\test\ArcGisFeature\ArcGisSymbologyRenderer.test.js" time="0.006" failures="0">
+    <testcase name="ArcGisSymbologyRenderer should construct renderer from incomplete drawing info" time="0.002" classname="should construct renderer from incomplete drawing info">
     </testcase>
-    <testcase name="ArcGisSymbologyRenderer should construct renderer from unique value drawing info" time="0.001" classname="should construct renderer from unique value drawing info">
+    <testcase name="ArcGisSymbologyRenderer should construct renderer from unique value drawing info" time="0.000" classname="should construct renderer from unique value drawing info">
     </testcase>
-    <testcase name="ArcGisSymbologyRenderer should construct renderer from point symbology drawing info" time="0.001" classname="should construct renderer from point symbology drawing info">
+    <testcase name="ArcGisSymbologyRenderer should construct renderer from point symbology drawing info" time="0.000" classname="should construct renderer from point symbology drawing info">
     </testcase>
   </testsuite>
 </testsuites>

package/map-layers-formats.build.log

@@ -1,10 +1,10 @@
 Invoking: betools docs --includes=../../generated-docs/extract --json=../../generated-docs/core/map-layers-formats/file.json --tsIndexFile=./map-layers-formats.ts --onlyJson --excludes=**/ArcGisFeature/*.ts,**/*.gen.ts 
 Running command:
-node D:\vsts_b\15\s\tools\build\scripts\docs.js --json ../../generated-docs/core/map-layers-formats/file.json --includes ../../generated-docs/extract --excludes **/ArcGisFeature/*.ts,**/*.gen.ts --tsIndexFile ./map-layers-formats.ts --onlyJson
+node D:\vsts_a\3\s\tools\build\scripts\docs.js --json ../../generated-docs/core/map-layers-formats/file.json --includes ../../generated-docs/extract --excludes **/ArcGisFeature/*.ts,**/*.gen.ts --tsIndexFile ./map-layers-formats.ts --onlyJson
 Arguments to TypeDoc: [
   "--entryPointStrategy",
   "expand",
-  "D:\\vsts_b\\15\\s\\extensions\\map-layers-formats\\src",
+  "D:\\vsts_a\\3\\s\\extensions\\map-layers-formats\\src",
   "--excludePrivate",
   "--hideGenerator",
   "--logLevel",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@itwin/map-layers-formats",
-  "version": "3.5.0-dev.51",
+  "version": "3.5.0-dev.53",
   "description": "Enables additional map-layers formats in iTwin.js",
   "main": "lib/cjs/map-layers-formats.js",
   "module": "lib/esm/map-layers-formats.js",
@@ -21,13 +21,13 @@
     "url": "http://www.bentley.com"
   },
   "devDependencies": {
-    "@itwin/appui-abstract": "3.5.0-dev.51",
-    "@itwin/build-tools": "3.5.0-dev.51",
-    "@itwin/core-bentley": "3.5.0-dev.51",
-    "@itwin/core-common": "3.5.0-dev.51",
-    "@itwin/core-geometry": "3.5.0-dev.51",
-    "@itwin/core-frontend": "3.5.0-dev.51",
-    "@itwin/eslint-plugin": "3.5.0-dev.51",
+    "@itwin/appui-abstract": "3.5.0-dev.53",
+    "@itwin/build-tools": "3.5.0-dev.53",
+    "@itwin/core-bentley": "3.5.0-dev.53",
+    "@itwin/core-common": "3.5.0-dev.53",
+    "@itwin/core-geometry": "3.5.0-dev.53",
+    "@itwin/core-frontend": "3.5.0-dev.53",
+    "@itwin/eslint-plugin": "3.5.0-dev.53",
     "@types/chai": "4.3.1",
     "@types/chai-as-promised": "^7",
     "@types/google-protobuf": "~3.15.6",
@@ -48,10 +48,10 @@
     "typescript": "~4.4.0"
   },
   "peerDependencies": {
-    "@itwin/appui-abstract": "3.5.0-dev.51",
-    "@itwin/core-bentley": "3.5.0-dev.51",
-    "@itwin/core-common": "3.5.0-dev.51",
-    "@itwin/core-geometry": "3.5.0-dev.51"
+    "@itwin/appui-abstract": "3.5.0-dev.53",
+    "@itwin/core-bentley": "3.5.0-dev.53",
+    "@itwin/core-common": "3.5.0-dev.53",
+    "@itwin/core-geometry": "3.5.0-dev.53"
   },
   "dependencies": {
     "google-protobuf": "~3.20.1"

package/src/ArcGisFeature/ArcGisFeatureProvider.ts

@@ -5,8 +5,8 @@
 
 import { Cartographic, ImageMapLayerSettings, ImageSource, ImageSourceFormat, ServerError } from "@itwin/core-common";
 import { assert, base64StringToUint8Array, IModelStatus, Logger } from "@itwin/core-bentley";
-import { Matrix4d, Point3d, Transform } from "@itwin/core-geometry";
-import { ArcGisErrorCode, ArcGISImageryProvider, ArcGisUtilities, ImageryMapTileTree, MapLayerFeatureInfo, MapLayerImageryProviderStatus, QuadId } from "@itwin/core-frontend";
+import { Matrix4d, Point3d, Range2d, Transform } from "@itwin/core-geometry";
+import { ArcGisErrorCode, ArcGISImageryProvider, ArcGisUtilities, ImageryMapTileTree, MapCartoRectangle, MapLayerFeatureInfo, MapLayerImageryProviderStatus, QuadId } from "@itwin/core-frontend";
 import { ArcGisSymbologyRenderer } from "./ArcGisSymbologyRenderer";
 import { ArcGisExtent, ArcGisFeatureFormat, ArcGisFeatureQuery, ArcGisGeometry, FeatureQueryQuantizationParams } from "./ArcGisFeatureQuery";
 import { ArcGisFeatureRenderer } from "./ArcGisFeatureRenderer";
@@ -139,11 +139,28 @@ export class ArcGisFeatureProvider extends ArcGISImageryProvider {
       }
     }
 
+    // Parse server version
+    let majorVersion: number|undefined;
+    if (this.serviceJson?.currentVersion) {
+      try {
+        majorVersion = Math.trunc(this.serviceJson?.currentVersion);
+      } catch {
+      }
+    }
+
+    // Coordinates Quantization:  If supported, server will transform for us the coordinates in the Tile coordinate space (pixels, origin = upper left corner
+    // If not supported, transformation will be applied client side.
+    // Note: For some reasons, even though 'supportsCoordinatesQuantization' is set to 'true' on the layer metadata, server will give an error message for server version < 11
+    if (majorVersion && majorVersion >= 11 && this._layerMetadata.supportsCoordinatesQuantization) {
+      this._supportsCoordinatesQuantization = true;
+    }
+
     // Check supported query formats: JSON and PBF are currently implemented by this provider
     // Note: needs to be checked on the layer metadata, service metadata advertises a different set of formats
+    //       Also, since PBF format does not support floating points, there is no point using this format if supportsCoordinatesQuantization is not available.
     if (this._layerMetadata.supportedQueryFormats) {
       const formats: string[] = this._layerMetadata.supportedQueryFormats.split(", ");
-      if (formats.includes("PBF")) {
+      if (formats.includes("PBF") && this._supportsCoordinatesQuantization ) {
         this._format = "PBF";
       } else if (formats.includes ("JSON"))  {
         this._format = "JSON";
@@ -151,24 +168,34 @@ export class ArcGisFeatureProvider extends ArcGISImageryProvider {
     }
 
     if (!this._format) {
-      Logger.logError(loggerCategory, "Could not get service JSON");
+      Logger.logError(loggerCategory, "Could not get request format from service JSON");
       throw new ServerError(IModelStatus.ValidationFailed, "");
     }
 
-    // Coordinates Quantization:  If supported, server will transform for us the coordinates in the Tile coordinate space (pixels, origin = upper left corner
-    // If not supported, transformation will be applied client side.
-    if (this._layerMetadata.supportsCoordinatesQuantization) {
-      this._supportsCoordinatesQuantization = true;
+    // Read range using full extent from service metadata
+    if (json.fullExtent) {
+      if (json.fullExtent.spatialReference.latestWkid === 3857 || json.fullExtent.spatialReference.wkid === 102100) {
+        const range3857 = Range2d.createFrom({
+          low: {x: json.fullExtent.xmin, y: json.fullExtent.ymin},
+          high: {x: json.fullExtent.xmax, y: json.fullExtent.ymax} });
+
+        const west = this.getEPSG4326Lon(range3857.xLow);
+        const south = this.getEPSG4326Lat(range3857.yLow);
+        const east = this.getEPSG4326Lon(range3857.xHigh);
+        const north = this.getEPSG4326Lat(range3857.yHigh);
+        this.cartoRange = MapCartoRectangle.fromDegrees(west, south, east, north);
+      }
     }
 
     // Check for minScale / max scale
     const minScale = this._layerMetadata?.minScale || undefined;  // undefined, 0 -> undefined
     const maxScale = this._layerMetadata?.maxScale || undefined;  // undefined, 0 -> undefined
-    const scales = ArcGisUtilities.getZoomLevelsScales(this.defaultMaximumZoomLevel, this.tileSize, minScale, maxScale);
+    const scales = ArcGisUtilities.getZoomLevelsScales(this.defaultMaximumZoomLevel, this.tileSize, minScale, maxScale, 1.0);
     if (scales.minLod)
       this._minDepthFromLod = scales.minLod;
-    if (scales.maxLod)
-      this._maxDepthFromLod = scales.maxLod;
+
+    // Some servers advertises a max LOD of 0, it should be interpreted as 'not defined' (otherwise a max lod of 0 would would mean never display anything)
+    this._maxDepthFromLod =  (scales.maxLod ? scales.maxLod : this.defaultMaximumZoomLevel);
 
     this._symbologyRenderer = new ArcGisSymbologyRenderer(this._layerMetadata?.geometryType, this._layerMetadata?.drawingInfo?.renderer);
   }
@@ -205,7 +232,7 @@ export class ArcGisFeatureProvider extends ArcGISImageryProvider {
     // Actual spatial filter.
     // By default, we request the tile extent.  If 'cartoPoint' is specified,
     // we restrict the spatial to specific point. (i.e. GetFeatureInfo requests)
-    // We a refine envelope is provided, it has the priority over 'cartoPoint'
+    // If envelope is provided, it has the priority over 'cartoPoint'
     let geometry: ArcGisGeometry|undefined;
     if (geomOverride) {
       geometry = geomOverride;
@@ -324,9 +351,6 @@ export class ArcGisFeatureProvider extends ArcGISImageryProvider {
     }
 
     const response = this.fetch(new URL(tileUrl.url), { method: "GET" });
-    // if ((await response).status !== 200){
-    //   return undefined;
-    // }
     return new ArcGisFeatureResponse(this.format, response, tileUrl.envelope);
   }
 

package/src/ArcGisFeature/ArcGisFeatureQuery.ts

@@ -157,80 +157,70 @@ export class ArcGisFeatureQuery {
   }
 
   public toString() {
-    let customParams = "";
+    const url = new URL(`${this.baseUrl}/${this.layerIdx}/query`);
+
+    url.searchParams.append("f", this.format);
 
     if ( this.resultRecordCount !== undefined) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "resultRecordCount", `${this.resultRecordCount}`);
+      url.searchParams.append("resultRecordCount", `${this.resultRecordCount}`);
     }
 
     if ( this.resultOffset !== undefined) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "resultOffset", `${this.resultOffset}`);
+      url.searchParams.append( "resultOffset", `${this.resultOffset}`);
     }
 
     if ( this.returnGeometry !== undefined) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "returnGeometry", this.returnGeometry?"true":"false");
+      url.searchParams.append("returnGeometry", this.returnGeometry?"true":"false");
     }
 
     if ( this.resultType !== undefined) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "resultType", this.resultType);
+      url.searchParams.append("resultType", this.resultType);
     }
 
     if ( this.maxRecordCountFactor !== undefined) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "maxRecordCountFactor", `${this.maxRecordCountFactor}`);
+      url.searchParams.append( "maxRecordCountFactor", `${this.maxRecordCountFactor}`);
     }
 
     if ( this.returnExceededLimitFeatures !== undefined) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "returnExceededLimitFeatures", this.returnExceededLimitFeatures?"true":"false");
+      url.searchParams.append( "returnExceededLimitFeatures", this.returnExceededLimitFeatures?"true":"false");
     }
 
-    customParams = ArcGisFeatureQuery.appendParam(customParams, "outSR", `${this.outSR}`);
+    url.searchParams.append( "outSR", `${this.outSR}`);
 
     if (this.geometry || this.spatialRel) {
 
       if (this.spatialRel) {
-        customParams = ArcGisFeatureQuery.appendParam(customParams, "spatialRel", this.spatialRel);
+        url.searchParams.append( "spatialRel", this.spatialRel);
       }
 
       if (this.geometry) {
-        customParams = ArcGisFeatureQuery.appendParam(customParams, "geometryType", this.geometry.type);
+        url.searchParams.append( "geometryType", this.geometry.type);
 
         const geomStr = JSON.stringify(this.geometry.geom);
-        customParams = ArcGisFeatureQuery.appendParam(customParams, "geometry", geomStr);
+        url.searchParams.append( "geometry", geomStr);
+        url.searchParams.append( "units", "esriSRUnit_Meter");    // required on older server for get feature info
 
-        customParams = ArcGisFeatureQuery.appendParam(customParams, "inSR", `${this.geometry.geom.spatialReference.wkid}`);
+        url.searchParams.append( "inSR", `${this.geometry.geom.spatialReference.wkid}`);
       }
     } else {
       // No custom params, fetch all geometries
-      customParams = "where=1=1";
+      url.searchParams.append("where", "1=1");
     }
 
     if (this.quantizationParams) {
       const quantizationParamsStr = JSON.stringify(this.quantizationParams);
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "quantizationParameters", quantizationParamsStr);
+      url.searchParams.append("quantizationParameters", quantizationParamsStr);
     }
 
     if (this.outFields) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "outFields", this.outFields);
+      url.searchParams.append( "outFields", this.outFields);
     }
 
     if (this.distance) {
-      customParams = ArcGisFeatureQuery.appendParam(customParams, "distance", `${this.distance}`);
-    }
-
-    return `${this.baseUrl}/${this.layerIdx}/query/?f=${this.format}&${customParams}`;
-  }
-
-  private static  appendParam(urlToAppend: string, paramName: string, paramValue: string) {
-    if (paramName.length === 0) {
-      return urlToAppend;
-    }
-
-    let url = urlToAppend;
-    if (urlToAppend.length > 0 && !urlToAppend.endsWith("&")) {
-      url = `${urlToAppend  }&`;
+      url.searchParams.append("distance", `${this.distance}`);
     }
 
-    return `${url}${paramName}=${paramValue}`;
+    return url.toString();
   }
 
 }

package/src/ArcGisFeature/ArcGisSymbologyRenderer.ts

@@ -130,21 +130,23 @@ export class ArcGisSymbologyRenderer {
     type: "esriPMS",
     url: "",
     contentType: "image/png",
-    imageData: "iVBORw0KGgoAAAANSUhEUgAAABMAAAATCAYAAAByUDbMAAAAAXNSR0IB2cksfwAAAAlwSFlzAAAOxAAADsQBlSsOGwAAAT9JREFUOI2t1E8rRGEUx/HvMHViIm5ZXGt/3gFlwdKGhYjyAmxs7IassDHFyguwwkbZYJKNslVWJDZT1C3psRv9NMpmJk/Tvc3MHWf3/PuccxbPyfKPkW1wPmBmQ5L6giB4d849Al+tYjNAHpiQ1AHgnAMoA+dhGG5HUfTQCOsCDoGlhCTdwGIURfPVZPtJWCdwBkwntVF3d6+K78Rh+SYhP7bM7FbSjY8FwHqLEEBGUgEY97E5oCcFBjAGDAMvNWwyJVSLKR8L28QG4a/N7zYx+VipTazkY0VgNSVUAa597MrMniWNpMBOAOdjFUlrwAWQaQFywGZt4f+AIrAB7DYJlc1sQdJrHAZQAN6AA6A/STGzp1wut+ycu/f340bQEXAJrACzwCjQC3wAd8CppGNJP/UPk+bZZ7XKQlJ1cfEL1AZaAcKna+kAAAAASUVORK5CYII=",
-    width: 14,
-    height: 14,
+    imageData: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAmBJREFUOE+Nk01IVFEUx//n3jfvOZOaJkMtiiJ7o9RG3LgoqKhFSFJBTS1ahFBBi0ijfJXCIyQr+hBbSIsoW7iQoKKFCw2CkAI3tZAgy8Ei+xhoTCbnje/NPfHGnA816KzuPR+/c8/HJRQJE7o+VUhym0DcCOYGgBQEXjOLlyqo+nHanCkMoaL4rslKjZwOQLT4ek3Mmz3FACFNLB67ut6M1nWphbg8wI6VyJK5KEH0EQFVJRKbwzokAW++p/ErraAYSQK3u47bC3vLnA+ZB9i2gHF0oyQMCfCGNaUa+vauxs71wWz2V18cnBj8gQ8J1/eeBnHUa4sMFQDGdGno+4gwEAoQzjVUon3rqlx1KY9x7+0MWobjAPg3QJ2eZV4tAEyFNCN5FkSXyw2B3j1hRGvLcgBXMV5MptA4MOXr0gT0u5bZnAf0jBsyiSgJPAxqhON1K3FlRxUMvwFAtv7u0Wl0jvwEmJNEuOhakTt5wKEBifr6Oo14BIBRpgt07w6jcVMIngKGY7NofR5HwlF+zDcpsC193vyYB/innvHywCzdZfAR/+onX1segBTAxHzzfPE7/8yzzIPLjJE1LTixHZx5CtCK4gXLzovBiDPUsYxVM7gUkB3nWKlm6DYEnQGzXARxCOK+a1WfKtQXb6LNAvr7iCboCUA1Ocdsdv5KLPe7F6pH/w3wLbc+BwOuc5IZ1wEE/jonQbjptZn24tKKX7BgvR2r0NKZRwDvAqCI+Z30VJPTURv7P4A9psuQcYAUPwAoReBLrmX2Lmls7i8sZ7kWLwuoxA1FVJGxzMPLufi6P2r+2xFbOUjGAAAAAElFTkSuQmCC",
+    width: 16,
+    height: 16,
+    xoffset: -8,
+    yoffset: -16,
   };
 
   private static readonly defaultSLS: EsriSLSProps = {
     type: "esriSLS",
-    color: [0, 0.0],
+    color: [0, 0, 0, 255],
     width: 1,
     style: "esriSLSSolid",
   };
 
   private static readonly defaultSFS: EsriSFSProps = {
     type: "esriSFS",
-    color: [0, 0.0],
+    color:  [0, 0, 0, 255],
     style: "esriSFSSolid",
   };
 
@@ -172,11 +174,11 @@ export class ArcGisSymbologyRenderer {
     if (this._symbol === undefined) {
       Logger.logWarning(loggerCategory, "Symbology definition not supported, using default symbology");
       if (geometryType === "esriGeometryPoint" || geometryType === "esriGeometryMultipoint") {
-        this._symbol = ArcGisSymbologyRenderer.defaultPMS;
+        this._symbol = EsriPMS.fromJSON(ArcGisSymbologyRenderer.defaultPMS);
       } else if (geometryType === "esriGeometryLine" || geometryType === "esriGeometryPolyline") {
-        this._symbol = ArcGisSymbologyRenderer.defaultSLS;
+        this._symbol = EsriSLS.fromJSON(ArcGisSymbologyRenderer.defaultSLS);
       } else if (geometryType === "esriGeometryPolygon") {
-        this._symbol = ArcGisSymbologyRenderer.defaultSFS;
+        this._symbol = EsriSFS.fromJSON(ArcGisSymbologyRenderer.defaultSFS);
       } else {
         Logger.logError(loggerCategory, "Could not determine default symbology: geometry type not supported");
       }
@@ -227,14 +229,15 @@ export class ArcGisSymbologyRenderer {
       let xOffset = 0, yOffset = 0;
       if (pms.xoffset)
         xOffset = pms.xoffset;
+      else if (pms.width)
+        xOffset = pms.width * -0.5;  // if no offset center in the middle
+
       if (pms.yoffset)
         yOffset = pms.yoffset;
+      else if (pms.height)
+        yOffset = pms.height * -0.5; // if no offset center in the middle
 
       if (pms.width && pms.height) {
-        // // make sure the marker is centered on the point
-        xOffset += pms.width * -0.5;
-        yOffset += pms.height * -0.5;
-
         context.drawImage(pms.image, ptX + xOffset, ptY + yOffset, pms.width, pms.height);
       } else {
         context.drawImage(pms.image, ptX + xOffset, ptY + yOffset);