@itwin/imodel-transformer 2.0.0-dev.50 → 2.0.0-dev.51

package/lib/cjs/IModelTransformer.js

@@ -889,18 +889,17 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             }
         }
     }
-    /** Override of [IModelExportHandler.onDeleteElement]($transformer) that is called when [IModelExporter]($transformer) detects that an Element has been deleted from the source iModel.
-     * This override propagates the delete to the target iModel via [IModelImporter.deleteElement]($transformer).
-     */
-    async onDeleteElement(sourceElementId) {
-        const targetElementId = this.context.findTargetElementId(sourceElementId);
-        if (core_bentley_1.Id64.isValidId64(targetElementId)) {
-            // Skip deletion if new / updated source element was remapped to it by Code during
-            // this transformation pass.
-            if (!this._targetElementIdsRemappedByCode.has(targetElementId)) {
-                await this.importer.deleteElement(targetElementId);
+    /** Maps the deleted source element IDs and passes the target IDs to the importer as one set. */
+    async onDeleteElements(sourceElementIds) {
+        const targetElementIds = new Set();
+        for (const sourceElementId of sourceElementIds) {
+            const targetElementId = this.context.findTargetElementId(sourceElementId);
+            if (core_bentley_1.Id64.isValidId64(targetElementId) &&
+                !this._targetElementIdsRemappedByCode.has(targetElementId)) {
+                targetElementIds.add(targetElementId);
             }
         }
+        await this.importer.deleteElements(targetElementIds);
     }
     /** Override of [IModelExportHandler.onExportModel]($transformer) that is called when a Model should be exported from the source iModel.
      * This override calls [[onTransformModel]] and then [IModelImporter.importModel]($transformer) to update the target iModel.
@@ -969,9 +968,8 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
                     error.errorNumber === core_bentley_1.IModelStatus.ForeignKeyConstraint);
             if (!isDeletionProhibitedErr)
                 throw error;
-            // Transformer tries to delete models before it deletes elements. Definition models cannot be deleted unless all of their modeled elements are deleted first.
-            // In case a definition model needs to be deleted we need to skip it for now and register its modeled partition for deletion.
-            // The `OnDeleteElement` calls `DeleteElementTree` Which deletes the model together with its partition after deleting all of the modeled elements.
+            // Models are processed before elements, but a definition model cannot be deleted while it contains elements.
+            // Add its partition to the element deletion set. Bulk cascade deletion will remove the contents, model, and partition together.
             this.scheduleModeledPartitionDeletion(sourceModelId);
         }
     }