@itwin/imodel-transformer 2.0.0-dev.2 → 2.0.0-dev.3

package/lib/cjs/IModelTransformer.js

@@ -77,6 +77,15 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
     targetDb;
     /** The IModelTransformContext for this IModelTransformer. */
     context;
+    /** The transform to be applied to the placement of spatial elements
+     * This transform should be applied when:
+     * - source and target db have different ECEF locations
+     * - source and target db have matching GCS/CRS data, but differing `geographicCoordinateSystem.additionalTransform.helmert2DWithZOffset`
+     * @note for ECEF transforms, this can only be used when source and target are linearly located imodels
+     * @note for non linearly located imodels, this transform will be a linear transform derived from Helmert Transforms from the src and target iModels.
+     * @beta
+     */
+    _linearSpatialTransform;
     _syncType;
     /** The Id of the Element in the **target** iModel that represents the **source** repository as a whole and scopes its [ExternalSourceAspect]($backend) instances. */
     get targetScopeElementId() {
@@ -111,7 +120,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         AND Identifier=:identifier
       LIMIT 1
     `;
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         return dbToQuery.withPreparedStatement(sql, (statement) => {
             statement.bindId("elementId", aspectProps.element.id);
             if (aspectProps.scope === undefined)
@@ -230,10 +239,11 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             // non-falsy defaults
             cloneUsingBinaryGeometry: options?.cloneUsingBinaryGeometry ?? true,
             targetScopeElementId: options?.targetScopeElementId ?? core_common_1.IModel.rootSubjectId,
-            // eslint-disable-next-line deprecation/deprecation
+            // eslint-disable-next-line @typescript-eslint/no-deprecated
             danglingReferencesBehavior: options?.danglingReferencesBehavior ?? "reject",
             branchRelationshipDataBehavior: options?.branchRelationshipDataBehavior ?? "reject",
             skipPropagateChangesToRootElements: options?.skipPropagateChangesToRootElements ?? true,
+            tryAlignGeolocation: options?.tryAlignGeolocation ?? false,
         };
         // check if authorization client is defined
         if (core_backend_1.IModelHost.authorizationClient === undefined) {
@@ -289,6 +299,20 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             this.targetDb.codeValueBehavior = "exact";
         }
         /* eslint-enable @itwin/no-internal */
+        if (this._options.tryAlignGeolocation) {
+            if (this.sourceDb.geographicCoordinateSystem ||
+                this.targetDb.geographicCoordinateSystem) {
+                core_bentley_1.Logger.logTrace(loggerCategory, "Aligning Additional transforms between imodels due to imodels containing GeographicCoordinateSystem data");
+                this._linearSpatialTransform =
+                    this.calculateTransformFromHelmertTransforms();
+            }
+            else if (this.sourceDb.ecefLocation && this.targetDb.ecefLocation) {
+                core_bentley_1.Logger.logTrace(loggerCategory, "Aligning ECEF Location's between imodels due to imodels not containing GeographicCoordinateSystem data");
+                this._linearSpatialTransform = this.calculateEcefTransform();
+            }
+            else
+                core_bentley_1.Logger.logTrace(loggerCategory, "No Geolcation data to align, both GCS and ECEF are undefined");
+        }
     }
     /** validates that the importer set on the transformer has the same values for its shared options as the transformer.
      *  @note This expects that the importer is already set on the transformer.
@@ -371,7 +395,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         const provenanceRelInstanceId = args.isReverseSynchronization
             ? sourceRelInstanceId
             : targetRelInstanceId;
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         const elementId = provenanceDb.withPreparedStatement("SELECT SourceECInstanceId FROM bis.ElementRefersToElements WHERE ECInstanceId=?", (stmt) => {
             stmt.bindId(1, provenanceRelInstanceId);
             nodeAssert(stmt.step() === core_bentley_1.DbResult.BE_SQLITE_ROW);
@@ -524,9 +548,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
           AND Kind=:kind
         LIMIT 1
       `;
-            // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+            // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
             const hasConflictingScope = this.provenanceDb.withPreparedStatement(sql, 
-            // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+            // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
             (statement) => {
                 statement.bindId("elementId", aspectProps.element.id);
                 statement.bindId("scopeId", aspectProps.scope.id); // this scope.id can never be invalid, we create it above
@@ -649,9 +673,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         // NOTE: if we exposed the native attach database support,
         // we could get the intersection of fed guids in one query, not sure if it would be faster
         // OR we could do a raw sqlite query...
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         sourceDb.withStatement(elementIdByFedGuidQuery, (sourceStmt) => 
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         targetDb.withStatement(elementIdByFedGuidQuery, (targetStmt) => {
             if (sourceStmt.step() !== core_bentley_1.DbResult.BE_SQLITE_ROW)
                 return;
@@ -695,7 +719,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         // Technically this will a second time call the function (as documented) on
         // victims of the old provenance method that have both fedguids and an inserted aspect.
         // But this is a private function with one known caller where that doesn't matter
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         args.provenanceDb.withPreparedStatement(provenanceAspectsQuery, (stmt) => {
             const runFnInDataFlowDirection = (sourceId, targetId) => args.isReverseSynchronization
                 ? args.fn(sourceId, targetId)
@@ -728,7 +752,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
      * @returns the elementId that the ESA is stored on, esa.Element.Id
      */
     _queryProvenanceForElement(entityInProvenanceSourceId) {
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         return this.provenanceDb.withPreparedStatement(`
         SELECT esa.Element.Id
         FROM Bis.ExternalSourceAspect esa
@@ -753,7 +777,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
      * @returns
      */
     _queryProvenanceForRelationship(entityInProvenanceSourceId, sourceRelInfo) {
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         return this.provenanceDb.withPreparedStatement(`
         SELECT
           ECInstanceId,
@@ -788,7 +812,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         if (targetRelInfo.sourceId === undefined ||
             targetRelInfo.targetId === undefined)
             return undefined; // couldn't find an element, rel is invalid or deleted
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         return this.targetDb.withPreparedStatement(`
       SELECT ECInstanceId
       FROM bis.ElementRefersToElements
@@ -816,7 +840,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
     // NOTE: this doesn't handle remapped element classes,
     // but is only used for relationships rn
     _getRelClassId(db, classFullName) {
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         return db.withPreparedStatement(`
       SELECT c.ECInstanceId
       FROM ECDbMeta.ECClassDef c
@@ -834,7 +858,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         });
     }
     _queryElemIdByFedGuid(db, fedGuid) {
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         return db.withPreparedStatement("SELECT ECInstanceId FROM Bis.Element WHERE FederationGuid=?", (stmt) => {
             stmt.bindGuid(1, fedGuid);
             if (stmt.step() === core_bentley_1.DbResult.BE_SQLITE_ROW)
@@ -870,7 +894,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
     `;
         nodeAssert(!this.isReverseSynchronization, "synchronizations with processChanges already detect element deletes, don't call detectElementDeletes");
         // Reported issue: https://github.com/iTwin/itwinjs-core/issues/7989
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         this.provenanceDb.withPreparedStatement(sql, (stmt) => {
             stmt.bindId("scopeId", this.targetScopeElementId);
             stmt.bindString("kind", core_backend_1.ExternalSourceAspect.Kind.Element);
@@ -918,8 +942,87 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
                 targetElementProps.jsonProperties.Subject.Job = undefined;
             }
         }
+        if (this._linearSpatialTransform !== undefined &&
+            sourceElement instanceof core_backend_1.GeometricElement3d) {
+            // can check the sourceElement since this IModelTransformer does not remap classes
+            const placement = core_common_1.Placement3d.fromJSON(targetElementProps.placement);
+            if (placement.isValid) {
+                placement.multiplyTransform(this._linearSpatialTransform);
+                targetElementProps.placement = placement;
+            }
+        }
         return targetElementProps;
     }
+    /**
+     * Calculate the transform between two ECEF locations
+     * @param srcDb
+     * @param targetDb
+     * @returns Transform that converts relative coordinates in the source iModel to relative coordinates in the target iModel.
+     * @note This can only be used if both source and target iModels are linearly located
+     */
+    calculateEcefTransform() {
+        const srcEcefLoc = this.sourceDb.ecefLocation;
+        const targetEcefLoc = this.targetDb.ecefLocation;
+        if (srcEcefLoc === undefined || targetEcefLoc === undefined) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.NoGeoLocation, "Both source and target ECEF locations must be defined to calculate the transform.");
+        }
+        if (srcEcefLoc.getTransform().isAlmostEqual(targetEcefLoc.getTransform())) {
+            core_bentley_1.Logger.logTrace(loggerCategory, "ECEF data is already aligned. No spatial transforms needed.");
+            return undefined;
+        }
+        const srcSpatialToECEF = srcEcefLoc.getTransform(); // converts relative to ECEF in relation to source
+        const targetECEFToSpatial = targetEcefLoc.getTransform().inverse(); // converts ECEF to relative in relation to target
+        if (!targetECEFToSpatial) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.NoGeoLocation, "Failed to invert target ECEF transform.");
+        }
+        const ecefTransform = targetECEFToSpatial.multiplyTransformTransform(srcSpatialToECEF); // chain both transforms
+        return ecefTransform;
+    }
+    static convertHelmertToTransform(helmert) {
+        if (!helmert) {
+            return core_geometry_1.Transform.createIdentity();
+        }
+        const rotationXY = core_geometry_1.Matrix3d.createRotationAroundAxisIndex(core_geometry_1.AxisIndex.Z, core_geometry_1.Angle.createDegrees(helmert?.rotDeg));
+        rotationXY.scaleColumnsInPlace(helmert.scale, helmert.scale, 1.0);
+        const translation = core_geometry_1.Vector3d.create(helmert.translationX, helmert.translationY, helmert.translationZ);
+        const helmertTransform = core_geometry_1.Transform.createRefs(translation, rotationXY);
+        return helmertTransform;
+    }
+    calculateTransformFromHelmertTransforms() {
+        if (this.sourceDb.geographicCoordinateSystem?.horizontalCRS === undefined ||
+            this.sourceDb.geographicCoordinateSystem?.verticalCRS === undefined) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.BadRequest, "Source iModel does not have a geographic coordinate system defined.");
+        }
+        if (this.targetDb.geographicCoordinateSystem?.horizontalCRS === undefined ||
+            this.targetDb.geographicCoordinateSystem.verticalCRS === undefined) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.BadRequest, "Target iModel does not have a geographic coordinate system defined.");
+        }
+        if (!this.sourceDb.geographicCoordinateSystem.horizontalCRS.equals(this.targetDb.geographicCoordinateSystem.horizontalCRS) ||
+            !this.sourceDb.geographicCoordinateSystem.verticalCRS.equals(this.targetDb.geographicCoordinateSystem.verticalCRS)) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.MismatchGcs, "Source and target geographic coordinate systems must match to calculate the spatial transform.");
+        }
+        if (this.sourceDb.geographicCoordinateSystem.additionalTransform ===
+            this.targetDb.geographicCoordinateSystem.additionalTransform) {
+            core_bentley_1.Logger.logTrace(loggerCategory, "Geolocation data is already aligned. No spatial transforms needed.");
+            return undefined;
+        }
+        const srcScale = this.sourceDb.geographicCoordinateSystem.additionalTransform
+            ?.helmert2DWithZOffset?.scale ?? 1;
+        const targetScale = this.targetDb.geographicCoordinateSystem.additionalTransform
+            ?.helmert2DWithZOffset?.scale ?? 1;
+        if (srcScale !== targetScale) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.MismatchGcs, "Spatial transform is non rigid. Source and target Helmert transforms must have the same scale to calculate a rigid spatial transform.");
+        }
+        const srcTransform = IModelTransformer.convertHelmertToTransform(this.sourceDb.geographicCoordinateSystem.additionalTransform
+            ?.helmert2DWithZOffset); // moves elements to where src helmert transform would move them at render time
+        const targetTransformInv = IModelTransformer.convertHelmertToTransform(this.targetDb.geographicCoordinateSystem.additionalTransform
+            ?.helmert2DWithZOffset).inverse(); // negates target helmert transform that is applied at render time
+        if (!targetTransformInv) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.NoGeoLocation, "Failed to invert target Helmert transform.");
+        }
+        const combinedTransform = targetTransformInv.multiplyTransformTransform(srcTransform);
+        return combinedTransform;
+    }
     // if undefined, it can be initialized by calling [[this.processChangesets]]
     _deletedSourceRelationshipData = undefined;
     /** Returns true if a change within sourceElement is detected.
@@ -1162,7 +1265,10 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         if (!this._options.wasSourceIModelCopiedToTarget) {
             this.importer.importElement(targetElementProps); // don't need to import if iModel was copied
         }
-        this.context.remapElement(sourceElement.id, targetElementProps.id); // targetElementProps.id assigned by importElement
+        if (targetElementProps.id === undefined) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.BadElement, "targetElementProps.id should be assigned by importElement");
+        }
+        this.context.remapElement(sourceElement.id, targetElementProps.id);
         // the transformer does not currently 'split' or 'join' any elements, therefore, it does not
         // insert external source aspects because federation guids are sufficient for this.
         // Other transformer subclasses must insert the appropriate aspect (as provided by a TBD API)
@@ -1233,7 +1339,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
       WHERE ECInstanceId=:targetModelId
     `;
         if (this.exporter.sourceDbChanges?.element.deleteIds.has(sourceModelId)) {
-            // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+            // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
             const isDefinitionPartition = this.targetDb.withPreparedStatement(sql, (stmt) => {
                 stmt.bindId("targetModelId", targetModelId);
                 const val = stmt.step();
@@ -1301,9 +1407,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         await this.initialize();
         // import DefinitionModels first
         const childDefinitionPartitionSql = `SELECT ECInstanceId FROM ${core_backend_1.DefinitionPartition.classFullName} WHERE Parent.Id=:subjectId`;
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         await this.sourceDb.withPreparedStatement(childDefinitionPartitionSql, 
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         async (statement) => {
             statement.bindId("subjectId", sourceSubjectId);
             while (core_bentley_1.DbResult.BE_SQLITE_ROW === statement.step()) {
@@ -1312,9 +1418,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         });
         // import other partitions next
         const childPartitionSql = `SELECT ECInstanceId FROM ${core_backend_1.InformationPartitionElement.classFullName} WHERE Parent.Id=:subjectId`;
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         await this.sourceDb.withPreparedStatement(childPartitionSql, 
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         async (statement) => {
             statement.bindId("subjectId", sourceSubjectId);
             while (core_bentley_1.DbResult.BE_SQLITE_ROW === statement.step()) {
@@ -1327,9 +1433,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         });
         // recurse into child Subjects
         const childSubjectSql = `SELECT ECInstanceId FROM ${core_backend_1.Subject.classFullName} WHERE Parent.Id=:subjectId`;
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         await this.sourceDb.withPreparedStatement(childSubjectSql, 
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         async (statement) => {
             statement.bindId("subjectId", sourceSubjectId);
             while (core_bentley_1.DbResult.BE_SQLITE_ROW === statement.step()) {
@@ -1351,6 +1457,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             id: targetModeledElementId,
         };
         targetModelProps.id = targetModeledElementId;
+        if (targetModelProps.parentModel === undefined) {
+            throw new core_common_1.IModelError(core_bentley_1.IModelStatus.BadElement, "targetElementProps must have a defined parentModel");
+        }
         targetModelProps.parentModel = this.context.findTargetElementId(targetModelProps.parentModel);
         return targetModelProps;
     }
@@ -1400,6 +1509,8 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             (this._startingChangesetIndices && initializeReverseSyncVersion)) {
             nodeAssert(this.targetDb.changeset.index !== undefined &&
                 this._startingChangesetIndices !== undefined, "updateSynchronizationVersion was called without change history");
+            // Store in a local variable, so typescript knows it's defined (due to the assert above)
+            const startingChangesetIndices = this._startingChangesetIndices;
             const jsonProps = this._targetScopeProvenanceProps.jsonProperties;
             core_bentley_1.Logger.logTrace(loggerCategory, `previous pendingReverseSyncChanges: ${jsonProps.pendingReverseSyncChangesetIndices}`);
             core_bentley_1.Logger.logTrace(loggerCategory, `previous pendingSyncChanges: ${jsonProps.pendingSyncChangesetIndices}`);
@@ -1420,16 +1531,16 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             // transformation finalization, the work will be saved immediately, otherwise we've
             // just marked this changeset as a synchronization to ignore, and the user can add other
             // stuff to it which would break future synchronizations
-            for (let i = this._startingChangesetIndices.target + 1; i <= this.targetDb.changeset.index + 1; i++)
+            for (let i = startingChangesetIndices.target + 1; i <= this.targetDb.changeset.index + 1; i++)
                 jsonProps[syncChangesetsToUpdateKey].push(i);
             // Only keep the changeset indices which are greater than the source, this means they haven't been processed yet.
             jsonProps[syncChangesetsToClearKey] = jsonProps[syncChangesetsToClearKey].filter((csIndex) => {
-                return csIndex > this._startingChangesetIndices.source;
+                return csIndex > startingChangesetIndices.source;
             });
             // if reverse sync then we may have received provenance changes which should be marked as sync changes
             if (this.isReverseSynchronization) {
                 nodeAssert(this.sourceDb.changeset.index !== undefined, "changeset didn't exist");
-                for (let i = this._startingChangesetIndices.source + 1; i <= this.sourceDb.changeset.index + 1; i++)
+                for (let i = startingChangesetIndices.source + 1; i <= this.sourceDb.changeset.index + 1; i++)
                     jsonProps.pendingReverseSyncChangesetIndices.push(i);
             }
             core_bentley_1.Logger.logTrace(loggerCategory, `new pendingReverseSyncChanges: ${jsonProps.pendingReverseSyncChangesetIndices}`);
@@ -1551,9 +1662,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
       WHERE aspect.Scope.Id=:scopeId
         AND aspect.Kind=:kind
     `;
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         await this.targetDb.withPreparedStatement(sql, 
-        // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+        // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
         async (statement) => {
             statement.bindId("scopeId", this.targetScopeElementId);
             statement.bindString("kind", core_backend_1.ExternalSourceAspect.Kind.Relationship);
@@ -1685,7 +1796,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             nodeAssert(schemaFileName.length <= systemMaxPathSegmentSize, "Schema name was still long. This is a bug.");
             this._longNamedSchemasMap.set(schema.name, schemaFileName);
         }
-        /* eslint-disable-next-line deprecation/deprecation */
+        /* eslint-disable-next-line @typescript-eslint/no-deprecated */
         this.sourceDb.exportSchema({
             schemaName: schema.name,
             outputDirectory: this._schemaExportDir,
@@ -1848,7 +1959,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
                 disableSchemaCheck: true,
             });
             const csAdaptor = new core_backend_1.ChangesetECAdaptor(csReader);
-            const ecChangeUnifier = new core_backend_1.PartialECChangeUnifier();
+            const ecChangeUnifier = new core_backend_1.PartialECChangeUnifier(this.sourceDb);
             while (csAdaptor.step()) {
                 ecChangeUnifier.appendFrom(csAdaptor);
             }
@@ -1957,7 +2068,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             const sourceIdOfRelationshipInTarget = await getTargetIdFromSourceId(sourceIdOfRelationshipInSource);
             const targetIdOfRelationshipInTarget = await getTargetIdFromSourceId(targetIdOfRelationshipInSource);
             if (sourceIdOfRelationshipInTarget && targetIdOfRelationshipInTarget) {
-                this._deletedSourceRelationshipData.set(changedInstanceId, {
+                this._deletedSourceRelationshipData?.set(changedInstanceId, {
                     classFullName: classFullName ?? "",
                     sourceIdInTarget: sourceIdOfRelationshipInTarget,
                     targetIdInTarget: targetIdOfRelationshipInTarget,
@@ -1970,7 +2081,7 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
                     targetId: targetIdOfRelationshipInSource,
                 });
                 if (relProvenance && relProvenance.relationshipId)
-                    this._deletedSourceRelationshipData.set(changedInstanceId, {
+                    this._deletedSourceRelationshipData?.set(changedInstanceId, {
                         classFullName: classFullName ?? "",
                         relId: relProvenance.relationshipId,
                         provenanceAspectId: relProvenance.aspectId,
@@ -1987,6 +2098,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
             const deletionNotInTarget = !targetId;
             if (deletionNotInTarget)
                 return;
+            if (targetId === undefined) {
+                throw new core_common_1.IModelError(core_bentley_1.IModelStatus.BadElement, "targetId should aquired from source id or element provenance");
+            }
             this.context.remapElement(changedInstanceId, targetId);
             // If an entity insert and an entity delete both point to the same entity in target iModel, that means that entity was recreated.
             // In such case an entity update will be triggered and we no longer need to delete the entity.
@@ -2020,13 +2134,11 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         const endChangesetId = this.sourceDb.changeset.id;
         const [startChangesetIndex, endChangesetIndex] = await Promise.all([startChangesetIndexOrId, endChangesetId].map(async (indexOrId) => typeof indexOrId === "number"
             ? indexOrId
-            : core_backend_1.BriefcaseManager
-                .queryChangeset({
+            : core_backend_1.BriefcaseManager.queryChangeset({
                 iModelId: this.sourceDb.iModelId,
-                // eslint-disable-next-line deprecation/deprecation
+                // eslint-disable-next-line @typescript-eslint/no-deprecated
                 changeset: { id: indexOrId },
-            })
-                .then((changeset) => changeset.index)));
+            }).then((changeset) => changeset.index)));
         const missingChangesets = startChangesetIndex > this.synchronizationVersion.index + 1;
         if (!this._options.argsForProcessChanges
             ?.ignoreMissingChangesetsInSynchronizations &&
@@ -2115,9 +2227,9 @@ class IModelTransformer extends IModelExporter_1.IModelExportHandler {
         await this.exporter.exportRelationships(core_backend_1.ElementRefersToElements.classFullName);
         if (this._options.forceExternalSourceAspectProvenance &&
             this.shouldDetectDeletes()) {
-            // eslint-disable-next-line deprecation/deprecation
+            // eslint-disable-next-line @typescript-eslint/no-deprecated
             await this.detectElementDeletes();
-            // eslint-disable-next-line deprecation/deprecation
+            // eslint-disable-next-line @typescript-eslint/no-deprecated
             await this.detectRelationshipDeletes();
         }
         if (this._options.optimizeGeometry)
@@ -2294,13 +2406,13 @@ class TemplateModelCloner extends IModelTransformer {
                 targetElementProps.placement = placement;
             }
         }
-        this._sourceIdToTargetIdMap.set(sourceElement.id, core_bentley_1.Id64.invalid); // keep track of (source) elementIds from the template model, but the target hasn't been inserted yet
+        this._sourceIdToTargetIdMap?.set(sourceElement.id, core_bentley_1.Id64.invalid); // keep track of (source) elementIds from the template model, but the target hasn't been inserted yet
         return targetElementProps;
     }
 }
 exports.TemplateModelCloner = TemplateModelCloner;
 function queryElemFedGuid(db, elemId) {
-    // eslint-disable-next-line @itwin/no-internal, deprecation/deprecation
+    // eslint-disable-next-line @itwin/no-internal, @typescript-eslint/no-deprecated
     return db.withPreparedStatement(`
     SELECT FederationGuid
     FROM bis.Element