@itwin/ecschema-rpcinterface-tests 5.13.0-dev.10 → 5.13.0-dev.12

package/lib/dist/bundled-tests.js

@@ -28324,15 +28324,28 @@ class QueryBinder {
      * @param indexOrName Specify parameter index or its name used in ECSQL statement.
      * @param val @type OrderedId64Iterable value to bind to ECSQL statement.
      * @returns @type QueryBinder to allow fluent interface.
+     * @throws an [[ITwinError]] with scope `"itwin-QueryBinder"` and key `"invalid-arguments"` if any entry is not a valid [Id64String]($bentley).
      */
     bindIdSet(indexOrName, val) {
         this.verify(indexOrName);
         const name = String(indexOrName);
-        _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.OrderedId64Iterable.uniqueIterator(val);
+        const ids = [];
+        // `string` is an Iterable<string>. In that case assume caller passed a single Id64String, matching CompressedId64Set.sortAndCompress.
+        const iterable = typeof val === "string" ? [val] : val;
+        for (const id of iterable) {
+            if (!_itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.Id64.isValidId64(id)) {
+                _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.ITwinError.throwError({
+                    message: `QueryBinder.bindIdSet: entry ${JSON.stringify(id)} for parameter "${name}" is not a valid Id64String`,
+                    iTwinErrorId: { scope: "itwin-QueryBinder", key: "invalid-arguments" },
+                });
+            }
+            ids.push(id);
+        }
+        _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.OrderedId64Iterable.sortArray(ids);
         Object.defineProperty(this._args, name, {
             enumerable: true, value: {
                 type: QueryParamType.IdSet,
-                value: _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.CompressedId64Set.sortAndCompress(_itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.OrderedId64Iterable.uniqueIterator(val)),
+                value: _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.CompressedId64Set.compressArray(ids),
             },
         });
         return this;
@@ -31399,7 +31412,7 @@ var ExternalSourceAttachmentRole;
     /** The attached [ExternalSource]($backend) models a part of the whole. */
     ExternalSourceAttachmentRole[ExternalSourceAttachmentRole["SpecifyPart"] = 1] = "SpecifyPart";
 })(ExternalSourceAttachmentRole || (ExternalSourceAttachmentRole = {}));
-/** The *rank* for a Category
+/** The *rank* for a [Category]($backend), [SubCategory]($backend), or [DefinitionSet]($backend).
  * @public @preview
  * @extensions
  */
@@ -100475,6 +100488,7 @@ class ViewManager {
     cursor = "default";
     _viewports = [];
     decorators = [];
+    _selectedViewportChange = Promise.resolve();
     _selectedView;
     _invalidateScenes = false;
     _skipSceneCreation = false;
@@ -100602,9 +100616,16 @@ class ViewManager {
     }
     /** @internal */
     notifySelectedViewportChanged(previous, current) {
-        _IModelApp__WEBPACK_IMPORTED_MODULE_1__.IModelApp.toolAdmin.onSelectedViewportChanged(previous, current); // eslint-disable-line @typescript-eslint/no-floating-promises
+        const selectedViewportChange = _IModelApp__WEBPACK_IMPORTED_MODULE_1__.IModelApp.toolAdmin.onSelectedViewportChanged(previous, current)
+            .catch(() => undefined);
+        this._selectedViewportChange = this._selectedViewportChange.then(async () => selectedViewportChange, async () => selectedViewportChange)
+            .then(() => undefined, () => undefined);
         this.onSelectedViewportChanged.emit({ previous, current });
     }
+    /** @internal */
+    async waitForSelectedViewportChange() {
+        await this._selectedViewportChange;
+    }
     /** The "selected view" is the default for certain operations.  */
     get selectedView() { return this._selectedView; }
     /** Get the first opened view. */
@@ -186431,7 +186452,11 @@ class InteractiveTool extends Tool {
     async onPostInstall() { }
     /** Override Call to reset tool to initial state */
     async onReinitialize() { }
-    /** Invoked when the tool becomes no longer active, to perform additional cleanup logic */
+    /** Invoked when the tool becomes no longer active, to perform additional cleanup logic.
+     * Cleanup must not assume that the EditCommand associated with the tool is still active: an immediate tool may have finished or
+     * replaced it while this tool remained active. Tools must not start an EditCommand from onCleanup; ToolAdmin owns finishing the active EditCommand during tool cleanup.
+     * @note A ViewTool should never start an EditCommand. An InputCollector may start an EditCommand only if suspending a tool that supports EditManipulators (ex. SelectionTool).
+     */
     async onCleanup() { }
     /** Notification of a ViewTool or InputCollector starting and this tool is being suspended.
      * @note Applies only to PrimitiveTool and InputCollector, a ViewTool can't be suspended.
@@ -188605,23 +188630,54 @@ class ToolAdmin {
     }
     /** @internal */
     async setPrimitiveTool(newTool) {
-        if (undefined !== this._primitiveTool) {
-            await this._primitiveTool.onCleanup();
-            if (undefined !== this._editCommandHandler)
-                await this._editCommandHandler.finishCommand();
-            this._primitiveTool = undefined;
+        return this.setPrimitiveToolInternal(newTool);
+    }
+    async setPrimitiveToolInternal(newTool, pendingFinishCommand) {
+        const oldTool = this._primitiveTool;
+        let ownsOldTool = undefined === oldTool;
+        if (undefined !== oldTool) {
+            let mainError;
+            try {
+                await oldTool.onCleanup();
+            }
+            catch (err) {
+                mainError = (err instanceof Error) ? err : new Error(_itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.BentleyError.getErrorMessage(err));
+            }
+            try {
+                if (undefined !== pendingFinishCommand)
+                    await pendingFinishCommand;
+                else if (undefined !== this._editCommandHandler)
+                    await this._editCommandHandler.finishCommand();
+            }
+            catch (err) {
+                // throw finishCommand error if onCleanup succeeded, otherwise log finishCommand failure...
+                if (undefined === mainError)
+                    mainError = (err instanceof Error) ? err : new Error(_itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.BentleyError.getErrorMessage(err));
+                else
+                    _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.Logger.logError(`${_common_FrontendLoggerCategory__WEBPACK_IMPORTED_MODULE_4__.FrontendLoggerCategory.Package}.toolAdmin`, err);
+            }
+            finally {
+                // Force-clear stale tool state if either onCleanup or finishCommand failed...
+                ownsOldTool = this._primitiveTool === oldTool;
+                if (ownsOldTool)
+                    this._primitiveTool = undefined;
+            }
+            if (undefined !== mainError)
+                throw mainError;
         }
-        this._primitiveTool = newTool;
+        // Do not let a delayed transition overwrite a tool installed by a newer transition.
+        if (ownsOldTool)
+            this._primitiveTool = newTool;
     }
-    // serialize concurrent starts to avoid two tools installing simultaneously.
-    _primitiveToolStarting;
+    // Serialize primitive starts and last-viewport cleanup to avoid overlapping transitions.
+    _primitiveToolTransition;
     /** @internal */
     async startPrimitiveTool(newTool) {
         // If another start is in progress wait for it to finish before proceeding.
-        while (undefined !== this._primitiveToolStarting)
-            await this._primitiveToolStarting;
-        let resolveStarting;
-        this._primitiveToolStarting = new Promise((r) => { resolveStarting = r; });
+        while (undefined !== this._primitiveToolTransition)
+            await this._primitiveToolTransition;
+        let resolveTransition;
+        const transition = this._primitiveToolTransition = new Promise((resolve) => { resolveTransition = resolve; });
         try {
             _IModelApp__WEBPACK_IMPORTED_MODULE_5__.IModelApp.notifications.outputPrompt("");
             await this.exitViewTool();
@@ -188649,9 +188705,9 @@ class ToolAdmin {
             this.onActiveToolChanged(activeTool, StartOrResume.Start);
         }
         finally {
-            if (resolveStarting)
-                resolveStarting();
-            this._primitiveToolStarting = undefined;
+            resolveTransition?.();
+            if (this._primitiveToolTransition === transition)
+                this._primitiveToolTransition = undefined;
         }
     }
     /** Method used by interactive tools to send updated values to UI components, typically showing tool settings.
@@ -188898,10 +188954,41 @@ class ToolAdmin {
     set coordinateLockOverrides(coordLockOvr) { this.toolState.coordLockOvr = coordLockOvr; }
     /** @internal */
     async callOnCleanup() {
-        await this.exitViewTool();
-        await this.exitInputCollector();
-        if (undefined !== this._primitiveTool)
-            await this._primitiveTool.onCleanup();
+        let pendingFinishCommand;
+        const previousTransition = this._primitiveToolTransition;
+        let resolveTransition;
+        const transition = this._primitiveToolTransition = new Promise((resolve) => { resolveTransition = resolve; });
+        try {
+            // Start the edit-command cleanup before the first await. ViewManager can invoke this method
+            // without awaiting it when the last viewport is dropped.
+            if (undefined !== this._editCommandHandler) {
+                const finishCommand = this._editCommandHandler.finishCommand();
+                // Attach a rejection handler immediately: another cleanup operation may fail before this promise is awaited.
+                pendingFinishCommand = finishCommand.catch((err) => {
+                    _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.Logger.logError(`${_common_FrontendLoggerCategory__WEBPACK_IMPORTED_MODULE_4__.FrontendLoggerCategory.Package}.toolAdmin`, err);
+                    return "";
+                });
+            }
+            if (undefined !== previousTransition)
+                await previousTransition;
+            if (undefined !== this._viewTool)
+                await this.exitViewTool();
+            if (undefined !== this._inputCollector)
+                await this.exitInputCollector();
+            // Keep cleanup path consistent with other primitive-tool transitions.
+            if (undefined !== this._primitiveTool)
+                await this.setPrimitiveToolInternal(undefined, pendingFinishCommand); // NOTE: ViewManager.setSelectedView will call startDefaultTool if a new view is opened...
+            else if (undefined !== pendingFinishCommand)
+                await pendingFinishCommand;
+        }
+        catch (err) {
+            _itwin_core_bentley__WEBPACK_IMPORTED_MODULE_0__.Logger.logError(`${_common_FrontendLoggerCategory__WEBPACK_IMPORTED_MODULE_4__.FrontendLoggerCategory.Package}.toolAdmin`, err);
+        }
+        finally {
+            resolveTransition?.();
+            if (this._primitiveToolTransition === transition)
+                this._primitiveToolTransition = undefined;
+        }
     }
 }
 /**
@@ -269892,18 +269979,19 @@ class PolyfaceQuery {
      */
     static dihedralAngleSummary(source, ignoreBoundaries = false) {
         // more info can be found at geometry/internaldocs/Polyface.md
+        // visit all facets and collect normals and edges
         const edges = new _IndexedEdgeMatcher__WEBPACK_IMPORTED_MODULE_29__.IndexedEdgeMatcher();
         const vertices = source instanceof _Polyface__WEBPACK_IMPORTED_MODULE_34__.Polyface ? source.data.point : undefined;
         const visitor = source instanceof _Polyface__WEBPACK_IMPORTED_MODULE_34__.Polyface ? source.createVisitor(1) : source;
         visitor.setNumWrap(1);
-        const centroidNormal = [];
+        const facetNormals = [];
         let normalCounter = 0;
         for (visitor.reset(); visitor.moveToNextFacet();) {
             const numEdges = visitor.pointCount - 1;
             const normal = _geometry3d_PolygonOps__WEBPACK_IMPORTED_MODULE_14__.PolygonOps.centroidAreaNormal(visitor.point);
             if (normal === undefined)
                 return -2;
-            centroidNormal.push(normal);
+            facetNormals.push(normal);
             for (let i = 0; i < numEdges; i++) {
                 const edge = edges.addEdge(visitor.clientPointIndex(i), visitor.clientPointIndex(i + 1), normalCounter);
                 if (!vertices) // decorate if we don't have vertices to query later
@@ -269919,21 +270007,24 @@ class PolyfaceQuery {
         edges.sortAndCollectClusters(manifoldClusters, ignoreBoundaries ? undefined : badClusters, undefined, badClusters);
         if (badClusters.length > 0)
             return -2;
-        // find angle between facet centroid normals (dihedral angles)
+        // find angle between facet normals (dihedral angles)
         let numPositive = 0;
         let numPlanar = 0;
         let numNegative = 0;
         const edgeVector = _geometry3d_Point3dVector3d__WEBPACK_IMPORTED_MODULE_12__.Vector3d.create();
         for (const cluster of manifoldClusters) {
             if (Array.isArray(cluster) && cluster.length === 2) {
-                const sideA = cluster[0];
-                const sideB = cluster[1];
-                if (vertices)
-                    vertices.vectorIndexIndex(sideA.startVertex, sideA.endVertex, edgeVector);
-                else
+                const sideA = cluster[0]; // edge on facetA
+                const sideB = cluster[1]; // edge on facetB
+                if (vertices) {
+                    if (!vertices.vectorIndexIndex(sideA.startVertex, sideA.endVertex, edgeVector))
+                        return -2;
+                }
+                else {
                     edgeVector.setFrom(sideA.edgeVector);
-                const facetNormalA = centroidNormal[sideA.facetIndex].direction;
-                const facetNormalB = centroidNormal[sideB.facetIndex].direction;
+                }
+                const facetNormalA = facetNormals[sideA.facetIndex].direction;
+                const facetNormalB = facetNormals[sideB.facetIndex].direction;
                 const dihedralAngle = facetNormalA.signedAngleTo(facetNormalB, edgeVector);
                 if (dihedralAngle.isAlmostZero)
                     numPlanar++;
@@ -334369,7 +334460,7 @@ var loadLanguages = instance.loadLanguages;
 (module) {
 
 "use strict";
-module.exports = /*#__PURE__*/JSON.parse('{"name":"@itwin/core-frontend","version":"5.13.0-dev.10","description":"iTwin.js frontend components","main":"lib/cjs/core-frontend.js","module":"lib/esm/core-frontend.js","typings":"lib/cjs/core-frontend","license":"MIT","scripts":{"build":"npm run -s copy:public && npm run -s build:cjs && npm run -s build:esm && npm run -s build:workers && npm run -s copy:draco","build:cjs":"npm run -s copy:js:cjs && tsc 1>&2 --outDir lib/cjs","build:esm":"npm run -s copy:js:esm && tsc 1>&2 --module ES2022 --outDir lib/esm","clean":"rimraf -g lib .rush/temp/package-deps*.json","copy:public":"cpx \\"./src/public/**/*\\" ./lib/public","copy:js:cjs":"cpx \\"./src/**/*.js\\" ./lib/cjs","copy:js:esm":"cpx \\"./src/**/*.js\\" ./lib/esm","copy:draco":"cpx \\"./node_modules/@loaders.gl/draco/dist/libs/*\\" ./lib/public/scripts","docs":"betools docs --json=../../generated-docs/core/core-frontend/file.json --tsIndexFile=./core-frontend.ts --onlyJson --excludes=webgl/**/*,**/map/*.d.ts,**/tile/*.d.ts,**/*-css.ts && npm run -s extract","extract":"betools extract --fileExt=ts --extractFrom=./src/test/example-code --recursive --out=../../generated-docs/extract","extract-api":"betools extract-api --entry=core-frontend && npm run extract-extension-api","extract-extension-api":"eslint --no-inline-config -c extraction.eslint.config.js  \\"./src/**/*.ts\\" 1>&2","lint":"eslint \\"./src/**/*.ts\\" 1>&2","lint-fix":"eslint --fix -f visualstudio \\"./src/**/*.ts\\" 1>&2","lint-deprecation":"eslint --fix -f visualstudio --no-inline-config -c ../../common/config/eslint/eslint.config.deprecation-policy.js \\"./src/**/*.ts\\"","pseudolocalize":"betools pseudolocalize --englishDir ./src/public/locales/en --out ./public/locales/en-PSEUDO","test":"npm run build:test-worker && vitest --run","cover":"npm run build:test-worker && vitest --run","build:test-worker":"vite build --config ./src/test/worker/vite.config.mts 1>&2","build:workers":"rimraf lib/workers/webpack && vite build --config ./src/workers/ImdlParser/vite.config.mts 1>&2"},"repository":{"type":"git","url":"https://github.com/iTwin/itwinjs-core.git","directory":"core/frontend"},"keywords":["Bentley","BIM","iModel","digital-twin","iTwin"],"author":{"name":"Bentley Systems, Inc.","url":"http://www.bentley.com"},"peerDependencies":{"@itwin/appui-abstract":"workspace:*","@itwin/core-bentley":"workspace:*","@itwin/core-common":"workspace:*","@itwin/core-geometry":"workspace:*","@itwin/core-orbitgt":"workspace:*","@itwin/core-quantity":"workspace:*","@itwin/ecschema-metadata":"workspace:*","@itwin/ecschema-rpcinterface-common":"workspace:*"},"//devDependencies":["NOTE: All peerDependencies should also be listed as devDependencies since peerDependencies are not considered by npm install","NOTE: All tools used by scripts in this package must be listed as devDependencies"],"devDependencies":{"@bentley/aec-units-schema":"^1.0.3","@bentley/formats-schema":"^1.0.0","@bentley/units-schema":"^1.0.11","@itwin/appui-abstract":"workspace:*","@itwin/build-tools":"workspace:*","@itwin/core-bentley":"workspace:*","@itwin/core-common":"workspace:*","@itwin/core-geometry":"workspace:*","@itwin/core-orbitgt":"workspace:*","@itwin/core-quantity":"workspace:*","@itwin/ecschema-metadata":"workspace:*","@itwin/ecschema-rpcinterface-common":"workspace:*","@itwin/object-storage-core":"^3.0.4","@itwin/eslint-plugin":"^6.0.0","@types/chai-as-promised":"^7","@types/draco3d":"^1.4.10","@types/node":"~20.17.0","@types/sinon":"^17.0.2","@vitest/browser-playwright":"^4.1.10","@vitest/coverage-v8":"^4.1.10","cpx2":"^8.0.0","eslint":"^9.31.0","playwright":"~1.56.1","rimraf":"^6.0.1","sinon":"^17.0.2","typescript":"~5.6.2","vite":"^6.4.3","vitest":"^4.1.10","vite-multiple-assets":"^1.3.1","vite-plugin-static-copy":"2.2.0"},"//dependencies":["NOTE: these dependencies should be only for things that DO NOT APPEAR IN THE API","NOTE: core-frontend should remain UI technology agnostic, so no react/angular dependencies are allowed"],"dependencies":{"@itwin/core-i18n":"workspace:*","@itwin/webgl-compatibility":"workspace:*","@loaders.gl/core":"~4.3.4","@loaders.gl/draco":"~4.3.4","fuse.js":"^3.3.0","wms-capabilities":"0.4.0"}}');
+module.exports = /*#__PURE__*/JSON.parse('{"name":"@itwin/core-frontend","version":"5.13.0-dev.12","description":"iTwin.js frontend components","main":"lib/cjs/core-frontend.js","module":"lib/esm/core-frontend.js","typings":"lib/cjs/core-frontend","license":"MIT","scripts":{"build":"npm run -s copy:public && npm run -s build:cjs && npm run -s build:esm && npm run -s build:workers && npm run -s copy:draco","build:cjs":"npm run -s copy:js:cjs && tsc 1>&2 --outDir lib/cjs","build:esm":"npm run -s copy:js:esm && tsc 1>&2 --module ES2022 --outDir lib/esm","clean":"rimraf -g lib .rush/temp/package-deps*.json","copy:public":"cpx \\"./src/public/**/*\\" ./lib/public","copy:js:cjs":"cpx \\"./src/**/*.js\\" ./lib/cjs","copy:js:esm":"cpx \\"./src/**/*.js\\" ./lib/esm","copy:draco":"cpx \\"./node_modules/@loaders.gl/draco/dist/libs/*\\" ./lib/public/scripts","docs":"betools docs --json=../../generated-docs/core/core-frontend/file.json --tsIndexFile=./core-frontend.ts --onlyJson --excludes=webgl/**/*,**/map/*.d.ts,**/tile/*.d.ts,**/*-css.ts && npm run -s extract","extract":"betools extract --fileExt=ts --extractFrom=./src/test/example-code --recursive --out=../../generated-docs/extract","extract-api":"betools extract-api --entry=core-frontend && npm run extract-extension-api","extract-extension-api":"eslint --no-inline-config -c extraction.eslint.config.js  \\"./src/**/*.ts\\" 1>&2","lint":"eslint \\"./src/**/*.ts\\" 1>&2","lint-fix":"eslint --fix -f visualstudio \\"./src/**/*.ts\\" 1>&2","lint-deprecation":"eslint --fix -f visualstudio --no-inline-config -c ../../common/config/eslint/eslint.config.deprecation-policy.js \\"./src/**/*.ts\\"","pseudolocalize":"betools pseudolocalize --englishDir ./src/public/locales/en --out ./public/locales/en-PSEUDO","test":"npm run build:test-worker && vitest --run","cover":"npm run build:test-worker && vitest --run","build:test-worker":"vite build --config ./src/test/worker/vite.config.mts 1>&2","build:workers":"rimraf lib/workers/webpack && vite build --config ./src/workers/ImdlParser/vite.config.mts 1>&2"},"repository":{"type":"git","url":"https://github.com/iTwin/itwinjs-core.git","directory":"core/frontend"},"keywords":["Bentley","BIM","iModel","digital-twin","iTwin"],"author":{"name":"Bentley Systems, Inc.","url":"http://www.bentley.com"},"peerDependencies":{"@itwin/appui-abstract":"workspace:*","@itwin/core-bentley":"workspace:*","@itwin/core-common":"workspace:*","@itwin/core-geometry":"workspace:*","@itwin/core-orbitgt":"workspace:*","@itwin/core-quantity":"workspace:*","@itwin/ecschema-metadata":"workspace:*","@itwin/ecschema-rpcinterface-common":"workspace:*"},"//devDependencies":["NOTE: All peerDependencies should also be listed as devDependencies since peerDependencies are not considered by npm install","NOTE: All tools used by scripts in this package must be listed as devDependencies"],"devDependencies":{"@bentley/aec-units-schema":"^1.0.3","@bentley/formats-schema":"^1.0.0","@bentley/units-schema":"^1.0.11","@itwin/appui-abstract":"workspace:*","@itwin/build-tools":"workspace:*","@itwin/core-bentley":"workspace:*","@itwin/core-common":"workspace:*","@itwin/core-geometry":"workspace:*","@itwin/core-orbitgt":"workspace:*","@itwin/core-quantity":"workspace:*","@itwin/ecschema-metadata":"workspace:*","@itwin/ecschema-rpcinterface-common":"workspace:*","@itwin/object-storage-core":"^3.0.4","@itwin/eslint-plugin":"^6.0.0","@types/chai-as-promised":"^7","@types/draco3d":"^1.4.10","@types/node":"~20.17.0","@types/sinon":"^17.0.2","@vitest/browser-playwright":"^4.1.10","@vitest/coverage-v8":"^4.1.10","cpx2":"^8.0.0","eslint":"^9.31.0","playwright":"~1.56.1","rimraf":"^6.0.1","sinon":"^17.0.2","typescript":"~5.6.2","vite":"^6.4.3","vitest":"^4.1.10","vite-multiple-assets":"^1.3.1","vite-plugin-static-copy":"2.2.0"},"//dependencies":["NOTE: these dependencies should be only for things that DO NOT APPEAR IN THE API","NOTE: core-frontend should remain UI technology agnostic, so no react/angular dependencies are allowed"],"dependencies":{"@itwin/core-i18n":"workspace:*","@itwin/webgl-compatibility":"workspace:*","@loaders.gl/core":"~4.3.4","@loaders.gl/draco":"~4.3.4","fuse.js":"^3.3.0","wms-capabilities":"0.4.0"}}');
 
 /***/ }