@itwin/core-geometry 5.11.0-dev.5 → 5.11.0-dev.7

package/lib/cjs/curve/internalContexts/CurveCurveIntersectXY.js

@@ -294,14 +294,14 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         const cosines = new GrowableFloat64Array_1.GrowableFloat64Array(2);
         const sines = new GrowableFloat64Array_1.GrowableFloat64Array(2);
         const radians = new GrowableFloat64Array_1.GrowableFloat64Array(2);
-        // Arc: X = C + cU + sV
+        // Arc:  X(theta) = C + cos(theta)·U + sin(theta)·V
         // Line:  contains points A0,A1
-        // Arc point colinear with line if det (A0, A1, X) = 0
-        // with homogeneous xyw points and vectors.
-        // With equational X: det (A0, A1, C) + c det (A0, A1,U) + s det (A0, A1, V) = 0.
-        // solve for theta.
-        // evaluate points.
-        // project back to line.
+        // Arc point X is colinear (intersects) with line if det(A0, A1, X) = 0 with homogeneous xyw points and vectors
+        // This leads to
+        // det(A0, A1, C) + cos(theta) det(A0, A1, U) + sin(theta) det(A0, A1, V) = 0
+        // or
+        // alpha + beta cos(theta) + gamma sin(theta) = 0
+        // solve for theta; evaluate points; project back to line
         if (this._worldToLocalPerspective) {
             const data = arc.toTransformedPoint4d(this._worldToLocalPerspective);
             const radians0 = data.sweep.fractionToRadians(0);
@@ -313,7 +313,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             const alpha = Geometry_1.Geometry.tripleProductPoint4dXYW(pointA0H, pointA1H, data.center);
             const beta = Geometry_1.Geometry.tripleProductPoint4dXYW(pointA0H, pointA1H, data.vector0);
             const gamma = Geometry_1.Geometry.tripleProductPoint4dXYW(pointA0H, pointA1H, data.vector90);
-            let numRoots = Polynomials_1.AnalyticRoots.appendImplicitLineUnitCircleIntersections(alpha, beta, gamma, cosines, sines, radians);
+            let numRoots = Polynomials_1.AnalyticRoots.appendImplicitLineUnitCircleIntersections(alpha, beta, gamma, cosines, sines, radians, tol2);
             const closeApproach = (0 === numRoots);
             if (closeApproach)
                 numRoots = 1; // we returned the arc's closest approach as the first "root"; if within tolerance and at endpoints, we record it
@@ -354,7 +354,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             const alpha = Geometry_1.Geometry.tripleProductXYW(pointA0Local, 1, pointA1Local, 1, data.center, 1);
             const beta = Geometry_1.Geometry.tripleProductXYW(pointA0Local, 1, pointA1Local, 1, data.vector0, 0);
             const gamma = Geometry_1.Geometry.tripleProductXYW(pointA0Local, 1, pointA1Local, 1, data.vector90, 0);
-            let numRoots = Polynomials_1.AnalyticRoots.appendImplicitLineUnitCircleIntersections(alpha, beta, gamma, cosines, sines, radians);
+            let numRoots = Polynomials_1.AnalyticRoots.appendImplicitLineUnitCircleIntersections(alpha, beta, gamma, cosines, sines, radians, tol2);
             const closeApproach = (0 === numRoots);
             if (closeApproach)
                 numRoots = 1; // we returned the arc's closest approach as the first "root"; if within tolerance and at endpoints, we record it