@itwin/core-geometry 4.3.0-dev.21 → 4.3.0-dev.23

package/lib/cjs/curve/internalContexts/CurveCurveIntersectXY.d.ts

@@ -1,9 +1,7 @@
-import { BezierCurveBase } from "../../bspline/BezierCurveBase";
 import { BSplineCurve3d } from "../../bspline/BSplineCurve";
 import { BSplineCurve3dH } from "../../bspline/BSplineCurve3dH";
 import { RecurseToCurvesGeometryHandler } from "../../geometry3d/GeometryHandler";
 import { Matrix4d } from "../../geometry4d/Matrix4d";
-import { NewtonEvaluatorRRtoRRD } from "../../numerics/Newton";
 import { Arc3d } from "../Arc3d";
 import { CurveChainWithDistanceIndex } from "../CurveChainWithDistanceIndex";
 import { CurveLocationDetailPair } from "../CurveLocationDetail";
@@ -11,19 +9,6 @@ import { CurvePrimitive } from "../CurvePrimitive";
 import { AnyCurve } from "../CurveTypes";
 import { LineSegment3d } from "../LineSegment3d";
 import { LineString3d } from "../LineString3d";
-/**
- * Private class for refining bezier-bezier intersections.
- * * The inputs are assumed pre-transformed so that the target condition is to match x and y coordinates.
- * @internal
- */
-export declare class BezierBezierIntersectionXYRRToRRD extends NewtonEvaluatorRRtoRRD {
-    private _curveA;
-    private _curveB;
-    private _rayA;
-    private _rayB;
-    constructor(curveA: BezierCurveBase, curveB: BezierCurveBase);
-    evaluate(fractionA: number, fractionB: number): boolean;
-}
 /**
  * Handler class for XY intersections between _geometryB and another geometry.
  * * Instances are initialized and called from CurveCurve.
@@ -105,7 +90,20 @@ export declare class CurveCurveIntersectXY extends RecurseToCurvesGeometryHandle
     private computeSegmentSegment3DH;
     private dispatchSegmentSegment;
     private dispatchSegmentArc;
+    /**
+     * Compute the intersection of two xy-arcs.
+     * * Each matrix has [U V C] in (x,y,w) form from homogeneous projection (local to world).
+     * * Arcs are ordered so that matrixA is better conditioned.
+     */
     private dispatchArcArcThisOrder;
+    /**
+     * We have 2 xy-arcs.
+     * 1- We pick the arc that is closest to circular (larger condition number is closer to circular).
+     * 2- Transform it to local coords, where it becomes the unit xy-circle.
+     * 3- Use the same map to transform the other arc.
+     * 4- Find the intersection of arc and unit circle.
+     * 5- Convert intersection angles to fractions and record intersections.
+     */
     private dispatchArcArc;
     private dispatchArcBsplineCurve3d;
     /** Apply the transformation to bezier curves. Optionally construct ranges. */
@@ -132,7 +130,7 @@ export declare class CurveCurveIntersectXY extends RecurseToCurvesGeometryHandle
     private static setTransformedWorkPoints;
     /** Low level dispatch of curve collection. */
     private dispatchCurveCollection;
-    /** Low level dispatch to geomA given a CurveChainWithDistanceIndex in geometryB. */
+    /** Low level dispatch of CurveChainWithDistanceIndex. */
     private dispatchCurveChainWithDistanceIndex;
     /** Double dispatch handler for strongly typed segment. */
     handleLineSegment3d(segmentA: LineSegment3d): any;

package/lib/cjs/curve/internalContexts/CurveCurveIntersectXY.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"CurveCurveIntersectXY.d.ts","sourceRoot":"","sources":["../../../../src/curve/internalContexts/CurveCurveIntersectXY.ts"],"names":[],"mappings":"AAWA,OAAO,EAAE,eAAe,EAAE,MAAM,+BAA+B,CAAC;AAChE,OAAO,EAAE,cAAc,EAAsB,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,eAAe,EAAE,MAAM,+BAA+B,CAAC;AAGhE,OAAO,EAAE,8BAA8B,EAAE,MAAM,kCAAkC,CAAC;AASlF,OAAO,EAAE,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AAGrD,OAAO,EAAmC,sBAAsB,EAAE,MAAM,uBAAuB,CAAC;AAEhG,OAAO,EAAE,KAAK,EAAE,MAAM,UAAU,CAAC;AACjC,OAAO,EAAE,2BAA2B,EAAE,MAAM,gCAAgC,CAAC;AAE7E,OAAO,EAA0C,uBAAuB,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AACnD,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjD,OAAO,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAC;AAI/C;;;;GAIG;AACH,qBAAa,iCAAkC,SAAQ,sBAAsB;IAC3E,OAAO,CAAC,OAAO,CAAkB;IACjC,OAAO,CAAC,OAAO,CAAkB;IACjC,OAAO,CAAC,KAAK,CAAQ;IACrB,OAAO,CAAC,KAAK,CAAQ;gBACT,MAAM,EAAE,eAAe,EAAE,MAAM,EAAE,eAAe;IAOrD,QAAQ,CAAC,SAAS,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO;CAU/D;AACD;;;;;GAKG;AACH,qBAAa,qBAAsB,SAAQ,8BAA8B;IACvE,OAAO,CAAC,QAAQ,CAAU;IAC1B,OAAO,CAAC,UAAU,CAAuB;IACzC,OAAO,CAAC,QAAQ,CAAU;IAC1B,OAAO,CAAC,QAAQ,CAA4B;IAC5C,OAAO,CAAC,wBAAwB,CAAuB;IACvD,OAAO,CAAC,mBAAmB,CAAwB;IACnD,OAAO,CAAC,0BAA0B,CAA0B;IAC5D,OAAO,CAAC,MAAM,CAAC,cAAc,CAAqB;IAClD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,OAAO,CAAC,CAAU;IAC1B,OAAO,CAAC,OAAO,CAAC,CAAU;IAC1B,OAAO,CAAC,UAAU,CAAC,CAAU;IAC7B,OAAO,CAAC,MAAM,CAAC,CAAU;IACzB;;;;;;;OAOG;gBAED,YAAY,EAAE,QAAQ,GAAG,SAAS,EAClC,OAAO,EAAE,OAAO,EAChB,SAAS,EAAE,QAAQ,GAAG,SAAS,EAC/B,OAAO,EAAE,OAAO,EAChB,SAAS,GAAE,MAAqC;IAgBlD,wGAAwG;IACjG,aAAa,CAAC,SAAS,EAAE,QAAQ,GAAG,IAAI;IAG/C,OAAO,CAAC,cAAc;IAOtB,yFAAyF;IACzF,OAAO,CAAC,oBAAoB;IAc5B;;;OAGG;IACI,iBAAiB,CAAC,YAAY,GAAE,OAAe,GAAG,uBAAuB,EAAE;IAMlF;;;;;;;;;;;;OAYG;IACH,OAAO,CAAC,6BAA6B;IA4DrC;;;;;;OAMG;IACI,WAAW,CAChB,GAAG,EAAE,cAAc,EAAE,GAAG,EAAE,cAAc,EAAE,KAAK,EAAE,uBAAuB,EAAE,GAAG,SAAS,EAAE,QAAQ,EAAE,OAAO,GACxG,IAAI;IASP,0GAA0G;IAC1G,OAAO,CAAC,uBAAuB;IAkC/B;;;OAGG;IACH,OAAO,CAAC,wBAAwB;IAyChC,OAAO,CAAC,sBAAsB;IA4C9B,OAAO,CAAC,kBAAkB;IAuF1B,OAAO,CAAC,uBAAuB;IAgC/B,OAAO,CAAC,cAAc;IA+CtB,OAAO,CAAC,yBAAyB;IA2EjC,8EAA8E;IAC9E,OAAO,CAAC,gBAAgB;IAOxB,OAAO,CAAC,SAAS;IAQjB,OAAO,CAAC,+BAA+B;IA6FvC,OAAO,CAAC,oCAAoC;IAgC5C;;;;OAIG;IACH,OAAO,CAAC,YAAY;IAOpB,OAAO,CAAC,kBAAkB;IAiB1B,OAAO,CAAC,2BAA2B;IAkCnC,0EAA0E;IACnE,8BAA8B,CACnC,GAAG,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,cAAc,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,GAC/F,GAAG;IAoBN,8DAA8D;IACvD,wBAAwB,CAC7B,GAAG,EAAE,aAAa,EAAE,OAAO,EAAE,OAAO,EAAE,GAAG,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,GAC3F,GAAG;IAwBN,0DAA0D;IACnD,oBAAoB,CACzB,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,OAAO,EAAE,GAAG,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,GACpF,GAAG;IAqBN,iEAAiE;IACjE,OAAO,CAAC,2BAA2B;IAmCnC,OAAO,CAAC,MAAM,CAAC,wBAAwB;IAQvC,8CAA8C;IAC9C,OAAO,CAAC,uBAAuB;IAU/B,oFAAoF;IACpF,OAAO,CAAC,mCAAmC;IAgB3C,0DAA0D;IAC1C,mBAAmB,CAAC,QAAQ,EAAE,aAAa,GAAG,GAAG;IA2BjE,6DAA6D;IAC7C,kBAAkB,CAAC,GAAG,EAAE,YAAY,GAAG,GAAG;IAiB1D,sDAAsD;IACtC,WAAW,CAAC,IAAI,EAAE,KAAK,GAAG,GAAG;IAmB7C,gEAAgE;IAChD,oBAAoB,CAAC,KAAK,EAAE,cAAc,GAAG,GAAG;IAmBhE,8EAA8E;IAC9D,iCAAiC,CAAC,KAAK,EAAE,2BAA2B,GAAG,GAAG;IAK1F,8EAA8E;IAC9D,qBAAqB,CAAC,MAAM,EAAE,eAAe,GAAG,GAAG;CAgBpE"}
+{"version":3,"file":"CurveCurveIntersectXY.d.ts","sourceRoot":"","sources":["../../../../src/curve/internalContexts/CurveCurveIntersectXY.ts"],"names":[],"mappings":"AAYA,OAAO,EAAE,cAAc,EAAsB,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,eAAe,EAAE,MAAM,+BAA+B,CAAC;AAGhE,OAAO,EAAE,8BAA8B,EAAE,MAAM,kCAAkC,CAAC;AAQlF,OAAO,EAAE,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AAKrD,OAAO,EAAE,KAAK,EAAE,MAAM,UAAU,CAAC;AACjC,OAAO,EAAE,2BAA2B,EAAE,MAAM,gCAAgC,CAAC;AAE7E,OAAO,EAA0C,uBAAuB,EAAE,MAAM,wBAAwB,CAAC;AACzG,OAAO,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AACnD,OAAO,EAAE,QAAQ,EAAE,MAAM,eAAe,CAAC;AACzC,OAAO,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjD,OAAO,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAC;AAG/C;;;;;GAKG;AACH,qBAAa,qBAAsB,SAAQ,8BAA8B;IACvE,OAAO,CAAC,QAAQ,CAAU;IAC1B,OAAO,CAAC,UAAU,CAAuB;IACzC,OAAO,CAAC,QAAQ,CAAU;IAC1B,OAAO,CAAC,QAAQ,CAA4B;IAC5C,OAAO,CAAC,wBAAwB,CAAuB;IACvD,OAAO,CAAC,mBAAmB,CAAwB;IACnD,OAAO,CAAC,0BAA0B,CAA0B;IAC5D,OAAO,CAAC,MAAM,CAAC,cAAc,CAAqB;IAClD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,aAAa,CAAoB;IAChD,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,MAAM,CAAC,YAAY,CAAoB;IAC/C,OAAO,CAAC,OAAO,CAAC,CAAU;IAC1B,OAAO,CAAC,OAAO,CAAC,CAAU;IAC1B,OAAO,CAAC,UAAU,CAAC,CAAU;IAC7B,OAAO,CAAC,MAAM,CAAC,CAAU;IACzB;;;;;;;OAOG;gBAED,YAAY,EAAE,QAAQ,GAAG,SAAS,EAClC,OAAO,EAAE,OAAO,EAChB,SAAS,EAAE,QAAQ,GAAG,SAAS,EAC/B,OAAO,EAAE,OAAO,EAChB,SAAS,GAAE,MAAqC;IAgBlD,wGAAwG;IACjG,aAAa,CAAC,SAAS,EAAE,QAAQ,GAAG,IAAI;IAG/C,OAAO,CAAC,cAAc;IAOtB,yFAAyF;IACzF,OAAO,CAAC,oBAAoB;IAc5B;;;OAGG;IACI,iBAAiB,CAAC,YAAY,GAAE,OAAe,GAAG,uBAAuB,EAAE;IAMlF;;;;;;;;;;;;OAYG;IACH,OAAO,CAAC,6BAA6B;IA4DrC;;;;;;OAMG;IACI,WAAW,CAChB,GAAG,EAAE,cAAc,EAAE,GAAG,EAAE,cAAc,EAAE,KAAK,EAAE,uBAAuB,EAAE,GAAG,SAAS,EAAE,QAAQ,EAAE,OAAO,GACxG,IAAI;IASP,0GAA0G;IAC1G,OAAO,CAAC,uBAAuB;IAyC/B;;;OAGG;IACH,OAAO,CAAC,wBAAwB;IAyChC,OAAO,CAAC,sBAAsB;IA4C9B,OAAO,CAAC,kBAAkB;IAmF1B;;;;OAIG;IACH,OAAO,CAAC,uBAAuB;IAiC/B;;;;;;;OAOG;IACH,OAAO,CAAC,cAAc;IAyCtB,OAAO,CAAC,yBAAyB;IA2EjC,8EAA8E;IAC9E,OAAO,CAAC,gBAAgB;IAOxB,OAAO,CAAC,SAAS;IAQjB,OAAO,CAAC,+BAA+B;IA6FvC,OAAO,CAAC,oCAAoC;IAgC5C;;;;OAIG;IACH,OAAO,CAAC,YAAY;IAOpB,OAAO,CAAC,kBAAkB;IAiB1B,OAAO,CAAC,2BAA2B;IAkCnC,0EAA0E;IACnE,8BAA8B,CACnC,GAAG,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,cAAc,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,GAC/F,GAAG;IAoBN,8DAA8D;IACvD,wBAAwB,CAC7B,GAAG,EAAE,aAAa,EAAE,OAAO,EAAE,OAAO,EAAE,GAAG,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,GAC3F,GAAG;IAwBN,0DAA0D;IACnD,oBAAoB,CACzB,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,OAAO,EAAE,GAAG,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,GACpF,GAAG;IAqBN,iEAAiE;IACjE,OAAO,CAAC,2BAA2B;IAmCnC,OAAO,CAAC,MAAM,CAAC,wBAAwB;IAQvC,8CAA8C;IAC9C,OAAO,CAAC,uBAAuB;IAU/B,yDAAyD;IACzD,OAAO,CAAC,mCAAmC;IAgB3C,0DAA0D;IAC1C,mBAAmB,CAAC,QAAQ,EAAE,aAAa,GAAG,GAAG;IA2BjE,6DAA6D;IAC7C,kBAAkB,CAAC,GAAG,EAAE,YAAY,GAAG,GAAG;IAiB1D,sDAAsD;IACtC,WAAW,CAAC,IAAI,EAAE,KAAK,GAAG,GAAG;IAmB7C,gEAAgE;IAChD,oBAAoB,CAAC,KAAK,EAAE,cAAc,GAAG,GAAG;IAmBhE,8EAA8E;IAC9D,iCAAiC,CAAC,KAAK,EAAE,2BAA2B,GAAG,GAAG;IAK1F,8EAA8E;IAC9D,qBAAqB,CAAC,MAAM,EAAE,eAAe,GAAG,GAAG;CAgBpE"}

package/lib/cjs/curve/internalContexts/CurveCurveIntersectXY.js

@@ -4,7 +4,7 @@
 * See LICENSE.md in the project root for license terms and full copyright notice.
 *--------------------------------------------------------------------------------------------*/
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.CurveCurveIntersectXY = exports.BezierBezierIntersectionXYRRToRRD = void 0;
+exports.CurveCurveIntersectXY = void 0;
 /** @packageDocumentation
  * @module Curve
  */
@@ -17,7 +17,6 @@ const GrowableFloat64Array_1 = require("../../geometry3d/GrowableFloat64Array");
 const Matrix3d_1 = require("../../geometry3d/Matrix3d");
 const Point2dVector2d_1 = require("../../geometry3d/Point2dVector2d");
 const Point3dVector3d_1 = require("../../geometry3d/Point3dVector3d");
-const Ray3d_1 = require("../../geometry3d/Ray3d");
 const Point4d_1 = require("../../geometry4d/Point4d");
 const BezierPolynomials_1 = require("../../numerics/BezierPolynomials");
 const Newton_1 = require("../../numerics/Newton");
@@ -29,27 +28,6 @@ const CurveLocationDetail_1 = require("../CurveLocationDetail");
 const LineSegment3d_1 = require("../LineSegment3d");
 const LineString3d_1 = require("../LineString3d");
 // cspell:word XYRR
-/**
- * Private class for refining bezier-bezier intersections.
- * * The inputs are assumed pre-transformed so that the target condition is to match x and y coordinates.
- * @internal
- */
-class BezierBezierIntersectionXYRRToRRD extends Newton_1.NewtonEvaluatorRRtoRRD {
-    constructor(curveA, curveB) {
-        super();
-        this._curveA = curveA;
-        this._curveB = curveB;
-        this._rayA = Ray3d_1.Ray3d.createZero();
-        this._rayB = Ray3d_1.Ray3d.createZero();
-    }
-    evaluate(fractionA, fractionB) {
-        this._curveA.fractionToPointAndDerivative(fractionA, this._rayA);
-        this._curveB.fractionToPointAndDerivative(fractionB, this._rayB);
-        this.currentF.setOriginAndVectorsXYZ(this._rayB.origin.x - this._rayA.origin.x, this._rayB.origin.y - this._rayA.origin.y, 0.0, -this._rayA.direction.x, -this._rayA.direction.y, 0.0, this._rayB.direction.x, this._rayB.direction.y, 0.0);
-        return true;
-    }
-}
-exports.BezierBezierIntersectionXYRRToRRD = BezierBezierIntersectionXYRRToRRD;
 /**
  * Handler class for XY intersections between _geometryB and another geometry.
  * * Instances are initialized and called from CurveCurve.
@@ -309,44 +287,44 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             }
         }
     }
-    // Caller accesses data from two arcs.
-    // Each matrix has [U V C] in (x,y,w) form from projection.
-    // Invert the projection matrix matrixA.
-    // Apply the inverse to matrixB. Then arc b is an ellipse in the circular space of A.
-    dispatchArcArcThisOrder(cpA, matrixA, // homogeneous xyw projection !!!
-    extendA, cpB, matrixB, // homogeneous xyw projection !!!
-    extendB, reversed) {
+    /**
+     * Compute the intersection of two xy-arcs.
+     * * Each matrix has [U V C] in (x,y,w) form from homogeneous projection (local to world).
+     * * Arcs are ordered so that matrixA is better conditioned.
+     */
+    dispatchArcArcThisOrder(cpA, // arc closer to being circular
+    matrixA, extendA, cpB, matrixB, extendB, reversed) {
+        // inverseA transforms arcA to its local coordinates, where it is the unit xy-circle.
         const inverseA = matrixA.inverse();
         if (inverseA) {
-            const localB = inverseA.multiplyMatrixMatrix(matrixB); // localB->localA transform
+            // localB defines the arc formed by transforming arcB into the local coordinates of arcA
+            const localB = inverseA.multiplyMatrixMatrix(matrixB);
             const ellipseRadians = [];
             const circleRadians = [];
+            // find the intersection of the transformed arcs
             Polynomials_1.TrigPolynomial.solveUnitCircleHomogeneousEllipseIntersection(localB.coffs[2], localB.coffs[5], localB.coffs[8], // center xyw
             localB.coffs[0], localB.coffs[3], localB.coffs[6], // vector0 xyw
             localB.coffs[1], localB.coffs[4], localB.coffs[7], // vector90 xyw
             ellipseRadians, circleRadians);
+            // the intersections are transform-invariant, so the solution angles apply directly to the input arcs
             for (let i = 0; i < ellipseRadians.length; i++) {
                 const fractionA = cpA.sweep.radiansToSignedPeriodicFraction(circleRadians[i]);
                 const fractionB = cpB.sweep.radiansToSignedPeriodicFraction(ellipseRadians[i]);
-                // hm .. do we really need to check the fractions?  We know they are internal to the beziers
                 if (this.acceptFraction(extendA, fractionA, extendA) && this.acceptFraction(extendB, fractionB, extendB)) {
                     this.recordPointWithLocalFractions(fractionA, cpA, 0, 1, fractionB, cpB, 0, 1, reversed);
                 }
             }
         }
     }
-    // Caller accesses data from two arcs.
-    // Selects the best conditioned arc (in xy parts) as "circle after inversion".
-    // Solves the arc-arc equations.
+    /**
+     * We have 2 xy-arcs.
+     * 1- We pick the arc that is closest to circular (larger condition number is closer to circular).
+     * 2- Transform it to local coords, where it becomes the unit xy-circle.
+     * 3- Use the same map to transform the other arc.
+     * 4- Find the intersection of arc and unit circle.
+     * 5- Convert intersection angles to fractions and record intersections.
+     */
     dispatchArcArc(cpA, extendA, cpB, extendB, reversed) {
-        // Arc: X = C + cU + sV
-        // Line:  contains points A0,A1
-        // Arc point colinear with line if det (A0, A1, X) = 0
-        // with homogeneous xyw points and vectors.
-        // With equational X:   det (A0, A1, C) + c det (A0, A1, U) + s det (A0, A1, V) = 0.
-        // solve for theta.
-        // evaluate points.
-        // project back to line.
         let matrixA;
         let matrixB;
         if (this._worldToLocalPerspective) {
@@ -363,11 +341,12 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         }
         const conditionA = matrixA.conditionNumber();
         const conditionB = matrixB.conditionNumber();
+        // pick the arc that is closest to circular.
         if (conditionA > conditionB)
             this.dispatchArcArcThisOrder(cpA, matrixA, extendA, cpB, matrixB, extendB, reversed);
         else
             this.dispatchArcArcThisOrder(cpB, matrixB, extendB, cpA, matrixA, extendA, !reversed);
-        // overlap handling .. perspective is not handled . . .
+        // overlap handling. perspective is not handled.
         if (!this._coincidentGeometryContext) {
             // do nothing
         }
@@ -518,32 +497,32 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
                     const segmentAFraction = Polynomials_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(this._xyzwA0, this._xyzwA1, this._xyzwB);
                     if (segmentAFraction && Geometry_1.Geometry.isIn01WithTolerance(segmentAFraction, intervalTolerance)) {
                         let bezierAFraction = Geometry_1.Geometry.interpolate(f0, segmentAFraction, f1);
-                        const xyMatchingFunction = new BezierBezierIntersectionXYRRToRRD(bezierA, bezierB);
+                        // We have a near intersection at fractions on the two beziers
+                        // Iterate on the curves for a true intersection
+                        const xyMatchingFunction = new Newton_1.CurveCurveIntersectionXYRRToRRD(bezierA, bezierB);
                         const newtonSearcher = new Newton_1.Newton2dUnboundedWithDerivative(xyMatchingFunction);
                         newtonSearcher.setUV(bezierAFraction, bezierBFraction);
                         if (newtonSearcher.runIterations()) {
                             bezierAFraction = newtonSearcher.getU();
                             bezierBFraction = newtonSearcher.getV();
                         }
-                        // We have a near intersection at fractions on the two beziers !!!
-                        // Iterate on the curves for a true intersection ....
-                        // NEEDS WORK -- just accept . . .
                         const bcurveAFraction = bezierA.fractionToParentFraction(bezierAFraction);
                         const bcurveBFraction = bezierB.fractionToParentFraction(bezierBFraction);
-                        const xyzA0 = bezierA.fractionToPoint(bezierAFraction);
-                        const xyzA1 = bcurveA.fractionToPoint(bcurveAFraction);
-                        const xyzB0 = bezierB.fractionToPoint(bezierBFraction);
-                        const xyzB1 = bcurveB.fractionToPoint(bcurveBFraction);
-                        if (!xyzA0.isAlmostEqualXY(xyzA1))
-                            errors++;
-                        if (!xyzB0.isAlmostEqualXY(xyzB1))
-                            errors++;
-                        if (errors > 0 && !xyzA0.isAlmostEqual(xyzB0))
-                            errors++;
-                        if (errors > 0 && !xyzA1.isAlmostEqual(xyzB1))
-                            errors++;
-                        if (this.acceptFraction(false, bcurveAFraction, false) &&
-                            this.acceptFraction(false, bcurveBFraction, false)) {
+                        if (!"verify results") {
+                            const xyzA0 = bezierA.fractionToPoint(bezierAFraction);
+                            const xyzA1 = bcurveA.fractionToPoint(bcurveAFraction);
+                            const xyzB0 = bezierB.fractionToPoint(bezierBFraction);
+                            const xyzB1 = bcurveB.fractionToPoint(bcurveBFraction);
+                            if (!xyzA0.isAlmostEqualXY(xyzA1))
+                                errors++;
+                            if (!xyzB0.isAlmostEqualXY(xyzB1))
+                                errors++;
+                            if (errors > 0 && !xyzA0.isAlmostEqual(xyzB0))
+                                errors++;
+                            if (errors > 0 && !xyzA1.isAlmostEqual(xyzB1))
+                                errors++;
+                        }
+                        if (this.acceptFraction(false, bcurveAFraction, false) && this.acceptFraction(false, bcurveBFraction, false)) {
                             this.recordPointWithLocalFractions(bcurveAFraction, bcurveA, 0, 1, bcurveBFraction, bcurveB, 0, 1, reversed);
                         }
                     }
@@ -739,7 +718,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         }
         this._geometryB = geomB; // restore
     }
-    /** Low level dispatch to geomA given a CurveChainWithDistanceIndex in geometryB. */
+    /** Low level dispatch of CurveChainWithDistanceIndex. */
     dispatchCurveChainWithDistanceIndex(geomA, geomAHandler) {
         if (!this._geometryB || !(this._geometryB instanceof CurveChainWithDistanceIndex_1.CurveChainWithDistanceIndex))
             return;