@itwin/core-geometry 4.3.0-dev.13 → 4.3.0-dev.15

package/lib/cjs/serialization/GeometrySamples.js

@@ -1106,8 +1106,8 @@ class Sample {
      */
     static createPseudoTorusBsplineSurface(radiusU, radiusV, numU, numV, orderU, orderV) {
         const points = [];
-        const numUPole = numU + orderU - 1;
-        const numVPole = numV + orderV - 1;
+        const numUPole = numU + orderU - 1; // degreeU wrap-around poles
+        const numVPole = numV + orderV - 1; // degreeV wrap-around poles
         const uKnots = KnotVector_1.KnotVector.createUniformWrapped(numU, orderU - 1, 0, 1);
         const vKnots = KnotVector_1.KnotVector.createUniformWrapped(numV, orderV - 1, 0, 1);
         const dURadians = 2.0 * Math.PI / numU;
@@ -1126,8 +1126,8 @@ class Sample {
         }
         const result = BSplineSurface_1.BSplineSurface3d.create(points, numUPole, orderU, uKnots.knots, numVPole, orderV, vKnots.knots);
         if (result) {
-            result.setWrappable(0, KnotVector_1.BSplineWrapMode.OpenByAddingControlPoints);
-            result.setWrappable(1, KnotVector_1.BSplineWrapMode.OpenByAddingControlPoints);
+            result.setWrappable(BSplineSurface_1.UVSelect.uDirection, KnotVector_1.BSplineWrapMode.OpenByAddingControlPoints);
+            result.setWrappable(BSplineSurface_1.UVSelect.vDirection, KnotVector_1.BSplineWrapMode.OpenByAddingControlPoints);
         }
         return result;
     }
@@ -1163,10 +1163,8 @@ class Sample {
             controlPoints.push(Sample.createBsplineArc90SectionToXYZWArrays(center, axes, r0, r90, false));
         }
         const result = BSplineSurface_1.BSplineSurface3dH.createGrid(controlPoints, BSplineSurface_1.WeightStyle.WeightsSeparateFromCoordinates, 3, uKnots, 2, vKnots);
-        // if (result) {
-        // result.setWrappable(0, BSplineWrapMode.OpenByAddingControlPoints);
-        // result.setWrappable(1, BSplineWrapMode.OpenByAddingControlPoints);
-        // }
+        if (result)
+            result.setWrappable(BSplineSurface_1.UVSelect.uDirection, KnotVector_1.BSplineWrapMode.OpenByRemovingKnots);
         return result;
     }
     /** Create bspline surface on xy grid with weights. */