@itwin/core-geometry 4.2.0-dev.32 → 4.2.0-dev.33

package/lib/esm/curve/internalContexts/CurveCurveIntersectXY.js

@@ -47,15 +47,13 @@ export class BezierBezierIntersectionXYRRToRRD extends NewtonEvaluatorRRtoRRD {
  * @internal
  */
 class CurveCurveIntersectXY extends NullGeometryHandler {
-    reinitialize() {
-        this._results = [];
-    }
     /**
+     * The constructor.
      * @param worldToLocal optional transform (possibly perspective) to project to xy plane for intersection.
-     * @param extendA flag to enable using extension of the other geometry.
-     * @param geometryB second curve for intersection.  Saved for reference by specific handler methods.
+     * @param extendA flag for extension of the other geometry.
+     * @param geometryB second curve for intersection. Saved for reference by specific handler methods.
      * @param extendB flag for extension of geometryB.
-     * @param tolerance optional distance tolerance for coincidence
+     * @param tolerance optional distance tolerance for coincidence.
      */
     constructor(worldToLocal, extendA, geometryB, extendB, tolerance = Geometry.smallMetricDistance) {
         super();
@@ -70,7 +68,7 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
                 this._worldToLocalPerspective = worldToLocal.clone();
         }
         this._coincidentGeometryContext = CoincidentGeometryQuery.create(tolerance);
-        this.reinitialize();
+        this._results = [];
     }
     /** Reset the geometry and flags, leaving all other parts unchanged (and preserving accumulated intersections) */
     resetGeometry(extendA, geometryB, extendB) {
@@ -85,10 +83,7 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             return false;
         return true;
     }
-    /**
-     * Test the fraction by strict parameter, but allow toleranced distance test at ends.
-     * @param tolerance optional distance tolerance to check proximity to start/end point
-     */
+    /** Test the fraction by strict parameter, but allow toleranced distance test at ends. */
     acceptFractionOnLine(extend0, fraction, extend1, pointA, pointB, tolerance = Geometry.smallMetricDistance) {
         if (!extend0 && fraction < 0) {
             return Geometry.isDistanceWithinTol(fraction * pointA.distanceXY(pointB), tolerance);
@@ -98,25 +93,32 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         return true;
     }
     /**
-     * * Return the results structure for the intersection calculation, structured as an array of CurveLocationDetailPair
+     * Return the results structure for the intersection calculation, structured as an array of CurveLocationDetailPair
      * @param reinitialize if true, a new results structure is created for use by later calls.
      */
     grabPairedResults(reinitialize = false) {
         const result = this._results;
         if (reinitialize)
-            this.reinitialize();
+            this._results = [];
         return result;
     }
     sameCurveAndFraction(cp, fraction, detail) {
         return cp === detail.curve && Geometry.isAlmostEqualNumber(fraction, detail.fraction);
     }
     /**
-     * Compute intersection of two line segments.
-     * Filter by extension rules.
-     * Record with fraction mapping.
+     * Record the pre-computed intersection between two curves. Filter by extension rules. Record with fraction mapping.
+     * @param localFractionA intersection fraction local to the subcurve of cpA between fractionA0 and fractionA1
+     * @param cpA the first curve
+     * @param fractionA0 start of the subcurve of cpA
+     * @param fractionA1 end of the subcurve of cpA
+     * @param localFractionB intersection fraction local to the subcurve of cpB between fractionB0 and fractionB1
+     * @param cpB the second curve
+     * @param fractionB0 start of the subcurve of cpB
+     * @param fractionB1 end of the subcurve of cpB
+     * @param reversed whether to reverse the details in the recorded intersection pair
+     * @param intervalDetails optional data for a coincident segment intersection
      */
-    recordPointWithLocalFractions(localFractionA, cpA, fractionA0, fractionA1, localFractionB, // Computed intersection fraction
-    cpB, fractionB0, fractionB1, reversed, intervalDetails) {
+    recordPointWithLocalFractions(localFractionA, cpA, fractionA0, fractionA1, localFractionB, cpB, fractionB0, fractionB1, reversed, intervalDetails) {
         let globalFractionA, globalFractionB;
         let globalFractionA1, globalFractionB1;
         const isInterval = intervalDetails !== undefined &&
@@ -132,7 +134,7 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             globalFractionA = globalFractionA1 = Geometry.interpolate(fractionA0, localFractionA, fractionA1);
             globalFractionB = globalFractionB1 = Geometry.interpolate(fractionB0, localFractionB, fractionB1);
         }
-        // ignore duplicate of most recent point .  ..
+        // ignore duplicate of most recent pair
         const numPrevious = this._results.length;
         if (numPrevious > 0 && !isInterval) {
             const oldDetailA = this._results[numPrevious - 1].detailA;
@@ -166,10 +168,10 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
     }
     /**
-     * Emit recordPoint for multiple pairs (on full curve!)
-     * @param cpA first curve primitive (possibly different from curve in detailA, but fraction compatible)
-     * @param cpB second curve primitive (possibly different from curve in detailA, but fraction compatible)
-     * @param pairs array of pairs
+     * Emit recordPoint for multiple pairs (on full curve).
+     * @param cpA first curve primitive (possibly different from curve in detailA, but fraction compatible).
+     * @param cpB second curve primitive (possibly different from curve in detailA, but fraction compatible).
+     * @param pairs array of pairs.
      * @param reversed true to have order reversed in final structures.
      */
     recordPairs(cpA, cpB, pairs, reversed) {
@@ -179,11 +181,7 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             }
         }
     }
-    /**
-     * Compute intersection of two line segments.
-     * Filter by extension rules.
-     * Record with fraction mapping.
-     */
+    /** Compute intersection of two line segments. Filter by extension rules. Record with fraction mapping. */
     computeSegmentSegment3D(cpA, extendA0, pointA0, fractionA0, pointA1, fractionA1, extendA1, cpB, extendB0, pointB0, fractionB0, pointB1, fractionB1, extendB1, reversed) {
         const uv = CurveCurveIntersectXY._workVector2dA;
         // Problem: Normal practice is to do the (quick, simple) transverse intersection first
@@ -201,7 +199,10 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             }
         }
     }
-    // intersection of PROJECTED homogeneous segments ...  assumes caller knows the _worldToLocal is present
+    /**
+     * Compute intersection of projected homogeneous line segments. Filter by extension rules. Record with
+     * fraction mapping. Assumes caller knows the _worldToLocal is present.
+     */
     computeSegmentSegment3DH(cpA, extendA0, pointA0, fractionA0, pointA1, fractionA1, extendA1, cpB, extendB0, pointB0, fractionB0, pointB1, fractionB1, extendB1, reversed) {
         const hA0 = CurveCurveIntersectXY._workPointA0H;
         const hA1 = CurveCurveIntersectXY._workPointA1H;
@@ -222,8 +223,8 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
     }
     // Caller accesses data from a line segment and passes to here.
-    // (The line segment in question might be (a) a full line segment or (b) a fragment within a linestring.
-    // The fraction and extend parameters allow all combinations to be passed in)
+    // The line segment in question might be (a) a full line segment or (b) a fragment within a linestring.
+    // The fraction and extend parameters allow all combinations to be passed in.
     // This method applies transform.
     dispatchSegmentSegment(cpA, extendA0, pointA0, fractionA0, pointA1, fractionA1, extendA1, cpB, extendB0, pointB0, fractionB0, pointB1, fractionB1, extendB1, reversed) {
         if (this._worldToLocalAffine) {
@@ -239,14 +240,14 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
     }
     // Caller accesses data from a linestring or segment and passes it here.
-    // (The line segment in question might be (a) a full line segment or (b) a fragment within a linestring.
-    // The fraction and extend parameters allow all combinations to be passed in)
+    // The line segment in question might be (a) a full line segment or (b) a fragment within a linestring.
+    // The fraction and extend parameters allow all combinations to be passed in.
     dispatchSegmentArc(cpA, extendA0, pointA0, fractionA0, pointA1, fractionA1, extendA1, arc, extendB0, extendB1, reversed) {
         // Arc: X = C + cU + sV
         // Line:  contains points A0,A1
         // Arc point colinear with line if det (A0, A1, X) = 0
         // with homogeneous xyw points and vectors.
-        // With equational X:   det (A0, A1, C) + c det (A0, A1,U) + s det (A0, A1, V) = 0.
+        // With equational X: det (A0, A1, C) + c det (A0, A1,U) + s det (A0, A1, V) = 0.
         // solve for theta.
         // evaluate points.
         // project back to line.
@@ -302,9 +303,9 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
     }
     // Caller accesses data from two arcs.
-    // each matrix has [U V C] in (x,y,w) form from projection.
-    // invert the projection matrix matrixA.
-    // apply the inverse to matrixB. Then arc b is an ellipse in the circular space of A
+    // Each matrix has [U V C] in (x,y,w) form from projection.
+    // Invert the projection matrix matrixA.
+    // Apply the inverse to matrixB. Then arc b is an ellipse in the circular space of A.
     dispatchArcArcThisOrder(cpA, matrixA, // homogeneous xyw projection !!!
     extendA, cpB, matrixB, // homogeneous xyw projection !!!
     extendB, reversed) {
@@ -328,8 +329,8 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
     }
     // Caller accesses data from two arcs.
-    // Selects the best conditioned arc (in xy parts) as "circle after inversion"
-    // Solves the arc-arc equations
+    // Selects the best conditioned arc (in xy parts) as "circle after inversion".
+    // Solves the arc-arc equations.
     dispatchArcArc(cpA, extendA, cpB, extendB, reversed) {
         // Arc: X = C + cU + sV
         // Line:  contains points A0,A1
@@ -375,9 +376,6 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
                 this.recordPairs(cpA, cpB, pairs, reversed);
         }
     }
-    // Caller accesses data from two arcs.
-    // Selects the best conditioned arc (in xy parts) as "circle after inversion"
-    // Solves the arc-arc equations
     dispatchArcBsplineCurve3d(cpA, extendA, cpB, extendB, reversed) {
         // Arc: X = C + cU + sV
         // implicitize the arc as viewed.  This "3d" matrix is homogeneous "XYW" not "xyz"
@@ -448,7 +446,7 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             }
         }
     }
-    /** Apply the transformation to bezier curves. optionally construct ranges. */
+    /** Apply the transformation to bezier curves. Optionally construct ranges. */
     transformBeziers(beziers) {
         if (this._worldToLocalAffine) {
             for (const bezier of beziers)
@@ -488,8 +486,9 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             const s = bcurvePoint4d.dotProductXYZW(ayx, ayy, ayz, ayw);
             const arcFraction = cpA.sweep.radiansToSignedPeriodicFraction(Math.atan2(s, c));
             if (this.acceptFraction(extendA, arcFraction, extendA) && this.acceptFraction(extendB, fractionB, extendB)) {
-              this.recordPointWithLocalFractions(arcFraction, cpA, 0, 1,
-                fractionB, cpB, 0, 1, reversed);
+              this.recordPointWithLocalFractions(
+                arcFraction, cpA, 0, 1, fractionB, cpB, 0, 1, reversed,
+              );
             }
           }
         */
@@ -505,7 +504,7 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             bezierB.poleProductsXYZW(univariateBezierB.coffs, this._xyzwPlane.x, this._xyzwPlane.y, this._xyzwPlane.z, this._xyzwPlane.w);
             let errors = 0;
             const roots = univariateBezierB.roots(0.0, true);
-            if (roots)
+            if (roots) {
                 for (const r of roots) {
                     let bezierBFraction = r;
                     bezierB.fractionToPoint4d(bezierBFraction, this._xyzwB);
@@ -542,11 +541,9 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
                         }
                     }
                 }
+            }
         }
     }
-    // Caller accesses data from two arcs.
-    // Selects the best conditioned arc (in xy parts) as "circle after inversion"
-    // Solves the arc-arc equations
     dispatchBSplineCurve3dBSplineCurve3d(bcurveA, bcurveB, _reversed) {
         const bezierSpanA = bcurveA.collectBezierSpans(true);
         const bezierSpanB = bcurveB.collectBezierSpans(true);
@@ -574,9 +571,9 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
     }
     /**
-     * Apply the projection transform (if any) to (xyz, w)
+     * Apply the projection transform (if any) to (xyz, w).
      * @param xyz xyz parts of input point.
-     * @param w weight to use for homogeneous effects
+     * @param w weight to use for homogeneous effects.
      */
     projectPoint(xyz, w = 1.0) {
         if (this._worldToLocalPerspective)
@@ -601,9 +598,9 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
             npcPlane.clone(worldPlane);
         }
     }
-    // Caller accesses data from segment and bsplineCurve
-    // Selects the best conditioned arc (in xy parts) as "circle after inversion"
-    // Solves the arc-arc equations
+    // Caller accesses data from segment and bsplineCurve.
+    // Selects the best conditioned arc (in xy parts) as "circle after inversion".
+    // Solves the arc-arc equations.
     dispatchSegmentBsplineCurve(cpA, extendA0, pointA0, fractionA0, pointA1, fractionA1, extendA1, bcurve, extendB, reversed) {
         const pointA0H = this.projectPoint(pointA0);
         const pointA1H = this.projectPoint(pointA1);
@@ -685,6 +682,38 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         }
         return undefined;
     }
+    /** Detail computation for linestring intersecting linestring. */
+    computeLineStringLineString(lsA, lsB, reversed) {
+        const pointA0 = CurveCurveIntersectXY._workPointAA0;
+        const pointA1 = CurveCurveIntersectXY._workPointAA1;
+        const pointB0 = CurveCurveIntersectXY._workPointBB0;
+        const pointB1 = CurveCurveIntersectXY._workPointBB1;
+        const numA = lsA.numPoints();
+        const numB = lsB.numPoints();
+        if (numA > 1 && numB > 1) {
+            lsA.pointAt(0, pointA0);
+            const dfA = 1.0 / (numA - 1);
+            const dfB = 1.0 / (numB - 1);
+            let fA0 = 0.0;
+            let fB0;
+            let fA1;
+            let fB1;
+            const extendA = this._extendA;
+            const extendB = this._extendB;
+            lsA.pointAt(0, pointA0);
+            for (let ia = 1; ia < numA; ia++, pointA0.setFrom(pointA1), fA0 = fA1) {
+                fA1 = ia * dfA;
+                fB0 = 0.0;
+                lsA.pointAt(ia, pointA1);
+                lsB.pointAt(0, pointB0);
+                for (let ib = 1; ib < numB; ib++, pointB0.setFrom(pointB1), fB0 = fB1) {
+                    lsB.pointAt(ib, pointB1);
+                    fB1 = ib * dfB;
+                    this.dispatchSegmentSegment(lsA, ia === 1 && extendA, pointA0, fA0, pointA1, fA1, (ia + 1) === numA && extendA, lsB, ib === 1 && extendB, pointB0, fB0, pointB1, fB1, (ib + 1) === numB && extendB, reversed);
+                }
+            }
+        }
+    }
     static setTransformedWorkPoints(transform, pointA0, pointA1, pointB0, pointB1) {
         transform.multiplyPoint3d(pointA0, this._workPointA0);
         transform.multiplyPoint3d(pointA1, this._workPointA1);
@@ -706,40 +735,13 @@ class CurveCurveIntersectXY extends NullGeometryHandler {
         else if (this._geometryB instanceof BSplineCurve3d) {
             this.dispatchSegmentBsplineCurve(segmentA, this._extendA, segmentA.point0Ref, 0.0, segmentA.point1Ref, 1.0, this._extendA, this._geometryB, this._extendB, false);
         }
+        return undefined;
     }
     /** Double dispatch handler for strongly typed linestring. */
     handleLineString3d(lsA) {
         if (this._geometryB instanceof LineString3d) {
             const lsB = this._geometryB;
-            const pointA0 = CurveCurveIntersectXY._workPointAA0;
-            const pointA1 = CurveCurveIntersectXY._workPointAA1;
-            const pointB0 = CurveCurveIntersectXY._workPointBB0;
-            const pointB1 = CurveCurveIntersectXY._workPointBB1;
-            const numA = lsA.numPoints();
-            const numB = lsB.numPoints();
-            if (numA > 1 && numB > 1) {
-                lsA.pointAt(0, pointA0);
-                const dfA = 1.0 / (numA - 1);
-                const dfB = 1.0 / (numB - 1);
-                let fA0 = 0.0;
-                let fB0;
-                let fA1;
-                let fB1;
-                const extendA = this._extendA;
-                const extendB = this._extendB;
-                lsA.pointAt(0, pointA0);
-                for (let ia = 1; ia < numA; ia++, pointA0.setFrom(pointA1), fA0 = fA1) {
-                    fA1 = ia * dfA;
-                    fB0 = 0.0;
-                    lsA.pointAt(ia, pointA1);
-                    lsB.pointAt(0, pointB0);
-                    for (let ib = 1; ib < numB; ib++, pointB0.setFrom(pointB1), fB0 = fB1) {
-                        lsB.pointAt(ib, pointB1);
-                        fB1 = ib * dfB;
-                        this.dispatchSegmentSegment(lsA, ia === 1 && extendA, pointA0, fA0, pointA1, fA1, (ia + 1) === numA && extendA, lsB, ib === 1 && extendB, pointB0, fB0, pointB1, fB1, (ib + 1) === numB && extendB, false);
-                    }
-                }
-            }
+            this.computeLineStringLineString(lsA, lsB, false);
         }
         else if (this._geometryB instanceof LineSegment3d) {
             this.computeSegmentLineString(this._geometryB, this._extendB, lsA, this._extendA, true);